[v2] qemu-img convert: Fix abort with unaligned image size

[PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size

Kevin Wolf posted 2 patches 3 years, 9 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Test docker-mingw@fedora passed

Test FreeBSD passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200716142601.111237-1-kwolf@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block.c            | 16 ++++++++++++++++
block/file-posix.c | 26 +++++++++++++++++++++++++-
2 files changed, 41 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size

Posted by Kevin Wolf 3 years, 9 months ago

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1834646

Patch 1 fixes the assertion failure by failing gracefully when opening
an image whose size isn't aligned to the required request alignment.

Patch 2 relaxes the restrictions for NFS, which actually supports byte
alignment, but incorrectly gets a 4k request alignment in the file-posix
block driver.

v2:
- Don't fail opening unaligned images, but requesting WRITE permission
  without RESIZE. This keeps qcow2 images with unaligned metadata at EOF
  working. [Max]

Kevin Wolf (2):
  block: Require aligned image size to avoid assertion failure
  file-posix: Allow byte-aligned O_DIRECT with NFS

 block.c            | 16 ++++++++++++++++
 block/file-posix.c | 26 +++++++++++++++++++++++++-
 2 files changed, 41 insertions(+), 1 deletion(-)

-- 
2.25.4