configure: Fix for running with --enable-werror on macOS

[PATCH] configure: Fix for running with --enable-werror on macOS

Posted by Thomas Huth 3 years, 9 months ago

The configure script currently refuses to succeed when run on macOS
with --enable-werror:

 ERROR: configure test passed without -Werror but failed with -Werror.

The information in config.log indicates:

 config-temp/qemu-conf.c:3:55: error: control reaches end of non-void
 function [-Werror,-Wreturn-type]
 static void *f(void *p) { pthread_setname_np("QEMU"); }
                                                      ^
And indeed, the return statement is missing here.

Fixes: 479a57475e ("util: Implement debug-threads for macOS")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Note: There is another issue with --enable-werror on macOS, with the
       atomic64, which I haven't quite figured out yet, so compiling
       with --enable-werror is still not working there.

 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index b751c853f5..e93836aaae 100755
--- a/configure
+++ b/configure
@@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
 cat > $TMPC << EOF
 #include <pthread.h>
 
-static void *f(void *p) { pthread_setname_np("QEMU"); }
+static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
 int main(void)
 {
     pthread_t thread;
-- 
2.18.1

Re: [PATCH] configure: Fix for running with --enable-werror on macOS

Posted by Philippe Mathieu-Daudé 3 years, 9 months ago

On 7/16/20 7:56 AM, Thomas Huth wrote:
> The configure script currently refuses to succeed when run on macOS
> with --enable-werror:
> 
>  ERROR: configure test passed without -Werror but failed with -Werror.
> 
> The information in config.log indicates:
> 
>  config-temp/qemu-conf.c:3:55: error: control reaches end of non-void
>  function [-Werror,-Wreturn-type]
>  static void *f(void *p) { pthread_setname_np("QEMU"); }
>                                                       ^
> And indeed, the return statement is missing here.

I have a similar commit dated "2019-07-13 17:13:51" that fixes that too,
because I had problem with a CI (cirrus?). I remember there was a
discussion about it, as I can't find on the list, I suppose it was
discussed on IRC.
I don't remember the outcome, it was negative or the patch was
incomplete. I'm happy if it get fixed, so:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Fixes: 479a57475e ("util: Implement debug-threads for macOS")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  Note: There is another issue with --enable-werror on macOS, with the
>        atomic64, which I haven't quite figured out yet, so compiling
>        with --enable-werror is still not working there.
> 
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b751c853f5..e93836aaae 100755
> --- a/configure
> +++ b/configure
> @@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
>  cat > $TMPC << EOF
>  #include <pthread.h>
>  
> -static void *f(void *p) { pthread_setname_np("QEMU"); }
> +static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
>  int main(void)
>  {
>      pthread_t thread;
>

Re: [PATCH] configure: Fix for running with --enable-werror on macOS

Posted by Philippe Mathieu-Daudé 3 years, 9 months ago

On Thu, Jul 16, 2020 at 9:32 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 7/16/20 7:56 AM, Thomas Huth wrote:
> > The configure script currently refuses to succeed when run on macOS
> > with --enable-werror:
> >
> >  ERROR: configure test passed without -Werror but failed with -Werror.
> >
> > The information in config.log indicates:
> >
> >  config-temp/qemu-conf.c:3:55: error: control reaches end of non-void
> >  function [-Werror,-Wreturn-type]
> >  static void *f(void *p) { pthread_setname_np("QEMU"); }
> >                                                       ^
> > And indeed, the return statement is missing here.
>
> I have a similar commit dated "2019-07-13 17:13:51" that fixes that too,
> because I had problem with a CI (cirrus?). I remember there was a
> discussion about it, as I can't find on the list, I suppose it was
> discussed on IRC.
> I don't remember the outcome, it was negative or the patch was
> incomplete. I'm happy if it get fixed, so:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Oops the other one:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>
> >
> > Fixes: 479a57475e ("util: Implement debug-threads for macOS")
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  Note: There is another issue with --enable-werror on macOS, with the
> >        atomic64, which I haven't quite figured out yet, so compiling
> >        with --enable-werror is still not working there.
> >
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index b751c853f5..e93836aaae 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4198,7 +4198,7 @@ pthread_setname_np_wo_tid=no
> >  cat > $TMPC << EOF
> >  #include <pthread.h>
> >
> > -static void *f(void *p) { pthread_setname_np("QEMU"); }
> > +static void *f(void *p) { pthread_setname_np("QEMU"); return NULL; }
> >  int main(void)
> >  {
> >      pthread_t thread;
> >
>
>