[PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()

Philippe Mathieu-Daudé posted 4 patches 5 years, 7 months ago
[PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()
Posted by Philippe Mathieu-Daudé 5 years, 7 months ago
Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset().

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/avr/cpu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/avr/cpu.c b/target/avr/cpu.c
index 4e4dd4f6aa..50fb1c378b 100644
--- a/target/avr/cpu.c
+++ b/target/avr/cpu.c
@@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds)
     env->skip = 0;
 
     memset(env->r, 0, sizeof(env->r));
-
-    tlb_flush(cs);
 }
 
 static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info *info)
-- 
2.21.3


Re: [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()
Posted by Thomas Huth 5 years, 7 months ago
Am Tue,  7 Jul 2020 09:00:18 +0200
schrieb Philippe Mathieu-Daudé <f4bug@amsat.org>:

> Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset().
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/avr/cpu.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target/avr/cpu.c b/target/avr/cpu.c
> index 4e4dd4f6aa..50fb1c378b 100644
> --- a/target/avr/cpu.c
> +++ b/target/avr/cpu.c
> @@ -78,8 +78,6 @@ static void avr_cpu_reset(DeviceState *ds)
>      env->skip = 0;
>  
>      memset(env->r, 0, sizeof(env->r));
> -
> -    tlb_flush(cs);
>  }
>  
>  static void avr_cpu_disas_set_info(CPUState *cpu, disassemble_info
> *info)

Reviewed-by: Thomas Huth <huth@tuxfamily.org>

Re: [PATCH v2 1/4] target/avr/cpu: Drop tlb_flush() in avr_cpu_reset()
Posted by Richard Henderson 5 years, 7 months ago
On 7/7/20 12:00 AM, Philippe Mathieu-Daudé wrote:
> Since commit 1f5c00cfdb tlb_flush() is called from cpu_common_reset().
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/avr/cpu.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~