1. Patchew
  2. QEMU
  3. View series

[PATCH] hw/register: Document register_init_block @memory_size

Philippe Mathieu-Daudé posted 1 patch 3 years, 9 months ago
Test checkpatch passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200707062308.4531-1-f4bug@amsat.org
include/hw/register.h | 1 +
1 file changed, 1 insertion(+)
[PATCH] hw/register: Document register_init_block @memory_size
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago 
Document the 'memory_size' argument of register_init_block().

Fixes: a74229597e ("register: Add block initialise helper")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 include/hw/register.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/hw/register.h b/include/hw/register.h
index 5d2c565ae0..fdac5e69b5 100644
--- a/include/hw/register.h
+++ b/include/hw/register.h
@@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
  * @data: Array to use for register data, must already be allocated
  * @ops: Memory region ops to access registers.
  * @debug enabled: turn on/off verbose debug information
+ * @memory_size: Size of the memory region
  * returns: A structure containing all of the registers and an initialized
  *          memory region (r_array->mem) the caller should add to a container.
  */
-- 
2.21.3
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Laurent Vivier 3 years, 9 months ago 
Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> Document the 'memory_size' argument of register_init_block().
> 
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  include/hw/register.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>   * @data: Array to use for register data, must already be allocated
>   * @ops: Memory region ops to access registers.
>   * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
>   * returns: A structure containing all of the registers and an initialized
>   *          memory region (r_array->mem) the caller should add to a container.
>   */
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Alistair Francis 3 years, 9 months ago 
On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>
> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> > Document the 'memory_size' argument of register_init_block().
> >
> > Fixes: a74229597e ("register: Add block initialise helper")
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  include/hw/register.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/hw/register.h b/include/hw/register.h
> > index 5d2c565ae0..fdac5e69b5 100644
> > --- a/include/hw/register.h
> > +++ b/include/hw/register.h
> > @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
> >   * @data: Array to use for register data, must already be allocated
> >   * @ops: Memory region ops to access registers.
> >   * @debug enabled: turn on/off verbose debug information
> > + * @memory_size: Size of the memory region
> >   * returns: A structure containing all of the registers and an initialized
> >   *          memory region (r_array->mem) the caller should add to a container.
> >   */
> >
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Can this go via the trivial tree?

Alistair

>
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Laurent Vivier 3 years, 9 months ago 
Le 09/07/2020 à 19:19, Alistair Francis a écrit :
> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
>>> Document the 'memory_size' argument of register_init_block().
>>>
>>> Fixes: a74229597e ("register: Add block initialise helper")
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>>  include/hw/register.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/hw/register.h b/include/hw/register.h
>>> index 5d2c565ae0..fdac5e69b5 100644
>>> --- a/include/hw/register.h
>>> +++ b/include/hw/register.h
>>> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>>>   * @data: Array to use for register data, must already be allocated
>>>   * @ops: Memory region ops to access registers.
>>>   * @debug enabled: turn on/off verbose debug information
>>> + * @memory_size: Size of the memory region
>>>   * returns: A structure containing all of the registers and an initialized
>>>   *          memory region (r_array->mem) the caller should add to a container.
>>>   */
>>>
>>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> 
> Can this go via the trivial tree?
> 

Yes, I will try to do a PR before the hard freeze.

Thanks,
Laurent
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago 
On 7/9/20 10:17 PM, Laurent Vivier wrote:
> Le 09/07/2020 à 19:19, Alistair Francis a écrit :
>> On Wed, Jul 8, 2020 at 5:43 AM Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
>>>> Document the 'memory_size' argument of register_init_block().
>>>>
>>>> Fixes: a74229597e ("register: Add block initialise helper")
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  include/hw/register.h | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/hw/register.h b/include/hw/register.h
>>>> index 5d2c565ae0..fdac5e69b5 100644
>>>> --- a/include/hw/register.h
>>>> +++ b/include/hw/register.h
>>>> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>>>>   * @data: Array to use for register data, must already be allocated
>>>>   * @ops: Memory region ops to access registers.
>>>>   * @debug enabled: turn on/off verbose debug information
>>>> + * @memory_size: Size of the memory region
>>>>   * returns: A structure containing all of the registers and an initialized
>>>>   *          memory region (r_array->mem) the caller should add to a container.
>>>>   */
>>>>
>>>
>>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>>
>> Can this go via the trivial tree?
>>
> 
> Yes, I will try to do a PR before the hard freeze.

No rush, if there is nothing else in your queue
you can safely keep this for 5.2 ;)
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Laurent Vivier 3 years, 7 months ago 
Le 07/07/2020 à 08:23, Philippe Mathieu-Daudé a écrit :
> Document the 'memory_size' argument of register_init_block().
> 
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  include/hw/register.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>   * @data: Array to use for register data, must already be allocated
>   * @ops: Memory region ops to access registers.
>   * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
>   * returns: A structure containing all of the registers and an initialized
>   *          memory region (r_array->mem) the caller should add to a container.
>   */
> 

Applied to my trivial-patches branch.

Thanks,
Laurent
Re: [PATCH] hw/register: Document register_init_block @memory_size
Posted by Alistair Francis 3 years, 9 months ago 
On Mon, Jul 6, 2020 at 11:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Document the 'memory_size' argument of register_init_block().
>
> Fixes: a74229597e ("register: Add block initialise helper")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/register.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 5d2c565ae0..fdac5e69b5 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -181,6 +181,7 @@ uint64_t register_read_memory(void *opaque, hwaddr addr, unsigned size);
>   * @data: Array to use for register data, must already be allocated
>   * @ops: Memory region ops to access registers.
>   * @debug enabled: turn on/off verbose debug information
> + * @memory_size: Size of the memory region
>   * returns: A structure containing all of the registers and an initialized
>   *          memory region (r_array->mem) the caller should add to a container.
>   */
> --
> 2.21.3
>
>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.