scripts: improve message when TAP based tests fail

[PATCH] scripts: improve message when TAP based tests fail

Daniel P. Berrangé posted 1 patch 3 years, 9 months ago

Download mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200706125054.2619012-1-berrange@redhat.com

scripts/tap-driver.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] scripts: improve message when TAP based tests fail

Posted by Daniel P. Berrangé 3 years, 9 months ago

If one of the qtests fails, the TAP driver prints out a message like:

  ERROR - too few tests run (expected 3, got 1)

which fails to tell you which test program failed. This is a critical
ommission when many tests are running in parallel as their output is
interleaved. The improved message is:

  ERROR endianness-test - too few tests run (expected 3, got 1)

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 scripts/tap-driver.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
index 6621a5cd67..b1d3880c50 100755
--- a/scripts/tap-driver.pl
+++ b/scripts/tap-driver.pl
@@ -217,7 +217,7 @@ sub report ($;$)
 
 sub testsuite_error ($)
 {
-  report "ERROR", "- $_[0]";
+  report "ERROR", "$test_name - $_[0]";
 }
 
 sub handle_tap_result ($)
-- 
2.26.2

Re: [PATCH] scripts: improve message when TAP based tests fail

Posted by Paolo Bonzini 3 years, 9 months ago

On 06/07/20 14:50, Daniel P. Berrangé wrote:
> If one of the qtests fails, the TAP driver prints out a message like:
> 
>   ERROR - too few tests run (expected 3, got 1)
> 
> which fails to tell you which test program failed. This is a critical
> ommission when many tests are running in parallel as their output is
> interleaved. The improved message is:
> 
>   ERROR endianness-test - too few tests run (expected 3, got 1)
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  scripts/tap-driver.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/tap-driver.pl b/scripts/tap-driver.pl
> index 6621a5cd67..b1d3880c50 100755
> --- a/scripts/tap-driver.pl
> +++ b/scripts/tap-driver.pl
> @@ -217,7 +217,7 @@ sub report ($;$)
>  
>  sub testsuite_error ($)
>  {
> -  report "ERROR", "- $_[0]";
> +  report "ERROR", "$test_name - $_[0]";
>  }
>  
>  sub handle_tap_result ($)
> 

Queued, thanks.

Paolo