[PATCH rc6 00/30] target/avr merger

Thomas Huth posted 30 patches 3 years, 9 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch failed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200705140315.260514-1-huth@tuxfamily.org
Maintainers: Sarah Harris <S.E.Harris@kent.ac.uk>, Michael Rolnik <mrolnik@gmail.com>
MAINTAINERS                      |   30 +
arch_init.c                      |    2 +
configure                        |    7 +
default-configs/avr-softmmu.mak  |    5 +
docs/system/target-avr.rst       |   37 +
docs/system/targets.rst          |    1 +
gdb-xml/avr-cpu.xml              |   49 +
hw/Kconfig                       |    1 +
hw/avr/Kconfig                   |    9 +
hw/avr/Makefile.objs             |    3 +
hw/avr/arduino.c                 |  149 ++
hw/avr/atmega.c                  |  458 +++++
hw/avr/atmega.h                  |   48 +
hw/avr/boot.c                    |  116 ++
hw/avr/boot.h                    |   33 +
hw/char/Kconfig                  |    3 +
hw/char/Makefile.objs            |    1 +
hw/char/avr_usart.c              |  320 ++++
hw/misc/Kconfig                  |    3 +
hw/misc/Makefile.objs            |    2 +
hw/misc/avr_power.c              |  113 ++
hw/misc/trace-events             |    4 +
hw/timer/Kconfig                 |    3 +
hw/timer/Makefile.objs           |    2 +
hw/timer/avr_timer16.c           |  609 ++++++
hw/timer/trace-events            |   12 +
include/disas/dis-asm.h          |   19 +
include/elf.h                    |    4 +
include/hw/char/avr_usart.h      |   93 +
include/hw/misc/avr_power.h      |   46 +
include/hw/timer/avr_timer16.h   |   94 +
include/sysemu/arch_init.h       |    1 +
qapi/machine.json                |    2 +-
target/avr/Makefile.objs         |   34 +
target/avr/cpu-param.h           |   37 +
target/avr/cpu-qom.h             |   54 +
target/avr/cpu.c                 |  777 ++++++++
target/avr/cpu.h                 |  256 +++
target/avr/disas.c               |  246 +++
target/avr/gdbstub.c             |   84 +
target/avr/helper.c              |  342 ++++
target/avr/helper.h              |   29 +
target/avr/insn.decode           |  187 ++
target/avr/machine.c             |  121 ++
target/avr/translate.c           | 3073 ++++++++++++++++++++++++++++++
tests/acceptance/machine_avr6.py |   50 +
tests/qtest/Makefile.include     |    2 +
tests/qtest/boot-serial-test.c   |   11 +
tests/qtest/machine-none-test.c  |    1 +
49 files changed, 7582 insertions(+), 1 deletion(-)
create mode 100644 default-configs/avr-softmmu.mak
create mode 100644 docs/system/target-avr.rst
create mode 100644 gdb-xml/avr-cpu.xml
create mode 100644 hw/avr/Kconfig
create mode 100644 hw/avr/Makefile.objs
create mode 100644 hw/avr/arduino.c
create mode 100644 hw/avr/atmega.c
create mode 100644 hw/avr/atmega.h
create mode 100644 hw/avr/boot.c
create mode 100644 hw/avr/boot.h
create mode 100644 hw/char/avr_usart.c
create mode 100644 hw/misc/avr_power.c
create mode 100644 hw/timer/avr_timer16.c
create mode 100644 include/hw/char/avr_usart.h
create mode 100644 include/hw/misc/avr_power.h
create mode 100644 include/hw/timer/avr_timer16.h
create mode 100644 target/avr/Makefile.objs
create mode 100644 target/avr/cpu-param.h
create mode 100644 target/avr/cpu-qom.h
create mode 100644 target/avr/cpu.c
create mode 100644 target/avr/cpu.h
create mode 100644 target/avr/disas.c
create mode 100644 target/avr/gdbstub.c
create mode 100644 target/avr/helper.c
create mode 100644 target/avr/helper.h
create mode 100644 target/avr/insn.decode
create mode 100644 target/avr/machine.c
create mode 100644 target/avr/translate.c
create mode 100644 tests/acceptance/machine_avr6.py
[PATCH rc6 00/30] target/avr merger
Posted by Thomas Huth 3 years, 9 months ago
This is the AVR port from Michael, release (merge) candidate 6.

I've rebased rc5 to the current master branch, fixed the conflicts,
and updated the APIs where necessary (e.g. qdev_create() had to be
replaced).

These patches have been on the list for a long time. Let's try to
get them finally merged.

You can also find the patches in my repo here:

 https://gitlab.com/huth/qemu/-/tree/avr

rc6:
- Rebased to master, fixed conflicts
- Changed the object_initialize_child() and qdev_create() calls
  where necessary
- Converted the texi doc to Sphinx
- Dropped the travis.yml patch - the acceptance CI is currently moved
  to gitlab, so we should add it later there instead
- Dropped the patch to clean up MAINTAINERs - and do it correctly
  right from the start instead.

Michael Rolnik (26):
  target/avr: Add basic parameters of the new platform
  target/avr: Introduce basic CPU class object
  target/avr: CPU class: Add interrupt handling support
  target/avr: CPU class: Add memory menagement support
  target/avr: CPU class: Add migration support
  target/avr: CPU class: Add GDB support
  target/avr: Introduce enumeration AVRFeature
  target/avr: Add defintions of AVR core types
  target/avr: Add instruction helpers
  target/avr: Add instruction translation - Register definitions
  target/avr: Add instruction translation - Arithmetic and Logic
    Instructions
  target/avr: Add instruction translation - Branch Instructions
  target/avr: Add instruction translation - Data Transfer Instructions
  target/avr: Add instruction translation - Bit and Bit-test
    Instructions
  target/avr: Add instruction translation - MCU Control Instructions
  target/avr: Add instruction translation - CPU main translation
    function
  target/avr: Initialize TCG register variables
  target/avr: Add support for disassembling via option '-d in_asm'
  hw/char: avr: Add limited support for USART peripheral
  hw/timer: avr: Add limited support for 16-bit timer peripheral
  hw/misc: avr: Add limited support for power reduction device
  target/avr: Register AVR support with the rest of QEMU
  target/avr: Update build system
  tests/machine-none: Add AVR support
  tests/boot-serial: Test some Arduino boards (AVR based)
  tests/acceptance: Test the Arduino MEGA2560 board

Philippe Mathieu-Daudé (3):
  hw/avr: Add support for loading ELF/raw binaries
  hw/avr: Add some ATmega microcontrollers
  hw/avr: Add limited support for some Arduino boards

Thomas Huth (1):
  target/avr: Add section into QEMU documentation

 MAINTAINERS                      |   30 +
 arch_init.c                      |    2 +
 configure                        |    7 +
 default-configs/avr-softmmu.mak  |    5 +
 docs/system/target-avr.rst       |   37 +
 docs/system/targets.rst          |    1 +
 gdb-xml/avr-cpu.xml              |   49 +
 hw/Kconfig                       |    1 +
 hw/avr/Kconfig                   |    9 +
 hw/avr/Makefile.objs             |    3 +
 hw/avr/arduino.c                 |  149 ++
 hw/avr/atmega.c                  |  458 +++++
 hw/avr/atmega.h                  |   48 +
 hw/avr/boot.c                    |  116 ++
 hw/avr/boot.h                    |   33 +
 hw/char/Kconfig                  |    3 +
 hw/char/Makefile.objs            |    1 +
 hw/char/avr_usart.c              |  320 ++++
 hw/misc/Kconfig                  |    3 +
 hw/misc/Makefile.objs            |    2 +
 hw/misc/avr_power.c              |  113 ++
 hw/misc/trace-events             |    4 +
 hw/timer/Kconfig                 |    3 +
 hw/timer/Makefile.objs           |    2 +
 hw/timer/avr_timer16.c           |  609 ++++++
 hw/timer/trace-events            |   12 +
 include/disas/dis-asm.h          |   19 +
 include/elf.h                    |    4 +
 include/hw/char/avr_usart.h      |   93 +
 include/hw/misc/avr_power.h      |   46 +
 include/hw/timer/avr_timer16.h   |   94 +
 include/sysemu/arch_init.h       |    1 +
 qapi/machine.json                |    2 +-
 target/avr/Makefile.objs         |   34 +
 target/avr/cpu-param.h           |   37 +
 target/avr/cpu-qom.h             |   54 +
 target/avr/cpu.c                 |  777 ++++++++
 target/avr/cpu.h                 |  256 +++
 target/avr/disas.c               |  246 +++
 target/avr/gdbstub.c             |   84 +
 target/avr/helper.c              |  342 ++++
 target/avr/helper.h              |   29 +
 target/avr/insn.decode           |  187 ++
 target/avr/machine.c             |  121 ++
 target/avr/translate.c           | 3073 ++++++++++++++++++++++++++++++
 tests/acceptance/machine_avr6.py |   50 +
 tests/qtest/Makefile.include     |    2 +
 tests/qtest/boot-serial-test.c   |   11 +
 tests/qtest/machine-none-test.c  |    1 +
 49 files changed, 7582 insertions(+), 1 deletion(-)
 create mode 100644 default-configs/avr-softmmu.mak
 create mode 100644 docs/system/target-avr.rst
 create mode 100644 gdb-xml/avr-cpu.xml
 create mode 100644 hw/avr/Kconfig
 create mode 100644 hw/avr/Makefile.objs
 create mode 100644 hw/avr/arduino.c
 create mode 100644 hw/avr/atmega.c
 create mode 100644 hw/avr/atmega.h
 create mode 100644 hw/avr/boot.c
 create mode 100644 hw/avr/boot.h
 create mode 100644 hw/char/avr_usart.c
 create mode 100644 hw/misc/avr_power.c
 create mode 100644 hw/timer/avr_timer16.c
 create mode 100644 include/hw/char/avr_usart.h
 create mode 100644 include/hw/misc/avr_power.h
 create mode 100644 include/hw/timer/avr_timer16.h
 create mode 100644 target/avr/Makefile.objs
 create mode 100644 target/avr/cpu-param.h
 create mode 100644 target/avr/cpu-qom.h
 create mode 100644 target/avr/cpu.c
 create mode 100644 target/avr/cpu.h
 create mode 100644 target/avr/disas.c
 create mode 100644 target/avr/gdbstub.c
 create mode 100644 target/avr/helper.c
 create mode 100644 target/avr/helper.h
 create mode 100644 target/avr/insn.decode
 create mode 100644 target/avr/machine.c
 create mode 100644 target/avr/translate.c
 create mode 100644 tests/acceptance/machine_avr6.py

-- 
2.26.2


Re: [PATCH rc6 00/30] target/avr merger
Posted by no-reply@patchew.org 3 years, 9 months ago
Patchew URL: https://patchew.org/QEMU/20200705140315.260514-1-huth@tuxfamily.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH rc6 00/30] target/avr merger
Type: series
Message-id: 20200705140315.260514-1-huth@tuxfamily.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200703184952.4918-1-f4bug@amsat.org -> patchew/20200703184952.4918-1-f4bug@amsat.org
 - [tag update]      patchew/20200703200459.23294-1-f4bug@amsat.org -> patchew/20200703200459.23294-1-f4bug@amsat.org
 - [tag update]      patchew/20200704153908.12118-1-philmd@redhat.com -> patchew/20200704153908.12118-1-philmd@redhat.com
 * [new tag]         patchew/20200705140315.260514-1-huth@tuxfamily.org -> patchew/20200705140315.260514-1-huth@tuxfamily.org
Switched to a new branch 'test'
faad775 target/avr: Add section into QEMU documentation
8857615 tests/acceptance: Test the Arduino MEGA2560 board
b564682 tests/boot-serial: Test some Arduino boards (AVR based)
d5e4699 tests/machine-none: Add AVR support
bba1e34 target/avr: Update build system
29dd29c hw/avr: Add limited support for some Arduino boards
3d1640f hw/avr: Add some ATmega microcontrollers
43b47a1 hw/avr: Add support for loading ELF/raw binaries
1ae4d9e target/avr: Register AVR support with the rest of QEMU
a523aa8 hw/misc: avr: Add limited support for power reduction device
d673e4a hw/timer: avr: Add limited support for 16-bit timer peripheral
3cb5e31 hw/char: avr: Add limited support for USART peripheral
81ef8ef target/avr: Add support for disassembling via option '-d in_asm'
e2c7a47 target/avr: Initialize TCG register variables
31793f5 target/avr: Add instruction translation - CPU main translation function
03b0b1e target/avr: Add instruction translation - MCU Control Instructions
dd26299 target/avr: Add instruction translation - Bit and Bit-test Instructions
cf3dbfd target/avr: Add instruction translation - Data Transfer Instructions
22d4651 target/avr: Add instruction translation - Branch Instructions
120a956 target/avr: Add instruction translation - Arithmetic and Logic Instructions
28a91ea target/avr: Add instruction translation - Register definitions
b61b514 target/avr: Add instruction helpers
74089c9 target/avr: Add defintions of AVR core types
9c7e675 target/avr: Introduce enumeration AVRFeature
1fd82d4 target/avr: CPU class: Add GDB support
3c788c7 target/avr: CPU class: Add migration support
cb72169 target/avr: CPU class: Add memory menagement support
0758ca1 target/avr: CPU class: Add interrupt handling support
bf938b7 target/avr: Introduce basic CPU class object
b5e3116 target/avr: Add basic parameters of the new platform

=== OUTPUT BEGIN ===
1/30 Checking commit b5e3116a3591 (target/avr: Add basic parameters of the new platform)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 115 lines checked

Patch 1/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/30 Checking commit bf938b75dc12 (target/avr: Introduce basic CPU class object)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 412 lines checked

Patch 2/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/30 Checking commit 0758ca106cc4 (target/avr: CPU class: Add interrupt handling support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 97 lines checked

Patch 3/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/30 Checking commit cb72169d4881 (target/avr: CPU class: Add memory menagement support)
5/30 Checking commit 3c788c7f7b46 (target/avr: CPU class: Add migration support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 136 lines checked

Patch 5/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/30 Checking commit 1fd82d47f5a7 (target/avr: CPU class: Add GDB support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 156 lines checked

Patch 6/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/30 Checking commit 9c7e67571337 (target/avr: Introduce enumeration AVRFeature)
8/30 Checking commit 74089c904d15 (target/avr: Add defintions of AVR core types)
9/30 Checking commit b61b514c3997 (target/avr: Add instruction helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#235: 
new file mode 100644

total: 0 errors, 1 warnings, 235 lines checked

Patch 9/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/30 Checking commit 28a91eae7169 (target/avr: Add instruction translation - Register definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 143 lines checked

Patch 10/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/30 Checking commit 120a95627611 (target/avr: Add instruction translation - Arithmetic and Logic Instructions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 908 lines checked

Patch 11/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/30 Checking commit 22d465149871 (target/avr: Add instruction translation - Branch Instructions)
13/30 Checking commit cf3dbfd9661c (target/avr: Add instruction translation - Data Transfer Instructions)
14/30 Checking commit dd262992399f (target/avr: Add instruction translation - Bit and Bit-test Instructions)
15/30 Checking commit 03b0b1ec78c3 (target/avr: Add instruction translation - MCU Control Instructions)
16/30 Checking commit 31793f55b06e (target/avr: Add instruction translation - CPU main translation function)
17/30 Checking commit e2c7a4769a94 (target/avr: Initialize TCG register variables)
18/30 Checking commit 81ef8efbea3c (target/avr: Add support for disassembling via option '-d in_asm')
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

total: 0 errors, 1 warnings, 279 lines checked

Patch 18/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/30 Checking commit 3cb5e313494e (hw/char: avr: Add limited support for USART peripheral)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 19/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/30 Checking commit d673e4a56319 (hw/timer: avr: Add limited support for 16-bit timer peripheral)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 737 lines checked

Patch 20/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/30 Checking commit a523aa88b34c (hw/misc: avr: Add limited support for power reduction device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

total: 0 errors, 1 warnings, 189 lines checked

Patch 21/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/30 Checking commit 1ae4d9e3bbc3 (target/avr: Register AVR support with the rest of QEMU)
23/30 Checking commit 43b47a14c9e9 (hw/avr: Add support for loading ELF/raw binaries)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 173 lines checked

Patch 23/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/30 Checking commit 3d1640fb8c1a (hw/avr: Add some ATmega microcontrollers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 513 lines checked

Patch 24/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/30 Checking commit 29dd29ce1df9 (hw/avr: Add limited support for some Arduino boards)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#81: 
new file mode 100644

total: 0 errors, 1 warnings, 178 lines checked

Patch 25/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/30 Checking commit bba1e34ecbaa (target/avr: Update build system)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 65 lines checked

Patch 26/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/30 Checking commit d5e469951cf6 (tests/machine-none: Add AVR support)
28/30 Checking commit b564682b6339 (tests/boot-serial: Test some Arduino boards (AVR based))
29/30 Checking commit 88576153f639 (tests/acceptance: Test the Arduino MEGA2560 board)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46: 
new file mode 100644

total: 0 errors, 1 warnings, 57 lines checked

Patch 29/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/30 Checking commit faad77504d50 (target/avr: Add section into QEMU documentation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: trailing whitespace
#39: FILE: docs/system/target-avr.rst:20:
+ - Continuous non interrupted execution: $

total: 1 errors, 1 warnings, 41 lines checked

Patch 30/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200705140315.260514-1-huth@tuxfamily.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH rc6 00/30] target/avr merger
Posted by Thomas Huth 3 years, 9 months ago
Am Sun, 5 Jul 2020 07:29:06 -0700 (PDT)
schrieb no-reply@patchew.org:

> Patchew URL:
> https://patchew.org/QEMU/20200705140315.260514-1-huth@tuxfamily.org/
[...]
> === OUTPUT BEGIN ===
> 1/30 Checking commit b5e3116a3591 (target/avr: Add basic parameters
> of the new platform) WARNING: added, moved or deleted file(s), does
> MAINTAINERS need updating? #42: 
> new file mode 100644

These warnings are really annoying. The target/avr folder is added to
MAINTAINERS in the first patch, so they should not occur...?

[...]
> ERROR: trailing whitespace
> #39: FILE: docs/system/target-avr.rst:20:
> + - Continuous non interrupted execution: $

Ok, that's a real one. I just already fixed it in my local branch.

 Thomas

Re: [PATCH rc6 00/30] target/avr merger
Posted by Peter Maydell 3 years, 9 months ago
On Sun, 5 Jul 2020 at 19:31, Thomas Huth <huth@tuxfamily.org> wrote:
>
> Am Sun, 5 Jul 2020 07:29:06 -0700 (PDT)
> schrieb no-reply@patchew.org:
>
> > Patchew URL:
> > https://patchew.org/QEMU/20200705140315.260514-1-huth@tuxfamily.org/
> [...]
> > === OUTPUT BEGIN ===
> > 1/30 Checking commit b5e3116a3591 (target/avr: Add basic parameters
> > of the new platform) WARNING: added, moved or deleted file(s), does
> > MAINTAINERS need updating? #42:
> > new file mode 100644
>
> These warnings are really annoying. The target/avr folder is added to
> MAINTAINERS in the first patch, so they should not occur...?

checkpatch's logic for this is extremely simplistic: it will
warn if:
 * the patch adds, moves or deletes a file
 * the patch does not itself modify MAINTAINERS

This naturally leads to a ton of false-positives.

thanks
-- PMM

Re: [PATCH rc6 00/30] target/avr merger
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago
On 7/5/20 4:02 PM, Thomas Huth wrote:
> This is the AVR port from Michael, release (merge) candidate 6.
> 
> I've rebased rc5 to the current master branch, fixed the conflicts,
> and updated the APIs where necessary (e.g. qdev_create() had to be
> replaced).
> 
> These patches have been on the list for a long time. Let's try to
> get them finally merged.
> 
> You can also find the patches in my repo here:
> 
>  https://gitlab.com/huth/qemu/-/tree/avr
> 
> rc6:
> - Rebased to master, fixed conflicts
> - Changed the object_initialize_child() and qdev_create() calls
>   where necessary
> - Converted the texi doc to Sphinx
> - Dropped the travis.yml patch - the acceptance CI is currently moved
>   to gitlab, so we should add it later there instead
> - Dropped the patch to clean up MAINTAINERs - and do it correctly
>   right from the start instead.

Thanks for this Thomas!

I am queuing the patches and will send a pull request.

Regards,

Phil.