[RFC PATCH v2 00/23] hw/qdev: Warn when using pre-qdev/QOM devices

Philippe Mathieu-Daudé posted 23 patches 3 years, 9 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200704153908.12118-1-philmd@redhat.com
configure                    |  8 ++++++++
include/hw/qdev-deprecated.h | 26 ++++++++++++++++++++++++++
include/qom/object.h         |  6 +++---
hw/arm/nseries.c             |  2 ++
hw/arm/omap1.c               |  6 ++++++
hw/arm/pxa2xx.c              |  3 +++
hw/char/omap_uart.c          |  5 +++++
hw/char/parallel.c           |  3 +++
hw/char/sh_serial.c          |  3 +++
hw/core/qdev.c               |  8 ++++++++
hw/display/blizzard.c        |  3 +++
hw/display/pxa2xx_lcd.c      |  3 +++
hw/display/ramfb.c           |  3 +++
hw/display/tc6393xb.c        |  3 +++
hw/display/vga-isa-mm.c      |  5 +++++
hw/display/vga.c             |  3 +++
hw/dma/etraxfs_dma.c         |  4 +++-
hw/dma/soc_dma.c             |  3 +++
hw/input/lasips2.c           |  4 +++-
hw/input/pxa2xx_keypad.c     |  3 +++
hw/input/tsc2005.c           |  3 +++
hw/intc/sh_intc.c            |  3 +++
hw/m68k/mcf5206.c            |  5 +++++
hw/m68k/mcf5208.c            |  3 +++
hw/misc/cbus.c               |  3 +++
hw/misc/omap_gpmc.c          |  3 +++
hw/misc/omap_l4.c            |  3 +++
hw/misc/omap_sdrc.c          |  3 +++
hw/nvram/eeprom93xx.c        |  3 +++
hw/openrisc/cputimer.c       |  3 +++
hw/ppc/ppc405_boards.c       |  5 +++++
hw/ppc/ppc405_uc.c           | 21 +++++++++++++++++++++
hw/ppc/ppc4xx_devs.c         |  7 +++++++
hw/riscv/riscv_htif.c        |  4 ++++
hw/riscv/sifive_uart.c       |  4 ++++
hw/sd/omap_mmc.c             |  5 +++++
hw/sh4/r2d.c                 |  3 +++
hw/sh4/sh7750.c              |  4 ++++
hw/ssi/omap_spi.c            |  3 +++
hw/timer/omap_synctimer.c    |  4 ++++
hw/timer/sh_timer.c          |  5 +++++
hw/usb/hcd-musb.c            |  3 +++
hw/xtensa/xtfpga.c           |  3 +++
43 files changed, 202 insertions(+), 5 deletions(-)
create mode 100644 include/hw/qdev-deprecated.h
[RFC PATCH v2 00/23] hw/qdev: Warn when using pre-qdev/QOM devices
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago
This is a trivial RFC series to anotate pre-qdev/QOM devices
so developers using them without knowing they are not QOM'ified
yet can realize it and convert them if/when they have time.

qdev/QOM devices are introspectable, so easier to test
or even fuzz.

Since RFC v1:
- Addressed bonzini comments, removed invalid patches
- Addressed thuth comment

Philippe Mathieu-Daudé (23):
  qom/object: Update documentation
  hw/core/qdev: Add qdev_warn_deprecated_function_used() helper
  hw/arm/omap: Emit warning when old code is used
  hw/arm/pxa2xx: Emit warning when old code is used
  hw/arm/nseries: Emit warning when old code is used
  hw/char/parallel: Emit warning when old code is used
  hw/display/blizzard: Emit warning when old code is used
  hw/display/ramfb: Emit warning when old code is used
  hw/display/tc6393xb: Emit warning when old code is used
  hw/display/vga-isa-mm: Emit warning when old code is used
  hw/dma/etraxfs_dma: Emit warning when old code is used
  hw/dma/soc_dma: Emit warning when old code is used
  hw/input/lasips2: Emit warning when old code is used
  hw/input/tsc2005: Emit warning when old code is used
  hw/m68k/mcf520x: Emit warning when old code is used
  hw/misc/cbus: Emit warning when old code is used
  hw/nvram/eeprom93xx: Emit warning when old code is used
  hw/openrisc/cputimer: Emit warning when old code is used
  hw/ppc/ppc4xx: Emit warning when old code is used
  hw/sh4: Emit warning when old code is used
  hw/riscv: Emit warning when old code is used
  hw/usb/hcd-musb: Emit warning when old code is used
  hw/xtensa/xtfpga: Emit warning when old code is used

 configure                    |  8 ++++++++
 include/hw/qdev-deprecated.h | 26 ++++++++++++++++++++++++++
 include/qom/object.h         |  6 +++---
 hw/arm/nseries.c             |  2 ++
 hw/arm/omap1.c               |  6 ++++++
 hw/arm/pxa2xx.c              |  3 +++
 hw/char/omap_uart.c          |  5 +++++
 hw/char/parallel.c           |  3 +++
 hw/char/sh_serial.c          |  3 +++
 hw/core/qdev.c               |  8 ++++++++
 hw/display/blizzard.c        |  3 +++
 hw/display/pxa2xx_lcd.c      |  3 +++
 hw/display/ramfb.c           |  3 +++
 hw/display/tc6393xb.c        |  3 +++
 hw/display/vga-isa-mm.c      |  5 +++++
 hw/display/vga.c             |  3 +++
 hw/dma/etraxfs_dma.c         |  4 +++-
 hw/dma/soc_dma.c             |  3 +++
 hw/input/lasips2.c           |  4 +++-
 hw/input/pxa2xx_keypad.c     |  3 +++
 hw/input/tsc2005.c           |  3 +++
 hw/intc/sh_intc.c            |  3 +++
 hw/m68k/mcf5206.c            |  5 +++++
 hw/m68k/mcf5208.c            |  3 +++
 hw/misc/cbus.c               |  3 +++
 hw/misc/omap_gpmc.c          |  3 +++
 hw/misc/omap_l4.c            |  3 +++
 hw/misc/omap_sdrc.c          |  3 +++
 hw/nvram/eeprom93xx.c        |  3 +++
 hw/openrisc/cputimer.c       |  3 +++
 hw/ppc/ppc405_boards.c       |  5 +++++
 hw/ppc/ppc405_uc.c           | 21 +++++++++++++++++++++
 hw/ppc/ppc4xx_devs.c         |  7 +++++++
 hw/riscv/riscv_htif.c        |  4 ++++
 hw/riscv/sifive_uart.c       |  4 ++++
 hw/sd/omap_mmc.c             |  5 +++++
 hw/sh4/r2d.c                 |  3 +++
 hw/sh4/sh7750.c              |  4 ++++
 hw/ssi/omap_spi.c            |  3 +++
 hw/timer/omap_synctimer.c    |  4 ++++
 hw/timer/sh_timer.c          |  5 +++++
 hw/usb/hcd-musb.c            |  3 +++
 hw/xtensa/xtfpga.c           |  3 +++
 43 files changed, 202 insertions(+), 5 deletions(-)
 create mode 100644 include/hw/qdev-deprecated.h

-- 
2.21.3