1. Patchew
  2. QEMU
  3. View series

[PATCH v2] MAINTAINERS: Cover the firmware JSON schema

Philippe Mathieu-Daudé posted 1 patch 3 years, 9 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200703183450.32398-1-philmd@redhat.com
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago 
Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of
virtual machine firmware).

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Kashyap Chamarthy <kchamart@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Since RFC v1:
- Added Daniel & Kashyap as reviewer
- Added myself as co-maintainer with Laszlo

Based on a comment from Laszlo:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
Background info from Kashyap:
https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
---
 MAINTAINERS | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index dec252f38b..64bcea658d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
+Firmware schema specifications
+M: Laszlo Ersek <lersek@redhat.com>
+M: Philippe Mathieu-Daudé <philmd@redhat.com>
+R: Daniel P. Berrange <berrange@redhat.com>
+R: Kashyap Chamarthy <kchamart@redhat.com>
+S: Maintained
+F: docs/interop/firmware.json
+
 EDK2 Firmware
 M: Laszlo Ersek <lersek@redhat.com>
 M: Philippe Mathieu-Daudé <philmd@redhat.com>
-- 
2.21.3
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Daniel P. Berrangé 3 years, 9 months ago 
On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Kashyap Chamarthy <kchamart@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Since RFC v1:
> - Added Daniel & Kashyap as reviewer
> - Added myself as co-maintainer with Laszlo

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Kashyap Chamarthy 3 years, 9 months ago 
On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:

(Was on PTO; just catching up.)

> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Kashyap Chamarthy <kchamart@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Since RFC v1:
> - Added Daniel & Kashyap as reviewer
> - Added myself as co-maintainer with Laszlo
> 
> Based on a comment from Laszlo:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
> Background info from Kashyap:
> https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
> ---

Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com> 

>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..64bcea658d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
>  F: include/hw/i2c/smbus_slave.h
>  F: include/hw/i2c/smbus_eeprom.h
>  
> +Firmware schema specifications
> +M: Laszlo Ersek <lersek@redhat.com>
> +M: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Daniel P. Berrange <berrange@redhat.com>
> +R: Kashyap Chamarthy <kchamart@redhat.com>
> +S: Maintained
> +F: docs/interop/firmware.json
> +
>  EDK2 Firmware
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
> -- 
> 2.21.3
> 

-- 
/kashyap
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Michael S. Tsirkin 3 years, 9 months ago 
On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Kashyap Chamarthy <kchamart@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Michael S. Tsirkin <mst@redhat.com>



> ---
> Since RFC v1:
> - Added Daniel & Kashyap as reviewer
> - Added myself as co-maintainer with Laszlo
> 
> Based on a comment from Laszlo:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
> Background info from Kashyap:
> https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..64bcea658d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
>  F: include/hw/i2c/smbus_slave.h
>  F: include/hw/i2c/smbus_eeprom.h
>  
> +Firmware schema specifications
> +M: Laszlo Ersek <lersek@redhat.com>
> +M: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Daniel P. Berrange <berrange@redhat.com>
> +R: Kashyap Chamarthy <kchamart@redhat.com>
> +S: Maintained
> +F: docs/interop/firmware.json
> +
>  EDK2 Firmware
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
> -- 
> 2.21.3
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago 
+qemu-trivial

On 7/8/20 8:45 AM, Michael S. Tsirkin wrote:
> On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:
>> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
>> schema that describes the different uses and properties of
>> virtual machine firmware).
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Michael S. Tsirkin <mst@redhat.com>
>> Cc: Kashyap Chamarthy <kchamart@redhat.com>
>> Cc: Daniel P. Berrange <berrange@redhat.com>
>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Thanks Michael. If you plan to do a pull request, can you
include this patch please? (modulo the weird UTF8 mojibakes)

Else it can simply go via the trivial tree.

> 
>> ---
>> Since RFC v1:
>> - Added Daniel & Kashyap as reviewer
>> - Added myself as co-maintainer with Laszlo
>>
>> Based on a comment from Laszlo:
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
>> Background info from Kashyap:
>> https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
>> ---
>>  MAINTAINERS | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index dec252f38b..64bcea658d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
>>  F: include/hw/i2c/smbus_slave.h
>>  F: include/hw/i2c/smbus_eeprom.h
>>  
>> +Firmware schema specifications
>> +M: Laszlo Ersek <lersek@redhat.com>
>> +M: Philippe Mathieu-Daudé <philmd@redhat.com>
>> +R: Daniel P. Berrange <berrange@redhat.com>
>> +R: Kashyap Chamarthy <kchamart@redhat.com>
>> +S: Maintained
>> +F: docs/interop/firmware.json
>> +
>>  EDK2 Firmware
>>  M: Laszlo Ersek <lersek@redhat.com>
>>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
>> -- 
>> 2.21.3
>
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Michael S. Tsirkin 3 years, 9 months ago 
On Wed, Jul 08, 2020 at 10:57:31AM +0200, Philippe Mathieu-Daudé wrote:
> +qemu-trivial
> 
> On 7/8/20 8:45 AM, Michael S. Tsirkin wrote:
> > On Fri, Jul 03, 2020 at 08:34:50PM +0200, Philippe Mathieu-Daudé wrote:
> >> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> >> schema that describes the different uses and properties of
> >> virtual machine firmware).
> >>
> >> Cc: Laszlo Ersek <lersek@redhat.com>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Cc: Kashyap Chamarthy <kchamart@redhat.com>
> >> Cc: Daniel P. Berrange <berrange@redhat.com>
> >> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > 
> > 
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Thanks Michael. If you plan to do a pull request, can you
> include this patch please? (modulo the weird UTF8 mojibakes)

I'll try, hopefully utf8 will be fine when I do.

> Else it can simply go via the trivial tree.
> 
> > 
> >> ---
> >> Since RFC v1:
> >> - Added Daniel & Kashyap as reviewer
> >> - Added myself as co-maintainer with Laszlo
> >>
> >> Based on a comment from Laszlo:
> >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
> >> Background info from Kashyap:
> >> https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
> >> ---
> >>  MAINTAINERS | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index dec252f38b..64bcea658d 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
> >>  F: include/hw/i2c/smbus_slave.h
> >>  F: include/hw/i2c/smbus_eeprom.h
> >>  
> >> +Firmware schema specifications
> >> +M: Laszlo Ersek <lersek@redhat.com>
> >> +M: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> +R: Daniel P. Berrange <berrange@redhat.com>
> >> +R: Kashyap Chamarthy <kchamart@redhat.com>
> >> +S: Maintained
> >> +F: docs/interop/firmware.json
> >> +
> >>  EDK2 Firmware
> >>  M: Laszlo Ersek <lersek@redhat.com>
> >>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> -- 
> >> 2.21.3
> >
Re: [PATCH v2] MAINTAINERS: Cover the firmware JSON schema
Posted by Laszlo Ersek 3 years, 9 months ago 
On 07/03/20 20:34, Philippe Mathieu-Daudé wrote:
> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> schema that describes the different uses and properties of
> virtual machine firmware).
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Kashyap Chamarthy <kchamart@redhat.com>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Since RFC v1:
> - Added Daniel & Kashyap as reviewer
> - Added myself as co-maintainer with Laszlo
> 
> Based on a comment from Laszlo:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg604925.html
> Background info from Kashyap:
> https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
> ---
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..64bcea658d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2601,6 +2601,14 @@ F: include/hw/i2c/smbus_master.h
>  F: include/hw/i2c/smbus_slave.h
>  F: include/hw/i2c/smbus_eeprom.h
>  
> +Firmware schema specifications
> +M: Laszlo Ersek <lersek@redhat.com>
> +M: Philippe Mathieu-Daudé <philmd@redhat.com>
> +R: Daniel P. Berrange <berrange@redhat.com>
> +R: Kashyap Chamarthy <kchamart@redhat.com>
> +S: Maintained
> +F: docs/interop/firmware.json
> +
>  EDK2 Firmware
>  M: Laszlo Ersek <lersek@redhat.com>
>  M: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you!
Laszlo

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.