[PATCH v2 0/3] block: improve error reporting for unsupported O_DIRECT

Daniel P. Berrangé posted 3 patches 3 years, 10 months ago
Test FreeBSD passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200702125612.2176194-1-berrange@redhat.com
There is a newer version of this series
block/file-posix.c            | 10 ++---
include/qemu/osdep.h          |  2 +
tests/qemu-iotests/051.out    |  4 +-
tests/qemu-iotests/051.pc.out |  4 +-
tests/qemu-iotests/061.out    |  2 +-
tests/qemu-iotests/069.out    |  2 +-
tests/qemu-iotests/082.out    |  4 +-
tests/qemu-iotests/111.out    |  2 +-
tests/qemu-iotests/226.out    |  6 +--
tests/qemu-iotests/232.out    | 12 +++---
tests/qemu-iotests/244.out    |  6 +--
util/osdep.c                  | 69 +++++++++++++++++++++++++++++------
12 files changed, 85 insertions(+), 38 deletions(-)
[PATCH v2 0/3] block: improve error reporting for unsupported O_DIRECT
Posted by Daniel P. Berrangé 3 years, 10 months ago
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg00269.html

See patch commit messages for rationale

Ideally we would convert other callers of qemu_open to use
qemu_open_err, and eventually remove qemu_open, renaming
qemu_open_err back to qemu_open.  Given soft freeze is just
days away though, I'm hoping this series is simple enough
to get into this release, leaving bigger cleanup for later.

Improved in v2:

 - Mention that qemu_open_err is preferred over qemu_open
 - Get rid of obsolete error_report call
 - Simplify O_DIRECT handling
 - Fixup iotests for changed error message text

Daniel P. Berrangé (3):
  util: validate whether O_DIRECT is supported after failure
  util: support detailed error reporting for qemu_open
  block: switch to use qemu_open_err for improved errors

 block/file-posix.c            | 10 ++---
 include/qemu/osdep.h          |  2 +
 tests/qemu-iotests/051.out    |  4 +-
 tests/qemu-iotests/051.pc.out |  4 +-
 tests/qemu-iotests/061.out    |  2 +-
 tests/qemu-iotests/069.out    |  2 +-
 tests/qemu-iotests/082.out    |  4 +-
 tests/qemu-iotests/111.out    |  2 +-
 tests/qemu-iotests/226.out    |  6 +--
 tests/qemu-iotests/232.out    | 12 +++---
 tests/qemu-iotests/244.out    |  6 +--
 util/osdep.c                  | 69 +++++++++++++++++++++++++++++------
 12 files changed, 85 insertions(+), 38 deletions(-)

-- 
2.26.2