[v1] s390-ccw bios update

[PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

Posted by Thomas Huth 3 years, 9 months ago

This pull request is not for master.

 Hi Cornelia,

the following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:

  hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)

are available in the Git repository at:

  https://gitlab.com/huth/qemu.git tags/s390-ccw-bios-2020-07-02

for you to fetch changes up to b71db6b9abb5af302c9669c133d78115c6437c45:

  pc-bios/s390: Update s390-ccw bios binaries with the latest changes (2020-07-02 11:51:31 +0200)

----------------------------------------------------------------
* Source code clean-ups from Janosch
----------------------------------------------------------------

Janosch Frank (9):
      pc-bios: s390x: cio.c cleanup and compile fix
      pc-bios: s390x: Consolidate timing functions into time.h
      pc-bios: s390x: Move sleep and yield to helper.h
      pc-bios: s390x: Get rid of magic offsets into the lowcore
      pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
      pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
      pc-bios: s390x: Move panic() into header and add infinite loop
      pc-bios: s390x: Use ebcdic2ascii table
      pc-bios: s390x: Make u32 ptr check explicit

Thomas Huth (2):
      pc-bios/s390-ccw: Generate and include dependency files in the Makefile
      pc-bios/s390: Update s390-ccw bios binaries with the latest changes

 pc-bios/s390-ccw.img           | Bin 42608 -> 42608 bytes
 pc-bios/s390-ccw/Makefile      |   3 +++
 pc-bios/s390-ccw/bootmap.c     |   4 +---
 pc-bios/s390-ccw/cio.c         |  40 ++++++++++++++++++++++------------------
 pc-bios/s390-ccw/cio.h         |  17 +++++++++++------
 pc-bios/s390-ccw/helper.h      |  19 ++++++++++++++++++-
 pc-bios/s390-ccw/jump2ipl.c    |  10 ++++------
 pc-bios/s390-ccw/main.c        |  15 +++------------
 pc-bios/s390-ccw/menu.c        |   1 +
 pc-bios/s390-ccw/netboot.mak   |  13 +++++++------
 pc-bios/s390-ccw/netmain.c     |  23 +++--------------------
 pc-bios/s390-ccw/s390-arch.h   |   4 +++-
 pc-bios/s390-ccw/s390-ccw.h    |  27 +++++++--------------------
 pc-bios/s390-ccw/s390-time.h   |  23 +++++++++++++++++++++++
 pc-bios/s390-ccw/start.S       |   5 +++--
 pc-bios/s390-ccw/virtio-net.c  |   2 ++
 pc-bios/s390-ccw/virtio-scsi.c |   2 ++
 pc-bios/s390-ccw/virtio.c      |  18 +++---------------
 pc-bios/s390-netboot.img       | Bin 67232 -> 67232 bytes
 19 files changed, 116 insertions(+), 110 deletions(-)
 create mode 100644 pc-bios/s390-ccw/s390-time.h

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

Posted by no-reply@patchew.org 3 years, 9 months ago

Patchew URL: https://patchew.org/QEMU/20200702115045.6171-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update
Type: series
Message-id: 20200702115045.6171-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200702115045.6171-1-thuth@redhat.com -> patchew/20200702115045.6171-1-thuth@redhat.com
Switched to a new branch 'test'
0d1e389 pc-bios/s390: Update s390-ccw bios binaries with the latest changes
b853d2a pc-bios/s390-ccw: Generate and include dependency files in the Makefile
b23b6b1 pc-bios: s390x: Make u32 ptr check explicit
6b8c130 pc-bios: s390x: Use ebcdic2ascii table
e2168e6 pc-bios: s390x: Move panic() into header and add infinite loop
7a2400d pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
267c418 pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
6bd3e6c pc-bios: s390x: Get rid of magic offsets into the lowcore
becd3ca pc-bios: s390x: Move sleep and yield to helper.h
061e9f3 pc-bios: s390x: Consolidate timing functions into time.h
7e56f4f pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/11 Checking commit 7e56f4febf83 (pc-bios: s390x: cio.c cleanup and compile fix)
2/11 Checking commit 061e9f352a3e (pc-bios: s390x: Consolidate timing functions into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit becd3ca7caaf (pc-bios: s390x: Move sleep and yield to helper.h)
4/11 Checking commit 6bd3e6c441a1 (pc-bios: s390x: Get rid of magic offsets into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#35: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#36: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#37: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#38: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 267c4180a374 (pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64)
6/11 Checking commit 7a2400dfa22b (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR)
7/11 Checking commit e2168e661f8d (pc-bios: s390x: Move panic() into header and add infinite loop)
8/11 Checking commit 6b8c130e5b38 (pc-bios: s390x: Use ebcdic2ascii table)
9/11 Checking commit b23b6b118f04 (pc-bios: s390x: Make u32 ptr check explicit)
10/11 Checking commit b853d2adc612 (pc-bios/s390-ccw: Generate and include dependency files in the Makefile)
11/11 Checking commit 0d1e38904c99 (pc-bios/s390: Update s390-ccw bios binaries with the latest changes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

Posted by Cornelia Huck 3 years, 9 months ago

On Thu,  2 Jul 2020 13:50:34 +0200
Thomas Huth <thuth@redhat.com> wrote:

> This pull request is not for master.
> 
>  Hi Cornelia,
> 
> the following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
> 
>   hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10 +0100)
> 
> are available in the Git repository at:
> 
>   https://gitlab.com/huth/qemu.git tags/s390-ccw-bios-2020-07-02
> 
> for you to fetch changes up to b71db6b9abb5af302c9669c133d78115c6437c45:
> 
>   pc-bios/s390: Update s390-ccw bios binaries with the latest changes (2020-07-02 11:51:31 +0200)
> 
> ----------------------------------------------------------------
> * Source code clean-ups from Janosch
> ----------------------------------------------------------------
> 
> Janosch Frank (9):
>       pc-bios: s390x: cio.c cleanup and compile fix
>       pc-bios: s390x: Consolidate timing functions into time.h
>       pc-bios: s390x: Move sleep and yield to helper.h
>       pc-bios: s390x: Get rid of magic offsets into the lowcore
>       pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
>       pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
>       pc-bios: s390x: Move panic() into header and add infinite loop
>       pc-bios: s390x: Use ebcdic2ascii table
>       pc-bios: s390x: Make u32 ptr check explicit
> 
> Thomas Huth (2):
>       pc-bios/s390-ccw: Generate and include dependency files in the Makefile
>       pc-bios/s390: Update s390-ccw bios binaries with the latest changes
> 
>  pc-bios/s390-ccw.img           | Bin 42608 -> 42608 bytes
>  pc-bios/s390-ccw/Makefile      |   3 +++
>  pc-bios/s390-ccw/bootmap.c     |   4 +---
>  pc-bios/s390-ccw/cio.c         |  40 ++++++++++++++++++++++------------------
>  pc-bios/s390-ccw/cio.h         |  17 +++++++++++------
>  pc-bios/s390-ccw/helper.h      |  19 ++++++++++++++++++-
>  pc-bios/s390-ccw/jump2ipl.c    |  10 ++++------
>  pc-bios/s390-ccw/main.c        |  15 +++------------
>  pc-bios/s390-ccw/menu.c        |   1 +
>  pc-bios/s390-ccw/netboot.mak   |  13 +++++++------
>  pc-bios/s390-ccw/netmain.c     |  23 +++--------------------
>  pc-bios/s390-ccw/s390-arch.h   |   4 +++-
>  pc-bios/s390-ccw/s390-ccw.h    |  27 +++++++--------------------
>  pc-bios/s390-ccw/s390-time.h   |  23 +++++++++++++++++++++++
>  pc-bios/s390-ccw/start.S       |   5 +++--
>  pc-bios/s390-ccw/virtio-net.c  |   2 ++
>  pc-bios/s390-ccw/virtio-scsi.c |   2 ++
>  pc-bios/s390-ccw/virtio.c      |  18 +++---------------
>  pc-bios/s390-netboot.img       | Bin 67232 -> 67232 bytes
>  19 files changed, 116 insertions(+), 110 deletions(-)
>  create mode 100644 pc-bios/s390-ccw/s390-time.h

Thanks, pulled.

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

Posted by no-reply@patchew.org 3 years, 9 months ago

Patchew URL: https://patchew.org/QEMU/20200702115045.6171-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update
Type: series
Message-id: 20200702115045.6171-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200702115045.6171-1-thuth@redhat.com -> patchew/20200702115045.6171-1-thuth@redhat.com
 * [new tag]         patchew/20200702122048.27798-1-kraxel@redhat.com -> patchew/20200702122048.27798-1-kraxel@redhat.com
Switched to a new branch 'test'
f0b076c pc-bios/s390: Update s390-ccw bios binaries with the latest changes
bf38303 pc-bios/s390-ccw: Generate and include dependency files in the Makefile
32d438d pc-bios: s390x: Make u32 ptr check explicit
d8c3200 pc-bios: s390x: Use ebcdic2ascii table
64f3f76 pc-bios: s390x: Move panic() into header and add infinite loop
8f3dc6b pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
937ebff pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
e8f864c pc-bios: s390x: Get rid of magic offsets into the lowcore
9638d54 pc-bios: s390x: Move sleep and yield to helper.h
4099f82 pc-bios: s390x: Consolidate timing functions into time.h
5e1d3fa pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/11 Checking commit 5e1d3fafa103 (pc-bios: s390x: cio.c cleanup and compile fix)
2/11 Checking commit 4099f82dce51 (pc-bios: s390x: Consolidate timing functions into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 9638d54963df (pc-bios: s390x: Move sleep and yield to helper.h)
4/11 Checking commit e8f864c1883e (pc-bios: s390x: Get rid of magic offsets into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#35: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#36: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#37: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#38: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 937ebffac0f6 (pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64)
6/11 Checking commit 8f3dc6be69ea (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR)
7/11 Checking commit 64f3f7675d21 (pc-bios: s390x: Move panic() into header and add infinite loop)
8/11 Checking commit d8c320076ea9 (pc-bios: s390x: Use ebcdic2ascii table)
9/11 Checking commit 32d438db1ef6 (pc-bios: s390x: Make u32 ptr check explicit)
10/11 Checking commit bf3830330eb1 (pc-bios/s390-ccw: Generate and include dependency files in the Makefile)
11/11 Checking commit f0b076c09a1f (pc-bios/s390: Update s390-ccw bios binaries with the latest changes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update

Posted by no-reply@patchew.org 3 years, 9 months ago

Patchew URL: https://patchew.org/QEMU/20200702115045.6171-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL SUBSYSTEM s390x 00/11] s390-ccw bios update
Type: series
Message-id: 20200702115045.6171-1-thuth@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200702115045.6171-1-thuth@redhat.com -> patchew/20200702115045.6171-1-thuth@redhat.com
Switched to a new branch 'test'
08322ed pc-bios/s390: Update s390-ccw bios binaries with the latest changes
fa1b24c pc-bios/s390-ccw: Generate and include dependency files in the Makefile
2a10b04 pc-bios: s390x: Make u32 ptr check explicit
eabfe81 pc-bios: s390x: Use ebcdic2ascii table
a1f5d42 pc-bios: s390x: Move panic() into header and add infinite loop
11e6639 pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR
698cf8e pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64
09abe4a pc-bios: s390x: Get rid of magic offsets into the lowcore
187e4da pc-bios: s390x: Move sleep and yield to helper.h
4b2ae23 pc-bios: s390x: Consolidate timing functions into time.h
bafe452 pc-bios: s390x: cio.c cleanup and compile fix

=== OUTPUT BEGIN ===
1/11 Checking commit bafe4528bda4 (pc-bios: s390x: cio.c cleanup and compile fix)
2/11 Checking commit 4b2ae23f4133 (pc-bios: s390x: Consolidate timing functions into time.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#97: 
new file mode 100644

total: 0 errors, 1 warnings, 142 lines checked

Patch 2/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/11 Checking commit 187e4daaa561 (pc-bios: s390x: Move sleep and yield to helper.h)
4/11 Checking commit 09abe4ab2f1c (pc-bios: s390x: Get rid of magic offsets into the lowcore)
ERROR: spaces required around that ':' (ctx:VxV)
#34: FILE: pc-bios/s390-ccw/cio.h:127:
+            __u16 cssid:8;
                        ^

ERROR: spaces required around that ':' (ctx:VxV)
#35: FILE: pc-bios/s390-ccw/cio.h:128:
+            __u16 reserved:4;
                           ^

ERROR: spaces required around that ':' (ctx:VxV)
#36: FILE: pc-bios/s390-ccw/cio.h:129:
+            __u16 m:1;
                    ^

ERROR: spaces required around that ':' (ctx:VxV)
#37: FILE: pc-bios/s390-ccw/cio.h:130:
+            __u16 ssid:2;
                       ^

ERROR: spaces required around that ':' (ctx:VxV)
#38: FILE: pc-bios/s390-ccw/cio.h:131:
+            __u16 one:1;
                      ^

total: 5 errors, 0 warnings, 37 lines checked

Patch 4/11 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/11 Checking commit 698cf8e0b1f5 (pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64)
6/11 Checking commit 11e663982839 (pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR)
7/11 Checking commit a1f5d4280c22 (pc-bios: s390x: Move panic() into header and add infinite loop)
8/11 Checking commit eabfe8127b88 (pc-bios: s390x: Use ebcdic2ascii table)
9/11 Checking commit 2a10b04887c5 (pc-bios: s390x: Make u32 ptr check explicit)
10/11 Checking commit fa1b24ca40d3 (pc-bios/s390-ccw: Generate and include dependency files in the Makefile)
11/11 Checking commit 08322ed01c42 (pc-bios/s390: Update s390-ccw bios binaries with the latest changes)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200702115045.6171-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com