[v3] net: tap: check file descriptor can be used

[PATCH v3 0/2] net: tap: check file descriptor can be used

Laurent Vivier posted 2 patches 3 years, 9 months ago

Diff against v2 v4
Download series mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200701193951.36248-1-lvivier@redhat.com

Maintainers: Stefan Weil <sw@weilnetz.de>, Jason Wang <jasowang@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

There is a newer version of this series

include/qemu/sockets.h |  1 +
net/tap-bsd.c          |  2 +-
net/tap-linux.c        |  8 +++---
net/tap-solaris.c      |  2 +-
net/tap-stub.c         |  2 +-
net/tap.c              | 41 ++++++++++++++++++++++++------
net/tap_int.h          |  2 +-
util/oslib-posix.c     | 26 +++++++++++++------
util/oslib-win32.c     | 57 ++++++++++++++++++++++++------------------
9 files changed, 93 insertions(+), 48 deletions(-)

Expand all Fold all

[PATCH v3 0/2] net: tap: check file descriptor can be used

Posted by Laurent Vivier 3 years, 9 months ago

v3: move qemu_fd_is_valid() checking into a new function
    qemu_try_set_nonblock(), and use qemu_try_set_nonblock() in
    qemu_set_nonblock().

v2: Add patch from Daniel to check the fd can be used

    I have updated Daniel's patch not to check for EINVAL on TUNGETIFF
    as I think we can avoid this special case because TUNGETIFF
    is available since kernel v2.6.27 (October 2008)
    Moreover I think the code was wrong as it was checking with -EINVAL and
    not EINVAL.

Daniel P. Berrang�� (1):
  net: detect errors from probing vnet hdr flag for TAP devices

Laurent Vivier (1):
  net: tap: check if the file descriptor is valid before using it

 include/qemu/sockets.h |  1 +
 net/tap-bsd.c          |  2 +-
 net/tap-linux.c        |  8 +++---
 net/tap-solaris.c      |  2 +-
 net/tap-stub.c         |  2 +-
 net/tap.c              | 41 ++++++++++++++++++++++++------
 net/tap_int.h          |  2 +-
 util/oslib-posix.c     | 26 +++++++++++++------
 util/oslib-win32.c     | 57 ++++++++++++++++++++++++------------------
 9 files changed, 93 insertions(+), 48 deletions(-)

-- 
2.26.2

Re: [PATCH v3 0/2] net: tap: check file descriptor can be used

Posted by Laurent Vivier 3 years, 9 months ago

Hi,

ping.

I think it would be good to have this fix in next release.

Thanks,
Laurent

On 01/07/2020 21:39, Laurent Vivier wrote:
> v3: move qemu_fd_is_valid() checking into a new function
>     qemu_try_set_nonblock(), and use qemu_try_set_nonblock() in
>     qemu_set_nonblock().
> 
> v2: Add patch from Daniel to check the fd can be used
> 
>     I have updated Daniel's patch not to check for EINVAL on TUNGETIFF
>     as I think we can avoid this special case because TUNGETIFF
>     is available since kernel v2.6.27 (October 2008)
>     Moreover I think the code was wrong as it was checking with -EINVAL and
>     not EINVAL.
> 
> Daniel P. Berrang�� (1):
>   net: detect errors from probing vnet hdr flag for TAP devices
> 
> Laurent Vivier (1):
>   net: tap: check if the file descriptor is valid before using it
> 
>  include/qemu/sockets.h |  1 +
>  net/tap-bsd.c          |  2 +-
>  net/tap-linux.c        |  8 +++---
>  net/tap-solaris.c      |  2 +-
>  net/tap-stub.c         |  2 +-
>  net/tap.c              | 41 ++++++++++++++++++++++++------
>  net/tap_int.h          |  2 +-
>  util/oslib-posix.c     | 26 +++++++++++++------
>  util/oslib-win32.c     | 57 ++++++++++++++++++++++++------------------
>  9 files changed, 93 insertions(+), 48 deletions(-)
>