[PATCH v2 0/3] some docs (booting, mttcg, icount)

Alex Bennée posted 3 patches 3 years, 10 months ago
Test FreeBSD passed
Test checkpatch failed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200701161153.30988-1-alex.bennee@linaro.org
docs/devel/index.rst                          |   2 +
...ti-thread-tcg.txt => multi-thread-tcg.rst} |  52 +++---
docs/devel/tcg-icount.rst                     |  89 ++++++++++
docs/interop/booting.rst                      | 159 ++++++++++++++++++
docs/interop/index.rst                        |   1 +
5 files changed, 284 insertions(+), 19 deletions(-)
rename docs/devel/{multi-thread-tcg.txt => multi-thread-tcg.rst} (90%)
create mode 100644 docs/devel/tcg-icount.rst
create mode 100644 docs/interop/booting.rst
[PATCH v2 0/3] some docs (booting, mttcg, icount)
Posted by Alex Bennée 3 years, 10 months ago
Hi,

This is the current state of documentation patches. They didn't get
much review the first time around so I present them as a series. I
Think we should merge them unless anyone want to argue they actively
muddy our document situation?

The following have no reviews:

 - docs/devel: convert and update MTTCG design document
 - docs/booting.rst: start documenting the boot process

Alex Bennée (3):
  docs/booting.rst: start documenting the boot process
  docs/devel: convert and update MTTCG design document
  docs/devel: add some notes on tcg-icount for developers

 docs/devel/index.rst                          |   2 +
 ...ti-thread-tcg.txt => multi-thread-tcg.rst} |  52 +++---
 docs/devel/tcg-icount.rst                     |  89 ++++++++++
 docs/interop/booting.rst                      | 159 ++++++++++++++++++
 docs/interop/index.rst                        |   1 +
 5 files changed, 284 insertions(+), 19 deletions(-)
 rename docs/devel/{multi-thread-tcg.txt => multi-thread-tcg.rst} (90%)
 create mode 100644 docs/devel/tcg-icount.rst
 create mode 100644 docs/interop/booting.rst

-- 
2.20.1


Re: [PATCH v2 0/3] some docs (booting, mttcg, icount)
Posted by no-reply@patchew.org 3 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20200701161153.30988-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH  v2 0/3] some docs (booting, mttcg, icount)
Type: series
Message-id: 20200701161153.30988-1-alex.bennee@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f0c6933 docs/devel: add some notes on tcg-icount for developers
b4ed66b docs/devel: convert and update MTTCG design document
2c9c289 docs/booting.rst: start documenting the boot process

=== OUTPUT BEGIN ===
1/3 Checking commit 2c9c289aa77c (docs/booting.rst: start documenting the boot process)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100644

total: 0 errors, 1 warnings, 166 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit b4ed66b650ef (docs/devel: convert and update MTTCG design document)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
rename from docs/devel/multi-thread-tcg.txt

total: 0 errors, 1 warnings, 97 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit f0c6933d34a5 (docs/devel: add some notes on tcg-icount for developers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

ERROR: trailing whitespace
#107: FILE: docs/devel/tcg-icount.rst:70:
+  $

ERROR: trailing whitespace
#108: FILE: docs/devel/tcg-icount.rst:71:
+.. [1] sometimes two instructions if dealing with delay slots  $

ERROR: trailing whitespace
#123: FILE: docs/devel/tcg-icount.rst:86:
+   $

total: 3 errors, 1 warnings, 96 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200701161153.30988-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/3] some docs (booting, mttcg, icount)
Posted by no-reply@patchew.org 3 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20200701161153.30988-1-alex.bennee@linaro.org/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      util/cutils.o
  CC      util/unicode.o

Warning, treated as error:
/tmp/qemu-test/src/docs/interop/booting.rst:141:Title level inconsistent:

Hardware
---
  CC      util/qemu-thread-win32.o
  CC      util/envlist.o

Warning, treated as error:
/tmp/qemu-test/src/docs/interop/booting.rst:141:Title level inconsistent:

Hardware
~~~~~~~~
  CC      util/path.o
make: *** [Makefile:1108: .docs_interop_qemu-ga.8.sentinel.] Error 2
make: *** Deleting file '.docs_interop_qemu-ga.8.sentinel.'
make: *** Waiting for unfinished jobs....
make: *** [Makefile:1093: docs/interop/index.html] Error 2
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 669, in <module>
    sys.exit(main())
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=8aa5ca1bf60d4a9a844021819abc67e4', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-chc922my/src/docker-src.2020-07-01-12.52.42.12836:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=8aa5ca1bf60d4a9a844021819abc67e4
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-chc922my/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    3m5.559s
user    0m8.570s


The full log is available at
http://patchew.org/logs/20200701161153.30988-1-alex.bennee@linaro.org/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com