[PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Philippe Mathieu-Daudé posted 6 patches 1 week ago
Test docker-quick@centos7 passed
Test checkpatch passed
Test docker-mingw@fedora passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200630145236.27529-1-f4bug@amsat.org
Maintainers: Michael Tokarev <mjt@tls.msk.ru>, Laurent Vivier <laurent@vivier.eu>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Aurelien Jarno <aurelien@aurel32.net>
hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 111 insertions(+), 14 deletions(-)

[PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Philippe Mathieu-Daudé 1 week ago
Hi,

This series add a new 'malta-strict' machine, that aims to properly
model the real hardware (which is not what the current 'malta'
machine models).

As a bonus for Debian builders, a 'malta-unleashed' machine RFC
patch is included. This might start another endless discussion
upstream, but this is not the point of, so I still include it
for people to test. The rest of the series is candidate for merging
in mainstream QEMU.

Philippe Mathieu-Daudé (6):
  hw/mips/malta: Trivial code movement
  hw/mips/malta: Register the machine as a TypeInfo
  hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
  hw/mips/malta: Introduce the 'malta-strict' machine
  hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
  hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine

 hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 111 insertions(+), 14 deletions(-)

-- 
2.21.3


Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Aleksandar Markovic 1 week ago
уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
написао/ла:
>
> Hi,
>
> This series add a new 'malta-strict' machine, that aims to properly
> model the real hardware (which is not what the current 'malta'
> machine models).
>
> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
> patch is included. This might start another endless discussion
> upstream, but this is not the point of, so I still include it
> for people to test. The rest of the series is candidate for merging
> in mainstream QEMU.
>
> Philippe Mathieu-Daudé (6):
>   hw/mips/malta: Trivial code movement
>   hw/mips/malta: Register the machine as a TypeInfo
>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>   hw/mips/malta: Introduce the 'malta-strict' machine
>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>
>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>  1 file changed, 111 insertions(+), 14 deletions(-)
>
> --

This whole series is based on idea of emulating physically
non-existing feature, and as such violates the fundamental principles
of QEMU.

As such, not acceptable for upstreaming.

I don't see the point of sending again the same series, in just
cosmetically different form, if it was said to you that the concept is
wrong.

Regards,
Aleksandar


> 2.21.3
>

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Daniel P. Berrangé 1 week ago
On Tue, Jun 30, 2020 at 05:38:25PM +0200, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
> >
> > Hi,
> >
> > This series add a new 'malta-strict' machine, that aims to properly
> > model the real hardware (which is not what the current 'malta'
> > machine models).
> >
> > As a bonus for Debian builders, a 'malta-unleashed' machine RFC
> > patch is included. This might start another endless discussion
> > upstream, but this is not the point of, so I still include it
> > for people to test. The rest of the series is candidate for merging
> > in mainstream QEMU.
> >
> > Philippe Mathieu-Daudé (6):
> >   hw/mips/malta: Trivial code movement
> >   hw/mips/malta: Register the machine as a TypeInfo
> >   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
> >   hw/mips/malta: Introduce the 'malta-strict' machine
> >   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
> >   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
> >
> >  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
> >  1 file changed, 111 insertions(+), 14 deletions(-)
> >
> > --
> 
> This whole series is based on idea of emulating physically
> non-existing feature, and as such violates the fundamental principles
> of QEMU.

On x86 we model a i440fx from 1995. Max RAM in 1995 was on the order
of 10's of MB, but we run it with *multi-TB* of RAM in QEMU. There's
examples of this all over QEMU.

> As such, not acceptable for upstreaming.

I think this is quite unreasonable, especially considering this series is
addressing a real world problem that users of QEMU malta are facing with
insufficient RAM. QEMU exists to help users get their work done

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Thomas Huth 1 week ago
On 30/06/2020 17.38, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> Hi,
>>
>> This series add a new 'malta-strict' machine, that aims to properly
>> model the real hardware (which is not what the current 'malta'
>> machine models).
>>
>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>> patch is included. This might start another endless discussion
>> upstream, but this is not the point of, so I still include it
>> for people to test. The rest of the series is candidate for merging
>> in mainstream QEMU.
>>
>> Philippe Mathieu-Daudé (6):
>>    hw/mips/malta: Trivial code movement
>>    hw/mips/malta: Register the machine as a TypeInfo
>>    hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>    hw/mips/malta: Introduce the 'malta-strict' machine
>>    hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>    hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>
>>   hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>   1 file changed, 111 insertions(+), 14 deletions(-)
>>
>> --
> 
> This whole series is based on idea of emulating physically
> non-existing feature, and as such violates the fundamental principles
> of QEMU.
> 
> As such, not acceptable for upstreaming.

  Hi Aleksandar,

could you please point me to the spot where we declare this "fundamental 
principle" of QEMU? Sorry, but I must have missed this piece of 
information so far. And could you please enlighten me what we should do 
now with virtio, since most of these devices also are physically 
non-existent?

  Thanks,
   Thomas


Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Philippe Mathieu-Daudé 1 week ago
On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> Hi,
>>
>> This series add a new 'malta-strict' machine, that aims to properly
>> model the real hardware (which is not what the current 'malta'
>> machine models).
>>
>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>> patch is included. This might start another endless discussion
>> upstream, but this is not the point of, so I still include it
>> for people to test. The rest of the series is candidate for merging
>> in mainstream QEMU.
>>
>> Philippe Mathieu-Daudé (6):
>>   hw/mips/malta: Trivial code movement
>>   hw/mips/malta: Register the machine as a TypeInfo
>>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>   hw/mips/malta: Introduce the 'malta-strict' machine
>>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>
>>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>  1 file changed, 111 insertions(+), 14 deletions(-)
>>
>> --
> 
> This whole series is based on idea of emulating physically
> non-existing feature, and as such violates the fundamental principles
> of QEMU.
> 
> As such, not acceptable for upstreaming.
> 
> I don't see the point of sending again the same series, in just
> cosmetically different form, if it was said to you that the concept is
> wrong.

Have you looked at the patches? What "violates the fundamental
principles of QEMU" is the code currently in mainstream. Should
we remove it? I can send a patch for it if it pleases you, but
you will make QEMU unuseful for many distribution users.

What this series does is emulate the physically existing feature
that are not yet emulated in QEMU.

Please refer to the datasheet 'MIPS Document Number: MD00051
Revision 01.07' before rejecting this series, and find the
correct arguments.

Thanks.

> 
> Regards,
> Aleksandar
> 
> 
>> 2.21.3
>>
> 

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Aleksandar Markovic 1 week ago
уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
написао/ла:
>
> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
> > уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> > написао/ла:
> >>
> >> Hi,
> >>
> >> This series add a new 'malta-strict' machine, that aims to properly
> >> model the real hardware (which is not what the current 'malta'
> >> machine models).
> >>
> >> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
> >> patch is included. This might start another endless discussion
> >> upstream, but this is not the point of, so I still include it
> >> for people to test. The rest of the series is candidate for merging
> >> in mainstream QEMU.
> >>
> >> Philippe Mathieu-Daudé (6):
> >>   hw/mips/malta: Trivial code movement
> >>   hw/mips/malta: Register the machine as a TypeInfo
> >>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
> >>   hw/mips/malta: Introduce the 'malta-strict' machine
> >>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
> >>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
> >>
> >>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
> >>  1 file changed, 111 insertions(+), 14 deletions(-)
> >>
> >> --
> >
> > This whole series is based on idea of emulating physically
> > non-existing feature, and as such violates the fundamental principles
> > of QEMU.
> >
> > As such, not acceptable for upstreaming.
> >
> > I don't see the point of sending again the same series, in just
> > cosmetically different form, if it was said to you that the concept is
> > wrong.
>
> Have you looked at the patches? What "violates the fundamental
> principles of QEMU" is the code currently in mainstream. Should
> we remove it? I can send a patch for it if it pleases you, but
> you will make QEMU unuseful for many distribution users.
>

Past mistakes are past mistakes. We have to live with them. And not
make them in the future.

I see the whole series as a precursor for your change that repeats
past mistakes, a "wolf in sheep clothing".

That's why I reject the series as a whole.

Yours,
Aleksandar

> What this series does is emulate the physically existing feature
> that are not yet emulated in QEMU.
>
> Please refer to the datasheet 'MIPS Document Number: MD00051
> Revision 01.07' before rejecting this series, and find the
> correct arguments.
>
> Thanks.
>
> >
> > Regards,
> > Aleksandar
> >
> >
> >> 2.21.3
> >>
> >

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Philippe Mathieu-Daudé 1 week ago
On 6/30/20 6:55 PM, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
>>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>> написао/ла:
>>>>
>>>> Hi,
>>>>
>>>> This series add a new 'malta-strict' machine, that aims to properly
>>>> model the real hardware (which is not what the current 'malta'
>>>> machine models).
>>>>
>>>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>>>> patch is included. This might start another endless discussion
>>>> upstream, but this is not the point of, so I still include it
>>>> for people to test. The rest of the series is candidate for merging
>>>> in mainstream QEMU.
>>>>
>>>> Philippe Mathieu-Daudé (6):
>>>>   hw/mips/malta: Trivial code movement
>>>>   hw/mips/malta: Register the machine as a TypeInfo
>>>>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>>>   hw/mips/malta: Introduce the 'malta-strict' machine
>>>>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>>>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>>>
>>>>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>>>  1 file changed, 111 insertions(+), 14 deletions(-)
>>>>
>>>> --
>>>
>>> This whole series is based on idea of emulating physically
>>> non-existing feature, and as such violates the fundamental principles
>>> of QEMU.
>>>
>>> As such, not acceptable for upstreaming.
>>>
>>> I don't see the point of sending again the same series, in just
>>> cosmetically different form, if it was said to you that the concept is
>>> wrong.
>>
>> Have you looked at the patches? What "violates the fundamental
>> principles of QEMU" is the code currently in mainstream. Should
>> we remove it? I can send a patch for it if it pleases you, but
>> you will make QEMU unuseful for many distribution users.
>>
> 
> Past mistakes are past mistakes. We have to live with them. And not
> make them in the future.
> 
> I see the whole series as a precursor for your change that repeats
> past mistakes, a "wolf in sheep clothing".
> 
> That's why I reject the series as a whole.

As a co-maintainer I don't accept that.

The 'malta' machine is not changed, the series adds the 'malta-strict'
machine which check the RAM restriction:

$ qemu-system-mips -M malta-strict -bios /dev/null -m 512
qemu-system-mips: Too much memory for this machine: 512 MiB, maximum 256 MiB

$ qemu-system-mips -M malta-strict -bios /dev/null -m 252
qemu-system-mips: RAM size must be the combination of 4 powers of 2

$ qemu-system-mips -M malta-strict -monitor stdio -S -bios /dev/null -m 100
QEMU 5.0.50 monitor - type 'help' for more information
(qemu) info mtree
address-space: memory
  0000000000000000-ffffffffffffffff (prio 0, i/o): system
    0000000000000000-00000000063fffff (prio 0, ram): alias
mips_malta_low_preio.ram @mips_malta.ram 0000000000000000-00000000063fffff

100 = 64 + 32 + 2 + 2

> 
> Yours,
> Aleksandar
> 
>> What this series does is emulate the physically existing feature
>> that are not yet emulated in QEMU.
>>
>> Please refer to the datasheet 'MIPS Document Number: MD00051
>> Revision 01.07' before rejecting this series, and find the
>> correct arguments.
>>
>> Thanks.
>>
>>>
>>> Regards,
>>> Aleksandar
>>>
>>>
>>>> 2.21.3
>>>>
>>>
> 

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Aleksandar Markovic 1 week ago
уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé <f4bug@amsat.org> је
написао/ла:
>
> On 6/30/20 6:55 PM, Aleksandar Markovic wrote:
> > уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> > написао/ла:
> >>
> >> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
> >>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> >>> написао/ла:
> >>>>
> >>>> Hi,
> >>>>
> >>>> This series add a new 'malta-strict' machine, that aims to properly
> >>>> model the real hardware (which is not what the current 'malta'
> >>>> machine models).
> >>>>
> >>>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
> >>>> patch is included. This might start another endless discussion
> >>>> upstream, but this is not the point of, so I still include it
> >>>> for people to test. The rest of the series is candidate for merging
> >>>> in mainstream QEMU.
> >>>>
> >>>> Philippe Mathieu-Daudé (6):
> >>>>   hw/mips/malta: Trivial code movement
> >>>>   hw/mips/malta: Register the machine as a TypeInfo
> >>>>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
> >>>>   hw/mips/malta: Introduce the 'malta-strict' machine
> >>>>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
> >>>>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
> >>>>
> >>>>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
> >>>>  1 file changed, 111 insertions(+), 14 deletions(-)
> >>>>
> >>>> --
> >>>
> >>> This whole series is based on idea of emulating physically
> >>> non-existing feature, and as such violates the fundamental principles
> >>> of QEMU.
> >>>
> >>> As such, not acceptable for upstreaming.
> >>>
> >>> I don't see the point of sending again the same series, in just
> >>> cosmetically different form, if it was said to you that the concept is
> >>> wrong.
> >>
> >> Have you looked at the patches? What "violates the fundamental
> >> principles of QEMU" is the code currently in mainstream. Should
> >> we remove it? I can send a patch for it if it pleases you, but
> >> you will make QEMU unuseful for many distribution users.
> >>
> >
> > Past mistakes are past mistakes. We have to live with them. And not
> > make them in the future.
> >
> > I see the whole series as a precursor for your change that repeats
> > past mistakes, a "wolf in sheep clothing".
> >
> > That's why I reject the series as a whole.
>
> As a co-maintainer I don't accept that.
>

I offered you the full maintainership for Malta.

You said you can proveide only "Odd fiexes".

I had to jump in to provide "Maintained" status.

Therefore, I provide the higher level of maintainership, and you have
to respect that. But you don't.

Regards,
Aleksandar

> The 'malta' machine is not changed, the series adds the 'malta-strict'
> machine which check the RAM restriction:
>
> $ qemu-system-mips -M malta-strict -bios /dev/null -m 512
> qemu-system-mips: Too much memory for this machine: 512 MiB, maximum 256 MiB
>
> $ qemu-system-mips -M malta-strict -bios /dev/null -m 252
> qemu-system-mips: RAM size must be the combination of 4 powers of 2
>
> $ qemu-system-mips -M malta-strict -monitor stdio -S -bios /dev/null -m 100
> QEMU 5.0.50 monitor - type 'help' for more information
> (qemu) info mtree
> address-space: memory
>   0000000000000000-ffffffffffffffff (prio 0, i/o): system
>     0000000000000000-00000000063fffff (prio 0, ram): alias
> mips_malta_low_preio.ram @mips_malta.ram 0000000000000000-00000000063fffff
>
> 100 = 64 + 32 + 2 + 2
>
> >
> > Yours,
> > Aleksandar
> >
> >> What this series does is emulate the physically existing feature
> >> that are not yet emulated in QEMU.
> >>
> >> Please refer to the datasheet 'MIPS Document Number: MD00051
> >> Revision 01.07' before rejecting this series, and find the
> >> correct arguments.
> >>
> >> Thanks.
> >>
> >>>
> >>> Regards,
> >>> Aleksandar
> >>>
> >>>
> >>>> 2.21.3
> >>>>
> >>>
> >

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Richard Henderson 1 week ago
On 6/30/20 10:28 AM, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> On 6/30/20 6:55 PM, Aleksandar Markovic wrote:
>>> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>> написао/ла:
>>>>
>>>> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
>>>>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>>>> написао/ла:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> This series add a new 'malta-strict' machine, that aims to properly
>>>>>> model the real hardware (which is not what the current 'malta'
>>>>>> machine models).
>>>>>>
>>>>>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>>>>>> patch is included. This might start another endless discussion
>>>>>> upstream, but this is not the point of, so I still include it
>>>>>> for people to test. The rest of the series is candidate for merging
>>>>>> in mainstream QEMU.
>>>>>>
>>>>>> Philippe Mathieu-Daudé (6):
>>>>>>   hw/mips/malta: Trivial code movement
>>>>>>   hw/mips/malta: Register the machine as a TypeInfo
>>>>>>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>>>>>   hw/mips/malta: Introduce the 'malta-strict' machine
>>>>>>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>>>>>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>>>>>
>>>>>>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>>>>>  1 file changed, 111 insertions(+), 14 deletions(-)
>>>>>>
>>>>>> --
>>>>>
>>>>> This whole series is based on idea of emulating physically
>>>>> non-existing feature, and as such violates the fundamental principles
>>>>> of QEMU.
>>>>>
>>>>> As such, not acceptable for upstreaming.
>>>>>
>>>>> I don't see the point of sending again the same series, in just
>>>>> cosmetically different form, if it was said to you that the concept is
>>>>> wrong.
>>>>
>>>> Have you looked at the patches? What "violates the fundamental
>>>> principles of QEMU" is the code currently in mainstream. Should
>>>> we remove it? I can send a patch for it if it pleases you, but
>>>> you will make QEMU unuseful for many distribution users.
>>>>
>>>
>>> Past mistakes are past mistakes. We have to live with them. And not
>>> make them in the future.
>>>
>>> I see the whole series as a precursor for your change that repeats
>>> past mistakes, a "wolf in sheep clothing".
>>>
>>> That's why I reject the series as a whole.
>>
>> As a co-maintainer I don't accept that.
>>
> 
> I offered you the full maintainership for Malta.
> 
> You said you can proveide only "Odd fiexes".
> 
> I had to jump in to provide "Maintained" status.
> 
> Therefore, I provide the higher level of maintainership, and you have
> to respect that. But you don't.

You need to cool your jets here, Aleksandar.

You do not have some mythical "higher level" of maintainership.  Nor, as far as
I can tell, are you actually doing anything with Malta whereas Philippe is.


r~

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

Posted by Philippe Mathieu-Daudé 1 week ago
On 6/30/20 7:28 PM, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
>>
>> On 6/30/20 6:55 PM, Aleksandar Markovic wrote:
>>> уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>> написао/ла:
>>>>
>>>> On 6/30/20 5:38 PM, Aleksandar Markovic wrote:
>>>>> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
>>>>> написао/ла:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> This series add a new 'malta-strict' machine, that aims to properly
>>>>>> model the real hardware (which is not what the current 'malta'
>>>>>> machine models).
>>>>>>
>>>>>> As a bonus for Debian builders, a 'malta-unleashed' machine RFC
>>>>>> patch is included. This might start another endless discussion
>>>>>> upstream, but this is not the point of, so I still include it
>>>>>> for people to test. The rest of the series is candidate for merging
>>>>>> in mainstream QEMU.
>>>>>>
>>>>>> Philippe Mathieu-Daudé (6):
>>>>>>   hw/mips/malta: Trivial code movement
>>>>>>   hw/mips/malta: Register the machine as a TypeInfo
>>>>>>   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
>>>>>>   hw/mips/malta: Introduce the 'malta-strict' machine
>>>>>>   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
>>>>>>   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
>>>>>>
>>>>>>  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
>>>>>>  1 file changed, 111 insertions(+), 14 deletions(-)
>>>>>>
>>>>>> --
>>>>>
>>>>> This whole series is based on idea of emulating physically
>>>>> non-existing feature, and as such violates the fundamental principles
>>>>> of QEMU.
>>>>>
>>>>> As such, not acceptable for upstreaming.
>>>>>
>>>>> I don't see the point of sending again the same series, in just
>>>>> cosmetically different form, if it was said to you that the concept is
>>>>> wrong.
>>>>
>>>> Have you looked at the patches? What "violates the fundamental
>>>> principles of QEMU" is the code currently in mainstream. Should
>>>> we remove it? I can send a patch for it if it pleases you, but
>>>> you will make QEMU unuseful for many distribution users.
>>>>
>>>
>>> Past mistakes are past mistakes. We have to live with them. And not
>>> make them in the future.
>>>
>>> I see the whole series as a precursor for your change that repeats
>>> past mistakes, a "wolf in sheep clothing".
>>>
>>> That's why I reject the series as a whole.
>>
>> As a co-maintainer I don't accept that.
>>
> 
> I offered you the full maintainership for Malta.
> 
> You said you can proveide only "Odd fiexes".
> 
> I had to jump in to provide "Maintained" status.
> 
> Therefore, I provide the higher level of maintainership, and you have
> to respect that. But you don't.

FYI we are listed as co-maintainer:

Malta
M: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
M: Philippe Mathieu-Daudé <f4bug@amsat.org>
R: Aurelien Jarno <aurelien@aurel32.net>
S: Maintained

There is no difference of level. If you don't want my help and plan
to destroy the hobbyist MIPS aspect of QEMU please kick me out, as
I don't want to be responsible for dictating in an open source project.

You can also relinquish your responsibility in Malta and focus on what
is important for your company.

> 
> Regards,
> Aleksandar
> 
>> The 'malta' machine is not changed, the series adds the 'malta-strict'
>> machine which check the RAM restriction:
>>
>> $ qemu-system-mips -M malta-strict -bios /dev/null -m 512
>> qemu-system-mips: Too much memory for this machine: 512 MiB, maximum 256 MiB
>>
>> $ qemu-system-mips -M malta-strict -bios /dev/null -m 252
>> qemu-system-mips: RAM size must be the combination of 4 powers of 2
>>
>> $ qemu-system-mips -M malta-strict -monitor stdio -S -bios /dev/null -m 100
>> QEMU 5.0.50 monitor - type 'help' for more information
>> (qemu) info mtree
>> address-space: memory
>>   0000000000000000-ffffffffffffffff (prio 0, i/o): system
>>     0000000000000000-00000000063fffff (prio 0, ram): alias
>> mips_malta_low_preio.ram @mips_malta.ram 0000000000000000-00000000063fffff
>>
>> 100 = 64 + 32 + 2 + 2
>>
>>>
>>> Yours,
>>> Aleksandar
>>>
>>>> What this series does is emulate the physically existing feature
>>>> that are not yet emulated in QEMU.
>>>>
>>>> Please refer to the datasheet 'MIPS Document Number: MD00051
>>>> Revision 01.07' before rejecting this series, and find the
>>>> correct arguments.
>>>>
>>>> Thanks.
>>>>
>>>>>
>>>>> Regards,
>>>>> Aleksandar
>>>>>
>>>>>
>>>>>> 2.21.3
>>>>>>
>>>>>
>>>
>