intel_iommu: "aw-bits" error message still refers to "x-aw-bits"

[PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"

Menno Lageman posted 1 patch 3 years, 10 months ago

Download mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200625155258.1452425-1-menno.lageman@oracle.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

hw/i386/intel_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"

Posted by Menno Lageman 3 years, 10 months ago

Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
removed the "x-" prefix but but didn't update the error message
accordingly.

Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
---
 hw/i386/intel_iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index df7ad254ac15..c56398e99177 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
     /* Currently only address widths supported are 39 and 48 bits */
     if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
         (s->aw_bits != VTD_HOST_AW_48BIT)) {
-        error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
+        error_setg(errp, "Supported values for aw-bits are: %d, %d",
                    VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
         return false;
     }
-- 
2.26.2

Re: [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"

Posted by Laurent Vivier 3 years, 9 months ago

Le 25/06/2020 à 17:52, Menno Lageman a écrit :
> Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
> removed the "x-" prefix but but didn't update the error message
> accordingly.
> 
> Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
> ---
>  hw/i386/intel_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index df7ad254ac15..c56398e99177 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
>      /* Currently only address widths supported are 39 and 48 bits */
>      if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
>          (s->aw_bits != VTD_HOST_AW_48BIT)) {
> -        error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
> +        error_setg(errp, "Supported values for aw-bits are: %d, %d",
>                     VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
>          return false;
>      }
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"

Posted by Laurent Vivier 3 years, 9 months ago

Le 25/06/2020 à 17:52, Menno Lageman a écrit :
> Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
> removed the "x-" prefix but but didn't update the error message
> accordingly.
> 
> Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
> ---
>  hw/i386/intel_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index df7ad254ac15..c56398e99177 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
>      /* Currently only address widths supported are 39 and 48 bits */
>      if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
>          (s->aw_bits != VTD_HOST_AW_48BIT)) {
> -        error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
> +        error_setg(errp, "Supported values for aw-bits are: %d, %d",
>                     VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
>          return false;
>      }
> 

Applied to my trivial-patches-for-5.1 branch.

Thanks,
Laurent