[v1] Fix crash due to NBD export leak

[PATCH 0/4] Fix crash due to NBD export leak

Vladimir Sementsov-Ogievskiy posted 4 patches 3 years, 10 months ago

Diff against v2 v3
Download series mbox

Test FreeBSD passed

Test docker-quick@centos7 failed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200625142540.24589-1-vsementsov@virtuozzo.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>

There is a newer version of this series

nbd/server.c                  |  3 ++
tests/qemu-iotests/299        | 65 +++++++++++++++++++++++++++++++++++
tests/qemu-iotests/299.out    | 10 ++++++
tests/qemu-iotests/group      |  1 +
tests/qemu-iotests/iotests.py | 15 +++++---
5 files changed, 90 insertions(+), 4 deletions(-)
create mode 100644 tests/qemu-iotests/299
create mode 100644 tests/qemu-iotests/299.out

Expand all Fold all

[PATCH 0/4] Fix crash due to NBD export leak

Posted by Vladimir Sementsov-Ogievskiy 3 years, 10 months ago

Hi all!

We've faced crash bug, which is reproducing on master branch as well.
The case is described in 03, where fix is suggested.
New iotest in 04 crashes without that fix.

Vladimir Sementsov-Ogievskiy (4):
  iotests: QemuIoInteractive: use qemu_io_args_no_fmt
  iotests.py: QemuIoInteractive: print output on failure
  nbd: make client_close synchronous
  iotests: test shutdown when bitmap is exported through NBD

 nbd/server.c                  |  3 ++
 tests/qemu-iotests/299        | 65 +++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/299.out    | 10 ++++++
 tests/qemu-iotests/group      |  1 +
 tests/qemu-iotests/iotests.py | 15 +++++---
 5 files changed, 90 insertions(+), 4 deletions(-)
 create mode 100644 tests/qemu-iotests/299
 create mode 100644 tests/qemu-iotests/299.out

-- 
2.21.0

Re: [PATCH 0/4] Fix crash due to NBD export leak

Posted by no-reply@patchew.org 3 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/20200625142540.24589-1-vsementsov@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Not run: 259
Failures: 140 143
Failed 2 of 120 iotests
make: *** [check-tests/check-block.sh] Error 1
make: *** Waiting for unfinished jobs....
  TEST    check-qtest-aarch64: tests/qtest/qos-test
Traceback (most recent call last):
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=0c91d8fcbb86459aa0e4fb7fbaad61d0', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-xdxld493/src/docker-src.2020-06-25-11.01.00.15808:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=0c91d8fcbb86459aa0e4fb7fbaad61d0
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-xdxld493/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    14m24.488s
user    0m9.266s


The full log is available at
http://patchew.org/logs/20200625142540.24589-1-vsementsov@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com