hw/virtio/virtio-iommu-pci.c: Fix typo in error message

[PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

Posted by Peter Maydell 3 years, 10 months ago

Fix a typo in an error message in virtio_iommu_pci_realize():
"Check you machine" should be "Check your machine".

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/virtio/virtio-iommu-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
index 632533abaf7..32e3215d1df 100644
--- a/hw/virtio/virtio-iommu-pci.c
+++ b/hw/virtio/virtio-iommu-pci.c
@@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
                    "%s machine fails to create iommu-map device tree bindings",
                    mc->name);
         error_append_hint(errp,
-                          "Check you machine implements a hotplug handler "
+                          "Check your machine implements a hotplug handler "
                           "for the virtio-iommu-pci device\n");
         error_append_hint(errp, "Check the guest is booted without FW or with "
                           "-no-acpi\n");
-- 
2.20.1

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

Posted by Auger Eric 3 years, 10 months ago

Hi Peter,

On 6/25/20 12:08 PM, Peter Maydell wrote:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
> 
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

> ---
>  hw/virtio/virtio-iommu-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
>                     "%s machine fails to create iommu-map device tree bindings",
>                     mc->name);
>          error_append_hint(errp,
> -                          "Check you machine implements a hotplug handler "
> +                          "Check your machine implements a hotplug handler "
>                            "for the virtio-iommu-pci device\n");
>          error_append_hint(errp, "Check the guest is booted without FW or with "
>                            "-no-acpi\n");
>

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

Posted by Markus Armbruster 3 years, 9 months ago

Peter Maydell <peter.maydell@linaro.org> writes:

> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/virtio/virtio-iommu-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
>                     "%s machine fails to create iommu-map device tree bindings",
>                     mc->name);
>          error_append_hint(errp,
> -                          "Check you machine implements a hotplug handler "
> +                          "Check your machine implements a hotplug handler "
>                            "for the virtio-iommu-pci device\n");
>          error_append_hint(errp, "Check the guest is booted without FW or with "
>                            "-no-acpi\n");

Since I have a bunch of error reporting patches to merge, I'm taking the
liberty to queue this along with them.  Hope that's okay.  Thanks!

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

Posted by Philippe Mathieu-Daudé 3 years, 10 months ago

On 6/25/20 12:08 PM, Peter Maydell wrote:
> Fix a typo in an error message in virtio_iommu_pci_realize():
> "Check you machine" should be "Check your machine".
> 
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/virtio/virtio-iommu-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c
> index 632533abaf7..32e3215d1df 100644
> --- a/hw/virtio/virtio-iommu-pci.c
> +++ b/hw/virtio/virtio-iommu-pci.c
> @@ -48,7 +48,7 @@ static void virtio_iommu_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
>                     "%s machine fails to create iommu-map device tree bindings",
>                     mc->name);
>          error_append_hint(errp,
> -                          "Check you machine implements a hotplug handler "
> +                          "Check your machine implements a hotplug handler "
>                            "for the virtio-iommu-pci device\n");
>          error_append_hint(errp, "Check the guest is booted without FW or with "
>                            "-no-acpi\n");
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>