testing/next (vm, gitlab, docker)

[PATCH v2 02/25] crypto/linux_keyring: fix 'secret_keyring' configure test

Posted by Alex Bennée 5 years, 7 months ago

From: David Edmondson <david.edmondson@oracle.com>

The configure test for 'secret_keyring' incorrectly checked the
'have_keyring' variable.

Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15
Signed-off-by: David Edmondson <david.edmondson@oracle.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200618092636.71832-1-david.edmondson@oracle.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index ba88fd18244..69ffd750dbc 100755
--- a/configure
+++ b/configure
@@ -6369,7 +6369,7 @@ EOF
 fi
 if test "$secret_keyring" != "no"
 then
-    if test "$have_keyring" == "yes"
+    if test "$have_keyring" = "yes"
     then
 	secret_keyring=yes
     else
-- 
2.20.1

Re: [PATCH v2 02/25] crypto/linux_keyring: fix 'secret_keyring' configure test

Posted by Thomas Huth 5 years, 7 months ago

On 24/06/2020 16.04, Alex Bennée wrote:
> From: David Edmondson <david.edmondson@oracle.com>
> 
> The configure test for 'secret_keyring' incorrectly checked the
> 'have_keyring' variable.
> 
> Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15
> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200618092636.71832-1-david.edmondson@oracle.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ba88fd18244..69ffd750dbc 100755
> --- a/configure
> +++ b/configure
> @@ -6369,7 +6369,7 @@ EOF
>   fi
>   if test "$secret_keyring" != "no"
>   then
> -    if test "$have_keyring" == "yes"
> +    if test "$have_keyring" = "yes"
>       then
>   	secret_keyring=yes
>       else
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>