vvfat: Two small patches

[PATCH 0/2] vvfat: Two small patches

Kevin Wolf posted 2 patches 3 years, 10 months ago

Download series mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch failed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200623175534.38286-1-kwolf@redhat.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block/vvfat.c | 65 ++++++++++++++++++++++-----------------------------
1 file changed, 28 insertions(+), 37 deletions(-)

Expand all Fold all

[PATCH 0/2] vvfat: Two small patches

Posted by Kevin Wolf 3 years, 10 months ago

This fixes two of the four cases (1. and 4.) reported in:

    https://bugs.launchpad.net/qemu/+bug/1883083

The third case I attempted to fix looks a bit more complicated and I
don't have the time right now to learn how vvfat really works, so let's
merge these two patches at least.

Kevin Wolf (2):
  vvfat: Check that updated filenames are valid
  vvfat: Fix array_remove_slice()

 block/vvfat.c | 65 ++++++++++++++++++++++-----------------------------
 1 file changed, 28 insertions(+), 37 deletions(-)

-- 
2.25.4

Re: [PATCH 0/2] vvfat: Two small patches

Posted by no-reply@patchew.org 3 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/20200623175534.38286-1-kwolf@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/2] vvfat: Two small patches
Type: series
Message-id: 20200623175534.38286-1-kwolf@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200623175534.38286-1-kwolf@redhat.com -> patchew/20200623175534.38286-1-kwolf@redhat.com
Switched to a new branch 'test'
5d9f5f1 vvfat: Fix array_remove_slice()
f1dd8bf vvfat: Check that updated filenames are valid

=== OUTPUT BEGIN ===
1/2 Checking commit f1dd8bf731ce (vvfat: Check that updated filenames are valid)
ERROR: "(foo*)" should be "(foo *)"
#31: FILE: block/vvfat.c:526:
+    if (!strcmp((const char*)name, ".") || !strcmp((const char*)name, "..")) {

total: 1 errors, 0 warnings, 35 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 5d9f5f1638af (vvfat: Fix array_remove_slice())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200623175534.38286-1-kwolf@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com