target/ppc: Remove TIDR from POWER10 processor

[PATCH] target/ppc: Remove TIDR from POWER10 processor

Cédric Le Goater posted 1 patch 3 years, 10 months ago

Download mbox

Test FreeBSD passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200623154534.266065-1-clg@kaod.org

target/ppc/translate_init.inc.c | 5 -----
1 file changed, 5 deletions(-)

Expand all Fold all

[PATCH] target/ppc: Remove TIDR from POWER10 processor

Posted by Cédric Le Goater 3 years, 10 months ago

It is not part of Power ISA Version 3.1.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 target/ppc/translate_init.inc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
index a40888411c1a..49212bfd90f2 100644
--- a/target/ppc/translate_init.inc.c
+++ b/target/ppc/translate_init.inc.c
@@ -9086,11 +9086,6 @@ static void init_proc_POWER10(CPUPPCState *env)
     gen_spr_power8_rpr(env);
     gen_spr_power9_mmu(env);
 
-    /* POWER9 Specific registers */
-    spr_register_kvm(env, SPR_TIDR, "TIDR", NULL, NULL,
-                     spr_read_generic, spr_write_generic,
-                     KVM_REG_PPC_TIDR, 0);
-
     /* FIXME: Filter fields properly based on privilege level */
     spr_register_kvm_hv(env, SPR_PSSCR, "PSSCR", NULL, NULL, NULL, NULL,
                         spr_read_generic, spr_write_generic,
-- 
2.25.4

Re: [PATCH] target/ppc: Remove TIDR from POWER10 processor

Posted by David Gibson 3 years, 10 months ago

On Tue, Jun 23, 2020 at 05:45:34PM +0200, Cédric Le Goater wrote:
> It is not part of Power ISA Version 3.1.

Applied to ppc-for-5.1, thanks.

> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  target/ppc/translate_init.inc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
> index a40888411c1a..49212bfd90f2 100644
> --- a/target/ppc/translate_init.inc.c
> +++ b/target/ppc/translate_init.inc.c
> @@ -9086,11 +9086,6 @@ static void init_proc_POWER10(CPUPPCState *env)
>      gen_spr_power8_rpr(env);
>      gen_spr_power9_mmu(env);
>  
> -    /* POWER9 Specific registers */
> -    spr_register_kvm(env, SPR_TIDR, "TIDR", NULL, NULL,
> -                     spr_read_generic, spr_write_generic,
> -                     KVM_REG_PPC_TIDR, 0);
> -
>      /* FIXME: Filter fields properly based on privilege level */
>      spr_register_kvm_hv(env, SPR_PSSCR, "PSSCR", NULL, NULL, NULL, NULL,
>                          spr_read_generic, spr_write_generic,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson