[PATCH 2/5] iotests/041: Skip test_small_target for qed

Max Reitz posted 5 patches 5 years, 7 months ago
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
[PATCH 2/5] iotests/041: Skip test_small_target for qed
Posted by Max Reitz 5 years, 7 months ago
qed does not support shrinking images, so the test_small_target method
should be skipped to keep 041 passing.

Fixes: 16cea4ee1c8e5a69a058e76f426b2e17974d8d7d
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/041 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 601c756117..b843f88a66 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -277,6 +277,8 @@ class TestSingleBlockdev(TestSingleDrive):
         result = self.vm.run_job('job0')
         self.assertEqual(result, 'Source and target image have different sizes')
 
+    # qed does not support shrinking
+    @iotests.skip_for_formats(('qed'))
     def test_small_target(self):
         self.do_test_target_size(self.image_len // 2)
 
-- 
2.26.2


Re: [PATCH 2/5] iotests/041: Skip test_small_target for qed
Posted by Thomas Huth 5 years, 7 months ago
On 17/06/2020 12.48, Max Reitz wrote:
> qed does not support shrinking images, so the test_small_target method
> should be skipped to keep 041 passing.
> 
> Fixes: 16cea4ee1c8e5a69a058e76f426b2e17974d8d7d
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/041 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
> index 601c756117..b843f88a66 100755
> --- a/tests/qemu-iotests/041
> +++ b/tests/qemu-iotests/041
> @@ -277,6 +277,8 @@ class TestSingleBlockdev(TestSingleDrive):
>          result = self.vm.run_job('job0')
>          self.assertEqual(result, 'Source and target image have different sizes')
>  
> +    # qed does not support shrinking
> +    @iotests.skip_for_formats(('qed'))
>      def test_small_target(self):
>          self.do_test_target_size(self.image_len // 2)

Great, now "check -qed 041" works fine for me again! Thanks!

Tested-by: Thomas Huth <thuth@redhat.com>