[v9] acpi: i386 tweaks

[PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs

Gerd Hoffmann posted 10 patches 5 years, 7 months ago

Diff against v1 v2 v3 v4 v5 v6 v7 v8 v10
Download mbox

Maintainers: Richard Henderson <rth@twiddle.net>, Igor Mammedov <imammedo@redhat.com>, John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Thomas Huth <thuth@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

Expand all Fold all

[PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs

Posted by Gerd Hoffmann 5 years, 7 months ago

Makes it easier to create good commit messages from the logs.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 tests/qtest/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index b482f76c03d4..c315156858f4 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -469,7 +469,7 @@ static void test_acpi_asl(test_data *data)
                 fflush(stderr);
                 if (getenv("V")) {
                     const char *diff_env = getenv("DIFF");
-                    const char *diff_cmd = diff_env ? diff_env : "diff -u";
+                    const char *diff_cmd = diff_env ? diff_env : "diff -U 16";
                     char *diff = g_strdup_printf("%s %s %s", diff_cmd,
                                                  exp_sdt->asl_file, sdt->asl_file);
                     int out = dup(STDOUT_FILENO);
-- 
2.18.4

Re: [PATCH v9 01/10] acpi: bios-tables-test: show more context on asl diffs

Posted by Philippe Mathieu-Daudé 5 years, 7 months ago

On 6/17/20 9:11 AM, Gerd Hoffmann wrote:
> Makes it easier to create good commit messages from the logs.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  tests/qtest/bios-tables-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index b482f76c03d4..c315156858f4 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -469,7 +469,7 @@ static void test_acpi_asl(test_data *data)
>                  fflush(stderr);
>                  if (getenv("V")) {
>                      const char *diff_env = getenv("DIFF");
> -                    const char *diff_cmd = diff_env ? diff_env : "diff -u";
> +                    const char *diff_cmd = diff_env ? diff_env : "diff -U 16";
>                      char *diff = g_strdup_printf("%s %s %s", diff_cmd,
>                                                   exp_sdt->asl_file, sdt->asl_file);
>                      int out = dup(STDOUT_FILENO);
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>