Vga 20200615 patches

[PULL 0/4] Vga 20200615 patches

Posted by Gerd Hoffmann 5 years, 5 months ago

The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/vga-20200615-pull-request

for you to fetch changes up to fca0b885417497a973c56e6d4e0d88f9f7a0e71b:

  sm501: Optimise 1 pixel 2d ops (2020-06-15 10:52:53 +0200)

----------------------------------------------------------------
vga: sm501 fixes and optimizations.

----------------------------------------------------------------

BALATON Zoltan (4):
  sm501: Fix bounds checks
  sm501: Drop unneded variable
  sm501: Ignore no-op blits
  sm501: Optimise 1 pixel 2d ops

 hw/display/sm501.c | 58 ++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 48 insertions(+), 10 deletions(-)

-- 
2.18.4

Re: [PULL 0/4] Vga 20200615 patches

Posted by BALATON Zoltan 5 years, 5 months ago

On Mon, 15 Jun 2020, Gerd Hoffmann wrote:
> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
>
>  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100)
>
> are available in the Git repository at:
>
>  git://git.kraxel.org/qemu tags/vga-20200615-pull-request
>
> for you to fetch changes up to fca0b885417497a973c56e6d4e0d88f9f7a0e71b:
>
>  sm501: Optimise 1 pixel 2d ops (2020-06-15 10:52:53 +0200)
>
> ----------------------------------------------------------------
> vga: sm501 fixes and optimizations.
>
> ----------------------------------------------------------------
>
> BALATON Zoltan (4):
>  sm501: Fix bounds checks
>  sm501: Drop unneded variable
>  sm501: Ignore no-op blits
>  sm501: Optimise 1 pixel 2d ops
>
> hw/display/sm501.c | 58 ++++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 48 insertions(+), 10 deletions(-)

Seems you've crossed mails with Peter. He sent some review comments for 
these patches. Should I respin with those changes or you'll take this as 
it is and I should send followup patches?

Regards,
BALATON Zoltan

Re: [PULL 0/4] Vga 20200615 patches

Posted by Peter Maydell 5 years, 5 months ago

On Mon, 15 Jun 2020 at 17:28, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Mon, 15 Jun 2020, Gerd Hoffmann wrote:
> > The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
> >
> >  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100)
> >
> > are available in the Git repository at:
> >
> >  git://git.kraxel.org/qemu tags/vga-20200615-pull-request
> >
> > for you to fetch changes up to fca0b885417497a973c56e6d4e0d88f9f7a0e71b:
> >
> >  sm501: Optimise 1 pixel 2d ops (2020-06-15 10:52:53 +0200)
> >
> > ----------------------------------------------------------------
> > vga: sm501 fixes and optimizations.
> >
> > ----------------------------------------------------------------
> >
> > BALATON Zoltan (4):
> >  sm501: Fix bounds checks
> >  sm501: Drop unneded variable
> >  sm501: Ignore no-op blits
> >  sm501: Optimise 1 pixel 2d ops
> >
> > hw/display/sm501.c | 58 ++++++++++++++++++++++++++++++++++++++--------
> > 1 file changed, 48 insertions(+), 10 deletions(-)
>
> Seems you've crossed mails with Peter. He sent some review comments for
> these patches. Should I respin with those changes or you'll take this as
> it is and I should send followup patches?

I've dropped the pullreq from my to-process queue; if you could respin
the patchset that's probably the best thing I think.

thanks
-- PMM

Re: [PULL 0/4] Vga 20200615 patches

Posted by Peter Maydell 5 years, 5 months ago

On Mon, 15 Jun 2020 at 16:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2020-06-12 23:06:22 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/vga-20200615-pull-request
>
> for you to fetch changes up to fca0b885417497a973c56e6d4e0d88f9f7a0e71b:
>
>   sm501: Optimise 1 pixel 2d ops (2020-06-15 10:52:53 +0200)
>
> ----------------------------------------------------------------
> vga: sm501 fixes and optimizations.
>
> ----------------------------------------------------------------
>
> BALATON Zoltan (4):
>   sm501: Fix bounds checks
>   sm501: Drop unneded variable
>   sm501: Ignore no-op blits
>   sm501: Optimise 1 pixel 2d ops

I just sent reviewed-by tags for patches 1-3 which you haven't
picked up; and patch 4 hasn't been reviewed at all yet :-(

-- PMM