[PATCH 2/4] target/mips: Add comments for vendor-specific ASEs

Jiaxun Yang posted 4 patches 5 years, 5 months ago
Only 3 patches received!
[PATCH 2/4] target/mips: Add comments for vendor-specific ASEs
Posted by Jiaxun Yang 5 years, 5 months ago
Abbreviations of vendor-specific ASEs looks very similiar.
Add comments to explain the full name and vendors of these flags.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 target/mips/mips-defs.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h
index f1b833f947..ed6a7a9e54 100644
--- a/target/mips/mips-defs.h
+++ b/target/mips/mips-defs.h
@@ -57,9 +57,13 @@
 /*
  *   bits 52-63: vendor-specific ASEs
  */
+/* MultiMedia Instructions defined by R5900 */
 #define ASE_MMI           0x0010000000000000ULL
+/* MIPS eXtension/enhanced Unit defined by Ingenic */
 #define ASE_MXU           0x0020000000000000ULL
+/* Loongson MultiMedia Instructions */
 #define ASE_LMMI          0x0040000000000000ULL
+/* Loongson EXTensions */
 #define ASE_LEXT          0x0080000000000000ULL
 
 /* MIPS CPU defines. */
-- 
2.27.0

Re: [PATCH 2/4] target/mips: Add comments for vendor-specific ASEs
Posted by Aleksandar Markovic 5 years, 5 months ago
нед, 14. јун 2020. у 10:03 Jiaxun Yang <jiaxun.yang@flygoat.com> је написао/ла:
>
> Abbreviations of vendor-specific ASEs looks very similiar.
> Add comments to explain the full name and vendors of these flags.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---

Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

Applied to the next mips queue.

>  target/mips/mips-defs.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/target/mips/mips-defs.h b/target/mips/mips-defs.h
> index f1b833f947..ed6a7a9e54 100644
> --- a/target/mips/mips-defs.h
> +++ b/target/mips/mips-defs.h
> @@ -57,9 +57,13 @@
>  /*
>   *   bits 52-63: vendor-specific ASEs
>   */
> +/* MultiMedia Instructions defined by R5900 */
>  #define ASE_MMI           0x0010000000000000ULL
> +/* MIPS eXtension/enhanced Unit defined by Ingenic */
>  #define ASE_MXU           0x0020000000000000ULL
> +/* Loongson MultiMedia Instructions */
>  #define ASE_LMMI          0x0040000000000000ULL
> +/* Loongson EXTensions */
>  #define ASE_LEXT          0x0080000000000000ULL
>
>  /* MIPS CPU defines. */
> --
> 2.27.0