[v1] tpm: Split hw/ vs backends/

[PATCH 2/8] hw/tpm: Include missing 'qemu/option.h' header

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

Files using the TPM_STANDARD_CMDLINE_OPTS macro declared in
"tpm_int.h" will use QEMU_OPT_STRING definition declared in
"qemu/option.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/tpm/tpm_int.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/tpm/tpm_int.h b/hw/tpm/tpm_int.h
index 3fb28a9d6c..fd5ebc6489 100644
--- a/hw/tpm/tpm_int.h
+++ b/hw/tpm/tpm_int.h
@@ -12,6 +12,8 @@
 #ifndef TPM_TPM_INT_H
 #define TPM_TPM_INT_H
 
+#include "qemu/option.h"
+
 #define TPM_STANDARD_CMDLINE_OPTS \
     { \
         .name = "type", \
-- 
2.21.3

Re: [PATCH 2/8] hw/tpm: Include missing 'qemu/option.h' header

Posted by Stefan Berger 5 years, 8 months ago

On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
> Files using the TPM_STANDARD_CMDLINE_OPTS macro declared in
> "tpm_int.h" will use QEMU_OPT_STRING definition declared in
> "qemu/option.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


> ---
>   hw/tpm/tpm_int.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/hw/tpm/tpm_int.h b/hw/tpm/tpm_int.h
> index 3fb28a9d6c..fd5ebc6489 100644
> --- a/hw/tpm/tpm_int.h
> +++ b/hw/tpm/tpm_int.h
> @@ -12,6 +12,8 @@
>   #ifndef TPM_TPM_INT_H
>   #define TPM_TPM_INT_H
>   
> +#include "qemu/option.h"
> +
>   #define TPM_STANDARD_CMDLINE_OPTS \
>       { \
>           .name = "type", \