[v1] tpm: Split hw/ vs backends/

[PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

From CODING_STYLE.rst:

  Do not include "qemu/osdep.h" from header files since the .c
  file will have already included it.

Remove "qemu/osdep.h" from "tpm_tis.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/tpm/tpm_tis.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h
index 5554989395..f6b5872ba6 100644
--- a/hw/tpm/tpm_tis.h
+++ b/hw/tpm/tpm_tis.h
@@ -24,7 +24,6 @@
 #ifndef TPM_TPM_TIS_H
 #define TPM_TPM_TIS_H
 
-#include "qemu/osdep.h"
 #include "sysemu/tpm_backend.h"
 #include "tpm_ppi.h"
 
-- 
2.21.3

Re: [PATCH 1/8] hw/tpm: Do not include 'qemu/osdep.h' in header

Posted by Stefan Berger 5 years, 8 months ago

On 6/10/20 4:02 PM, Philippe Mathieu-Daudé wrote:
>  From CODING_STYLE.rst:
>
>    Do not include "qemu/osdep.h" from header files since the .c
>    file will have already included it.
>
> Remove "qemu/osdep.h" from "tpm_tis.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>


> ---
>   hw/tpm/tpm_tis.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h
> index 5554989395..f6b5872ba6 100644
> --- a/hw/tpm/tpm_tis.h
> +++ b/hw/tpm/tpm_tis.h
> @@ -24,7 +24,6 @@
>   #ifndef TPM_TPM_TIS_H
>   #define TPM_TPM_TIS_H
>   
> -#include "qemu/osdep.h"
>   #include "sysemu/tpm_backend.h"
>   #include "tpm_ppi.h"
>