[PATCH v7 00/22] nvme: small fixes, refactoring and cleanups

Klaus Jensen posted 22 patches 3 years, 10 months ago
Test asan passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200609190333.59390-1-its@irrelevant.dk
Maintainers: Keith Busch <kbusch@kernel.org>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
hw/block/nvme.c       | 576 ++++++++++++++++++++++++------------------
hw/block/nvme.h       |  34 ++-
hw/block/trace-events | 180 ++++++-------
include/block/nvme.h  |   8 +
4 files changed, 459 insertions(+), 339 deletions(-)
[PATCH v7 00/22] nvme: small fixes, refactoring and cleanups
Posted by Klaus Jensen 3 years, 10 months ago
From: Klaus Jensen <k.jensen@samsung.com>

Hi all,

As per our discussion about how to amend the bug I introduced in
"hw/block/nvme: allow use of any valid msix vector", this is a respin
without that patch.

Kevin, it applies cleanly on top of your block tree with all current
hw/block/bnvme patches removed.


Changes since v6
~~~~~~~~~~~~~~~~
* Dropped the goofed "hw/block/nvme: allow use of any valid msix vector"
  patch.

* Included Philippe's "hw/block/nvme: Verify msix_vector_use() returned
  value" patch for posterity.

* Added two patches (requesting reviews):

    1. hw/block/nvme: add msix_qsize parameter
    2. hw/block/nvme: verify msix_init_exclusive_bar() return value

  Kevin, it's up to you if you want to wait for reviews on these two or
  just pick up the rest of the series. But let's see if we can get a
  quick review on them.


Klaus Jensen (21):
  hw/block/nvme: fix pci doorbell size calculation
  hw/block/nvme: rename trace events to pci_nvme
  hw/block/nvme: remove superfluous breaks
  hw/block/nvme: move device parameters to separate struct
  hw/block/nvme: use constants in identify
  hw/block/nvme: refactor nvme_addr_read
  hw/block/nvme: fix pin-based interrupt behavior
  hw/block/nvme: add max_ioqpairs device parameter
  hw/block/nvme: remove redundant cmbloc/cmbsz members
  hw/block/nvme: factor out property/constraint checks
  hw/block/nvme: factor out device state setup
  hw/block/nvme: factor out block backend setup
  hw/block/nvme: add namespace helpers
  hw/block/nvme: factor out namespace setup
  hw/block/nvme: factor out pci setup
  hw/block/nvme: factor out cmb setup
  hw/block/nvme: factor out pmr setup
  hw/block/nvme: do cmb/pmr init as part of pci init
  hw/block/nvme: factor out controller identify setup
  hw/block/nvme: add msix_qsize parameter
  hw/block/nvme: verify msix_init_exclusive_bar() return value

Philippe Mathieu-Daudé (1):
  hw/block/nvme: Verify msix_vector_use() returned value

 hw/block/nvme.c       | 576 ++++++++++++++++++++++++------------------
 hw/block/nvme.h       |  34 ++-
 hw/block/trace-events | 180 ++++++-------
 include/block/nvme.h  |   8 +
 4 files changed, 459 insertions(+), 339 deletions(-)

-- 
2.27.0


Re: [PATCH v7 00/22] nvme: small fixes, refactoring and cleanups
Posted by Kevin Wolf 3 years, 10 months ago
Am 09.06.2020 um 21:03 hat Klaus Jensen geschrieben:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Hi all,
> 
> As per our discussion about how to amend the bug I introduced in
> "hw/block/nvme: allow use of any valid msix vector", this is a respin
> without that patch.
> 
> Kevin, it applies cleanly on top of your block tree with all current
> hw/block/bnvme patches removed.

Thanks, applied to the block branch.

Kevin