[v8] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

[PATCH v8 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Philippe Mathieu-Daudé posted 5 patches 3 years, 10 months ago

Diff against v3 v4 v5 v5 v6 v7 v9 v10
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200609170727.9977-1-philmd@redhat.com

There is a newer version of this series

docs/specs/fw_cfg.txt              |  13 ++-
include/crypto/tls-cipher-suites.h |  38 ++++++++
include/hw/nvram/fw_cfg.h          |  52 ++++++++++
crypto/tls-cipher-suites.c         | 146 +++++++++++++++++++++++++++++
hw/nvram/fw_cfg.c                  |  36 +++++++
softmmu/vl.c                       |  33 +++++--
crypto/Makefile.objs               |   1 +
crypto/trace-events                |   5 +
qemu-options.hx                    |  38 ++++++++
9 files changed, 352 insertions(+), 10 deletions(-)
create mode 100644 include/crypto/tls-cipher-suites.h
create mode 100644 crypto/tls-cipher-suites.c

Expand all Fold all

[PATCH v8 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Posted by Philippe Mathieu-Daudé 3 years, 10 months ago

Hi,

This series has two parts:

- First we add the ability to QOM objects to produce data
  consumable by the fw_cfg device,

- Then we add the tls-cipher-suites object, and let it
  implement the FW_CFG_DATA_GENERATOR interface.

This is required by EDK2 'HTTPS Boot' feature [*] to tell
the guest which TLS ciphers it can use.

** Unresolved item: **
- Should a generated fw_cfg entry use a specific global order?
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg02309.html

^ Gerd can you help?

Since v7:
- addressed Laszlo review comments
  (changes describe in each patch).
Since v6:
- addressed Laszlo & Daniel review comments
Since v5:
- Complete rewrite after chatting with Daniel Berrangé
Since v4:
- Addressed Laszlo comments (see patch#1 description)
Since v3:
- Addressed Markus' comments (do not care about heap)
Since v2:
- Split of
Since v1:
- Addressed Michael and Laszlo comments.

Please review,

Phil.

[*]: https://github.com/tianocore/edk2/blob/master/OvmfPkg/README
v7: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08050.html
v6: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg05448.html
v5: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04525.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04300.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02965.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html

Philippe Mathieu-Daudé (5):
  hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
  softmmu/vl: Let -fw_cfg option take a 'gen_id' argument
  softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace
  crypto: Add tls-cipher-suites object
  crypto/tls-cipher-suites: Produce fw_cfg consumable blob

 docs/specs/fw_cfg.txt              |  13 ++-
 include/crypto/tls-cipher-suites.h |  38 ++++++++
 include/hw/nvram/fw_cfg.h          |  52 ++++++++++
 crypto/tls-cipher-suites.c         | 146 +++++++++++++++++++++++++++++
 hw/nvram/fw_cfg.c                  |  36 +++++++
 softmmu/vl.c                       |  33 +++++--
 crypto/Makefile.objs               |   1 +
 crypto/trace-events                |   5 +
 qemu-options.hx                    |  38 ++++++++
 9 files changed, 352 insertions(+), 10 deletions(-)
 create mode 100644 include/crypto/tls-cipher-suites.h
 create mode 100644 crypto/tls-cipher-suites.c

-- 
2.21.3