[PATCH] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h

Thomas Huth posted 1 patch 3 years, 11 months ago
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200607052022.12222-1-thuth@redhat.com
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h
Posted by Thomas Huth 3 years, 11 months ago
The file tests/qtest/bios-tables-test-allowed-diff.h is currently only
assigned to the qtest section according MAINTAINERS. However, this file
normally only gets updated when the ACPI tables changed - something the
qtest maintainers don't have much clue of. Thus this file should rather
be assigned to the ACPI maintainers instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6e7890ce82..0c5ed09ad5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1531,7 +1531,7 @@ F: hw/acpi/*
 F: hw/smbios/*
 F: hw/i386/acpi-build.[hc]
 F: hw/arm/virt-acpi-build.c
-F: tests/qtest/bios-tables-test.c
+F: tests/qtest/bios-tables-test*
 F: tests/qtest/acpi-utils.[hc]
 F: tests/data/acpi/
 
@@ -2321,6 +2321,7 @@ S: Maintained
 F: qtest.c
 F: accel/qtest.c
 F: tests/qtest/
+X: tests/qtest/bios-tables-test-allowed-diff.h
 
 Device Fuzzing
 M: Alexander Bulekov <alxndr@bu.edu>
-- 
2.18.1


Re: [PATCH] MAINTAINERS: Fix the classification of bios-tables-test-allowed-diff.h
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
On Sun, Jun 7, 2020 at 7:21 AM Thomas Huth <thuth@redhat.com> wrote:
>
> The file tests/qtest/bios-tables-test-allowed-diff.h is currently only
> assigned to the qtest section according MAINTAINERS. However, this file
> normally only gets updated when the ACPI tables changed - something the
> qtest maintainers don't have much clue of. Thus this file should rather
> be assigned to the ACPI maintainers instead.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6e7890ce82..0c5ed09ad5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1531,7 +1531,7 @@ F: hw/acpi/*
>  F: hw/smbios/*
>  F: hw/i386/acpi-build.[hc]
>  F: hw/arm/virt-acpi-build.c
> -F: tests/qtest/bios-tables-test.c
> +F: tests/qtest/bios-tables-test*
>  F: tests/qtest/acpi-utils.[hc]
>  F: tests/data/acpi/
>
> @@ -2321,6 +2321,7 @@ S: Maintained
>  F: qtest.c
>  F: accel/qtest.c
>  F: tests/qtest/
> +X: tests/qtest/bios-tables-test-allowed-diff.h
>
>  Device Fuzzing
>  M: Alexander Bulekov <alxndr@bu.edu>
> --
> 2.18.1
>
>