1 | Arm queue; some of the simpler stuff, things other have reviewed (thanks!), etc. | 1 | A grab-bag of minor stuff for the end of the year. My to-review |
---|---|---|---|
2 | queue is not empty, but it it at least in single figures... | ||
2 | 3 | ||
3 | -- PMM | 4 | -- PMM |
4 | 5 | ||
5 | The following changes since commit 5d2f557b47dfbf8f23277a5bdd8473d4607c681a: | 6 | The following changes since commit 5bfbd8170ce7acb98a1834ff49ed7340b0837144: |
6 | 7 | ||
7 | Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200605-pull-request' into staging (2020-06-05 13:53:05 +0100) | 8 | Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-pull-request' into staging (2020-12-14 20:32:38 +0000) |
8 | 9 | ||
9 | are available in the Git repository at: | 10 | are available in the Git repository at: |
10 | 11 | ||
11 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200605 | 12 | https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20201215 |
12 | 13 | ||
13 | for you to fetch changes up to 2c35a39eda0b16c2ed85c94cec204bf5efb97812: | 14 | for you to fetch changes up to 23af268566069183285bebbdf95b1b37cb7c0942: |
14 | 15 | ||
15 | target/arm: Convert Neon one-register-and-immediate insns to decodetree (2020-06-05 17:23:10 +0100) | 16 | hw/block/m25p80: Fix Numonyx fast read dummy cycle count (2020-12-15 13:39:30 +0000) |
16 | 17 | ||
17 | ---------------------------------------------------------------- | 18 | ---------------------------------------------------------------- |
18 | target-arm queue: | 19 | target-arm queue: |
19 | hw/ssi/imx_spi: Handle tx burst lengths other than 8 correctly | 20 | * gdbstub: Correct misparsing of vCont C/S requests |
20 | hw/input/pxa2xx_keypad: Replace hw_error() by qemu_log_mask() | 21 | * openrisc: Move pic_cpu code into CPU object proper |
21 | hw/arm/pxa2xx: Replace printf() call by qemu_log_mask() | 22 | * nios2: Move IIC code into CPU object proper |
22 | target/arm: Convert crypto insns to gvec | 23 | * Improve reporting of ROM overlap errors |
23 | hw/adc/stm32f2xx_adc: Correct memory region size and access size | 24 | * xlnx-versal: Add USB support |
24 | tests/acceptance: Add a boot test for the xlnx-versal-virt machine | 25 | * hw/misc/zynq_slcr: Avoid #DIV/0! error |
25 | docs/system: Document Aspeed boards | 26 | * Numonyx: Fix dummy cycles and check for SPI mode on cmds |
26 | raspi: Add model of the USB controller | ||
27 | target/arm: Convert 2-reg-and-shift and 1-reg-imm Neon insns to decodetree | ||
28 | 27 | ||
29 | ---------------------------------------------------------------- | 28 | ---------------------------------------------------------------- |
30 | Cédric Le Goater (1): | 29 | Joe Komlodi (4): |
31 | docs/system: Document Aspeed boards | 30 | hw/block/m25p80: Make Numonyx config field names more accurate |
31 | hw/block/m25p80: Fix when VCFG XIP bit is set for Numonyx | ||
32 | hw/block/m25p80: Check SPI mode before running some Numonyx commands | ||
33 | hw/block/m25p80: Fix Numonyx fast read dummy cycle count | ||
32 | 34 | ||
33 | Eden Mikitas (2): | 35 | Peter Maydell (11): |
34 | hw/ssi/imx_spi: changed while statement to prevent underflow | 36 | gdbstub: Correct misparsing of vCont C/S requests |
35 | hw/ssi/imx_spi: Removed unnecessary cast of rx data received from slave | 37 | hw/openrisc/openrisc_sim: Use IRQ splitter when connecting IRQ to multiple CPUs |
38 | hw/openrisc/openrisc_sim: Abstract out "get IRQ x of CPU y" | ||
39 | target/openrisc: Move pic_cpu code into CPU object proper | ||
40 | target/nios2: Move IIC code into CPU object proper | ||
41 | target/nios2: Move nios2_check_interrupts() into target/nios2 | ||
42 | target/nios2: Use deposit32() to update ipending register | ||
43 | hw/core/loader.c: Track last-seen ROM in rom_check_and_register_reset() | ||
44 | hw/core/loader.c: Improve reporting of ROM overlap errors | ||
45 | elf_ops.h: Don't truncate name of the ROM blobs we create | ||
46 | elf_ops.h: Be more verbose with ROM blob names | ||
36 | 47 | ||
37 | Paul Zimmerman (7): | 48 | Philippe Mathieu-Daudé (1): |
38 | raspi: add BCM2835 SOC MPHI emulation | 49 | hw/misc/zynq_slcr: Avoid #DIV/0! error |
39 | dwc-hsotg (dwc2) USB host controller register definitions | ||
40 | dwc-hsotg (dwc2) USB host controller state definitions | ||
41 | dwc-hsotg (dwc2) USB host controller emulation | ||
42 | usb: add short-packet handling to usb-storage driver | ||
43 | wire in the dwc-hsotg (dwc2) USB host controller emulation | ||
44 | raspi2 acceptance test: add test for dwc-hsotg (dwc2) USB host | ||
45 | 50 | ||
46 | Peter Maydell (9): | 51 | Sai Pavan Boddu (2): |
47 | target/arm: Convert Neon VSHL and VSLI 2-reg-shift insn to decodetree | 52 | usb: Add versal-usb2-ctrl-regs module |
48 | target/arm: Convert Neon VSHR 2-reg-shift insns to decodetree | 53 | usb: xlnx-usb-subsystem: Add xilinx usb subsystem |
49 | target/arm: Convert Neon VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree | ||
50 | target/arm: Convert VQSHLU, VQSHL 2-reg-shift insns to decodetree | ||
51 | target/arm: Convert Neon narrowing shifts with op==8 to decodetree | ||
52 | target/arm: Convert Neon narrowing shifts with op==9 to decodetree | ||
53 | target/arm: Convert Neon VSHLL, VMOVL to decodetree | ||
54 | target/arm: Convert VCVT fixed-point ops to decodetree | ||
55 | target/arm: Convert Neon one-register-and-immediate insns to decodetree | ||
56 | 54 | ||
57 | Philippe Mathieu-Daudé (3): | 55 | Vikram Garhwal (2): |
58 | hw/input/pxa2xx_keypad: Replace hw_error() by qemu_log_mask() | 56 | usb: Add DWC3 model |
59 | hw/arm/pxa2xx: Replace printf() call by qemu_log_mask() | 57 | arm: xlnx-versal: Connect usb to virt-versal |
60 | hw/adc/stm32f2xx_adc: Correct memory region size and access size | ||
61 | 58 | ||
62 | Richard Henderson (6): | 59 | include/hw/arm/xlnx-versal.h | 9 + |
63 | target/arm: Convert aes and sm4 to gvec helpers | 60 | include/hw/elf_ops.h | 5 +- |
64 | target/arm: Convert rax1 to gvec helpers | 61 | include/hw/usb/hcd-dwc3.h | 55 +++ |
65 | target/arm: Convert sha512 and sm3 to gvec helpers | 62 | include/hw/usb/xlnx-usb-subsystem.h | 45 ++ |
66 | target/arm: Convert sha1 and sha256 to gvec helpers | 63 | include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 45 ++ |
67 | target/arm: Split helper_crypto_sha1_3reg | 64 | target/nios2/cpu.h | 3 - |
68 | target/arm: Split helper_crypto_sm3tt | 65 | target/openrisc/cpu.h | 1 - |
66 | gdbstub.c | 2 +- | ||
67 | hw/arm/xlnx-versal-virt.c | 55 +++ | ||
68 | hw/arm/xlnx-versal.c | 26 ++ | ||
69 | hw/block/m25p80.c | 158 +++++-- | ||
70 | hw/core/loader.c | 67 ++- | ||
71 | hw/intc/nios2_iic.c | 95 ---- | ||
72 | hw/misc/zynq_slcr.c | 5 + | ||
73 | hw/nios2/10m50_devboard.c | 13 +- | ||
74 | hw/nios2/cpu_pic.c | 67 --- | ||
75 | hw/openrisc/openrisc_sim.c | 46 +- | ||
76 | hw/openrisc/pic_cpu.c | 61 --- | ||
77 | hw/usb/hcd-dwc3.c | 689 ++++++++++++++++++++++++++++ | ||
78 | hw/usb/xlnx-usb-subsystem.c | 94 ++++ | ||
79 | hw/usb/xlnx-versal-usb2-ctrl-regs.c | 229 +++++++++ | ||
80 | softmmu/vl.c | 1 - | ||
81 | target/nios2/cpu.c | 29 ++ | ||
82 | target/nios2/op_helper.c | 9 + | ||
83 | target/openrisc/cpu.c | 32 ++ | ||
84 | MAINTAINERS | 1 - | ||
85 | hw/intc/meson.build | 1 - | ||
86 | hw/nios2/meson.build | 2 +- | ||
87 | hw/openrisc/Kconfig | 1 + | ||
88 | hw/openrisc/meson.build | 2 +- | ||
89 | hw/usb/Kconfig | 10 + | ||
90 | hw/usb/meson.build | 3 + | ||
91 | 32 files changed, 1557 insertions(+), 304 deletions(-) | ||
92 | create mode 100644 include/hw/usb/hcd-dwc3.h | ||
93 | create mode 100644 include/hw/usb/xlnx-usb-subsystem.h | ||
94 | create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | ||
95 | delete mode 100644 hw/intc/nios2_iic.c | ||
96 | delete mode 100644 hw/nios2/cpu_pic.c | ||
97 | delete mode 100644 hw/openrisc/pic_cpu.c | ||
98 | create mode 100644 hw/usb/hcd-dwc3.c | ||
99 | create mode 100644 hw/usb/xlnx-usb-subsystem.c | ||
100 | create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c | ||
69 | 101 | ||
70 | Thomas Huth (1): | ||
71 | tests/acceptance: Add a boot test for the xlnx-versal-virt machine | ||
72 | |||
73 | docs/system/arm/aspeed.rst | 85 ++ | ||
74 | docs/system/target-arm.rst | 1 + | ||
75 | hw/usb/hcd-dwc2.h | 190 +++++ | ||
76 | include/hw/arm/bcm2835_peripherals.h | 5 +- | ||
77 | include/hw/misc/bcm2835_mphi.h | 44 + | ||
78 | include/hw/usb/dwc2-regs.h | 899 ++++++++++++++++++++ | ||
79 | target/arm/helper.h | 45 +- | ||
80 | target/arm/translate-a64.h | 3 + | ||
81 | target/arm/vec_internal.h | 33 + | ||
82 | target/arm/neon-dp.decode | 214 ++++- | ||
83 | hw/adc/stm32f2xx_adc.c | 4 +- | ||
84 | hw/arm/bcm2835_peripherals.c | 38 +- | ||
85 | hw/arm/pxa2xx.c | 66 +- | ||
86 | hw/input/pxa2xx_keypad.c | 10 +- | ||
87 | hw/misc/bcm2835_mphi.c | 191 +++++ | ||
88 | hw/ssi/imx_spi.c | 4 +- | ||
89 | hw/usb/dev-storage.c | 15 +- | ||
90 | hw/usb/hcd-dwc2.c | 1417 ++++++++++++++++++++++++++++++++ | ||
91 | target/arm/crypto_helper.c | 267 ++++-- | ||
92 | target/arm/translate-a64.c | 198 ++--- | ||
93 | target/arm/translate-neon.inc.c | 796 ++++++++++++++---- | ||
94 | target/arm/translate.c | 539 +----------- | ||
95 | target/arm/vec_helper.c | 12 +- | ||
96 | hw/misc/Makefile.objs | 1 + | ||
97 | hw/usb/Kconfig | 5 + | ||
98 | hw/usb/Makefile.objs | 1 + | ||
99 | hw/usb/trace-events | 50 ++ | ||
100 | tests/acceptance/boot_linux_console.py | 35 +- | ||
101 | 28 files changed, 4258 insertions(+), 910 deletions(-) | ||
102 | create mode 100644 docs/system/arm/aspeed.rst | ||
103 | create mode 100644 hw/usb/hcd-dwc2.h | ||
104 | create mode 100644 include/hw/misc/bcm2835_mphi.h | ||
105 | create mode 100644 include/hw/usb/dwc2-regs.h | ||
106 | create mode 100644 target/arm/vec_internal.h | ||
107 | create mode 100644 hw/misc/bcm2835_mphi.c | ||
108 | create mode 100644 hw/usb/hcd-dwc2.c | ||
109 | diff view generated by jsdifflib |
1 | From: Eden Mikitas <e.mikitas@gmail.com> | 1 | In the vCont packet, two of the command actions (C and S) take an |
---|---|---|---|
2 | argument specifying the signal to be sent to the process/thread, which is | ||
3 | sent as an ASCII string of two hex digits which immediately follow the | ||
4 | 'C' or 'S' character. | ||
2 | 5 | ||
3 | The while statement in question only checked if tx_burst is not 0. | 6 | Our code for parsing this packet accidentally skipped the first of the |
4 | tx_burst is a signed int, which is assigned the value put by the | 7 | two bytes of the signal value, because it started parsing the hex string |
5 | guest driver in ECSPI_CONREG. The burst length can be anywhere | 8 | at 'p + 1' when the preceding code had already moved past the 'C' or |
6 | between 1 and 4096, and since tx_burst is always decremented by 8 | 9 | 'S' with "cur_action = *p++". |
7 | it could possibly underflow, causing an infinite loop. | ||
8 | 10 | ||
9 | Signed-off-by: Eden Mikitas <e.mikitas@gmail.com> | 11 | This meant that we would only do the right thing for signals below |
10 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | 12 | 10, and would misinterpret the rest. For instance, when the debugger |
13 | wants to send the process a SIGPROF (27 on x86-64) we mangle this into | ||
14 | a SIGSEGV (11). | ||
15 | |||
16 | Remove the accidental double increment. | ||
17 | |||
18 | Fixes: https://bugs.launchpad.net/qemu/+bug/1773743 | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 19 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
20 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
21 | Reviewed-by: Alex Bennée <alex.bennee@linaro.org> | ||
22 | Message-id: 20201121210342.10089-1-peter.maydell@linaro.org | ||
12 | --- | 23 | --- |
13 | hw/ssi/imx_spi.c | 2 +- | 24 | gdbstub.c | 2 +- |
14 | 1 file changed, 1 insertion(+), 1 deletion(-) | 25 | 1 file changed, 1 insertion(+), 1 deletion(-) |
15 | 26 | ||
16 | diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c | 27 | diff --git a/gdbstub.c b/gdbstub.c |
17 | index XXXXXXX..XXXXXXX 100644 | 28 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/hw/ssi/imx_spi.c | 29 | --- a/gdbstub.c |
19 | +++ b/hw/ssi/imx_spi.c | 30 | +++ b/gdbstub.c |
20 | @@ -XXX,XX +XXX,XX @@ static void imx_spi_flush_txfifo(IMXSPIState *s) | 31 | @@ -XXX,XX +XXX,XX @@ static int gdb_handle_vcont(const char *p) |
21 | 32 | cur_action = *p++; | |
22 | rx = 0; | 33 | if (cur_action == 'C' || cur_action == 'S') { |
23 | 34 | cur_action = qemu_tolower(cur_action); | |
24 | - while (tx_burst) { | 35 | - res = qemu_strtoul(p + 1, &p, 16, &tmp); |
25 | + while (tx_burst > 0) { | 36 | + res = qemu_strtoul(p, &p, 16, &tmp); |
26 | uint8_t byte = tx & 0xff; | 37 | if (res) { |
27 | 38 | goto out; | |
28 | DPRINTF("writing 0x%02x\n", (uint32_t)byte); | 39 | } |
29 | -- | 40 | -- |
30 | 2.20.1 | 41 | 2.20.1 |
31 | 42 | ||
32 | 43 | diff view generated by jsdifflib |
1 | Convert the insns in the one-register-and-immediate group to decodetree. | 1 | openrisc_sim_net_init() attempts to connect the IRQ line from the |
---|---|---|---|
2 | ethernet device to both CPUs in an SMP configuration by simply caling | ||
3 | sysbus_connect_irq() for it twice. This doesn't work, because the | ||
4 | second connection simply overrides the first. | ||
2 | 5 | ||
3 | In the new decode, our asimd_imm_const() function returns a 64-bit value | 6 | Fix this by creating a TYPE_SPLIT_IRQ to split the IRQ in the SMP |
4 | rather than a 32-bit one, which means we don't need to treat cmode=14 op=1 | 7 | case. |
5 | as a special case in the decoder (it is the only encoding where the two | ||
6 | halves of the 64-bit value are different). | ||
7 | 8 | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 10 | Reviewed-by: Stafford Horne <shorne@gmail.com> |
10 | Message-id: 20200522145520.6778-10-peter.maydell@linaro.org | 11 | Message-id: 20201127225127.14770-2-peter.maydell@linaro.org |
11 | --- | 12 | --- |
12 | target/arm/neon-dp.decode | 22 ++++++ | 13 | hw/openrisc/openrisc_sim.c | 13 +++++++++++-- |
13 | target/arm/translate-neon.inc.c | 118 ++++++++++++++++++++++++++++++++ | 14 | hw/openrisc/Kconfig | 1 + |
14 | target/arm/translate.c | 101 +-------------------------- | 15 | 2 files changed, 12 insertions(+), 2 deletions(-) |
15 | 3 files changed, 142 insertions(+), 99 deletions(-) | ||
16 | 16 | ||
17 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 17 | diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c |
18 | index XXXXXXX..XXXXXXX 100644 | 18 | index XXXXXXX..XXXXXXX 100644 |
19 | --- a/target/arm/neon-dp.decode | 19 | --- a/hw/openrisc/openrisc_sim.c |
20 | +++ b/target/arm/neon-dp.decode | 20 | +++ b/hw/openrisc/openrisc_sim.c |
21 | @@ -XXX,XX +XXX,XX @@ VCVT_SF_2sh 1111 001 0 1 . ...... .... 1110 0 . . 1 .... @2reg_vcvt | 21 | @@ -XXX,XX +XXX,XX @@ |
22 | VCVT_UF_2sh 1111 001 1 1 . ...... .... 1110 0 . . 1 .... @2reg_vcvt | 22 | #include "hw/sysbus.h" |
23 | VCVT_FS_2sh 1111 001 0 1 . ...... .... 1111 0 . . 1 .... @2reg_vcvt | 23 | #include "sysemu/qtest.h" |
24 | VCVT_FU_2sh 1111 001 1 1 . ...... .... 1111 0 . . 1 .... @2reg_vcvt | 24 | #include "sysemu/reset.h" |
25 | + | 25 | +#include "hw/core/split-irq.h" |
26 | +###################################################################### | 26 | |
27 | +# 1-reg-and-modified-immediate grouping: | 27 | #define KERNEL_LOAD_ADDR 0x100 |
28 | +# 1111 001 i 1 D 000 imm:3 Vd:4 cmode:4 0 Q op 1 Vm:4 | 28 | |
29 | +###################################################################### | 29 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_net_init(hwaddr base, hwaddr descriptors, |
30 | + | 30 | |
31 | +&1reg_imm vd q imm cmode op | 31 | s = SYS_BUS_DEVICE(dev); |
32 | + | 32 | sysbus_realize_and_unref(s, &error_fatal); |
33 | +%asimd_imm_value 24:1 16:3 0:4 | 33 | - for (i = 0; i < num_cpus; i++) { |
34 | + | 34 | - sysbus_connect_irq(s, 0, cpu_irqs[i][irq_pin]); |
35 | +@1reg_imm .... ... . . . ... ... .... .... . q:1 . . .... \ | 35 | + if (num_cpus > 1) { |
36 | + &1reg_imm imm=%asimd_imm_value vd=%vd_dp | 36 | + DeviceState *splitter = qdev_new(TYPE_SPLIT_IRQ); |
37 | + | 37 | + qdev_prop_set_uint32(splitter, "num-lines", num_cpus); |
38 | +# The cmode/op bits here decode VORR/VBIC/VMOV/VMNV, but | 38 | + qdev_realize_and_unref(splitter, NULL, &error_fatal); |
39 | +# not in a way we can conveniently represent in decodetree without | 39 | + for (i = 0; i < num_cpus; i++) { |
40 | +# a lot of repetition: | 40 | + qdev_connect_gpio_out(splitter, i, cpu_irqs[i][irq_pin]); |
41 | +# VORR: op=0, (cmode & 1) && cmode < 12 | 41 | + } |
42 | +# VBIC: op=1, (cmode & 1) && cmode < 12 | 42 | + sysbus_connect_irq(s, 0, qdev_get_gpio_in(splitter, 0)); |
43 | +# VMOV: everything else | 43 | + } else { |
44 | +# So we have a single decode line and check the cmode/op in the | 44 | + sysbus_connect_irq(s, 0, cpu_irqs[0][irq_pin]); |
45 | +# trans function. | 45 | } |
46 | +Vimm_1r 1111 001 . 1 . 000 ... .... cmode:4 0 . op:1 1 .... @1reg_imm | 46 | sysbus_mmio_map(s, 0, base); |
47 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | 47 | sysbus_mmio_map(s, 1, descriptors); |
48 | diff --git a/hw/openrisc/Kconfig b/hw/openrisc/Kconfig | ||
48 | index XXXXXXX..XXXXXXX 100644 | 49 | index XXXXXXX..XXXXXXX 100644 |
49 | --- a/target/arm/translate-neon.inc.c | 50 | --- a/hw/openrisc/Kconfig |
50 | +++ b/target/arm/translate-neon.inc.c | 51 | +++ b/hw/openrisc/Kconfig |
51 | @@ -XXX,XX +XXX,XX @@ DO_FP_2SH(VCVT_SF, gen_helper_vfp_sltos) | 52 | @@ -XXX,XX +XXX,XX @@ config OR1K_SIM |
52 | DO_FP_2SH(VCVT_UF, gen_helper_vfp_ultos) | 53 | select SERIAL |
53 | DO_FP_2SH(VCVT_FS, gen_helper_vfp_tosls_round_to_zero) | 54 | select OPENCORES_ETH |
54 | DO_FP_2SH(VCVT_FU, gen_helper_vfp_touls_round_to_zero) | 55 | select OMPIC |
55 | + | 56 | + select SPLIT_IRQ |
56 | +static uint64_t asimd_imm_const(uint32_t imm, int cmode, int op) | ||
57 | +{ | ||
58 | + /* | ||
59 | + * Expand the encoded constant. | ||
60 | + * Note that cmode = 2,3,4,5,6,7,10,11,12,13 imm=0 is UNPREDICTABLE. | ||
61 | + * We choose to not special-case this and will behave as if a | ||
62 | + * valid constant encoding of 0 had been given. | ||
63 | + * cmode = 15 op = 1 must UNDEF; we assume decode has handled that. | ||
64 | + */ | ||
65 | + switch (cmode) { | ||
66 | + case 0: case 1: | ||
67 | + /* no-op */ | ||
68 | + break; | ||
69 | + case 2: case 3: | ||
70 | + imm <<= 8; | ||
71 | + break; | ||
72 | + case 4: case 5: | ||
73 | + imm <<= 16; | ||
74 | + break; | ||
75 | + case 6: case 7: | ||
76 | + imm <<= 24; | ||
77 | + break; | ||
78 | + case 8: case 9: | ||
79 | + imm |= imm << 16; | ||
80 | + break; | ||
81 | + case 10: case 11: | ||
82 | + imm = (imm << 8) | (imm << 24); | ||
83 | + break; | ||
84 | + case 12: | ||
85 | + imm = (imm << 8) | 0xff; | ||
86 | + break; | ||
87 | + case 13: | ||
88 | + imm = (imm << 16) | 0xffff; | ||
89 | + break; | ||
90 | + case 14: | ||
91 | + if (op) { | ||
92 | + /* | ||
93 | + * This is the only case where the top and bottom 32 bits | ||
94 | + * of the encoded constant differ. | ||
95 | + */ | ||
96 | + uint64_t imm64 = 0; | ||
97 | + int n; | ||
98 | + | ||
99 | + for (n = 0; n < 8; n++) { | ||
100 | + if (imm & (1 << n)) { | ||
101 | + imm64 |= (0xffULL << (n * 8)); | ||
102 | + } | ||
103 | + } | ||
104 | + return imm64; | ||
105 | + } | ||
106 | + imm |= (imm << 8) | (imm << 16) | (imm << 24); | ||
107 | + break; | ||
108 | + case 15: | ||
109 | + imm = ((imm & 0x80) << 24) | ((imm & 0x3f) << 19) | ||
110 | + | ((imm & 0x40) ? (0x1f << 25) : (1 << 30)); | ||
111 | + break; | ||
112 | + } | ||
113 | + if (op) { | ||
114 | + imm = ~imm; | ||
115 | + } | ||
116 | + return dup_const(MO_32, imm); | ||
117 | +} | ||
118 | + | ||
119 | +static bool do_1reg_imm(DisasContext *s, arg_1reg_imm *a, | ||
120 | + GVecGen2iFn *fn) | ||
121 | +{ | ||
122 | + uint64_t imm; | ||
123 | + int reg_ofs, vec_size; | ||
124 | + | ||
125 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
126 | + return false; | ||
127 | + } | ||
128 | + | ||
129 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
130 | + if (!dc_isar_feature(aa32_simd_r32, s) && (a->vd & 0x10)) { | ||
131 | + return false; | ||
132 | + } | ||
133 | + | ||
134 | + if (a->vd & a->q) { | ||
135 | + return false; | ||
136 | + } | ||
137 | + | ||
138 | + if (!vfp_access_check(s)) { | ||
139 | + return true; | ||
140 | + } | ||
141 | + | ||
142 | + reg_ofs = neon_reg_offset(a->vd, 0); | ||
143 | + vec_size = a->q ? 16 : 8; | ||
144 | + imm = asimd_imm_const(a->imm, a->cmode, a->op); | ||
145 | + | ||
146 | + fn(MO_64, reg_ofs, reg_ofs, imm, vec_size, vec_size); | ||
147 | + return true; | ||
148 | +} | ||
149 | + | ||
150 | +static void gen_VMOV_1r(unsigned vece, uint32_t dofs, uint32_t aofs, | ||
151 | + int64_t c, uint32_t oprsz, uint32_t maxsz) | ||
152 | +{ | ||
153 | + tcg_gen_gvec_dup_imm(MO_64, dofs, oprsz, maxsz, c); | ||
154 | +} | ||
155 | + | ||
156 | +static bool trans_Vimm_1r(DisasContext *s, arg_1reg_imm *a) | ||
157 | +{ | ||
158 | + /* Handle decode of cmode/op here between VORR/VBIC/VMOV */ | ||
159 | + GVecGen2iFn *fn; | ||
160 | + | ||
161 | + if ((a->cmode & 1) && a->cmode < 12) { | ||
162 | + /* for op=1, the imm will be inverted, so BIC becomes AND. */ | ||
163 | + fn = a->op ? tcg_gen_gvec_andi : tcg_gen_gvec_ori; | ||
164 | + } else { | ||
165 | + /* There is one unallocated cmode/op combination in this space */ | ||
166 | + if (a->cmode == 15 && a->op == 1) { | ||
167 | + return false; | ||
168 | + } | ||
169 | + fn = gen_VMOV_1r; | ||
170 | + } | ||
171 | + return do_1reg_imm(s, a, fn); | ||
172 | +} | ||
173 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
174 | index XXXXXXX..XXXXXXX 100644 | ||
175 | --- a/target/arm/translate.c | ||
176 | +++ b/target/arm/translate.c | ||
177 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
178 | /* Three register same length: handled by decodetree */ | ||
179 | return 1; | ||
180 | } else if (insn & (1 << 4)) { | ||
181 | - if ((insn & 0x00380080) != 0) { | ||
182 | - /* Two registers and shift: handled by decodetree */ | ||
183 | - return 1; | ||
184 | - } else { /* (insn & 0x00380080) == 0 */ | ||
185 | - int invert, reg_ofs, vec_size; | ||
186 | - | ||
187 | - if (q && (rd & 1)) { | ||
188 | - return 1; | ||
189 | - } | ||
190 | - | ||
191 | - op = (insn >> 8) & 0xf; | ||
192 | - /* One register and immediate. */ | ||
193 | - imm = (u << 7) | ((insn >> 12) & 0x70) | (insn & 0xf); | ||
194 | - invert = (insn & (1 << 5)) != 0; | ||
195 | - /* Note that op = 2,3,4,5,6,7,10,11,12,13 imm=0 is UNPREDICTABLE. | ||
196 | - * We choose to not special-case this and will behave as if a | ||
197 | - * valid constant encoding of 0 had been given. | ||
198 | - */ | ||
199 | - switch (op) { | ||
200 | - case 0: case 1: | ||
201 | - /* no-op */ | ||
202 | - break; | ||
203 | - case 2: case 3: | ||
204 | - imm <<= 8; | ||
205 | - break; | ||
206 | - case 4: case 5: | ||
207 | - imm <<= 16; | ||
208 | - break; | ||
209 | - case 6: case 7: | ||
210 | - imm <<= 24; | ||
211 | - break; | ||
212 | - case 8: case 9: | ||
213 | - imm |= imm << 16; | ||
214 | - break; | ||
215 | - case 10: case 11: | ||
216 | - imm = (imm << 8) | (imm << 24); | ||
217 | - break; | ||
218 | - case 12: | ||
219 | - imm = (imm << 8) | 0xff; | ||
220 | - break; | ||
221 | - case 13: | ||
222 | - imm = (imm << 16) | 0xffff; | ||
223 | - break; | ||
224 | - case 14: | ||
225 | - imm |= (imm << 8) | (imm << 16) | (imm << 24); | ||
226 | - if (invert) { | ||
227 | - imm = ~imm; | ||
228 | - } | ||
229 | - break; | ||
230 | - case 15: | ||
231 | - if (invert) { | ||
232 | - return 1; | ||
233 | - } | ||
234 | - imm = ((imm & 0x80) << 24) | ((imm & 0x3f) << 19) | ||
235 | - | ((imm & 0x40) ? (0x1f << 25) : (1 << 30)); | ||
236 | - break; | ||
237 | - } | ||
238 | - if (invert) { | ||
239 | - imm = ~imm; | ||
240 | - } | ||
241 | - | ||
242 | - reg_ofs = neon_reg_offset(rd, 0); | ||
243 | - vec_size = q ? 16 : 8; | ||
244 | - | ||
245 | - if (op & 1 && op < 12) { | ||
246 | - if (invert) { | ||
247 | - /* The immediate value has already been inverted, | ||
248 | - * so BIC becomes AND. | ||
249 | - */ | ||
250 | - tcg_gen_gvec_andi(MO_32, reg_ofs, reg_ofs, imm, | ||
251 | - vec_size, vec_size); | ||
252 | - } else { | ||
253 | - tcg_gen_gvec_ori(MO_32, reg_ofs, reg_ofs, imm, | ||
254 | - vec_size, vec_size); | ||
255 | - } | ||
256 | - } else { | ||
257 | - /* VMOV, VMVN. */ | ||
258 | - if (op == 14 && invert) { | ||
259 | - TCGv_i64 t64 = tcg_temp_new_i64(); | ||
260 | - | ||
261 | - for (pass = 0; pass <= q; ++pass) { | ||
262 | - uint64_t val = 0; | ||
263 | - int n; | ||
264 | - | ||
265 | - for (n = 0; n < 8; n++) { | ||
266 | - if (imm & (1 << (n + pass * 8))) { | ||
267 | - val |= 0xffull << (n * 8); | ||
268 | - } | ||
269 | - } | ||
270 | - tcg_gen_movi_i64(t64, val); | ||
271 | - neon_store_reg64(t64, rd + pass); | ||
272 | - } | ||
273 | - tcg_temp_free_i64(t64); | ||
274 | - } else { | ||
275 | - tcg_gen_gvec_dup_imm(MO_32, reg_ofs, vec_size, | ||
276 | - vec_size, imm); | ||
277 | - } | ||
278 | - } | ||
279 | - } | ||
280 | + /* Two registers and shift or reg and imm: handled by decodetree */ | ||
281 | + return 1; | ||
282 | } else { /* (insn & 0x00800010 == 0x00800000) */ | ||
283 | if (size != 3) { | ||
284 | op = (insn >> 8) & 0xf; | ||
285 | -- | 57 | -- |
286 | 2.20.1 | 58 | 2.20.1 |
287 | 59 | ||
288 | 60 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | We're about to refactor the OpenRISC pic_cpu code in a way that means |
---|---|---|---|
2 | that just grabbing the whole qemu_irq[] array of inbound IRQs for a | ||
3 | CPU won't be possible any more. Abstract out a function for "return | ||
4 | the qemu_irq for IRQ x input of CPU y" so we can more easily replace | ||
5 | the implementation. | ||
2 | 6 | ||
3 | Rather than passing an opcode to a helper, fully decode the | 7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
4 | operation at translate time. Use clear_tail_16 to zap the | 8 | Reviewed-by: Stafford Horne <shorne@gmail.com> |
5 | balance of the SVE register with the AdvSIMD write. | 9 | Message-id: 20201127225127.14770-3-peter.maydell@linaro.org |
10 | --- | ||
11 | hw/openrisc/openrisc_sim.c | 38 +++++++++++++++++++++----------------- | ||
12 | 1 file changed, 21 insertions(+), 17 deletions(-) | ||
6 | 13 | ||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 14 | diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c |
8 | Message-id: 20200514212831.31248-6-richard.henderson@linaro.org | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | target/arm/helper.h | 5 +- | ||
13 | target/arm/neon-dp.decode | 6 +- | ||
14 | target/arm/crypto_helper.c | 99 +++++++++++++++++++++------------ | ||
15 | target/arm/translate-a64.c | 29 ++++------ | ||
16 | target/arm/translate-neon.inc.c | 46 ++++----------- | ||
17 | 5 files changed, 93 insertions(+), 92 deletions(-) | ||
18 | |||
19 | diff --git a/target/arm/helper.h b/target/arm/helper.h | ||
20 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
21 | --- a/target/arm/helper.h | 16 | --- a/hw/openrisc/openrisc_sim.c |
22 | +++ b/target/arm/helper.h | 17 | +++ b/hw/openrisc/openrisc_sim.c |
23 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_2(neon_qzip32, TCG_CALL_NO_RWG, void, ptr, ptr) | 18 | @@ -XXX,XX +XXX,XX @@ static void main_cpu_reset(void *opaque) |
24 | DEF_HELPER_FLAGS_4(crypto_aese, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 19 | cpu_set_pc(cs, boot_info.bootstrap_pc); |
25 | DEF_HELPER_FLAGS_3(crypto_aesmc, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
26 | |||
27 | -DEF_HELPER_FLAGS_4(crypto_sha1_3reg, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
28 | +DEF_HELPER_FLAGS_4(crypto_sha1su0, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
29 | +DEF_HELPER_FLAGS_4(crypto_sha1c, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
30 | +DEF_HELPER_FLAGS_4(crypto_sha1p, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
31 | +DEF_HELPER_FLAGS_4(crypto_sha1m, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
32 | DEF_HELPER_FLAGS_3(crypto_sha1h, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
33 | DEF_HELPER_FLAGS_3(crypto_sha1su1, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
34 | |||
35 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | ||
36 | index XXXXXXX..XXXXXXX 100644 | ||
37 | --- a/target/arm/neon-dp.decode | ||
38 | +++ b/target/arm/neon-dp.decode | ||
39 | @@ -XXX,XX +XXX,XX @@ VQRDMLAH_3s 1111 001 1 0 . .. .... .... 1011 ... 1 .... @3same | ||
40 | @3same_crypto .... .... .... .... .... .... .... .... \ | ||
41 | &3same vm=%vm_dp vn=%vn_dp vd=%vd_dp size=0 q=1 | ||
42 | |||
43 | -SHA1_3s 1111 001 0 0 . optype:2 .... .... 1100 . 1 . 0 .... \ | ||
44 | - vm=%vm_dp vn=%vn_dp vd=%vd_dp | ||
45 | +SHA1C_3s 1111 001 0 0 . 00 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
46 | +SHA1P_3s 1111 001 0 0 . 01 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
47 | +SHA1M_3s 1111 001 0 0 . 10 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
48 | +SHA1SU0_3s 1111 001 0 0 . 11 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
49 | SHA256H_3s 1111 001 1 0 . 00 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
50 | SHA256H2_3s 1111 001 1 0 . 01 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
51 | SHA256SU1_3s 1111 001 1 0 . 10 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
52 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | ||
53 | index XXXXXXX..XXXXXXX 100644 | ||
54 | --- a/target/arm/crypto_helper.c | ||
55 | +++ b/target/arm/crypto_helper.c | ||
56 | @@ -XXX,XX +XXX,XX @@ union CRYPTO_STATE { | ||
57 | }; | ||
58 | |||
59 | #ifdef HOST_WORDS_BIGENDIAN | ||
60 | -#define CR_ST_BYTE(state, i) (state.bytes[(15 - (i)) ^ 8]) | ||
61 | -#define CR_ST_WORD(state, i) (state.words[(3 - (i)) ^ 2]) | ||
62 | +#define CR_ST_BYTE(state, i) ((state).bytes[(15 - (i)) ^ 8]) | ||
63 | +#define CR_ST_WORD(state, i) ((state).words[(3 - (i)) ^ 2]) | ||
64 | #else | ||
65 | -#define CR_ST_BYTE(state, i) (state.bytes[i]) | ||
66 | -#define CR_ST_WORD(state, i) (state.words[i]) | ||
67 | +#define CR_ST_BYTE(state, i) ((state).bytes[i]) | ||
68 | +#define CR_ST_WORD(state, i) ((state).words[i]) | ||
69 | #endif | ||
70 | |||
71 | /* | ||
72 | @@ -XXX,XX +XXX,XX @@ static uint32_t maj(uint32_t x, uint32_t y, uint32_t z) | ||
73 | return (x & y) | ((x | y) & z); | ||
74 | } | 20 | } |
75 | 21 | ||
76 | -void HELPER(crypto_sha1_3reg)(void *vd, void *vn, void *vm, uint32_t op) | 22 | +static qemu_irq get_cpu_irq(OpenRISCCPU *cpus[], int cpunum, int irq_pin) |
77 | +void HELPER(crypto_sha1su0)(void *vd, void *vn, void *vm, uint32_t desc) | ||
78 | +{ | 23 | +{ |
79 | + uint64_t *d = vd, *n = vn, *m = vm; | 24 | + return cpus[cpunum]->env.irq[irq_pin]; |
80 | + uint64_t d0, d1; | ||
81 | + | ||
82 | + d0 = d[1] ^ d[0] ^ m[0]; | ||
83 | + d1 = n[0] ^ d[1] ^ m[1]; | ||
84 | + d[0] = d0; | ||
85 | + d[1] = d1; | ||
86 | + | ||
87 | + clear_tail_16(vd, desc); | ||
88 | +} | 25 | +} |
89 | + | 26 | + |
90 | +static inline void crypto_sha1_3reg(uint64_t *rd, uint64_t *rn, | 27 | static void openrisc_sim_net_init(hwaddr base, hwaddr descriptors, |
91 | + uint64_t *rm, uint32_t desc, | 28 | - int num_cpus, qemu_irq **cpu_irqs, |
92 | + uint32_t (*fn)(union CRYPTO_STATE *d)) | 29 | + int num_cpus, OpenRISCCPU *cpus[], |
30 | int irq_pin, NICInfo *nd) | ||
93 | { | 31 | { |
94 | - uint64_t *rd = vd; | 32 | DeviceState *dev; |
95 | - uint64_t *rn = vn; | 33 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_net_init(hwaddr base, hwaddr descriptors, |
96 | - uint64_t *rm = vm; | 34 | qdev_prop_set_uint32(splitter, "num-lines", num_cpus); |
97 | union CRYPTO_STATE d = { .l = { rd[0], rd[1] } }; | 35 | qdev_realize_and_unref(splitter, NULL, &error_fatal); |
98 | union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; | 36 | for (i = 0; i < num_cpus; i++) { |
99 | union CRYPTO_STATE m = { .l = { rm[0], rm[1] } }; | 37 | - qdev_connect_gpio_out(splitter, i, cpu_irqs[i][irq_pin]); |
100 | + int i; | 38 | + qdev_connect_gpio_out(splitter, i, get_cpu_irq(cpus, i, irq_pin)); |
101 | 39 | } | |
102 | - if (op == 3) { /* sha1su0 */ | 40 | sysbus_connect_irq(s, 0, qdev_get_gpio_in(splitter, 0)); |
103 | - d.l[0] ^= d.l[1] ^ m.l[0]; | 41 | } else { |
104 | - d.l[1] ^= n.l[0] ^ m.l[1]; | 42 | - sysbus_connect_irq(s, 0, cpu_irqs[0][irq_pin]); |
105 | - } else { | 43 | + sysbus_connect_irq(s, 0, get_cpu_irq(cpus, 0, irq_pin)); |
106 | - int i; | ||
107 | + for (i = 0; i < 4; i++) { | ||
108 | + uint32_t t = fn(&d); | ||
109 | |||
110 | - for (i = 0; i < 4; i++) { | ||
111 | - uint32_t t; | ||
112 | + t += rol32(CR_ST_WORD(d, 0), 5) + CR_ST_WORD(n, 0) | ||
113 | + + CR_ST_WORD(m, i); | ||
114 | |||
115 | - switch (op) { | ||
116 | - case 0: /* sha1c */ | ||
117 | - t = cho(CR_ST_WORD(d, 1), CR_ST_WORD(d, 2), CR_ST_WORD(d, 3)); | ||
118 | - break; | ||
119 | - case 1: /* sha1p */ | ||
120 | - t = par(CR_ST_WORD(d, 1), CR_ST_WORD(d, 2), CR_ST_WORD(d, 3)); | ||
121 | - break; | ||
122 | - case 2: /* sha1m */ | ||
123 | - t = maj(CR_ST_WORD(d, 1), CR_ST_WORD(d, 2), CR_ST_WORD(d, 3)); | ||
124 | - break; | ||
125 | - default: | ||
126 | - g_assert_not_reached(); | ||
127 | - } | ||
128 | - t += rol32(CR_ST_WORD(d, 0), 5) + CR_ST_WORD(n, 0) | ||
129 | - + CR_ST_WORD(m, i); | ||
130 | - | ||
131 | - CR_ST_WORD(n, 0) = CR_ST_WORD(d, 3); | ||
132 | - CR_ST_WORD(d, 3) = CR_ST_WORD(d, 2); | ||
133 | - CR_ST_WORD(d, 2) = ror32(CR_ST_WORD(d, 1), 2); | ||
134 | - CR_ST_WORD(d, 1) = CR_ST_WORD(d, 0); | ||
135 | - CR_ST_WORD(d, 0) = t; | ||
136 | - } | ||
137 | + CR_ST_WORD(n, 0) = CR_ST_WORD(d, 3); | ||
138 | + CR_ST_WORD(d, 3) = CR_ST_WORD(d, 2); | ||
139 | + CR_ST_WORD(d, 2) = ror32(CR_ST_WORD(d, 1), 2); | ||
140 | + CR_ST_WORD(d, 1) = CR_ST_WORD(d, 0); | ||
141 | + CR_ST_WORD(d, 0) = t; | ||
142 | } | 44 | } |
143 | rd[0] = d.l[0]; | 45 | sysbus_mmio_map(s, 0, base); |
144 | rd[1] = d.l[1]; | 46 | sysbus_mmio_map(s, 1, descriptors); |
145 | + | ||
146 | + clear_tail_16(rd, desc); | ||
147 | +} | ||
148 | + | ||
149 | +static uint32_t do_sha1c(union CRYPTO_STATE *d) | ||
150 | +{ | ||
151 | + return cho(CR_ST_WORD(*d, 1), CR_ST_WORD(*d, 2), CR_ST_WORD(*d, 3)); | ||
152 | +} | ||
153 | + | ||
154 | +void HELPER(crypto_sha1c)(void *vd, void *vn, void *vm, uint32_t desc) | ||
155 | +{ | ||
156 | + crypto_sha1_3reg(vd, vn, vm, desc, do_sha1c); | ||
157 | +} | ||
158 | + | ||
159 | +static uint32_t do_sha1p(union CRYPTO_STATE *d) | ||
160 | +{ | ||
161 | + return par(CR_ST_WORD(*d, 1), CR_ST_WORD(*d, 2), CR_ST_WORD(*d, 3)); | ||
162 | +} | ||
163 | + | ||
164 | +void HELPER(crypto_sha1p)(void *vd, void *vn, void *vm, uint32_t desc) | ||
165 | +{ | ||
166 | + crypto_sha1_3reg(vd, vn, vm, desc, do_sha1p); | ||
167 | +} | ||
168 | + | ||
169 | +static uint32_t do_sha1m(union CRYPTO_STATE *d) | ||
170 | +{ | ||
171 | + return maj(CR_ST_WORD(*d, 1), CR_ST_WORD(*d, 2), CR_ST_WORD(*d, 3)); | ||
172 | +} | ||
173 | + | ||
174 | +void HELPER(crypto_sha1m)(void *vd, void *vn, void *vm, uint32_t desc) | ||
175 | +{ | ||
176 | + crypto_sha1_3reg(vd, vn, vm, desc, do_sha1m); | ||
177 | } | 47 | } |
178 | 48 | ||
179 | void HELPER(crypto_sha1h)(void *vd, void *vm, uint32_t desc) | 49 | static void openrisc_sim_ompic_init(hwaddr base, int num_cpus, |
180 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | 50 | - qemu_irq **cpu_irqs, int irq_pin) |
181 | index XXXXXXX..XXXXXXX 100644 | 51 | + OpenRISCCPU *cpus[], int irq_pin) |
182 | --- a/target/arm/translate-a64.c | 52 | { |
183 | +++ b/target/arm/translate-a64.c | 53 | DeviceState *dev; |
184 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha(DisasContext *s, uint32_t insn) | 54 | SysBusDevice *s; |
185 | 55 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_ompic_init(hwaddr base, int num_cpus, | |
186 | switch (opcode) { | 56 | s = SYS_BUS_DEVICE(dev); |
187 | case 0: /* SHA1C */ | 57 | sysbus_realize_and_unref(s, &error_fatal); |
188 | + genfn = gen_helper_crypto_sha1c; | 58 | for (i = 0; i < num_cpus; i++) { |
189 | + feature = dc_isar_feature(aa64_sha1, s); | 59 | - sysbus_connect_irq(s, i, cpu_irqs[i][irq_pin]); |
190 | + break; | 60 | + sysbus_connect_irq(s, i, get_cpu_irq(cpus, i, irq_pin)); |
191 | case 1: /* SHA1P */ | ||
192 | + genfn = gen_helper_crypto_sha1p; | ||
193 | + feature = dc_isar_feature(aa64_sha1, s); | ||
194 | + break; | ||
195 | case 2: /* SHA1M */ | ||
196 | + genfn = gen_helper_crypto_sha1m; | ||
197 | + feature = dc_isar_feature(aa64_sha1, s); | ||
198 | + break; | ||
199 | case 3: /* SHA1SU0 */ | ||
200 | - genfn = NULL; | ||
201 | + genfn = gen_helper_crypto_sha1su0; | ||
202 | feature = dc_isar_feature(aa64_sha1, s); | ||
203 | break; | ||
204 | case 4: /* SHA256H */ | ||
205 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha(DisasContext *s, uint32_t insn) | ||
206 | if (!fp_access_check(s)) { | ||
207 | return; | ||
208 | } | 61 | } |
209 | - | 62 | sysbus_mmio_map(s, 0, base); |
210 | - if (genfn) { | ||
211 | - gen_gvec_op3_ool(s, true, rd, rn, rm, 0, genfn); | ||
212 | - } else { | ||
213 | - TCGv_i32 tcg_opcode = tcg_const_i32(opcode); | ||
214 | - TCGv_ptr tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
215 | - TCGv_ptr tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
216 | - TCGv_ptr tcg_rm_ptr = vec_full_reg_ptr(s, rm); | ||
217 | - | ||
218 | - gen_helper_crypto_sha1_3reg(tcg_rd_ptr, tcg_rn_ptr, | ||
219 | - tcg_rm_ptr, tcg_opcode); | ||
220 | - | ||
221 | - tcg_temp_free_i32(tcg_opcode); | ||
222 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
223 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
224 | - tcg_temp_free_ptr(tcg_rm_ptr); | ||
225 | - } | ||
226 | + gen_gvec_op3_ool(s, true, rd, rn, rm, 0, genfn); | ||
227 | } | 63 | } |
228 | 64 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_init(MachineState *machine) | |
229 | /* Crypto two-reg SHA | 65 | { |
230 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | 66 | ram_addr_t ram_size = machine->ram_size; |
231 | index XXXXXXX..XXXXXXX 100644 | 67 | const char *kernel_filename = machine->kernel_filename; |
232 | --- a/target/arm/translate-neon.inc.c | 68 | - OpenRISCCPU *cpu = NULL; |
233 | +++ b/target/arm/translate-neon.inc.c | 69 | + OpenRISCCPU *cpus[2] = {}; |
234 | @@ -XXX,XX +XXX,XX @@ static bool trans_VMUL_p_3s(DisasContext *s, arg_3same *a) | 70 | MemoryRegion *ram; |
235 | DO_VQRDMLAH(VQRDMLAH, gen_gvec_sqrdmlah_qc) | 71 | - qemu_irq *cpu_irqs[2]; |
236 | DO_VQRDMLAH(VQRDMLSH, gen_gvec_sqrdmlsh_qc) | 72 | qemu_irq serial_irq; |
237 | 73 | int n; | |
238 | -static bool trans_SHA1_3s(DisasContext *s, arg_SHA1_3s *a) | 74 | unsigned int smp_cpus = machine->smp.cpus; |
239 | -{ | 75 | |
240 | - TCGv_ptr ptr1, ptr2, ptr3; | 76 | assert(smp_cpus >= 1 && smp_cpus <= 2); |
241 | - TCGv_i32 tmp; | 77 | for (n = 0; n < smp_cpus; n++) { |
242 | - | 78 | - cpu = OPENRISC_CPU(cpu_create(machine->cpu_type)); |
243 | - if (!arm_dc_feature(s, ARM_FEATURE_NEON) || | 79 | - if (cpu == NULL) { |
244 | - !dc_isar_feature(aa32_sha1, s)) { | 80 | + cpus[n] = OPENRISC_CPU(cpu_create(machine->cpu_type)); |
245 | - return false; | 81 | + if (cpus[n] == NULL) { |
246 | +#define DO_SHA1(NAME, FUNC) \ | 82 | fprintf(stderr, "Unable to find CPU definition!\n"); |
247 | + WRAP_OOL_FN(gen_##NAME##_3s, FUNC) \ | 83 | exit(1); |
248 | + static bool trans_##NAME##_3s(DisasContext *s, arg_3same *a) \ | 84 | } |
249 | + { \ | 85 | - cpu_openrisc_pic_init(cpu); |
250 | + if (!dc_isar_feature(aa32_sha1, s)) { \ | 86 | - cpu_irqs[n] = (qemu_irq *) cpu->env.irq; |
251 | + return false; \ | 87 | + cpu_openrisc_pic_init(cpus[n]); |
252 | + } \ | 88 | |
253 | + return do_3same(s, a, gen_##NAME##_3s); \ | 89 | - cpu_openrisc_clock_init(cpu); |
90 | + cpu_openrisc_clock_init(cpus[n]); | ||
91 | |||
92 | - qemu_register_reset(main_cpu_reset, cpu); | ||
93 | + qemu_register_reset(main_cpu_reset, cpus[n]); | ||
254 | } | 94 | } |
255 | 95 | ||
256 | - /* UNDEF accesses to D16-D31 if they don't exist. */ | 96 | ram = g_malloc(sizeof(*ram)); |
257 | - if (!dc_isar_feature(aa32_simd_r32, s) && | 97 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_init(MachineState *machine) |
258 | - ((a->vd | a->vn | a->vm) & 0x10)) { | 98 | |
259 | - return false; | 99 | if (nd_table[0].used) { |
260 | - } | 100 | openrisc_sim_net_init(0x92000000, 0x92000400, smp_cpus, |
261 | - | 101 | - cpu_irqs, 4, nd_table); |
262 | - if ((a->vn | a->vm | a->vd) & 1) { | 102 | + cpus, 4, nd_table); |
263 | - return false; | 103 | } |
264 | - } | 104 | |
265 | - | 105 | if (smp_cpus > 1) { |
266 | - if (!vfp_access_check(s)) { | 106 | - openrisc_sim_ompic_init(0x98000000, smp_cpus, cpu_irqs, 1); |
267 | - return true; | 107 | + openrisc_sim_ompic_init(0x98000000, smp_cpus, cpus, 1); |
268 | - } | 108 | |
269 | - | 109 | - serial_irq = qemu_irq_split(cpu_irqs[0][2], cpu_irqs[1][2]); |
270 | - ptr1 = vfp_reg_ptr(true, a->vd); | 110 | + serial_irq = qemu_irq_split(get_cpu_irq(cpus, 0, 2), |
271 | - ptr2 = vfp_reg_ptr(true, a->vn); | 111 | + get_cpu_irq(cpus, 1, 2)); |
272 | - ptr3 = vfp_reg_ptr(true, a->vm); | 112 | } else { |
273 | - tmp = tcg_const_i32(a->optype); | 113 | - serial_irq = cpu_irqs[0][2]; |
274 | - gen_helper_crypto_sha1_3reg(ptr1, ptr2, ptr3, tmp); | 114 | + serial_irq = get_cpu_irq(cpus, 0, 2); |
275 | - tcg_temp_free_i32(tmp); | 115 | } |
276 | - tcg_temp_free_ptr(ptr1); | 116 | |
277 | - tcg_temp_free_ptr(ptr2); | 117 | serial_mm_init(get_system_memory(), 0x90000000, 0, serial_irq, |
278 | - tcg_temp_free_ptr(ptr3); | ||
279 | - | ||
280 | - return true; | ||
281 | -} | ||
282 | +DO_SHA1(SHA1C, gen_helper_crypto_sha1c) | ||
283 | +DO_SHA1(SHA1P, gen_helper_crypto_sha1p) | ||
284 | +DO_SHA1(SHA1M, gen_helper_crypto_sha1m) | ||
285 | +DO_SHA1(SHA1SU0, gen_helper_crypto_sha1su0) | ||
286 | |||
287 | #define DO_SHA2(NAME, FUNC) \ | ||
288 | WRAP_OOL_FN(gen_##NAME##_3s, FUNC) \ | ||
289 | -- | 118 | -- |
290 | 2.20.1 | 119 | 2.20.1 |
291 | 120 | ||
292 | 121 | diff view generated by jsdifflib |
1 | Convert the remaining Neon narrowing shifts to decodetree: | 1 | The openrisc code uses an old style of interrupt handling, where a |
---|---|---|---|
2 | * VQSHRN | 2 | separate standalone set of qemu_irqs invoke a function |
3 | * VQRSHRN | 3 | openrisc_pic_cpu_handler() which signals the interrupt to the CPU |
4 | proper by directly calling cpu_interrupt() and cpu_reset_interrupt(). | ||
5 | Because CPU objects now inherit (indirectly) from TYPE_DEVICE, they | ||
6 | can have GPIO input lines themselves, and the neater modern way to | ||
7 | implement this is to simply have the CPU object itself provide the | ||
8 | input IRQ lines. | ||
4 | 9 | ||
10 | Create GPIO inputs to the OpenRISC CPU object, and make the only user | ||
11 | of cpu_openrisc_pic_init() wire up directly to those instead. | ||
12 | |||
13 | This allows us to delete the hw/openrisc/pic_cpu.c file entirely. | ||
14 | |||
15 | This fixes a trivial memory leak reported by Coverity of the IRQs | ||
16 | allocated in cpu_openrisc_pic_init(). | ||
17 | |||
18 | Fixes: Coverity CID 1421934 | ||
5 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 19 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
6 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 20 | Reviewed-by: Stafford Horne <shorne@gmail.com> |
7 | Message-id: 20200522145520.6778-7-peter.maydell@linaro.org | 21 | Message-id: 20201127225127.14770-4-peter.maydell@linaro.org |
8 | --- | 22 | --- |
9 | target/arm/neon-dp.decode | 20 ++++++ | 23 | target/openrisc/cpu.h | 1 - |
10 | target/arm/translate-neon.inc.c | 15 +++++ | 24 | hw/openrisc/openrisc_sim.c | 3 +- |
11 | target/arm/translate.c | 110 +------------------------------- | 25 | hw/openrisc/pic_cpu.c | 61 -------------------------------------- |
12 | 3 files changed, 37 insertions(+), 108 deletions(-) | 26 | target/openrisc/cpu.c | 32 ++++++++++++++++++++ |
27 | hw/openrisc/meson.build | 2 +- | ||
28 | 5 files changed, 34 insertions(+), 65 deletions(-) | ||
29 | delete mode 100644 hw/openrisc/pic_cpu.c | ||
13 | 30 | ||
14 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 31 | diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h |
15 | index XXXXXXX..XXXXXXX 100644 | 32 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/target/arm/neon-dp.decode | 33 | --- a/target/openrisc/cpu.h |
17 | +++ b/target/arm/neon-dp.decode | 34 | +++ b/target/openrisc/cpu.h |
18 | @@ -XXX,XX +XXX,XX @@ VQSHRUN_16_2sh 1111 001 1 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_h | 35 | @@ -XXX,XX +XXX,XX @@ typedef struct CPUOpenRISCState { |
19 | VQRSHRUN_64_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_d | 36 | uint32_t picmr; /* Interrupt mask register */ |
20 | VQRSHRUN_32_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_s | 37 | uint32_t picsr; /* Interrupt contrl register*/ |
21 | VQRSHRUN_16_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_h | 38 | #endif |
22 | + | 39 | - void *irq[32]; /* Interrupt irq input */ |
23 | +# VQSHRN with signed input | 40 | } CPUOpenRISCState; |
24 | +VQSHRN_S64_2sh 1111 001 0 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_d | 41 | |
25 | +VQSHRN_S32_2sh 1111 001 0 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_s | 42 | /** |
26 | +VQSHRN_S16_2sh 1111 001 0 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_h | 43 | diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c |
27 | + | ||
28 | +# VQRSHRN with signed input | ||
29 | +VQRSHRN_S64_2sh 1111 001 0 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_d | ||
30 | +VQRSHRN_S32_2sh 1111 001 0 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_s | ||
31 | +VQRSHRN_S16_2sh 1111 001 0 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_h | ||
32 | + | ||
33 | +# VQSHRN with unsigned input | ||
34 | +VQSHRN_U64_2sh 1111 001 1 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_d | ||
35 | +VQSHRN_U32_2sh 1111 001 1 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_s | ||
36 | +VQSHRN_U16_2sh 1111 001 1 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_h | ||
37 | + | ||
38 | +# VQRSHRN with unsigned input | ||
39 | +VQRSHRN_U64_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_d | ||
40 | +VQRSHRN_U32_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_s | ||
41 | +VQRSHRN_U16_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_h | ||
42 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
43 | index XXXXXXX..XXXXXXX 100644 | 44 | index XXXXXXX..XXXXXXX 100644 |
44 | --- a/target/arm/translate-neon.inc.c | 45 | --- a/hw/openrisc/openrisc_sim.c |
45 | +++ b/target/arm/translate-neon.inc.c | 46 | +++ b/hw/openrisc/openrisc_sim.c |
46 | @@ -XXX,XX +XXX,XX @@ DO_2SN_32(VQSHRUN_16, gen_helper_neon_shl_s16, gen_helper_neon_unarrow_sat8) | 47 | @@ -XXX,XX +XXX,XX @@ static void main_cpu_reset(void *opaque) |
47 | DO_2SN_64(VQRSHRUN_64, gen_helper_neon_rshl_s64, gen_helper_neon_unarrow_sat32) | 48 | |
48 | DO_2SN_32(VQRSHRUN_32, gen_helper_neon_rshl_s32, gen_helper_neon_unarrow_sat16) | 49 | static qemu_irq get_cpu_irq(OpenRISCCPU *cpus[], int cpunum, int irq_pin) |
49 | DO_2SN_32(VQRSHRUN_16, gen_helper_neon_rshl_s16, gen_helper_neon_unarrow_sat8) | 50 | { |
50 | +DO_2SN_64(VQSHRN_S64, gen_sshl_i64, gen_helper_neon_narrow_sat_s32) | 51 | - return cpus[cpunum]->env.irq[irq_pin]; |
51 | +DO_2SN_32(VQSHRN_S32, gen_sshl_i32, gen_helper_neon_narrow_sat_s16) | 52 | + return qdev_get_gpio_in_named(DEVICE(cpus[cpunum]), "IRQ", irq_pin); |
52 | +DO_2SN_32(VQSHRN_S16, gen_helper_neon_shl_s16, gen_helper_neon_narrow_sat_s8) | ||
53 | + | ||
54 | +DO_2SN_64(VQRSHRN_S64, gen_helper_neon_rshl_s64, gen_helper_neon_narrow_sat_s32) | ||
55 | +DO_2SN_32(VQRSHRN_S32, gen_helper_neon_rshl_s32, gen_helper_neon_narrow_sat_s16) | ||
56 | +DO_2SN_32(VQRSHRN_S16, gen_helper_neon_rshl_s16, gen_helper_neon_narrow_sat_s8) | ||
57 | + | ||
58 | +DO_2SN_64(VQSHRN_U64, gen_ushl_i64, gen_helper_neon_narrow_sat_u32) | ||
59 | +DO_2SN_32(VQSHRN_U32, gen_ushl_i32, gen_helper_neon_narrow_sat_u16) | ||
60 | +DO_2SN_32(VQSHRN_U16, gen_helper_neon_shl_u16, gen_helper_neon_narrow_sat_u8) | ||
61 | + | ||
62 | +DO_2SN_64(VQRSHRN_U64, gen_helper_neon_rshl_u64, gen_helper_neon_narrow_sat_u32) | ||
63 | +DO_2SN_32(VQRSHRN_U32, gen_helper_neon_rshl_u32, gen_helper_neon_narrow_sat_u16) | ||
64 | +DO_2SN_32(VQRSHRN_U16, gen_helper_neon_rshl_u16, gen_helper_neon_narrow_sat_u8) | ||
65 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
66 | index XXXXXXX..XXXXXXX 100644 | ||
67 | --- a/target/arm/translate.c | ||
68 | +++ b/target/arm/translate.c | ||
69 | @@ -XXX,XX +XXX,XX @@ static inline void gen_neon_unarrow_sats(int size, TCGv_i32 dest, TCGv_i64 src) | ||
70 | } | ||
71 | } | 53 | } |
72 | 54 | ||
73 | -static inline void gen_neon_shift_narrow(int size, TCGv_i32 var, TCGv_i32 shift, | 55 | static void openrisc_sim_net_init(hwaddr base, hwaddr descriptors, |
74 | - int q, int u) | 56 | @@ -XXX,XX +XXX,XX @@ static void openrisc_sim_init(MachineState *machine) |
57 | fprintf(stderr, "Unable to find CPU definition!\n"); | ||
58 | exit(1); | ||
59 | } | ||
60 | - cpu_openrisc_pic_init(cpus[n]); | ||
61 | |||
62 | cpu_openrisc_clock_init(cpus[n]); | ||
63 | |||
64 | diff --git a/hw/openrisc/pic_cpu.c b/hw/openrisc/pic_cpu.c | ||
65 | deleted file mode 100644 | ||
66 | index XXXXXXX..XXXXXXX | ||
67 | --- a/hw/openrisc/pic_cpu.c | ||
68 | +++ /dev/null | ||
69 | @@ -XXX,XX +XXX,XX @@ | ||
70 | -/* | ||
71 | - * OpenRISC Programmable Interrupt Controller support. | ||
72 | - * | ||
73 | - * Copyright (c) 2011-2012 Jia Liu <proljc@gmail.com> | ||
74 | - * Feng Gao <gf91597@gmail.com> | ||
75 | - * | ||
76 | - * This library is free software; you can redistribute it and/or | ||
77 | - * modify it under the terms of the GNU Lesser General Public | ||
78 | - * License as published by the Free Software Foundation; either | ||
79 | - * version 2.1 of the License, or (at your option) any later version. | ||
80 | - * | ||
81 | - * This library is distributed in the hope that it will be useful, | ||
82 | - * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
83 | - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
84 | - * Lesser General Public License for more details. | ||
85 | - * | ||
86 | - * You should have received a copy of the GNU Lesser General Public | ||
87 | - * License along with this library; if not, see <http://www.gnu.org/licenses/>. | ||
88 | - */ | ||
89 | - | ||
90 | -#include "qemu/osdep.h" | ||
91 | -#include "hw/irq.h" | ||
92 | -#include "cpu.h" | ||
93 | - | ||
94 | -/* OpenRISC pic handler */ | ||
95 | -static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) | ||
75 | -{ | 96 | -{ |
76 | - if (q) { | 97 | - OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; |
77 | - if (u) { | 98 | - CPUState *cs = CPU(cpu); |
78 | - switch (size) { | 99 | - uint32_t irq_bit; |
79 | - case 1: gen_helper_neon_rshl_u16(var, var, shift); break; | 100 | - |
80 | - case 2: gen_helper_neon_rshl_u32(var, var, shift); break; | 101 | - if (irq > 31 || irq < 0) { |
81 | - default: abort(); | 102 | - return; |
82 | - } | 103 | - } |
83 | - } else { | 104 | - |
84 | - switch (size) { | 105 | - irq_bit = 1U << irq; |
85 | - case 1: gen_helper_neon_rshl_s16(var, var, shift); break; | 106 | - |
86 | - case 2: gen_helper_neon_rshl_s32(var, var, shift); break; | 107 | - if (level) { |
87 | - default: abort(); | 108 | - cpu->env.picsr |= irq_bit; |
88 | - } | ||
89 | - } | ||
90 | - } else { | 109 | - } else { |
91 | - if (u) { | 110 | - cpu->env.picsr &= ~irq_bit; |
92 | - switch (size) { | 111 | - } |
93 | - case 1: gen_helper_neon_shl_u16(var, var, shift); break; | 112 | - |
94 | - case 2: gen_ushl_i32(var, var, shift); break; | 113 | - if (cpu->env.picsr & cpu->env.picmr) { |
95 | - default: abort(); | 114 | - cpu_interrupt(cs, CPU_INTERRUPT_HARD); |
96 | - } | 115 | - } else { |
97 | - } else { | 116 | - cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); |
98 | - switch (size) { | 117 | - cpu->env.picsr = 0; |
99 | - case 1: gen_helper_neon_shl_s16(var, var, shift); break; | ||
100 | - case 2: gen_sshl_i32(var, var, shift); break; | ||
101 | - default: abort(); | ||
102 | - } | ||
103 | - } | ||
104 | - } | 118 | - } |
105 | -} | 119 | -} |
106 | - | 120 | - |
107 | static inline void gen_neon_widen(TCGv_i64 dest, TCGv_i32 src, int size, int u) | 121 | -void cpu_openrisc_pic_init(OpenRISCCPU *cpu) |
122 | -{ | ||
123 | - int i; | ||
124 | - qemu_irq *qi; | ||
125 | - qi = qemu_allocate_irqs(openrisc_pic_cpu_handler, cpu, NR_IRQS); | ||
126 | - | ||
127 | - for (i = 0; i < NR_IRQS; i++) { | ||
128 | - cpu->env.irq[i] = qi[i]; | ||
129 | - } | ||
130 | -} | ||
131 | diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c | ||
132 | index XXXXXXX..XXXXXXX 100644 | ||
133 | --- a/target/openrisc/cpu.c | ||
134 | +++ b/target/openrisc/cpu.c | ||
135 | @@ -XXX,XX +XXX,XX @@ static void openrisc_cpu_reset(DeviceState *dev) | ||
136 | #endif | ||
137 | } | ||
138 | |||
139 | +#ifndef CONFIG_USER_ONLY | ||
140 | +static void openrisc_cpu_set_irq(void *opaque, int irq, int level) | ||
141 | +{ | ||
142 | + OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; | ||
143 | + CPUState *cs = CPU(cpu); | ||
144 | + uint32_t irq_bit; | ||
145 | + | ||
146 | + if (irq > 31 || irq < 0) { | ||
147 | + return; | ||
148 | + } | ||
149 | + | ||
150 | + irq_bit = 1U << irq; | ||
151 | + | ||
152 | + if (level) { | ||
153 | + cpu->env.picsr |= irq_bit; | ||
154 | + } else { | ||
155 | + cpu->env.picsr &= ~irq_bit; | ||
156 | + } | ||
157 | + | ||
158 | + if (cpu->env.picsr & cpu->env.picmr) { | ||
159 | + cpu_interrupt(cs, CPU_INTERRUPT_HARD); | ||
160 | + } else { | ||
161 | + cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); | ||
162 | + cpu->env.picsr = 0; | ||
163 | + } | ||
164 | +} | ||
165 | +#endif | ||
166 | + | ||
167 | static void openrisc_cpu_realizefn(DeviceState *dev, Error **errp) | ||
108 | { | 168 | { |
109 | if (u) { | 169 | CPUState *cs = CPU(dev); |
110 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 170 | @@ -XXX,XX +XXX,XX @@ static void openrisc_cpu_initfn(Object *obj) |
111 | case 6: /* VQSHLU */ | 171 | OpenRISCCPU *cpu = OPENRISC_CPU(obj); |
112 | case 7: /* VQSHL */ | 172 | |
113 | case 8: /* VSHRN, VRSHRN, VQSHRUN, VQRSHRUN */ | 173 | cpu_set_cpustate_pointers(cpu); |
114 | + case 9: /* VQSHRN, VQRSHRN */ | 174 | + |
115 | return 1; /* handled by decodetree */ | 175 | +#ifndef CONFIG_USER_ONLY |
116 | default: | 176 | + qdev_init_gpio_in_named(DEVICE(cpu), openrisc_cpu_set_irq, "IRQ", NR_IRQS); |
117 | break; | 177 | +#endif |
118 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 178 | } |
119 | size--; | 179 | |
120 | } | 180 | /* CPU models */ |
121 | shift = (insn >> 16) & ((1 << (3 + size)) - 1); | 181 | diff --git a/hw/openrisc/meson.build b/hw/openrisc/meson.build |
122 | - if (op < 10) { | 182 | index XXXXXXX..XXXXXXX 100644 |
123 | - /* Shift by immediate and narrow: | 183 | --- a/hw/openrisc/meson.build |
124 | - VSHRN, VRSHRN, VQSHRN, VQRSHRN. */ | 184 | +++ b/hw/openrisc/meson.build |
125 | - int input_unsigned = (op == 8) ? !u : u; | 185 | @@ -XXX,XX +XXX,XX @@ |
126 | - if (rm & 1) { | 186 | openrisc_ss = ss.source_set() |
127 | - return 1; | 187 | -openrisc_ss.add(files('pic_cpu.c', 'cputimer.c')) |
128 | - } | 188 | +openrisc_ss.add(files('cputimer.c')) |
129 | - shift = shift - (1 << (size + 3)); | 189 | openrisc_ss.add(when: 'CONFIG_OR1K_SIM', if_true: files('openrisc_sim.c')) |
130 | - size++; | 190 | |
131 | - if (size == 3) { | 191 | hw_arch += {'openrisc': openrisc_ss} |
132 | - tmp64 = tcg_const_i64(shift); | ||
133 | - neon_load_reg64(cpu_V0, rm); | ||
134 | - neon_load_reg64(cpu_V1, rm + 1); | ||
135 | - for (pass = 0; pass < 2; pass++) { | ||
136 | - TCGv_i64 in; | ||
137 | - if (pass == 0) { | ||
138 | - in = cpu_V0; | ||
139 | - } else { | ||
140 | - in = cpu_V1; | ||
141 | - } | ||
142 | - if (q) { | ||
143 | - if (input_unsigned) { | ||
144 | - gen_helper_neon_rshl_u64(cpu_V0, in, tmp64); | ||
145 | - } else { | ||
146 | - gen_helper_neon_rshl_s64(cpu_V0, in, tmp64); | ||
147 | - } | ||
148 | - } else { | ||
149 | - if (input_unsigned) { | ||
150 | - gen_ushl_i64(cpu_V0, in, tmp64); | ||
151 | - } else { | ||
152 | - gen_sshl_i64(cpu_V0, in, tmp64); | ||
153 | - } | ||
154 | - } | ||
155 | - tmp = tcg_temp_new_i32(); | ||
156 | - gen_neon_narrow_op(op == 8, u, size - 1, tmp, cpu_V0); | ||
157 | - neon_store_reg(rd, pass, tmp); | ||
158 | - } /* for pass */ | ||
159 | - tcg_temp_free_i64(tmp64); | ||
160 | - } else { | ||
161 | - if (size == 1) { | ||
162 | - imm = (uint16_t)shift; | ||
163 | - imm |= imm << 16; | ||
164 | - } else { | ||
165 | - /* size == 2 */ | ||
166 | - imm = (uint32_t)shift; | ||
167 | - } | ||
168 | - tmp2 = tcg_const_i32(imm); | ||
169 | - tmp4 = neon_load_reg(rm + 1, 0); | ||
170 | - tmp5 = neon_load_reg(rm + 1, 1); | ||
171 | - for (pass = 0; pass < 2; pass++) { | ||
172 | - if (pass == 0) { | ||
173 | - tmp = neon_load_reg(rm, 0); | ||
174 | - } else { | ||
175 | - tmp = tmp4; | ||
176 | - } | ||
177 | - gen_neon_shift_narrow(size, tmp, tmp2, q, | ||
178 | - input_unsigned); | ||
179 | - if (pass == 0) { | ||
180 | - tmp3 = neon_load_reg(rm, 1); | ||
181 | - } else { | ||
182 | - tmp3 = tmp5; | ||
183 | - } | ||
184 | - gen_neon_shift_narrow(size, tmp3, tmp2, q, | ||
185 | - input_unsigned); | ||
186 | - tcg_gen_concat_i32_i64(cpu_V0, tmp, tmp3); | ||
187 | - tcg_temp_free_i32(tmp); | ||
188 | - tcg_temp_free_i32(tmp3); | ||
189 | - tmp = tcg_temp_new_i32(); | ||
190 | - gen_neon_narrow_op(op == 8, u, size - 1, tmp, cpu_V0); | ||
191 | - neon_store_reg(rd, pass, tmp); | ||
192 | - } /* for pass */ | ||
193 | - tcg_temp_free_i32(tmp2); | ||
194 | - } | ||
195 | - } else if (op == 10) { | ||
196 | + if (op == 10) { | ||
197 | /* VSHLL, VMOVL */ | ||
198 | if (q || (rd & 1)) { | ||
199 | return 1; | ||
200 | -- | 192 | -- |
201 | 2.20.1 | 193 | 2.20.1 |
202 | 194 | ||
203 | 195 | diff view generated by jsdifflib |
1 | Convert the VSHLL and VMOVL insns from the 2-reg-shift group | 1 | The Nios2 architecture supports two different interrupt controller |
---|---|---|---|
2 | to decodetree. Since the loop always has two passes, we unroll | 2 | options: |
3 | it to avoid the awkward reassignment of one TCGv to another. | 3 | |
4 | 4 | * The IIC (Internal Interrupt Controller) is part of the CPU itself; | |
5 | it has 32 IRQ input lines and no NMI support. Interrupt status is | ||
6 | queried and controlled via the CPU's ipending and istatus | ||
7 | registers. | ||
8 | |||
9 | * The EIC (External Interrupt Controller) interface allows the CPU | ||
10 | to connect to an external interrupt controller. The interface | ||
11 | allows the interrupt controller to present a packet of information | ||
12 | containing: | ||
13 | - handler address | ||
14 | - interrupt level | ||
15 | - register set | ||
16 | - NMI mode | ||
17 | |||
18 | QEMU does not model an EIC currently. We do model the IIC, but its | ||
19 | implementation is split across code in hw/nios2/cpu_pic.c and | ||
20 | hw/intc/nios2_iic.c. The code in those two files has no state of its | ||
21 | own -- the IIC state is in the Nios2CPU state struct. | ||
22 | |||
23 | Because CPU objects now inherit (indirectly) from TYPE_DEVICE, they | ||
24 | can have GPIO input lines themselves, so we can implement the IIC | ||
25 | directly in the CPU object the same way that real hardware does. | ||
26 | |||
27 | Create named "IRQ" GPIO inputs to the Nios2 CPU object, and make the | ||
28 | only user of the IIC wire up directly to those instead. | ||
29 | |||
30 | Note that the old code had an "NMI" concept which was entirely unused | ||
31 | and also as far as I can see not architecturally correct, since only | ||
32 | the EIC has a concept of an NMI. | ||
33 | |||
34 | This fixes a Coverity-reported trivial memory leak of the IRQ array | ||
35 | allocated in nios2_cpu_pic_init(). | ||
36 | |||
37 | Fixes: Coverity CID 1421916 | ||
5 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 38 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
6 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 39 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
7 | Message-id: 20200522145520.6778-8-peter.maydell@linaro.org | 40 | Message-id: 20201129174022.26530-2-peter.maydell@linaro.org |
41 | Reviewed-by: Wentong Wu <wentong.wu@intel.com> | ||
42 | Tested-by: Wentong Wu <wentong.wu@intel.com> | ||
8 | --- | 43 | --- |
9 | target/arm/neon-dp.decode | 16 +++++++ | 44 | target/nios2/cpu.h | 1 - |
10 | target/arm/translate-neon.inc.c | 81 +++++++++++++++++++++++++++++++++ | 45 | hw/intc/nios2_iic.c | 95 --------------------------------------- |
11 | target/arm/translate.c | 46 +------------------ | 46 | hw/nios2/10m50_devboard.c | 13 +----- |
12 | 3 files changed, 99 insertions(+), 44 deletions(-) | 47 | hw/nios2/cpu_pic.c | 31 ------------- |
13 | 48 | target/nios2/cpu.c | 30 +++++++++++++ | |
14 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 49 | MAINTAINERS | 1 - |
15 | index XXXXXXX..XXXXXXX 100644 | 50 | hw/intc/meson.build | 1 - |
16 | --- a/target/arm/neon-dp.decode | 51 | 7 files changed, 32 insertions(+), 140 deletions(-) |
17 | +++ b/target/arm/neon-dp.decode | 52 | delete mode 100644 hw/intc/nios2_iic.c |
18 | @@ -XXX,XX +XXX,XX @@ VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 53 | |
19 | &2reg_shift vm=%vm_dp vd=%vd_dp size=1 q=0 \ | 54 | diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h |
20 | shift=%neon_rshift_i3 | 55 | index XXXXXXX..XXXXXXX 100644 |
21 | 56 | --- a/target/nios2/cpu.h | |
22 | +# Long left shifts: again Q is part of opcode decode | 57 | +++ b/target/nios2/cpu.h |
23 | +@2reg_shll_s .... ... . . . 1 shift:5 .... .... 0 . . . .... \ | 58 | @@ -XXX,XX +XXX,XX @@ void nios2_cpu_do_unaligned_access(CPUState *cpu, vaddr addr, |
24 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=2 q=0 | 59 | MMUAccessType access_type, |
25 | +@2reg_shll_h .... ... . . . 01 shift:4 .... .... 0 . . . .... \ | 60 | int mmu_idx, uintptr_t retaddr); |
26 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=1 q=0 | 61 | |
27 | +@2reg_shll_b .... ... . . . 001 shift:3 .... .... 0 . . . .... \ | 62 | -qemu_irq *nios2_cpu_pic_init(Nios2CPU *cpu); |
28 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=0 q=0 | 63 | void nios2_check_interrupts(CPUNios2State *env); |
29 | + | 64 | |
30 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_d | 65 | void do_nios2_semihosting(CPUNios2State *env); |
31 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | 66 | diff --git a/hw/intc/nios2_iic.c b/hw/intc/nios2_iic.c |
32 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | 67 | deleted file mode 100644 |
33 | @@ -XXX,XX +XXX,XX @@ VQSHRN_U16_2sh 1111 001 1 1 . ...... .... 1001 . 0 . 1 .... @2reg_shrn_h | 68 | index XXXXXXX..XXXXXXX |
34 | VQRSHRN_U64_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_d | 69 | --- a/hw/intc/nios2_iic.c |
35 | VQRSHRN_U32_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_s | 70 | +++ /dev/null |
36 | VQRSHRN_U16_2sh 1111 001 1 1 . ...... .... 1001 . 1 . 1 .... @2reg_shrn_h | 71 | @@ -XXX,XX +XXX,XX @@ |
37 | + | 72 | -/* |
38 | +VSHLL_S_2sh 1111 001 0 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_s | 73 | - * QEMU Altera Internal Interrupt Controller. |
39 | +VSHLL_S_2sh 1111 001 0 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_h | 74 | - * |
40 | +VSHLL_S_2sh 1111 001 0 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_b | 75 | - * Copyright (c) 2012 Chris Wulff <crwulff@gmail.com> |
41 | + | 76 | - * |
42 | +VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_s | 77 | - * This library is free software; you can redistribute it and/or |
43 | +VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_h | 78 | - * modify it under the terms of the GNU Lesser General Public |
44 | +VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_b | 79 | - * License as published by the Free Software Foundation; either |
45 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | 80 | - * version 2.1 of the License, or (at your option) any later version. |
46 | index XXXXXXX..XXXXXXX 100644 | 81 | - * |
47 | --- a/target/arm/translate-neon.inc.c | 82 | - * This library is distributed in the hope that it will be useful, |
48 | +++ b/target/arm/translate-neon.inc.c | 83 | - * but WITHOUT ANY WARRANTY; without even the implied warranty of |
49 | @@ -XXX,XX +XXX,XX @@ DO_2SN_32(VQSHRN_U16, gen_helper_neon_shl_u16, gen_helper_neon_narrow_sat_u8) | 84 | - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
50 | DO_2SN_64(VQRSHRN_U64, gen_helper_neon_rshl_u64, gen_helper_neon_narrow_sat_u32) | 85 | - * Lesser General Public License for more details. |
51 | DO_2SN_32(VQRSHRN_U32, gen_helper_neon_rshl_u32, gen_helper_neon_narrow_sat_u16) | 86 | - * |
52 | DO_2SN_32(VQRSHRN_U16, gen_helper_neon_rshl_u16, gen_helper_neon_narrow_sat_u8) | 87 | - * You should have received a copy of the GNU Lesser General Public |
53 | + | 88 | - * License along with this library; if not, see |
54 | +static bool do_vshll_2sh(DisasContext *s, arg_2reg_shift *a, | 89 | - * <http://www.gnu.org/licenses/lgpl-2.1.html> |
55 | + NeonGenWidenFn *widenfn, bool u) | 90 | - */ |
91 | - | ||
92 | -#include "qemu/osdep.h" | ||
93 | -#include "qemu/module.h" | ||
94 | -#include "qapi/error.h" | ||
95 | - | ||
96 | -#include "hw/irq.h" | ||
97 | -#include "hw/sysbus.h" | ||
98 | -#include "cpu.h" | ||
99 | -#include "qom/object.h" | ||
100 | - | ||
101 | -#define TYPE_ALTERA_IIC "altera,iic" | ||
102 | -OBJECT_DECLARE_SIMPLE_TYPE(AlteraIIC, ALTERA_IIC) | ||
103 | - | ||
104 | -struct AlteraIIC { | ||
105 | - SysBusDevice parent_obj; | ||
106 | - void *cpu; | ||
107 | - qemu_irq parent_irq; | ||
108 | -}; | ||
109 | - | ||
110 | -static void update_irq(AlteraIIC *pv) | ||
111 | -{ | ||
112 | - CPUNios2State *env = &((Nios2CPU *)(pv->cpu))->env; | ||
113 | - | ||
114 | - qemu_set_irq(pv->parent_irq, | ||
115 | - env->regs[CR_IPENDING] & env->regs[CR_IENABLE]); | ||
116 | -} | ||
117 | - | ||
118 | -static void irq_handler(void *opaque, int irq, int level) | ||
119 | -{ | ||
120 | - AlteraIIC *pv = opaque; | ||
121 | - CPUNios2State *env = &((Nios2CPU *)(pv->cpu))->env; | ||
122 | - | ||
123 | - env->regs[CR_IPENDING] &= ~(1 << irq); | ||
124 | - env->regs[CR_IPENDING] |= !!level << irq; | ||
125 | - | ||
126 | - update_irq(pv); | ||
127 | -} | ||
128 | - | ||
129 | -static void altera_iic_init(Object *obj) | ||
130 | -{ | ||
131 | - AlteraIIC *pv = ALTERA_IIC(obj); | ||
132 | - | ||
133 | - qdev_init_gpio_in(DEVICE(pv), irq_handler, 32); | ||
134 | - sysbus_init_irq(SYS_BUS_DEVICE(obj), &pv->parent_irq); | ||
135 | -} | ||
136 | - | ||
137 | -static void altera_iic_realize(DeviceState *dev, Error **errp) | ||
138 | -{ | ||
139 | - struct AlteraIIC *pv = ALTERA_IIC(dev); | ||
140 | - | ||
141 | - pv->cpu = object_property_get_link(OBJECT(dev), "cpu", &error_abort); | ||
142 | -} | ||
143 | - | ||
144 | -static void altera_iic_class_init(ObjectClass *klass, void *data) | ||
145 | -{ | ||
146 | - DeviceClass *dc = DEVICE_CLASS(klass); | ||
147 | - | ||
148 | - /* Reason: needs to be wired up, e.g. by nios2_10m50_ghrd_init() */ | ||
149 | - dc->user_creatable = false; | ||
150 | - dc->realize = altera_iic_realize; | ||
151 | -} | ||
152 | - | ||
153 | -static TypeInfo altera_iic_info = { | ||
154 | - .name = TYPE_ALTERA_IIC, | ||
155 | - .parent = TYPE_SYS_BUS_DEVICE, | ||
156 | - .instance_size = sizeof(AlteraIIC), | ||
157 | - .instance_init = altera_iic_init, | ||
158 | - .class_init = altera_iic_class_init, | ||
159 | -}; | ||
160 | - | ||
161 | -static void altera_iic_register(void) | ||
162 | -{ | ||
163 | - type_register_static(&altera_iic_info); | ||
164 | -} | ||
165 | - | ||
166 | -type_init(altera_iic_register) | ||
167 | diff --git a/hw/nios2/10m50_devboard.c b/hw/nios2/10m50_devboard.c | ||
168 | index XXXXXXX..XXXXXXX 100644 | ||
169 | --- a/hw/nios2/10m50_devboard.c | ||
170 | +++ b/hw/nios2/10m50_devboard.c | ||
171 | @@ -XXX,XX +XXX,XX @@ static void nios2_10m50_ghrd_init(MachineState *machine) | ||
172 | ram_addr_t tcm_size = 0x1000; /* 1 kiB, but QEMU limit is 4 kiB */ | ||
173 | ram_addr_t ram_base = 0x08000000; | ||
174 | ram_addr_t ram_size = 0x08000000; | ||
175 | - qemu_irq *cpu_irq, irq[32]; | ||
176 | + qemu_irq irq[32]; | ||
177 | int i; | ||
178 | |||
179 | /* Physical TCM (tb_ram_1k) with alias at 0xc0000000 */ | ||
180 | @@ -XXX,XX +XXX,XX @@ static void nios2_10m50_ghrd_init(MachineState *machine) | ||
181 | |||
182 | /* Create CPU -- FIXME */ | ||
183 | cpu = NIOS2_CPU(cpu_create(TYPE_NIOS2_CPU)); | ||
184 | - | ||
185 | - /* Register: CPU interrupt controller (PIC) */ | ||
186 | - cpu_irq = nios2_cpu_pic_init(cpu); | ||
187 | - | ||
188 | - /* Register: Internal Interrupt Controller (IIC) */ | ||
189 | - dev = qdev_new("altera,iic"); | ||
190 | - object_property_add_const_link(OBJECT(dev), "cpu", OBJECT(cpu)); | ||
191 | - sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); | ||
192 | - sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, cpu_irq[0]); | ||
193 | for (i = 0; i < 32; i++) { | ||
194 | - irq[i] = qdev_get_gpio_in(dev, i); | ||
195 | + irq[i] = qdev_get_gpio_in_named(DEVICE(cpu), "IRQ", i); | ||
196 | } | ||
197 | |||
198 | /* Register: Altera 16550 UART */ | ||
199 | diff --git a/hw/nios2/cpu_pic.c b/hw/nios2/cpu_pic.c | ||
200 | index XXXXXXX..XXXXXXX 100644 | ||
201 | --- a/hw/nios2/cpu_pic.c | ||
202 | +++ b/hw/nios2/cpu_pic.c | ||
203 | @@ -XXX,XX +XXX,XX @@ | ||
204 | |||
205 | #include "boot.h" | ||
206 | |||
207 | -static void nios2_pic_cpu_handler(void *opaque, int irq, int level) | ||
208 | -{ | ||
209 | - Nios2CPU *cpu = opaque; | ||
210 | - CPUNios2State *env = &cpu->env; | ||
211 | - CPUState *cs = CPU(cpu); | ||
212 | - int type = irq ? CPU_INTERRUPT_NMI : CPU_INTERRUPT_HARD; | ||
213 | - | ||
214 | - if (type == CPU_INTERRUPT_HARD) { | ||
215 | - env->irq_pending = level; | ||
216 | - | ||
217 | - if (level && (env->regs[CR_STATUS] & CR_STATUS_PIE)) { | ||
218 | - env->irq_pending = 0; | ||
219 | - cpu_interrupt(cs, type); | ||
220 | - } else if (!level) { | ||
221 | - env->irq_pending = 0; | ||
222 | - cpu_reset_interrupt(cs, type); | ||
223 | - } | ||
224 | - } else { | ||
225 | - if (level) { | ||
226 | - cpu_interrupt(cs, type); | ||
227 | - } else { | ||
228 | - cpu_reset_interrupt(cs, type); | ||
229 | - } | ||
230 | - } | ||
231 | -} | ||
232 | - | ||
233 | void nios2_check_interrupts(CPUNios2State *env) | ||
234 | { | ||
235 | if (env->irq_pending && | ||
236 | @@ -XXX,XX +XXX,XX @@ void nios2_check_interrupts(CPUNios2State *env) | ||
237 | cpu_interrupt(env_cpu(env), CPU_INTERRUPT_HARD); | ||
238 | } | ||
239 | } | ||
240 | - | ||
241 | -qemu_irq *nios2_cpu_pic_init(Nios2CPU *cpu) | ||
242 | -{ | ||
243 | - return qemu_allocate_irqs(nios2_pic_cpu_handler, cpu, 2); | ||
244 | -} | ||
245 | diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c | ||
246 | index XXXXXXX..XXXXXXX 100644 | ||
247 | --- a/target/nios2/cpu.c | ||
248 | +++ b/target/nios2/cpu.c | ||
249 | @@ -XXX,XX +XXX,XX @@ static void nios2_cpu_reset(DeviceState *dev) | ||
250 | #endif | ||
251 | } | ||
252 | |||
253 | +#ifndef CONFIG_USER_ONLY | ||
254 | +static void nios2_cpu_set_irq(void *opaque, int irq, int level) | ||
56 | +{ | 255 | +{ |
57 | + TCGv_i64 tmp; | 256 | + Nios2CPU *cpu = opaque; |
58 | + TCGv_i32 rm0, rm1; | 257 | + CPUNios2State *env = &cpu->env; |
59 | + uint64_t widen_mask = 0; | 258 | + CPUState *cs = CPU(cpu); |
60 | + | 259 | + |
61 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | 260 | + env->regs[CR_IPENDING] &= ~(1 << irq); |
62 | + return false; | 261 | + env->regs[CR_IPENDING] |= !!level << irq; |
262 | + | ||
263 | + env->irq_pending = env->regs[CR_IPENDING] & env->regs[CR_IENABLE]; | ||
264 | + | ||
265 | + if (env->irq_pending && (env->regs[CR_STATUS] & CR_STATUS_PIE)) { | ||
266 | + env->irq_pending = 0; | ||
267 | + cpu_interrupt(cs, CPU_INTERRUPT_HARD); | ||
268 | + } else if (!env->irq_pending) { | ||
269 | + cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD); | ||
63 | + } | 270 | + } |
64 | + | 271 | +} |
65 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | 272 | +#endif |
66 | + if (!dc_isar_feature(aa32_simd_r32, s) && | 273 | + |
67 | + ((a->vd | a->vm) & 0x10)) { | 274 | static void nios2_cpu_initfn(Object *obj) |
68 | + return false; | 275 | { |
69 | + } | 276 | Nios2CPU *cpu = NIOS2_CPU(obj); |
70 | + | 277 | @@ -XXX,XX +XXX,XX @@ static void nios2_cpu_initfn(Object *obj) |
71 | + if (a->vd & 1) { | 278 | |
72 | + return false; | 279 | #if !defined(CONFIG_USER_ONLY) |
73 | + } | 280 | mmu_init(&cpu->env); |
74 | + | ||
75 | + if (!vfp_access_check(s)) { | ||
76 | + return true; | ||
77 | + } | ||
78 | + | 281 | + |
79 | + /* | 282 | + /* |
80 | + * This is a widen-and-shift operation. The shift is always less | 283 | + * These interrupt lines model the IIC (internal interrupt |
81 | + * than the width of the source type, so after widening the input | 284 | + * controller). QEMU does not currently support the EIC |
82 | + * vector we can simply shift the whole 64-bit widened register, | 285 | + * (external interrupt controller) -- if we did it would be |
83 | + * and then clear the potential overflow bits resulting from left | 286 | + * a separate device in hw/intc with a custom interface to |
84 | + * bits of the narrow input appearing as right bits of the left | 287 | + * the CPU, and boards using it would not wire up these IRQ lines. |
85 | + * neighbour narrow input. Calculate a mask of bits to clear. | ||
86 | + */ | 288 | + */ |
87 | + if ((a->shift != 0) && (a->size < 2 || u)) { | 289 | + qdev_init_gpio_in_named(DEVICE(cpu), nios2_cpu_set_irq, "IRQ", 32); |
88 | + int esize = 8 << a->size; | 290 | #endif |
89 | + widen_mask = MAKE_64BIT_MASK(0, esize); | 291 | } |
90 | + widen_mask >>= esize - a->shift; | 292 | |
91 | + widen_mask = dup_const(a->size + 1, widen_mask); | 293 | diff --git a/MAINTAINERS b/MAINTAINERS |
92 | + } | 294 | index XXXXXXX..XXXXXXX 100644 |
93 | + | 295 | --- a/MAINTAINERS |
94 | + rm0 = neon_load_reg(a->vm, 0); | 296 | +++ b/MAINTAINERS |
95 | + rm1 = neon_load_reg(a->vm, 1); | 297 | @@ -XXX,XX +XXX,XX @@ M: Marek Vasut <marex@denx.de> |
96 | + tmp = tcg_temp_new_i64(); | 298 | S: Maintained |
97 | + | 299 | F: target/nios2/ |
98 | + widenfn(tmp, rm0); | 300 | F: hw/nios2/ |
99 | + if (a->shift != 0) { | 301 | -F: hw/intc/nios2_iic.c |
100 | + tcg_gen_shli_i64(tmp, tmp, a->shift); | 302 | F: disas/nios2.c |
101 | + tcg_gen_andi_i64(tmp, tmp, ~widen_mask); | 303 | F: default-configs/nios2-softmmu.mak |
102 | + } | 304 | |
103 | + neon_store_reg64(tmp, a->vd); | 305 | diff --git a/hw/intc/meson.build b/hw/intc/meson.build |
104 | + | 306 | index XXXXXXX..XXXXXXX 100644 |
105 | + widenfn(tmp, rm1); | 307 | --- a/hw/intc/meson.build |
106 | + if (a->shift != 0) { | 308 | +++ b/hw/intc/meson.build |
107 | + tcg_gen_shli_i64(tmp, tmp, a->shift); | 309 | @@ -XXX,XX +XXX,XX @@ specific_ss.add(when: 'CONFIG_IBEX', if_true: files('ibex_plic.c')) |
108 | + tcg_gen_andi_i64(tmp, tmp, ~widen_mask); | 310 | specific_ss.add(when: 'CONFIG_IOAPIC', if_true: files('ioapic.c')) |
109 | + } | 311 | specific_ss.add(when: 'CONFIG_LOONGSON_LIOINTC', if_true: files('loongson_liointc.c')) |
110 | + neon_store_reg64(tmp, a->vd + 1); | 312 | specific_ss.add(when: 'CONFIG_MIPS_CPS', if_true: files('mips_gic.c')) |
111 | + tcg_temp_free_i64(tmp); | 313 | -specific_ss.add(when: 'CONFIG_NIOS2', if_true: files('nios2_iic.c')) |
112 | + return true; | 314 | specific_ss.add(when: 'CONFIG_OMAP', if_true: files('omap_intc.c')) |
113 | +} | 315 | specific_ss.add(when: 'CONFIG_OMPIC', if_true: files('ompic.c')) |
114 | + | 316 | specific_ss.add(when: 'CONFIG_OPENPIC_KVM', if_true: files('openpic_kvm.c')) |
115 | +static bool trans_VSHLL_S_2sh(DisasContext *s, arg_2reg_shift *a) | ||
116 | +{ | ||
117 | + NeonGenWidenFn *widenfn[] = { | ||
118 | + gen_helper_neon_widen_s8, | ||
119 | + gen_helper_neon_widen_s16, | ||
120 | + tcg_gen_ext_i32_i64, | ||
121 | + }; | ||
122 | + return do_vshll_2sh(s, a, widenfn[a->size], false); | ||
123 | +} | ||
124 | + | ||
125 | +static bool trans_VSHLL_U_2sh(DisasContext *s, arg_2reg_shift *a) | ||
126 | +{ | ||
127 | + NeonGenWidenFn *widenfn[] = { | ||
128 | + gen_helper_neon_widen_u8, | ||
129 | + gen_helper_neon_widen_u16, | ||
130 | + tcg_gen_extu_i32_i64, | ||
131 | + }; | ||
132 | + return do_vshll_2sh(s, a, widenfn[a->size], true); | ||
133 | +} | ||
134 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
135 | index XXXXXXX..XXXXXXX 100644 | ||
136 | --- a/target/arm/translate.c | ||
137 | +++ b/target/arm/translate.c | ||
138 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
139 | case 7: /* VQSHL */ | ||
140 | case 8: /* VSHRN, VRSHRN, VQSHRUN, VQRSHRUN */ | ||
141 | case 9: /* VQSHRN, VQRSHRN */ | ||
142 | + case 10: /* VSHLL, including VMOVL */ | ||
143 | return 1; /* handled by decodetree */ | ||
144 | default: | ||
145 | break; | ||
146 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
147 | size--; | ||
148 | } | ||
149 | shift = (insn >> 16) & ((1 << (3 + size)) - 1); | ||
150 | - if (op == 10) { | ||
151 | - /* VSHLL, VMOVL */ | ||
152 | - if (q || (rd & 1)) { | ||
153 | - return 1; | ||
154 | - } | ||
155 | - tmp = neon_load_reg(rm, 0); | ||
156 | - tmp2 = neon_load_reg(rm, 1); | ||
157 | - for (pass = 0; pass < 2; pass++) { | ||
158 | - if (pass == 1) | ||
159 | - tmp = tmp2; | ||
160 | - | ||
161 | - gen_neon_widen(cpu_V0, tmp, size, u); | ||
162 | - | ||
163 | - if (shift != 0) { | ||
164 | - /* The shift is less than the width of the source | ||
165 | - type, so we can just shift the whole register. */ | ||
166 | - tcg_gen_shli_i64(cpu_V0, cpu_V0, shift); | ||
167 | - /* Widen the result of shift: we need to clear | ||
168 | - * the potential overflow bits resulting from | ||
169 | - * left bits of the narrow input appearing as | ||
170 | - * right bits of left the neighbour narrow | ||
171 | - * input. */ | ||
172 | - if (size < 2 || !u) { | ||
173 | - uint64_t imm64; | ||
174 | - if (size == 0) { | ||
175 | - imm = (0xffu >> (8 - shift)); | ||
176 | - imm |= imm << 16; | ||
177 | - } else if (size == 1) { | ||
178 | - imm = 0xffff >> (16 - shift); | ||
179 | - } else { | ||
180 | - /* size == 2 */ | ||
181 | - imm = 0xffffffff >> (32 - shift); | ||
182 | - } | ||
183 | - if (size < 2) { | ||
184 | - imm64 = imm | (((uint64_t)imm) << 32); | ||
185 | - } else { | ||
186 | - imm64 = imm; | ||
187 | - } | ||
188 | - tcg_gen_andi_i64(cpu_V0, cpu_V0, ~imm64); | ||
189 | - } | ||
190 | - } | ||
191 | - neon_store_reg64(cpu_V0, rd + pass); | ||
192 | - } | ||
193 | - } else if (op >= 14) { | ||
194 | + if (op >= 14) { | ||
195 | /* VCVT fixed-point. */ | ||
196 | TCGv_ptr fpst; | ||
197 | TCGv_i32 shiftv; | ||
198 | -- | 317 | -- |
199 | 2.20.1 | 318 | 2.20.1 |
200 | 319 | ||
201 | 320 | diff view generated by jsdifflib |
1 | Convert the VCVT fixed-point conversion operations in the | 1 | The function nios2_check_interrupts)() looks only at CPU-internal |
---|---|---|---|
2 | Neon 2-regs-and-shift group to decodetree. | 2 | state; it belongs in target/nios2, not hw/nios2. Move it into the |
3 | same file as its only caller, so it can just be local to that file. | ||
4 | |||
5 | This removes the only remaining code from cpu_pic.c, so we can delete | ||
6 | that file entirely. | ||
3 | 7 | ||
4 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 9 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
6 | Message-id: 20200522145520.6778-9-peter.maydell@linaro.org | 10 | Message-id: 20201129174022.26530-3-peter.maydell@linaro.org |
11 | Reviewed-by: Wentong Wu <wentong.wu@intel.com> | ||
12 | Tested-by: Wentong Wu <wentong.wu@intel.com> | ||
7 | --- | 13 | --- |
8 | target/arm/neon-dp.decode | 11 +++++ | 14 | target/nios2/cpu.h | 2 -- |
9 | target/arm/translate-neon.inc.c | 49 +++++++++++++++++++++ | 15 | hw/nios2/cpu_pic.c | 36 ------------------------------------ |
10 | target/arm/translate.c | 75 +-------------------------------- | 16 | target/nios2/op_helper.c | 9 +++++++++ |
11 | 3 files changed, 62 insertions(+), 73 deletions(-) | 17 | hw/nios2/meson.build | 2 +- |
18 | 4 files changed, 10 insertions(+), 39 deletions(-) | ||
19 | delete mode 100644 hw/nios2/cpu_pic.c | ||
12 | 20 | ||
13 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 21 | diff --git a/target/nios2/cpu.h b/target/nios2/cpu.h |
14 | index XXXXXXX..XXXXXXX 100644 | 22 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/target/arm/neon-dp.decode | 23 | --- a/target/nios2/cpu.h |
16 | +++ b/target/arm/neon-dp.decode | 24 | +++ b/target/nios2/cpu.h |
17 | @@ -XXX,XX +XXX,XX @@ VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 25 | @@ -XXX,XX +XXX,XX @@ void nios2_cpu_do_unaligned_access(CPUState *cpu, vaddr addr, |
18 | @2reg_shll_b .... ... . . . 001 shift:3 .... .... 0 . . . .... \ | 26 | MMUAccessType access_type, |
19 | &2reg_shift vm=%vm_dp vd=%vd_dp size=0 q=0 | 27 | int mmu_idx, uintptr_t retaddr); |
20 | 28 | ||
21 | +# We use size=0 for fp32 and size=1 for fp16 to match the 3-same encodings. | 29 | -void nios2_check_interrupts(CPUNios2State *env); |
22 | +@2reg_vcvt .... ... . . . 1 ..... .... .... . q:1 . . .... \ | 30 | - |
23 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=0 shift=%neon_rshift_i5 | 31 | void do_nios2_semihosting(CPUNios2State *env); |
24 | + | 32 | |
25 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_d | 33 | #define CPU_RESOLVING_TYPE TYPE_NIOS2_CPU |
26 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | 34 | diff --git a/hw/nios2/cpu_pic.c b/hw/nios2/cpu_pic.c |
27 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | 35 | deleted file mode 100644 |
28 | @@ -XXX,XX +XXX,XX @@ VSHLL_S_2sh 1111 001 0 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_b | 36 | index XXXXXXX..XXXXXXX |
29 | VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_s | 37 | --- a/hw/nios2/cpu_pic.c |
30 | VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_h | 38 | +++ /dev/null |
31 | VSHLL_U_2sh 1111 001 1 1 . ...... .... 1010 . 0 . 1 .... @2reg_shll_b | 39 | @@ -XXX,XX +XXX,XX @@ |
32 | + | 40 | -/* |
33 | +# VCVT fixed<->float conversions | 41 | - * Altera Nios2 CPU PIC |
34 | +# TODO: FP16 fixed<->float conversions are opc==0b1100 and 0b1101 | 42 | - * |
35 | +VCVT_SF_2sh 1111 001 0 1 . ...... .... 1110 0 . . 1 .... @2reg_vcvt | 43 | - * Copyright (c) 2016 Marek Vasut <marek.vasut@gmail.com> |
36 | +VCVT_UF_2sh 1111 001 1 1 . ...... .... 1110 0 . . 1 .... @2reg_vcvt | 44 | - * |
37 | +VCVT_FS_2sh 1111 001 0 1 . ...... .... 1111 0 . . 1 .... @2reg_vcvt | 45 | - * This library is free software; you can redistribute it and/or |
38 | +VCVT_FU_2sh 1111 001 1 1 . ...... .... 1111 0 . . 1 .... @2reg_vcvt | 46 | - * modify it under the terms of the GNU Lesser General Public |
39 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | 47 | - * License as published by the Free Software Foundation; either |
48 | - * version 2.1 of the License, or (at your option) any later version. | ||
49 | - * | ||
50 | - * This library is distributed in the hope that it will be useful, | ||
51 | - * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
52 | - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
53 | - * Lesser General Public License for more details. | ||
54 | - * | ||
55 | - * You should have received a copy of the GNU Lesser General Public | ||
56 | - * License along with this library; if not, see | ||
57 | - * <http://www.gnu.org/licenses/lgpl-2.1.html> | ||
58 | - */ | ||
59 | - | ||
60 | -#include "qemu/osdep.h" | ||
61 | -#include "cpu.h" | ||
62 | -#include "hw/irq.h" | ||
63 | - | ||
64 | -#include "qemu/config-file.h" | ||
65 | - | ||
66 | -#include "boot.h" | ||
67 | - | ||
68 | -void nios2_check_interrupts(CPUNios2State *env) | ||
69 | -{ | ||
70 | - if (env->irq_pending && | ||
71 | - (env->regs[CR_STATUS] & CR_STATUS_PIE)) { | ||
72 | - env->irq_pending = 0; | ||
73 | - cpu_interrupt(env_cpu(env), CPU_INTERRUPT_HARD); | ||
74 | - } | ||
75 | -} | ||
76 | diff --git a/target/nios2/op_helper.c b/target/nios2/op_helper.c | ||
40 | index XXXXXXX..XXXXXXX 100644 | 77 | index XXXXXXX..XXXXXXX 100644 |
41 | --- a/target/arm/translate-neon.inc.c | 78 | --- a/target/nios2/op_helper.c |
42 | +++ b/target/arm/translate-neon.inc.c | 79 | +++ b/target/nios2/op_helper.c |
43 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSHLL_U_2sh(DisasContext *s, arg_2reg_shift *a) | 80 | @@ -XXX,XX +XXX,XX @@ void helper_mmu_write(CPUNios2State *env, uint32_t rn, uint32_t v) |
44 | }; | 81 | mmu_write(env, rn, v); |
45 | return do_vshll_2sh(s, a, widenfn[a->size], true); | ||
46 | } | 82 | } |
47 | + | 83 | |
48 | +static bool do_fp_2sh(DisasContext *s, arg_2reg_shift *a, | 84 | +static void nios2_check_interrupts(CPUNios2State *env) |
49 | + NeonGenTwoSingleOPFn *fn) | ||
50 | +{ | 85 | +{ |
51 | + /* FP operations in 2-reg-and-shift group */ | 86 | + if (env->irq_pending && |
52 | + TCGv_i32 tmp, shiftv; | 87 | + (env->regs[CR_STATUS] & CR_STATUS_PIE)) { |
53 | + TCGv_ptr fpstatus; | 88 | + env->irq_pending = 0; |
54 | + int pass; | 89 | + cpu_interrupt(env_cpu(env), CPU_INTERRUPT_HARD); |
55 | + | ||
56 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
57 | + return false; | ||
58 | + } | 90 | + } |
59 | + | ||
60 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
61 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
62 | + ((a->vd | a->vm) & 0x10)) { | ||
63 | + return false; | ||
64 | + } | ||
65 | + | ||
66 | + if ((a->vm | a->vd) & a->q) { | ||
67 | + return false; | ||
68 | + } | ||
69 | + | ||
70 | + if (!vfp_access_check(s)) { | ||
71 | + return true; | ||
72 | + } | ||
73 | + | ||
74 | + fpstatus = get_fpstatus_ptr(1); | ||
75 | + shiftv = tcg_const_i32(a->shift); | ||
76 | + for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
77 | + tmp = neon_load_reg(a->vm, pass); | ||
78 | + fn(tmp, tmp, shiftv, fpstatus); | ||
79 | + neon_store_reg(a->vd, pass, tmp); | ||
80 | + } | ||
81 | + tcg_temp_free_ptr(fpstatus); | ||
82 | + tcg_temp_free_i32(shiftv); | ||
83 | + return true; | ||
84 | +} | 91 | +} |
85 | + | 92 | + |
86 | +#define DO_FP_2SH(INSN, FUNC) \ | 93 | void helper_check_interrupts(CPUNios2State *env) |
87 | + static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a) \ | 94 | { |
88 | + { \ | 95 | qemu_mutex_lock_iothread(); |
89 | + return do_fp_2sh(s, a, FUNC); \ | 96 | diff --git a/hw/nios2/meson.build b/hw/nios2/meson.build |
90 | + } | ||
91 | + | ||
92 | +DO_FP_2SH(VCVT_SF, gen_helper_vfp_sltos) | ||
93 | +DO_FP_2SH(VCVT_UF, gen_helper_vfp_ultos) | ||
94 | +DO_FP_2SH(VCVT_FS, gen_helper_vfp_tosls_round_to_zero) | ||
95 | +DO_FP_2SH(VCVT_FU, gen_helper_vfp_touls_round_to_zero) | ||
96 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
97 | index XXXXXXX..XXXXXXX 100644 | 97 | index XXXXXXX..XXXXXXX 100644 |
98 | --- a/target/arm/translate.c | 98 | --- a/hw/nios2/meson.build |
99 | +++ b/target/arm/translate.c | 99 | +++ b/hw/nios2/meson.build |
100 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 100 | @@ -XXX,XX +XXX,XX @@ |
101 | int q; | 101 | nios2_ss = ss.source_set() |
102 | int rd, rn, rm, rd_ofs, rn_ofs, rm_ofs; | 102 | -nios2_ss.add(files('boot.c', 'cpu_pic.c')) |
103 | int size; | 103 | +nios2_ss.add(files('boot.c')) |
104 | - int shift; | 104 | nios2_ss.add(when: 'CONFIG_NIOS2_10M50', if_true: files('10m50_devboard.c')) |
105 | int pass; | 105 | nios2_ss.add(when: 'CONFIG_NIOS2_GENERIC_NOMMU', if_true: files('generic_nommu.c')) |
106 | int u; | ||
107 | int vec_size; | ||
108 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
109 | return 1; | ||
110 | } else if (insn & (1 << 4)) { | ||
111 | if ((insn & 0x00380080) != 0) { | ||
112 | - /* Two registers and shift. */ | ||
113 | - op = (insn >> 8) & 0xf; | ||
114 | - | ||
115 | - switch (op) { | ||
116 | - case 0: /* VSHR */ | ||
117 | - case 1: /* VSRA */ | ||
118 | - case 2: /* VRSHR */ | ||
119 | - case 3: /* VRSRA */ | ||
120 | - case 4: /* VSRI */ | ||
121 | - case 5: /* VSHL, VSLI */ | ||
122 | - case 6: /* VQSHLU */ | ||
123 | - case 7: /* VQSHL */ | ||
124 | - case 8: /* VSHRN, VRSHRN, VQSHRUN, VQRSHRUN */ | ||
125 | - case 9: /* VQSHRN, VQRSHRN */ | ||
126 | - case 10: /* VSHLL, including VMOVL */ | ||
127 | - return 1; /* handled by decodetree */ | ||
128 | - default: | ||
129 | - break; | ||
130 | - } | ||
131 | - | ||
132 | - if (insn & (1 << 7)) { | ||
133 | - /* 64-bit shift. */ | ||
134 | - if (op > 7) { | ||
135 | - return 1; | ||
136 | - } | ||
137 | - size = 3; | ||
138 | - } else { | ||
139 | - size = 2; | ||
140 | - while ((insn & (1 << (size + 19))) == 0) | ||
141 | - size--; | ||
142 | - } | ||
143 | - shift = (insn >> 16) & ((1 << (3 + size)) - 1); | ||
144 | - if (op >= 14) { | ||
145 | - /* VCVT fixed-point. */ | ||
146 | - TCGv_ptr fpst; | ||
147 | - TCGv_i32 shiftv; | ||
148 | - VFPGenFixPointFn *fn; | ||
149 | - | ||
150 | - if (!(insn & (1 << 21)) || (q && ((rd | rm) & 1))) { | ||
151 | - return 1; | ||
152 | - } | ||
153 | - | ||
154 | - if (!(op & 1)) { | ||
155 | - if (u) { | ||
156 | - fn = gen_helper_vfp_ultos; | ||
157 | - } else { | ||
158 | - fn = gen_helper_vfp_sltos; | ||
159 | - } | ||
160 | - } else { | ||
161 | - if (u) { | ||
162 | - fn = gen_helper_vfp_touls_round_to_zero; | ||
163 | - } else { | ||
164 | - fn = gen_helper_vfp_tosls_round_to_zero; | ||
165 | - } | ||
166 | - } | ||
167 | - | ||
168 | - /* We have already masked out the must-be-1 top bit of imm6, | ||
169 | - * hence this 32-shift where the ARM ARM has 64-imm6. | ||
170 | - */ | ||
171 | - shift = 32 - shift; | ||
172 | - fpst = get_fpstatus_ptr(1); | ||
173 | - shiftv = tcg_const_i32(shift); | ||
174 | - for (pass = 0; pass < (q ? 4 : 2); pass++) { | ||
175 | - TCGv_i32 tmpf = neon_load_reg(rm, pass); | ||
176 | - fn(tmpf, tmpf, shiftv, fpst); | ||
177 | - neon_store_reg(rd, pass, tmpf); | ||
178 | - } | ||
179 | - tcg_temp_free_ptr(fpst); | ||
180 | - tcg_temp_free_i32(shiftv); | ||
181 | - } else { | ||
182 | - return 1; | ||
183 | - } | ||
184 | + /* Two registers and shift: handled by decodetree */ | ||
185 | + return 1; | ||
186 | } else { /* (insn & 0x00380080) == 0 */ | ||
187 | int invert, reg_ofs, vec_size; | ||
188 | 106 | ||
189 | -- | 107 | -- |
190 | 2.20.1 | 108 | 2.20.1 |
191 | 109 | ||
192 | 110 | diff view generated by jsdifflib |
1 | Convert the Neon narrowing shifts where op==8 to decodetree: | 1 | In nios2_cpu_set_irq(), use deposit32() rather than raw shift-and-mask |
---|---|---|---|
2 | * VSHRN | 2 | operations to set the appropriate bit in the ipending register. |
3 | * VRSHRN | ||
4 | * VQSHRUN | ||
5 | * VQRSHRUN | ||
6 | 3 | ||
7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 4 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
8 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 5 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
9 | Message-id: 20200522145520.6778-6-peter.maydell@linaro.org | 6 | Message-id: 20201129174022.26530-4-peter.maydell@linaro.org |
10 | --- | 7 | --- |
11 | target/arm/neon-dp.decode | 27 ++++++ | 8 | target/nios2/cpu.c | 3 +-- |
12 | target/arm/translate-neon.inc.c | 167 ++++++++++++++++++++++++++++++++ | 9 | 1 file changed, 1 insertion(+), 2 deletions(-) |
13 | target/arm/translate.c | 1 + | ||
14 | 3 files changed, 195 insertions(+) | ||
15 | 10 | ||
16 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 11 | diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c |
17 | index XXXXXXX..XXXXXXX 100644 | 12 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/target/arm/neon-dp.decode | 13 | --- a/target/nios2/cpu.c |
19 | +++ b/target/arm/neon-dp.decode | 14 | +++ b/target/nios2/cpu.c |
20 | @@ -XXX,XX +XXX,XX @@ VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 15 | @@ -XXX,XX +XXX,XX @@ static void nios2_cpu_set_irq(void *opaque, int irq, int level) |
21 | @2reg_shl_b .... ... . . . 001 shift:3 .... .... 0 q:1 . . .... \ | 16 | CPUNios2State *env = &cpu->env; |
22 | &2reg_shift vm=%vm_dp vd=%vd_dp size=0 | 17 | CPUState *cs = CPU(cpu); |
23 | 18 | ||
24 | +# Narrowing right shifts: here the Q bit is part of the opcode decode | 19 | - env->regs[CR_IPENDING] &= ~(1 << irq); |
25 | +@2reg_shrn_d .... ... . . . 1 ..... .... .... 0 . . . .... \ | 20 | - env->regs[CR_IPENDING] |= !!level << irq; |
26 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=3 q=0 \ | 21 | + env->regs[CR_IPENDING] = deposit32(env->regs[CR_IPENDING], irq, 1, !!level); |
27 | + shift=%neon_rshift_i5 | 22 | |
28 | +@2reg_shrn_s .... ... . . . 01 .... .... .... 0 . . . .... \ | 23 | env->irq_pending = env->regs[CR_IPENDING] & env->regs[CR_IENABLE]; |
29 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=2 q=0 \ | 24 | |
30 | + shift=%neon_rshift_i4 | ||
31 | +@2reg_shrn_h .... ... . . . 001 ... .... .... 0 . . . .... \ | ||
32 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=1 q=0 \ | ||
33 | + shift=%neon_rshift_i3 | ||
34 | + | ||
35 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_d | ||
36 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | ||
37 | VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | ||
38 | @@ -XXX,XX +XXX,XX @@ VQSHL_U_64_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_d | ||
39 | VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_s | ||
40 | VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_h | ||
41 | VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_b | ||
42 | + | ||
43 | +VSHRN_64_2sh 1111 001 0 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_d | ||
44 | +VSHRN_32_2sh 1111 001 0 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_s | ||
45 | +VSHRN_16_2sh 1111 001 0 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_h | ||
46 | + | ||
47 | +VRSHRN_64_2sh 1111 001 0 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_d | ||
48 | +VRSHRN_32_2sh 1111 001 0 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_s | ||
49 | +VRSHRN_16_2sh 1111 001 0 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_h | ||
50 | + | ||
51 | +VQSHRUN_64_2sh 1111 001 1 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_d | ||
52 | +VQSHRUN_32_2sh 1111 001 1 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_s | ||
53 | +VQSHRUN_16_2sh 1111 001 1 1 . ...... .... 1000 . 0 . 1 .... @2reg_shrn_h | ||
54 | + | ||
55 | +VQRSHRUN_64_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_d | ||
56 | +VQRSHRUN_32_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_s | ||
57 | +VQRSHRUN_16_2sh 1111 001 1 1 . ...... .... 1000 . 1 . 1 .... @2reg_shrn_h | ||
58 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
59 | index XXXXXXX..XXXXXXX 100644 | ||
60 | --- a/target/arm/translate-neon.inc.c | ||
61 | +++ b/target/arm/translate-neon.inc.c | ||
62 | @@ -XXX,XX +XXX,XX @@ static bool do_2shift_env_32(DisasContext *s, arg_2reg_shift *a, | ||
63 | DO_2SHIFT_ENV(VQSHLU, qshlu_s) | ||
64 | DO_2SHIFT_ENV(VQSHL_U, qshl_u) | ||
65 | DO_2SHIFT_ENV(VQSHL_S, qshl_s) | ||
66 | + | ||
67 | +static bool do_2shift_narrow_64(DisasContext *s, arg_2reg_shift *a, | ||
68 | + NeonGenTwo64OpFn *shiftfn, | ||
69 | + NeonGenNarrowEnvFn *narrowfn) | ||
70 | +{ | ||
71 | + /* 2-reg-and-shift narrowing-shift operations, size == 3 case */ | ||
72 | + TCGv_i64 constimm, rm1, rm2; | ||
73 | + TCGv_i32 rd; | ||
74 | + | ||
75 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
76 | + return false; | ||
77 | + } | ||
78 | + | ||
79 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
80 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
81 | + ((a->vd | a->vm) & 0x10)) { | ||
82 | + return false; | ||
83 | + } | ||
84 | + | ||
85 | + if (a->vm & 1) { | ||
86 | + return false; | ||
87 | + } | ||
88 | + | ||
89 | + if (!vfp_access_check(s)) { | ||
90 | + return true; | ||
91 | + } | ||
92 | + | ||
93 | + /* | ||
94 | + * This is always a right shift, and the shiftfn is always a | ||
95 | + * left-shift helper, which thus needs the negated shift count. | ||
96 | + */ | ||
97 | + constimm = tcg_const_i64(-a->shift); | ||
98 | + rm1 = tcg_temp_new_i64(); | ||
99 | + rm2 = tcg_temp_new_i64(); | ||
100 | + | ||
101 | + /* Load both inputs first to avoid potential overwrite if rm == rd */ | ||
102 | + neon_load_reg64(rm1, a->vm); | ||
103 | + neon_load_reg64(rm2, a->vm + 1); | ||
104 | + | ||
105 | + shiftfn(rm1, rm1, constimm); | ||
106 | + rd = tcg_temp_new_i32(); | ||
107 | + narrowfn(rd, cpu_env, rm1); | ||
108 | + neon_store_reg(a->vd, 0, rd); | ||
109 | + | ||
110 | + shiftfn(rm2, rm2, constimm); | ||
111 | + rd = tcg_temp_new_i32(); | ||
112 | + narrowfn(rd, cpu_env, rm2); | ||
113 | + neon_store_reg(a->vd, 1, rd); | ||
114 | + | ||
115 | + tcg_temp_free_i64(rm1); | ||
116 | + tcg_temp_free_i64(rm2); | ||
117 | + tcg_temp_free_i64(constimm); | ||
118 | + | ||
119 | + return true; | ||
120 | +} | ||
121 | + | ||
122 | +static bool do_2shift_narrow_32(DisasContext *s, arg_2reg_shift *a, | ||
123 | + NeonGenTwoOpFn *shiftfn, | ||
124 | + NeonGenNarrowEnvFn *narrowfn) | ||
125 | +{ | ||
126 | + /* 2-reg-and-shift narrowing-shift operations, size < 3 case */ | ||
127 | + TCGv_i32 constimm, rm1, rm2, rm3, rm4; | ||
128 | + TCGv_i64 rtmp; | ||
129 | + uint32_t imm; | ||
130 | + | ||
131 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
132 | + return false; | ||
133 | + } | ||
134 | + | ||
135 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
136 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
137 | + ((a->vd | a->vm) & 0x10)) { | ||
138 | + return false; | ||
139 | + } | ||
140 | + | ||
141 | + if (a->vm & 1) { | ||
142 | + return false; | ||
143 | + } | ||
144 | + | ||
145 | + if (!vfp_access_check(s)) { | ||
146 | + return true; | ||
147 | + } | ||
148 | + | ||
149 | + /* | ||
150 | + * This is always a right shift, and the shiftfn is always a | ||
151 | + * left-shift helper, which thus needs the negated shift count | ||
152 | + * duplicated into each lane of the immediate value. | ||
153 | + */ | ||
154 | + if (a->size == 1) { | ||
155 | + imm = (uint16_t)(-a->shift); | ||
156 | + imm |= imm << 16; | ||
157 | + } else { | ||
158 | + /* size == 2 */ | ||
159 | + imm = -a->shift; | ||
160 | + } | ||
161 | + constimm = tcg_const_i32(imm); | ||
162 | + | ||
163 | + /* Load all inputs first to avoid potential overwrite */ | ||
164 | + rm1 = neon_load_reg(a->vm, 0); | ||
165 | + rm2 = neon_load_reg(a->vm, 1); | ||
166 | + rm3 = neon_load_reg(a->vm + 1, 0); | ||
167 | + rm4 = neon_load_reg(a->vm + 1, 1); | ||
168 | + rtmp = tcg_temp_new_i64(); | ||
169 | + | ||
170 | + shiftfn(rm1, rm1, constimm); | ||
171 | + shiftfn(rm2, rm2, constimm); | ||
172 | + | ||
173 | + tcg_gen_concat_i32_i64(rtmp, rm1, rm2); | ||
174 | + tcg_temp_free_i32(rm2); | ||
175 | + | ||
176 | + narrowfn(rm1, cpu_env, rtmp); | ||
177 | + neon_store_reg(a->vd, 0, rm1); | ||
178 | + | ||
179 | + shiftfn(rm3, rm3, constimm); | ||
180 | + shiftfn(rm4, rm4, constimm); | ||
181 | + tcg_temp_free_i32(constimm); | ||
182 | + | ||
183 | + tcg_gen_concat_i32_i64(rtmp, rm3, rm4); | ||
184 | + tcg_temp_free_i32(rm4); | ||
185 | + | ||
186 | + narrowfn(rm3, cpu_env, rtmp); | ||
187 | + tcg_temp_free_i64(rtmp); | ||
188 | + neon_store_reg(a->vd, 1, rm3); | ||
189 | + return true; | ||
190 | +} | ||
191 | + | ||
192 | +#define DO_2SN_64(INSN, FUNC, NARROWFUNC) \ | ||
193 | + static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a) \ | ||
194 | + { \ | ||
195 | + return do_2shift_narrow_64(s, a, FUNC, NARROWFUNC); \ | ||
196 | + } | ||
197 | +#define DO_2SN_32(INSN, FUNC, NARROWFUNC) \ | ||
198 | + static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a) \ | ||
199 | + { \ | ||
200 | + return do_2shift_narrow_32(s, a, FUNC, NARROWFUNC); \ | ||
201 | + } | ||
202 | + | ||
203 | +static void gen_neon_narrow_u32(TCGv_i32 dest, TCGv_ptr env, TCGv_i64 src) | ||
204 | +{ | ||
205 | + tcg_gen_extrl_i64_i32(dest, src); | ||
206 | +} | ||
207 | + | ||
208 | +static void gen_neon_narrow_u16(TCGv_i32 dest, TCGv_ptr env, TCGv_i64 src) | ||
209 | +{ | ||
210 | + gen_helper_neon_narrow_u16(dest, src); | ||
211 | +} | ||
212 | + | ||
213 | +static void gen_neon_narrow_u8(TCGv_i32 dest, TCGv_ptr env, TCGv_i64 src) | ||
214 | +{ | ||
215 | + gen_helper_neon_narrow_u8(dest, src); | ||
216 | +} | ||
217 | + | ||
218 | +DO_2SN_64(VSHRN_64, gen_ushl_i64, gen_neon_narrow_u32) | ||
219 | +DO_2SN_32(VSHRN_32, gen_ushl_i32, gen_neon_narrow_u16) | ||
220 | +DO_2SN_32(VSHRN_16, gen_helper_neon_shl_u16, gen_neon_narrow_u8) | ||
221 | + | ||
222 | +DO_2SN_64(VRSHRN_64, gen_helper_neon_rshl_u64, gen_neon_narrow_u32) | ||
223 | +DO_2SN_32(VRSHRN_32, gen_helper_neon_rshl_u32, gen_neon_narrow_u16) | ||
224 | +DO_2SN_32(VRSHRN_16, gen_helper_neon_rshl_u16, gen_neon_narrow_u8) | ||
225 | + | ||
226 | +DO_2SN_64(VQSHRUN_64, gen_sshl_i64, gen_helper_neon_unarrow_sat32) | ||
227 | +DO_2SN_32(VQSHRUN_32, gen_sshl_i32, gen_helper_neon_unarrow_sat16) | ||
228 | +DO_2SN_32(VQSHRUN_16, gen_helper_neon_shl_s16, gen_helper_neon_unarrow_sat8) | ||
229 | + | ||
230 | +DO_2SN_64(VQRSHRUN_64, gen_helper_neon_rshl_s64, gen_helper_neon_unarrow_sat32) | ||
231 | +DO_2SN_32(VQRSHRUN_32, gen_helper_neon_rshl_s32, gen_helper_neon_unarrow_sat16) | ||
232 | +DO_2SN_32(VQRSHRUN_16, gen_helper_neon_rshl_s16, gen_helper_neon_unarrow_sat8) | ||
233 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
234 | index XXXXXXX..XXXXXXX 100644 | ||
235 | --- a/target/arm/translate.c | ||
236 | +++ b/target/arm/translate.c | ||
237 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
238 | case 5: /* VSHL, VSLI */ | ||
239 | case 6: /* VQSHLU */ | ||
240 | case 7: /* VQSHL */ | ||
241 | + case 8: /* VSHRN, VRSHRN, VQSHRUN, VQRSHRUN */ | ||
242 | return 1; /* handled by decodetree */ | ||
243 | default: | ||
244 | break; | ||
245 | -- | 25 | -- |
246 | 2.20.1 | 26 | 2.20.1 |
247 | 27 | ||
248 | 28 | diff view generated by jsdifflib |
1 | Convert the VQSHLU and QVSHL 2-reg-shift insns to decodetree. | 1 | In rom_check_and_register_reset() we detect overlaps by looking at |
---|---|---|---|
2 | These are the last of the simple shift-by-immediate insns. | 2 | whether the ROM blob we're currently examining is in the same address |
3 | space and starts before the previous ROM blob ends. (This works | ||
4 | because the ROM list is kept sorted in order by AddressSpace and then | ||
5 | by address.) | ||
6 | |||
7 | Instead of keeping the AddressSpace and last address of the previous ROM | ||
8 | blob in local variables, just keep a pointer to it. | ||
9 | |||
10 | This will allow us to print more useful information when we do detect | ||
11 | an overlap. | ||
3 | 12 | ||
4 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 14 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
6 | Message-id: 20200522145520.6778-5-peter.maydell@linaro.org | 15 | Message-id: 20201129203923.10622-2-peter.maydell@linaro.org |
7 | --- | 16 | --- |
8 | target/arm/neon-dp.decode | 15 +++++ | 17 | hw/core/loader.c | 23 +++++++++++++++-------- |
9 | target/arm/translate-neon.inc.c | 108 +++++++++++++++++++++++++++++++ | 18 | 1 file changed, 15 insertions(+), 8 deletions(-) |
10 | target/arm/translate.c | 110 +------------------------------- | ||
11 | 3 files changed, 126 insertions(+), 107 deletions(-) | ||
12 | 19 | ||
13 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 20 | diff --git a/hw/core/loader.c b/hw/core/loader.c |
14 | index XXXXXXX..XXXXXXX 100644 | 21 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/target/arm/neon-dp.decode | 22 | --- a/hw/core/loader.c |
16 | +++ b/target/arm/neon-dp.decode | 23 | +++ b/hw/core/loader.c |
17 | @@ -XXX,XX +XXX,XX @@ VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_d | 24 | @@ -XXX,XX +XXX,XX @@ static void rom_reset(void *unused) |
18 | VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_s | ||
19 | VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_h | ||
20 | VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_b | ||
21 | + | ||
22 | +VQSHLU_64_2sh 1111 001 1 1 . ...... .... 0110 . . . 1 .... @2reg_shl_d | ||
23 | +VQSHLU_2sh 1111 001 1 1 . ...... .... 0110 . . . 1 .... @2reg_shl_s | ||
24 | +VQSHLU_2sh 1111 001 1 1 . ...... .... 0110 . . . 1 .... @2reg_shl_h | ||
25 | +VQSHLU_2sh 1111 001 1 1 . ...... .... 0110 . . . 1 .... @2reg_shl_b | ||
26 | + | ||
27 | +VQSHL_S_64_2sh 1111 001 0 1 . ...... .... 0111 . . . 1 .... @2reg_shl_d | ||
28 | +VQSHL_S_2sh 1111 001 0 1 . ...... .... 0111 . . . 1 .... @2reg_shl_s | ||
29 | +VQSHL_S_2sh 1111 001 0 1 . ...... .... 0111 . . . 1 .... @2reg_shl_h | ||
30 | +VQSHL_S_2sh 1111 001 0 1 . ...... .... 0111 . . . 1 .... @2reg_shl_b | ||
31 | + | ||
32 | +VQSHL_U_64_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_d | ||
33 | +VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_s | ||
34 | +VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_h | ||
35 | +VQSHL_U_2sh 1111 001 1 1 . ...... .... 0111 . . . 1 .... @2reg_shl_b | ||
36 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
37 | index XXXXXXX..XXXXXXX 100644 | ||
38 | --- a/target/arm/translate-neon.inc.c | ||
39 | +++ b/target/arm/translate-neon.inc.c | ||
40 | @@ -XXX,XX +XXX,XX @@ static bool trans_VSHR_U_2sh(DisasContext *s, arg_2reg_shift *a) | ||
41 | return do_vector_2sh(s, a, tcg_gen_gvec_shri); | ||
42 | } | 25 | } |
43 | } | 26 | } |
44 | + | 27 | |
45 | +static bool do_2shift_env_64(DisasContext *s, arg_2reg_shift *a, | 28 | +/* Return true if two consecutive ROMs in the ROM list overlap */ |
46 | + NeonGenTwo64OpEnvFn *fn) | 29 | +static bool roms_overlap(Rom *last_rom, Rom *this_rom) |
47 | +{ | 30 | +{ |
48 | + /* | 31 | + if (!last_rom) { |
49 | + * 2-reg-and-shift operations, size == 3 case, where the | ||
50 | + * function needs to be passed cpu_env. | ||
51 | + */ | ||
52 | + TCGv_i64 constimm; | ||
53 | + int pass; | ||
54 | + | ||
55 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
56 | + return false; | 32 | + return false; |
57 | + } | 33 | + } |
58 | + | 34 | + return last_rom->as == this_rom->as && |
59 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | 35 | + last_rom->addr + last_rom->romsize > this_rom->addr; |
60 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
61 | + ((a->vd | a->vm) & 0x10)) { | ||
62 | + return false; | ||
63 | + } | ||
64 | + | ||
65 | + if ((a->vm | a->vd) & a->q) { | ||
66 | + return false; | ||
67 | + } | ||
68 | + | ||
69 | + if (!vfp_access_check(s)) { | ||
70 | + return true; | ||
71 | + } | ||
72 | + | ||
73 | + /* | ||
74 | + * To avoid excessive duplication of ops we implement shift | ||
75 | + * by immediate using the variable shift operations. | ||
76 | + */ | ||
77 | + constimm = tcg_const_i64(dup_const(a->size, a->shift)); | ||
78 | + | ||
79 | + for (pass = 0; pass < a->q + 1; pass++) { | ||
80 | + TCGv_i64 tmp = tcg_temp_new_i64(); | ||
81 | + | ||
82 | + neon_load_reg64(tmp, a->vm + pass); | ||
83 | + fn(tmp, cpu_env, tmp, constimm); | ||
84 | + neon_store_reg64(tmp, a->vd + pass); | ||
85 | + } | ||
86 | + tcg_temp_free_i64(constimm); | ||
87 | + return true; | ||
88 | +} | 36 | +} |
89 | + | 37 | + |
90 | +static bool do_2shift_env_32(DisasContext *s, arg_2reg_shift *a, | 38 | int rom_check_and_register_reset(void) |
91 | + NeonGenTwoOpEnvFn *fn) | ||
92 | +{ | ||
93 | + /* | ||
94 | + * 2-reg-and-shift operations, size < 3 case, where the | ||
95 | + * helper needs to be passed cpu_env. | ||
96 | + */ | ||
97 | + TCGv_i32 constimm; | ||
98 | + int pass; | ||
99 | + | ||
100 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
101 | + return false; | ||
102 | + } | ||
103 | + | ||
104 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
105 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
106 | + ((a->vd | a->vm) & 0x10)) { | ||
107 | + return false; | ||
108 | + } | ||
109 | + | ||
110 | + if ((a->vm | a->vd) & a->q) { | ||
111 | + return false; | ||
112 | + } | ||
113 | + | ||
114 | + if (!vfp_access_check(s)) { | ||
115 | + return true; | ||
116 | + } | ||
117 | + | ||
118 | + /* | ||
119 | + * To avoid excessive duplication of ops we implement shift | ||
120 | + * by immediate using the variable shift operations. | ||
121 | + */ | ||
122 | + constimm = tcg_const_i32(dup_const(a->size, a->shift)); | ||
123 | + | ||
124 | + for (pass = 0; pass < (a->q ? 4 : 2); pass++) { | ||
125 | + TCGv_i32 tmp = neon_load_reg(a->vm, pass); | ||
126 | + fn(tmp, cpu_env, tmp, constimm); | ||
127 | + neon_store_reg(a->vd, pass, tmp); | ||
128 | + } | ||
129 | + tcg_temp_free_i32(constimm); | ||
130 | + return true; | ||
131 | +} | ||
132 | + | ||
133 | +#define DO_2SHIFT_ENV(INSN, FUNC) \ | ||
134 | + static bool trans_##INSN##_64_2sh(DisasContext *s, arg_2reg_shift *a) \ | ||
135 | + { \ | ||
136 | + return do_2shift_env_64(s, a, gen_helper_neon_##FUNC##64); \ | ||
137 | + } \ | ||
138 | + static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a) \ | ||
139 | + { \ | ||
140 | + static NeonGenTwoOpEnvFn * const fns[] = { \ | ||
141 | + gen_helper_neon_##FUNC##8, \ | ||
142 | + gen_helper_neon_##FUNC##16, \ | ||
143 | + gen_helper_neon_##FUNC##32, \ | ||
144 | + }; \ | ||
145 | + assert(a->size < ARRAY_SIZE(fns)); \ | ||
146 | + return do_2shift_env_32(s, a, fns[a->size]); \ | ||
147 | + } | ||
148 | + | ||
149 | +DO_2SHIFT_ENV(VQSHLU, qshlu_s) | ||
150 | +DO_2SHIFT_ENV(VQSHL_U, qshl_u) | ||
151 | +DO_2SHIFT_ENV(VQSHL_S, qshl_s) | ||
152 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
153 | index XXXXXXX..XXXXXXX 100644 | ||
154 | --- a/target/arm/translate.c | ||
155 | +++ b/target/arm/translate.c | ||
156 | @@ -XXX,XX +XXX,XX @@ static inline void gen_neon_rsb(int size, TCGv_i32 t0, TCGv_i32 t1) | ||
157 | } | ||
158 | } | ||
159 | |||
160 | -#define GEN_NEON_INTEGER_OP_ENV(name) do { \ | ||
161 | - switch ((size << 1) | u) { \ | ||
162 | - case 0: \ | ||
163 | - gen_helper_neon_##name##_s8(tmp, cpu_env, tmp, tmp2); \ | ||
164 | - break; \ | ||
165 | - case 1: \ | ||
166 | - gen_helper_neon_##name##_u8(tmp, cpu_env, tmp, tmp2); \ | ||
167 | - break; \ | ||
168 | - case 2: \ | ||
169 | - gen_helper_neon_##name##_s16(tmp, cpu_env, tmp, tmp2); \ | ||
170 | - break; \ | ||
171 | - case 3: \ | ||
172 | - gen_helper_neon_##name##_u16(tmp, cpu_env, tmp, tmp2); \ | ||
173 | - break; \ | ||
174 | - case 4: \ | ||
175 | - gen_helper_neon_##name##_s32(tmp, cpu_env, tmp, tmp2); \ | ||
176 | - break; \ | ||
177 | - case 5: \ | ||
178 | - gen_helper_neon_##name##_u32(tmp, cpu_env, tmp, tmp2); \ | ||
179 | - break; \ | ||
180 | - default: return 1; \ | ||
181 | - }} while (0) | ||
182 | - | ||
183 | static TCGv_i32 neon_load_scratch(int scratch) | ||
184 | { | 39 | { |
185 | TCGv_i32 tmp = tcg_temp_new_i32(); | 40 | - hwaddr addr = 0; |
186 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 41 | MemoryRegionSection section; |
187 | int size; | 42 | - Rom *rom; |
188 | int shift; | 43 | - AddressSpace *as = NULL; |
189 | int pass; | 44 | + Rom *rom, *last_rom = NULL; |
190 | - int count; | 45 | |
191 | int u; | 46 | QTAILQ_FOREACH(rom, &roms, next) { |
192 | int vec_size; | 47 | if (rom->fw_file) { |
193 | uint32_t imm; | 48 | continue; |
194 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 49 | } |
195 | case 3: /* VRSRA */ | 50 | if (!rom->mr) { |
196 | case 4: /* VSRI */ | 51 | - if ((addr > rom->addr) && (as == rom->as)) { |
197 | case 5: /* VSHL, VSLI */ | 52 | + if (roms_overlap(last_rom, rom)) { |
198 | + case 6: /* VQSHLU */ | 53 | fprintf(stderr, "rom: requested regions overlap " |
199 | + case 7: /* VQSHL */ | 54 | "(rom %s. free=0x" TARGET_FMT_plx |
200 | return 1; /* handled by decodetree */ | 55 | ", addr=0x" TARGET_FMT_plx ")\n", |
201 | default: | 56 | - rom->name, addr, rom->addr); |
202 | break; | 57 | + rom->name, last_rom->addr + last_rom->romsize, |
203 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 58 | + rom->addr); |
204 | size--; | 59 | return -1; |
205 | } | 60 | } |
206 | shift = (insn >> 16) & ((1 << (3 + size)) - 1); | 61 | - addr = rom->addr; |
207 | - if (op < 8) { | 62 | - addr += rom->romsize; |
208 | - /* Shift by immediate: | 63 | - as = rom->as; |
209 | - VSHR, VSRA, VRSHR, VRSRA, VSRI, VSHL, VQSHL, VQSHLU. */ | 64 | + last_rom = rom; |
210 | - if (q && ((rd | rm) & 1)) { | 65 | } |
211 | - return 1; | 66 | section = memory_region_find(rom->mr ? rom->mr : get_system_memory(), |
212 | - } | 67 | rom->addr, 1); |
213 | - if (!u && (op == 4 || op == 6)) { | ||
214 | - return 1; | ||
215 | - } | ||
216 | - /* Right shifts are encoded as N - shift, where N is the | ||
217 | - element size in bits. */ | ||
218 | - if (op <= 4) { | ||
219 | - shift = shift - (1 << (size + 3)); | ||
220 | - } | ||
221 | - | ||
222 | - if (size == 3) { | ||
223 | - count = q + 1; | ||
224 | - } else { | ||
225 | - count = q ? 4: 2; | ||
226 | - } | ||
227 | - | ||
228 | - /* To avoid excessive duplication of ops we implement shift | ||
229 | - * by immediate using the variable shift operations. | ||
230 | - */ | ||
231 | - imm = dup_const(size, shift); | ||
232 | - | ||
233 | - for (pass = 0; pass < count; pass++) { | ||
234 | - if (size == 3) { | ||
235 | - neon_load_reg64(cpu_V0, rm + pass); | ||
236 | - tcg_gen_movi_i64(cpu_V1, imm); | ||
237 | - switch (op) { | ||
238 | - case 6: /* VQSHLU */ | ||
239 | - gen_helper_neon_qshlu_s64(cpu_V0, cpu_env, | ||
240 | - cpu_V0, cpu_V1); | ||
241 | - break; | ||
242 | - case 7: /* VQSHL */ | ||
243 | - if (u) { | ||
244 | - gen_helper_neon_qshl_u64(cpu_V0, cpu_env, | ||
245 | - cpu_V0, cpu_V1); | ||
246 | - } else { | ||
247 | - gen_helper_neon_qshl_s64(cpu_V0, cpu_env, | ||
248 | - cpu_V0, cpu_V1); | ||
249 | - } | ||
250 | - break; | ||
251 | - default: | ||
252 | - g_assert_not_reached(); | ||
253 | - } | ||
254 | - neon_store_reg64(cpu_V0, rd + pass); | ||
255 | - } else { /* size < 3 */ | ||
256 | - /* Operands in T0 and T1. */ | ||
257 | - tmp = neon_load_reg(rm, pass); | ||
258 | - tmp2 = tcg_temp_new_i32(); | ||
259 | - tcg_gen_movi_i32(tmp2, imm); | ||
260 | - switch (op) { | ||
261 | - case 6: /* VQSHLU */ | ||
262 | - switch (size) { | ||
263 | - case 0: | ||
264 | - gen_helper_neon_qshlu_s8(tmp, cpu_env, | ||
265 | - tmp, tmp2); | ||
266 | - break; | ||
267 | - case 1: | ||
268 | - gen_helper_neon_qshlu_s16(tmp, cpu_env, | ||
269 | - tmp, tmp2); | ||
270 | - break; | ||
271 | - case 2: | ||
272 | - gen_helper_neon_qshlu_s32(tmp, cpu_env, | ||
273 | - tmp, tmp2); | ||
274 | - break; | ||
275 | - default: | ||
276 | - abort(); | ||
277 | - } | ||
278 | - break; | ||
279 | - case 7: /* VQSHL */ | ||
280 | - GEN_NEON_INTEGER_OP_ENV(qshl); | ||
281 | - break; | ||
282 | - default: | ||
283 | - g_assert_not_reached(); | ||
284 | - } | ||
285 | - tcg_temp_free_i32(tmp2); | ||
286 | - neon_store_reg(rd, pass, tmp); | ||
287 | - } | ||
288 | - } /* for pass */ | ||
289 | - } else if (op < 10) { | ||
290 | + if (op < 10) { | ||
291 | /* Shift by immediate and narrow: | ||
292 | VSHRN, VRSHRN, VQSHRN, VQRSHRN. */ | ||
293 | int input_unsigned = (op == 8) ? !u : u; | ||
294 | -- | 68 | -- |
295 | 2.20.1 | 69 | 2.20.1 |
296 | 70 | ||
297 | 71 | diff view generated by jsdifflib |
1 | Convert the VSHR 2-reg-shift insns to decodetree. | 1 | In rom_check_and_register_reset() we report to the user if there is |
---|---|---|---|
2 | a "ROM region overlap". This has a couple of problems: | ||
3 | * the reported information is not very easy to intepret | ||
4 | * the function just prints the overlap to stderr (and relies on | ||
5 | its single callsite in vl.c to do an error_report() and exit) | ||
6 | * only the first overlap encountered is diagnosed | ||
2 | 7 | ||
3 | Note that unlike the legacy decoder, we present the right shift | 8 | Make this function use error_report() and error_printf() and |
4 | amount to the trans_ function as a positive integer. | 9 | report a more user-friendly report with all the overlaps |
10 | diagnosed. | ||
11 | |||
12 | Sample old output: | ||
13 | |||
14 | rom: requested regions overlap (rom dtb. free=0x0000000000008000, addr=0x0000000000000000) | ||
15 | qemu-system-aarch64: rom check and register reset failed | ||
16 | |||
17 | Sample new output: | ||
18 | |||
19 | qemu-system-aarch64: Some ROM regions are overlapping | ||
20 | These ROM regions might have been loaded by direct user request or by default. | ||
21 | They could be BIOS/firmware images, a guest kernel, initrd or some other file loaded into guest memory. | ||
22 | Check whether you intended to load all this guest code, and whether it has been built to load to the correct addresses. | ||
23 | |||
24 | The following two regions overlap (in the cpu-memory-0 address space): | ||
25 | phdr #0: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf (addresses 0x0000000000000000 - 0x0000000000008000) | ||
26 | dtb (addresses 0x0000000000000000 - 0x0000000000100000) | ||
27 | |||
28 | The following two regions overlap (in the cpu-memory-0 address space): | ||
29 | phdr #1: /home/petmay01/linaro/qemu-misc-tests/bad-psci-call.axf (addresses 0x0000000040000000 - 0x0000000040000010) | ||
30 | phdr #0: /home/petmay01/linaro/qemu-misc-tests/bp-test.elf (addresses 0x0000000040000000 - 0x0000000040000020) | ||
5 | 31 | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 32 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
7 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 33 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
8 | Message-id: 20200522145520.6778-3-peter.maydell@linaro.org | 34 | Message-id: 20201129203923.10622-3-peter.maydell@linaro.org |
9 | --- | 35 | --- |
10 | target/arm/neon-dp.decode | 25 ++++++++++++++++++++ | 36 | hw/core/loader.c | 48 ++++++++++++++++++++++++++++++++++++++++++------ |
11 | target/arm/translate-neon.inc.c | 41 +++++++++++++++++++++++++++++++++ | 37 | softmmu/vl.c | 1 - |
12 | target/arm/translate.c | 21 +---------------- | 38 | 2 files changed, 42 insertions(+), 7 deletions(-) |
13 | 3 files changed, 67 insertions(+), 20 deletions(-) | ||
14 | 39 | ||
15 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 40 | diff --git a/hw/core/loader.c b/hw/core/loader.c |
16 | index XXXXXXX..XXXXXXX 100644 | 41 | index XXXXXXX..XXXXXXX 100644 |
17 | --- a/target/arm/neon-dp.decode | 42 | --- a/hw/core/loader.c |
18 | +++ b/target/arm/neon-dp.decode | 43 | +++ b/hw/core/loader.c |
19 | @@ -XXX,XX +XXX,XX @@ VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 44 | @@ -XXX,XX +XXX,XX @@ static bool roms_overlap(Rom *last_rom, Rom *this_rom) |
20 | ###################################################################### | 45 | last_rom->addr + last_rom->romsize > this_rom->addr; |
21 | &2reg_shift vm vd q shift size | ||
22 | |||
23 | +# Right shifts are encoded as N - shift, where N is the element size in bits. | ||
24 | +%neon_rshift_i6 16:6 !function=rsub_64 | ||
25 | +%neon_rshift_i5 16:5 !function=rsub_32 | ||
26 | +%neon_rshift_i4 16:4 !function=rsub_16 | ||
27 | +%neon_rshift_i3 16:3 !function=rsub_8 | ||
28 | + | ||
29 | +@2reg_shr_d .... ... . . . ...... .... .... 1 q:1 . . .... \ | ||
30 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=3 shift=%neon_rshift_i6 | ||
31 | +@2reg_shr_s .... ... . . . 1 ..... .... .... 0 q:1 . . .... \ | ||
32 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=2 shift=%neon_rshift_i5 | ||
33 | +@2reg_shr_h .... ... . . . 01 .... .... .... 0 q:1 . . .... \ | ||
34 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=1 shift=%neon_rshift_i4 | ||
35 | +@2reg_shr_b .... ... . . . 001 ... .... .... 0 q:1 . . .... \ | ||
36 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=0 shift=%neon_rshift_i3 | ||
37 | + | ||
38 | @2reg_shl_d .... ... . . . shift:6 .... .... 1 q:1 . . .... \ | ||
39 | &2reg_shift vm=%vm_dp vd=%vd_dp size=3 | ||
40 | @2reg_shl_s .... ... . . . 1 shift:5 .... .... 0 q:1 . . .... \ | ||
41 | @@ -XXX,XX +XXX,XX @@ VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | ||
42 | @2reg_shl_b .... ... . . . 001 shift:3 .... .... 0 q:1 . . .... \ | ||
43 | &2reg_shift vm=%vm_dp vd=%vd_dp size=0 | ||
44 | |||
45 | +VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_d | ||
46 | +VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | ||
47 | +VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | ||
48 | +VSHR_S_2sh 1111 001 0 1 . ...... .... 0000 . . . 1 .... @2reg_shr_b | ||
49 | + | ||
50 | +VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_d | ||
51 | +VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | ||
52 | +VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | ||
53 | +VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_b | ||
54 | + | ||
55 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_d | ||
56 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_s | ||
57 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_h | ||
58 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
59 | index XXXXXXX..XXXXXXX 100644 | ||
60 | --- a/target/arm/translate-neon.inc.c | ||
61 | +++ b/target/arm/translate-neon.inc.c | ||
62 | @@ -XXX,XX +XXX,XX @@ static inline int plus1(DisasContext *s, int x) | ||
63 | return x + 1; | ||
64 | } | 46 | } |
65 | 47 | ||
66 | +static inline int rsub_64(DisasContext *s, int x) | 48 | +static const char *rom_as_name(Rom *rom) |
67 | +{ | 49 | +{ |
68 | + return 64 - x; | 50 | + const char *name = rom->as ? rom->as->name : NULL; |
51 | + return name ?: "anonymous"; | ||
69 | +} | 52 | +} |
70 | + | 53 | + |
71 | +static inline int rsub_32(DisasContext *s, int x) | 54 | +static void rom_print_overlap_error_header(void) |
72 | +{ | 55 | +{ |
73 | + return 32 - x; | 56 | + error_report("Some ROM regions are overlapping"); |
74 | +} | 57 | + error_printf( |
75 | +static inline int rsub_16(DisasContext *s, int x) | 58 | + "These ROM regions might have been loaded by " |
76 | +{ | 59 | + "direct user request or by default.\n" |
77 | + return 16 - x; | 60 | + "They could be BIOS/firmware images, a guest kernel, " |
78 | +} | 61 | + "initrd or some other file loaded into guest memory.\n" |
79 | +static inline int rsub_8(DisasContext *s, int x) | 62 | + "Check whether you intended to load all this guest code, and " |
80 | +{ | 63 | + "whether it has been built to load to the correct addresses.\n"); |
81 | + return 8 - x; | ||
82 | +} | 64 | +} |
83 | + | 65 | + |
84 | /* Include the generated Neon decoder */ | 66 | +static void rom_print_one_overlap_error(Rom *last_rom, Rom *rom) |
85 | #include "decode-neon-dp.inc.c" | ||
86 | #include "decode-neon-ls.inc.c" | ||
87 | @@ -XXX,XX +XXX,XX @@ static bool do_vector_2sh(DisasContext *s, arg_2reg_shift *a, GVecGen2iFn *fn) | ||
88 | |||
89 | DO_2SH(VSHL, tcg_gen_gvec_shli) | ||
90 | DO_2SH(VSLI, gen_gvec_sli) | ||
91 | + | ||
92 | +static bool trans_VSHR_S_2sh(DisasContext *s, arg_2reg_shift *a) | ||
93 | +{ | 67 | +{ |
94 | + /* Signed shift out of range results in all-sign-bits */ | 68 | + error_printf( |
95 | + a->shift = MIN(a->shift, (8 << a->size) - 1); | 69 | + "\nThe following two regions overlap (in the %s address space):\n", |
96 | + return do_vector_2sh(s, a, tcg_gen_gvec_sari); | 70 | + rom_as_name(rom)); |
71 | + error_printf( | ||
72 | + " %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n", | ||
73 | + last_rom->name, last_rom->addr, last_rom->addr + last_rom->romsize); | ||
74 | + error_printf( | ||
75 | + " %s (addresses 0x" TARGET_FMT_plx " - 0x" TARGET_FMT_plx ")\n", | ||
76 | + rom->name, rom->addr, rom->addr + rom->romsize); | ||
97 | +} | 77 | +} |
98 | + | 78 | + |
99 | +static void gen_zero_rd_2sh(unsigned vece, uint32_t rd_ofs, uint32_t rm_ofs, | 79 | int rom_check_and_register_reset(void) |
100 | + int64_t shift, uint32_t oprsz, uint32_t maxsz) | 80 | { |
101 | +{ | 81 | MemoryRegionSection section; |
102 | + tcg_gen_gvec_dup_imm(vece, rd_ofs, oprsz, maxsz, 0); | 82 | Rom *rom, *last_rom = NULL; |
103 | +} | 83 | + bool found_overlap = false; |
84 | |||
85 | QTAILQ_FOREACH(rom, &roms, next) { | ||
86 | if (rom->fw_file) { | ||
87 | @@ -XXX,XX +XXX,XX @@ int rom_check_and_register_reset(void) | ||
88 | } | ||
89 | if (!rom->mr) { | ||
90 | if (roms_overlap(last_rom, rom)) { | ||
91 | - fprintf(stderr, "rom: requested regions overlap " | ||
92 | - "(rom %s. free=0x" TARGET_FMT_plx | ||
93 | - ", addr=0x" TARGET_FMT_plx ")\n", | ||
94 | - rom->name, last_rom->addr + last_rom->romsize, | ||
95 | - rom->addr); | ||
96 | - return -1; | ||
97 | + if (!found_overlap) { | ||
98 | + found_overlap = true; | ||
99 | + rom_print_overlap_error_header(); | ||
100 | + } | ||
101 | + rom_print_one_overlap_error(last_rom, rom); | ||
102 | + /* Keep going through the list so we report all overlaps */ | ||
103 | } | ||
104 | last_rom = rom; | ||
105 | } | ||
106 | @@ -XXX,XX +XXX,XX @@ int rom_check_and_register_reset(void) | ||
107 | rom->isrom = int128_nz(section.size) && memory_region_is_rom(section.mr); | ||
108 | memory_region_unref(section.mr); | ||
109 | } | ||
110 | + if (found_overlap) { | ||
111 | + return -1; | ||
112 | + } | ||
104 | + | 113 | + |
105 | +static bool trans_VSHR_U_2sh(DisasContext *s, arg_2reg_shift *a) | 114 | qemu_register_reset(rom_reset, NULL); |
106 | +{ | 115 | roms_loaded = 1; |
107 | + /* Shift out of range is architecturally valid and results in zero. */ | 116 | return 0; |
108 | + if (a->shift >= (8 << a->size)) { | 117 | diff --git a/softmmu/vl.c b/softmmu/vl.c |
109 | + return do_vector_2sh(s, a, gen_zero_rd_2sh); | ||
110 | + } else { | ||
111 | + return do_vector_2sh(s, a, tcg_gen_gvec_shri); | ||
112 | + } | ||
113 | +} | ||
114 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
115 | index XXXXXXX..XXXXXXX 100644 | 118 | index XXXXXXX..XXXXXXX 100644 |
116 | --- a/target/arm/translate.c | 119 | --- a/softmmu/vl.c |
117 | +++ b/target/arm/translate.c | 120 | +++ b/softmmu/vl.c |
118 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 121 | @@ -XXX,XX +XXX,XX @@ static void qemu_machine_creation_done(void) |
119 | op = (insn >> 8) & 0xf; | 122 | qemu_run_machine_init_done_notifiers(); |
120 | 123 | ||
121 | switch (op) { | 124 | if (rom_check_and_register_reset() != 0) { |
122 | + case 0: /* VSHR */ | 125 | - error_report("rom check and register reset failed"); |
123 | case 5: /* VSHL, VSLI */ | 126 | exit(1); |
124 | return 1; /* handled by decodetree */ | 127 | } |
125 | default: | 128 | |
126 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
127 | } | ||
128 | |||
129 | switch (op) { | ||
130 | - case 0: /* VSHR */ | ||
131 | - /* Right shift comes here negative. */ | ||
132 | - shift = -shift; | ||
133 | - /* Shifts larger than the element size are architecturally | ||
134 | - * valid. Unsigned results in all zeros; signed results | ||
135 | - * in all sign bits. | ||
136 | - */ | ||
137 | - if (!u) { | ||
138 | - tcg_gen_gvec_sari(size, rd_ofs, rm_ofs, | ||
139 | - MIN(shift, (8 << size) - 1), | ||
140 | - vec_size, vec_size); | ||
141 | - } else if (shift >= 8 << size) { | ||
142 | - tcg_gen_gvec_dup_imm(MO_8, rd_ofs, vec_size, | ||
143 | - vec_size, 0); | ||
144 | - } else { | ||
145 | - tcg_gen_gvec_shri(size, rd_ofs, rm_ofs, shift, | ||
146 | - vec_size, vec_size); | ||
147 | - } | ||
148 | - return 0; | ||
149 | - | ||
150 | case 1: /* VSRA */ | ||
151 | /* Right shift comes here negative. */ | ||
152 | shift = -shift; | ||
153 | -- | 129 | -- |
154 | 2.20.1 | 130 | 2.20.1 |
155 | 131 | ||
156 | 132 | diff view generated by jsdifflib |
1 | Convert the VSRA, VSRI, VRSHR, VRSRA 2-reg-shift insns to decodetree. | 1 | Currently the load_elf code assembles the ROM blob name into a |
---|---|---|---|
2 | (These are the last instructions in the group that are vectorized; | 2 | local 128 byte fixed-size array. Use g_strdup_printf() instead so |
3 | the rest all require looping over each element.) | 3 | that we don't truncate the pathname if it happens to be long. |
4 | (This matters mostly for monitor 'info roms' output and for the | ||
5 | error messages if ROM blobs overlap.) | ||
4 | 6 | ||
5 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
6 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 8 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
7 | Message-id: 20200522145520.6778-4-peter.maydell@linaro.org | 9 | Message-id: 20201129203923.10622-4-peter.maydell@linaro.org |
8 | --- | 10 | --- |
9 | target/arm/neon-dp.decode | 35 ++++++++++++++++++++++ | 11 | include/hw/elf_ops.h | 4 ++-- |
10 | target/arm/translate-neon.inc.c | 7 +++++ | 12 | 1 file changed, 2 insertions(+), 2 deletions(-) |
11 | target/arm/translate.c | 52 +++------------------------------ | ||
12 | 3 files changed, 46 insertions(+), 48 deletions(-) | ||
13 | 13 | ||
14 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 14 | diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h |
15 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/target/arm/neon-dp.decode | 16 | --- a/include/hw/elf_ops.h |
17 | +++ b/target/arm/neon-dp.decode | 17 | +++ b/include/hw/elf_ops.h |
18 | @@ -XXX,XX +XXX,XX @@ VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_s | 18 | @@ -XXX,XX +XXX,XX @@ static int glue(load_elf, SZ)(const char *name, int fd, |
19 | VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_h | 19 | uint64_t addr, low = (uint64_t)-1, high = 0; |
20 | VSHR_U_2sh 1111 001 1 1 . ...... .... 0000 . . . 1 .... @2reg_shr_b | 20 | GMappedFile *mapped_file = NULL; |
21 | 21 | uint8_t *data = NULL; | |
22 | +VSRA_S_2sh 1111 001 0 1 . ...... .... 0001 . . . 1 .... @2reg_shr_d | 22 | - char label[128]; |
23 | +VSRA_S_2sh 1111 001 0 1 . ...... .... 0001 . . . 1 .... @2reg_shr_s | 23 | int ret = ELF_LOAD_FAILED; |
24 | +VSRA_S_2sh 1111 001 0 1 . ...... .... 0001 . . . 1 .... @2reg_shr_h | 24 | |
25 | +VSRA_S_2sh 1111 001 0 1 . ...... .... 0001 . . . 1 .... @2reg_shr_b | 25 | if (read(fd, &ehdr, sizeof(ehdr)) != sizeof(ehdr)) |
26 | + | 26 | @@ -XXX,XX +XXX,XX @@ static int glue(load_elf, SZ)(const char *name, int fd, |
27 | +VSRA_U_2sh 1111 001 1 1 . ...... .... 0001 . . . 1 .... @2reg_shr_d | 27 | */ |
28 | +VSRA_U_2sh 1111 001 1 1 . ...... .... 0001 . . . 1 .... @2reg_shr_s | 28 | if (mem_size != 0) { |
29 | +VSRA_U_2sh 1111 001 1 1 . ...... .... 0001 . . . 1 .... @2reg_shr_h | 29 | if (load_rom) { |
30 | +VSRA_U_2sh 1111 001 1 1 . ...... .... 0001 . . . 1 .... @2reg_shr_b | 30 | - snprintf(label, sizeof(label), "phdr #%d: %s", i, name); |
31 | + | 31 | + g_autofree char *label = |
32 | +VRSHR_S_2sh 1111 001 0 1 . ...... .... 0010 . . . 1 .... @2reg_shr_d | 32 | + g_strdup_printf("phdr #%d: %s", i, name); |
33 | +VRSHR_S_2sh 1111 001 0 1 . ...... .... 0010 . . . 1 .... @2reg_shr_s | 33 | |
34 | +VRSHR_S_2sh 1111 001 0 1 . ...... .... 0010 . . . 1 .... @2reg_shr_h | 34 | /* |
35 | +VRSHR_S_2sh 1111 001 0 1 . ...... .... 0010 . . . 1 .... @2reg_shr_b | 35 | * rom_add_elf_program() takes its own reference to |
36 | + | ||
37 | +VRSHR_U_2sh 1111 001 1 1 . ...... .... 0010 . . . 1 .... @2reg_shr_d | ||
38 | +VRSHR_U_2sh 1111 001 1 1 . ...... .... 0010 . . . 1 .... @2reg_shr_s | ||
39 | +VRSHR_U_2sh 1111 001 1 1 . ...... .... 0010 . . . 1 .... @2reg_shr_h | ||
40 | +VRSHR_U_2sh 1111 001 1 1 . ...... .... 0010 . . . 1 .... @2reg_shr_b | ||
41 | + | ||
42 | +VRSRA_S_2sh 1111 001 0 1 . ...... .... 0011 . . . 1 .... @2reg_shr_d | ||
43 | +VRSRA_S_2sh 1111 001 0 1 . ...... .... 0011 . . . 1 .... @2reg_shr_s | ||
44 | +VRSRA_S_2sh 1111 001 0 1 . ...... .... 0011 . . . 1 .... @2reg_shr_h | ||
45 | +VRSRA_S_2sh 1111 001 0 1 . ...... .... 0011 . . . 1 .... @2reg_shr_b | ||
46 | + | ||
47 | +VRSRA_U_2sh 1111 001 1 1 . ...... .... 0011 . . . 1 .... @2reg_shr_d | ||
48 | +VRSRA_U_2sh 1111 001 1 1 . ...... .... 0011 . . . 1 .... @2reg_shr_s | ||
49 | +VRSRA_U_2sh 1111 001 1 1 . ...... .... 0011 . . . 1 .... @2reg_shr_h | ||
50 | +VRSRA_U_2sh 1111 001 1 1 . ...... .... 0011 . . . 1 .... @2reg_shr_b | ||
51 | + | ||
52 | +VSRI_2sh 1111 001 1 1 . ...... .... 0100 . . . 1 .... @2reg_shr_d | ||
53 | +VSRI_2sh 1111 001 1 1 . ...... .... 0100 . . . 1 .... @2reg_shr_s | ||
54 | +VSRI_2sh 1111 001 1 1 . ...... .... 0100 . . . 1 .... @2reg_shr_h | ||
55 | +VSRI_2sh 1111 001 1 1 . ...... .... 0100 . . . 1 .... @2reg_shr_b | ||
56 | + | ||
57 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_d | ||
58 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_s | ||
59 | VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_h | ||
60 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
61 | index XXXXXXX..XXXXXXX 100644 | ||
62 | --- a/target/arm/translate-neon.inc.c | ||
63 | +++ b/target/arm/translate-neon.inc.c | ||
64 | @@ -XXX,XX +XXX,XX @@ static bool do_vector_2sh(DisasContext *s, arg_2reg_shift *a, GVecGen2iFn *fn) | ||
65 | |||
66 | DO_2SH(VSHL, tcg_gen_gvec_shli) | ||
67 | DO_2SH(VSLI, gen_gvec_sli) | ||
68 | +DO_2SH(VSRI, gen_gvec_sri) | ||
69 | +DO_2SH(VSRA_S, gen_gvec_ssra) | ||
70 | +DO_2SH(VSRA_U, gen_gvec_usra) | ||
71 | +DO_2SH(VRSHR_S, gen_gvec_srshr) | ||
72 | +DO_2SH(VRSHR_U, gen_gvec_urshr) | ||
73 | +DO_2SH(VRSRA_S, gen_gvec_srsra) | ||
74 | +DO_2SH(VRSRA_U, gen_gvec_ursra) | ||
75 | |||
76 | static bool trans_VSHR_S_2sh(DisasContext *s, arg_2reg_shift *a) | ||
77 | { | ||
78 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
79 | index XXXXXXX..XXXXXXX 100644 | ||
80 | --- a/target/arm/translate.c | ||
81 | +++ b/target/arm/translate.c | ||
82 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
83 | |||
84 | switch (op) { | ||
85 | case 0: /* VSHR */ | ||
86 | + case 1: /* VSRA */ | ||
87 | + case 2: /* VRSHR */ | ||
88 | + case 3: /* VRSRA */ | ||
89 | + case 4: /* VSRI */ | ||
90 | case 5: /* VSHL, VSLI */ | ||
91 | return 1; /* handled by decodetree */ | ||
92 | default: | ||
93 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
94 | shift = shift - (1 << (size + 3)); | ||
95 | } | ||
96 | |||
97 | - switch (op) { | ||
98 | - case 1: /* VSRA */ | ||
99 | - /* Right shift comes here negative. */ | ||
100 | - shift = -shift; | ||
101 | - if (u) { | ||
102 | - gen_gvec_usra(size, rd_ofs, rm_ofs, shift, | ||
103 | - vec_size, vec_size); | ||
104 | - } else { | ||
105 | - gen_gvec_ssra(size, rd_ofs, rm_ofs, shift, | ||
106 | - vec_size, vec_size); | ||
107 | - } | ||
108 | - return 0; | ||
109 | - | ||
110 | - case 2: /* VRSHR */ | ||
111 | - /* Right shift comes here negative. */ | ||
112 | - shift = -shift; | ||
113 | - if (u) { | ||
114 | - gen_gvec_urshr(size, rd_ofs, rm_ofs, shift, | ||
115 | - vec_size, vec_size); | ||
116 | - } else { | ||
117 | - gen_gvec_srshr(size, rd_ofs, rm_ofs, shift, | ||
118 | - vec_size, vec_size); | ||
119 | - } | ||
120 | - return 0; | ||
121 | - | ||
122 | - case 3: /* VRSRA */ | ||
123 | - /* Right shift comes here negative. */ | ||
124 | - shift = -shift; | ||
125 | - if (u) { | ||
126 | - gen_gvec_ursra(size, rd_ofs, rm_ofs, shift, | ||
127 | - vec_size, vec_size); | ||
128 | - } else { | ||
129 | - gen_gvec_srsra(size, rd_ofs, rm_ofs, shift, | ||
130 | - vec_size, vec_size); | ||
131 | - } | ||
132 | - return 0; | ||
133 | - | ||
134 | - case 4: /* VSRI */ | ||
135 | - if (!u) { | ||
136 | - return 1; | ||
137 | - } | ||
138 | - /* Right shift comes here negative. */ | ||
139 | - shift = -shift; | ||
140 | - gen_gvec_sri(size, rd_ofs, rm_ofs, shift, | ||
141 | - vec_size, vec_size); | ||
142 | - return 0; | ||
143 | - } | ||
144 | - | ||
145 | if (size == 3) { | ||
146 | count = q + 1; | ||
147 | } else { | ||
148 | -- | 36 | -- |
149 | 2.20.1 | 37 | 2.20.1 |
150 | 38 | ||
151 | 39 | diff view generated by jsdifflib |
1 | Convert the VSHL and VSLI insns from the Neon 2-registers-and-a-shift | 1 | Instead of making the ROM blob name something like: |
---|---|---|---|
2 | group to decodetree. | 2 | phdr #0: /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf |
3 | make it a little more self-explanatory for people who don't know | ||
4 | ELF format details: | ||
5 | /home/petmay01/linaro/qemu-misc-tests/ldmia-fault.axf ELF program header segment 0 | ||
3 | 6 | ||
4 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 7 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
5 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> | 8 | Reviewed-by: Richard Henderson <richard.henderson@linaro.org> |
6 | Message-id: 20200522145520.6778-2-peter.maydell@linaro.org | 9 | Message-id: 20201129203923.10622-5-peter.maydell@linaro.org |
7 | --- | 10 | --- |
8 | target/arm/neon-dp.decode | 25 ++++++++++++++++++++++ | 11 | include/hw/elf_ops.h | 3 ++- |
9 | target/arm/translate-neon.inc.c | 38 +++++++++++++++++++++++++++++++++ | 12 | 1 file changed, 2 insertions(+), 1 deletion(-) |
10 | target/arm/translate.c | 18 +++++++--------- | ||
11 | 3 files changed, 71 insertions(+), 10 deletions(-) | ||
12 | 13 | ||
13 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | 14 | diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h |
14 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
15 | --- a/target/arm/neon-dp.decode | 16 | --- a/include/hw/elf_ops.h |
16 | +++ b/target/arm/neon-dp.decode | 17 | +++ b/include/hw/elf_ops.h |
17 | @@ -XXX,XX +XXX,XX @@ VRECPS_fp_3s 1111 001 0 0 . 0 . .... .... 1111 ... 1 .... @3same_fp | 18 | @@ -XXX,XX +XXX,XX @@ static int glue(load_elf, SZ)(const char *name, int fd, |
18 | VRSQRTS_fp_3s 1111 001 0 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 19 | if (mem_size != 0) { |
19 | VMAXNM_fp_3s 1111 001 1 0 . 0 . .... .... 1111 ... 1 .... @3same_fp | 20 | if (load_rom) { |
20 | VMINNM_fp_3s 1111 001 1 0 . 1 . .... .... 1111 ... 1 .... @3same_fp | 21 | g_autofree char *label = |
21 | + | 22 | - g_strdup_printf("phdr #%d: %s", i, name); |
22 | +###################################################################### | 23 | + g_strdup_printf("%s ELF program header segment %d", |
23 | +# 2-reg-and-shift grouping: | 24 | + name, i); |
24 | +# 1111 001 U 1 D immH:3 immL:3 Vd:4 opc:4 L Q M 1 Vm:4 | 25 | |
25 | +###################################################################### | 26 | /* |
26 | +&2reg_shift vm vd q shift size | 27 | * rom_add_elf_program() takes its own reference to |
27 | + | ||
28 | +@2reg_shl_d .... ... . . . shift:6 .... .... 1 q:1 . . .... \ | ||
29 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=3 | ||
30 | +@2reg_shl_s .... ... . . . 1 shift:5 .... .... 0 q:1 . . .... \ | ||
31 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=2 | ||
32 | +@2reg_shl_h .... ... . . . 01 shift:4 .... .... 0 q:1 . . .... \ | ||
33 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=1 | ||
34 | +@2reg_shl_b .... ... . . . 001 shift:3 .... .... 0 q:1 . . .... \ | ||
35 | + &2reg_shift vm=%vm_dp vd=%vd_dp size=0 | ||
36 | + | ||
37 | +VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_d | ||
38 | +VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_s | ||
39 | +VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_h | ||
40 | +VSHL_2sh 1111 001 0 1 . ...... .... 0101 . . . 1 .... @2reg_shl_b | ||
41 | + | ||
42 | +VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_d | ||
43 | +VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_s | ||
44 | +VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_h | ||
45 | +VSLI_2sh 1111 001 1 1 . ...... .... 0101 . . . 1 .... @2reg_shl_b | ||
46 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
47 | index XXXXXXX..XXXXXXX 100644 | ||
48 | --- a/target/arm/translate-neon.inc.c | ||
49 | +++ b/target/arm/translate-neon.inc.c | ||
50 | @@ -XXX,XX +XXX,XX @@ static bool do_3same_fp_pair(DisasContext *s, arg_3same *a, VFPGen3OpSPFn *fn) | ||
51 | DO_3S_FP_PAIR(VPADD, gen_helper_vfp_adds) | ||
52 | DO_3S_FP_PAIR(VPMAX, gen_helper_vfp_maxs) | ||
53 | DO_3S_FP_PAIR(VPMIN, gen_helper_vfp_mins) | ||
54 | + | ||
55 | +static bool do_vector_2sh(DisasContext *s, arg_2reg_shift *a, GVecGen2iFn *fn) | ||
56 | +{ | ||
57 | + /* Handle a 2-reg-shift insn which can be vectorized. */ | ||
58 | + int vec_size = a->q ? 16 : 8; | ||
59 | + int rd_ofs = neon_reg_offset(a->vd, 0); | ||
60 | + int rm_ofs = neon_reg_offset(a->vm, 0); | ||
61 | + | ||
62 | + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
63 | + return false; | ||
64 | + } | ||
65 | + | ||
66 | + /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
67 | + if (!dc_isar_feature(aa32_simd_r32, s) && | ||
68 | + ((a->vd | a->vm) & 0x10)) { | ||
69 | + return false; | ||
70 | + } | ||
71 | + | ||
72 | + if ((a->vm | a->vd) & a->q) { | ||
73 | + return false; | ||
74 | + } | ||
75 | + | ||
76 | + if (!vfp_access_check(s)) { | ||
77 | + return true; | ||
78 | + } | ||
79 | + | ||
80 | + fn(a->size, rd_ofs, rm_ofs, a->shift, vec_size, vec_size); | ||
81 | + return true; | ||
82 | +} | ||
83 | + | ||
84 | +#define DO_2SH(INSN, FUNC) \ | ||
85 | + static bool trans_##INSN##_2sh(DisasContext *s, arg_2reg_shift *a) \ | ||
86 | + { \ | ||
87 | + return do_vector_2sh(s, a, FUNC); \ | ||
88 | + } \ | ||
89 | + | ||
90 | +DO_2SH(VSHL, tcg_gen_gvec_shli) | ||
91 | +DO_2SH(VSLI, gen_gvec_sli) | ||
92 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
93 | index XXXXXXX..XXXXXXX 100644 | ||
94 | --- a/target/arm/translate.c | ||
95 | +++ b/target/arm/translate.c | ||
96 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
97 | if ((insn & 0x00380080) != 0) { | ||
98 | /* Two registers and shift. */ | ||
99 | op = (insn >> 8) & 0xf; | ||
100 | + | ||
101 | + switch (op) { | ||
102 | + case 5: /* VSHL, VSLI */ | ||
103 | + return 1; /* handled by decodetree */ | ||
104 | + default: | ||
105 | + break; | ||
106 | + } | ||
107 | + | ||
108 | if (insn & (1 << 7)) { | ||
109 | /* 64-bit shift. */ | ||
110 | if (op > 7) { | ||
111 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
112 | gen_gvec_sri(size, rd_ofs, rm_ofs, shift, | ||
113 | vec_size, vec_size); | ||
114 | return 0; | ||
115 | - | ||
116 | - case 5: /* VSHL, VSLI */ | ||
117 | - if (u) { /* VSLI */ | ||
118 | - gen_gvec_sli(size, rd_ofs, rm_ofs, shift, | ||
119 | - vec_size, vec_size); | ||
120 | - } else { /* VSHL */ | ||
121 | - tcg_gen_gvec_shli(size, rd_ofs, rm_ofs, shift, | ||
122 | - vec_size, vec_size); | ||
123 | - } | ||
124 | - return 0; | ||
125 | } | ||
126 | |||
127 | if (size == 3) { | ||
128 | -- | 28 | -- |
129 | 2.20.1 | 29 | 2.20.1 |
130 | 30 | ||
131 | 31 | diff view generated by jsdifflib |
1 | From: Paul Zimmerman <pauldzim@gmail.com> | 1 | From: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | Add BCM2835 SOC MPHI (Message-based Parallel Host Interface) | 3 | This module emulates control registers of versal usb2 controller, this is added |
4 | emulation. It is very basic, only providing the FIQ interrupt | 4 | just to make guest happy. In general this module would control the phy-reset |
5 | needed to allow the dwc-otg USB host controller driver in the | 5 | signal from usb controller, data coherency of the transactions, signals |
6 | Raspbian kernel to function. | 6 | the host system errors received from controller. |
7 | 7 | ||
8 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | 8 | Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
9 | Acked-by: Philippe Mathieu-Daude <f4bug@amsat.org> | 9 | Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com> |
10 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
10 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
11 | Message-id: 20200520235349.21215-2-pauldzim@gmail.com | 12 | Message-id: 1607023357-5096-2-git-send-email-sai.pavan.boddu@xilinx.com |
12 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
13 | --- | 14 | --- |
14 | include/hw/arm/bcm2835_peripherals.h | 2 + | 15 | include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 45 ++++ |
15 | include/hw/misc/bcm2835_mphi.h | 44 ++++++ | 16 | hw/usb/xlnx-versal-usb2-ctrl-regs.c | 229 ++++++++++++++++++++ |
16 | hw/arm/bcm2835_peripherals.c | 17 +++ | 17 | hw/usb/meson.build | 1 + |
17 | hw/misc/bcm2835_mphi.c | 191 +++++++++++++++++++++++++++ | 18 | 3 files changed, 275 insertions(+) |
18 | hw/misc/Makefile.objs | 1 + | 19 | create mode 100644 include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |
19 | 5 files changed, 255 insertions(+) | 20 | create mode 100644 hw/usb/xlnx-versal-usb2-ctrl-regs.c |
20 | create mode 100644 include/hw/misc/bcm2835_mphi.h | 21 | |
21 | create mode 100644 hw/misc/bcm2835_mphi.c | 22 | diff --git a/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h b/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |
22 | |||
23 | diff --git a/include/hw/arm/bcm2835_peripherals.h b/include/hw/arm/bcm2835_peripherals.h | ||
24 | index XXXXXXX..XXXXXXX 100644 | ||
25 | --- a/include/hw/arm/bcm2835_peripherals.h | ||
26 | +++ b/include/hw/arm/bcm2835_peripherals.h | ||
27 | @@ -XXX,XX +XXX,XX @@ | ||
28 | #include "hw/misc/bcm2835_property.h" | ||
29 | #include "hw/misc/bcm2835_rng.h" | ||
30 | #include "hw/misc/bcm2835_mbox.h" | ||
31 | +#include "hw/misc/bcm2835_mphi.h" | ||
32 | #include "hw/misc/bcm2835_thermal.h" | ||
33 | #include "hw/sd/sdhci.h" | ||
34 | #include "hw/sd/bcm2835_sdhost.h" | ||
35 | @@ -XXX,XX +XXX,XX @@ typedef struct BCM2835PeripheralState { | ||
36 | qemu_irq irq, fiq; | ||
37 | |||
38 | BCM2835SystemTimerState systmr; | ||
39 | + BCM2835MphiState mphi; | ||
40 | UnimplementedDeviceState armtmr; | ||
41 | UnimplementedDeviceState cprman; | ||
42 | UnimplementedDeviceState a2w; | ||
43 | diff --git a/include/hw/misc/bcm2835_mphi.h b/include/hw/misc/bcm2835_mphi.h | ||
44 | new file mode 100644 | 23 | new file mode 100644 |
45 | index XXXXXXX..XXXXXXX | 24 | index XXXXXXX..XXXXXXX |
46 | --- /dev/null | 25 | --- /dev/null |
47 | +++ b/include/hw/misc/bcm2835_mphi.h | 26 | +++ b/include/hw/usb/xlnx-versal-usb2-ctrl-regs.h |
48 | @@ -XXX,XX +XXX,XX @@ | 27 | @@ -XXX,XX +XXX,XX @@ |
49 | +/* | 28 | +/* |
50 | + * BCM2835 SOC MPHI state definitions | 29 | + * QEMU model of the VersalUsb2CtrlRegs Register control/Status block for |
51 | + * | 30 | + * USB2.0 controller |
52 | + * Copyright (c) 2020 Paul Zimmerman <pauldzim@gmail.com> | 31 | + * |
53 | + * | 32 | + * Copyright (c) 2020 Xilinx Inc. Vikram Garhwal <fnu.vikram@xilinx.com> |
54 | + * This program is free software; you can redistribute it and/or modify | 33 | + * |
55 | + * it under the terms of the GNU General Public License as published by | 34 | + * Permission is hereby granted, free of charge, to any person obtaining a copy |
56 | + * the Free Software Foundation; either version 2 of the License, or | 35 | + * of this software and associated documentation files (the "Software"), to deal |
57 | + * (at your option) any later version. | 36 | + * in the Software without restriction, including without limitation the rights |
58 | + * | 37 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
59 | + * This program is distributed in the hope that it will be useful, | 38 | + * copies of the Software, and to permit persons to whom the Software is |
60 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of | 39 | + * furnished to do so, subject to the following conditions: |
61 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 40 | + * |
62 | + * GNU General Public License for more details. | 41 | + * The above copyright notice and this permission notice shall be included in |
42 | + * all copies or substantial portions of the Software. | ||
43 | + * | ||
44 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
45 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
46 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
47 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
48 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
49 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
50 | + * THE SOFTWARE. | ||
63 | + */ | 51 | + */ |
64 | + | 52 | + |
65 | +#ifndef HW_MISC_BCM2835_MPHI_H | 53 | +#ifndef _XLNX_USB2_REGS_H_ |
66 | +#define HW_MISC_BCM2835_MPHI_H | 54 | +#define _XLNX_USB2_REGS_H_ |
67 | + | 55 | + |
68 | +#include "hw/irq.h" | 56 | +#define TYPE_XILINX_VERSAL_USB2_CTRL_REGS "xlnx.versal-usb2-ctrl-regs" |
69 | +#include "hw/sysbus.h" | 57 | + |
70 | + | 58 | +#define XILINX_VERSAL_USB2_CTRL_REGS(obj) \ |
71 | +#define MPHI_MMIO_SIZE 0x1000 | 59 | + OBJECT_CHECK(VersalUsb2CtrlRegs, (obj), TYPE_XILINX_VERSAL_USB2_CTRL_REGS) |
72 | + | 60 | + |
73 | +typedef struct BCM2835MphiState BCM2835MphiState; | 61 | +#define USB2_REGS_R_MAX ((0x78 / 4) + 1) |
74 | + | 62 | + |
75 | +struct BCM2835MphiState { | 63 | +typedef struct VersalUsb2CtrlRegs { |
76 | + SysBusDevice parent_obj; | 64 | + SysBusDevice parent_obj; |
77 | + qemu_irq irq; | ||
78 | + MemoryRegion iomem; | 65 | + MemoryRegion iomem; |
79 | + | 66 | + qemu_irq irq_ir; |
80 | + uint32_t outdda; | 67 | + |
81 | + uint32_t outddb; | 68 | + uint32_t regs[USB2_REGS_R_MAX]; |
82 | + uint32_t ctrl; | 69 | + RegisterInfo regs_info[USB2_REGS_R_MAX]; |
83 | + uint32_t intstat; | 70 | +} VersalUsb2CtrlRegs; |
84 | + uint32_t swirq; | ||
85 | +}; | ||
86 | + | ||
87 | +#define TYPE_BCM2835_MPHI "bcm2835-mphi" | ||
88 | + | ||
89 | +#define BCM2835_MPHI(obj) \ | ||
90 | + OBJECT_CHECK(BCM2835MphiState, (obj), TYPE_BCM2835_MPHI) | ||
91 | + | 71 | + |
92 | +#endif | 72 | +#endif |
93 | diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c | 73 | diff --git a/hw/usb/xlnx-versal-usb2-ctrl-regs.c b/hw/usb/xlnx-versal-usb2-ctrl-regs.c |
94 | index XXXXXXX..XXXXXXX 100644 | ||
95 | --- a/hw/arm/bcm2835_peripherals.c | ||
96 | +++ b/hw/arm/bcm2835_peripherals.c | ||
97 | @@ -XXX,XX +XXX,XX @@ static void bcm2835_peripherals_init(Object *obj) | ||
98 | OBJECT(&s->sdhci.sdbus)); | ||
99 | object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhost", | ||
100 | OBJECT(&s->sdhost.sdbus)); | ||
101 | + | ||
102 | + /* Mphi */ | ||
103 | + sysbus_init_child_obj(obj, "mphi", &s->mphi, sizeof(s->mphi), | ||
104 | + TYPE_BCM2835_MPHI); | ||
105 | } | ||
106 | |||
107 | static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) | ||
108 | @@ -XXX,XX +XXX,XX @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) | ||
109 | |||
110 | object_property_add_alias(OBJECT(s), "sd-bus", OBJECT(&s->gpio), "sd-bus"); | ||
111 | |||
112 | + /* Mphi */ | ||
113 | + object_property_set_bool(OBJECT(&s->mphi), true, "realized", &err); | ||
114 | + if (err) { | ||
115 | + error_propagate(errp, err); | ||
116 | + return; | ||
117 | + } | ||
118 | + | ||
119 | + memory_region_add_subregion(&s->peri_mr, MPHI_OFFSET, | ||
120 | + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->mphi), 0)); | ||
121 | + sysbus_connect_irq(SYS_BUS_DEVICE(&s->mphi), 0, | ||
122 | + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, | ||
123 | + INTERRUPT_HOSTPORT)); | ||
124 | + | ||
125 | create_unimp(s, &s->armtmr, "bcm2835-sp804", ARMCTRL_TIMER0_1_OFFSET, 0x40); | ||
126 | create_unimp(s, &s->cprman, "bcm2835-cprman", CPRMAN_OFFSET, 0x1000); | ||
127 | create_unimp(s, &s->a2w, "bcm2835-a2w", A2W_OFFSET, 0x1000); | ||
128 | diff --git a/hw/misc/bcm2835_mphi.c b/hw/misc/bcm2835_mphi.c | ||
129 | new file mode 100644 | 74 | new file mode 100644 |
130 | index XXXXXXX..XXXXXXX | 75 | index XXXXXXX..XXXXXXX |
131 | --- /dev/null | 76 | --- /dev/null |
132 | +++ b/hw/misc/bcm2835_mphi.c | 77 | +++ b/hw/usb/xlnx-versal-usb2-ctrl-regs.c |
133 | @@ -XXX,XX +XXX,XX @@ | 78 | @@ -XXX,XX +XXX,XX @@ |
134 | +/* | 79 | +/* |
135 | + * BCM2835 SOC MPHI emulation | 80 | + * QEMU model of the VersalUsb2CtrlRegs Register control/Status block for |
136 | + * | 81 | + * USB2.0 controller |
137 | + * Very basic emulation, only providing the FIQ interrupt needed to | 82 | + * |
138 | + * allow the dwc-otg USB host controller driver in the Raspbian kernel | 83 | + * This module should control phy_reset, permanent device plugs, frame length |
139 | + * to function. | 84 | + * time adjust & setting of coherency paths. None of which are emulated in |
140 | + * | 85 | + * present model. |
141 | + * Copyright (c) 2020 Paul Zimmerman <pauldzim@gmail.com> | 86 | + * |
142 | + * | 87 | + * Copyright (c) 2020 Xilinx Inc. Vikram Garhwal <fnu.vikram@xilinx.com> |
143 | + * This program is free software; you can redistribute it and/or modify | 88 | + * |
144 | + * it under the terms of the GNU General Public License as published by | 89 | + * Permission is hereby granted, free of charge, to any person obtaining a copy |
145 | + * the Free Software Foundation; either version 2 of the License, or | 90 | + * of this software and associated documentation files (the "Software"), to deal |
146 | + * (at your option) any later version. | 91 | + * in the Software without restriction, including without limitation the rights |
147 | + * | 92 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
148 | + * This program is distributed in the hope that it will be useful, | 93 | + * copies of the Software, and to permit persons to whom the Software is |
149 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of | 94 | + * furnished to do so, subject to the following conditions: |
150 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 95 | + * |
151 | + * GNU General Public License for more details. | 96 | + * The above copyright notice and this permission notice shall be included in |
97 | + * all copies or substantial portions of the Software. | ||
98 | + * | ||
99 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
100 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
101 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
102 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
103 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
104 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
105 | + * THE SOFTWARE. | ||
152 | + */ | 106 | + */ |
153 | + | 107 | + |
154 | +#include "qemu/osdep.h" | 108 | +#include "qemu/osdep.h" |
155 | +#include "qapi/error.h" | 109 | +#include "hw/sysbus.h" |
156 | +#include "hw/misc/bcm2835_mphi.h" | 110 | +#include "hw/irq.h" |
111 | +#include "hw/register.h" | ||
112 | +#include "qemu/bitops.h" | ||
113 | +#include "qemu/log.h" | ||
114 | +#include "qom/object.h" | ||
157 | +#include "migration/vmstate.h" | 115 | +#include "migration/vmstate.h" |
158 | +#include "qemu/error-report.h" | 116 | +#include "hw/usb/xlnx-versal-usb2-ctrl-regs.h" |
159 | +#include "qemu/log.h" | 117 | + |
160 | +#include "qemu/main-loop.h" | 118 | +#ifndef XILINX_VERSAL_USB2_CTRL_REGS_ERR_DEBUG |
161 | + | 119 | +#define XILINX_VERSAL_USB2_CTRL_REGS_ERR_DEBUG 0 |
162 | +static inline void mphi_raise_irq(BCM2835MphiState *s) | 120 | +#endif |
163 | +{ | 121 | + |
164 | + qemu_set_irq(s->irq, 1); | 122 | +REG32(BUS_FILTER, 0x30) |
165 | +} | 123 | + FIELD(BUS_FILTER, BYPASS, 0, 4) |
166 | + | 124 | +REG32(PORT, 0x34) |
167 | +static inline void mphi_lower_irq(BCM2835MphiState *s) | 125 | + FIELD(PORT, HOST_SMI_BAR_WR, 4, 1) |
168 | +{ | 126 | + FIELD(PORT, HOST_SMI_PCI_CMD_REG_WR, 3, 1) |
169 | + qemu_set_irq(s->irq, 0); | 127 | + FIELD(PORT, HOST_MSI_ENABLE, 2, 1) |
170 | +} | 128 | + FIELD(PORT, PWR_CTRL_PRSNT, 1, 1) |
171 | + | 129 | + FIELD(PORT, HUB_PERM_ATTACH, 0, 1) |
172 | +static uint64_t mphi_reg_read(void *ptr, hwaddr addr, unsigned size) | 130 | +REG32(JITTER_ADJUST, 0x38) |
173 | +{ | 131 | + FIELD(JITTER_ADJUST, FLADJ, 0, 6) |
174 | + BCM2835MphiState *s = ptr; | 132 | +REG32(BIGENDIAN, 0x40) |
175 | + uint32_t val = 0; | 133 | + FIELD(BIGENDIAN, ENDIAN_GS, 0, 1) |
176 | + | 134 | +REG32(COHERENCY, 0x44) |
177 | + switch (addr) { | 135 | + FIELD(COHERENCY, USB_COHERENCY, 0, 1) |
178 | + case 0x28: /* outdda */ | 136 | +REG32(XHC_BME, 0x48) |
179 | + val = s->outdda; | 137 | + FIELD(XHC_BME, XHC_BME, 0, 1) |
180 | + break; | 138 | +REG32(REG_CTRL, 0x60) |
181 | + case 0x2c: /* outddb */ | 139 | + FIELD(REG_CTRL, SLVERR_ENABLE, 0, 1) |
182 | + val = s->outddb; | 140 | +REG32(IR_STATUS, 0x64) |
183 | + break; | 141 | + FIELD(IR_STATUS, HOST_SYS_ERR, 1, 1) |
184 | + case 0x4c: /* ctrl */ | 142 | + FIELD(IR_STATUS, ADDR_DEC_ERR, 0, 1) |
185 | + val = s->ctrl; | 143 | +REG32(IR_MASK, 0x68) |
186 | + val |= 1 << 17; | 144 | + FIELD(IR_MASK, HOST_SYS_ERR, 1, 1) |
187 | + break; | 145 | + FIELD(IR_MASK, ADDR_DEC_ERR, 0, 1) |
188 | + case 0x50: /* intstat */ | 146 | +REG32(IR_ENABLE, 0x6c) |
189 | + val = s->intstat; | 147 | + FIELD(IR_ENABLE, HOST_SYS_ERR, 1, 1) |
190 | + break; | 148 | + FIELD(IR_ENABLE, ADDR_DEC_ERR, 0, 1) |
191 | + case 0x1f0: /* swirq_set */ | 149 | +REG32(IR_DISABLE, 0x70) |
192 | + val = s->swirq; | 150 | + FIELD(IR_DISABLE, HOST_SYS_ERR, 1, 1) |
193 | + break; | 151 | + FIELD(IR_DISABLE, ADDR_DEC_ERR, 0, 1) |
194 | + case 0x1f4: /* swirq_clr */ | 152 | +REG32(USB3, 0x78) |
195 | + val = s->swirq; | 153 | + |
196 | + break; | 154 | +static void ir_update_irq(VersalUsb2CtrlRegs *s) |
197 | + default: | 155 | +{ |
198 | + qemu_log_mask(LOG_UNIMP, "read from unknown register"); | 156 | + bool pending = s->regs[R_IR_STATUS] & ~s->regs[R_IR_MASK]; |
199 | + break; | 157 | + qemu_set_irq(s->irq_ir, pending); |
158 | +} | ||
159 | + | ||
160 | +static void ir_status_postw(RegisterInfo *reg, uint64_t val64) | ||
161 | +{ | ||
162 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(reg->opaque); | ||
163 | + /* | ||
164 | + * TODO: This should also clear USBSTS.HSE field in USB XHCI register. | ||
165 | + * May be combine both the modules. | ||
166 | + */ | ||
167 | + ir_update_irq(s); | ||
168 | +} | ||
169 | + | ||
170 | +static uint64_t ir_enable_prew(RegisterInfo *reg, uint64_t val64) | ||
171 | +{ | ||
172 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(reg->opaque); | ||
173 | + uint32_t val = val64; | ||
174 | + | ||
175 | + s->regs[R_IR_MASK] &= ~val; | ||
176 | + ir_update_irq(s); | ||
177 | + return 0; | ||
178 | +} | ||
179 | + | ||
180 | +static uint64_t ir_disable_prew(RegisterInfo *reg, uint64_t val64) | ||
181 | +{ | ||
182 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(reg->opaque); | ||
183 | + uint32_t val = val64; | ||
184 | + | ||
185 | + s->regs[R_IR_MASK] |= val; | ||
186 | + ir_update_irq(s); | ||
187 | + return 0; | ||
188 | +} | ||
189 | + | ||
190 | +static const RegisterAccessInfo usb2_ctrl_regs_regs_info[] = { | ||
191 | + { .name = "BUS_FILTER", .addr = A_BUS_FILTER, | ||
192 | + .rsvd = 0xfffffff0, | ||
193 | + },{ .name = "PORT", .addr = A_PORT, | ||
194 | + .rsvd = 0xffffffe0, | ||
195 | + },{ .name = "JITTER_ADJUST", .addr = A_JITTER_ADJUST, | ||
196 | + .reset = 0x20, | ||
197 | + .rsvd = 0xffffffc0, | ||
198 | + },{ .name = "BIGENDIAN", .addr = A_BIGENDIAN, | ||
199 | + .rsvd = 0xfffffffe, | ||
200 | + },{ .name = "COHERENCY", .addr = A_COHERENCY, | ||
201 | + .rsvd = 0xfffffffe, | ||
202 | + },{ .name = "XHC_BME", .addr = A_XHC_BME, | ||
203 | + .reset = 0x1, | ||
204 | + .rsvd = 0xfffffffe, | ||
205 | + },{ .name = "REG_CTRL", .addr = A_REG_CTRL, | ||
206 | + .rsvd = 0xfffffffe, | ||
207 | + },{ .name = "IR_STATUS", .addr = A_IR_STATUS, | ||
208 | + .rsvd = 0xfffffffc, | ||
209 | + .w1c = 0x3, | ||
210 | + .post_write = ir_status_postw, | ||
211 | + },{ .name = "IR_MASK", .addr = A_IR_MASK, | ||
212 | + .reset = 0x3, | ||
213 | + .rsvd = 0xfffffffc, | ||
214 | + .ro = 0x3, | ||
215 | + },{ .name = "IR_ENABLE", .addr = A_IR_ENABLE, | ||
216 | + .rsvd = 0xfffffffc, | ||
217 | + .pre_write = ir_enable_prew, | ||
218 | + },{ .name = "IR_DISABLE", .addr = A_IR_DISABLE, | ||
219 | + .rsvd = 0xfffffffc, | ||
220 | + .pre_write = ir_disable_prew, | ||
221 | + },{ .name = "USB3", .addr = A_USB3, | ||
200 | + } | 222 | + } |
201 | + | 223 | +}; |
202 | + return val; | 224 | + |
203 | +} | 225 | +static void usb2_ctrl_regs_reset_init(Object *obj, ResetType type) |
204 | + | 226 | +{ |
205 | +static void mphi_reg_write(void *ptr, hwaddr addr, uint64_t val, unsigned size) | 227 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(obj); |
206 | +{ | 228 | + unsigned int i; |
207 | + BCM2835MphiState *s = ptr; | 229 | + |
208 | + int do_irq = 0; | 230 | + for (i = 0; i < ARRAY_SIZE(s->regs_info); ++i) { |
209 | + | 231 | + register_reset(&s->regs_info[i]); |
210 | + switch (addr) { | ||
211 | + case 0x28: /* outdda */ | ||
212 | + s->outdda = val; | ||
213 | + break; | ||
214 | + case 0x2c: /* outddb */ | ||
215 | + s->outddb = val; | ||
216 | + if (val & (1 << 29)) { | ||
217 | + do_irq = 1; | ||
218 | + } | ||
219 | + break; | ||
220 | + case 0x4c: /* ctrl */ | ||
221 | + s->ctrl = val; | ||
222 | + if (val & (1 << 16)) { | ||
223 | + do_irq = -1; | ||
224 | + } | ||
225 | + break; | ||
226 | + case 0x50: /* intstat */ | ||
227 | + s->intstat = val; | ||
228 | + if (val & ((1 << 16) | (1 << 29))) { | ||
229 | + do_irq = -1; | ||
230 | + } | ||
231 | + break; | ||
232 | + case 0x1f0: /* swirq_set */ | ||
233 | + s->swirq |= val; | ||
234 | + do_irq = 1; | ||
235 | + break; | ||
236 | + case 0x1f4: /* swirq_clr */ | ||
237 | + s->swirq &= ~val; | ||
238 | + do_irq = -1; | ||
239 | + break; | ||
240 | + default: | ||
241 | + qemu_log_mask(LOG_UNIMP, "write to unknown register"); | ||
242 | + return; | ||
243 | + } | 232 | + } |
244 | + | 233 | +} |
245 | + if (do_irq > 0) { | 234 | + |
246 | + mphi_raise_irq(s); | 235 | +static void usb2_ctrl_regs_reset_hold(Object *obj) |
247 | + } else if (do_irq < 0) { | 236 | +{ |
248 | + mphi_lower_irq(s); | 237 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(obj); |
249 | + } | 238 | + |
250 | +} | 239 | + ir_update_irq(s); |
251 | + | 240 | +} |
252 | +static const MemoryRegionOps mphi_mmio_ops = { | 241 | + |
253 | + .read = mphi_reg_read, | 242 | +static const MemoryRegionOps usb2_ctrl_regs_ops = { |
254 | + .write = mphi_reg_write, | 243 | + .read = register_read_memory, |
255 | + .impl.min_access_size = 4, | 244 | + .write = register_write_memory, |
256 | + .impl.max_access_size = 4, | ||
257 | + .endianness = DEVICE_LITTLE_ENDIAN, | 245 | + .endianness = DEVICE_LITTLE_ENDIAN, |
246 | + .valid = { | ||
247 | + .min_access_size = 4, | ||
248 | + .max_access_size = 4, | ||
249 | + }, | ||
258 | +}; | 250 | +}; |
259 | + | 251 | + |
260 | +static void mphi_reset(DeviceState *dev) | 252 | +static void usb2_ctrl_regs_init(Object *obj) |
261 | +{ | 253 | +{ |
262 | + BCM2835MphiState *s = BCM2835_MPHI(dev); | 254 | + VersalUsb2CtrlRegs *s = XILINX_VERSAL_USB2_CTRL_REGS(obj); |
263 | + | ||
264 | + s->outdda = 0; | ||
265 | + s->outddb = 0; | ||
266 | + s->ctrl = 0; | ||
267 | + s->intstat = 0; | ||
268 | + s->swirq = 0; | ||
269 | +} | ||
270 | + | ||
271 | +static void mphi_realize(DeviceState *dev, Error **errp) | ||
272 | +{ | ||
273 | + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); | ||
274 | + BCM2835MphiState *s = BCM2835_MPHI(dev); | ||
275 | + | ||
276 | + sysbus_init_irq(sbd, &s->irq); | ||
277 | +} | ||
278 | + | ||
279 | +static void mphi_init(Object *obj) | ||
280 | +{ | ||
281 | + SysBusDevice *sbd = SYS_BUS_DEVICE(obj); | 255 | + SysBusDevice *sbd = SYS_BUS_DEVICE(obj); |
282 | + BCM2835MphiState *s = BCM2835_MPHI(obj); | 256 | + RegisterInfoArray *reg_array; |
283 | + | 257 | + |
284 | + memory_region_init_io(&s->iomem, obj, &mphi_mmio_ops, s, "mphi", MPHI_MMIO_SIZE); | 258 | + memory_region_init(&s->iomem, obj, TYPE_XILINX_VERSAL_USB2_CTRL_REGS, |
259 | + USB2_REGS_R_MAX * 4); | ||
260 | + reg_array = | ||
261 | + register_init_block32(DEVICE(obj), usb2_ctrl_regs_regs_info, | ||
262 | + ARRAY_SIZE(usb2_ctrl_regs_regs_info), | ||
263 | + s->regs_info, s->regs, | ||
264 | + &usb2_ctrl_regs_ops, | ||
265 | + XILINX_VERSAL_USB2_CTRL_REGS_ERR_DEBUG, | ||
266 | + USB2_REGS_R_MAX * 4); | ||
267 | + memory_region_add_subregion(&s->iomem, | ||
268 | + 0x0, | ||
269 | + ®_array->mem); | ||
285 | + sysbus_init_mmio(sbd, &s->iomem); | 270 | + sysbus_init_mmio(sbd, &s->iomem); |
286 | +} | 271 | + sysbus_init_irq(sbd, &s->irq_ir); |
287 | + | 272 | +} |
288 | +const VMStateDescription vmstate_mphi_state = { | 273 | + |
289 | + .name = "mphi", | 274 | +static const VMStateDescription vmstate_usb2_ctrl_regs = { |
275 | + .name = TYPE_XILINX_VERSAL_USB2_CTRL_REGS, | ||
290 | + .version_id = 1, | 276 | + .version_id = 1, |
291 | + .minimum_version_id = 1, | 277 | + .minimum_version_id = 1, |
292 | + .fields = (VMStateField[]) { | 278 | + .fields = (VMStateField[]) { |
293 | + VMSTATE_UINT32(outdda, BCM2835MphiState), | 279 | + VMSTATE_UINT32_ARRAY(regs, VersalUsb2CtrlRegs, USB2_REGS_R_MAX), |
294 | + VMSTATE_UINT32(outddb, BCM2835MphiState), | 280 | + VMSTATE_END_OF_LIST(), |
295 | + VMSTATE_UINT32(ctrl, BCM2835MphiState), | ||
296 | + VMSTATE_UINT32(intstat, BCM2835MphiState), | ||
297 | + VMSTATE_UINT32(swirq, BCM2835MphiState), | ||
298 | + VMSTATE_END_OF_LIST() | ||
299 | + } | 281 | + } |
300 | +}; | 282 | +}; |
301 | + | 283 | + |
302 | +static void mphi_class_init(ObjectClass *klass, void *data) | 284 | +static void usb2_ctrl_regs_class_init(ObjectClass *klass, void *data) |
303 | +{ | 285 | +{ |
304 | + DeviceClass *dc = DEVICE_CLASS(klass); | 286 | + DeviceClass *dc = DEVICE_CLASS(klass); |
305 | + | 287 | + ResettableClass *rc = RESETTABLE_CLASS(klass); |
306 | + dc->realize = mphi_realize; | 288 | + |
307 | + dc->reset = mphi_reset; | 289 | + rc->phases.enter = usb2_ctrl_regs_reset_init; |
308 | + dc->vmsd = &vmstate_mphi_state; | 290 | + rc->phases.hold = usb2_ctrl_regs_reset_hold; |
309 | +} | 291 | + dc->vmsd = &vmstate_usb2_ctrl_regs; |
310 | + | 292 | +} |
311 | +static const TypeInfo bcm2835_mphi_type_info = { | 293 | + |
312 | + .name = TYPE_BCM2835_MPHI, | 294 | +static const TypeInfo usb2_ctrl_regs_info = { |
295 | + .name = TYPE_XILINX_VERSAL_USB2_CTRL_REGS, | ||
313 | + .parent = TYPE_SYS_BUS_DEVICE, | 296 | + .parent = TYPE_SYS_BUS_DEVICE, |
314 | + .instance_size = sizeof(BCM2835MphiState), | 297 | + .instance_size = sizeof(VersalUsb2CtrlRegs), |
315 | + .instance_init = mphi_init, | 298 | + .class_init = usb2_ctrl_regs_class_init, |
316 | + .class_init = mphi_class_init, | 299 | + .instance_init = usb2_ctrl_regs_init, |
317 | +}; | 300 | +}; |
318 | + | 301 | + |
319 | +static void bcm2835_mphi_register_types(void) | 302 | +static void usb2_ctrl_regs_register_types(void) |
320 | +{ | 303 | +{ |
321 | + type_register_static(&bcm2835_mphi_type_info); | 304 | + type_register_static(&usb2_ctrl_regs_info); |
322 | +} | 305 | +} |
323 | + | 306 | + |
324 | +type_init(bcm2835_mphi_register_types) | 307 | +type_init(usb2_ctrl_regs_register_types) |
325 | diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs | 308 | diff --git a/hw/usb/meson.build b/hw/usb/meson.build |
326 | index XXXXXXX..XXXXXXX 100644 | 309 | index XXXXXXX..XXXXXXX 100644 |
327 | --- a/hw/misc/Makefile.objs | 310 | --- a/hw/usb/meson.build |
328 | +++ b/hw/misc/Makefile.objs | 311 | +++ b/hw/usb/meson.build |
329 | @@ -XXX,XX +XXX,XX @@ common-obj-$(CONFIG_OMAP) += omap_l4.o | 312 | @@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_USB_DWC2', if_true: files('hcd-dwc2.c')) |
330 | common-obj-$(CONFIG_OMAP) += omap_sdrc.o | 313 | softmmu_ss.add(when: 'CONFIG_TUSB6010', if_true: files('tusb6010.c')) |
331 | common-obj-$(CONFIG_OMAP) += omap_tap.o | 314 | softmmu_ss.add(when: 'CONFIG_IMX', if_true: files('chipidea.c')) |
332 | common-obj-$(CONFIG_RASPI) += bcm2835_mbox.o | 315 | softmmu_ss.add(when: 'CONFIG_IMX_USBPHY', if_true: files('imx-usb-phy.c')) |
333 | +common-obj-$(CONFIG_RASPI) += bcm2835_mphi.o | 316 | +specific_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files('xlnx-versal-usb2-ctrl-regs.c')) |
334 | common-obj-$(CONFIG_RASPI) += bcm2835_property.o | 317 | |
335 | common-obj-$(CONFIG_RASPI) += bcm2835_rng.o | 318 | # emulated usb devices |
336 | common-obj-$(CONFIG_RASPI) += bcm2835_thermal.o | 319 | softmmu_ss.add(when: 'CONFIG_USB', if_true: files('dev-hub.c')) |
337 | -- | 320 | -- |
338 | 2.20.1 | 321 | 2.20.1 |
339 | 322 | ||
340 | 323 | diff view generated by jsdifflib |
1 | From: Paul Zimmerman <pauldzim@gmail.com> | 1 | From: Vikram Garhwal <fnu.vikram@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | Add the dwc-hsotg (dwc2) USB host controller emulation code. | 3 | This patch adds skeleton model of dwc3 usb controller attached to |
4 | Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c. | 4 | xhci-sysbus device. It defines global register space of DWC3 controller, |
5 | global registers control the AXI/AHB interfaces properties, external FIFO | ||
6 | support and event count support. All of which are unimplemented at | ||
7 | present,we are only supporting core reset and read of ID register. | ||
5 | 8 | ||
6 | Note that to use this with the dwc-otg driver in the Raspbian | 9 | Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com> |
7 | kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" on | 10 | Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
8 | the kernel command line. | 11 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> |
9 | 12 | Message-id: 1607023357-5096-3-git-send-email-sai.pavan.boddu@xilinx.com | |
10 | Emulation of slave mode and of descriptor-DMA mode has not been | ||
11 | implemented yet. These modes are seldom used. | ||
12 | |||
13 | I have used some on-line sources of information while developing | ||
14 | this emulation, including: | ||
15 | |||
16 | http://www.capital-micro.com/PDF/CME-M7_Family_User_Guide_EN.pdf | ||
17 | which has a pretty complete description of the controller starting | ||
18 | on page 370. | ||
19 | |||
20 | https://sourceforge.net/p/wive-ng/wive-ng-mt/ci/master/tree/docs/DataSheets/RT3050_5x_V2.0_081408_0902.pdf | ||
21 | which has a description of the controller registers starting on | ||
22 | page 130. | ||
23 | |||
24 | Thanks to Felippe Mathieu-Daude for providing a cleaner method | ||
25 | of implementing the memory regions for the controller registers. | ||
26 | |||
27 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | ||
28 | Message-id: 20200520235349.21215-5-pauldzim@gmail.com | ||
29 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
30 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
31 | --- | 14 | --- |
32 | hw/usb/hcd-dwc2.c | 1417 ++++++++++++++++++++++++++++++++++++++++++ | 15 | include/hw/usb/hcd-dwc3.h | 55 +++ |
33 | hw/usb/Kconfig | 5 + | 16 | hw/usb/hcd-dwc3.c | 689 ++++++++++++++++++++++++++++++++++++++ |
34 | hw/usb/Makefile.objs | 1 + | 17 | hw/usb/Kconfig | 5 + |
35 | hw/usb/trace-events | 50 ++ | 18 | hw/usb/meson.build | 1 + |
36 | 4 files changed, 1473 insertions(+) | 19 | 4 files changed, 750 insertions(+) |
37 | create mode 100644 hw/usb/hcd-dwc2.c | 20 | create mode 100644 include/hw/usb/hcd-dwc3.h |
21 | create mode 100644 hw/usb/hcd-dwc3.c | ||
38 | 22 | ||
39 | diff --git a/hw/usb/hcd-dwc2.c b/hw/usb/hcd-dwc2.c | 23 | diff --git a/include/hw/usb/hcd-dwc3.h b/include/hw/usb/hcd-dwc3.h |
40 | new file mode 100644 | 24 | new file mode 100644 |
41 | index XXXXXXX..XXXXXXX | 25 | index XXXXXXX..XXXXXXX |
42 | --- /dev/null | 26 | --- /dev/null |
43 | +++ b/hw/usb/hcd-dwc2.c | 27 | +++ b/include/hw/usb/hcd-dwc3.h |
44 | @@ -XXX,XX +XXX,XX @@ | 28 | @@ -XXX,XX +XXX,XX @@ |
45 | +/* | 29 | +/* |
46 | + * dwc-hsotg (dwc2) USB host controller emulation | 30 | + * QEMU model of the USB DWC3 host controller emulation. |
47 | + * | 31 | + * |
48 | + * Based on hw/usb/hcd-ehci.c and hw/usb/hcd-ohci.c | 32 | + * Copyright (c) 2020 Xilinx Inc. |
49 | + * | 33 | + * |
50 | + * Note that to use this emulation with the dwc-otg driver in the | 34 | + * Written by Vikram Garhwal<fnu.vikram@xilinx.com> |
51 | + * Raspbian kernel, you must pass the option "dwc_otg.fiq_fsm_enable=0" | 35 | + * |
52 | + * on the kernel command line. | 36 | + * Permission is hereby granted, free of charge, to any person obtaining a copy |
53 | + * | 37 | + * of this software and associated documentation files (the "Software"), to deal |
54 | + * Some useful documentation used to develop this emulation can be | 38 | + * in the Software without restriction, including without limitation the rights |
55 | + * found online (as of April 2020) at: | 39 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
56 | + * | 40 | + * copies of the Software, and to permit persons to whom the Software is |
57 | + * http://www.capital-micro.com/PDF/CME-M7_Family_User_Guide_EN.pdf | 41 | + * furnished to do so, subject to the following conditions: |
58 | + * which has a pretty complete description of the controller starting | 42 | + * |
59 | + * on page 370. | 43 | + * The above copyright notice and this permission notice shall be included in |
60 | + * | 44 | + * all copies or substantial portions of the Software. |
61 | + * https://sourceforge.net/p/wive-ng/wive-ng-mt/ci/master/tree/docs/DataSheets/RT3050_5x_V2.0_081408_0902.pdf | 45 | + * |
62 | + * which has a description of the controller registers starting on | 46 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
63 | + * page 130. | 47 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
64 | + * | 48 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
65 | + * Copyright (c) 2020 Paul Zimmerman <pauldzim@gmail.com> | 49 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
66 | + * | 50 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, |
67 | + * This program is free software; you can redistribute it and/or modify | 51 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN |
68 | + * it under the terms of the GNU General Public License as published by | 52 | + * THE SOFTWARE. |
69 | + * the Free Software Foundation; either version 2 of the License, or | ||
70 | + * (at your option) any later version. | ||
71 | + * | ||
72 | + * This program is distributed in the hope that it will be useful, | ||
73 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
74 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
75 | + * GNU General Public License for more details. | ||
76 | + */ | 53 | + */ |
54 | +#ifndef HCD_DWC3_H | ||
55 | +#define HCD_DWC3_H | ||
56 | + | ||
57 | +#include "hw/usb/hcd-xhci.h" | ||
58 | +#include "hw/usb/hcd-xhci-sysbus.h" | ||
59 | + | ||
60 | +#define TYPE_USB_DWC3 "usb_dwc3" | ||
61 | + | ||
62 | +#define USB_DWC3(obj) \ | ||
63 | + OBJECT_CHECK(USBDWC3, (obj), TYPE_USB_DWC3) | ||
64 | + | ||
65 | +#define USB_DWC3_R_MAX ((0x530 / 4) + 1) | ||
66 | +#define DWC3_SIZE 0x10000 | ||
67 | + | ||
68 | +typedef struct USBDWC3 { | ||
69 | + SysBusDevice parent_obj; | ||
70 | + MemoryRegion iomem; | ||
71 | + XHCISysbusState sysbus_xhci; | ||
72 | + | ||
73 | + uint32_t regs[USB_DWC3_R_MAX]; | ||
74 | + RegisterInfo regs_info[USB_DWC3_R_MAX]; | ||
75 | + | ||
76 | + struct { | ||
77 | + uint8_t mode; | ||
78 | + uint32_t dwc_usb3_user; | ||
79 | + } cfg; | ||
80 | + | ||
81 | +} USBDWC3; | ||
82 | + | ||
83 | +#endif | ||
84 | diff --git a/hw/usb/hcd-dwc3.c b/hw/usb/hcd-dwc3.c | ||
85 | new file mode 100644 | ||
86 | index XXXXXXX..XXXXXXX | ||
87 | --- /dev/null | ||
88 | +++ b/hw/usb/hcd-dwc3.c | ||
89 | @@ -XXX,XX +XXX,XX @@ | ||
90 | +/* | ||
91 | + * QEMU model of the USB DWC3 host controller emulation. | ||
92 | + * | ||
93 | + * This model defines global register space of DWC3 controller. Global | ||
94 | + * registers control the AXI/AHB interfaces properties, external FIFO support | ||
95 | + * and event count support. All of which are unimplemented at present. We are | ||
96 | + * only supporting core reset and read of ID register. | ||
97 | + * | ||
98 | + * Copyright (c) 2020 Xilinx Inc. Vikram Garhwal<fnu.vikram@xilinx.com> | ||
99 | + * | ||
100 | + * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
101 | + * of this software and associated documentation files (the "Software"), to deal | ||
102 | + * in the Software without restriction, including without limitation the rights | ||
103 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
104 | + * copies of the Software, and to permit persons to whom the Software is | ||
105 | + * furnished to do so, subject to the following conditions: | ||
106 | + * | ||
107 | + * The above copyright notice and this permission notice shall be included in | ||
108 | + * all copies or substantial portions of the Software. | ||
109 | + * | ||
110 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
111 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
112 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
113 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
114 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
115 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
116 | + * THE SOFTWARE. | ||
117 | + */ | ||
77 | + | 118 | + |
78 | +#include "qemu/osdep.h" | 119 | +#include "qemu/osdep.h" |
79 | +#include "qemu/units.h" | 120 | +#include "hw/sysbus.h" |
121 | +#include "hw/register.h" | ||
122 | +#include "qemu/bitops.h" | ||
123 | +#include "qemu/log.h" | ||
124 | +#include "qom/object.h" | ||
125 | +#include "migration/vmstate.h" | ||
126 | +#include "hw/qdev-properties.h" | ||
127 | +#include "hw/usb/hcd-dwc3.h" | ||
80 | +#include "qapi/error.h" | 128 | +#include "qapi/error.h" |
81 | +#include "hw/usb/dwc2-regs.h" | 129 | + |
82 | +#include "hw/usb/hcd-dwc2.h" | 130 | +#ifndef USB_DWC3_ERR_DEBUG |
83 | +#include "migration/vmstate.h" | 131 | +#define USB_DWC3_ERR_DEBUG 0 |
84 | +#include "trace.h" | 132 | +#endif |
85 | +#include "qemu/log.h" | 133 | + |
86 | +#include "qemu/error-report.h" | 134 | +#define HOST_MODE 1 |
87 | +#include "qemu/main-loop.h" | 135 | +#define FIFO_LEN 0x1000 |
88 | +#include "hw/qdev-properties.h" | 136 | + |
89 | + | 137 | +REG32(GSBUSCFG0, 0x00) |
90 | +#define USB_HZ_FS 12000000 | 138 | + FIELD(GSBUSCFG0, DATRDREQINFO, 28, 4) |
91 | +#define USB_HZ_HS 96000000 | 139 | + FIELD(GSBUSCFG0, DESRDREQINFO, 24, 4) |
92 | +#define USB_FRMINTVL 12000 | 140 | + FIELD(GSBUSCFG0, DATWRREQINFO, 20, 4) |
93 | + | 141 | + FIELD(GSBUSCFG0, DESWRREQINFO, 16, 4) |
94 | +/* nifty macros from Arnon's EHCI version */ | 142 | + FIELD(GSBUSCFG0, RESERVED_15_12, 12, 4) |
95 | +#define get_field(data, field) \ | 143 | + FIELD(GSBUSCFG0, DATBIGEND, 11, 1) |
96 | + (((data) & field##_MASK) >> field##_SHIFT) | 144 | + FIELD(GSBUSCFG0, DESBIGEND, 10, 1) |
97 | + | 145 | + FIELD(GSBUSCFG0, RESERVED_9_8, 8, 2) |
98 | +#define set_field(data, newval, field) do { \ | 146 | + FIELD(GSBUSCFG0, INCR256BRSTENA, 7, 1) |
99 | + uint32_t val = *(data); \ | 147 | + FIELD(GSBUSCFG0, INCR128BRSTENA, 6, 1) |
100 | + val &= ~field##_MASK; \ | 148 | + FIELD(GSBUSCFG0, INCR64BRSTENA, 5, 1) |
101 | + val |= ((newval) << field##_SHIFT) & field##_MASK; \ | 149 | + FIELD(GSBUSCFG0, INCR32BRSTENA, 4, 1) |
102 | + *(data) = val; \ | 150 | + FIELD(GSBUSCFG0, INCR16BRSTENA, 3, 1) |
103 | +} while (0) | 151 | + FIELD(GSBUSCFG0, INCR8BRSTENA, 2, 1) |
104 | + | 152 | + FIELD(GSBUSCFG0, INCR4BRSTENA, 1, 1) |
105 | +#define get_bit(data, bitmask) \ | 153 | + FIELD(GSBUSCFG0, INCRBRSTENA, 0, 1) |
106 | + (!!((data) & (bitmask))) | 154 | +REG32(GSBUSCFG1, 0x04) |
107 | + | 155 | + FIELD(GSBUSCFG1, RESERVED_31_13, 13, 19) |
108 | +/* update irq line */ | 156 | + FIELD(GSBUSCFG1, EN1KPAGE, 12, 1) |
109 | +static inline void dwc2_update_irq(DWC2State *s) | 157 | + FIELD(GSBUSCFG1, PIPETRANSLIMIT, 8, 4) |
158 | + FIELD(GSBUSCFG1, RESERVED_7_0, 0, 8) | ||
159 | +REG32(GTXTHRCFG, 0x08) | ||
160 | + FIELD(GTXTHRCFG, RESERVED_31, 31, 1) | ||
161 | + FIELD(GTXTHRCFG, RESERVED_30, 30, 1) | ||
162 | + FIELD(GTXTHRCFG, USBTXPKTCNTSEL, 29, 1) | ||
163 | + FIELD(GTXTHRCFG, RESERVED_28, 28, 1) | ||
164 | + FIELD(GTXTHRCFG, USBTXPKTCNT, 24, 4) | ||
165 | + FIELD(GTXTHRCFG, USBMAXTXBURSTSIZE, 16, 8) | ||
166 | + FIELD(GTXTHRCFG, RESERVED_15, 15, 1) | ||
167 | + FIELD(GTXTHRCFG, RESERVED_14, 14, 1) | ||
168 | + FIELD(GTXTHRCFG, RESERVED_13_11, 11, 3) | ||
169 | + FIELD(GTXTHRCFG, RESERVED_10_0, 0, 11) | ||
170 | +REG32(GRXTHRCFG, 0x0c) | ||
171 | + FIELD(GRXTHRCFG, RESERVED_31_30, 30, 2) | ||
172 | + FIELD(GRXTHRCFG, USBRXPKTCNTSEL, 29, 1) | ||
173 | + FIELD(GRXTHRCFG, RESERVED_28, 28, 1) | ||
174 | + FIELD(GRXTHRCFG, USBRXPKTCNT, 24, 4) | ||
175 | + FIELD(GRXTHRCFG, USBMAXRXBURSTSIZE, 19, 5) | ||
176 | + FIELD(GRXTHRCFG, RESERVED_18_16, 16, 3) | ||
177 | + FIELD(GRXTHRCFG, RESERVED_15, 15, 1) | ||
178 | + FIELD(GRXTHRCFG, RESERVED_14_13, 13, 2) | ||
179 | + FIELD(GRXTHRCFG, RESVISOCOUTSPC, 0, 13) | ||
180 | +REG32(GCTL, 0x10) | ||
181 | + FIELD(GCTL, PWRDNSCALE, 19, 13) | ||
182 | + FIELD(GCTL, MASTERFILTBYPASS, 18, 1) | ||
183 | + FIELD(GCTL, BYPSSETADDR, 17, 1) | ||
184 | + FIELD(GCTL, U2RSTECN, 16, 1) | ||
185 | + FIELD(GCTL, FRMSCLDWN, 14, 2) | ||
186 | + FIELD(GCTL, PRTCAPDIR, 12, 2) | ||
187 | + FIELD(GCTL, CORESOFTRESET, 11, 1) | ||
188 | + FIELD(GCTL, U1U2TIMERSCALE, 9, 1) | ||
189 | + FIELD(GCTL, DEBUGATTACH, 8, 1) | ||
190 | + FIELD(GCTL, RAMCLKSEL, 6, 2) | ||
191 | + FIELD(GCTL, SCALEDOWN, 4, 2) | ||
192 | + FIELD(GCTL, DISSCRAMBLE, 3, 1) | ||
193 | + FIELD(GCTL, U2EXIT_LFPS, 2, 1) | ||
194 | + FIELD(GCTL, GBLHIBERNATIONEN, 1, 1) | ||
195 | + FIELD(GCTL, DSBLCLKGTNG, 0, 1) | ||
196 | +REG32(GPMSTS, 0x14) | ||
197 | +REG32(GSTS, 0x18) | ||
198 | + FIELD(GSTS, CBELT, 20, 12) | ||
199 | + FIELD(GSTS, RESERVED_19_12, 12, 8) | ||
200 | + FIELD(GSTS, SSIC_IP, 11, 1) | ||
201 | + FIELD(GSTS, OTG_IP, 10, 1) | ||
202 | + FIELD(GSTS, BC_IP, 9, 1) | ||
203 | + FIELD(GSTS, ADP_IP, 8, 1) | ||
204 | + FIELD(GSTS, HOST_IP, 7, 1) | ||
205 | + FIELD(GSTS, DEVICE_IP, 6, 1) | ||
206 | + FIELD(GSTS, CSRTIMEOUT, 5, 1) | ||
207 | + FIELD(GSTS, BUSERRADDRVLD, 4, 1) | ||
208 | + FIELD(GSTS, RESERVED_3_2, 2, 2) | ||
209 | + FIELD(GSTS, CURMOD, 0, 2) | ||
210 | +REG32(GUCTL1, 0x1c) | ||
211 | + FIELD(GUCTL1, RESUME_OPMODE_HS_HOST, 10, 1) | ||
212 | +REG32(GSNPSID, 0x20) | ||
213 | +REG32(GGPIO, 0x24) | ||
214 | + FIELD(GGPIO, GPO, 16, 16) | ||
215 | + FIELD(GGPIO, GPI, 0, 16) | ||
216 | +REG32(GUID, 0x28) | ||
217 | +REG32(GUCTL, 0x2c) | ||
218 | + FIELD(GUCTL, REFCLKPER, 22, 10) | ||
219 | + FIELD(GUCTL, NOEXTRDL, 21, 1) | ||
220 | + FIELD(GUCTL, RESERVED_20_18, 18, 3) | ||
221 | + FIELD(GUCTL, SPRSCTRLTRANSEN, 17, 1) | ||
222 | + FIELD(GUCTL, RESBWHSEPS, 16, 1) | ||
223 | + FIELD(GUCTL, RESERVED_15, 15, 1) | ||
224 | + FIELD(GUCTL, USBHSTINAUTORETRYEN, 14, 1) | ||
225 | + FIELD(GUCTL, ENOVERLAPCHK, 13, 1) | ||
226 | + FIELD(GUCTL, EXTCAPSUPPTEN, 12, 1) | ||
227 | + FIELD(GUCTL, INSRTEXTRFSBODI, 11, 1) | ||
228 | + FIELD(GUCTL, DTCT, 9, 2) | ||
229 | + FIELD(GUCTL, DTFT, 0, 9) | ||
230 | +REG32(GBUSERRADDRLO, 0x30) | ||
231 | +REG32(GBUSERRADDRHI, 0x34) | ||
232 | +REG32(GHWPARAMS0, 0x40) | ||
233 | + FIELD(GHWPARAMS0, GHWPARAMS0_31_24, 24, 8) | ||
234 | + FIELD(GHWPARAMS0, GHWPARAMS0_23_16, 16, 8) | ||
235 | + FIELD(GHWPARAMS0, GHWPARAMS0_15_8, 8, 8) | ||
236 | + FIELD(GHWPARAMS0, GHWPARAMS0_7_6, 6, 2) | ||
237 | + FIELD(GHWPARAMS0, GHWPARAMS0_5_3, 3, 3) | ||
238 | + FIELD(GHWPARAMS0, GHWPARAMS0_2_0, 0, 3) | ||
239 | +REG32(GHWPARAMS1, 0x44) | ||
240 | + FIELD(GHWPARAMS1, GHWPARAMS1_31, 31, 1) | ||
241 | + FIELD(GHWPARAMS1, GHWPARAMS1_30, 30, 1) | ||
242 | + FIELD(GHWPARAMS1, GHWPARAMS1_29, 29, 1) | ||
243 | + FIELD(GHWPARAMS1, GHWPARAMS1_28, 28, 1) | ||
244 | + FIELD(GHWPARAMS1, GHWPARAMS1_27, 27, 1) | ||
245 | + FIELD(GHWPARAMS1, GHWPARAMS1_26, 26, 1) | ||
246 | + FIELD(GHWPARAMS1, GHWPARAMS1_25_24, 24, 2) | ||
247 | + FIELD(GHWPARAMS1, GHWPARAMS1_23, 23, 1) | ||
248 | + FIELD(GHWPARAMS1, GHWPARAMS1_22_21, 21, 2) | ||
249 | + FIELD(GHWPARAMS1, GHWPARAMS1_20_15, 15, 6) | ||
250 | + FIELD(GHWPARAMS1, GHWPARAMS1_14_12, 12, 3) | ||
251 | + FIELD(GHWPARAMS1, GHWPARAMS1_11_9, 9, 3) | ||
252 | + FIELD(GHWPARAMS1, GHWPARAMS1_8_6, 6, 3) | ||
253 | + FIELD(GHWPARAMS1, GHWPARAMS1_5_3, 3, 3) | ||
254 | + FIELD(GHWPARAMS1, GHWPARAMS1_2_0, 0, 3) | ||
255 | +REG32(GHWPARAMS2, 0x48) | ||
256 | +REG32(GHWPARAMS3, 0x4c) | ||
257 | + FIELD(GHWPARAMS3, GHWPARAMS3_31, 31, 1) | ||
258 | + FIELD(GHWPARAMS3, GHWPARAMS3_30_23, 23, 8) | ||
259 | + FIELD(GHWPARAMS3, GHWPARAMS3_22_18, 18, 5) | ||
260 | + FIELD(GHWPARAMS3, GHWPARAMS3_17_12, 12, 6) | ||
261 | + FIELD(GHWPARAMS3, GHWPARAMS3_11, 11, 1) | ||
262 | + FIELD(GHWPARAMS3, GHWPARAMS3_10, 10, 1) | ||
263 | + FIELD(GHWPARAMS3, GHWPARAMS3_9_8, 8, 2) | ||
264 | + FIELD(GHWPARAMS3, GHWPARAMS3_7_6, 6, 2) | ||
265 | + FIELD(GHWPARAMS3, GHWPARAMS3_5_4, 4, 2) | ||
266 | + FIELD(GHWPARAMS3, GHWPARAMS3_3_2, 2, 2) | ||
267 | + FIELD(GHWPARAMS3, GHWPARAMS3_1_0, 0, 2) | ||
268 | +REG32(GHWPARAMS4, 0x50) | ||
269 | + FIELD(GHWPARAMS4, GHWPARAMS4_31_28, 28, 4) | ||
270 | + FIELD(GHWPARAMS4, GHWPARAMS4_27_24, 24, 4) | ||
271 | + FIELD(GHWPARAMS4, GHWPARAMS4_23, 23, 1) | ||
272 | + FIELD(GHWPARAMS4, GHWPARAMS4_22, 22, 1) | ||
273 | + FIELD(GHWPARAMS4, GHWPARAMS4_21, 21, 1) | ||
274 | + FIELD(GHWPARAMS4, GHWPARAMS4_20_17, 17, 4) | ||
275 | + FIELD(GHWPARAMS4, GHWPARAMS4_16_13, 13, 4) | ||
276 | + FIELD(GHWPARAMS4, GHWPARAMS4_12, 12, 1) | ||
277 | + FIELD(GHWPARAMS4, GHWPARAMS4_11, 11, 1) | ||
278 | + FIELD(GHWPARAMS4, GHWPARAMS4_10_9, 9, 2) | ||
279 | + FIELD(GHWPARAMS4, GHWPARAMS4_8_7, 7, 2) | ||
280 | + FIELD(GHWPARAMS4, GHWPARAMS4_6, 6, 1) | ||
281 | + FIELD(GHWPARAMS4, GHWPARAMS4_5_0, 0, 6) | ||
282 | +REG32(GHWPARAMS5, 0x54) | ||
283 | + FIELD(GHWPARAMS5, GHWPARAMS5_31_28, 28, 4) | ||
284 | + FIELD(GHWPARAMS5, GHWPARAMS5_27_22, 22, 6) | ||
285 | + FIELD(GHWPARAMS5, GHWPARAMS5_21_16, 16, 6) | ||
286 | + FIELD(GHWPARAMS5, GHWPARAMS5_15_10, 10, 6) | ||
287 | + FIELD(GHWPARAMS5, GHWPARAMS5_9_4, 4, 6) | ||
288 | + FIELD(GHWPARAMS5, GHWPARAMS5_3_0, 0, 4) | ||
289 | +REG32(GHWPARAMS6, 0x58) | ||
290 | + FIELD(GHWPARAMS6, GHWPARAMS6_31_16, 16, 16) | ||
291 | + FIELD(GHWPARAMS6, BUSFLTRSSUPPORT, 15, 1) | ||
292 | + FIELD(GHWPARAMS6, BCSUPPORT, 14, 1) | ||
293 | + FIELD(GHWPARAMS6, OTG_SS_SUPPORT, 13, 1) | ||
294 | + FIELD(GHWPARAMS6, ADPSUPPORT, 12, 1) | ||
295 | + FIELD(GHWPARAMS6, HNPSUPPORT, 11, 1) | ||
296 | + FIELD(GHWPARAMS6, SRPSUPPORT, 10, 1) | ||
297 | + FIELD(GHWPARAMS6, GHWPARAMS6_9_8, 8, 2) | ||
298 | + FIELD(GHWPARAMS6, GHWPARAMS6_7, 7, 1) | ||
299 | + FIELD(GHWPARAMS6, GHWPARAMS6_6, 6, 1) | ||
300 | + FIELD(GHWPARAMS6, GHWPARAMS6_5_0, 0, 6) | ||
301 | +REG32(GHWPARAMS7, 0x5c) | ||
302 | + FIELD(GHWPARAMS7, GHWPARAMS7_31_16, 16, 16) | ||
303 | + FIELD(GHWPARAMS7, GHWPARAMS7_15_0, 0, 16) | ||
304 | +REG32(GDBGFIFOSPACE, 0x60) | ||
305 | + FIELD(GDBGFIFOSPACE, SPACE_AVAILABLE, 16, 16) | ||
306 | + FIELD(GDBGFIFOSPACE, RESERVED_15_9, 9, 7) | ||
307 | + FIELD(GDBGFIFOSPACE, FIFO_QUEUE_SELECT, 0, 9) | ||
308 | +REG32(GUCTL2, 0x9c) | ||
309 | + FIELD(GUCTL2, RESERVED_31_26, 26, 6) | ||
310 | + FIELD(GUCTL2, EN_HP_PM_TIMER, 19, 7) | ||
311 | + FIELD(GUCTL2, NOLOWPWRDUR, 15, 4) | ||
312 | + FIELD(GUCTL2, RST_ACTBITLATER, 14, 1) | ||
313 | + FIELD(GUCTL2, RESERVED_13, 13, 1) | ||
314 | + FIELD(GUCTL2, DISABLECFC, 11, 1) | ||
315 | +REG32(GUSB2PHYCFG, 0x100) | ||
316 | + FIELD(GUSB2PHYCFG, U2_FREECLK_EXISTS, 30, 1) | ||
317 | + FIELD(GUSB2PHYCFG, ULPI_LPM_WITH_OPMODE_CHK, 29, 1) | ||
318 | + FIELD(GUSB2PHYCFG, RESERVED_25, 25, 1) | ||
319 | + FIELD(GUSB2PHYCFG, LSTRD, 22, 3) | ||
320 | + FIELD(GUSB2PHYCFG, LSIPD, 19, 3) | ||
321 | + FIELD(GUSB2PHYCFG, ULPIEXTVBUSINDIACTOR, 18, 1) | ||
322 | + FIELD(GUSB2PHYCFG, ULPIEXTVBUSDRV, 17, 1) | ||
323 | + FIELD(GUSB2PHYCFG, RESERVED_16, 16, 1) | ||
324 | + FIELD(GUSB2PHYCFG, ULPIAUTORES, 15, 1) | ||
325 | + FIELD(GUSB2PHYCFG, RESERVED_14, 14, 1) | ||
326 | + FIELD(GUSB2PHYCFG, USBTRDTIM, 10, 4) | ||
327 | + FIELD(GUSB2PHYCFG, XCVRDLY, 9, 1) | ||
328 | + FIELD(GUSB2PHYCFG, ENBLSLPM, 8, 1) | ||
329 | + FIELD(GUSB2PHYCFG, PHYSEL, 7, 1) | ||
330 | + FIELD(GUSB2PHYCFG, SUSPENDUSB20, 6, 1) | ||
331 | + FIELD(GUSB2PHYCFG, FSINTF, 5, 1) | ||
332 | + FIELD(GUSB2PHYCFG, ULPI_UTMI_SEL, 4, 1) | ||
333 | + FIELD(GUSB2PHYCFG, PHYIF, 3, 1) | ||
334 | + FIELD(GUSB2PHYCFG, TOUTCAL, 0, 3) | ||
335 | +REG32(GUSB2I2CCTL, 0x140) | ||
336 | +REG32(GUSB2PHYACC_ULPI, 0x180) | ||
337 | + FIELD(GUSB2PHYACC_ULPI, RESERVED_31_27, 27, 5) | ||
338 | + FIELD(GUSB2PHYACC_ULPI, DISUIPIDRVR, 26, 1) | ||
339 | + FIELD(GUSB2PHYACC_ULPI, NEWREGREQ, 25, 1) | ||
340 | + FIELD(GUSB2PHYACC_ULPI, VSTSDONE, 24, 1) | ||
341 | + FIELD(GUSB2PHYACC_ULPI, VSTSBSY, 23, 1) | ||
342 | + FIELD(GUSB2PHYACC_ULPI, REGWR, 22, 1) | ||
343 | + FIELD(GUSB2PHYACC_ULPI, REGADDR, 16, 6) | ||
344 | + FIELD(GUSB2PHYACC_ULPI, EXTREGADDR, 8, 8) | ||
345 | + FIELD(GUSB2PHYACC_ULPI, REGDATA, 0, 8) | ||
346 | +REG32(GTXFIFOSIZ0, 0x200) | ||
347 | + FIELD(GTXFIFOSIZ0, TXFSTADDR_N, 16, 16) | ||
348 | + FIELD(GTXFIFOSIZ0, TXFDEP_N, 0, 16) | ||
349 | +REG32(GTXFIFOSIZ1, 0x204) | ||
350 | + FIELD(GTXFIFOSIZ1, TXFSTADDR_N, 16, 16) | ||
351 | + FIELD(GTXFIFOSIZ1, TXFDEP_N, 0, 16) | ||
352 | +REG32(GTXFIFOSIZ2, 0x208) | ||
353 | + FIELD(GTXFIFOSIZ2, TXFSTADDR_N, 16, 16) | ||
354 | + FIELD(GTXFIFOSIZ2, TXFDEP_N, 0, 16) | ||
355 | +REG32(GTXFIFOSIZ3, 0x20c) | ||
356 | + FIELD(GTXFIFOSIZ3, TXFSTADDR_N, 16, 16) | ||
357 | + FIELD(GTXFIFOSIZ3, TXFDEP_N, 0, 16) | ||
358 | +REG32(GTXFIFOSIZ4, 0x210) | ||
359 | + FIELD(GTXFIFOSIZ4, TXFSTADDR_N, 16, 16) | ||
360 | + FIELD(GTXFIFOSIZ4, TXFDEP_N, 0, 16) | ||
361 | +REG32(GTXFIFOSIZ5, 0x214) | ||
362 | + FIELD(GTXFIFOSIZ5, TXFSTADDR_N, 16, 16) | ||
363 | + FIELD(GTXFIFOSIZ5, TXFDEP_N, 0, 16) | ||
364 | +REG32(GRXFIFOSIZ0, 0x280) | ||
365 | + FIELD(GRXFIFOSIZ0, RXFSTADDR_N, 16, 16) | ||
366 | + FIELD(GRXFIFOSIZ0, RXFDEP_N, 0, 16) | ||
367 | +REG32(GRXFIFOSIZ1, 0x284) | ||
368 | + FIELD(GRXFIFOSIZ1, RXFSTADDR_N, 16, 16) | ||
369 | + FIELD(GRXFIFOSIZ1, RXFDEP_N, 0, 16) | ||
370 | +REG32(GRXFIFOSIZ2, 0x288) | ||
371 | + FIELD(GRXFIFOSIZ2, RXFSTADDR_N, 16, 16) | ||
372 | + FIELD(GRXFIFOSIZ2, RXFDEP_N, 0, 16) | ||
373 | +REG32(GEVNTADRLO_0, 0x300) | ||
374 | +REG32(GEVNTADRHI_0, 0x304) | ||
375 | +REG32(GEVNTSIZ_0, 0x308) | ||
376 | + FIELD(GEVNTSIZ_0, EVNTINTRPTMASK, 31, 1) | ||
377 | + FIELD(GEVNTSIZ_0, RESERVED_30_16, 16, 15) | ||
378 | + FIELD(GEVNTSIZ_0, EVENTSIZ, 0, 16) | ||
379 | +REG32(GEVNTCOUNT_0, 0x30c) | ||
380 | + FIELD(GEVNTCOUNT_0, EVNT_HANDLER_BUSY, 31, 1) | ||
381 | + FIELD(GEVNTCOUNT_0, RESERVED_30_16, 16, 15) | ||
382 | + FIELD(GEVNTCOUNT_0, EVNTCOUNT, 0, 16) | ||
383 | +REG32(GEVNTADRLO_1, 0x310) | ||
384 | +REG32(GEVNTADRHI_1, 0x314) | ||
385 | +REG32(GEVNTSIZ_1, 0x318) | ||
386 | + FIELD(GEVNTSIZ_1, EVNTINTRPTMASK, 31, 1) | ||
387 | + FIELD(GEVNTSIZ_1, RESERVED_30_16, 16, 15) | ||
388 | + FIELD(GEVNTSIZ_1, EVENTSIZ, 0, 16) | ||
389 | +REG32(GEVNTCOUNT_1, 0x31c) | ||
390 | + FIELD(GEVNTCOUNT_1, EVNT_HANDLER_BUSY, 31, 1) | ||
391 | + FIELD(GEVNTCOUNT_1, RESERVED_30_16, 16, 15) | ||
392 | + FIELD(GEVNTCOUNT_1, EVNTCOUNT, 0, 16) | ||
393 | +REG32(GEVNTADRLO_2, 0x320) | ||
394 | +REG32(GEVNTADRHI_2, 0x324) | ||
395 | +REG32(GEVNTSIZ_2, 0x328) | ||
396 | + FIELD(GEVNTSIZ_2, EVNTINTRPTMASK, 31, 1) | ||
397 | + FIELD(GEVNTSIZ_2, RESERVED_30_16, 16, 15) | ||
398 | + FIELD(GEVNTSIZ_2, EVENTSIZ, 0, 16) | ||
399 | +REG32(GEVNTCOUNT_2, 0x32c) | ||
400 | + FIELD(GEVNTCOUNT_2, EVNT_HANDLER_BUSY, 31, 1) | ||
401 | + FIELD(GEVNTCOUNT_2, RESERVED_30_16, 16, 15) | ||
402 | + FIELD(GEVNTCOUNT_2, EVNTCOUNT, 0, 16) | ||
403 | +REG32(GEVNTADRLO_3, 0x330) | ||
404 | +REG32(GEVNTADRHI_3, 0x334) | ||
405 | +REG32(GEVNTSIZ_3, 0x338) | ||
406 | + FIELD(GEVNTSIZ_3, EVNTINTRPTMASK, 31, 1) | ||
407 | + FIELD(GEVNTSIZ_3, RESERVED_30_16, 16, 15) | ||
408 | + FIELD(GEVNTSIZ_3, EVENTSIZ, 0, 16) | ||
409 | +REG32(GEVNTCOUNT_3, 0x33c) | ||
410 | + FIELD(GEVNTCOUNT_3, EVNT_HANDLER_BUSY, 31, 1) | ||
411 | + FIELD(GEVNTCOUNT_3, RESERVED_30_16, 16, 15) | ||
412 | + FIELD(GEVNTCOUNT_3, EVNTCOUNT, 0, 16) | ||
413 | +REG32(GHWPARAMS8, 0x500) | ||
414 | +REG32(GTXFIFOPRIDEV, 0x510) | ||
415 | + FIELD(GTXFIFOPRIDEV, RESERVED_31_N, 6, 26) | ||
416 | + FIELD(GTXFIFOPRIDEV, GTXFIFOPRIDEV, 0, 6) | ||
417 | +REG32(GTXFIFOPRIHST, 0x518) | ||
418 | + FIELD(GTXFIFOPRIHST, RESERVED_31_16, 3, 29) | ||
419 | + FIELD(GTXFIFOPRIHST, GTXFIFOPRIHST, 0, 3) | ||
420 | +REG32(GRXFIFOPRIHST, 0x51c) | ||
421 | + FIELD(GRXFIFOPRIHST, RESERVED_31_16, 3, 29) | ||
422 | + FIELD(GRXFIFOPRIHST, GRXFIFOPRIHST, 0, 3) | ||
423 | +REG32(GDMAHLRATIO, 0x524) | ||
424 | + FIELD(GDMAHLRATIO, RESERVED_31_13, 13, 19) | ||
425 | + FIELD(GDMAHLRATIO, HSTRXFIFO, 8, 5) | ||
426 | + FIELD(GDMAHLRATIO, RESERVED_7_5, 5, 3) | ||
427 | + FIELD(GDMAHLRATIO, HSTTXFIFO, 0, 5) | ||
428 | +REG32(GFLADJ, 0x530) | ||
429 | + FIELD(GFLADJ, GFLADJ_REFCLK_240MHZDECR_PLS1, 31, 1) | ||
430 | + FIELD(GFLADJ, GFLADJ_REFCLK_240MHZ_DECR, 24, 7) | ||
431 | + FIELD(GFLADJ, GFLADJ_REFCLK_LPM_SEL, 23, 1) | ||
432 | + FIELD(GFLADJ, RESERVED_22, 22, 1) | ||
433 | + FIELD(GFLADJ, GFLADJ_REFCLK_FLADJ, 8, 14) | ||
434 | + FIELD(GFLADJ, GFLADJ_30MHZ_SDBND_SEL, 7, 1) | ||
435 | + FIELD(GFLADJ, GFLADJ_30MHZ, 0, 6) | ||
436 | + | ||
437 | +#define DWC3_GLOBAL_OFFSET 0xC100 | ||
438 | +static void reset_csr(USBDWC3 * s) | ||
110 | +{ | 439 | +{ |
111 | + static int oldlevel; | 440 | + int i = 0; |
112 | + int level = 0; | 441 | + /* |
113 | + | 442 | + * We reset all CSR regs except GCTL, GUCTL, GSTS, GSNPSID, GGPIO, GUID, |
114 | + if ((s->gintsts & s->gintmsk) && (s->gahbcfg & GAHBCFG_GLBL_INTR_EN)) { | 443 | + * GUSB2PHYCFGn registers and GUSB3PIPECTLn registers. We will skip PHY |
115 | + level = 1; | 444 | + * register as we don't implement them. |
445 | + */ | ||
446 | + for (i = 0; i < USB_DWC3_R_MAX; i++) { | ||
447 | + switch (i) { | ||
448 | + case R_GCTL: | ||
449 | + break; | ||
450 | + case R_GSTS: | ||
451 | + break; | ||
452 | + case R_GSNPSID: | ||
453 | + break; | ||
454 | + case R_GGPIO: | ||
455 | + break; | ||
456 | + case R_GUID: | ||
457 | + break; | ||
458 | + case R_GUCTL: | ||
459 | + break; | ||
460 | + case R_GHWPARAMS0...R_GHWPARAMS7: | ||
461 | + break; | ||
462 | + case R_GHWPARAMS8: | ||
463 | + break; | ||
464 | + default: | ||
465 | + register_reset(&s->regs_info[i]); | ||
466 | + break; | ||
467 | + } | ||
116 | + } | 468 | + } |
117 | + if (level != oldlevel) { | 469 | + |
118 | + oldlevel = level; | 470 | + xhci_sysbus_reset(DEVICE(&s->sysbus_xhci)); |
119 | + trace_usb_dwc2_update_irq(level); | 471 | +} |
120 | + qemu_set_irq(s->irq, level); | 472 | + |
473 | +static void usb_dwc3_gctl_postw(RegisterInfo *reg, uint64_t val64) | ||
474 | +{ | ||
475 | + USBDWC3 *s = USB_DWC3(reg->opaque); | ||
476 | + | ||
477 | + if (ARRAY_FIELD_EX32(s->regs, GCTL, CORESOFTRESET)) { | ||
478 | + reset_csr(s); | ||
121 | + } | 479 | + } |
122 | +} | 480 | +} |
123 | + | 481 | + |
124 | +/* flag interrupt condition */ | 482 | +static void usb_dwc3_guid_postw(RegisterInfo *reg, uint64_t val64) |
125 | +static inline void dwc2_raise_global_irq(DWC2State *s, uint32_t intr) | ||
126 | +{ | 483 | +{ |
127 | + if (!(s->gintsts & intr)) { | 484 | + USBDWC3 *s = USB_DWC3(reg->opaque); |
128 | + s->gintsts |= intr; | 485 | + |
129 | + trace_usb_dwc2_raise_global_irq(intr); | 486 | + s->regs[R_GUID] = s->cfg.dwc_usb3_user; |
130 | + dwc2_update_irq(s); | 487 | +} |
488 | + | ||
489 | +static const RegisterAccessInfo usb_dwc3_regs_info[] = { | ||
490 | + { .name = "GSBUSCFG0", .addr = A_GSBUSCFG0, | ||
491 | + .ro = 0xf300, | ||
492 | + .unimp = 0xffffffff, | ||
493 | + },{ .name = "GSBUSCFG1", .addr = A_GSBUSCFG1, | ||
494 | + .reset = 0x300, | ||
495 | + .ro = 0xffffe0ff, | ||
496 | + .unimp = 0xffffffff, | ||
497 | + },{ .name = "GTXTHRCFG", .addr = A_GTXTHRCFG, | ||
498 | + .ro = 0xd000ffff, | ||
499 | + .unimp = 0xffffffff, | ||
500 | + },{ .name = "GRXTHRCFG", .addr = A_GRXTHRCFG, | ||
501 | + .ro = 0xd007e000, | ||
502 | + .unimp = 0xffffffff, | ||
503 | + },{ .name = "GCTL", .addr = A_GCTL, | ||
504 | + .reset = 0x30c13004, .post_write = usb_dwc3_gctl_postw, | ||
505 | + },{ .name = "GPMSTS", .addr = A_GPMSTS, | ||
506 | + .ro = 0xfffffff, | ||
507 | + .unimp = 0xffffffff, | ||
508 | + },{ .name = "GSTS", .addr = A_GSTS, | ||
509 | + .reset = 0x7e800000, | ||
510 | + .ro = 0xffffffcf, | ||
511 | + .w1c = 0x30, | ||
512 | + .unimp = 0xffffffff, | ||
513 | + },{ .name = "GUCTL1", .addr = A_GUCTL1, | ||
514 | + .reset = 0x198a, | ||
515 | + .ro = 0x7800, | ||
516 | + .unimp = 0xffffffff, | ||
517 | + },{ .name = "GSNPSID", .addr = A_GSNPSID, | ||
518 | + .reset = 0x5533330a, | ||
519 | + .ro = 0xffffffff, | ||
520 | + },{ .name = "GGPIO", .addr = A_GGPIO, | ||
521 | + .ro = 0xffff, | ||
522 | + .unimp = 0xffffffff, | ||
523 | + },{ .name = "GUID", .addr = A_GUID, | ||
524 | + .reset = 0x12345678, .post_write = usb_dwc3_guid_postw, | ||
525 | + },{ .name = "GUCTL", .addr = A_GUCTL, | ||
526 | + .reset = 0x0c808010, | ||
527 | + .ro = 0x1c8000, | ||
528 | + .unimp = 0xffffffff, | ||
529 | + },{ .name = "GBUSERRADDRLO", .addr = A_GBUSERRADDRLO, | ||
530 | + .ro = 0xffffffff, | ||
531 | + },{ .name = "GBUSERRADDRHI", .addr = A_GBUSERRADDRHI, | ||
532 | + .ro = 0xffffffff, | ||
533 | + },{ .name = "GHWPARAMS0", .addr = A_GHWPARAMS0, | ||
534 | + .ro = 0xffffffff, | ||
535 | + },{ .name = "GHWPARAMS1", .addr = A_GHWPARAMS1, | ||
536 | + .ro = 0xffffffff, | ||
537 | + },{ .name = "GHWPARAMS2", .addr = A_GHWPARAMS2, | ||
538 | + .ro = 0xffffffff, | ||
539 | + },{ .name = "GHWPARAMS3", .addr = A_GHWPARAMS3, | ||
540 | + .ro = 0xffffffff, | ||
541 | + },{ .name = "GHWPARAMS4", .addr = A_GHWPARAMS4, | ||
542 | + .ro = 0xffffffff, | ||
543 | + },{ .name = "GHWPARAMS5", .addr = A_GHWPARAMS5, | ||
544 | + .ro = 0xffffffff, | ||
545 | + },{ .name = "GHWPARAMS6", .addr = A_GHWPARAMS6, | ||
546 | + .ro = 0xffffffff, | ||
547 | + },{ .name = "GHWPARAMS7", .addr = A_GHWPARAMS7, | ||
548 | + .ro = 0xffffffff, | ||
549 | + },{ .name = "GDBGFIFOSPACE", .addr = A_GDBGFIFOSPACE, | ||
550 | + .reset = 0xa0000, | ||
551 | + .ro = 0xfffffe00, | ||
552 | + .unimp = 0xffffffff, | ||
553 | + },{ .name = "GUCTL2", .addr = A_GUCTL2, | ||
554 | + .reset = 0x40d, | ||
555 | + .ro = 0x2000, | ||
556 | + .unimp = 0xffffffff, | ||
557 | + },{ .name = "GUSB2PHYCFG", .addr = A_GUSB2PHYCFG, | ||
558 | + .reset = 0x40102410, | ||
559 | + .ro = 0x1e014030, | ||
560 | + .unimp = 0xffffffff, | ||
561 | + },{ .name = "GUSB2I2CCTL", .addr = A_GUSB2I2CCTL, | ||
562 | + .ro = 0xffffffff, | ||
563 | + .unimp = 0xffffffff, | ||
564 | + },{ .name = "GUSB2PHYACC_ULPI", .addr = A_GUSB2PHYACC_ULPI, | ||
565 | + .ro = 0xfd000000, | ||
566 | + .unimp = 0xffffffff, | ||
567 | + },{ .name = "GTXFIFOSIZ0", .addr = A_GTXFIFOSIZ0, | ||
568 | + .reset = 0x2c7000a, | ||
569 | + .unimp = 0xffffffff, | ||
570 | + },{ .name = "GTXFIFOSIZ1", .addr = A_GTXFIFOSIZ1, | ||
571 | + .reset = 0x2d10103, | ||
572 | + .unimp = 0xffffffff, | ||
573 | + },{ .name = "GTXFIFOSIZ2", .addr = A_GTXFIFOSIZ2, | ||
574 | + .reset = 0x3d40103, | ||
575 | + .unimp = 0xffffffff, | ||
576 | + },{ .name = "GTXFIFOSIZ3", .addr = A_GTXFIFOSIZ3, | ||
577 | + .reset = 0x4d70083, | ||
578 | + .unimp = 0xffffffff, | ||
579 | + },{ .name = "GTXFIFOSIZ4", .addr = A_GTXFIFOSIZ4, | ||
580 | + .reset = 0x55a0083, | ||
581 | + .unimp = 0xffffffff, | ||
582 | + },{ .name = "GTXFIFOSIZ5", .addr = A_GTXFIFOSIZ5, | ||
583 | + .reset = 0x5dd0083, | ||
584 | + .unimp = 0xffffffff, | ||
585 | + },{ .name = "GRXFIFOSIZ0", .addr = A_GRXFIFOSIZ0, | ||
586 | + .reset = 0x1c20105, | ||
587 | + .unimp = 0xffffffff, | ||
588 | + },{ .name = "GRXFIFOSIZ1", .addr = A_GRXFIFOSIZ1, | ||
589 | + .reset = 0x2c70000, | ||
590 | + .unimp = 0xffffffff, | ||
591 | + },{ .name = "GRXFIFOSIZ2", .addr = A_GRXFIFOSIZ2, | ||
592 | + .reset = 0x2c70000, | ||
593 | + .unimp = 0xffffffff, | ||
594 | + },{ .name = "GEVNTADRLO_0", .addr = A_GEVNTADRLO_0, | ||
595 | + .unimp = 0xffffffff, | ||
596 | + },{ .name = "GEVNTADRHI_0", .addr = A_GEVNTADRHI_0, | ||
597 | + .unimp = 0xffffffff, | ||
598 | + },{ .name = "GEVNTSIZ_0", .addr = A_GEVNTSIZ_0, | ||
599 | + .ro = 0x7fff0000, | ||
600 | + .unimp = 0xffffffff, | ||
601 | + },{ .name = "GEVNTCOUNT_0", .addr = A_GEVNTCOUNT_0, | ||
602 | + .ro = 0x7fff0000, | ||
603 | + .unimp = 0xffffffff, | ||
604 | + },{ .name = "GEVNTADRLO_1", .addr = A_GEVNTADRLO_1, | ||
605 | + .unimp = 0xffffffff, | ||
606 | + },{ .name = "GEVNTADRHI_1", .addr = A_GEVNTADRHI_1, | ||
607 | + .unimp = 0xffffffff, | ||
608 | + },{ .name = "GEVNTSIZ_1", .addr = A_GEVNTSIZ_1, | ||
609 | + .ro = 0x7fff0000, | ||
610 | + .unimp = 0xffffffff, | ||
611 | + },{ .name = "GEVNTCOUNT_1", .addr = A_GEVNTCOUNT_1, | ||
612 | + .ro = 0x7fff0000, | ||
613 | + .unimp = 0xffffffff, | ||
614 | + },{ .name = "GEVNTADRLO_2", .addr = A_GEVNTADRLO_2, | ||
615 | + .unimp = 0xffffffff, | ||
616 | + },{ .name = "GEVNTADRHI_2", .addr = A_GEVNTADRHI_2, | ||
617 | + .unimp = 0xffffffff, | ||
618 | + },{ .name = "GEVNTSIZ_2", .addr = A_GEVNTSIZ_2, | ||
619 | + .ro = 0x7fff0000, | ||
620 | + .unimp = 0xffffffff, | ||
621 | + },{ .name = "GEVNTCOUNT_2", .addr = A_GEVNTCOUNT_2, | ||
622 | + .ro = 0x7fff0000, | ||
623 | + .unimp = 0xffffffff, | ||
624 | + },{ .name = "GEVNTADRLO_3", .addr = A_GEVNTADRLO_3, | ||
625 | + .unimp = 0xffffffff, | ||
626 | + },{ .name = "GEVNTADRHI_3", .addr = A_GEVNTADRHI_3, | ||
627 | + .unimp = 0xffffffff, | ||
628 | + },{ .name = "GEVNTSIZ_3", .addr = A_GEVNTSIZ_3, | ||
629 | + .ro = 0x7fff0000, | ||
630 | + .unimp = 0xffffffff, | ||
631 | + },{ .name = "GEVNTCOUNT_3", .addr = A_GEVNTCOUNT_3, | ||
632 | + .ro = 0x7fff0000, | ||
633 | + .unimp = 0xffffffff, | ||
634 | + },{ .name = "GHWPARAMS8", .addr = A_GHWPARAMS8, | ||
635 | + .ro = 0xffffffff, | ||
636 | + },{ .name = "GTXFIFOPRIDEV", .addr = A_GTXFIFOPRIDEV, | ||
637 | + .ro = 0xffffffc0, | ||
638 | + .unimp = 0xffffffff, | ||
639 | + },{ .name = "GTXFIFOPRIHST", .addr = A_GTXFIFOPRIHST, | ||
640 | + .ro = 0xfffffff8, | ||
641 | + .unimp = 0xffffffff, | ||
642 | + },{ .name = "GRXFIFOPRIHST", .addr = A_GRXFIFOPRIHST, | ||
643 | + .ro = 0xfffffff8, | ||
644 | + .unimp = 0xffffffff, | ||
645 | + },{ .name = "GDMAHLRATIO", .addr = A_GDMAHLRATIO, | ||
646 | + .ro = 0xffffe0e0, | ||
647 | + .unimp = 0xffffffff, | ||
648 | + },{ .name = "GFLADJ", .addr = A_GFLADJ, | ||
649 | + .reset = 0xc83f020, | ||
650 | + .rsvd = 0x40, | ||
651 | + .ro = 0x400040, | ||
652 | + .unimp = 0xffffffff, | ||
131 | + } | 653 | + } |
654 | +}; | ||
655 | + | ||
656 | +static void usb_dwc3_reset(DeviceState *dev) | ||
657 | +{ | ||
658 | + USBDWC3 *s = USB_DWC3(dev); | ||
659 | + unsigned int i; | ||
660 | + | ||
661 | + for (i = 0; i < ARRAY_SIZE(s->regs_info); ++i) { | ||
662 | + switch (i) { | ||
663 | + case R_GHWPARAMS0...R_GHWPARAMS7: | ||
664 | + break; | ||
665 | + case R_GHWPARAMS8: | ||
666 | + break; | ||
667 | + default: | ||
668 | + register_reset(&s->regs_info[i]); | ||
669 | + }; | ||
670 | + } | ||
671 | + | ||
672 | + xhci_sysbus_reset(DEVICE(&s->sysbus_xhci)); | ||
132 | +} | 673 | +} |
133 | + | 674 | + |
134 | +static inline void dwc2_lower_global_irq(DWC2State *s, uint32_t intr) | 675 | +static const MemoryRegionOps usb_dwc3_ops = { |
676 | + .read = register_read_memory, | ||
677 | + .write = register_write_memory, | ||
678 | + .endianness = DEVICE_LITTLE_ENDIAN, | ||
679 | + .valid = { | ||
680 | + .min_access_size = 4, | ||
681 | + .max_access_size = 4, | ||
682 | + }, | ||
683 | +}; | ||
684 | + | ||
685 | +static void usb_dwc3_realize(DeviceState *dev, Error **errp) | ||
135 | +{ | 686 | +{ |
136 | + if (s->gintsts & intr) { | 687 | + USBDWC3 *s = USB_DWC3(dev); |
137 | + s->gintsts &= ~intr; | 688 | + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); |
138 | + trace_usb_dwc2_lower_global_irq(intr); | 689 | + Error *err = NULL; |
139 | + dwc2_update_irq(s); | 690 | + |
140 | + } | 691 | + sysbus_realize(SYS_BUS_DEVICE(&s->sysbus_xhci), &err); |
141 | +} | 692 | + if (err) { |
142 | + | 693 | + error_propagate(errp, err); |
143 | +static inline void dwc2_raise_host_irq(DWC2State *s, uint32_t host_intr) | ||
144 | +{ | ||
145 | + if (!(s->haint & host_intr)) { | ||
146 | + s->haint |= host_intr; | ||
147 | + s->haint &= 0xffff; | ||
148 | + trace_usb_dwc2_raise_host_irq(host_intr); | ||
149 | + if (s->haint & s->haintmsk) { | ||
150 | + dwc2_raise_global_irq(s, GINTSTS_HCHINT); | ||
151 | + } | ||
152 | + } | ||
153 | +} | ||
154 | + | ||
155 | +static inline void dwc2_lower_host_irq(DWC2State *s, uint32_t host_intr) | ||
156 | +{ | ||
157 | + if (s->haint & host_intr) { | ||
158 | + s->haint &= ~host_intr; | ||
159 | + trace_usb_dwc2_lower_host_irq(host_intr); | ||
160 | + if (!(s->haint & s->haintmsk)) { | ||
161 | + dwc2_lower_global_irq(s, GINTSTS_HCHINT); | ||
162 | + } | ||
163 | + } | ||
164 | +} | ||
165 | + | ||
166 | +static inline void dwc2_update_hc_irq(DWC2State *s, int index) | ||
167 | +{ | ||
168 | + uint32_t host_intr = 1 << (index >> 3); | ||
169 | + | ||
170 | + if (s->hreg1[index + 2] & s->hreg1[index + 3]) { | ||
171 | + dwc2_raise_host_irq(s, host_intr); | ||
172 | + } else { | ||
173 | + dwc2_lower_host_irq(s, host_intr); | ||
174 | + } | ||
175 | +} | ||
176 | + | ||
177 | +/* set a timer for EOF */ | ||
178 | +static void dwc2_eof_timer(DWC2State *s) | ||
179 | +{ | ||
180 | + timer_mod(s->eof_timer, s->sof_time + s->usb_frame_time); | ||
181 | +} | ||
182 | + | ||
183 | +/* Set a timer for EOF and generate SOF event */ | ||
184 | +static void dwc2_sof(DWC2State *s) | ||
185 | +{ | ||
186 | + s->sof_time += s->usb_frame_time; | ||
187 | + trace_usb_dwc2_sof(s->sof_time); | ||
188 | + dwc2_eof_timer(s); | ||
189 | + dwc2_raise_global_irq(s, GINTSTS_SOF); | ||
190 | +} | ||
191 | + | ||
192 | +/* Do frame processing on frame boundary */ | ||
193 | +static void dwc2_frame_boundary(void *opaque) | ||
194 | +{ | ||
195 | + DWC2State *s = opaque; | ||
196 | + int64_t now; | ||
197 | + uint16_t frcnt; | ||
198 | + | ||
199 | + now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); | ||
200 | + | ||
201 | + /* Frame boundary, so do EOF stuff here */ | ||
202 | + | ||
203 | + /* Increment frame number */ | ||
204 | + frcnt = (uint16_t)((now - s->sof_time) / s->fi); | ||
205 | + s->frame_number = (s->frame_number + frcnt) & 0xffff; | ||
206 | + s->hfnum = s->frame_number & HFNUM_MAX_FRNUM; | ||
207 | + | ||
208 | + /* Do SOF stuff here */ | ||
209 | + dwc2_sof(s); | ||
210 | +} | ||
211 | + | ||
212 | +/* Start sending SOF tokens on the USB bus */ | ||
213 | +static void dwc2_bus_start(DWC2State *s) | ||
214 | +{ | ||
215 | + trace_usb_dwc2_bus_start(); | ||
216 | + s->sof_time = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); | ||
217 | + dwc2_eof_timer(s); | ||
218 | +} | ||
219 | + | ||
220 | +/* Stop sending SOF tokens on the USB bus */ | ||
221 | +static void dwc2_bus_stop(DWC2State *s) | ||
222 | +{ | ||
223 | + trace_usb_dwc2_bus_stop(); | ||
224 | + timer_del(s->eof_timer); | ||
225 | +} | ||
226 | + | ||
227 | +static USBDevice *dwc2_find_device(DWC2State *s, uint8_t addr) | ||
228 | +{ | ||
229 | + USBDevice *dev; | ||
230 | + | ||
231 | + trace_usb_dwc2_find_device(addr); | ||
232 | + | ||
233 | + if (!(s->hprt0 & HPRT0_ENA)) { | ||
234 | + trace_usb_dwc2_port_disabled(0); | ||
235 | + } else { | ||
236 | + dev = usb_find_device(&s->uport, addr); | ||
237 | + if (dev != NULL) { | ||
238 | + trace_usb_dwc2_device_found(0); | ||
239 | + return dev; | ||
240 | + } | ||
241 | + } | ||
242 | + | ||
243 | + trace_usb_dwc2_device_not_found(); | ||
244 | + return NULL; | ||
245 | +} | ||
246 | + | ||
247 | +static const char *pstatus[] = { | ||
248 | + "USB_RET_SUCCESS", "USB_RET_NODEV", "USB_RET_NAK", "USB_RET_STALL", | ||
249 | + "USB_RET_BABBLE", "USB_RET_IOERROR", "USB_RET_ASYNC", | ||
250 | + "USB_RET_ADD_TO_QUEUE", "USB_RET_REMOVE_FROM_QUEUE" | ||
251 | +}; | ||
252 | + | ||
253 | +static uint32_t pintr[] = { | ||
254 | + HCINTMSK_XFERCOMPL, HCINTMSK_XACTERR, HCINTMSK_NAK, HCINTMSK_STALL, | ||
255 | + HCINTMSK_BBLERR, HCINTMSK_XACTERR, HCINTMSK_XACTERR, HCINTMSK_XACTERR, | ||
256 | + HCINTMSK_XACTERR | ||
257 | +}; | ||
258 | + | ||
259 | +static const char *types[] = { | ||
260 | + "Ctrl", "Isoc", "Bulk", "Intr" | ||
261 | +}; | ||
262 | + | ||
263 | +static const char *dirs[] = { | ||
264 | + "Out", "In" | ||
265 | +}; | ||
266 | + | ||
267 | +static void dwc2_handle_packet(DWC2State *s, uint32_t devadr, USBDevice *dev, | ||
268 | + USBEndpoint *ep, uint32_t index, bool send) | ||
269 | +{ | ||
270 | + DWC2Packet *p; | ||
271 | + uint32_t hcchar = s->hreg1[index]; | ||
272 | + uint32_t hctsiz = s->hreg1[index + 4]; | ||
273 | + uint32_t hcdma = s->hreg1[index + 5]; | ||
274 | + uint32_t chan, epnum, epdir, eptype, mps, pid, pcnt, len, tlen, intr = 0; | ||
275 | + uint32_t tpcnt, stsidx, actual = 0; | ||
276 | + bool do_intr = false, done = false; | ||
277 | + | ||
278 | + epnum = get_field(hcchar, HCCHAR_EPNUM); | ||
279 | + epdir = get_bit(hcchar, HCCHAR_EPDIR); | ||
280 | + eptype = get_field(hcchar, HCCHAR_EPTYPE); | ||
281 | + mps = get_field(hcchar, HCCHAR_MPS); | ||
282 | + pid = get_field(hctsiz, TSIZ_SC_MC_PID); | ||
283 | + pcnt = get_field(hctsiz, TSIZ_PKTCNT); | ||
284 | + len = get_field(hctsiz, TSIZ_XFERSIZE); | ||
285 | + assert(len <= DWC2_MAX_XFER_SIZE); | ||
286 | + chan = index >> 3; | ||
287 | + p = &s->packet[chan]; | ||
288 | + | ||
289 | + trace_usb_dwc2_handle_packet(chan, dev, &p->packet, epnum, types[eptype], | ||
290 | + dirs[epdir], mps, len, pcnt); | ||
291 | + | ||
292 | + if (eptype == USB_ENDPOINT_XFER_CONTROL && pid == TSIZ_SC_MC_PID_SETUP) { | ||
293 | + pid = USB_TOKEN_SETUP; | ||
294 | + } else { | ||
295 | + pid = epdir ? USB_TOKEN_IN : USB_TOKEN_OUT; | ||
296 | + } | ||
297 | + | ||
298 | + if (send) { | ||
299 | + tlen = len; | ||
300 | + if (p->small) { | ||
301 | + if (tlen > mps) { | ||
302 | + tlen = mps; | ||
303 | + } | ||
304 | + } | ||
305 | + | ||
306 | + if (pid != USB_TOKEN_IN) { | ||
307 | + trace_usb_dwc2_memory_read(hcdma, tlen); | ||
308 | + if (dma_memory_read(&s->dma_as, hcdma, | ||
309 | + s->usb_buf[chan], tlen) != MEMTX_OK) { | ||
310 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: dma_memory_read failed\n", | ||
311 | + __func__); | ||
312 | + } | ||
313 | + } | ||
314 | + | ||
315 | + usb_packet_init(&p->packet); | ||
316 | + usb_packet_setup(&p->packet, pid, ep, 0, hcdma, | ||
317 | + pid != USB_TOKEN_IN, true); | ||
318 | + usb_packet_addbuf(&p->packet, s->usb_buf[chan], tlen); | ||
319 | + p->async = DWC2_ASYNC_NONE; | ||
320 | + usb_handle_packet(dev, &p->packet); | ||
321 | + } else { | ||
322 | + tlen = p->len; | ||
323 | + } | ||
324 | + | ||
325 | + stsidx = -p->packet.status; | ||
326 | + assert(stsidx < sizeof(pstatus) / sizeof(*pstatus)); | ||
327 | + actual = p->packet.actual_length; | ||
328 | + trace_usb_dwc2_packet_status(pstatus[stsidx], actual); | ||
329 | + | ||
330 | +babble: | ||
331 | + if (p->packet.status != USB_RET_SUCCESS && | ||
332 | + p->packet.status != USB_RET_NAK && | ||
333 | + p->packet.status != USB_RET_STALL && | ||
334 | + p->packet.status != USB_RET_ASYNC) { | ||
335 | + trace_usb_dwc2_packet_error(pstatus[stsidx]); | ||
336 | + } | ||
337 | + | ||
338 | + if (p->packet.status == USB_RET_ASYNC) { | ||
339 | + trace_usb_dwc2_async_packet(&p->packet, chan, dev, epnum, | ||
340 | + dirs[epdir], tlen); | ||
341 | + usb_device_flush_ep_queue(dev, ep); | ||
342 | + assert(p->async != DWC2_ASYNC_INFLIGHT); | ||
343 | + p->devadr = devadr; | ||
344 | + p->epnum = epnum; | ||
345 | + p->epdir = epdir; | ||
346 | + p->mps = mps; | ||
347 | + p->pid = pid; | ||
348 | + p->index = index; | ||
349 | + p->pcnt = pcnt; | ||
350 | + p->len = tlen; | ||
351 | + p->async = DWC2_ASYNC_INFLIGHT; | ||
352 | + p->needs_service = false; | ||
353 | + return; | 694 | + return; |
354 | + } | 695 | + } |
355 | + | 696 | + |
356 | + if (p->packet.status == USB_RET_SUCCESS) { | 697 | + memory_region_add_subregion(&s->iomem, 0, |
357 | + if (actual > tlen) { | 698 | + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->sysbus_xhci), 0)); |
358 | + p->packet.status = USB_RET_BABBLE; | 699 | + sysbus_init_mmio(sbd, &s->iomem); |
359 | + goto babble; | 700 | + |
360 | + } | 701 | + /* |
361 | + | 702 | + * Device Configuration |
362 | + if (pid == USB_TOKEN_IN) { | 703 | + */ |
363 | + trace_usb_dwc2_memory_write(hcdma, actual); | 704 | + s->regs[R_GHWPARAMS0] = 0x40204048 | s->cfg.mode; |
364 | + if (dma_memory_write(&s->dma_as, hcdma, s->usb_buf[chan], | 705 | + s->regs[R_GHWPARAMS1] = 0x222493b; |
365 | + actual) != MEMTX_OK) { | 706 | + s->regs[R_GHWPARAMS2] = 0x12345678; |
366 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: dma_memory_write failed\n", | 707 | + s->regs[R_GHWPARAMS3] = 0x618c088; |
367 | + __func__); | 708 | + s->regs[R_GHWPARAMS4] = 0x47822004; |
368 | + } | 709 | + s->regs[R_GHWPARAMS5] = 0x4202088; |
369 | + } | 710 | + s->regs[R_GHWPARAMS6] = 0x7850c20; |
370 | + | 711 | + s->regs[R_GHWPARAMS7] = 0x0; |
371 | + tpcnt = actual / mps; | 712 | + s->regs[R_GHWPARAMS8] = 0x478; |
372 | + if (actual % mps) { | ||
373 | + tpcnt++; | ||
374 | + if (pid == USB_TOKEN_IN) { | ||
375 | + done = true; | ||
376 | + } | ||
377 | + } | ||
378 | + | ||
379 | + pcnt -= tpcnt < pcnt ? tpcnt : pcnt; | ||
380 | + set_field(&hctsiz, pcnt, TSIZ_PKTCNT); | ||
381 | + len -= actual < len ? actual : len; | ||
382 | + set_field(&hctsiz, len, TSIZ_XFERSIZE); | ||
383 | + s->hreg1[index + 4] = hctsiz; | ||
384 | + hcdma += actual; | ||
385 | + s->hreg1[index + 5] = hcdma; | ||
386 | + | ||
387 | + if (!pcnt || len == 0 || actual == 0) { | ||
388 | + done = true; | ||
389 | + } | ||
390 | + } else { | ||
391 | + intr |= pintr[stsidx]; | ||
392 | + if (p->packet.status == USB_RET_NAK && | ||
393 | + (eptype == USB_ENDPOINT_XFER_CONTROL || | ||
394 | + eptype == USB_ENDPOINT_XFER_BULK)) { | ||
395 | + /* | ||
396 | + * for ctrl/bulk, automatically retry on NAK, | ||
397 | + * but send the interrupt anyway | ||
398 | + */ | ||
399 | + intr &= ~HCINTMSK_RESERVED14_31; | ||
400 | + s->hreg1[index + 2] |= intr; | ||
401 | + do_intr = true; | ||
402 | + } else { | ||
403 | + intr |= HCINTMSK_CHHLTD; | ||
404 | + done = true; | ||
405 | + } | ||
406 | + } | ||
407 | + | ||
408 | + usb_packet_cleanup(&p->packet); | ||
409 | + | ||
410 | + if (done) { | ||
411 | + hcchar &= ~HCCHAR_CHENA; | ||
412 | + s->hreg1[index] = hcchar; | ||
413 | + if (!(intr & HCINTMSK_CHHLTD)) { | ||
414 | + intr |= HCINTMSK_CHHLTD | HCINTMSK_XFERCOMPL; | ||
415 | + } | ||
416 | + intr &= ~HCINTMSK_RESERVED14_31; | ||
417 | + s->hreg1[index + 2] |= intr; | ||
418 | + p->needs_service = false; | ||
419 | + trace_usb_dwc2_packet_done(pstatus[stsidx], actual, len, pcnt); | ||
420 | + dwc2_update_hc_irq(s, index); | ||
421 | + return; | ||
422 | + } | ||
423 | + | ||
424 | + p->devadr = devadr; | ||
425 | + p->epnum = epnum; | ||
426 | + p->epdir = epdir; | ||
427 | + p->mps = mps; | ||
428 | + p->pid = pid; | ||
429 | + p->index = index; | ||
430 | + p->pcnt = pcnt; | ||
431 | + p->len = len; | ||
432 | + p->needs_service = true; | ||
433 | + trace_usb_dwc2_packet_next(pstatus[stsidx], len, pcnt); | ||
434 | + if (do_intr) { | ||
435 | + dwc2_update_hc_irq(s, index); | ||
436 | + } | ||
437 | +} | 713 | +} |
438 | + | 714 | + |
439 | +/* Attach or detach a device on root hub */ | 715 | +static void usb_dwc3_init(Object *obj) |
440 | + | ||
441 | +static const char *speeds[] = { | ||
442 | + "low", "full", "high" | ||
443 | +}; | ||
444 | + | ||
445 | +static void dwc2_attach(USBPort *port) | ||
446 | +{ | 716 | +{ |
447 | + DWC2State *s = port->opaque; | 717 | + USBDWC3 *s = USB_DWC3(obj); |
448 | + int hispd = 0; | 718 | + RegisterInfoArray *reg_array; |
449 | + | 719 | + |
450 | + trace_usb_dwc2_attach(port); | 720 | + memory_region_init(&s->iomem, obj, TYPE_USB_DWC3, DWC3_SIZE); |
451 | + assert(port->index == 0); | 721 | + reg_array = |
452 | + | 722 | + register_init_block32(DEVICE(obj), usb_dwc3_regs_info, |
453 | + if (!port->dev || !port->dev->attached) { | 723 | + ARRAY_SIZE(usb_dwc3_regs_info), |
454 | + return; | 724 | + s->regs_info, s->regs, |
455 | + } | 725 | + &usb_dwc3_ops, |
456 | + | 726 | + USB_DWC3_ERR_DEBUG, |
457 | + assert(port->dev->speed <= USB_SPEED_HIGH); | 727 | + USB_DWC3_R_MAX * 4); |
458 | + trace_usb_dwc2_attach_speed(speeds[port->dev->speed]); | 728 | + memory_region_add_subregion(&s->iomem, |
459 | + s->hprt0 &= ~HPRT0_SPD_MASK; | 729 | + DWC3_GLOBAL_OFFSET, |
460 | + | 730 | + ®_array->mem); |
461 | + switch (port->dev->speed) { | 731 | + object_initialize_child(obj, "dwc3-xhci", &s->sysbus_xhci, |
462 | + case USB_SPEED_LOW: | 732 | + TYPE_XHCI_SYSBUS); |
463 | + s->hprt0 |= HPRT0_SPD_LOW_SPEED << HPRT0_SPD_SHIFT; | 733 | + qdev_alias_all_properties(DEVICE(&s->sysbus_xhci), obj); |
464 | + break; | 734 | + |
465 | + case USB_SPEED_FULL: | 735 | + s->cfg.mode = HOST_MODE; |
466 | + s->hprt0 |= HPRT0_SPD_FULL_SPEED << HPRT0_SPD_SHIFT; | ||
467 | + break; | ||
468 | + case USB_SPEED_HIGH: | ||
469 | + s->hprt0 |= HPRT0_SPD_HIGH_SPEED << HPRT0_SPD_SHIFT; | ||
470 | + hispd = 1; | ||
471 | + break; | ||
472 | + } | ||
473 | + | ||
474 | + if (hispd) { | ||
475 | + s->usb_frame_time = NANOSECONDS_PER_SECOND / 8000; /* 125000 */ | ||
476 | + if (NANOSECONDS_PER_SECOND >= USB_HZ_HS) { | ||
477 | + s->usb_bit_time = NANOSECONDS_PER_SECOND / USB_HZ_HS; /* 10.4 */ | ||
478 | + } else { | ||
479 | + s->usb_bit_time = 1; | ||
480 | + } | ||
481 | + } else { | ||
482 | + s->usb_frame_time = NANOSECONDS_PER_SECOND / 1000; /* 1000000 */ | ||
483 | + if (NANOSECONDS_PER_SECOND >= USB_HZ_FS) { | ||
484 | + s->usb_bit_time = NANOSECONDS_PER_SECOND / USB_HZ_FS; /* 83.3 */ | ||
485 | + } else { | ||
486 | + s->usb_bit_time = 1; | ||
487 | + } | ||
488 | + } | ||
489 | + | ||
490 | + s->fi = USB_FRMINTVL - 1; | ||
491 | + s->hprt0 |= HPRT0_CONNDET | HPRT0_CONNSTS; | ||
492 | + | ||
493 | + dwc2_bus_start(s); | ||
494 | + dwc2_raise_global_irq(s, GINTSTS_PRTINT); | ||
495 | +} | 736 | +} |
496 | + | 737 | + |
497 | +static void dwc2_detach(USBPort *port) | 738 | +static const VMStateDescription vmstate_usb_dwc3 = { |
498 | +{ | 739 | + .name = "usb-dwc3", |
499 | + DWC2State *s = port->opaque; | ||
500 | + | ||
501 | + trace_usb_dwc2_detach(port); | ||
502 | + assert(port->index == 0); | ||
503 | + | ||
504 | + dwc2_bus_stop(s); | ||
505 | + | ||
506 | + s->hprt0 &= ~(HPRT0_SPD_MASK | HPRT0_SUSP | HPRT0_ENA | HPRT0_CONNSTS); | ||
507 | + s->hprt0 |= HPRT0_CONNDET | HPRT0_ENACHG; | ||
508 | + | ||
509 | + dwc2_raise_global_irq(s, GINTSTS_PRTINT); | ||
510 | +} | ||
511 | + | ||
512 | +static void dwc2_child_detach(USBPort *port, USBDevice *child) | ||
513 | +{ | ||
514 | + trace_usb_dwc2_child_detach(port, child); | ||
515 | + assert(port->index == 0); | ||
516 | +} | ||
517 | + | ||
518 | +static void dwc2_wakeup(USBPort *port) | ||
519 | +{ | ||
520 | + DWC2State *s = port->opaque; | ||
521 | + | ||
522 | + trace_usb_dwc2_wakeup(port); | ||
523 | + assert(port->index == 0); | ||
524 | + | ||
525 | + if (s->hprt0 & HPRT0_SUSP) { | ||
526 | + s->hprt0 |= HPRT0_RES; | ||
527 | + dwc2_raise_global_irq(s, GINTSTS_PRTINT); | ||
528 | + } | ||
529 | + | ||
530 | + qemu_bh_schedule(s->async_bh); | ||
531 | +} | ||
532 | + | ||
533 | +static void dwc2_async_packet_complete(USBPort *port, USBPacket *packet) | ||
534 | +{ | ||
535 | + DWC2State *s = port->opaque; | ||
536 | + DWC2Packet *p; | ||
537 | + USBDevice *dev; | ||
538 | + USBEndpoint *ep; | ||
539 | + | ||
540 | + assert(port->index == 0); | ||
541 | + p = container_of(packet, DWC2Packet, packet); | ||
542 | + dev = dwc2_find_device(s, p->devadr); | ||
543 | + ep = usb_ep_get(dev, p->pid, p->epnum); | ||
544 | + trace_usb_dwc2_async_packet_complete(port, packet, p->index >> 3, dev, | ||
545 | + p->epnum, dirs[p->epdir], p->len); | ||
546 | + assert(p->async == DWC2_ASYNC_INFLIGHT); | ||
547 | + | ||
548 | + if (packet->status == USB_RET_REMOVE_FROM_QUEUE) { | ||
549 | + usb_cancel_packet(packet); | ||
550 | + usb_packet_cleanup(packet); | ||
551 | + return; | ||
552 | + } | ||
553 | + | ||
554 | + dwc2_handle_packet(s, p->devadr, dev, ep, p->index, false); | ||
555 | + | ||
556 | + p->async = DWC2_ASYNC_FINISHED; | ||
557 | + qemu_bh_schedule(s->async_bh); | ||
558 | +} | ||
559 | + | ||
560 | +static USBPortOps dwc2_port_ops = { | ||
561 | + .attach = dwc2_attach, | ||
562 | + .detach = dwc2_detach, | ||
563 | + .child_detach = dwc2_child_detach, | ||
564 | + .wakeup = dwc2_wakeup, | ||
565 | + .complete = dwc2_async_packet_complete, | ||
566 | +}; | ||
567 | + | ||
568 | +static uint32_t dwc2_get_frame_remaining(DWC2State *s) | ||
569 | +{ | ||
570 | + uint32_t fr = 0; | ||
571 | + int64_t tks; | ||
572 | + | ||
573 | + tks = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - s->sof_time; | ||
574 | + if (tks < 0) { | ||
575 | + tks = 0; | ||
576 | + } | ||
577 | + | ||
578 | + /* avoid muldiv if possible */ | ||
579 | + if (tks >= s->usb_frame_time) { | ||
580 | + goto out; | ||
581 | + } | ||
582 | + if (tks < s->usb_bit_time) { | ||
583 | + fr = s->fi; | ||
584 | + goto out; | ||
585 | + } | ||
586 | + | ||
587 | + /* tks = number of ns since SOF, divided by 83 (fs) or 10 (hs) */ | ||
588 | + tks = tks / s->usb_bit_time; | ||
589 | + if (tks >= (int64_t)s->fi) { | ||
590 | + goto out; | ||
591 | + } | ||
592 | + | ||
593 | + /* remaining = frame interval minus tks */ | ||
594 | + fr = (uint32_t)((int64_t)s->fi - tks); | ||
595 | + | ||
596 | +out: | ||
597 | + return fr; | ||
598 | +} | ||
599 | + | ||
600 | +static void dwc2_work_bh(void *opaque) | ||
601 | +{ | ||
602 | + DWC2State *s = opaque; | ||
603 | + DWC2Packet *p; | ||
604 | + USBDevice *dev; | ||
605 | + USBEndpoint *ep; | ||
606 | + int64_t t_now, expire_time; | ||
607 | + int chan; | ||
608 | + bool found = false; | ||
609 | + | ||
610 | + trace_usb_dwc2_work_bh(); | ||
611 | + if (s->working) { | ||
612 | + return; | ||
613 | + } | ||
614 | + s->working = true; | ||
615 | + | ||
616 | + t_now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); | ||
617 | + chan = s->next_chan; | ||
618 | + | ||
619 | + do { | ||
620 | + p = &s->packet[chan]; | ||
621 | + if (p->needs_service) { | ||
622 | + dev = dwc2_find_device(s, p->devadr); | ||
623 | + ep = usb_ep_get(dev, p->pid, p->epnum); | ||
624 | + trace_usb_dwc2_work_bh_service(s->next_chan, chan, dev, p->epnum); | ||
625 | + dwc2_handle_packet(s, p->devadr, dev, ep, p->index, true); | ||
626 | + found = true; | ||
627 | + } | ||
628 | + if (++chan == DWC2_NB_CHAN) { | ||
629 | + chan = 0; | ||
630 | + } | ||
631 | + if (found) { | ||
632 | + s->next_chan = chan; | ||
633 | + trace_usb_dwc2_work_bh_next(chan); | ||
634 | + } | ||
635 | + } while (chan != s->next_chan); | ||
636 | + | ||
637 | + if (found) { | ||
638 | + expire_time = t_now + NANOSECONDS_PER_SECOND / 4000; | ||
639 | + timer_mod(s->frame_timer, expire_time); | ||
640 | + } | ||
641 | + s->working = false; | ||
642 | +} | ||
643 | + | ||
644 | +static void dwc2_enable_chan(DWC2State *s, uint32_t index) | ||
645 | +{ | ||
646 | + USBDevice *dev; | ||
647 | + USBEndpoint *ep; | ||
648 | + uint32_t hcchar; | ||
649 | + uint32_t hctsiz; | ||
650 | + uint32_t devadr, epnum, epdir, eptype, pid, len; | ||
651 | + DWC2Packet *p; | ||
652 | + | ||
653 | + assert((index >> 3) < DWC2_NB_CHAN); | ||
654 | + p = &s->packet[index >> 3]; | ||
655 | + hcchar = s->hreg1[index]; | ||
656 | + hctsiz = s->hreg1[index + 4]; | ||
657 | + devadr = get_field(hcchar, HCCHAR_DEVADDR); | ||
658 | + epnum = get_field(hcchar, HCCHAR_EPNUM); | ||
659 | + epdir = get_bit(hcchar, HCCHAR_EPDIR); | ||
660 | + eptype = get_field(hcchar, HCCHAR_EPTYPE); | ||
661 | + pid = get_field(hctsiz, TSIZ_SC_MC_PID); | ||
662 | + len = get_field(hctsiz, TSIZ_XFERSIZE); | ||
663 | + | ||
664 | + dev = dwc2_find_device(s, devadr); | ||
665 | + | ||
666 | + trace_usb_dwc2_enable_chan(index >> 3, dev, &p->packet, epnum); | ||
667 | + if (dev == NULL) { | ||
668 | + return; | ||
669 | + } | ||
670 | + | ||
671 | + if (eptype == USB_ENDPOINT_XFER_CONTROL && pid == TSIZ_SC_MC_PID_SETUP) { | ||
672 | + pid = USB_TOKEN_SETUP; | ||
673 | + } else { | ||
674 | + pid = epdir ? USB_TOKEN_IN : USB_TOKEN_OUT; | ||
675 | + } | ||
676 | + | ||
677 | + ep = usb_ep_get(dev, pid, epnum); | ||
678 | + | ||
679 | + /* | ||
680 | + * Hack: Networking doesn't like us delivering large transfers, it kind | ||
681 | + * of works but the latency is horrible. So if the transfer is <= the mtu | ||
682 | + * size, we take that as a hint that this might be a network transfer, | ||
683 | + * and do the transfer packet-by-packet. | ||
684 | + */ | ||
685 | + if (len > 1536) { | ||
686 | + p->small = false; | ||
687 | + } else { | ||
688 | + p->small = true; | ||
689 | + } | ||
690 | + | ||
691 | + dwc2_handle_packet(s, devadr, dev, ep, index, true); | ||
692 | + qemu_bh_schedule(s->async_bh); | ||
693 | +} | ||
694 | + | ||
695 | +static const char *glbregnm[] = { | ||
696 | + "GOTGCTL ", "GOTGINT ", "GAHBCFG ", "GUSBCFG ", "GRSTCTL ", | ||
697 | + "GINTSTS ", "GINTMSK ", "GRXSTSR ", "GRXSTSP ", "GRXFSIZ ", | ||
698 | + "GNPTXFSIZ", "GNPTXSTS ", "GI2CCTL ", "GPVNDCTL ", "GGPIO ", | ||
699 | + "GUID ", "GSNPSID ", "GHWCFG1 ", "GHWCFG2 ", "GHWCFG3 ", | ||
700 | + "GHWCFG4 ", "GLPMCFG ", "GPWRDN ", "GDFIFOCFG", "GADPCTL ", | ||
701 | + "GREFCLK ", "GINTMSK2 ", "GINTSTS2 " | ||
702 | +}; | ||
703 | + | ||
704 | +static uint64_t dwc2_glbreg_read(void *ptr, hwaddr addr, int index, | ||
705 | + unsigned size) | ||
706 | +{ | ||
707 | + DWC2State *s = ptr; | ||
708 | + uint32_t val; | ||
709 | + | ||
710 | + assert(addr <= GINTSTS2); | ||
711 | + val = s->glbreg[index]; | ||
712 | + | ||
713 | + switch (addr) { | ||
714 | + case GRSTCTL: | ||
715 | + /* clear any self-clearing bits that were set */ | ||
716 | + val &= ~(GRSTCTL_TXFFLSH | GRSTCTL_RXFFLSH | GRSTCTL_IN_TKNQ_FLSH | | ||
717 | + GRSTCTL_FRMCNTRRST | GRSTCTL_HSFTRST | GRSTCTL_CSFTRST); | ||
718 | + s->glbreg[index] = val; | ||
719 | + break; | ||
720 | + default: | ||
721 | + break; | ||
722 | + } | ||
723 | + | ||
724 | + trace_usb_dwc2_glbreg_read(addr, glbregnm[index], val); | ||
725 | + return val; | ||
726 | +} | ||
727 | + | ||
728 | +static void dwc2_glbreg_write(void *ptr, hwaddr addr, int index, uint64_t val, | ||
729 | + unsigned size) | ||
730 | +{ | ||
731 | + DWC2State *s = ptr; | ||
732 | + uint64_t orig = val; | ||
733 | + uint32_t *mmio; | ||
734 | + uint32_t old; | ||
735 | + int iflg = 0; | ||
736 | + | ||
737 | + assert(addr <= GINTSTS2); | ||
738 | + mmio = &s->glbreg[index]; | ||
739 | + old = *mmio; | ||
740 | + | ||
741 | + switch (addr) { | ||
742 | + case GOTGCTL: | ||
743 | + /* don't allow setting of read-only bits */ | ||
744 | + val &= ~(GOTGCTL_MULT_VALID_BC_MASK | GOTGCTL_BSESVLD | | ||
745 | + GOTGCTL_ASESVLD | GOTGCTL_DBNC_SHORT | GOTGCTL_CONID_B | | ||
746 | + GOTGCTL_HSTNEGSCS | GOTGCTL_SESREQSCS); | ||
747 | + /* don't allow clearing of read-only bits */ | ||
748 | + val |= old & (GOTGCTL_MULT_VALID_BC_MASK | GOTGCTL_BSESVLD | | ||
749 | + GOTGCTL_ASESVLD | GOTGCTL_DBNC_SHORT | GOTGCTL_CONID_B | | ||
750 | + GOTGCTL_HSTNEGSCS | GOTGCTL_SESREQSCS); | ||
751 | + break; | ||
752 | + case GAHBCFG: | ||
753 | + if ((val & GAHBCFG_GLBL_INTR_EN) && !(old & GAHBCFG_GLBL_INTR_EN)) { | ||
754 | + iflg = 1; | ||
755 | + } | ||
756 | + break; | ||
757 | + case GRSTCTL: | ||
758 | + val |= GRSTCTL_AHBIDLE; | ||
759 | + val &= ~GRSTCTL_DMAREQ; | ||
760 | + if (!(old & GRSTCTL_TXFFLSH) && (val & GRSTCTL_TXFFLSH)) { | ||
761 | + /* TODO - TX fifo flush */ | ||
762 | + qemu_log_mask(LOG_UNIMP, "Tx FIFO flush not implemented\n"); | ||
763 | + } | ||
764 | + if (!(old & GRSTCTL_RXFFLSH) && (val & GRSTCTL_RXFFLSH)) { | ||
765 | + /* TODO - RX fifo flush */ | ||
766 | + qemu_log_mask(LOG_UNIMP, "Rx FIFO flush not implemented\n"); | ||
767 | + } | ||
768 | + if (!(old & GRSTCTL_IN_TKNQ_FLSH) && (val & GRSTCTL_IN_TKNQ_FLSH)) { | ||
769 | + /* TODO - device IN token queue flush */ | ||
770 | + qemu_log_mask(LOG_UNIMP, "Token queue flush not implemented\n"); | ||
771 | + } | ||
772 | + if (!(old & GRSTCTL_FRMCNTRRST) && (val & GRSTCTL_FRMCNTRRST)) { | ||
773 | + /* TODO - host frame counter reset */ | ||
774 | + qemu_log_mask(LOG_UNIMP, "Frame counter reset not implemented\n"); | ||
775 | + } | ||
776 | + if (!(old & GRSTCTL_HSFTRST) && (val & GRSTCTL_HSFTRST)) { | ||
777 | + /* TODO - host soft reset */ | ||
778 | + qemu_log_mask(LOG_UNIMP, "Host soft reset not implemented\n"); | ||
779 | + } | ||
780 | + if (!(old & GRSTCTL_CSFTRST) && (val & GRSTCTL_CSFTRST)) { | ||
781 | + /* TODO - core soft reset */ | ||
782 | + qemu_log_mask(LOG_UNIMP, "Core soft reset not implemented\n"); | ||
783 | + } | ||
784 | + /* don't allow clearing of self-clearing bits */ | ||
785 | + val |= old & (GRSTCTL_TXFFLSH | GRSTCTL_RXFFLSH | | ||
786 | + GRSTCTL_IN_TKNQ_FLSH | GRSTCTL_FRMCNTRRST | | ||
787 | + GRSTCTL_HSFTRST | GRSTCTL_CSFTRST); | ||
788 | + break; | ||
789 | + case GINTSTS: | ||
790 | + /* clear the write-1-to-clear bits */ | ||
791 | + val |= ~old; | ||
792 | + val = ~val; | ||
793 | + /* don't allow clearing of read-only bits */ | ||
794 | + val |= old & (GINTSTS_PTXFEMP | GINTSTS_HCHINT | GINTSTS_PRTINT | | ||
795 | + GINTSTS_OEPINT | GINTSTS_IEPINT | GINTSTS_GOUTNAKEFF | | ||
796 | + GINTSTS_GINNAKEFF | GINTSTS_NPTXFEMP | GINTSTS_RXFLVL | | ||
797 | + GINTSTS_OTGINT | GINTSTS_CURMODE_HOST); | ||
798 | + iflg = 1; | ||
799 | + break; | ||
800 | + case GINTMSK: | ||
801 | + iflg = 1; | ||
802 | + break; | ||
803 | + default: | ||
804 | + break; | ||
805 | + } | ||
806 | + | ||
807 | + trace_usb_dwc2_glbreg_write(addr, glbregnm[index], orig, old, val); | ||
808 | + *mmio = val; | ||
809 | + | ||
810 | + if (iflg) { | ||
811 | + dwc2_update_irq(s); | ||
812 | + } | ||
813 | +} | ||
814 | + | ||
815 | +static uint64_t dwc2_fszreg_read(void *ptr, hwaddr addr, int index, | ||
816 | + unsigned size) | ||
817 | +{ | ||
818 | + DWC2State *s = ptr; | ||
819 | + uint32_t val; | ||
820 | + | ||
821 | + assert(addr == HPTXFSIZ); | ||
822 | + val = s->fszreg[index]; | ||
823 | + | ||
824 | + trace_usb_dwc2_fszreg_read(addr, val); | ||
825 | + return val; | ||
826 | +} | ||
827 | + | ||
828 | +static void dwc2_fszreg_write(void *ptr, hwaddr addr, int index, uint64_t val, | ||
829 | + unsigned size) | ||
830 | +{ | ||
831 | + DWC2State *s = ptr; | ||
832 | + uint64_t orig = val; | ||
833 | + uint32_t *mmio; | ||
834 | + uint32_t old; | ||
835 | + | ||
836 | + assert(addr == HPTXFSIZ); | ||
837 | + mmio = &s->fszreg[index]; | ||
838 | + old = *mmio; | ||
839 | + | ||
840 | + trace_usb_dwc2_fszreg_write(addr, orig, old, val); | ||
841 | + *mmio = val; | ||
842 | +} | ||
843 | + | ||
844 | +static const char *hreg0nm[] = { | ||
845 | + "HCFG ", "HFIR ", "HFNUM ", "<rsvd> ", "HPTXSTS ", | ||
846 | + "HAINT ", "HAINTMSK ", "HFLBADDR ", "<rsvd> ", "<rsvd> ", | ||
847 | + "<rsvd> ", "<rsvd> ", "<rsvd> ", "<rsvd> ", "<rsvd> ", | ||
848 | + "<rsvd> ", "HPRT0 " | ||
849 | +}; | ||
850 | + | ||
851 | +static uint64_t dwc2_hreg0_read(void *ptr, hwaddr addr, int index, | ||
852 | + unsigned size) | ||
853 | +{ | ||
854 | + DWC2State *s = ptr; | ||
855 | + uint32_t val; | ||
856 | + | ||
857 | + assert(addr >= HCFG && addr <= HPRT0); | ||
858 | + val = s->hreg0[index]; | ||
859 | + | ||
860 | + switch (addr) { | ||
861 | + case HFNUM: | ||
862 | + val = (dwc2_get_frame_remaining(s) << HFNUM_FRREM_SHIFT) | | ||
863 | + (s->hfnum << HFNUM_FRNUM_SHIFT); | ||
864 | + break; | ||
865 | + default: | ||
866 | + break; | ||
867 | + } | ||
868 | + | ||
869 | + trace_usb_dwc2_hreg0_read(addr, hreg0nm[index], val); | ||
870 | + return val; | ||
871 | +} | ||
872 | + | ||
873 | +static void dwc2_hreg0_write(void *ptr, hwaddr addr, int index, uint64_t val, | ||
874 | + unsigned size) | ||
875 | +{ | ||
876 | + DWC2State *s = ptr; | ||
877 | + USBDevice *dev = s->uport.dev; | ||
878 | + uint64_t orig = val; | ||
879 | + uint32_t *mmio; | ||
880 | + uint32_t tval, told, old; | ||
881 | + int prst = 0; | ||
882 | + int iflg = 0; | ||
883 | + | ||
884 | + assert(addr >= HCFG && addr <= HPRT0); | ||
885 | + mmio = &s->hreg0[index]; | ||
886 | + old = *mmio; | ||
887 | + | ||
888 | + switch (addr) { | ||
889 | + case HFIR: | ||
890 | + break; | ||
891 | + case HFNUM: | ||
892 | + case HPTXSTS: | ||
893 | + case HAINT: | ||
894 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: write to read-only register\n", | ||
895 | + __func__); | ||
896 | + return; | ||
897 | + case HAINTMSK: | ||
898 | + val &= 0xffff; | ||
899 | + break; | ||
900 | + case HPRT0: | ||
901 | + /* don't allow clearing of read-only bits */ | ||
902 | + val |= old & (HPRT0_SPD_MASK | HPRT0_LNSTS_MASK | HPRT0_OVRCURRACT | | ||
903 | + HPRT0_CONNSTS); | ||
904 | + /* don't allow clearing of self-clearing bits */ | ||
905 | + val |= old & (HPRT0_SUSP | HPRT0_RES); | ||
906 | + /* don't allow setting of self-setting bits */ | ||
907 | + if (!(old & HPRT0_ENA) && (val & HPRT0_ENA)) { | ||
908 | + val &= ~HPRT0_ENA; | ||
909 | + } | ||
910 | + /* clear the write-1-to-clear bits */ | ||
911 | + tval = val & (HPRT0_OVRCURRCHG | HPRT0_ENACHG | HPRT0_ENA | | ||
912 | + HPRT0_CONNDET); | ||
913 | + told = old & (HPRT0_OVRCURRCHG | HPRT0_ENACHG | HPRT0_ENA | | ||
914 | + HPRT0_CONNDET); | ||
915 | + tval |= ~told; | ||
916 | + tval = ~tval; | ||
917 | + tval &= (HPRT0_OVRCURRCHG | HPRT0_ENACHG | HPRT0_ENA | | ||
918 | + HPRT0_CONNDET); | ||
919 | + val &= ~(HPRT0_OVRCURRCHG | HPRT0_ENACHG | HPRT0_ENA | | ||
920 | + HPRT0_CONNDET); | ||
921 | + val |= tval; | ||
922 | + if (!(val & HPRT0_RST) && (old & HPRT0_RST)) { | ||
923 | + if (dev && dev->attached) { | ||
924 | + val |= HPRT0_ENA | HPRT0_ENACHG; | ||
925 | + prst = 1; | ||
926 | + } | ||
927 | + } | ||
928 | + if (val & (HPRT0_OVRCURRCHG | HPRT0_ENACHG | HPRT0_CONNDET)) { | ||
929 | + iflg = 1; | ||
930 | + } else { | ||
931 | + iflg = -1; | ||
932 | + } | ||
933 | + break; | ||
934 | + default: | ||
935 | + break; | ||
936 | + } | ||
937 | + | ||
938 | + if (prst) { | ||
939 | + trace_usb_dwc2_hreg0_write(addr, hreg0nm[index], orig, old, | ||
940 | + val & ~HPRT0_CONNDET); | ||
941 | + trace_usb_dwc2_hreg0_action("call usb_port_reset"); | ||
942 | + usb_port_reset(&s->uport); | ||
943 | + val &= ~HPRT0_CONNDET; | ||
944 | + } else { | ||
945 | + trace_usb_dwc2_hreg0_write(addr, hreg0nm[index], orig, old, val); | ||
946 | + } | ||
947 | + | ||
948 | + *mmio = val; | ||
949 | + | ||
950 | + if (iflg > 0) { | ||
951 | + trace_usb_dwc2_hreg0_action("enable PRTINT"); | ||
952 | + dwc2_raise_global_irq(s, GINTSTS_PRTINT); | ||
953 | + } else if (iflg < 0) { | ||
954 | + trace_usb_dwc2_hreg0_action("disable PRTINT"); | ||
955 | + dwc2_lower_global_irq(s, GINTSTS_PRTINT); | ||
956 | + } | ||
957 | +} | ||
958 | + | ||
959 | +static const char *hreg1nm[] = { | ||
960 | + "HCCHAR ", "HCSPLT ", "HCINT ", "HCINTMSK", "HCTSIZ ", "HCDMA ", | ||
961 | + "<rsvd> ", "HCDMAB " | ||
962 | +}; | ||
963 | + | ||
964 | +static uint64_t dwc2_hreg1_read(void *ptr, hwaddr addr, int index, | ||
965 | + unsigned size) | ||
966 | +{ | ||
967 | + DWC2State *s = ptr; | ||
968 | + uint32_t val; | ||
969 | + | ||
970 | + assert(addr >= HCCHAR(0) && addr <= HCDMAB(DWC2_NB_CHAN - 1)); | ||
971 | + val = s->hreg1[index]; | ||
972 | + | ||
973 | + trace_usb_dwc2_hreg1_read(addr, hreg1nm[index & 7], addr >> 5, val); | ||
974 | + return val; | ||
975 | +} | ||
976 | + | ||
977 | +static void dwc2_hreg1_write(void *ptr, hwaddr addr, int index, uint64_t val, | ||
978 | + unsigned size) | ||
979 | +{ | ||
980 | + DWC2State *s = ptr; | ||
981 | + uint64_t orig = val; | ||
982 | + uint32_t *mmio; | ||
983 | + uint32_t old; | ||
984 | + int iflg = 0; | ||
985 | + int enflg = 0; | ||
986 | + int disflg = 0; | ||
987 | + | ||
988 | + assert(addr >= HCCHAR(0) && addr <= HCDMAB(DWC2_NB_CHAN - 1)); | ||
989 | + mmio = &s->hreg1[index]; | ||
990 | + old = *mmio; | ||
991 | + | ||
992 | + switch (HSOTG_REG(0x500) + (addr & 0x1c)) { | ||
993 | + case HCCHAR(0): | ||
994 | + if ((val & HCCHAR_CHDIS) && !(old & HCCHAR_CHDIS)) { | ||
995 | + val &= ~(HCCHAR_CHENA | HCCHAR_CHDIS); | ||
996 | + disflg = 1; | ||
997 | + } else { | ||
998 | + val |= old & HCCHAR_CHDIS; | ||
999 | + if ((val & HCCHAR_CHENA) && !(old & HCCHAR_CHENA)) { | ||
1000 | + val &= ~HCCHAR_CHDIS; | ||
1001 | + enflg = 1; | ||
1002 | + } else { | ||
1003 | + val |= old & HCCHAR_CHENA; | ||
1004 | + } | ||
1005 | + } | ||
1006 | + break; | ||
1007 | + case HCINT(0): | ||
1008 | + /* clear the write-1-to-clear bits */ | ||
1009 | + val |= ~old; | ||
1010 | + val = ~val; | ||
1011 | + val &= ~HCINTMSK_RESERVED14_31; | ||
1012 | + iflg = 1; | ||
1013 | + break; | ||
1014 | + case HCINTMSK(0): | ||
1015 | + val &= ~HCINTMSK_RESERVED14_31; | ||
1016 | + iflg = 1; | ||
1017 | + break; | ||
1018 | + case HCDMAB(0): | ||
1019 | + qemu_log_mask(LOG_GUEST_ERROR, "%s: write to read-only register\n", | ||
1020 | + __func__); | ||
1021 | + return; | ||
1022 | + default: | ||
1023 | + break; | ||
1024 | + } | ||
1025 | + | ||
1026 | + trace_usb_dwc2_hreg1_write(addr, hreg1nm[index & 7], index >> 3, orig, | ||
1027 | + old, val); | ||
1028 | + *mmio = val; | ||
1029 | + | ||
1030 | + if (disflg) { | ||
1031 | + /* set ChHltd in HCINT */ | ||
1032 | + s->hreg1[(index & ~7) + 2] |= HCINTMSK_CHHLTD; | ||
1033 | + iflg = 1; | ||
1034 | + } | ||
1035 | + | ||
1036 | + if (enflg) { | ||
1037 | + dwc2_enable_chan(s, index & ~7); | ||
1038 | + } | ||
1039 | + | ||
1040 | + if (iflg) { | ||
1041 | + dwc2_update_hc_irq(s, index & ~7); | ||
1042 | + } | ||
1043 | +} | ||
1044 | + | ||
1045 | +static const char *pcgregnm[] = { | ||
1046 | + "PCGCTL ", "PCGCCTL1 " | ||
1047 | +}; | ||
1048 | + | ||
1049 | +static uint64_t dwc2_pcgreg_read(void *ptr, hwaddr addr, int index, | ||
1050 | + unsigned size) | ||
1051 | +{ | ||
1052 | + DWC2State *s = ptr; | ||
1053 | + uint32_t val; | ||
1054 | + | ||
1055 | + assert(addr >= PCGCTL && addr <= PCGCCTL1); | ||
1056 | + val = s->pcgreg[index]; | ||
1057 | + | ||
1058 | + trace_usb_dwc2_pcgreg_read(addr, pcgregnm[index], val); | ||
1059 | + return val; | ||
1060 | +} | ||
1061 | + | ||
1062 | +static void dwc2_pcgreg_write(void *ptr, hwaddr addr, int index, | ||
1063 | + uint64_t val, unsigned size) | ||
1064 | +{ | ||
1065 | + DWC2State *s = ptr; | ||
1066 | + uint64_t orig = val; | ||
1067 | + uint32_t *mmio; | ||
1068 | + uint32_t old; | ||
1069 | + | ||
1070 | + assert(addr >= PCGCTL && addr <= PCGCCTL1); | ||
1071 | + mmio = &s->pcgreg[index]; | ||
1072 | + old = *mmio; | ||
1073 | + | ||
1074 | + trace_usb_dwc2_pcgreg_write(addr, pcgregnm[index], orig, old, val); | ||
1075 | + *mmio = val; | ||
1076 | +} | ||
1077 | + | ||
1078 | +static uint64_t dwc2_hsotg_read(void *ptr, hwaddr addr, unsigned size) | ||
1079 | +{ | ||
1080 | + uint64_t val; | ||
1081 | + | ||
1082 | + switch (addr) { | ||
1083 | + case HSOTG_REG(0x000) ... HSOTG_REG(0x0fc): | ||
1084 | + val = dwc2_glbreg_read(ptr, addr, (addr - HSOTG_REG(0x000)) >> 2, size); | ||
1085 | + break; | ||
1086 | + case HSOTG_REG(0x100): | ||
1087 | + val = dwc2_fszreg_read(ptr, addr, (addr - HSOTG_REG(0x100)) >> 2, size); | ||
1088 | + break; | ||
1089 | + case HSOTG_REG(0x104) ... HSOTG_REG(0x3fc): | ||
1090 | + /* Gadget-mode registers, just return 0 for now */ | ||
1091 | + val = 0; | ||
1092 | + break; | ||
1093 | + case HSOTG_REG(0x400) ... HSOTG_REG(0x4fc): | ||
1094 | + val = dwc2_hreg0_read(ptr, addr, (addr - HSOTG_REG(0x400)) >> 2, size); | ||
1095 | + break; | ||
1096 | + case HSOTG_REG(0x500) ... HSOTG_REG(0x7fc): | ||
1097 | + val = dwc2_hreg1_read(ptr, addr, (addr - HSOTG_REG(0x500)) >> 2, size); | ||
1098 | + break; | ||
1099 | + case HSOTG_REG(0x800) ... HSOTG_REG(0xdfc): | ||
1100 | + /* Gadget-mode registers, just return 0 for now */ | ||
1101 | + val = 0; | ||
1102 | + break; | ||
1103 | + case HSOTG_REG(0xe00) ... HSOTG_REG(0xffc): | ||
1104 | + val = dwc2_pcgreg_read(ptr, addr, (addr - HSOTG_REG(0xe00)) >> 2, size); | ||
1105 | + break; | ||
1106 | + default: | ||
1107 | + g_assert_not_reached(); | ||
1108 | + } | ||
1109 | + | ||
1110 | + return val; | ||
1111 | +} | ||
1112 | + | ||
1113 | +static void dwc2_hsotg_write(void *ptr, hwaddr addr, uint64_t val, | ||
1114 | + unsigned size) | ||
1115 | +{ | ||
1116 | + switch (addr) { | ||
1117 | + case HSOTG_REG(0x000) ... HSOTG_REG(0x0fc): | ||
1118 | + dwc2_glbreg_write(ptr, addr, (addr - HSOTG_REG(0x000)) >> 2, val, size); | ||
1119 | + break; | ||
1120 | + case HSOTG_REG(0x100): | ||
1121 | + dwc2_fszreg_write(ptr, addr, (addr - HSOTG_REG(0x100)) >> 2, val, size); | ||
1122 | + break; | ||
1123 | + case HSOTG_REG(0x104) ... HSOTG_REG(0x3fc): | ||
1124 | + /* Gadget-mode registers, do nothing for now */ | ||
1125 | + break; | ||
1126 | + case HSOTG_REG(0x400) ... HSOTG_REG(0x4fc): | ||
1127 | + dwc2_hreg0_write(ptr, addr, (addr - HSOTG_REG(0x400)) >> 2, val, size); | ||
1128 | + break; | ||
1129 | + case HSOTG_REG(0x500) ... HSOTG_REG(0x7fc): | ||
1130 | + dwc2_hreg1_write(ptr, addr, (addr - HSOTG_REG(0x500)) >> 2, val, size); | ||
1131 | + break; | ||
1132 | + case HSOTG_REG(0x800) ... HSOTG_REG(0xdfc): | ||
1133 | + /* Gadget-mode registers, do nothing for now */ | ||
1134 | + break; | ||
1135 | + case HSOTG_REG(0xe00) ... HSOTG_REG(0xffc): | ||
1136 | + dwc2_pcgreg_write(ptr, addr, (addr - HSOTG_REG(0xe00)) >> 2, val, size); | ||
1137 | + break; | ||
1138 | + default: | ||
1139 | + g_assert_not_reached(); | ||
1140 | + } | ||
1141 | +} | ||
1142 | + | ||
1143 | +static const MemoryRegionOps dwc2_mmio_hsotg_ops = { | ||
1144 | + .read = dwc2_hsotg_read, | ||
1145 | + .write = dwc2_hsotg_write, | ||
1146 | + .impl.min_access_size = 4, | ||
1147 | + .impl.max_access_size = 4, | ||
1148 | + .endianness = DEVICE_LITTLE_ENDIAN, | ||
1149 | +}; | ||
1150 | + | ||
1151 | +static uint64_t dwc2_hreg2_read(void *ptr, hwaddr addr, unsigned size) | ||
1152 | +{ | ||
1153 | + /* TODO - implement FIFOs to support slave mode */ | ||
1154 | + trace_usb_dwc2_hreg2_read(addr, addr >> 12, 0); | ||
1155 | + qemu_log_mask(LOG_UNIMP, "FIFO read not implemented\n"); | ||
1156 | + return 0; | ||
1157 | +} | ||
1158 | + | ||
1159 | +static void dwc2_hreg2_write(void *ptr, hwaddr addr, uint64_t val, | ||
1160 | + unsigned size) | ||
1161 | +{ | ||
1162 | + uint64_t orig = val; | ||
1163 | + | ||
1164 | + /* TODO - implement FIFOs to support slave mode */ | ||
1165 | + trace_usb_dwc2_hreg2_write(addr, addr >> 12, orig, 0, val); | ||
1166 | + qemu_log_mask(LOG_UNIMP, "FIFO write not implemented\n"); | ||
1167 | +} | ||
1168 | + | ||
1169 | +static const MemoryRegionOps dwc2_mmio_hreg2_ops = { | ||
1170 | + .read = dwc2_hreg2_read, | ||
1171 | + .write = dwc2_hreg2_write, | ||
1172 | + .impl.min_access_size = 4, | ||
1173 | + .impl.max_access_size = 4, | ||
1174 | + .endianness = DEVICE_LITTLE_ENDIAN, | ||
1175 | +}; | ||
1176 | + | ||
1177 | +static void dwc2_wakeup_endpoint(USBBus *bus, USBEndpoint *ep, | ||
1178 | + unsigned int stream) | ||
1179 | +{ | ||
1180 | + DWC2State *s = container_of(bus, DWC2State, bus); | ||
1181 | + | ||
1182 | + trace_usb_dwc2_wakeup_endpoint(ep, stream); | ||
1183 | + | ||
1184 | + /* TODO - do something here? */ | ||
1185 | + qemu_bh_schedule(s->async_bh); | ||
1186 | +} | ||
1187 | + | ||
1188 | +static USBBusOps dwc2_bus_ops = { | ||
1189 | + .wakeup_endpoint = dwc2_wakeup_endpoint, | ||
1190 | +}; | ||
1191 | + | ||
1192 | +static void dwc2_work_timer(void *opaque) | ||
1193 | +{ | ||
1194 | + DWC2State *s = opaque; | ||
1195 | + | ||
1196 | + trace_usb_dwc2_work_timer(); | ||
1197 | + qemu_bh_schedule(s->async_bh); | ||
1198 | +} | ||
1199 | + | ||
1200 | +static void dwc2_reset_enter(Object *obj, ResetType type) | ||
1201 | +{ | ||
1202 | + DWC2Class *c = DWC2_GET_CLASS(obj); | ||
1203 | + DWC2State *s = DWC2_USB(obj); | ||
1204 | + int i; | ||
1205 | + | ||
1206 | + trace_usb_dwc2_reset_enter(); | ||
1207 | + | ||
1208 | + if (c->parent_phases.enter) { | ||
1209 | + c->parent_phases.enter(obj, type); | ||
1210 | + } | ||
1211 | + | ||
1212 | + timer_del(s->frame_timer); | ||
1213 | + qemu_bh_cancel(s->async_bh); | ||
1214 | + | ||
1215 | + if (s->uport.dev && s->uport.dev->attached) { | ||
1216 | + usb_detach(&s->uport); | ||
1217 | + } | ||
1218 | + | ||
1219 | + dwc2_bus_stop(s); | ||
1220 | + | ||
1221 | + s->gotgctl = GOTGCTL_BSESVLD | GOTGCTL_ASESVLD | GOTGCTL_CONID_B; | ||
1222 | + s->gotgint = 0; | ||
1223 | + s->gahbcfg = 0; | ||
1224 | + s->gusbcfg = 5 << GUSBCFG_USBTRDTIM_SHIFT; | ||
1225 | + s->grstctl = GRSTCTL_AHBIDLE; | ||
1226 | + s->gintsts = GINTSTS_CONIDSTSCHNG | GINTSTS_PTXFEMP | GINTSTS_NPTXFEMP | | ||
1227 | + GINTSTS_CURMODE_HOST; | ||
1228 | + s->gintmsk = 0; | ||
1229 | + s->grxstsr = 0; | ||
1230 | + s->grxstsp = 0; | ||
1231 | + s->grxfsiz = 1024; | ||
1232 | + s->gnptxfsiz = 1024 << FIFOSIZE_DEPTH_SHIFT; | ||
1233 | + s->gnptxsts = (4 << FIFOSIZE_DEPTH_SHIFT) | 1024; | ||
1234 | + s->gi2cctl = GI2CCTL_I2CDATSE0 | GI2CCTL_ACK; | ||
1235 | + s->gpvndctl = 0; | ||
1236 | + s->ggpio = 0; | ||
1237 | + s->guid = 0; | ||
1238 | + s->gsnpsid = 0x4f54294a; | ||
1239 | + s->ghwcfg1 = 0; | ||
1240 | + s->ghwcfg2 = (8 << GHWCFG2_DEV_TOKEN_Q_DEPTH_SHIFT) | | ||
1241 | + (4 << GHWCFG2_HOST_PERIO_TX_Q_DEPTH_SHIFT) | | ||
1242 | + (4 << GHWCFG2_NONPERIO_TX_Q_DEPTH_SHIFT) | | ||
1243 | + GHWCFG2_DYNAMIC_FIFO | | ||
1244 | + GHWCFG2_PERIO_EP_SUPPORTED | | ||
1245 | + ((DWC2_NB_CHAN - 1) << GHWCFG2_NUM_HOST_CHAN_SHIFT) | | ||
1246 | + (GHWCFG2_INT_DMA_ARCH << GHWCFG2_ARCHITECTURE_SHIFT) | | ||
1247 | + (GHWCFG2_OP_MODE_NO_SRP_CAPABLE_HOST << GHWCFG2_OP_MODE_SHIFT); | ||
1248 | + s->ghwcfg3 = (4096 << GHWCFG3_DFIFO_DEPTH_SHIFT) | | ||
1249 | + (4 << GHWCFG3_PACKET_SIZE_CNTR_WIDTH_SHIFT) | | ||
1250 | + (4 << GHWCFG3_XFER_SIZE_CNTR_WIDTH_SHIFT); | ||
1251 | + s->ghwcfg4 = 0; | ||
1252 | + s->glpmcfg = 0; | ||
1253 | + s->gpwrdn = GPWRDN_PWRDNRSTN; | ||
1254 | + s->gdfifocfg = 0; | ||
1255 | + s->gadpctl = 0; | ||
1256 | + s->grefclk = 0; | ||
1257 | + s->gintmsk2 = 0; | ||
1258 | + s->gintsts2 = 0; | ||
1259 | + | ||
1260 | + s->hptxfsiz = 500 << FIFOSIZE_DEPTH_SHIFT; | ||
1261 | + | ||
1262 | + s->hcfg = 2 << HCFG_RESVALID_SHIFT; | ||
1263 | + s->hfir = 60000; | ||
1264 | + s->hfnum = 0x3fff; | ||
1265 | + s->hptxsts = (16 << TXSTS_QSPCAVAIL_SHIFT) | 32768; | ||
1266 | + s->haint = 0; | ||
1267 | + s->haintmsk = 0; | ||
1268 | + s->hprt0 = 0; | ||
1269 | + | ||
1270 | + memset(s->hreg1, 0, sizeof(s->hreg1)); | ||
1271 | + memset(s->pcgreg, 0, sizeof(s->pcgreg)); | ||
1272 | + | ||
1273 | + s->sof_time = 0; | ||
1274 | + s->frame_number = 0; | ||
1275 | + s->fi = USB_FRMINTVL - 1; | ||
1276 | + s->next_chan = 0; | ||
1277 | + s->working = false; | ||
1278 | + | ||
1279 | + for (i = 0; i < DWC2_NB_CHAN; i++) { | ||
1280 | + s->packet[i].needs_service = false; | ||
1281 | + } | ||
1282 | +} | ||
1283 | + | ||
1284 | +static void dwc2_reset_hold(Object *obj) | ||
1285 | +{ | ||
1286 | + DWC2Class *c = DWC2_GET_CLASS(obj); | ||
1287 | + DWC2State *s = DWC2_USB(obj); | ||
1288 | + | ||
1289 | + trace_usb_dwc2_reset_hold(); | ||
1290 | + | ||
1291 | + if (c->parent_phases.hold) { | ||
1292 | + c->parent_phases.hold(obj); | ||
1293 | + } | ||
1294 | + | ||
1295 | + dwc2_update_irq(s); | ||
1296 | +} | ||
1297 | + | ||
1298 | +static void dwc2_reset_exit(Object *obj) | ||
1299 | +{ | ||
1300 | + DWC2Class *c = DWC2_GET_CLASS(obj); | ||
1301 | + DWC2State *s = DWC2_USB(obj); | ||
1302 | + | ||
1303 | + trace_usb_dwc2_reset_exit(); | ||
1304 | + | ||
1305 | + if (c->parent_phases.exit) { | ||
1306 | + c->parent_phases.exit(obj); | ||
1307 | + } | ||
1308 | + | ||
1309 | + s->hprt0 = HPRT0_PWR; | ||
1310 | + if (s->uport.dev && s->uport.dev->attached) { | ||
1311 | + usb_attach(&s->uport); | ||
1312 | + usb_device_reset(s->uport.dev); | ||
1313 | + } | ||
1314 | +} | ||
1315 | + | ||
1316 | +static void dwc2_realize(DeviceState *dev, Error **errp) | ||
1317 | +{ | ||
1318 | + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); | ||
1319 | + DWC2State *s = DWC2_USB(dev); | ||
1320 | + Object *obj; | ||
1321 | + Error *err = NULL; | ||
1322 | + | ||
1323 | + obj = object_property_get_link(OBJECT(dev), "dma-mr", &err); | ||
1324 | + if (err) { | ||
1325 | + error_setg(errp, "dwc2: required dma-mr link not found: %s", | ||
1326 | + error_get_pretty(err)); | ||
1327 | + return; | ||
1328 | + } | ||
1329 | + assert(obj != NULL); | ||
1330 | + | ||
1331 | + s->dma_mr = MEMORY_REGION(obj); | ||
1332 | + address_space_init(&s->dma_as, s->dma_mr, "dwc2"); | ||
1333 | + | ||
1334 | + usb_bus_new(&s->bus, sizeof(s->bus), &dwc2_bus_ops, dev); | ||
1335 | + usb_register_port(&s->bus, &s->uport, s, 0, &dwc2_port_ops, | ||
1336 | + USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL | | ||
1337 | + (s->usb_version == 2 ? USB_SPEED_MASK_HIGH : 0)); | ||
1338 | + s->uport.dev = 0; | ||
1339 | + | ||
1340 | + s->usb_frame_time = NANOSECONDS_PER_SECOND / 1000; /* 1000000 */ | ||
1341 | + if (NANOSECONDS_PER_SECOND >= USB_HZ_FS) { | ||
1342 | + s->usb_bit_time = NANOSECONDS_PER_SECOND / USB_HZ_FS; /* 83.3 */ | ||
1343 | + } else { | ||
1344 | + s->usb_bit_time = 1; | ||
1345 | + } | ||
1346 | + | ||
1347 | + s->fi = USB_FRMINTVL - 1; | ||
1348 | + s->eof_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, dwc2_frame_boundary, s); | ||
1349 | + s->frame_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, dwc2_work_timer, s); | ||
1350 | + s->async_bh = qemu_bh_new(dwc2_work_bh, s); | ||
1351 | + | ||
1352 | + sysbus_init_irq(sbd, &s->irq); | ||
1353 | +} | ||
1354 | + | ||
1355 | +static void dwc2_init(Object *obj) | ||
1356 | +{ | ||
1357 | + SysBusDevice *sbd = SYS_BUS_DEVICE(obj); | ||
1358 | + DWC2State *s = DWC2_USB(obj); | ||
1359 | + | ||
1360 | + memory_region_init(&s->container, obj, "dwc2", DWC2_MMIO_SIZE); | ||
1361 | + sysbus_init_mmio(sbd, &s->container); | ||
1362 | + | ||
1363 | + memory_region_init_io(&s->hsotg, obj, &dwc2_mmio_hsotg_ops, s, | ||
1364 | + "dwc2-io", 4 * KiB); | ||
1365 | + memory_region_add_subregion(&s->container, 0x0000, &s->hsotg); | ||
1366 | + | ||
1367 | + memory_region_init_io(&s->fifos, obj, &dwc2_mmio_hreg2_ops, s, | ||
1368 | + "dwc2-fifo", 64 * KiB); | ||
1369 | + memory_region_add_subregion(&s->container, 0x1000, &s->fifos); | ||
1370 | +} | ||
1371 | + | ||
1372 | +static const VMStateDescription vmstate_dwc2_state_packet = { | ||
1373 | + .name = "dwc2/packet", | ||
1374 | + .version_id = 1, | 740 | + .version_id = 1, |
1375 | + .minimum_version_id = 1, | ||
1376 | + .fields = (VMStateField[]) { | 741 | + .fields = (VMStateField[]) { |
1377 | + VMSTATE_UINT32(devadr, DWC2Packet), | 742 | + VMSTATE_UINT32_ARRAY(regs, USBDWC3, USB_DWC3_R_MAX), |
1378 | + VMSTATE_UINT32(epnum, DWC2Packet), | 743 | + VMSTATE_UINT8(cfg.mode, USBDWC3), |
1379 | + VMSTATE_UINT32(epdir, DWC2Packet), | 744 | + VMSTATE_UINT32(cfg.dwc_usb3_user, USBDWC3), |
1380 | + VMSTATE_UINT32(mps, DWC2Packet), | ||
1381 | + VMSTATE_UINT32(pid, DWC2Packet), | ||
1382 | + VMSTATE_UINT32(index, DWC2Packet), | ||
1383 | + VMSTATE_UINT32(pcnt, DWC2Packet), | ||
1384 | + VMSTATE_UINT32(len, DWC2Packet), | ||
1385 | + VMSTATE_INT32(async, DWC2Packet), | ||
1386 | + VMSTATE_BOOL(small, DWC2Packet), | ||
1387 | + VMSTATE_BOOL(needs_service, DWC2Packet), | ||
1388 | + VMSTATE_END_OF_LIST() | ||
1389 | + }, | ||
1390 | +}; | ||
1391 | + | ||
1392 | +const VMStateDescription vmstate_dwc2_state = { | ||
1393 | + .name = "dwc2", | ||
1394 | + .version_id = 1, | ||
1395 | + .minimum_version_id = 1, | ||
1396 | + .fields = (VMStateField[]) { | ||
1397 | + VMSTATE_UINT32_ARRAY(glbreg, DWC2State, | ||
1398 | + DWC2_GLBREG_SIZE / sizeof(uint32_t)), | ||
1399 | + VMSTATE_UINT32_ARRAY(fszreg, DWC2State, | ||
1400 | + DWC2_FSZREG_SIZE / sizeof(uint32_t)), | ||
1401 | + VMSTATE_UINT32_ARRAY(hreg0, DWC2State, | ||
1402 | + DWC2_HREG0_SIZE / sizeof(uint32_t)), | ||
1403 | + VMSTATE_UINT32_ARRAY(hreg1, DWC2State, | ||
1404 | + DWC2_HREG1_SIZE / sizeof(uint32_t)), | ||
1405 | + VMSTATE_UINT32_ARRAY(pcgreg, DWC2State, | ||
1406 | + DWC2_PCGREG_SIZE / sizeof(uint32_t)), | ||
1407 | + | ||
1408 | + VMSTATE_TIMER_PTR(eof_timer, DWC2State), | ||
1409 | + VMSTATE_TIMER_PTR(frame_timer, DWC2State), | ||
1410 | + VMSTATE_INT64(sof_time, DWC2State), | ||
1411 | + VMSTATE_INT64(usb_frame_time, DWC2State), | ||
1412 | + VMSTATE_INT64(usb_bit_time, DWC2State), | ||
1413 | + VMSTATE_UINT32(usb_version, DWC2State), | ||
1414 | + VMSTATE_UINT16(frame_number, DWC2State), | ||
1415 | + VMSTATE_UINT16(fi, DWC2State), | ||
1416 | + VMSTATE_UINT16(next_chan, DWC2State), | ||
1417 | + VMSTATE_BOOL(working, DWC2State), | ||
1418 | + | ||
1419 | + VMSTATE_STRUCT_ARRAY(packet, DWC2State, DWC2_NB_CHAN, 1, | ||
1420 | + vmstate_dwc2_state_packet, DWC2Packet), | ||
1421 | + VMSTATE_UINT8_2DARRAY(usb_buf, DWC2State, DWC2_NB_CHAN, | ||
1422 | + DWC2_MAX_XFER_SIZE), | ||
1423 | + | ||
1424 | + VMSTATE_END_OF_LIST() | 745 | + VMSTATE_END_OF_LIST() |
1425 | + } | 746 | + } |
1426 | +}; | 747 | +}; |
1427 | + | 748 | + |
1428 | +static Property dwc2_usb_properties[] = { | 749 | +static Property usb_dwc3_properties[] = { |
1429 | + DEFINE_PROP_UINT32("usb_version", DWC2State, usb_version, 2), | 750 | + DEFINE_PROP_UINT32("DWC_USB3_USERID", USBDWC3, cfg.dwc_usb3_user, |
751 | + 0x12345678), | ||
1430 | + DEFINE_PROP_END_OF_LIST(), | 752 | + DEFINE_PROP_END_OF_LIST(), |
1431 | +}; | 753 | +}; |
1432 | + | 754 | + |
1433 | +static void dwc2_class_init(ObjectClass *klass, void *data) | 755 | +static void usb_dwc3_class_init(ObjectClass *klass, void *data) |
1434 | +{ | 756 | +{ |
1435 | + DeviceClass *dc = DEVICE_CLASS(klass); | 757 | + DeviceClass *dc = DEVICE_CLASS(klass); |
1436 | + DWC2Class *c = DWC2_CLASS(klass); | 758 | + |
1437 | + ResettableClass *rc = RESETTABLE_CLASS(klass); | 759 | + dc->reset = usb_dwc3_reset; |
1438 | + | 760 | + dc->realize = usb_dwc3_realize; |
1439 | + dc->realize = dwc2_realize; | 761 | + dc->vmsd = &vmstate_usb_dwc3; |
1440 | + dc->vmsd = &vmstate_dwc2_state; | 762 | + device_class_set_props(dc, usb_dwc3_properties); |
1441 | + set_bit(DEVICE_CATEGORY_USB, dc->categories); | ||
1442 | + device_class_set_props(dc, dwc2_usb_properties); | ||
1443 | + resettable_class_set_parent_phases(rc, dwc2_reset_enter, dwc2_reset_hold, | ||
1444 | + dwc2_reset_exit, &c->parent_phases); | ||
1445 | +} | 763 | +} |
1446 | + | 764 | + |
1447 | +static const TypeInfo dwc2_usb_type_info = { | 765 | +static const TypeInfo usb_dwc3_info = { |
1448 | + .name = TYPE_DWC2_USB, | 766 | + .name = TYPE_USB_DWC3, |
1449 | + .parent = TYPE_SYS_BUS_DEVICE, | 767 | + .parent = TYPE_SYS_BUS_DEVICE, |
1450 | + .instance_size = sizeof(DWC2State), | 768 | + .instance_size = sizeof(USBDWC3), |
1451 | + .instance_init = dwc2_init, | 769 | + .class_init = usb_dwc3_class_init, |
1452 | + .class_size = sizeof(DWC2Class), | 770 | + .instance_init = usb_dwc3_init, |
1453 | + .class_init = dwc2_class_init, | ||
1454 | +}; | 771 | +}; |
1455 | + | 772 | + |
1456 | +static void dwc2_usb_register_types(void) | 773 | +static void usb_dwc3_register_types(void) |
1457 | +{ | 774 | +{ |
1458 | + type_register_static(&dwc2_usb_type_info); | 775 | + type_register_static(&usb_dwc3_info); |
1459 | +} | 776 | +} |
1460 | + | 777 | + |
1461 | +type_init(dwc2_usb_register_types) | 778 | +type_init(usb_dwc3_register_types) |
1462 | diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig | 779 | diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig |
1463 | index XXXXXXX..XXXXXXX 100644 | 780 | index XXXXXXX..XXXXXXX 100644 |
1464 | --- a/hw/usb/Kconfig | 781 | --- a/hw/usb/Kconfig |
1465 | +++ b/hw/usb/Kconfig | 782 | +++ b/hw/usb/Kconfig |
1466 | @@ -XXX,XX +XXX,XX @@ config USB_MUSB | 783 | @@ -XXX,XX +XXX,XX @@ config IMX_USBPHY |
1467 | bool | 784 | bool |
1468 | select USB | 785 | default y |
1469 | 786 | depends on USB | |
1470 | +config USB_DWC2 | 787 | + |
788 | +config USB_DWC3 | ||
1471 | + bool | 789 | + bool |
1472 | + default y | 790 | + select USB_XHCI_SYSBUS |
1473 | + select USB | 791 | + select REGISTER |
1474 | + | 792 | diff --git a/hw/usb/meson.build b/hw/usb/meson.build |
1475 | config TUSB6010 | ||
1476 | bool | ||
1477 | select USB_MUSB | ||
1478 | diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs | ||
1479 | index XXXXXXX..XXXXXXX 100644 | 793 | index XXXXXXX..XXXXXXX 100644 |
1480 | --- a/hw/usb/Makefile.objs | 794 | --- a/hw/usb/meson.build |
1481 | +++ b/hw/usb/Makefile.objs | 795 | +++ b/hw/usb/meson.build |
1482 | @@ -XXX,XX +XXX,XX @@ common-obj-$(CONFIG_USB_EHCI_SYSBUS) += hcd-ehci-sysbus.o | 796 | @@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_USB_XHCI_SYSBUS', if_true: files('hcd-xhci-sysbus.c |
1483 | common-obj-$(CONFIG_USB_XHCI) += hcd-xhci.o | 797 | softmmu_ss.add(when: 'CONFIG_USB_XHCI_NEC', if_true: files('hcd-xhci-nec.c')) |
1484 | common-obj-$(CONFIG_USB_XHCI_NEC) += hcd-xhci-nec.o | 798 | softmmu_ss.add(when: 'CONFIG_USB_MUSB', if_true: files('hcd-musb.c')) |
1485 | common-obj-$(CONFIG_USB_MUSB) += hcd-musb.o | 799 | softmmu_ss.add(when: 'CONFIG_USB_DWC2', if_true: files('hcd-dwc2.c')) |
1486 | +common-obj-$(CONFIG_USB_DWC2) += hcd-dwc2.o | 800 | +softmmu_ss.add(when: 'CONFIG_USB_DWC3', if_true: files('hcd-dwc3.c')) |
1487 | 801 | ||
1488 | common-obj-$(CONFIG_TUSB6010) += tusb6010.o | 802 | softmmu_ss.add(when: 'CONFIG_TUSB6010', if_true: files('tusb6010.c')) |
1489 | common-obj-$(CONFIG_IMX) += chipidea.o | 803 | softmmu_ss.add(when: 'CONFIG_IMX', if_true: files('chipidea.c')) |
1490 | diff --git a/hw/usb/trace-events b/hw/usb/trace-events | ||
1491 | index XXXXXXX..XXXXXXX 100644 | ||
1492 | --- a/hw/usb/trace-events | ||
1493 | +++ b/hw/usb/trace-events | ||
1494 | @@ -XXX,XX +XXX,XX @@ usb_xhci_xfer_error(void *xfer, uint32_t ret) "%p: ret %d" | ||
1495 | usb_xhci_unimplemented(const char *item, int nr) "%s (0x%x)" | ||
1496 | usb_xhci_enforced_limit(const char *item) "%s" | ||
1497 | |||
1498 | +# hcd-dwc2.c | ||
1499 | +usb_dwc2_update_irq(uint32_t level) "level=%d" | ||
1500 | +usb_dwc2_raise_global_irq(uint32_t intr) "0x%08x" | ||
1501 | +usb_dwc2_lower_global_irq(uint32_t intr) "0x%08x" | ||
1502 | +usb_dwc2_raise_host_irq(uint32_t intr) "0x%04x" | ||
1503 | +usb_dwc2_lower_host_irq(uint32_t intr) "0x%04x" | ||
1504 | +usb_dwc2_sof(int64_t next) "next SOF %" PRId64 | ||
1505 | +usb_dwc2_bus_start(void) "start SOFs" | ||
1506 | +usb_dwc2_bus_stop(void) "stop SOFs" | ||
1507 | +usb_dwc2_find_device(uint8_t addr) "%d" | ||
1508 | +usb_dwc2_port_disabled(uint32_t pnum) "port %d disabled" | ||
1509 | +usb_dwc2_device_found(uint32_t pnum) "device found on port %d" | ||
1510 | +usb_dwc2_device_not_found(void) "device not found" | ||
1511 | +usb_dwc2_handle_packet(uint32_t chan, void *dev, void *pkt, uint32_t ep, const char *type, const char *dir, uint32_t mps, uint32_t len, uint32_t pcnt) "ch %d dev %p pkt %p ep %d type %s dir %s mps %d len %d pcnt %d" | ||
1512 | +usb_dwc2_memory_read(uint32_t addr, uint32_t len) "addr %d len %d" | ||
1513 | +usb_dwc2_packet_status(const char *status, uint32_t len) "status %s len %d" | ||
1514 | +usb_dwc2_packet_error(const char *status) "ERROR %s" | ||
1515 | +usb_dwc2_async_packet(void *pkt, uint32_t chan, void *dev, uint32_t ep, const char *dir, uint32_t len) "pkt %p ch %d dev %p ep %d %s len %d" | ||
1516 | +usb_dwc2_memory_write(uint32_t addr, uint32_t len) "addr %d len %d" | ||
1517 | +usb_dwc2_packet_done(const char *status, uint32_t actual, uint32_t len, uint32_t pcnt) "status %s actual %d len %d pcnt %d" | ||
1518 | +usb_dwc2_packet_next(const char *status, uint32_t len, uint32_t pcnt) "status %s len %d pcnt %d" | ||
1519 | +usb_dwc2_attach(void *port) "port %p" | ||
1520 | +usb_dwc2_attach_speed(const char *speed) "%s-speed device attached" | ||
1521 | +usb_dwc2_detach(void *port) "port %p" | ||
1522 | +usb_dwc2_child_detach(void *port, void *child) "port %p child %p" | ||
1523 | +usb_dwc2_wakeup(void *port) "port %p" | ||
1524 | +usb_dwc2_async_packet_complete(void *port, void *pkt, uint32_t chan, void *dev, uint32_t ep, const char *dir, uint32_t len) "port %p packet %p ch %d dev %p ep %d %s len %d" | ||
1525 | +usb_dwc2_work_bh(void) "" | ||
1526 | +usb_dwc2_work_bh_service(uint32_t first, uint32_t current, void *dev, uint32_t ep) "first %d servicing %d dev %p ep %d" | ||
1527 | +usb_dwc2_work_bh_next(uint32_t chan) "next %d" | ||
1528 | +usb_dwc2_enable_chan(uint32_t chan, void *dev, void *pkt, uint32_t ep) "ch %d dev %p pkt %p ep %d" | ||
1529 | +usb_dwc2_glbreg_read(uint64_t addr, const char *reg, uint32_t val) " 0x%04" PRIx64 " %s val 0x%08x" | ||
1530 | +usb_dwc2_glbreg_write(uint64_t addr, const char *reg, uint64_t val, uint32_t old, uint64_t result) "0x%04" PRIx64 " %s val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1531 | +usb_dwc2_fszreg_read(uint64_t addr, uint32_t val) " 0x%04" PRIx64 " HPTXFSIZ val 0x%08x" | ||
1532 | +usb_dwc2_fszreg_write(uint64_t addr, uint64_t val, uint32_t old, uint64_t result) "0x%04" PRIx64 " HPTXFSIZ val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1533 | +usb_dwc2_hreg0_read(uint64_t addr, const char *reg, uint32_t val) " 0x%04" PRIx64 " %s val 0x%08x" | ||
1534 | +usb_dwc2_hreg0_write(uint64_t addr, const char *reg, uint64_t val, uint32_t old, uint64_t result) " 0x%04" PRIx64 " %s val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1535 | +usb_dwc2_hreg1_read(uint64_t addr, const char *reg, uint64_t chan, uint32_t val) " 0x%04" PRIx64 " %s%" PRId64 " val 0x%08x" | ||
1536 | +usb_dwc2_hreg1_write(uint64_t addr, const char *reg, uint64_t chan, uint64_t val, uint32_t old, uint64_t result) " 0x%04" PRIx64 " %s%" PRId64 " val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1537 | +usb_dwc2_pcgreg_read(uint64_t addr, const char *reg, uint32_t val) " 0x%04" PRIx64 " %s val 0x%08x" | ||
1538 | +usb_dwc2_pcgreg_write(uint64_t addr, const char *reg, uint64_t val, uint32_t old, uint64_t result) "0x%04" PRIx64 " %s val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1539 | +usb_dwc2_hreg2_read(uint64_t addr, uint64_t fifo, uint32_t val) " 0x%04" PRIx64 " FIFO%" PRId64 " val 0x%08x" | ||
1540 | +usb_dwc2_hreg2_write(uint64_t addr, uint64_t fifo, uint64_t val, uint32_t old, uint64_t result) " 0x%04" PRIx64 " FIFO%" PRId64 " val 0x%08" PRIx64 " old 0x%08x result 0x%08" PRIx64 | ||
1541 | +usb_dwc2_hreg0_action(const char *s) "%s" | ||
1542 | +usb_dwc2_wakeup_endpoint(void *ep, uint32_t stream) "endp %p stream %d" | ||
1543 | +usb_dwc2_work_timer(void) "" | ||
1544 | +usb_dwc2_reset_enter(void) "=== RESET enter ===" | ||
1545 | +usb_dwc2_reset_hold(void) "=== RESET hold ===" | ||
1546 | +usb_dwc2_reset_exit(void) "=== RESET exit ===" | ||
1547 | + | ||
1548 | # desc.c | ||
1549 | usb_desc_device(int addr, int len, int ret) "dev %d query device, len %d, ret %d" | ||
1550 | usb_desc_device_qualifier(int addr, int len, int ret) "dev %d query device qualifier, len %d, ret %d" | ||
1551 | -- | 804 | -- |
1552 | 2.20.1 | 805 | 2.20.1 |
1553 | 806 | ||
1554 | 807 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | With this conversion, we will be able to use the same helpers | 3 | This model is a top level integration wrapper for hcd-dwc3 and |
4 | with sve. In particular, pass 3 vector parameters for the | 4 | versal-usb2-ctrl-regs modules, this is used by xilinx versal soc's and |
5 | 3-operand operations; for advsimd the destination register | 5 | future xilinx usb subsystems would also be part of it. |
6 | is also an input. | 6 | |
7 | 7 | Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> | |
8 | This also fixes a bug in which we failed to clear the high bits | 8 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> |
9 | of the SVE register after an AdvSIMD operation. | ||
10 | |||
11 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
12 | Message-id: 20200514212831.31248-2-richard.henderson@linaro.org | ||
13 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> |
10 | Message-id: 1607023357-5096-4-git-send-email-sai.pavan.boddu@xilinx.com | ||
14 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
15 | --- | 12 | --- |
16 | target/arm/helper.h | 6 ++-- | 13 | include/hw/usb/xlnx-usb-subsystem.h | 45 ++++++++++++++ |
17 | target/arm/vec_internal.h | 33 +++++++++++++++++ | 14 | hw/usb/xlnx-usb-subsystem.c | 94 +++++++++++++++++++++++++++++ |
18 | target/arm/crypto_helper.c | 72 +++++++++++++++++++++++++++----------- | 15 | hw/usb/Kconfig | 5 ++ |
19 | target/arm/translate-a64.c | 55 ++++++++++++++++++----------- | 16 | hw/usb/meson.build | 1 + |
20 | target/arm/translate.c | 27 +++++++------- | 17 | 4 files changed, 145 insertions(+) |
21 | target/arm/vec_helper.c | 12 +------ | 18 | create mode 100644 include/hw/usb/xlnx-usb-subsystem.h |
22 | 6 files changed, 138 insertions(+), 67 deletions(-) | 19 | create mode 100644 hw/usb/xlnx-usb-subsystem.c |
23 | create mode 100644 target/arm/vec_internal.h | 20 | |
24 | 21 | diff --git a/include/hw/usb/xlnx-usb-subsystem.h b/include/hw/usb/xlnx-usb-subsystem.h | |
25 | diff --git a/target/arm/helper.h b/target/arm/helper.h | ||
26 | index XXXXXXX..XXXXXXX 100644 | ||
27 | --- a/target/arm/helper.h | ||
28 | +++ b/target/arm/helper.h | ||
29 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_2(neon_qzip8, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
30 | DEF_HELPER_FLAGS_2(neon_qzip16, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
31 | DEF_HELPER_FLAGS_2(neon_qzip32, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
32 | |||
33 | -DEF_HELPER_FLAGS_3(crypto_aese, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
34 | +DEF_HELPER_FLAGS_4(crypto_aese, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
35 | DEF_HELPER_FLAGS_3(crypto_aesmc, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
36 | |||
37 | DEF_HELPER_FLAGS_4(crypto_sha1_3reg, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
38 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_5(crypto_sm3tt, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32, i32) | ||
39 | DEF_HELPER_FLAGS_3(crypto_sm3partw1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
40 | DEF_HELPER_FLAGS_3(crypto_sm3partw2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
41 | |||
42 | -DEF_HELPER_FLAGS_2(crypto_sm4e, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
43 | -DEF_HELPER_FLAGS_3(crypto_sm4ekey, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
44 | +DEF_HELPER_FLAGS_4(crypto_sm4e, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
45 | +DEF_HELPER_FLAGS_4(crypto_sm4ekey, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
46 | |||
47 | DEF_HELPER_FLAGS_3(crc32, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) | ||
48 | DEF_HELPER_FLAGS_3(crc32c, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) | ||
49 | diff --git a/target/arm/vec_internal.h b/target/arm/vec_internal.h | ||
50 | new file mode 100644 | 22 | new file mode 100644 |
51 | index XXXXXXX..XXXXXXX | 23 | index XXXXXXX..XXXXXXX |
52 | --- /dev/null | 24 | --- /dev/null |
53 | +++ b/target/arm/vec_internal.h | 25 | +++ b/include/hw/usb/xlnx-usb-subsystem.h |
54 | @@ -XXX,XX +XXX,XX @@ | 26 | @@ -XXX,XX +XXX,XX @@ |
55 | +/* | 27 | +/* |
56 | + * ARM AdvSIMD / SVE Vector Helpers | 28 | + * QEMU model of the Xilinx usb subsystem |
57 | + * | 29 | + * |
58 | + * Copyright (c) 2020 Linaro | 30 | + * Copyright (c) 2020 Xilinx Inc. Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
59 | + * | 31 | + * |
60 | + * This library is free software; you can redistribute it and/or | 32 | + * Permission is hereby granted, free of charge, to any person obtaining a copy |
61 | + * modify it under the terms of the GNU Lesser General Public | 33 | + * of this software and associated documentation files (the "Software"), to deal |
62 | + * License as published by the Free Software Foundation; either | 34 | + * in the Software without restriction, including without limitation the rights |
63 | + * version 2 of the License, or (at your option) any later version. | 35 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
64 | + * | 36 | + * copies of the Software, and to permit persons to whom the Software is |
65 | + * This library is distributed in the hope that it will be useful, | 37 | + * furnished to do so, subject to the following conditions: |
66 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of | 38 | + * |
67 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | 39 | + * The above copyright notice and this permission notice shall be included in |
68 | + * Lesser General Public License for more details. | 40 | + * all copies or substantial portions of the Software. |
69 | + * | 41 | + * |
70 | + * You should have received a copy of the GNU Lesser General Public | 42 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
71 | + * License along with this library; if not, see <http://www.gnu.org/licenses/>. | 43 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
44 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
45 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
46 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
47 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
48 | + * THE SOFTWARE. | ||
72 | + */ | 49 | + */ |
73 | + | 50 | + |
74 | +#ifndef TARGET_ARM_VEC_INTERNALS_H | 51 | +#ifndef _XLNX_VERSAL_USB_SUBSYSTEM_H_ |
75 | +#define TARGET_ARM_VEC_INTERNALS_H | 52 | +#define _XLNX_VERSAL_USB_SUBSYSTEM_H_ |
76 | + | 53 | + |
77 | +static inline void clear_tail(void *vd, uintptr_t opr_sz, uintptr_t max_sz) | 54 | +#include "hw/usb/xlnx-versal-usb2-ctrl-regs.h" |
78 | +{ | 55 | +#include "hw/usb/hcd-dwc3.h" |
79 | + uint64_t *d = vd + opr_sz; | 56 | + |
80 | + uintptr_t i; | 57 | +#define TYPE_XILINX_VERSAL_USB2 "xlnx.versal-usb2" |
81 | + | 58 | + |
82 | + for (i = opr_sz; i < max_sz; i += 8) { | 59 | +#define VERSAL_USB2(obj) \ |
83 | + *d++ = 0; | 60 | + OBJECT_CHECK(VersalUsb2, (obj), TYPE_XILINX_VERSAL_USB2) |
84 | + } | 61 | + |
85 | +} | 62 | +typedef struct VersalUsb2 { |
86 | + | 63 | + SysBusDevice parent_obj; |
87 | +#endif /* TARGET_ARM_VEC_INTERNALS_H */ | 64 | + MemoryRegion dwc3_mr; |
88 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | 65 | + MemoryRegion usb2Ctrl_mr; |
89 | index XXXXXXX..XXXXXXX 100644 | 66 | + |
90 | --- a/target/arm/crypto_helper.c | 67 | + VersalUsb2CtrlRegs usb2Ctrl; |
91 | +++ b/target/arm/crypto_helper.c | 68 | + USBDWC3 dwc3; |
69 | +} VersalUsb2; | ||
70 | + | ||
71 | +#endif | ||
72 | diff --git a/hw/usb/xlnx-usb-subsystem.c b/hw/usb/xlnx-usb-subsystem.c | ||
73 | new file mode 100644 | ||
74 | index XXXXXXX..XXXXXXX | ||
75 | --- /dev/null | ||
76 | +++ b/hw/usb/xlnx-usb-subsystem.c | ||
92 | @@ -XXX,XX +XXX,XX @@ | 77 | @@ -XXX,XX +XXX,XX @@ |
93 | 78 | +/* | |
94 | #include "cpu.h" | 79 | + * QEMU model of the Xilinx usb subsystem |
95 | #include "exec/helper-proto.h" | 80 | + * |
96 | +#include "tcg/tcg-gvec-desc.h" | 81 | + * Copyright (c) 2020 Xilinx Inc. Sai Pavan Boddu <sai.pava.boddu@xilinx.com> |
97 | #include "crypto/aes.h" | 82 | + * |
98 | +#include "vec_internal.h" | 83 | + * Permission is hereby granted, free of charge, to any person obtaining a copy |
99 | 84 | + * of this software and associated documentation files (the "Software"), to deal | |
100 | union CRYPTO_STATE { | 85 | + * in the Software without restriction, including without limitation the rights |
101 | uint8_t bytes[16]; | 86 | + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell |
102 | @@ -XXX,XX +XXX,XX @@ union CRYPTO_STATE { | 87 | + * copies of the Software, and to permit persons to whom the Software is |
103 | #define CR_ST_WORD(state, i) (state.words[i]) | 88 | + * furnished to do so, subject to the following conditions: |
104 | #endif | 89 | + * |
105 | 90 | + * The above copyright notice and this permission notice shall be included in | |
106 | -void HELPER(crypto_aese)(void *vd, void *vm, uint32_t decrypt) | 91 | + * all copies or substantial portions of the Software. |
107 | +static void do_crypto_aese(uint64_t *rd, uint64_t *rn, | 92 | + * |
108 | + uint64_t *rm, bool decrypt) | 93 | + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR |
109 | { | 94 | + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, |
110 | static uint8_t const * const sbox[2] = { AES_sbox, AES_isbox }; | 95 | + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL |
111 | static uint8_t const * const shift[2] = { AES_shifts, AES_ishifts }; | 96 | + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
112 | - uint64_t *rd = vd; | 97 | + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, |
113 | - uint64_t *rm = vm; | 98 | + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN |
114 | union CRYPTO_STATE rk = { .l = { rm[0], rm[1] } }; | 99 | + * THE SOFTWARE. |
115 | - union CRYPTO_STATE st = { .l = { rd[0], rd[1] } }; | 100 | + */ |
116 | + union CRYPTO_STATE st = { .l = { rn[0], rn[1] } }; | 101 | + |
117 | int i; | 102 | +#include "qemu/osdep.h" |
118 | 103 | +#include "hw/sysbus.h" | |
119 | - assert(decrypt < 2); | 104 | +#include "hw/irq.h" |
120 | - | 105 | +#include "hw/register.h" |
121 | /* xor state vector with round key */ | 106 | +#include "qemu/bitops.h" |
122 | rk.l[0] ^= st.l[0]; | 107 | +#include "qemu/log.h" |
123 | rk.l[1] ^= st.l[1]; | 108 | +#include "qom/object.h" |
124 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_aese)(void *vd, void *vm, uint32_t decrypt) | 109 | +#include "qapi/error.h" |
125 | rd[1] = st.l[1]; | 110 | +#include "hw/qdev-properties.h" |
126 | } | 111 | +#include "hw/usb/xlnx-usb-subsystem.h" |
127 | 112 | + | |
128 | -void HELPER(crypto_aesmc)(void *vd, void *vm, uint32_t decrypt) | 113 | +static void versal_usb2_realize(DeviceState *dev, Error **errp) |
129 | +void HELPER(crypto_aese)(void *vd, void *vn, void *vm, uint32_t desc) | 114 | +{ |
130 | +{ | 115 | + VersalUsb2 *s = VERSAL_USB2(dev); |
131 | + intptr_t i, opr_sz = simd_oprsz(desc); | 116 | + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); |
132 | + bool decrypt = simd_data(desc); | 117 | + Error *err = NULL; |
133 | + | 118 | + |
134 | + for (i = 0; i < opr_sz; i += 16) { | 119 | + sysbus_realize(SYS_BUS_DEVICE(&s->dwc3), &err); |
135 | + do_crypto_aese(vd + i, vn + i, vm + i, decrypt); | 120 | + if (err) { |
136 | + } | 121 | + error_propagate(errp, err); |
137 | + clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
138 | +} | ||
139 | + | ||
140 | +static void do_crypto_aesmc(uint64_t *rd, uint64_t *rm, bool decrypt) | ||
141 | { | ||
142 | static uint32_t const mc[][256] = { { | ||
143 | /* MixColumns lookup table */ | ||
144 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_aesmc)(void *vd, void *vm, uint32_t decrypt) | ||
145 | 0xbe805d9f, 0xb58d5491, 0xa89a4f83, 0xa397468d, | ||
146 | } }; | ||
147 | |||
148 | - uint64_t *rd = vd; | ||
149 | - uint64_t *rm = vm; | ||
150 | union CRYPTO_STATE st = { .l = { rm[0], rm[1] } }; | ||
151 | int i; | ||
152 | |||
153 | - assert(decrypt < 2); | ||
154 | - | ||
155 | for (i = 0; i < 16; i += 4) { | ||
156 | CR_ST_WORD(st, i >> 2) = | ||
157 | mc[decrypt][CR_ST_BYTE(st, i)] ^ | ||
158 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_aesmc)(void *vd, void *vm, uint32_t decrypt) | ||
159 | rd[1] = st.l[1]; | ||
160 | } | ||
161 | |||
162 | +void HELPER(crypto_aesmc)(void *vd, void *vm, uint32_t desc) | ||
163 | +{ | ||
164 | + intptr_t i, opr_sz = simd_oprsz(desc); | ||
165 | + bool decrypt = simd_data(desc); | ||
166 | + | ||
167 | + for (i = 0; i < opr_sz; i += 16) { | ||
168 | + do_crypto_aesmc(vd + i, vm + i, decrypt); | ||
169 | + } | ||
170 | + clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
171 | +} | ||
172 | + | ||
173 | /* | ||
174 | * SHA-1 logical functions | ||
175 | */ | ||
176 | @@ -XXX,XX +XXX,XX @@ static uint8_t const sm4_sbox[] = { | ||
177 | 0x79, 0xee, 0x5f, 0x3e, 0xd7, 0xcb, 0x39, 0x48, | ||
178 | }; | ||
179 | |||
180 | -void HELPER(crypto_sm4e)(void *vd, void *vn) | ||
181 | +static void do_crypto_sm4e(uint64_t *rd, uint64_t *rn, uint64_t *rm) | ||
182 | { | ||
183 | - uint64_t *rd = vd; | ||
184 | - uint64_t *rn = vn; | ||
185 | - union CRYPTO_STATE d = { .l = { rd[0], rd[1] } }; | ||
186 | - union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; | ||
187 | + union CRYPTO_STATE d = { .l = { rn[0], rn[1] } }; | ||
188 | + union CRYPTO_STATE n = { .l = { rm[0], rm[1] } }; | ||
189 | uint32_t t, i; | ||
190 | |||
191 | for (i = 0; i < 4; i++) { | ||
192 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm4e)(void *vd, void *vn) | ||
193 | rd[1] = d.l[1]; | ||
194 | } | ||
195 | |||
196 | -void HELPER(crypto_sm4ekey)(void *vd, void *vn, void* vm) | ||
197 | +void HELPER(crypto_sm4e)(void *vd, void *vn, void *vm, uint32_t desc) | ||
198 | +{ | ||
199 | + intptr_t i, opr_sz = simd_oprsz(desc); | ||
200 | + | ||
201 | + for (i = 0; i < opr_sz; i += 16) { | ||
202 | + do_crypto_sm4e(vd + i, vn + i, vm + i); | ||
203 | + } | ||
204 | + clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
205 | +} | ||
206 | + | ||
207 | +static void do_crypto_sm4ekey(uint64_t *rd, uint64_t *rn, uint64_t *rm) | ||
208 | { | ||
209 | - uint64_t *rd = vd; | ||
210 | - uint64_t *rn = vn; | ||
211 | - uint64_t *rm = vm; | ||
212 | union CRYPTO_STATE d; | ||
213 | union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; | ||
214 | union CRYPTO_STATE m = { .l = { rm[0], rm[1] } }; | ||
215 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm4ekey)(void *vd, void *vn, void* vm) | ||
216 | rd[0] = d.l[0]; | ||
217 | rd[1] = d.l[1]; | ||
218 | } | ||
219 | + | ||
220 | +void HELPER(crypto_sm4ekey)(void *vd, void *vn, void* vm, uint32_t desc) | ||
221 | +{ | ||
222 | + intptr_t i, opr_sz = simd_oprsz(desc); | ||
223 | + | ||
224 | + for (i = 0; i < opr_sz; i += 16) { | ||
225 | + do_crypto_sm4ekey(vd + i, vn + i, vm + i); | ||
226 | + } | ||
227 | + clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
228 | +} | ||
229 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
230 | index XXXXXXX..XXXXXXX 100644 | ||
231 | --- a/target/arm/translate-a64.c | ||
232 | +++ b/target/arm/translate-a64.c | ||
233 | @@ -XXX,XX +XXX,XX @@ static void gen_gvec_fn4(DisasContext *s, bool is_q, int rd, int rn, int rm, | ||
234 | is_q ? 16 : 8, vec_full_reg_size(s)); | ||
235 | } | ||
236 | |||
237 | +/* Expand a 2-operand operation using an out-of-line helper. */ | ||
238 | +static void gen_gvec_op2_ool(DisasContext *s, bool is_q, int rd, | ||
239 | + int rn, int data, gen_helper_gvec_2 *fn) | ||
240 | +{ | ||
241 | + tcg_gen_gvec_2_ool(vec_full_reg_offset(s, rd), | ||
242 | + vec_full_reg_offset(s, rn), | ||
243 | + is_q ? 16 : 8, vec_full_reg_size(s), data, fn); | ||
244 | +} | ||
245 | + | ||
246 | /* Expand a 3-operand operation using an out-of-line helper. */ | ||
247 | static void gen_gvec_op3_ool(DisasContext *s, bool is_q, int rd, | ||
248 | int rn, int rm, int data, gen_helper_gvec_3 *fn) | ||
249 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_aes(DisasContext *s, uint32_t insn) | ||
250 | int rn = extract32(insn, 5, 5); | ||
251 | int rd = extract32(insn, 0, 5); | ||
252 | int decrypt; | ||
253 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr; | ||
254 | - TCGv_i32 tcg_decrypt; | ||
255 | - CryptoThreeOpIntFn *genfn; | ||
256 | + gen_helper_gvec_2 *genfn2 = NULL; | ||
257 | + gen_helper_gvec_3 *genfn3 = NULL; | ||
258 | |||
259 | if (!dc_isar_feature(aa64_aes, s) || size != 0) { | ||
260 | unallocated_encoding(s); | ||
261 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_aes(DisasContext *s, uint32_t insn) | ||
262 | switch (opcode) { | ||
263 | case 0x4: /* AESE */ | ||
264 | decrypt = 0; | ||
265 | - genfn = gen_helper_crypto_aese; | ||
266 | + genfn3 = gen_helper_crypto_aese; | ||
267 | break; | ||
268 | case 0x6: /* AESMC */ | ||
269 | decrypt = 0; | ||
270 | - genfn = gen_helper_crypto_aesmc; | ||
271 | + genfn2 = gen_helper_crypto_aesmc; | ||
272 | break; | ||
273 | case 0x5: /* AESD */ | ||
274 | decrypt = 1; | ||
275 | - genfn = gen_helper_crypto_aese; | ||
276 | + genfn3 = gen_helper_crypto_aese; | ||
277 | break; | ||
278 | case 0x7: /* AESIMC */ | ||
279 | decrypt = 1; | ||
280 | - genfn = gen_helper_crypto_aesmc; | ||
281 | + genfn2 = gen_helper_crypto_aesmc; | ||
282 | break; | ||
283 | default: | ||
284 | unallocated_encoding(s); | ||
285 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_aes(DisasContext *s, uint32_t insn) | ||
286 | if (!fp_access_check(s)) { | ||
287 | return; | ||
288 | } | ||
289 | - | ||
290 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
291 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
292 | - tcg_decrypt = tcg_const_i32(decrypt); | ||
293 | - | ||
294 | - genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_decrypt); | ||
295 | - | ||
296 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
297 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
298 | - tcg_temp_free_i32(tcg_decrypt); | ||
299 | + if (genfn2) { | ||
300 | + gen_gvec_op2_ool(s, true, rd, rn, decrypt, genfn2); | ||
301 | + } else { | ||
302 | + gen_gvec_op3_ool(s, true, rd, rd, rn, decrypt, genfn3); | ||
303 | + } | ||
304 | } | ||
305 | |||
306 | /* Crypto three-reg SHA | ||
307 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
308 | int rn = extract32(insn, 5, 5); | ||
309 | int rd = extract32(insn, 0, 5); | ||
310 | bool feature; | ||
311 | - CryptoThreeOpFn *genfn; | ||
312 | + CryptoThreeOpFn *genfn = NULL; | ||
313 | + gen_helper_gvec_3 *oolfn = NULL; | ||
314 | |||
315 | if (o == 0) { | ||
316 | switch (opcode) { | ||
317 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
318 | break; | ||
319 | case 2: /* SM4EKEY */ | ||
320 | feature = dc_isar_feature(aa64_sm4, s); | ||
321 | - genfn = gen_helper_crypto_sm4ekey; | ||
322 | + oolfn = gen_helper_crypto_sm4ekey; | ||
323 | break; | ||
324 | default: | ||
325 | unallocated_encoding(s); | ||
326 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
327 | return; | ||
328 | } | ||
329 | |||
330 | + if (oolfn) { | ||
331 | + gen_gvec_op3_ool(s, true, rd, rn, rm, 0, oolfn); | ||
332 | + return; | 122 | + return; |
333 | + } | 123 | + } |
334 | + | 124 | + sysbus_realize(SYS_BUS_DEVICE(&s->usb2Ctrl), &err); |
335 | if (genfn) { | 125 | + if (err) { |
336 | TCGv_ptr tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr; | 126 | + error_propagate(errp, err); |
337 | |||
338 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) | ||
339 | TCGv_ptr tcg_rd_ptr, tcg_rn_ptr; | ||
340 | bool feature; | ||
341 | CryptoTwoOpFn *genfn; | ||
342 | + gen_helper_gvec_3 *oolfn = NULL; | ||
343 | |||
344 | switch (opcode) { | ||
345 | case 0: /* SHA512SU0 */ | ||
346 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) | ||
347 | break; | ||
348 | case 1: /* SM4E */ | ||
349 | feature = dc_isar_feature(aa64_sm4, s); | ||
350 | - genfn = gen_helper_crypto_sm4e; | ||
351 | + oolfn = gen_helper_crypto_sm4e; | ||
352 | break; | ||
353 | default: | ||
354 | unallocated_encoding(s); | ||
355 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) | ||
356 | return; | ||
357 | } | ||
358 | |||
359 | + if (oolfn) { | ||
360 | + gen_gvec_op3_ool(s, true, rd, rd, rn, 0, oolfn); | ||
361 | + return; | 127 | + return; |
362 | + } | 128 | + } |
363 | + | 129 | + sysbus_init_mmio(sbd, &s->dwc3_mr); |
364 | tcg_rd_ptr = vec_full_reg_ptr(s, rd); | 130 | + sysbus_init_mmio(sbd, &s->usb2Ctrl_mr); |
365 | tcg_rn_ptr = vec_full_reg_ptr(s, rn); | 131 | + qdev_pass_gpios(DEVICE(&s->dwc3.sysbus_xhci), dev, SYSBUS_DEVICE_GPIO_IRQ); |
366 | 132 | +} | |
367 | diff --git a/target/arm/translate.c b/target/arm/translate.c | 133 | + |
134 | +static void versal_usb2_init(Object *obj) | ||
135 | +{ | ||
136 | + VersalUsb2 *s = VERSAL_USB2(obj); | ||
137 | + | ||
138 | + object_initialize_child(obj, "versal.dwc3", &s->dwc3, | ||
139 | + TYPE_USB_DWC3); | ||
140 | + object_initialize_child(obj, "versal.usb2-ctrl", &s->usb2Ctrl, | ||
141 | + TYPE_XILINX_VERSAL_USB2_CTRL_REGS); | ||
142 | + memory_region_init_alias(&s->dwc3_mr, obj, "versal.dwc3_alias", | ||
143 | + &s->dwc3.iomem, 0, DWC3_SIZE); | ||
144 | + memory_region_init_alias(&s->usb2Ctrl_mr, obj, "versal.usb2Ctrl_alias", | ||
145 | + &s->usb2Ctrl.iomem, 0, USB2_REGS_R_MAX * 4); | ||
146 | + qdev_alias_all_properties(DEVICE(&s->dwc3), obj); | ||
147 | + qdev_alias_all_properties(DEVICE(&s->dwc3.sysbus_xhci), obj); | ||
148 | + object_property_add_alias(obj, "dma", OBJECT(&s->dwc3.sysbus_xhci), "dma"); | ||
149 | +} | ||
150 | + | ||
151 | +static void versal_usb2_class_init(ObjectClass *klass, void *data) | ||
152 | +{ | ||
153 | + DeviceClass *dc = DEVICE_CLASS(klass); | ||
154 | + | ||
155 | + dc->realize = versal_usb2_realize; | ||
156 | +} | ||
157 | + | ||
158 | +static const TypeInfo versal_usb2_info = { | ||
159 | + .name = TYPE_XILINX_VERSAL_USB2, | ||
160 | + .parent = TYPE_SYS_BUS_DEVICE, | ||
161 | + .instance_size = sizeof(VersalUsb2), | ||
162 | + .class_init = versal_usb2_class_init, | ||
163 | + .instance_init = versal_usb2_init, | ||
164 | +}; | ||
165 | + | ||
166 | +static void versal_usb_types(void) | ||
167 | +{ | ||
168 | + type_register_static(&versal_usb2_info); | ||
169 | +} | ||
170 | + | ||
171 | +type_init(versal_usb_types) | ||
172 | diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig | ||
368 | index XXXXXXX..XXXXXXX 100644 | 173 | index XXXXXXX..XXXXXXX 100644 |
369 | --- a/target/arm/translate.c | 174 | --- a/hw/usb/Kconfig |
370 | +++ b/target/arm/translate.c | 175 | +++ b/hw/usb/Kconfig |
371 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | 176 | @@ -XXX,XX +XXX,XX @@ config USB_DWC3 |
372 | if (!dc_isar_feature(aa32_aes, s) || ((rm | rd) & 1)) { | 177 | bool |
373 | return 1; | 178 | select USB_XHCI_SYSBUS |
374 | } | 179 | select REGISTER |
375 | - ptr1 = vfp_reg_ptr(true, rd); | 180 | + |
376 | - ptr2 = vfp_reg_ptr(true, rm); | 181 | +config XLNX_USB_SUBSYS |
377 | - | 182 | + bool |
378 | - /* Bit 6 is the lowest opcode bit; it distinguishes between | 183 | + default y if XLNX_VERSAL |
379 | - * encryption (AESE/AESMC) and decryption (AESD/AESIMC) | 184 | + select USB_DWC3 |
380 | - */ | 185 | diff --git a/hw/usb/meson.build b/hw/usb/meson.build |
381 | - tmp3 = tcg_const_i32(extract32(insn, 6, 1)); | ||
382 | - | ||
383 | + /* | ||
384 | + * Bit 6 is the lowest opcode bit; it distinguishes | ||
385 | + * between encryption (AESE/AESMC) and decryption | ||
386 | + * (AESD/AESIMC). | ||
387 | + */ | ||
388 | if (op == NEON_2RM_AESE) { | ||
389 | - gen_helper_crypto_aese(ptr1, ptr2, tmp3); | ||
390 | + tcg_gen_gvec_3_ool(vfp_reg_offset(true, rd), | ||
391 | + vfp_reg_offset(true, rd), | ||
392 | + vfp_reg_offset(true, rm), | ||
393 | + 16, 16, extract32(insn, 6, 1), | ||
394 | + gen_helper_crypto_aese); | ||
395 | } else { | ||
396 | - gen_helper_crypto_aesmc(ptr1, ptr2, tmp3); | ||
397 | + tcg_gen_gvec_2_ool(vfp_reg_offset(true, rd), | ||
398 | + vfp_reg_offset(true, rm), | ||
399 | + 16, 16, extract32(insn, 6, 1), | ||
400 | + gen_helper_crypto_aesmc); | ||
401 | } | ||
402 | - tcg_temp_free_ptr(ptr1); | ||
403 | - tcg_temp_free_ptr(ptr2); | ||
404 | - tcg_temp_free_i32(tmp3); | ||
405 | break; | ||
406 | case NEON_2RM_SHA1H: | ||
407 | if (!dc_isar_feature(aa32_sha1, s) || ((rm | rd) & 1)) { | ||
408 | diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c | ||
409 | index XXXXXXX..XXXXXXX 100644 | 186 | index XXXXXXX..XXXXXXX 100644 |
410 | --- a/target/arm/vec_helper.c | 187 | --- a/hw/usb/meson.build |
411 | +++ b/target/arm/vec_helper.c | 188 | +++ b/hw/usb/meson.build |
412 | @@ -XXX,XX +XXX,XX @@ | 189 | @@ -XXX,XX +XXX,XX @@ softmmu_ss.add(when: 'CONFIG_TUSB6010', if_true: files('tusb6010.c')) |
413 | #include "exec/helper-proto.h" | 190 | softmmu_ss.add(when: 'CONFIG_IMX', if_true: files('chipidea.c')) |
414 | #include "tcg/tcg-gvec-desc.h" | 191 | softmmu_ss.add(when: 'CONFIG_IMX_USBPHY', if_true: files('imx-usb-phy.c')) |
415 | #include "fpu/softfloat.h" | 192 | specific_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files('xlnx-versal-usb2-ctrl-regs.c')) |
416 | - | 193 | +specific_ss.add(when: 'CONFIG_XLNX_USB_SUBSYS', if_true: files('xlnx-usb-subsystem.c')) |
417 | +#include "vec_internal.h" | 194 | |
418 | 195 | # emulated usb devices | |
419 | /* Note that vector data is stored in host-endian 64-bit chunks, | 196 | softmmu_ss.add(when: 'CONFIG_USB', if_true: files('dev-hub.c')) |
420 | so addressing units smaller than that needs a host-endian fixup. */ | ||
421 | @@ -XXX,XX +XXX,XX @@ | ||
422 | #define H4(x) (x) | ||
423 | #endif | ||
424 | |||
425 | -static void clear_tail(void *vd, uintptr_t opr_sz, uintptr_t max_sz) | ||
426 | -{ | ||
427 | - uint64_t *d = vd + opr_sz; | ||
428 | - uintptr_t i; | ||
429 | - | ||
430 | - for (i = opr_sz; i < max_sz; i += 8) { | ||
431 | - *d++ = 0; | ||
432 | - } | ||
433 | -} | ||
434 | - | ||
435 | /* Signed saturating rounding doubling multiply-accumulate high half, 16-bit */ | ||
436 | static int16_t inl_qrdmlah_s16(int16_t src1, int16_t src2, | ||
437 | int16_t src3, uint32_t *sat) | ||
438 | -- | 197 | -- |
439 | 2.20.1 | 198 | 2.20.1 |
440 | 199 | ||
441 | 200 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Vikram Garhwal <fnu.vikram@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | Do not yet convert the helpers to loop over opr_sz, but the | 3 | Connect VersalUsb2 subsystem to xlnx-versal SOC, its placed |
4 | descriptor allows the vector tail to be cleared. Which fixes | 4 | in iou of lpd domain and configure it as dual port host controller. |
5 | an existing bug vs SVE. | 5 | Add the respective guest dts nodes for "xlnx-versal-virt" machine. |
6 | 6 | ||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 7 | Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com> |
8 | Message-id: 20200514212831.31248-4-richard.henderson@linaro.org | 8 | Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> |
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> |
10 | Message-id: 1607023357-5096-5-git-send-email-sai.pavan.boddu@xilinx.com | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
11 | --- | 12 | --- |
12 | target/arm/helper.h | 15 +++++++----- | 13 | include/hw/arm/xlnx-versal.h | 9 ++++++ |
13 | target/arm/crypto_helper.c | 37 +++++++++++++++++++++++----- | 14 | hw/arm/xlnx-versal-virt.c | 55 ++++++++++++++++++++++++++++++++++++ |
14 | target/arm/translate-a64.c | 50 ++++++++++++-------------------------- | 15 | hw/arm/xlnx-versal.c | 26 +++++++++++++++++ |
15 | 3 files changed, 55 insertions(+), 47 deletions(-) | 16 | 3 files changed, 90 insertions(+) |
16 | 17 | ||
17 | diff --git a/target/arm/helper.h b/target/arm/helper.h | 18 | diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h |
18 | index XXXXXXX..XXXXXXX 100644 | 19 | index XXXXXXX..XXXXXXX 100644 |
19 | --- a/target/arm/helper.h | 20 | --- a/include/hw/arm/xlnx-versal.h |
20 | +++ b/target/arm/helper.h | 21 | +++ b/include/hw/arm/xlnx-versal.h |
21 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_3(crypto_sha256h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 22 | @@ -XXX,XX +XXX,XX @@ |
22 | DEF_HELPER_FLAGS_2(crypto_sha256su0, TCG_CALL_NO_RWG, void, ptr, ptr) | 23 | #include "hw/net/cadence_gem.h" |
23 | DEF_HELPER_FLAGS_3(crypto_sha256su1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 24 | #include "hw/rtc/xlnx-zynqmp-rtc.h" |
24 | 25 | #include "qom/object.h" | |
25 | -DEF_HELPER_FLAGS_3(crypto_sha512h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 26 | +#include "hw/usb/xlnx-usb-subsystem.h" |
26 | -DEF_HELPER_FLAGS_3(crypto_sha512h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 27 | |
27 | -DEF_HELPER_FLAGS_2(crypto_sha512su0, TCG_CALL_NO_RWG, void, ptr, ptr) | 28 | #define TYPE_XLNX_VERSAL "xlnx-versal" |
28 | -DEF_HELPER_FLAGS_3(crypto_sha512su1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 29 | OBJECT_DECLARE_SIMPLE_TYPE(Versal, XLNX_VERSAL) |
29 | +DEF_HELPER_FLAGS_4(crypto_sha512h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 30 | @@ -XXX,XX +XXX,XX @@ struct Versal { |
30 | +DEF_HELPER_FLAGS_4(crypto_sha512h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 31 | PL011State uart[XLNX_VERSAL_NR_UARTS]; |
31 | +DEF_HELPER_FLAGS_3(crypto_sha512su0, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | 32 | CadenceGEMState gem[XLNX_VERSAL_NR_GEMS]; |
32 | +DEF_HELPER_FLAGS_4(crypto_sha512su1, TCG_CALL_NO_RWG, | 33 | XlnxZDMA adma[XLNX_VERSAL_NR_ADMAS]; |
33 | + void, ptr, ptr, ptr, i32) | 34 | + VersalUsb2 usb; |
34 | 35 | } iou; | |
35 | DEF_HELPER_FLAGS_5(crypto_sm3tt, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32, i32) | 36 | } lpd; |
36 | -DEF_HELPER_FLAGS_3(crypto_sm3partw1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 37 | |
37 | -DEF_HELPER_FLAGS_3(crypto_sm3partw2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 38 | @@ -XXX,XX +XXX,XX @@ struct Versal { |
38 | +DEF_HELPER_FLAGS_4(crypto_sm3partw1, TCG_CALL_NO_RWG, | 39 | |
39 | + void, ptr, ptr, ptr, i32) | 40 | #define VERSAL_UART0_IRQ_0 18 |
40 | +DEF_HELPER_FLAGS_4(crypto_sm3partw2, TCG_CALL_NO_RWG, | 41 | #define VERSAL_UART1_IRQ_0 19 |
41 | + void, ptr, ptr, ptr, i32) | 42 | +#define VERSAL_USB0_IRQ_0 22 |
42 | 43 | #define VERSAL_GEM0_IRQ_0 56 | |
43 | DEF_HELPER_FLAGS_4(crypto_sm4e, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 44 | #define VERSAL_GEM0_WAKE_IRQ_0 57 |
44 | DEF_HELPER_FLAGS_4(crypto_sm4ekey, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 45 | #define VERSAL_GEM1_IRQ_0 58 |
45 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | 46 | @@ -XXX,XX +XXX,XX @@ struct Versal { |
47 | #define MM_OCM 0xfffc0000U | ||
48 | #define MM_OCM_SIZE 0x40000 | ||
49 | |||
50 | +#define MM_USB2_CTRL_REGS 0xFF9D0000 | ||
51 | +#define MM_USB2_CTRL_REGS_SIZE 0x10000 | ||
52 | + | ||
53 | +#define MM_USB_0 0xFE200000 | ||
54 | +#define MM_USB_0_SIZE 0x10000 | ||
55 | + | ||
56 | #define MM_TOP_DDR 0x0 | ||
57 | #define MM_TOP_DDR_SIZE 0x80000000U | ||
58 | #define MM_TOP_DDR_2 0x800000000ULL | ||
59 | diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c | ||
46 | index XXXXXXX..XXXXXXX 100644 | 60 | index XXXXXXX..XXXXXXX 100644 |
47 | --- a/target/arm/crypto_helper.c | 61 | --- a/hw/arm/xlnx-versal-virt.c |
48 | +++ b/target/arm/crypto_helper.c | 62 | +++ b/hw/arm/xlnx-versal-virt.c |
49 | @@ -XXX,XX +XXX,XX @@ union CRYPTO_STATE { | 63 | @@ -XXX,XX +XXX,XX @@ struct VersalVirt { |
50 | #define CR_ST_WORD(state, i) (state.words[i]) | 64 | uint32_t ethernet_phy[2]; |
51 | #endif | 65 | uint32_t clk_125Mhz; |
52 | 66 | uint32_t clk_25Mhz; | |
53 | +/* | 67 | + uint32_t usb; |
54 | + * The caller has not been converted to full gvec, and so only | 68 | + uint32_t dwc; |
55 | + * modifies the low 16 bytes of the vector register. | 69 | } phandle; |
56 | + */ | 70 | struct arm_boot_info binfo; |
57 | +static void clear_tail_16(void *vd, uint32_t desc) | 71 | |
72 | @@ -XXX,XX +XXX,XX @@ static void fdt_create(VersalVirt *s) | ||
73 | s->phandle.clk_25Mhz = qemu_fdt_alloc_phandle(s->fdt); | ||
74 | s->phandle.clk_125Mhz = qemu_fdt_alloc_phandle(s->fdt); | ||
75 | |||
76 | + s->phandle.usb = qemu_fdt_alloc_phandle(s->fdt); | ||
77 | + s->phandle.dwc = qemu_fdt_alloc_phandle(s->fdt); | ||
78 | /* Create /chosen node for load_dtb. */ | ||
79 | qemu_fdt_add_subnode(s->fdt, "/chosen"); | ||
80 | |||
81 | @@ -XXX,XX +XXX,XX @@ static void fdt_add_timer_nodes(VersalVirt *s) | ||
82 | compat, sizeof(compat)); | ||
83 | } | ||
84 | |||
85 | +static void fdt_add_usb_xhci_nodes(VersalVirt *s) | ||
58 | +{ | 86 | +{ |
59 | + int opr_sz = simd_oprsz(desc); | 87 | + const char clocknames[] = "bus_clk\0ref_clk"; |
60 | + int max_sz = simd_maxsz(desc); | 88 | + const char irq_name[] = "dwc_usb3"; |
89 | + const char compatVersalDWC3[] = "xlnx,versal-dwc3"; | ||
90 | + const char compatDWC3[] = "snps,dwc3"; | ||
91 | + char *name = g_strdup_printf("/usb@%" PRIx32, MM_USB2_CTRL_REGS); | ||
61 | + | 92 | + |
62 | + assert(opr_sz == 16); | 93 | + qemu_fdt_add_subnode(s->fdt, name); |
63 | + clear_tail(vd, opr_sz, max_sz); | 94 | + qemu_fdt_setprop(s->fdt, name, "compatible", |
95 | + compatVersalDWC3, sizeof(compatVersalDWC3)); | ||
96 | + qemu_fdt_setprop_sized_cells(s->fdt, name, "reg", | ||
97 | + 2, MM_USB2_CTRL_REGS, | ||
98 | + 2, MM_USB2_CTRL_REGS_SIZE); | ||
99 | + qemu_fdt_setprop(s->fdt, name, "clock-names", | ||
100 | + clocknames, sizeof(clocknames)); | ||
101 | + qemu_fdt_setprop_cells(s->fdt, name, "clocks", | ||
102 | + s->phandle.clk_25Mhz, s->phandle.clk_125Mhz); | ||
103 | + qemu_fdt_setprop(s->fdt, name, "ranges", NULL, 0); | ||
104 | + qemu_fdt_setprop_cell(s->fdt, name, "#address-cells", 2); | ||
105 | + qemu_fdt_setprop_cell(s->fdt, name, "#size-cells", 2); | ||
106 | + qemu_fdt_setprop_cell(s->fdt, name, "phandle", s->phandle.usb); | ||
107 | + g_free(name); | ||
108 | + | ||
109 | + name = g_strdup_printf("/usb@%" PRIx32 "/dwc3@%" PRIx32, | ||
110 | + MM_USB2_CTRL_REGS, MM_USB_0); | ||
111 | + qemu_fdt_add_subnode(s->fdt, name); | ||
112 | + qemu_fdt_setprop(s->fdt, name, "compatible", | ||
113 | + compatDWC3, sizeof(compatDWC3)); | ||
114 | + qemu_fdt_setprop_sized_cells(s->fdt, name, "reg", | ||
115 | + 2, MM_USB_0, 2, MM_USB_0_SIZE); | ||
116 | + qemu_fdt_setprop(s->fdt, name, "interrupt-names", | ||
117 | + irq_name, sizeof(irq_name)); | ||
118 | + qemu_fdt_setprop_cells(s->fdt, name, "interrupts", | ||
119 | + GIC_FDT_IRQ_TYPE_SPI, VERSAL_USB0_IRQ_0, | ||
120 | + GIC_FDT_IRQ_FLAGS_LEVEL_HI); | ||
121 | + qemu_fdt_setprop_cell(s->fdt, name, | ||
122 | + "snps,quirk-frame-length-adjustment", 0x20); | ||
123 | + qemu_fdt_setprop_cells(s->fdt, name, "#stream-id-cells", 1); | ||
124 | + qemu_fdt_setprop_string(s->fdt, name, "dr_mode", "host"); | ||
125 | + qemu_fdt_setprop_string(s->fdt, name, "phy-names", "usb3-phy"); | ||
126 | + qemu_fdt_setprop(s->fdt, name, "snps,dis_u2_susphy_quirk", NULL, 0); | ||
127 | + qemu_fdt_setprop(s->fdt, name, "snps,dis_u3_susphy_quirk", NULL, 0); | ||
128 | + qemu_fdt_setprop(s->fdt, name, "snps,refclk_fladj", NULL, 0); | ||
129 | + qemu_fdt_setprop(s->fdt, name, "snps,mask_phy_reset", NULL, 0); | ||
130 | + qemu_fdt_setprop_cell(s->fdt, name, "phandle", s->phandle.dwc); | ||
131 | + qemu_fdt_setprop_string(s->fdt, name, "maximum-speed", "high-speed"); | ||
132 | + g_free(name); | ||
64 | +} | 133 | +} |
65 | + | 134 | + |
66 | static void do_crypto_aese(uint64_t *rd, uint64_t *rn, | 135 | static void fdt_add_uart_nodes(VersalVirt *s) |
67 | uint64_t *rm, bool decrypt) | ||
68 | { | 136 | { |
69 | @@ -XXX,XX +XXX,XX @@ static uint64_t s1_512(uint64_t x) | 137 | uint64_t addrs[] = { MM_UART1, MM_UART0 }; |
70 | return ror64(x, 19) ^ ror64(x, 61) ^ (x >> 6); | 138 | @@ -XXX,XX +XXX,XX @@ static void versal_virt_init(MachineState *machine) |
71 | } | 139 | fdt_add_gic_nodes(s); |
72 | 140 | fdt_add_timer_nodes(s); | |
73 | -void HELPER(crypto_sha512h)(void *vd, void *vn, void *vm) | 141 | fdt_add_zdma_nodes(s); |
74 | +void HELPER(crypto_sha512h)(void *vd, void *vn, void *vm, uint32_t desc) | 142 | + fdt_add_usb_xhci_nodes(s); |
75 | { | 143 | fdt_add_sd_nodes(s); |
76 | uint64_t *rd = vd; | 144 | fdt_add_rtc_node(s); |
77 | uint64_t *rn = vn; | 145 | fdt_add_cpu_nodes(s, psci_conduit); |
78 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha512h)(void *vd, void *vn, void *vm) | 146 | diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c |
79 | |||
80 | rd[0] = d0; | ||
81 | rd[1] = d1; | ||
82 | + | ||
83 | + clear_tail_16(vd, desc); | ||
84 | } | ||
85 | |||
86 | -void HELPER(crypto_sha512h2)(void *vd, void *vn, void *vm) | ||
87 | +void HELPER(crypto_sha512h2)(void *vd, void *vn, void *vm, uint32_t desc) | ||
88 | { | ||
89 | uint64_t *rd = vd; | ||
90 | uint64_t *rn = vn; | ||
91 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha512h2)(void *vd, void *vn, void *vm) | ||
92 | |||
93 | rd[0] = d0; | ||
94 | rd[1] = d1; | ||
95 | + | ||
96 | + clear_tail_16(vd, desc); | ||
97 | } | ||
98 | |||
99 | -void HELPER(crypto_sha512su0)(void *vd, void *vn) | ||
100 | +void HELPER(crypto_sha512su0)(void *vd, void *vn, uint32_t desc) | ||
101 | { | ||
102 | uint64_t *rd = vd; | ||
103 | uint64_t *rn = vn; | ||
104 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha512su0)(void *vd, void *vn) | ||
105 | |||
106 | rd[0] = d0; | ||
107 | rd[1] = d1; | ||
108 | + | ||
109 | + clear_tail_16(vd, desc); | ||
110 | } | ||
111 | |||
112 | -void HELPER(crypto_sha512su1)(void *vd, void *vn, void *vm) | ||
113 | +void HELPER(crypto_sha512su1)(void *vd, void *vn, void *vm, uint32_t desc) | ||
114 | { | ||
115 | uint64_t *rd = vd; | ||
116 | uint64_t *rn = vn; | ||
117 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha512su1)(void *vd, void *vn, void *vm) | ||
118 | |||
119 | rd[0] += s1_512(rn[0]) + rm[0]; | ||
120 | rd[1] += s1_512(rn[1]) + rm[1]; | ||
121 | + | ||
122 | + clear_tail_16(vd, desc); | ||
123 | } | ||
124 | |||
125 | -void HELPER(crypto_sm3partw1)(void *vd, void *vn, void *vm) | ||
126 | +void HELPER(crypto_sm3partw1)(void *vd, void *vn, void *vm, uint32_t desc) | ||
127 | { | ||
128 | uint64_t *rd = vd; | ||
129 | uint64_t *rn = vn; | ||
130 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm3partw1)(void *vd, void *vn, void *vm) | ||
131 | |||
132 | rd[0] = d.l[0]; | ||
133 | rd[1] = d.l[1]; | ||
134 | + | ||
135 | + clear_tail_16(vd, desc); | ||
136 | } | ||
137 | |||
138 | -void HELPER(crypto_sm3partw2)(void *vd, void *vn, void *vm) | ||
139 | +void HELPER(crypto_sm3partw2)(void *vd, void *vn, void *vm, uint32_t desc) | ||
140 | { | ||
141 | uint64_t *rd = vd; | ||
142 | uint64_t *rn = vn; | ||
143 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm3partw2)(void *vd, void *vn, void *vm) | ||
144 | |||
145 | rd[0] = d.l[0]; | ||
146 | rd[1] = d.l[1]; | ||
147 | + | ||
148 | + clear_tail_16(vd, desc); | ||
149 | } | ||
150 | |||
151 | void HELPER(crypto_sm3tt)(void *vd, void *vn, void *vm, uint32_t imm2, | ||
152 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
153 | index XXXXXXX..XXXXXXX 100644 | 147 | index XXXXXXX..XXXXXXX 100644 |
154 | --- a/target/arm/translate-a64.c | 148 | --- a/hw/arm/xlnx-versal.c |
155 | +++ b/target/arm/translate-a64.c | 149 | +++ b/hw/arm/xlnx-versal.c |
156 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | 150 | @@ -XXX,XX +XXX,XX @@ static void versal_create_uarts(Versal *s, qemu_irq *pic) |
157 | int rn = extract32(insn, 5, 5); | ||
158 | int rd = extract32(insn, 0, 5); | ||
159 | bool feature; | ||
160 | - CryptoThreeOpFn *genfn = NULL; | ||
161 | gen_helper_gvec_3 *oolfn = NULL; | ||
162 | GVecGen3Fn *gvecfn = NULL; | ||
163 | |||
164 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
165 | switch (opcode) { | ||
166 | case 0: /* SHA512H */ | ||
167 | feature = dc_isar_feature(aa64_sha512, s); | ||
168 | - genfn = gen_helper_crypto_sha512h; | ||
169 | + oolfn = gen_helper_crypto_sha512h; | ||
170 | break; | ||
171 | case 1: /* SHA512H2 */ | ||
172 | feature = dc_isar_feature(aa64_sha512, s); | ||
173 | - genfn = gen_helper_crypto_sha512h2; | ||
174 | + oolfn = gen_helper_crypto_sha512h2; | ||
175 | break; | ||
176 | case 2: /* SHA512SU1 */ | ||
177 | feature = dc_isar_feature(aa64_sha512, s); | ||
178 | - genfn = gen_helper_crypto_sha512su1; | ||
179 | + oolfn = gen_helper_crypto_sha512su1; | ||
180 | break; | ||
181 | case 3: /* RAX1 */ | ||
182 | feature = dc_isar_feature(aa64_sha3, s); | ||
183 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
184 | switch (opcode) { | ||
185 | case 0: /* SM3PARTW1 */ | ||
186 | feature = dc_isar_feature(aa64_sm3, s); | ||
187 | - genfn = gen_helper_crypto_sm3partw1; | ||
188 | + oolfn = gen_helper_crypto_sm3partw1; | ||
189 | break; | ||
190 | case 1: /* SM3PARTW2 */ | ||
191 | feature = dc_isar_feature(aa64_sm3, s); | ||
192 | - genfn = gen_helper_crypto_sm3partw2; | ||
193 | + oolfn = gen_helper_crypto_sm3partw2; | ||
194 | break; | ||
195 | case 2: /* SM4EKEY */ | ||
196 | feature = dc_isar_feature(aa64_sm4, s); | ||
197 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | ||
198 | |||
199 | if (oolfn) { | ||
200 | gen_gvec_op3_ool(s, true, rd, rn, rm, 0, oolfn); | ||
201 | - } else if (gvecfn) { | ||
202 | - gen_gvec_fn3(s, true, rd, rn, rm, gvecfn, MO_64); | ||
203 | } else { | ||
204 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr; | ||
205 | - | ||
206 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
207 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
208 | - tcg_rm_ptr = vec_full_reg_ptr(s, rm); | ||
209 | - | ||
210 | - genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr); | ||
211 | - | ||
212 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
213 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
214 | - tcg_temp_free_ptr(tcg_rm_ptr); | ||
215 | + gen_gvec_fn3(s, true, rd, rn, rm, gvecfn, MO_64); | ||
216 | } | 151 | } |
217 | } | 152 | } |
218 | 153 | ||
219 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) | 154 | +static void versal_create_usbs(Versal *s, qemu_irq *pic) |
220 | int opcode = extract32(insn, 10, 2); | 155 | +{ |
221 | int rn = extract32(insn, 5, 5); | 156 | + DeviceState *dev; |
222 | int rd = extract32(insn, 0, 5); | 157 | + MemoryRegion *mr; |
223 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr; | 158 | + |
224 | bool feature; | 159 | + object_initialize_child(OBJECT(s), "usb2", &s->lpd.iou.usb, |
225 | - CryptoTwoOpFn *genfn; | 160 | + TYPE_XILINX_VERSAL_USB2); |
226 | - gen_helper_gvec_3 *oolfn = NULL; | 161 | + dev = DEVICE(&s->lpd.iou.usb); |
227 | 162 | + | |
228 | switch (opcode) { | 163 | + object_property_set_link(OBJECT(dev), "dma", OBJECT(&s->mr_ps), |
229 | case 0: /* SHA512SU0 */ | 164 | + &error_abort); |
230 | feature = dc_isar_feature(aa64_sha512, s); | 165 | + qdev_prop_set_uint32(dev, "intrs", 1); |
231 | - genfn = gen_helper_crypto_sha512su0; | 166 | + qdev_prop_set_uint32(dev, "slots", 2); |
232 | break; | 167 | + |
233 | case 1: /* SM4E */ | 168 | + sysbus_realize(SYS_BUS_DEVICE(dev), &error_fatal); |
234 | feature = dc_isar_feature(aa64_sm4, s); | 169 | + |
235 | - oolfn = gen_helper_crypto_sm4e; | 170 | + mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0); |
236 | break; | 171 | + memory_region_add_subregion(&s->mr_ps, MM_USB_0, mr); |
237 | default: | 172 | + |
238 | unallocated_encoding(s); | 173 | + sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic[VERSAL_USB0_IRQ_0]); |
239 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha512(DisasContext *s, uint32_t insn) | 174 | + |
240 | return; | 175 | + mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 1); |
241 | } | 176 | + memory_region_add_subregion(&s->mr_ps, MM_USB2_CTRL_REGS, mr); |
242 | 177 | +} | |
243 | - if (oolfn) { | 178 | + |
244 | - gen_gvec_op3_ool(s, true, rd, rd, rn, 0, oolfn); | 179 | static void versal_create_gems(Versal *s, qemu_irq *pic) |
245 | - return; | 180 | { |
246 | + switch (opcode) { | 181 | int i; |
247 | + case 0: /* SHA512SU0 */ | 182 | @@ -XXX,XX +XXX,XX @@ static void versal_realize(DeviceState *dev, Error **errp) |
248 | + gen_gvec_op2_ool(s, true, rd, rn, 0, gen_helper_crypto_sha512su0); | 183 | versal_create_apu_cpus(s); |
249 | + break; | 184 | versal_create_apu_gic(s, pic); |
250 | + case 1: /* SM4E */ | 185 | versal_create_uarts(s, pic); |
251 | + gen_gvec_op3_ool(s, true, rd, rd, rn, 0, gen_helper_crypto_sm4e); | 186 | + versal_create_usbs(s, pic); |
252 | + break; | 187 | versal_create_gems(s, pic); |
253 | + default: | 188 | versal_create_admas(s, pic); |
254 | + g_assert_not_reached(); | 189 | versal_create_sds(s, pic); |
255 | } | ||
256 | - | ||
257 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
258 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
259 | - | ||
260 | - genfn(tcg_rd_ptr, tcg_rn_ptr); | ||
261 | - | ||
262 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
263 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
264 | } | ||
265 | |||
266 | /* Crypto four-register | ||
267 | -- | 190 | -- |
268 | 2.20.1 | 191 | 2.20.1 |
269 | 192 | ||
270 | 193 | diff view generated by jsdifflib |
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | 1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> |
---|---|---|---|
2 | 2 | ||
3 | hw_error() calls exit(). This a bit overkill when we can log | 3 | Malicious user can set the feedback divisor for the PLLs |
4 | the accesses as unimplemented or guest error. | 4 | to zero, triggering a floating-point exception (SIGFPE). |
5 | 5 | ||
6 | When fuzzing the devices, we don't want the whole process to | 6 | As the datasheet [*] is not clear how hardware behaves |
7 | exit. Replace some hw_error() calls by qemu_log_mask() | 7 | when these bits are zeroes, use the maximum divisor |
8 | (missed in commit 5a0001ec7e). | 8 | possible (128) to avoid the software FPE. |
9 | 9 | ||
10 | [*] Zynq-7000 TRM, UG585 (v1.12.2) | ||
11 | B.28 System Level Control Registers (slcr) | ||
12 | -> "Register (slcr) ARM_PLL_CTRL" | ||
13 | 25.10.4 PLLs | ||
14 | -> "Software-Controlled PLL Update" | ||
15 | |||
16 | Fixes: 38867cb7ec9 ("hw/misc/zynq_slcr: add clock generation for uarts") | ||
17 | Reported-by: Gaoning Pan <pgn@zju.edu.cn> | ||
10 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | 18 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> |
11 | Message-id: 20200525114123.21317-2-f4bug@amsat.org | 19 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> |
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 20 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> |
21 | Reviewed-by: Damien Hedde <damien.hedde@greensocs.com> | ||
22 | Message-id: 20201210141610.884600-1-f4bug@amsat.org | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 23 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
14 | --- | 24 | --- |
15 | hw/input/pxa2xx_keypad.c | 10 +++++++--- | 25 | hw/misc/zynq_slcr.c | 5 +++++ |
16 | 1 file changed, 7 insertions(+), 3 deletions(-) | 26 | 1 file changed, 5 insertions(+) |
17 | 27 | ||
18 | diff --git a/hw/input/pxa2xx_keypad.c b/hw/input/pxa2xx_keypad.c | 28 | diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c |
19 | index XXXXXXX..XXXXXXX 100644 | 29 | index XXXXXXX..XXXXXXX 100644 |
20 | --- a/hw/input/pxa2xx_keypad.c | 30 | --- a/hw/misc/zynq_slcr.c |
21 | +++ b/hw/input/pxa2xx_keypad.c | 31 | +++ b/hw/misc/zynq_slcr.c |
22 | @@ -XXX,XX +XXX,XX @@ | 32 | @@ -XXX,XX +XXX,XX @@ static uint64_t zynq_slcr_compute_pll(uint64_t input, uint32_t ctrl_reg) |
23 | */ | 33 | return 0; |
24 | |||
25 | #include "qemu/osdep.h" | ||
26 | -#include "hw/hw.h" | ||
27 | +#include "qemu/log.h" | ||
28 | #include "hw/irq.h" | ||
29 | #include "migration/vmstate.h" | ||
30 | #include "hw/arm/pxa.h" | ||
31 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_keypad_read(void *opaque, hwaddr offset, | ||
32 | return s->kpkdi; | ||
33 | break; | ||
34 | default: | ||
35 | - hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset); | ||
36 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
37 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
38 | + __func__, offset); | ||
39 | } | 34 | } |
40 | 35 | ||
41 | return 0; | 36 | + /* Consider zero feedback as maximum divide ratio possible */ |
42 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_keypad_write(void *opaque, hwaddr offset, | 37 | + if (!mult) { |
43 | break; | 38 | + mult = 1 << R_xxx_PLL_CTRL_PLL_FPDIV_LENGTH; |
44 | 39 | + } | |
45 | default: | 40 | + |
46 | - hw_error("%s: Bad offset " REG_FMT "\n", __func__, offset); | 41 | /* frequency multiplier -> period division */ |
47 | + qemu_log_mask(LOG_GUEST_ERROR, | 42 | return input / mult; |
48 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
49 | + __func__, offset); | ||
50 | } | ||
51 | } | 43 | } |
52 | |||
53 | -- | 44 | -- |
54 | 2.20.1 | 45 | 2.20.1 |
55 | 46 | ||
56 | 47 | diff view generated by jsdifflib |
1 | From: Paul Zimmerman <pauldzim@gmail.com> | 1 | From: Joe Komlodi <joe.komlodi@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | Add a check for functional dwc-hsotg (dwc2) USB host emulation to | 3 | The previous naming of the configuration registers made it sound like that if |
4 | the Raspi 2 acceptance test | 4 | the bits were set the settings would be enabled, while the opposite is true. |
5 | 5 | ||
6 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | 6 | Signed-off-by: Joe Komlodi <komlodi@xilinx.com> |
7 | Reviewed-by: Philippe Mathieu-Daude <f4bug@amsat.org> | 7 | Reviewed-by: Francisco Iglesias <francisco.iglesias@xilinx.com> |
8 | Message-id: 20200520235349.21215-8-pauldzim@gmail.com | 8 | Message-id: 1605568264-26376-2-git-send-email-komlodi@xilinx.com |
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
10 | --- | 10 | --- |
11 | tests/acceptance/boot_linux_console.py | 9 +++++++-- | 11 | hw/block/m25p80.c | 12 ++++++------ |
12 | 1 file changed, 7 insertions(+), 2 deletions(-) | 12 | 1 file changed, 6 insertions(+), 6 deletions(-) |
13 | 13 | ||
14 | diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py | 14 | diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c |
15 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/tests/acceptance/boot_linux_console.py | 16 | --- a/hw/block/m25p80.c |
17 | +++ b/tests/acceptance/boot_linux_console.py | 17 | +++ b/hw/block/m25p80.c |
18 | @@ -XXX,XX +XXX,XX @@ class BootLinuxConsole(LinuxKernelTest): | 18 | @@ -XXX,XX +XXX,XX @@ typedef struct FlashPartInfo { |
19 | 19 | #define VCFG_WRAP_SEQUENTIAL 0x2 | |
20 | self.vm.set_console() | 20 | #define NVCFG_XIP_MODE_DISABLED (7 << 9) |
21 | kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE + | 21 | #define NVCFG_XIP_MODE_MASK (7 << 9) |
22 | - serial_kernel_cmdline[uart_id]) | 22 | -#define VCFG_XIP_MODE_ENABLED (1 << 3) |
23 | + serial_kernel_cmdline[uart_id] + | 23 | +#define VCFG_XIP_MODE_DISABLED (1 << 3) |
24 | + ' root=/dev/mmcblk0p2 rootwait ' + | 24 | #define CFG_DUMMY_CLK_LEN 4 |
25 | + 'dwc_otg.fiq_fsm_enable=0') | 25 | #define NVCFG_DUMMY_CLK_POS 12 |
26 | self.vm.add_args('-kernel', kernel_path, | 26 | #define VCFG_DUMMY_CLK_POS 4 |
27 | '-dtb', dtb_path, | 27 | @@ -XXX,XX +XXX,XX @@ typedef struct FlashPartInfo { |
28 | - '-append', kernel_command_line) | 28 | #define EVCFG_VPP_ACCELERATOR (1 << 3) |
29 | + '-append', kernel_command_line, | 29 | #define EVCFG_RESET_HOLD_ENABLED (1 << 4) |
30 | + '-device', 'usb-kbd') | 30 | #define NVCFG_DUAL_IO_MASK (1 << 2) |
31 | self.vm.launch() | 31 | -#define EVCFG_DUAL_IO_ENABLED (1 << 6) |
32 | console_pattern = 'Kernel command line: %s' % kernel_command_line | 32 | +#define EVCFG_DUAL_IO_DISABLED (1 << 6) |
33 | self.wait_for_console_pattern(console_pattern) | 33 | #define NVCFG_QUAD_IO_MASK (1 << 3) |
34 | + console_pattern = 'Product: QEMU USB Keyboard' | 34 | -#define EVCFG_QUAD_IO_ENABLED (1 << 7) |
35 | + self.wait_for_console_pattern(console_pattern) | 35 | +#define EVCFG_QUAD_IO_DISABLED (1 << 7) |
36 | 36 | #define NVCFG_4BYTE_ADDR_MASK (1 << 0) | |
37 | def test_arm_raspi2_uart0(self): | 37 | #define NVCFG_LOWER_SEGMENT_MASK (1 << 1) |
38 | """ | 38 | |
39 | @@ -XXX,XX +XXX,XX @@ static void reset_memory(Flash *s) | ||
40 | s->volatile_cfg |= VCFG_WRAP_SEQUENTIAL; | ||
41 | if ((s->nonvolatile_cfg & NVCFG_XIP_MODE_MASK) | ||
42 | != NVCFG_XIP_MODE_DISABLED) { | ||
43 | - s->volatile_cfg |= VCFG_XIP_MODE_ENABLED; | ||
44 | + s->volatile_cfg |= VCFG_XIP_MODE_DISABLED; | ||
45 | } | ||
46 | s->volatile_cfg |= deposit32(s->volatile_cfg, | ||
47 | VCFG_DUMMY_CLK_POS, | ||
48 | @@ -XXX,XX +XXX,XX @@ static void reset_memory(Flash *s) | ||
49 | s->enh_volatile_cfg |= EVCFG_VPP_ACCELERATOR; | ||
50 | s->enh_volatile_cfg |= EVCFG_RESET_HOLD_ENABLED; | ||
51 | if (s->nonvolatile_cfg & NVCFG_DUAL_IO_MASK) { | ||
52 | - s->enh_volatile_cfg |= EVCFG_DUAL_IO_ENABLED; | ||
53 | + s->enh_volatile_cfg |= EVCFG_DUAL_IO_DISABLED; | ||
54 | } | ||
55 | if (s->nonvolatile_cfg & NVCFG_QUAD_IO_MASK) { | ||
56 | - s->enh_volatile_cfg |= EVCFG_QUAD_IO_ENABLED; | ||
57 | + s->enh_volatile_cfg |= EVCFG_QUAD_IO_DISABLED; | ||
58 | } | ||
59 | if (!(s->nonvolatile_cfg & NVCFG_4BYTE_ADDR_MASK)) { | ||
60 | s->four_bytes_address_mode = true; | ||
39 | -- | 61 | -- |
40 | 2.20.1 | 62 | 2.20.1 |
41 | 63 | ||
42 | 64 | diff view generated by jsdifflib |
1 | From: Eden Mikitas <e.mikitas@gmail.com> | 1 | From: Joe Komlodi <joe.komlodi@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | When inserting the value retrieved (rx) from the spi slave, rx is pushed to | 3 | VCFG XIP is set (disabled) when the NVCFG XIP bits are all set (disabled). |
4 | rx_fifo after being cast to uint8_t. rx_fifo is a fifo32, and the rx | ||
5 | register the driver uses is also 32 bit. This zeroes the 24 most | ||
6 | significant bits of rx. This proved problematic with devices that expect to | ||
7 | use the whole 32 bits of the rx register. | ||
8 | 4 | ||
9 | Signed-off-by: Eden Mikitas <e.mikitas@gmail.com> | 5 | Signed-off-by: Joe Komlodi <komlodi@xilinx.com> |
10 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | 6 | Reviewed-by: Francisco Iglesias <francisco.iglesias@xilinx.com> |
7 | Message-id: 1605568264-26376-3-git-send-email-komlodi@xilinx.com | ||
11 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
12 | --- | 9 | --- |
13 | hw/ssi/imx_spi.c | 2 +- | 10 | hw/block/m25p80.c | 2 +- |
14 | 1 file changed, 1 insertion(+), 1 deletion(-) | 11 | 1 file changed, 1 insertion(+), 1 deletion(-) |
15 | 12 | ||
16 | diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c | 13 | diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c |
17 | index XXXXXXX..XXXXXXX 100644 | 14 | index XXXXXXX..XXXXXXX 100644 |
18 | --- a/hw/ssi/imx_spi.c | 15 | --- a/hw/block/m25p80.c |
19 | +++ b/hw/ssi/imx_spi.c | 16 | +++ b/hw/block/m25p80.c |
20 | @@ -XXX,XX +XXX,XX @@ static void imx_spi_flush_txfifo(IMXSPIState *s) | 17 | @@ -XXX,XX +XXX,XX @@ static void reset_memory(Flash *s) |
21 | if (fifo32_is_full(&s->rx_fifo)) { | 18 | s->volatile_cfg |= VCFG_DUMMY; |
22 | s->regs[ECSPI_STATREG] |= ECSPI_STATREG_RO; | 19 | s->volatile_cfg |= VCFG_WRAP_SEQUENTIAL; |
23 | } else { | 20 | if ((s->nonvolatile_cfg & NVCFG_XIP_MODE_MASK) |
24 | - fifo32_push(&s->rx_fifo, (uint8_t)rx); | 21 | - != NVCFG_XIP_MODE_DISABLED) { |
25 | + fifo32_push(&s->rx_fifo, rx); | 22 | + == NVCFG_XIP_MODE_DISABLED) { |
23 | s->volatile_cfg |= VCFG_XIP_MODE_DISABLED; | ||
26 | } | 24 | } |
27 | 25 | s->volatile_cfg |= deposit32(s->volatile_cfg, | |
28 | if (s->burst_length <= 0) { | ||
29 | -- | 26 | -- |
30 | 2.20.1 | 27 | 2.20.1 |
31 | 28 | ||
32 | 29 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
2 | 1 | ||
3 | Replace printf() calls by qemu_log_mask(), which is disabled | ||
4 | by default. This avoid flooding the terminal when fuzzing the | ||
5 | device. | ||
6 | |||
7 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
8 | Message-id: 20200525114123.21317-3-f4bug@amsat.org | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | hw/arm/pxa2xx.c | 66 ++++++++++++++++++++++++++++++++++++------------- | ||
13 | 1 file changed, 49 insertions(+), 17 deletions(-) | ||
14 | |||
15 | diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/hw/arm/pxa2xx.c | ||
18 | +++ b/hw/arm/pxa2xx.c | ||
19 | @@ -XXX,XX +XXX,XX @@ | ||
20 | #include "sysemu/blockdev.h" | ||
21 | #include "sysemu/qtest.h" | ||
22 | #include "qemu/cutils.h" | ||
23 | +#include "qemu/log.h" | ||
24 | |||
25 | static struct { | ||
26 | hwaddr io_base; | ||
27 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_pm_read(void *opaque, hwaddr addr, | ||
28 | return s->pm_regs[addr >> 2]; | ||
29 | default: | ||
30 | fail: | ||
31 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
32 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
33 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
34 | + __func__, addr); | ||
35 | break; | ||
36 | } | ||
37 | return 0; | ||
38 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_pm_write(void *opaque, hwaddr addr, | ||
39 | s->pm_regs[addr >> 2] = value; | ||
40 | break; | ||
41 | } | ||
42 | - | ||
43 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
44 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
45 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
46 | + __func__, addr); | ||
47 | break; | ||
48 | } | ||
49 | } | ||
50 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_cm_read(void *opaque, hwaddr addr, | ||
51 | return s->cm_regs[CCCR >> 2] | (3 << 28); | ||
52 | |||
53 | default: | ||
54 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
55 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
56 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
57 | + __func__, addr); | ||
58 | break; | ||
59 | } | ||
60 | return 0; | ||
61 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_cm_write(void *opaque, hwaddr addr, | ||
62 | break; | ||
63 | |||
64 | default: | ||
65 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
66 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
67 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
68 | + __func__, addr); | ||
69 | break; | ||
70 | } | ||
71 | } | ||
72 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_mm_read(void *opaque, hwaddr addr, | ||
73 | return s->mm_regs[addr >> 2]; | ||
74 | /* fall through */ | ||
75 | default: | ||
76 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
77 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
78 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
79 | + __func__, addr); | ||
80 | break; | ||
81 | } | ||
82 | return 0; | ||
83 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_mm_write(void *opaque, hwaddr addr, | ||
84 | } | ||
85 | |||
86 | default: | ||
87 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
88 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
89 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
90 | + __func__, addr); | ||
91 | break; | ||
92 | } | ||
93 | } | ||
94 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_ssp_read(void *opaque, hwaddr addr, | ||
95 | case SSACD: | ||
96 | return s->ssacd; | ||
97 | default: | ||
98 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
99 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
100 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
101 | + __func__, addr); | ||
102 | break; | ||
103 | } | ||
104 | return 0; | ||
105 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_ssp_write(void *opaque, hwaddr addr, | ||
106 | break; | ||
107 | |||
108 | default: | ||
109 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
110 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
111 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
112 | + __func__, addr); | ||
113 | break; | ||
114 | } | ||
115 | } | ||
116 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_rtc_read(void *opaque, hwaddr addr, | ||
117 | else | ||
118 | return s->last_swcr; | ||
119 | default: | ||
120 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
121 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
122 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
123 | + __func__, addr); | ||
124 | break; | ||
125 | } | ||
126 | return 0; | ||
127 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_rtc_write(void *opaque, hwaddr addr, | ||
128 | break; | ||
129 | |||
130 | default: | ||
131 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
132 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
133 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
134 | + __func__, addr); | ||
135 | } | ||
136 | } | ||
137 | |||
138 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_i2c_read(void *opaque, hwaddr addr, | ||
139 | s->ibmr = 0; | ||
140 | return s->ibmr; | ||
141 | default: | ||
142 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
143 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
144 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
145 | + __func__, addr); | ||
146 | break; | ||
147 | } | ||
148 | return 0; | ||
149 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_i2c_write(void *opaque, hwaddr addr, | ||
150 | break; | ||
151 | |||
152 | default: | ||
153 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
154 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
155 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
156 | + __func__, addr); | ||
157 | } | ||
158 | } | ||
159 | |||
160 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_i2s_read(void *opaque, hwaddr addr, | ||
161 | } | ||
162 | return 0; | ||
163 | default: | ||
164 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
165 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
166 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
167 | + __func__, addr); | ||
168 | break; | ||
169 | } | ||
170 | return 0; | ||
171 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_i2s_write(void *opaque, hwaddr addr, | ||
172 | } | ||
173 | break; | ||
174 | default: | ||
175 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
176 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
177 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
178 | + __func__, addr); | ||
179 | } | ||
180 | } | ||
181 | |||
182 | @@ -XXX,XX +XXX,XX @@ static uint64_t pxa2xx_fir_read(void *opaque, hwaddr addr, | ||
183 | case ICFOR: | ||
184 | return s->rx_len; | ||
185 | default: | ||
186 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
187 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
188 | + "%s: Bad read offset 0x%"HWADDR_PRIx"\n", | ||
189 | + __func__, addr); | ||
190 | break; | ||
191 | } | ||
192 | return 0; | ||
193 | @@ -XXX,XX +XXX,XX @@ static void pxa2xx_fir_write(void *opaque, hwaddr addr, | ||
194 | case ICFOR: | ||
195 | break; | ||
196 | default: | ||
197 | - printf("%s: Bad register " REG_FMT "\n", __func__, addr); | ||
198 | + qemu_log_mask(LOG_GUEST_ERROR, | ||
199 | + "%s: Bad write offset 0x%"HWADDR_PRIx"\n", | ||
200 | + __func__, addr); | ||
201 | } | ||
202 | } | ||
203 | |||
204 | -- | ||
205 | 2.20.1 | ||
206 | |||
207 | diff view generated by jsdifflib |
1 | From: Richard Henderson <richard.henderson@linaro.org> | 1 | From: Joe Komlodi <joe.komlodi@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | With this conversion, we will be able to use the same helpers | 3 | Some Numonyx flash commands cannot be executed in DIO and QIO mode, such as |
4 | with sve. This also fixes a bug in which we failed to clear | 4 | trying to do DPP or DOR when in QIO mode. |
5 | the high bits of the SVE register after an AdvSIMD operation. | ||
6 | 5 | ||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | 6 | Signed-off-by: Joe Komlodi <komlodi@xilinx.com> |
8 | Message-id: 20200514212831.31248-3-richard.henderson@linaro.org | 7 | Reviewed-by: Francisco Iglesias <francisco.iglesias@xilinx.com> |
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | 8 | Message-id: 1605568264-26376-4-git-send-email-komlodi@xilinx.com |
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
11 | --- | 10 | --- |
12 | target/arm/helper.h | 2 ++ | 11 | hw/block/m25p80.c | 114 ++++++++++++++++++++++++++++++++++++++-------- |
13 | target/arm/translate-a64.h | 3 ++ | 12 | 1 file changed, 95 insertions(+), 19 deletions(-) |
14 | target/arm/crypto_helper.c | 11 +++++++ | ||
15 | target/arm/translate-a64.c | 59 ++++++++++++++++++++------------------ | ||
16 | 4 files changed, 47 insertions(+), 28 deletions(-) | ||
17 | 13 | ||
18 | diff --git a/target/arm/helper.h b/target/arm/helper.h | 14 | diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c |
19 | index XXXXXXX..XXXXXXX 100644 | 15 | index XXXXXXX..XXXXXXX 100644 |
20 | --- a/target/arm/helper.h | 16 | --- a/hw/block/m25p80.c |
21 | +++ b/target/arm/helper.h | 17 | +++ b/hw/block/m25p80.c |
22 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_3(crypto_sm3partw2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | 18 | @@ -XXX,XX +XXX,XX @@ typedef enum { |
23 | DEF_HELPER_FLAGS_4(crypto_sm4e, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 19 | MAN_GENERIC, |
24 | DEF_HELPER_FLAGS_4(crypto_sm4ekey, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 20 | } Manufacturer; |
25 | 21 | ||
26 | +DEF_HELPER_FLAGS_4(crypto_rax1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | 22 | +typedef enum { |
23 | + MODE_STD = 0, | ||
24 | + MODE_DIO = 1, | ||
25 | + MODE_QIO = 2 | ||
26 | +} SPIMode; | ||
27 | + | 27 | + |
28 | DEF_HELPER_FLAGS_3(crc32, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) | 28 | #define M25P80_INTERNAL_DATA_BUFFER_SZ 16 |
29 | DEF_HELPER_FLAGS_3(crc32c, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) | 29 | |
30 | 30 | struct Flash { | |
31 | diff --git a/target/arm/translate-a64.h b/target/arm/translate-a64.h | 31 | @@ -XXX,XX +XXX,XX @@ static void reset_memory(Flash *s) |
32 | index XXXXXXX..XXXXXXX 100644 | 32 | trace_m25p80_reset_done(s); |
33 | --- a/target/arm/translate-a64.h | ||
34 | +++ b/target/arm/translate-a64.h | ||
35 | @@ -XXX,XX +XXX,XX @@ static inline int vec_full_reg_size(DisasContext *s) | ||
36 | |||
37 | bool disas_sve(DisasContext *, uint32_t); | ||
38 | |||
39 | +void gen_gvec_rax1(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, | ||
40 | + uint32_t rm_ofs, uint32_t opr_sz, uint32_t max_sz); | ||
41 | + | ||
42 | #endif /* TARGET_ARM_TRANSLATE_A64_H */ | ||
43 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | ||
44 | index XXXXXXX..XXXXXXX 100644 | ||
45 | --- a/target/arm/crypto_helper.c | ||
46 | +++ b/target/arm/crypto_helper.c | ||
47 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm4ekey)(void *vd, void *vn, void* vm, uint32_t desc) | ||
48 | } | ||
49 | clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
50 | } | 33 | } |
51 | + | 34 | |
52 | +void HELPER(crypto_rax1)(void *vd, void *vn, void *vm, uint32_t desc) | 35 | +static uint8_t numonyx_mode(Flash *s) |
53 | +{ | 36 | +{ |
54 | + intptr_t i, opr_sz = simd_oprsz(desc); | 37 | + if (!(s->enh_volatile_cfg & EVCFG_QUAD_IO_DISABLED)) { |
55 | + uint64_t *d = vd, *n = vn, *m = vm; | 38 | + return MODE_QIO; |
56 | + | 39 | + } else if (!(s->enh_volatile_cfg & EVCFG_DUAL_IO_DISABLED)) { |
57 | + for (i = 0; i < opr_sz / 8; ++i) { | 40 | + return MODE_DIO; |
58 | + d[i] = n[i] ^ rol64(m[i], 1); | 41 | + } else { |
42 | + return MODE_STD; | ||
59 | + } | 43 | + } |
60 | + clear_tail(vd, opr_sz, simd_maxsz(desc)); | ||
61 | +} | ||
62 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
63 | index XXXXXXX..XXXXXXX 100644 | ||
64 | --- a/target/arm/translate-a64.c | ||
65 | +++ b/target/arm/translate-a64.c | ||
66 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha(DisasContext *s, uint32_t insn) | ||
67 | tcg_temp_free_ptr(tcg_rn_ptr); | ||
68 | } | ||
69 | |||
70 | +static void gen_rax1_i64(TCGv_i64 d, TCGv_i64 n, TCGv_i64 m) | ||
71 | +{ | ||
72 | + tcg_gen_rotli_i64(d, m, 1); | ||
73 | + tcg_gen_xor_i64(d, d, n); | ||
74 | +} | 44 | +} |
75 | + | 45 | + |
76 | +static void gen_rax1_vec(unsigned vece, TCGv_vec d, TCGv_vec n, TCGv_vec m) | 46 | static void decode_fast_read_cmd(Flash *s) |
77 | +{ | 47 | { |
78 | + tcg_gen_rotli_vec(vece, d, m, 1); | 48 | s->needed_bytes = get_addr_length(s); |
79 | + tcg_gen_xor_vec(vece, d, d, n); | 49 | @@ -XXX,XX +XXX,XX @@ static void decode_new_cmd(Flash *s, uint32_t value) |
80 | +} | 50 | case ERASE4_32K: |
81 | + | 51 | case ERASE_SECTOR: |
82 | +void gen_gvec_rax1(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, | 52 | case ERASE4_SECTOR: |
83 | + uint32_t rm_ofs, uint32_t opr_sz, uint32_t max_sz) | 53 | - case READ: |
84 | +{ | 54 | - case READ4: |
85 | + static const TCGOpcode vecop_list[] = { INDEX_op_rotli_vec, 0 }; | 55 | - case DPP: |
86 | + static const GVecGen3 op = { | 56 | - case QPP: |
87 | + .fni8 = gen_rax1_i64, | 57 | - case QPP_4: |
88 | + .fniv = gen_rax1_vec, | 58 | case PP: |
89 | + .opt_opc = vecop_list, | 59 | case PP4: |
90 | + .fno = gen_helper_crypto_rax1, | 60 | - case PP4_4: |
91 | + .vece = MO_64, | 61 | case DIE_ERASE: |
92 | + }; | 62 | case RDID_90: |
93 | + tcg_gen_gvec_3(rd_ofs, rn_ofs, rm_ofs, opr_sz, max_sz, &op); | 63 | case RDID_AB: |
94 | +} | 64 | @@ -XXX,XX +XXX,XX @@ static void decode_new_cmd(Flash *s, uint32_t value) |
95 | + | 65 | s->len = 0; |
96 | /* Crypto three-reg SHA512 | 66 | s->state = STATE_COLLECTING_DATA; |
97 | * 31 21 20 16 15 14 13 12 11 10 9 5 4 0 | 67 | break; |
98 | * +-----------------------+------+---+---+-----+--------+------+------+ | 68 | + case READ: |
99 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | 69 | + case READ4: |
100 | bool feature; | 70 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) == MODE_STD) { |
101 | CryptoThreeOpFn *genfn = NULL; | 71 | + s->needed_bytes = get_addr_length(s); |
102 | gen_helper_gvec_3 *oolfn = NULL; | 72 | + s->pos = 0; |
103 | + GVecGen3Fn *gvecfn = NULL; | 73 | + s->len = 0; |
104 | 74 | + s->state = STATE_COLLECTING_DATA; | |
105 | if (o == 0) { | 75 | + } else { |
106 | switch (opcode) { | 76 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " |
107 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | 77 | + "DIO or QIO mode\n", s->cmd_in_progress); |
108 | break; | 78 | + } |
109 | case 3: /* RAX1 */ | 79 | + break; |
110 | feature = dc_isar_feature(aa64_sha3, s); | 80 | + case DPP: |
111 | - genfn = NULL; | 81 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_QIO) { |
112 | + gvecfn = gen_gvec_rax1; | 82 | + s->needed_bytes = get_addr_length(s); |
113 | break; | 83 | + s->pos = 0; |
114 | default: | 84 | + s->len = 0; |
115 | g_assert_not_reached(); | 85 | + s->state = STATE_COLLECTING_DATA; |
116 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | 86 | + } else { |
117 | 87 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " | |
118 | if (oolfn) { | 88 | + "QIO mode\n", s->cmd_in_progress); |
119 | gen_gvec_op3_ool(s, true, rd, rn, rm, 0, oolfn); | 89 | + } |
120 | - return; | 90 | + break; |
121 | - } | 91 | + case QPP: |
122 | - | 92 | + case QPP_4: |
123 | - if (genfn) { | 93 | + case PP4_4: |
124 | + } else if (gvecfn) { | 94 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_DIO) { |
125 | + gen_gvec_fn3(s, true, rd, rn, rm, gvecfn, MO_64); | 95 | + s->needed_bytes = get_addr_length(s); |
126 | + } else { | 96 | + s->pos = 0; |
127 | TCGv_ptr tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr; | 97 | + s->len = 0; |
128 | 98 | + s->state = STATE_COLLECTING_DATA; | |
129 | tcg_rd_ptr = vec_full_reg_ptr(s, rd); | 99 | + } else { |
130 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha512(DisasContext *s, uint32_t insn) | 100 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " |
131 | tcg_temp_free_ptr(tcg_rd_ptr); | 101 | + "DIO mode\n", s->cmd_in_progress); |
132 | tcg_temp_free_ptr(tcg_rn_ptr); | 102 | + } |
133 | tcg_temp_free_ptr(tcg_rm_ptr); | 103 | + break; |
134 | - } else { | 104 | |
135 | - TCGv_i64 tcg_op1, tcg_op2, tcg_res[2]; | 105 | case FAST_READ: |
136 | - int pass; | 106 | case FAST_READ4: |
137 | - | 107 | + decode_fast_read_cmd(s); |
138 | - tcg_op1 = tcg_temp_new_i64(); | 108 | + break; |
139 | - tcg_op2 = tcg_temp_new_i64(); | 109 | case DOR: |
140 | - tcg_res[0] = tcg_temp_new_i64(); | 110 | case DOR4: |
141 | - tcg_res[1] = tcg_temp_new_i64(); | 111 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_QIO) { |
142 | - | 112 | + decode_fast_read_cmd(s); |
143 | - for (pass = 0; pass < 2; pass++) { | 113 | + } else { |
144 | - read_vec_element(s, tcg_op1, rn, pass, MO_64); | 114 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " |
145 | - read_vec_element(s, tcg_op2, rm, pass, MO_64); | 115 | + "QIO mode\n", s->cmd_in_progress); |
146 | - | 116 | + } |
147 | - tcg_gen_rotli_i64(tcg_res[pass], tcg_op2, 1); | 117 | + break; |
148 | - tcg_gen_xor_i64(tcg_res[pass], tcg_res[pass], tcg_op1); | 118 | case QOR: |
119 | case QOR4: | ||
120 | - decode_fast_read_cmd(s); | ||
121 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_DIO) { | ||
122 | + decode_fast_read_cmd(s); | ||
123 | + } else { | ||
124 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " | ||
125 | + "DIO mode\n", s->cmd_in_progress); | ||
126 | + } | ||
127 | break; | ||
128 | |||
129 | case DIOR: | ||
130 | case DIOR4: | ||
131 | - decode_dio_read_cmd(s); | ||
132 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_QIO) { | ||
133 | + decode_dio_read_cmd(s); | ||
134 | + } else { | ||
135 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " | ||
136 | + "QIO mode\n", s->cmd_in_progress); | ||
137 | + } | ||
138 | break; | ||
139 | |||
140 | case QIOR: | ||
141 | case QIOR4: | ||
142 | - decode_qio_read_cmd(s); | ||
143 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) != MODE_DIO) { | ||
144 | + decode_qio_read_cmd(s); | ||
145 | + } else { | ||
146 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute cmd %x in " | ||
147 | + "DIO mode\n", s->cmd_in_progress); | ||
148 | + } | ||
149 | break; | ||
150 | |||
151 | case WRSR: | ||
152 | @@ -XXX,XX +XXX,XX @@ static void decode_new_cmd(Flash *s, uint32_t value) | ||
153 | break; | ||
154 | |||
155 | case JEDEC_READ: | ||
156 | - trace_m25p80_populated_jedec(s); | ||
157 | - for (i = 0; i < s->pi->id_len; i++) { | ||
158 | - s->data[i] = s->pi->id[i]; | ||
149 | - } | 159 | - } |
150 | - write_vec_element(s, tcg_res[0], rd, 0, MO_64); | 160 | - for (; i < SPI_NOR_MAX_ID_LEN; i++) { |
151 | - write_vec_element(s, tcg_res[1], rd, 1, MO_64); | 161 | - s->data[i] = 0; |
152 | - | 162 | - } |
153 | - tcg_temp_free_i64(tcg_op1); | 163 | + if (get_man(s) != MAN_NUMONYX || numonyx_mode(s) == MODE_STD) { |
154 | - tcg_temp_free_i64(tcg_op2); | 164 | + trace_m25p80_populated_jedec(s); |
155 | - tcg_temp_free_i64(tcg_res[0]); | 165 | + for (i = 0; i < s->pi->id_len; i++) { |
156 | - tcg_temp_free_i64(tcg_res[1]); | 166 | + s->data[i] = s->pi->id[i]; |
157 | } | 167 | + } |
158 | } | 168 | + for (; i < SPI_NOR_MAX_ID_LEN; i++) { |
159 | 169 | + s->data[i] = 0; | |
170 | + } | ||
171 | |||
172 | - s->len = SPI_NOR_MAX_ID_LEN; | ||
173 | - s->pos = 0; | ||
174 | - s->state = STATE_READING_DATA; | ||
175 | + s->len = SPI_NOR_MAX_ID_LEN; | ||
176 | + s->pos = 0; | ||
177 | + s->state = STATE_READING_DATA; | ||
178 | + } else { | ||
179 | + qemu_log_mask(LOG_GUEST_ERROR, "M25P80: Cannot execute JEDEC read " | ||
180 | + "in DIO or QIO mode\n"); | ||
181 | + } | ||
182 | break; | ||
183 | |||
184 | case RDCR: | ||
160 | -- | 185 | -- |
161 | 2.20.1 | 186 | 2.20.1 |
162 | 187 | ||
163 | 188 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | Do not yet convert the helpers to loop over opr_sz, but the | ||
4 | descriptor allows the vector tail to be cleared. Which fixes | ||
5 | an existing bug vs SVE. | ||
6 | |||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
8 | Message-id: 20200514212831.31248-5-richard.henderson@linaro.org | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | target/arm/helper.h | 12 ++-- | ||
13 | target/arm/neon-dp.decode | 12 ++-- | ||
14 | target/arm/crypto_helper.c | 24 +++++-- | ||
15 | target/arm/translate-a64.c | 34 ++++----- | ||
16 | target/arm/translate-neon.inc.c | 124 +++++--------------------------- | ||
17 | target/arm/translate.c | 24 ++----- | ||
18 | 6 files changed, 67 insertions(+), 163 deletions(-) | ||
19 | |||
20 | diff --git a/target/arm/helper.h b/target/arm/helper.h | ||
21 | index XXXXXXX..XXXXXXX 100644 | ||
22 | --- a/target/arm/helper.h | ||
23 | +++ b/target/arm/helper.h | ||
24 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_4(crypto_aese, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
25 | DEF_HELPER_FLAGS_3(crypto_aesmc, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
26 | |||
27 | DEF_HELPER_FLAGS_4(crypto_sha1_3reg, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
28 | -DEF_HELPER_FLAGS_2(crypto_sha1h, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
29 | -DEF_HELPER_FLAGS_2(crypto_sha1su1, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
30 | +DEF_HELPER_FLAGS_3(crypto_sha1h, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
31 | +DEF_HELPER_FLAGS_3(crypto_sha1su1, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
32 | |||
33 | -DEF_HELPER_FLAGS_3(crypto_sha256h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
34 | -DEF_HELPER_FLAGS_3(crypto_sha256h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
35 | -DEF_HELPER_FLAGS_2(crypto_sha256su0, TCG_CALL_NO_RWG, void, ptr, ptr) | ||
36 | -DEF_HELPER_FLAGS_3(crypto_sha256su1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr) | ||
37 | +DEF_HELPER_FLAGS_4(crypto_sha256h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
38 | +DEF_HELPER_FLAGS_4(crypto_sha256h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
39 | +DEF_HELPER_FLAGS_3(crypto_sha256su0, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
40 | +DEF_HELPER_FLAGS_4(crypto_sha256su1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
41 | |||
42 | DEF_HELPER_FLAGS_4(crypto_sha512h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
43 | DEF_HELPER_FLAGS_4(crypto_sha512h2, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
44 | diff --git a/target/arm/neon-dp.decode b/target/arm/neon-dp.decode | ||
45 | index XXXXXXX..XXXXXXX 100644 | ||
46 | --- a/target/arm/neon-dp.decode | ||
47 | +++ b/target/arm/neon-dp.decode | ||
48 | @@ -XXX,XX +XXX,XX @@ VPADD_3s 1111 001 0 0 . .. .... .... 1011 . . . 1 .... @3same_q0 | ||
49 | |||
50 | VQRDMLAH_3s 1111 001 1 0 . .. .... .... 1011 ... 1 .... @3same | ||
51 | |||
52 | +@3same_crypto .... .... .... .... .... .... .... .... \ | ||
53 | + &3same vm=%vm_dp vn=%vn_dp vd=%vd_dp size=0 q=1 | ||
54 | + | ||
55 | SHA1_3s 1111 001 0 0 . optype:2 .... .... 1100 . 1 . 0 .... \ | ||
56 | vm=%vm_dp vn=%vn_dp vd=%vd_dp | ||
57 | -SHA256H_3s 1111 001 1 0 . 00 .... .... 1100 . 1 . 0 .... \ | ||
58 | - vm=%vm_dp vn=%vn_dp vd=%vd_dp | ||
59 | -SHA256H2_3s 1111 001 1 0 . 01 .... .... 1100 . 1 . 0 .... \ | ||
60 | - vm=%vm_dp vn=%vn_dp vd=%vd_dp | ||
61 | -SHA256SU1_3s 1111 001 1 0 . 10 .... .... 1100 . 1 . 0 .... \ | ||
62 | - vm=%vm_dp vn=%vn_dp vd=%vd_dp | ||
63 | +SHA256H_3s 1111 001 1 0 . 00 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
64 | +SHA256H2_3s 1111 001 1 0 . 01 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
65 | +SHA256SU1_3s 1111 001 1 0 . 10 .... .... 1100 . 1 . 0 .... @3same_crypto | ||
66 | |||
67 | VFMA_fp_3s 1111 001 0 0 . 0 . .... .... 1100 ... 1 .... @3same_fp | ||
68 | VFMS_fp_3s 1111 001 0 0 . 1 . .... .... 1100 ... 1 .... @3same_fp | ||
69 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | ||
70 | index XXXXXXX..XXXXXXX 100644 | ||
71 | --- a/target/arm/crypto_helper.c | ||
72 | +++ b/target/arm/crypto_helper.c | ||
73 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha1_3reg)(void *vd, void *vn, void *vm, uint32_t op) | ||
74 | rd[1] = d.l[1]; | ||
75 | } | ||
76 | |||
77 | -void HELPER(crypto_sha1h)(void *vd, void *vm) | ||
78 | +void HELPER(crypto_sha1h)(void *vd, void *vm, uint32_t desc) | ||
79 | { | ||
80 | uint64_t *rd = vd; | ||
81 | uint64_t *rm = vm; | ||
82 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha1h)(void *vd, void *vm) | ||
83 | |||
84 | rd[0] = m.l[0]; | ||
85 | rd[1] = m.l[1]; | ||
86 | + | ||
87 | + clear_tail_16(vd, desc); | ||
88 | } | ||
89 | |||
90 | -void HELPER(crypto_sha1su1)(void *vd, void *vm) | ||
91 | +void HELPER(crypto_sha1su1)(void *vd, void *vm, uint32_t desc) | ||
92 | { | ||
93 | uint64_t *rd = vd; | ||
94 | uint64_t *rm = vm; | ||
95 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha1su1)(void *vd, void *vm) | ||
96 | |||
97 | rd[0] = d.l[0]; | ||
98 | rd[1] = d.l[1]; | ||
99 | + | ||
100 | + clear_tail_16(vd, desc); | ||
101 | } | ||
102 | |||
103 | /* | ||
104 | @@ -XXX,XX +XXX,XX @@ static uint32_t s1(uint32_t x) | ||
105 | return ror32(x, 17) ^ ror32(x, 19) ^ (x >> 10); | ||
106 | } | ||
107 | |||
108 | -void HELPER(crypto_sha256h)(void *vd, void *vn, void *vm) | ||
109 | +void HELPER(crypto_sha256h)(void *vd, void *vn, void *vm, uint32_t desc) | ||
110 | { | ||
111 | uint64_t *rd = vd; | ||
112 | uint64_t *rn = vn; | ||
113 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha256h)(void *vd, void *vn, void *vm) | ||
114 | |||
115 | rd[0] = d.l[0]; | ||
116 | rd[1] = d.l[1]; | ||
117 | + | ||
118 | + clear_tail_16(vd, desc); | ||
119 | } | ||
120 | |||
121 | -void HELPER(crypto_sha256h2)(void *vd, void *vn, void *vm) | ||
122 | +void HELPER(crypto_sha256h2)(void *vd, void *vn, void *vm, uint32_t desc) | ||
123 | { | ||
124 | uint64_t *rd = vd; | ||
125 | uint64_t *rn = vn; | ||
126 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha256h2)(void *vd, void *vn, void *vm) | ||
127 | |||
128 | rd[0] = d.l[0]; | ||
129 | rd[1] = d.l[1]; | ||
130 | + | ||
131 | + clear_tail_16(vd, desc); | ||
132 | } | ||
133 | |||
134 | -void HELPER(crypto_sha256su0)(void *vd, void *vm) | ||
135 | +void HELPER(crypto_sha256su0)(void *vd, void *vm, uint32_t desc) | ||
136 | { | ||
137 | uint64_t *rd = vd; | ||
138 | uint64_t *rm = vm; | ||
139 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha256su0)(void *vd, void *vm) | ||
140 | |||
141 | rd[0] = d.l[0]; | ||
142 | rd[1] = d.l[1]; | ||
143 | + | ||
144 | + clear_tail_16(vd, desc); | ||
145 | } | ||
146 | |||
147 | -void HELPER(crypto_sha256su1)(void *vd, void *vn, void *vm) | ||
148 | +void HELPER(crypto_sha256su1)(void *vd, void *vn, void *vm, uint32_t desc) | ||
149 | { | ||
150 | uint64_t *rd = vd; | ||
151 | uint64_t *rn = vn; | ||
152 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sha256su1)(void *vd, void *vn, void *vm) | ||
153 | |||
154 | rd[0] = d.l[0]; | ||
155 | rd[1] = d.l[1]; | ||
156 | + | ||
157 | + clear_tail_16(vd, desc); | ||
158 | } | ||
159 | |||
160 | /* | ||
161 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
162 | index XXXXXXX..XXXXXXX 100644 | ||
163 | --- a/target/arm/translate-a64.c | ||
164 | +++ b/target/arm/translate-a64.c | ||
165 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha(DisasContext *s, uint32_t insn) | ||
166 | int rm = extract32(insn, 16, 5); | ||
167 | int rn = extract32(insn, 5, 5); | ||
168 | int rd = extract32(insn, 0, 5); | ||
169 | - CryptoThreeOpFn *genfn; | ||
170 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr; | ||
171 | + gen_helper_gvec_3 *genfn; | ||
172 | bool feature; | ||
173 | |||
174 | if (size != 0) { | ||
175 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_sha(DisasContext *s, uint32_t insn) | ||
176 | return; | ||
177 | } | ||
178 | |||
179 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
180 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
181 | - tcg_rm_ptr = vec_full_reg_ptr(s, rm); | ||
182 | - | ||
183 | if (genfn) { | ||
184 | - genfn(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr); | ||
185 | + gen_gvec_op3_ool(s, true, rd, rn, rm, 0, genfn); | ||
186 | } else { | ||
187 | TCGv_i32 tcg_opcode = tcg_const_i32(opcode); | ||
188 | + TCGv_ptr tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
189 | + TCGv_ptr tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
190 | + TCGv_ptr tcg_rm_ptr = vec_full_reg_ptr(s, rm); | ||
191 | |||
192 | gen_helper_crypto_sha1_3reg(tcg_rd_ptr, tcg_rn_ptr, | ||
193 | tcg_rm_ptr, tcg_opcode); | ||
194 | - tcg_temp_free_i32(tcg_opcode); | ||
195 | - } | ||
196 | |||
197 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
198 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
199 | - tcg_temp_free_ptr(tcg_rm_ptr); | ||
200 | + tcg_temp_free_i32(tcg_opcode); | ||
201 | + tcg_temp_free_ptr(tcg_rd_ptr); | ||
202 | + tcg_temp_free_ptr(tcg_rn_ptr); | ||
203 | + tcg_temp_free_ptr(tcg_rm_ptr); | ||
204 | + } | ||
205 | } | ||
206 | |||
207 | /* Crypto two-reg SHA | ||
208 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha(DisasContext *s, uint32_t insn) | ||
209 | int opcode = extract32(insn, 12, 5); | ||
210 | int rn = extract32(insn, 5, 5); | ||
211 | int rd = extract32(insn, 0, 5); | ||
212 | - CryptoTwoOpFn *genfn; | ||
213 | + gen_helper_gvec_2 *genfn; | ||
214 | bool feature; | ||
215 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr; | ||
216 | |||
217 | if (size != 0) { | ||
218 | unallocated_encoding(s); | ||
219 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_two_reg_sha(DisasContext *s, uint32_t insn) | ||
220 | if (!fp_access_check(s)) { | ||
221 | return; | ||
222 | } | ||
223 | - | ||
224 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
225 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
226 | - | ||
227 | - genfn(tcg_rd_ptr, tcg_rn_ptr); | ||
228 | - | ||
229 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
230 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
231 | + gen_gvec_op2_ool(s, true, rd, rn, 0, genfn); | ||
232 | } | ||
233 | |||
234 | static void gen_rax1_i64(TCGv_i64 d, TCGv_i64 n, TCGv_i64 m) | ||
235 | diff --git a/target/arm/translate-neon.inc.c b/target/arm/translate-neon.inc.c | ||
236 | index XXXXXXX..XXXXXXX 100644 | ||
237 | --- a/target/arm/translate-neon.inc.c | ||
238 | +++ b/target/arm/translate-neon.inc.c | ||
239 | @@ -XXX,XX +XXX,XX @@ DO_3SAME_CMP(VCGE_S, TCG_COND_GE) | ||
240 | DO_3SAME_CMP(VCGE_U, TCG_COND_GEU) | ||
241 | DO_3SAME_CMP(VCEQ, TCG_COND_EQ) | ||
242 | |||
243 | -static void gen_VMUL_p_3s(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, | ||
244 | - uint32_t rm_ofs, uint32_t oprsz, uint32_t maxsz) | ||
245 | -{ | ||
246 | - tcg_gen_gvec_3_ool(rd_ofs, rn_ofs, rm_ofs, oprsz, maxsz, | ||
247 | - 0, gen_helper_gvec_pmul_b); | ||
248 | -} | ||
249 | +#define WRAP_OOL_FN(WRAPNAME, FUNC) \ | ||
250 | + static void WRAPNAME(unsigned vece, uint32_t rd_ofs, uint32_t rn_ofs, \ | ||
251 | + uint32_t rm_ofs, uint32_t oprsz, uint32_t maxsz) \ | ||
252 | + { \ | ||
253 | + tcg_gen_gvec_3_ool(rd_ofs, rn_ofs, rm_ofs, oprsz, maxsz, 0, FUNC); \ | ||
254 | + } | ||
255 | + | ||
256 | +WRAP_OOL_FN(gen_VMUL_p_3s, gen_helper_gvec_pmul_b) | ||
257 | |||
258 | static bool trans_VMUL_p_3s(DisasContext *s, arg_3same *a) | ||
259 | { | ||
260 | @@ -XXX,XX +XXX,XX @@ static bool trans_SHA1_3s(DisasContext *s, arg_SHA1_3s *a) | ||
261 | return true; | ||
262 | } | ||
263 | |||
264 | -static bool trans_SHA256H_3s(DisasContext *s, arg_SHA256H_3s *a) | ||
265 | -{ | ||
266 | - TCGv_ptr ptr1, ptr2, ptr3; | ||
267 | - | ||
268 | - if (!arm_dc_feature(s, ARM_FEATURE_NEON) || | ||
269 | - !dc_isar_feature(aa32_sha2, s)) { | ||
270 | - return false; | ||
271 | +#define DO_SHA2(NAME, FUNC) \ | ||
272 | + WRAP_OOL_FN(gen_##NAME##_3s, FUNC) \ | ||
273 | + static bool trans_##NAME##_3s(DisasContext *s, arg_3same *a) \ | ||
274 | + { \ | ||
275 | + if (!dc_isar_feature(aa32_sha2, s)) { \ | ||
276 | + return false; \ | ||
277 | + } \ | ||
278 | + return do_3same(s, a, gen_##NAME##_3s); \ | ||
279 | } | ||
280 | |||
281 | - /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
282 | - if (!dc_isar_feature(aa32_simd_r32, s) && | ||
283 | - ((a->vd | a->vn | a->vm) & 0x10)) { | ||
284 | - return false; | ||
285 | - } | ||
286 | - | ||
287 | - if ((a->vn | a->vm | a->vd) & 1) { | ||
288 | - return false; | ||
289 | - } | ||
290 | - | ||
291 | - if (!vfp_access_check(s)) { | ||
292 | - return true; | ||
293 | - } | ||
294 | - | ||
295 | - ptr1 = vfp_reg_ptr(true, a->vd); | ||
296 | - ptr2 = vfp_reg_ptr(true, a->vn); | ||
297 | - ptr3 = vfp_reg_ptr(true, a->vm); | ||
298 | - gen_helper_crypto_sha256h(ptr1, ptr2, ptr3); | ||
299 | - tcg_temp_free_ptr(ptr1); | ||
300 | - tcg_temp_free_ptr(ptr2); | ||
301 | - tcg_temp_free_ptr(ptr3); | ||
302 | - | ||
303 | - return true; | ||
304 | -} | ||
305 | - | ||
306 | -static bool trans_SHA256H2_3s(DisasContext *s, arg_SHA256H2_3s *a) | ||
307 | -{ | ||
308 | - TCGv_ptr ptr1, ptr2, ptr3; | ||
309 | - | ||
310 | - if (!arm_dc_feature(s, ARM_FEATURE_NEON) || | ||
311 | - !dc_isar_feature(aa32_sha2, s)) { | ||
312 | - return false; | ||
313 | - } | ||
314 | - | ||
315 | - /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
316 | - if (!dc_isar_feature(aa32_simd_r32, s) && | ||
317 | - ((a->vd | a->vn | a->vm) & 0x10)) { | ||
318 | - return false; | ||
319 | - } | ||
320 | - | ||
321 | - if ((a->vn | a->vm | a->vd) & 1) { | ||
322 | - return false; | ||
323 | - } | ||
324 | - | ||
325 | - if (!vfp_access_check(s)) { | ||
326 | - return true; | ||
327 | - } | ||
328 | - | ||
329 | - ptr1 = vfp_reg_ptr(true, a->vd); | ||
330 | - ptr2 = vfp_reg_ptr(true, a->vn); | ||
331 | - ptr3 = vfp_reg_ptr(true, a->vm); | ||
332 | - gen_helper_crypto_sha256h2(ptr1, ptr2, ptr3); | ||
333 | - tcg_temp_free_ptr(ptr1); | ||
334 | - tcg_temp_free_ptr(ptr2); | ||
335 | - tcg_temp_free_ptr(ptr3); | ||
336 | - | ||
337 | - return true; | ||
338 | -} | ||
339 | - | ||
340 | -static bool trans_SHA256SU1_3s(DisasContext *s, arg_SHA256SU1_3s *a) | ||
341 | -{ | ||
342 | - TCGv_ptr ptr1, ptr2, ptr3; | ||
343 | - | ||
344 | - if (!arm_dc_feature(s, ARM_FEATURE_NEON) || | ||
345 | - !dc_isar_feature(aa32_sha2, s)) { | ||
346 | - return false; | ||
347 | - } | ||
348 | - | ||
349 | - /* UNDEF accesses to D16-D31 if they don't exist. */ | ||
350 | - if (!dc_isar_feature(aa32_simd_r32, s) && | ||
351 | - ((a->vd | a->vn | a->vm) & 0x10)) { | ||
352 | - return false; | ||
353 | - } | ||
354 | - | ||
355 | - if ((a->vn | a->vm | a->vd) & 1) { | ||
356 | - return false; | ||
357 | - } | ||
358 | - | ||
359 | - if (!vfp_access_check(s)) { | ||
360 | - return true; | ||
361 | - } | ||
362 | - | ||
363 | - ptr1 = vfp_reg_ptr(true, a->vd); | ||
364 | - ptr2 = vfp_reg_ptr(true, a->vn); | ||
365 | - ptr3 = vfp_reg_ptr(true, a->vm); | ||
366 | - gen_helper_crypto_sha256su1(ptr1, ptr2, ptr3); | ||
367 | - tcg_temp_free_ptr(ptr1); | ||
368 | - tcg_temp_free_ptr(ptr2); | ||
369 | - tcg_temp_free_ptr(ptr3); | ||
370 | - | ||
371 | - return true; | ||
372 | -} | ||
373 | +DO_SHA2(SHA256H, gen_helper_crypto_sha256h) | ||
374 | +DO_SHA2(SHA256H2, gen_helper_crypto_sha256h2) | ||
375 | +DO_SHA2(SHA256SU1, gen_helper_crypto_sha256su1) | ||
376 | |||
377 | #define DO_3SAME_64(INSN, FUNC) \ | ||
378 | static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, \ | ||
379 | diff --git a/target/arm/translate.c b/target/arm/translate.c | ||
380 | index XXXXXXX..XXXXXXX 100644 | ||
381 | --- a/target/arm/translate.c | ||
382 | +++ b/target/arm/translate.c | ||
383 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
384 | int vec_size; | ||
385 | uint32_t imm; | ||
386 | TCGv_i32 tmp, tmp2, tmp3, tmp4, tmp5; | ||
387 | - TCGv_ptr ptr1, ptr2; | ||
388 | + TCGv_ptr ptr1; | ||
389 | TCGv_i64 tmp64; | ||
390 | |||
391 | if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { | ||
392 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
393 | if (!dc_isar_feature(aa32_sha1, s) || ((rm | rd) & 1)) { | ||
394 | return 1; | ||
395 | } | ||
396 | - ptr1 = vfp_reg_ptr(true, rd); | ||
397 | - ptr2 = vfp_reg_ptr(true, rm); | ||
398 | - | ||
399 | - gen_helper_crypto_sha1h(ptr1, ptr2); | ||
400 | - | ||
401 | - tcg_temp_free_ptr(ptr1); | ||
402 | - tcg_temp_free_ptr(ptr2); | ||
403 | + tcg_gen_gvec_2_ool(rd_ofs, rm_ofs, 16, 16, 0, | ||
404 | + gen_helper_crypto_sha1h); | ||
405 | break; | ||
406 | case NEON_2RM_SHA1SU1: | ||
407 | if ((rm | rd) & 1) { | ||
408 | @@ -XXX,XX +XXX,XX @@ static int disas_neon_data_insn(DisasContext *s, uint32_t insn) | ||
409 | } else if (!dc_isar_feature(aa32_sha1, s)) { | ||
410 | return 1; | ||
411 | } | ||
412 | - ptr1 = vfp_reg_ptr(true, rd); | ||
413 | - ptr2 = vfp_reg_ptr(true, rm); | ||
414 | - if (q) { | ||
415 | - gen_helper_crypto_sha256su0(ptr1, ptr2); | ||
416 | - } else { | ||
417 | - gen_helper_crypto_sha1su1(ptr1, ptr2); | ||
418 | - } | ||
419 | - tcg_temp_free_ptr(ptr1); | ||
420 | - tcg_temp_free_ptr(ptr2); | ||
421 | + tcg_gen_gvec_2_ool(rd_ofs, rm_ofs, 16, 16, 0, | ||
422 | + q ? gen_helper_crypto_sha256su0 | ||
423 | + : gen_helper_crypto_sha1su1); | ||
424 | break; | ||
425 | - | ||
426 | case NEON_2RM_VMVN: | ||
427 | tcg_gen_gvec_not(0, rd_ofs, rm_ofs, vec_size, vec_size); | ||
428 | break; | ||
429 | -- | ||
430 | 2.20.1 | ||
431 | |||
432 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Richard Henderson <richard.henderson@linaro.org> | ||
2 | 1 | ||
3 | Rather than passing an opcode to a helper, fully decode the | ||
4 | operation at translate time. Use clear_tail_16 to zap the | ||
5 | balance of the SVE register with the AdvSIMD write. | ||
6 | |||
7 | Signed-off-by: Richard Henderson <richard.henderson@linaro.org> | ||
8 | Message-id: 20200514212831.31248-7-richard.henderson@linaro.org | ||
9 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
11 | --- | ||
12 | target/arm/helper.h | 5 ++++- | ||
13 | target/arm/crypto_helper.c | 24 ++++++++++++++++++------ | ||
14 | target/arm/translate-a64.c | 21 +++++---------------- | ||
15 | 3 files changed, 27 insertions(+), 23 deletions(-) | ||
16 | |||
17 | diff --git a/target/arm/helper.h b/target/arm/helper.h | ||
18 | index XXXXXXX..XXXXXXX 100644 | ||
19 | --- a/target/arm/helper.h | ||
20 | +++ b/target/arm/helper.h | ||
21 | @@ -XXX,XX +XXX,XX @@ DEF_HELPER_FLAGS_3(crypto_sha512su0, TCG_CALL_NO_RWG, void, ptr, ptr, i32) | ||
22 | DEF_HELPER_FLAGS_4(crypto_sha512su1, TCG_CALL_NO_RWG, | ||
23 | void, ptr, ptr, ptr, i32) | ||
24 | |||
25 | -DEF_HELPER_FLAGS_5(crypto_sm3tt, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32, i32) | ||
26 | +DEF_HELPER_FLAGS_4(crypto_sm3tt1a, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
27 | +DEF_HELPER_FLAGS_4(crypto_sm3tt1b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
28 | +DEF_HELPER_FLAGS_4(crypto_sm3tt2a, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
29 | +DEF_HELPER_FLAGS_4(crypto_sm3tt2b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) | ||
30 | DEF_HELPER_FLAGS_4(crypto_sm3partw1, TCG_CALL_NO_RWG, | ||
31 | void, ptr, ptr, ptr, i32) | ||
32 | DEF_HELPER_FLAGS_4(crypto_sm3partw2, TCG_CALL_NO_RWG, | ||
33 | diff --git a/target/arm/crypto_helper.c b/target/arm/crypto_helper.c | ||
34 | index XXXXXXX..XXXXXXX 100644 | ||
35 | --- a/target/arm/crypto_helper.c | ||
36 | +++ b/target/arm/crypto_helper.c | ||
37 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm3partw2)(void *vd, void *vn, void *vm, uint32_t desc) | ||
38 | clear_tail_16(vd, desc); | ||
39 | } | ||
40 | |||
41 | -void HELPER(crypto_sm3tt)(void *vd, void *vn, void *vm, uint32_t imm2, | ||
42 | - uint32_t opcode) | ||
43 | +static inline void QEMU_ALWAYS_INLINE | ||
44 | +crypto_sm3tt(uint64_t *rd, uint64_t *rn, uint64_t *rm, | ||
45 | + uint32_t desc, uint32_t opcode) | ||
46 | { | ||
47 | - uint64_t *rd = vd; | ||
48 | - uint64_t *rn = vn; | ||
49 | - uint64_t *rm = vm; | ||
50 | union CRYPTO_STATE d = { .l = { rd[0], rd[1] } }; | ||
51 | union CRYPTO_STATE n = { .l = { rn[0], rn[1] } }; | ||
52 | union CRYPTO_STATE m = { .l = { rm[0], rm[1] } }; | ||
53 | + uint32_t imm2 = simd_data(desc); | ||
54 | uint32_t t; | ||
55 | |||
56 | assert(imm2 < 4); | ||
57 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm3tt)(void *vd, void *vn, void *vm, uint32_t imm2, | ||
58 | /* SM3TT2B */ | ||
59 | t = cho(CR_ST_WORD(d, 3), CR_ST_WORD(d, 2), CR_ST_WORD(d, 1)); | ||
60 | } else { | ||
61 | - g_assert_not_reached(); | ||
62 | + qemu_build_not_reached(); | ||
63 | } | ||
64 | |||
65 | t += CR_ST_WORD(d, 0) + CR_ST_WORD(m, imm2); | ||
66 | @@ -XXX,XX +XXX,XX @@ void HELPER(crypto_sm3tt)(void *vd, void *vn, void *vm, uint32_t imm2, | ||
67 | |||
68 | rd[0] = d.l[0]; | ||
69 | rd[1] = d.l[1]; | ||
70 | + | ||
71 | + clear_tail_16(rd, desc); | ||
72 | } | ||
73 | |||
74 | +#define DO_SM3TT(NAME, OPCODE) \ | ||
75 | + void HELPER(NAME)(void *vd, void *vn, void *vm, uint32_t desc) \ | ||
76 | + { crypto_sm3tt(vd, vn, vm, desc, OPCODE); } | ||
77 | + | ||
78 | +DO_SM3TT(crypto_sm3tt1a, 0) | ||
79 | +DO_SM3TT(crypto_sm3tt1b, 1) | ||
80 | +DO_SM3TT(crypto_sm3tt2a, 2) | ||
81 | +DO_SM3TT(crypto_sm3tt2b, 3) | ||
82 | + | ||
83 | +#undef DO_SM3TT | ||
84 | + | ||
85 | static uint8_t const sm4_sbox[] = { | ||
86 | 0xd6, 0x90, 0xe9, 0xfe, 0xcc, 0xe1, 0x3d, 0xb7, | ||
87 | 0x16, 0xb6, 0x14, 0xc2, 0x28, 0xfb, 0x2c, 0x05, | ||
88 | diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c | ||
89 | index XXXXXXX..XXXXXXX 100644 | ||
90 | --- a/target/arm/translate-a64.c | ||
91 | +++ b/target/arm/translate-a64.c | ||
92 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_xar(DisasContext *s, uint32_t insn) | ||
93 | */ | ||
94 | static void disas_crypto_three_reg_imm2(DisasContext *s, uint32_t insn) | ||
95 | { | ||
96 | + static gen_helper_gvec_3 * const fns[4] = { | ||
97 | + gen_helper_crypto_sm3tt1a, gen_helper_crypto_sm3tt1b, | ||
98 | + gen_helper_crypto_sm3tt2a, gen_helper_crypto_sm3tt2b, | ||
99 | + }; | ||
100 | int opcode = extract32(insn, 10, 2); | ||
101 | int imm2 = extract32(insn, 12, 2); | ||
102 | int rm = extract32(insn, 16, 5); | ||
103 | int rn = extract32(insn, 5, 5); | ||
104 | int rd = extract32(insn, 0, 5); | ||
105 | - TCGv_ptr tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr; | ||
106 | - TCGv_i32 tcg_imm2, tcg_opcode; | ||
107 | |||
108 | if (!dc_isar_feature(aa64_sm3, s)) { | ||
109 | unallocated_encoding(s); | ||
110 | @@ -XXX,XX +XXX,XX @@ static void disas_crypto_three_reg_imm2(DisasContext *s, uint32_t insn) | ||
111 | return; | ||
112 | } | ||
113 | |||
114 | - tcg_rd_ptr = vec_full_reg_ptr(s, rd); | ||
115 | - tcg_rn_ptr = vec_full_reg_ptr(s, rn); | ||
116 | - tcg_rm_ptr = vec_full_reg_ptr(s, rm); | ||
117 | - tcg_imm2 = tcg_const_i32(imm2); | ||
118 | - tcg_opcode = tcg_const_i32(opcode); | ||
119 | - | ||
120 | - gen_helper_crypto_sm3tt(tcg_rd_ptr, tcg_rn_ptr, tcg_rm_ptr, tcg_imm2, | ||
121 | - tcg_opcode); | ||
122 | - | ||
123 | - tcg_temp_free_ptr(tcg_rd_ptr); | ||
124 | - tcg_temp_free_ptr(tcg_rn_ptr); | ||
125 | - tcg_temp_free_ptr(tcg_rm_ptr); | ||
126 | - tcg_temp_free_i32(tcg_imm2); | ||
127 | - tcg_temp_free_i32(tcg_opcode); | ||
128 | + gen_gvec_op3_ool(s, true, rd, rn, rm, imm2, fns[opcode]); | ||
129 | } | ||
130 | |||
131 | /* C3.6 Data processing - SIMD, inc Crypto | ||
132 | -- | ||
133 | 2.20.1 | ||
134 | |||
135 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
2 | 1 | ||
3 | The ADC region size is 256B, split as: | ||
4 | - [0x00 - 0x4f] defined | ||
5 | - [0x50 - 0xff] reserved | ||
6 | |||
7 | All registers are 32-bit (thus when the datasheet mentions the | ||
8 | last defined register is 0x4c, it means its address range is | ||
9 | 0x4c .. 0x4f. | ||
10 | |||
11 | This model implementation is also 32-bit. Set MemoryRegionOps | ||
12 | 'impl' fields. | ||
13 | |||
14 | See: | ||
15 | 'RM0033 Reference manual Rev 8', Table 10.13.18 "ADC register map". | ||
16 | |||
17 | Reported-by: Seth Kintigh <skintigh@gmail.com> | ||
18 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
19 | Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
20 | Message-id: 20200603055915.17678-1-f4bug@amsat.org | ||
21 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
22 | --- | ||
23 | hw/adc/stm32f2xx_adc.c | 4 +++- | ||
24 | 1 file changed, 3 insertions(+), 1 deletion(-) | ||
25 | |||
26 | diff --git a/hw/adc/stm32f2xx_adc.c b/hw/adc/stm32f2xx_adc.c | ||
27 | index XXXXXXX..XXXXXXX 100644 | ||
28 | --- a/hw/adc/stm32f2xx_adc.c | ||
29 | +++ b/hw/adc/stm32f2xx_adc.c | ||
30 | @@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps stm32f2xx_adc_ops = { | ||
31 | .read = stm32f2xx_adc_read, | ||
32 | .write = stm32f2xx_adc_write, | ||
33 | .endianness = DEVICE_NATIVE_ENDIAN, | ||
34 | + .impl.min_access_size = 4, | ||
35 | + .impl.max_access_size = 4, | ||
36 | }; | ||
37 | |||
38 | static const VMStateDescription vmstate_stm32f2xx_adc = { | ||
39 | @@ -XXX,XX +XXX,XX @@ static void stm32f2xx_adc_init(Object *obj) | ||
40 | sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); | ||
41 | |||
42 | memory_region_init_io(&s->mmio, obj, &stm32f2xx_adc_ops, s, | ||
43 | - TYPE_STM32F2XX_ADC, 0xFF); | ||
44 | + TYPE_STM32F2XX_ADC, 0x100); | ||
45 | sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); | ||
46 | } | ||
47 | |||
48 | -- | ||
49 | 2.20.1 | ||
50 | |||
51 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Thomas Huth <thuth@redhat.com> | ||
2 | 1 | ||
3 | As described by Edgar here: | ||
4 | |||
5 | https://www.mail-archive.com/qemu-devel@nongnu.org/msg605124.html | ||
6 | |||
7 | we can use the Ubuntu kernel for testing the xlnx-versal-virt machine. | ||
8 | So let's add a boot test for this now. | ||
9 | |||
10 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
11 | Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
12 | Signed-off-by: Thomas Huth <thuth@redhat.com> | ||
13 | Reviewed-by: Alistair Francis <alistair.francis@wdc.com> | ||
14 | Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com> | ||
15 | Message-id: 20200525141237.15243-1-thuth@redhat.com | ||
16 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
17 | --- | ||
18 | tests/acceptance/boot_linux_console.py | 26 ++++++++++++++++++++++++++ | ||
19 | 1 file changed, 26 insertions(+) | ||
20 | |||
21 | diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py | ||
22 | index XXXXXXX..XXXXXXX 100644 | ||
23 | --- a/tests/acceptance/boot_linux_console.py | ||
24 | +++ b/tests/acceptance/boot_linux_console.py | ||
25 | @@ -XXX,XX +XXX,XX @@ class BootLinuxConsole(LinuxKernelTest): | ||
26 | console_pattern = 'Kernel command line: %s' % kernel_command_line | ||
27 | self.wait_for_console_pattern(console_pattern) | ||
28 | |||
29 | + def test_aarch64_xlnx_versal_virt(self): | ||
30 | + """ | ||
31 | + :avocado: tags=arch:aarch64 | ||
32 | + :avocado: tags=machine:xlnx-versal-virt | ||
33 | + :avocado: tags=device:pl011 | ||
34 | + :avocado: tags=device:arm_gicv3 | ||
35 | + """ | ||
36 | + kernel_url = ('http://ports.ubuntu.com/ubuntu-ports/dists/' | ||
37 | + 'bionic-updates/main/installer-arm64/current/images/' | ||
38 | + 'netboot/ubuntu-installer/arm64/linux') | ||
39 | + kernel_hash = '5bfc54cf7ed8157d93f6e5b0241e727b6dc22c50' | ||
40 | + kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash) | ||
41 | + | ||
42 | + initrd_url = ('http://ports.ubuntu.com/ubuntu-ports/dists/' | ||
43 | + 'bionic-updates/main/installer-arm64/current/images/' | ||
44 | + 'netboot/ubuntu-installer/arm64/initrd.gz') | ||
45 | + initrd_hash = 'd385d3e88d53e2004c5d43cbe668b458a094f772' | ||
46 | + initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash) | ||
47 | + | ||
48 | + self.vm.set_console() | ||
49 | + self.vm.add_args('-m', '2G', | ||
50 | + '-kernel', kernel_path, | ||
51 | + '-initrd', initrd_path) | ||
52 | + self.vm.launch() | ||
53 | + self.wait_for_console_pattern('Checked W+X mappings: passed') | ||
54 | + | ||
55 | def test_arm_virt(self): | ||
56 | """ | ||
57 | :avocado: tags=arch:arm | ||
58 | -- | ||
59 | 2.20.1 | ||
60 | |||
61 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Cédric Le Goater <clg@kaod.org> | ||
2 | 1 | ||
3 | Signed-off-by: Cédric Le Goater <clg@kaod.org> | ||
4 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
5 | Message-id: 20200602135050.593692-1-clg@kaod.org | ||
6 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
7 | --- | ||
8 | docs/system/arm/aspeed.rst | 85 ++++++++++++++++++++++++++++++++++++++ | ||
9 | docs/system/target-arm.rst | 1 + | ||
10 | 2 files changed, 86 insertions(+) | ||
11 | create mode 100644 docs/system/arm/aspeed.rst | ||
12 | |||
13 | diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst | ||
14 | new file mode 100644 | ||
15 | index XXXXXXX..XXXXXXX | ||
16 | --- /dev/null | ||
17 | +++ b/docs/system/arm/aspeed.rst | ||
18 | @@ -XXX,XX +XXX,XX @@ | ||
19 | +Aspeed family boards (``*-bmc``, ``ast2500-evb``, ``ast2600-evb``) | ||
20 | +================================================================== | ||
21 | + | ||
22 | +The QEMU Aspeed machines model BMCs of various OpenPOWER systems and | ||
23 | +Aspeed evaluation boards. They are based on different releases of the | ||
24 | +Aspeed SoC : the AST2400 integrating an ARM926EJ-S CPU (400MHz), the | ||
25 | +AST2500 with an ARM1176JZS CPU (800MHz) and more recently the AST2600 | ||
26 | +with dual cores ARM Cortex A7 CPUs (1.2GHz). | ||
27 | + | ||
28 | +The SoC comes with RAM, Gigabit ethernet, USB, SD/MMC, USB, SPI, I2C, | ||
29 | +etc. | ||
30 | + | ||
31 | +AST2400 SoC based machines : | ||
32 | + | ||
33 | +- ``palmetto-bmc`` OpenPOWER Palmetto POWER8 BMC | ||
34 | + | ||
35 | +AST2500 SoC based machines : | ||
36 | + | ||
37 | +- ``ast2500-evb`` Aspeed AST2500 Evaluation board | ||
38 | +- ``romulus-bmc`` OpenPOWER Romulus POWER9 BMC | ||
39 | +- ``witherspoon-bmc`` OpenPOWER Witherspoon POWER9 BMC | ||
40 | +- ``sonorapass-bmc`` OCP SonoraPass BMC | ||
41 | +- ``swift-bmc`` OpenPOWER Swift BMC POWER9 | ||
42 | + | ||
43 | +AST2600 SoC based machines : | ||
44 | + | ||
45 | +- ``ast2600-evb`` Aspeed AST2600 Evaluation board (Cortex A7) | ||
46 | +- ``tacoma-bmc`` OpenPOWER Witherspoon POWER9 AST2600 BMC | ||
47 | + | ||
48 | +Supported devices | ||
49 | +----------------- | ||
50 | + | ||
51 | + * SMP (for the AST2600 Cortex-A7) | ||
52 | + * Interrupt Controller (VIC) | ||
53 | + * Timer Controller | ||
54 | + * RTC Controller | ||
55 | + * I2C Controller | ||
56 | + * System Control Unit (SCU) | ||
57 | + * SRAM mapping | ||
58 | + * X-DMA Controller (basic interface) | ||
59 | + * Static Memory Controller (SMC or FMC) - Only SPI Flash support | ||
60 | + * SPI Memory Controller | ||
61 | + * USB 2.0 Controller | ||
62 | + * SD/MMC storage controllers | ||
63 | + * SDRAM controller (dummy interface for basic settings and training) | ||
64 | + * Watchdog Controller | ||
65 | + * GPIO Controller (Master only) | ||
66 | + * UART | ||
67 | + * Ethernet controllers | ||
68 | + | ||
69 | + | ||
70 | +Missing devices | ||
71 | +--------------- | ||
72 | + | ||
73 | + * Coprocessor support | ||
74 | + * ADC (out of tree implementation) | ||
75 | + * PWM and Fan Controller | ||
76 | + * LPC Bus Controller | ||
77 | + * Slave GPIO Controller | ||
78 | + * Super I/O Controller | ||
79 | + * Hash/Crypto Engine | ||
80 | + * PCI-Express 1 Controller | ||
81 | + * Graphic Display Controller | ||
82 | + * PECI Controller | ||
83 | + * MCTP Controller | ||
84 | + * Mailbox Controller | ||
85 | + * Virtual UART | ||
86 | + * eSPI Controller | ||
87 | + * I3C Controller | ||
88 | + | ||
89 | +Boot options | ||
90 | +------------ | ||
91 | + | ||
92 | +The Aspeed machines can be started using the -kernel option to load a | ||
93 | +Linux kernel or from a firmare image which can be downloaded from the | ||
94 | +OpenPOWER jenkins : | ||
95 | + | ||
96 | + https://openpower.xyz/ | ||
97 | + | ||
98 | +The image should be attached as an MTD drive. Run : | ||
99 | + | ||
100 | +.. code-block:: bash | ||
101 | + | ||
102 | + $ qemu-system-arm -M romulus-bmc -nic user \ | ||
103 | + -drive file=flash-romulus,format=raw,if=mtd -nographic | ||
104 | diff --git a/docs/system/target-arm.rst b/docs/system/target-arm.rst | ||
105 | index XXXXXXX..XXXXXXX 100644 | ||
106 | --- a/docs/system/target-arm.rst | ||
107 | +++ b/docs/system/target-arm.rst | ||
108 | @@ -XXX,XX +XXX,XX @@ undocumented; you can get a complete list by running | ||
109 | arm/realview | ||
110 | arm/versatile | ||
111 | arm/vexpress | ||
112 | + arm/aspeed | ||
113 | arm/musicpal | ||
114 | arm/nseries | ||
115 | arm/orangepi | ||
116 | -- | ||
117 | 2.20.1 | ||
118 | |||
119 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Paul Zimmerman <pauldzim@gmail.com> | ||
2 | 1 | ||
3 | Import the dwc-hsotg (dwc2) register definitions file from the | ||
4 | Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the | ||
5 | mainline Linux kernel, the only changes being to the header, and | ||
6 | two instances of 'u32' changed to 'uint32_t' to allow it to | ||
7 | compile. Checkpatch throws a boatload of errors due to the tab | ||
8 | indentation, but I would rather import it as-is than reformat it. | ||
9 | |||
10 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | ||
11 | Message-id: 20200520235349.21215-3-pauldzim@gmail.com | ||
12 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | --- | ||
15 | include/hw/usb/dwc2-regs.h | 899 +++++++++++++++++++++++++++++++++++++ | ||
16 | 1 file changed, 899 insertions(+) | ||
17 | create mode 100644 include/hw/usb/dwc2-regs.h | ||
18 | |||
19 | diff --git a/include/hw/usb/dwc2-regs.h b/include/hw/usb/dwc2-regs.h | ||
20 | new file mode 100644 | ||
21 | index XXXXXXX..XXXXXXX | ||
22 | --- /dev/null | ||
23 | +++ b/include/hw/usb/dwc2-regs.h | ||
24 | @@ -XXX,XX +XXX,XX @@ | ||
25 | +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */ | ||
26 | +/* | ||
27 | + * Imported from the Linux kernel file drivers/usb/dwc2/hw.h, commit | ||
28 | + * a89bae709b3492b478480a2c9734e7e9393b279c ("usb: dwc2: Move | ||
29 | + * UTMI_PHY_DATA defines closer") | ||
30 | + * | ||
31 | + * hw.h - DesignWare HS OTG Controller hardware definitions | ||
32 | + * | ||
33 | + * Copyright 2004-2013 Synopsys, Inc. | ||
34 | + * | ||
35 | + * Redistribution and use in source and binary forms, with or without | ||
36 | + * modification, are permitted provided that the following conditions | ||
37 | + * are met: | ||
38 | + * 1. Redistributions of source code must retain the above copyright | ||
39 | + * notice, this list of conditions, and the following disclaimer, | ||
40 | + * without modification. | ||
41 | + * 2. Redistributions in binary form must reproduce the above copyright | ||
42 | + * notice, this list of conditions and the following disclaimer in the | ||
43 | + * documentation and/or other materials provided with the distribution. | ||
44 | + * 3. The names of the above-listed copyright holders may not be used | ||
45 | + * to endorse or promote products derived from this software without | ||
46 | + * specific prior written permission. | ||
47 | + * | ||
48 | + * ALTERNATIVELY, this software may be distributed under the terms of the | ||
49 | + * GNU General Public License ("GPL") as published by the Free Software | ||
50 | + * Foundation; either version 2 of the License, or (at your option) any | ||
51 | + * later version. | ||
52 | + * | ||
53 | + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS | ||
54 | + * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
55 | + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
56 | + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR | ||
57 | + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, | ||
58 | + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, | ||
59 | + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR | ||
60 | + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF | ||
61 | + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
62 | + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
63 | + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
64 | + */ | ||
65 | + | ||
66 | +#ifndef __DWC2_HW_H__ | ||
67 | +#define __DWC2_HW_H__ | ||
68 | + | ||
69 | +#define HSOTG_REG(x) (x) | ||
70 | + | ||
71 | +#define GOTGCTL HSOTG_REG(0x000) | ||
72 | +#define GOTGCTL_CHIRPEN BIT(27) | ||
73 | +#define GOTGCTL_MULT_VALID_BC_MASK (0x1f << 22) | ||
74 | +#define GOTGCTL_MULT_VALID_BC_SHIFT 22 | ||
75 | +#define GOTGCTL_OTGVER BIT(20) | ||
76 | +#define GOTGCTL_BSESVLD BIT(19) | ||
77 | +#define GOTGCTL_ASESVLD BIT(18) | ||
78 | +#define GOTGCTL_DBNC_SHORT BIT(17) | ||
79 | +#define GOTGCTL_CONID_B BIT(16) | ||
80 | +#define GOTGCTL_DBNCE_FLTR_BYPASS BIT(15) | ||
81 | +#define GOTGCTL_DEVHNPEN BIT(11) | ||
82 | +#define GOTGCTL_HSTSETHNPEN BIT(10) | ||
83 | +#define GOTGCTL_HNPREQ BIT(9) | ||
84 | +#define GOTGCTL_HSTNEGSCS BIT(8) | ||
85 | +#define GOTGCTL_SESREQ BIT(1) | ||
86 | +#define GOTGCTL_SESREQSCS BIT(0) | ||
87 | + | ||
88 | +#define GOTGINT HSOTG_REG(0x004) | ||
89 | +#define GOTGINT_DBNCE_DONE BIT(19) | ||
90 | +#define GOTGINT_A_DEV_TOUT_CHG BIT(18) | ||
91 | +#define GOTGINT_HST_NEG_DET BIT(17) | ||
92 | +#define GOTGINT_HST_NEG_SUC_STS_CHNG BIT(9) | ||
93 | +#define GOTGINT_SES_REQ_SUC_STS_CHNG BIT(8) | ||
94 | +#define GOTGINT_SES_END_DET BIT(2) | ||
95 | + | ||
96 | +#define GAHBCFG HSOTG_REG(0x008) | ||
97 | +#define GAHBCFG_AHB_SINGLE BIT(23) | ||
98 | +#define GAHBCFG_NOTI_ALL_DMA_WRIT BIT(22) | ||
99 | +#define GAHBCFG_REM_MEM_SUPP BIT(21) | ||
100 | +#define GAHBCFG_P_TXF_EMP_LVL BIT(8) | ||
101 | +#define GAHBCFG_NP_TXF_EMP_LVL BIT(7) | ||
102 | +#define GAHBCFG_DMA_EN BIT(5) | ||
103 | +#define GAHBCFG_HBSTLEN_MASK (0xf << 1) | ||
104 | +#define GAHBCFG_HBSTLEN_SHIFT 1 | ||
105 | +#define GAHBCFG_HBSTLEN_SINGLE 0 | ||
106 | +#define GAHBCFG_HBSTLEN_INCR 1 | ||
107 | +#define GAHBCFG_HBSTLEN_INCR4 3 | ||
108 | +#define GAHBCFG_HBSTLEN_INCR8 5 | ||
109 | +#define GAHBCFG_HBSTLEN_INCR16 7 | ||
110 | +#define GAHBCFG_GLBL_INTR_EN BIT(0) | ||
111 | +#define GAHBCFG_CTRL_MASK (GAHBCFG_P_TXF_EMP_LVL | \ | ||
112 | + GAHBCFG_NP_TXF_EMP_LVL | \ | ||
113 | + GAHBCFG_DMA_EN | \ | ||
114 | + GAHBCFG_GLBL_INTR_EN) | ||
115 | + | ||
116 | +#define GUSBCFG HSOTG_REG(0x00C) | ||
117 | +#define GUSBCFG_FORCEDEVMODE BIT(30) | ||
118 | +#define GUSBCFG_FORCEHOSTMODE BIT(29) | ||
119 | +#define GUSBCFG_TXENDDELAY BIT(28) | ||
120 | +#define GUSBCFG_ICTRAFFICPULLREMOVE BIT(27) | ||
121 | +#define GUSBCFG_ICUSBCAP BIT(26) | ||
122 | +#define GUSBCFG_ULPI_INT_PROT_DIS BIT(25) | ||
123 | +#define GUSBCFG_INDICATORPASSTHROUGH BIT(24) | ||
124 | +#define GUSBCFG_INDICATORCOMPLEMENT BIT(23) | ||
125 | +#define GUSBCFG_TERMSELDLPULSE BIT(22) | ||
126 | +#define GUSBCFG_ULPI_INT_VBUS_IND BIT(21) | ||
127 | +#define GUSBCFG_ULPI_EXT_VBUS_DRV BIT(20) | ||
128 | +#define GUSBCFG_ULPI_CLK_SUSP_M BIT(19) | ||
129 | +#define GUSBCFG_ULPI_AUTO_RES BIT(18) | ||
130 | +#define GUSBCFG_ULPI_FS_LS BIT(17) | ||
131 | +#define GUSBCFG_OTG_UTMI_FS_SEL BIT(16) | ||
132 | +#define GUSBCFG_PHY_LP_CLK_SEL BIT(15) | ||
133 | +#define GUSBCFG_USBTRDTIM_MASK (0xf << 10) | ||
134 | +#define GUSBCFG_USBTRDTIM_SHIFT 10 | ||
135 | +#define GUSBCFG_HNPCAP BIT(9) | ||
136 | +#define GUSBCFG_SRPCAP BIT(8) | ||
137 | +#define GUSBCFG_DDRSEL BIT(7) | ||
138 | +#define GUSBCFG_PHYSEL BIT(6) | ||
139 | +#define GUSBCFG_FSINTF BIT(5) | ||
140 | +#define GUSBCFG_ULPI_UTMI_SEL BIT(4) | ||
141 | +#define GUSBCFG_PHYIF16 BIT(3) | ||
142 | +#define GUSBCFG_PHYIF8 (0 << 3) | ||
143 | +#define GUSBCFG_TOUTCAL_MASK (0x7 << 0) | ||
144 | +#define GUSBCFG_TOUTCAL_SHIFT 0 | ||
145 | +#define GUSBCFG_TOUTCAL_LIMIT 0x7 | ||
146 | +#define GUSBCFG_TOUTCAL(_x) ((_x) << 0) | ||
147 | + | ||
148 | +#define GRSTCTL HSOTG_REG(0x010) | ||
149 | +#define GRSTCTL_AHBIDLE BIT(31) | ||
150 | +#define GRSTCTL_DMAREQ BIT(30) | ||
151 | +#define GRSTCTL_TXFNUM_MASK (0x1f << 6) | ||
152 | +#define GRSTCTL_TXFNUM_SHIFT 6 | ||
153 | +#define GRSTCTL_TXFNUM_LIMIT 0x1f | ||
154 | +#define GRSTCTL_TXFNUM(_x) ((_x) << 6) | ||
155 | +#define GRSTCTL_TXFFLSH BIT(5) | ||
156 | +#define GRSTCTL_RXFFLSH BIT(4) | ||
157 | +#define GRSTCTL_IN_TKNQ_FLSH BIT(3) | ||
158 | +#define GRSTCTL_FRMCNTRRST BIT(2) | ||
159 | +#define GRSTCTL_HSFTRST BIT(1) | ||
160 | +#define GRSTCTL_CSFTRST BIT(0) | ||
161 | + | ||
162 | +#define GINTSTS HSOTG_REG(0x014) | ||
163 | +#define GINTMSK HSOTG_REG(0x018) | ||
164 | +#define GINTSTS_WKUPINT BIT(31) | ||
165 | +#define GINTSTS_SESSREQINT BIT(30) | ||
166 | +#define GINTSTS_DISCONNINT BIT(29) | ||
167 | +#define GINTSTS_CONIDSTSCHNG BIT(28) | ||
168 | +#define GINTSTS_LPMTRANRCVD BIT(27) | ||
169 | +#define GINTSTS_PTXFEMP BIT(26) | ||
170 | +#define GINTSTS_HCHINT BIT(25) | ||
171 | +#define GINTSTS_PRTINT BIT(24) | ||
172 | +#define GINTSTS_RESETDET BIT(23) | ||
173 | +#define GINTSTS_FET_SUSP BIT(22) | ||
174 | +#define GINTSTS_INCOMPL_IP BIT(21) | ||
175 | +#define GINTSTS_INCOMPL_SOOUT BIT(21) | ||
176 | +#define GINTSTS_INCOMPL_SOIN BIT(20) | ||
177 | +#define GINTSTS_OEPINT BIT(19) | ||
178 | +#define GINTSTS_IEPINT BIT(18) | ||
179 | +#define GINTSTS_EPMIS BIT(17) | ||
180 | +#define GINTSTS_RESTOREDONE BIT(16) | ||
181 | +#define GINTSTS_EOPF BIT(15) | ||
182 | +#define GINTSTS_ISOUTDROP BIT(14) | ||
183 | +#define GINTSTS_ENUMDONE BIT(13) | ||
184 | +#define GINTSTS_USBRST BIT(12) | ||
185 | +#define GINTSTS_USBSUSP BIT(11) | ||
186 | +#define GINTSTS_ERLYSUSP BIT(10) | ||
187 | +#define GINTSTS_I2CINT BIT(9) | ||
188 | +#define GINTSTS_ULPI_CK_INT BIT(8) | ||
189 | +#define GINTSTS_GOUTNAKEFF BIT(7) | ||
190 | +#define GINTSTS_GINNAKEFF BIT(6) | ||
191 | +#define GINTSTS_NPTXFEMP BIT(5) | ||
192 | +#define GINTSTS_RXFLVL BIT(4) | ||
193 | +#define GINTSTS_SOF BIT(3) | ||
194 | +#define GINTSTS_OTGINT BIT(2) | ||
195 | +#define GINTSTS_MODEMIS BIT(1) | ||
196 | +#define GINTSTS_CURMODE_HOST BIT(0) | ||
197 | + | ||
198 | +#define GRXSTSR HSOTG_REG(0x01C) | ||
199 | +#define GRXSTSP HSOTG_REG(0x020) | ||
200 | +#define GRXSTS_FN_MASK (0x7f << 25) | ||
201 | +#define GRXSTS_FN_SHIFT 25 | ||
202 | +#define GRXSTS_PKTSTS_MASK (0xf << 17) | ||
203 | +#define GRXSTS_PKTSTS_SHIFT 17 | ||
204 | +#define GRXSTS_PKTSTS_GLOBALOUTNAK 1 | ||
205 | +#define GRXSTS_PKTSTS_OUTRX 2 | ||
206 | +#define GRXSTS_PKTSTS_HCHIN 2 | ||
207 | +#define GRXSTS_PKTSTS_OUTDONE 3 | ||
208 | +#define GRXSTS_PKTSTS_HCHIN_XFER_COMP 3 | ||
209 | +#define GRXSTS_PKTSTS_SETUPDONE 4 | ||
210 | +#define GRXSTS_PKTSTS_DATATOGGLEERR 5 | ||
211 | +#define GRXSTS_PKTSTS_SETUPRX 6 | ||
212 | +#define GRXSTS_PKTSTS_HCHHALTED 7 | ||
213 | +#define GRXSTS_HCHNUM_MASK (0xf << 0) | ||
214 | +#define GRXSTS_HCHNUM_SHIFT 0 | ||
215 | +#define GRXSTS_DPID_MASK (0x3 << 15) | ||
216 | +#define GRXSTS_DPID_SHIFT 15 | ||
217 | +#define GRXSTS_BYTECNT_MASK (0x7ff << 4) | ||
218 | +#define GRXSTS_BYTECNT_SHIFT 4 | ||
219 | +#define GRXSTS_EPNUM_MASK (0xf << 0) | ||
220 | +#define GRXSTS_EPNUM_SHIFT 0 | ||
221 | + | ||
222 | +#define GRXFSIZ HSOTG_REG(0x024) | ||
223 | +#define GRXFSIZ_DEPTH_MASK (0xffff << 0) | ||
224 | +#define GRXFSIZ_DEPTH_SHIFT 0 | ||
225 | + | ||
226 | +#define GNPTXFSIZ HSOTG_REG(0x028) | ||
227 | +/* Use FIFOSIZE_* constants to access this register */ | ||
228 | + | ||
229 | +#define GNPTXSTS HSOTG_REG(0x02C) | ||
230 | +#define GNPTXSTS_NP_TXQ_TOP_MASK (0x7f << 24) | ||
231 | +#define GNPTXSTS_NP_TXQ_TOP_SHIFT 24 | ||
232 | +#define GNPTXSTS_NP_TXQ_SPC_AVAIL_MASK (0xff << 16) | ||
233 | +#define GNPTXSTS_NP_TXQ_SPC_AVAIL_SHIFT 16 | ||
234 | +#define GNPTXSTS_NP_TXQ_SPC_AVAIL_GET(_v) (((_v) >> 16) & 0xff) | ||
235 | +#define GNPTXSTS_NP_TXF_SPC_AVAIL_MASK (0xffff << 0) | ||
236 | +#define GNPTXSTS_NP_TXF_SPC_AVAIL_SHIFT 0 | ||
237 | +#define GNPTXSTS_NP_TXF_SPC_AVAIL_GET(_v) (((_v) >> 0) & 0xffff) | ||
238 | + | ||
239 | +#define GI2CCTL HSOTG_REG(0x0030) | ||
240 | +#define GI2CCTL_BSYDNE BIT(31) | ||
241 | +#define GI2CCTL_RW BIT(30) | ||
242 | +#define GI2CCTL_I2CDATSE0 BIT(28) | ||
243 | +#define GI2CCTL_I2CDEVADDR_MASK (0x3 << 26) | ||
244 | +#define GI2CCTL_I2CDEVADDR_SHIFT 26 | ||
245 | +#define GI2CCTL_I2CSUSPCTL BIT(25) | ||
246 | +#define GI2CCTL_ACK BIT(24) | ||
247 | +#define GI2CCTL_I2CEN BIT(23) | ||
248 | +#define GI2CCTL_ADDR_MASK (0x7f << 16) | ||
249 | +#define GI2CCTL_ADDR_SHIFT 16 | ||
250 | +#define GI2CCTL_REGADDR_MASK (0xff << 8) | ||
251 | +#define GI2CCTL_REGADDR_SHIFT 8 | ||
252 | +#define GI2CCTL_RWDATA_MASK (0xff << 0) | ||
253 | +#define GI2CCTL_RWDATA_SHIFT 0 | ||
254 | + | ||
255 | +#define GPVNDCTL HSOTG_REG(0x0034) | ||
256 | +#define GGPIO HSOTG_REG(0x0038) | ||
257 | +#define GGPIO_STM32_OTG_GCCFG_PWRDWN BIT(16) | ||
258 | + | ||
259 | +#define GUID HSOTG_REG(0x003c) | ||
260 | +#define GSNPSID HSOTG_REG(0x0040) | ||
261 | +#define GHWCFG1 HSOTG_REG(0x0044) | ||
262 | +#define GSNPSID_ID_MASK GENMASK(31, 16) | ||
263 | + | ||
264 | +#define GHWCFG2 HSOTG_REG(0x0048) | ||
265 | +#define GHWCFG2_OTG_ENABLE_IC_USB BIT(31) | ||
266 | +#define GHWCFG2_DEV_TOKEN_Q_DEPTH_MASK (0x1f << 26) | ||
267 | +#define GHWCFG2_DEV_TOKEN_Q_DEPTH_SHIFT 26 | ||
268 | +#define GHWCFG2_HOST_PERIO_TX_Q_DEPTH_MASK (0x3 << 24) | ||
269 | +#define GHWCFG2_HOST_PERIO_TX_Q_DEPTH_SHIFT 24 | ||
270 | +#define GHWCFG2_NONPERIO_TX_Q_DEPTH_MASK (0x3 << 22) | ||
271 | +#define GHWCFG2_NONPERIO_TX_Q_DEPTH_SHIFT 22 | ||
272 | +#define GHWCFG2_MULTI_PROC_INT BIT(20) | ||
273 | +#define GHWCFG2_DYNAMIC_FIFO BIT(19) | ||
274 | +#define GHWCFG2_PERIO_EP_SUPPORTED BIT(18) | ||
275 | +#define GHWCFG2_NUM_HOST_CHAN_MASK (0xf << 14) | ||
276 | +#define GHWCFG2_NUM_HOST_CHAN_SHIFT 14 | ||
277 | +#define GHWCFG2_NUM_DEV_EP_MASK (0xf << 10) | ||
278 | +#define GHWCFG2_NUM_DEV_EP_SHIFT 10 | ||
279 | +#define GHWCFG2_FS_PHY_TYPE_MASK (0x3 << 8) | ||
280 | +#define GHWCFG2_FS_PHY_TYPE_SHIFT 8 | ||
281 | +#define GHWCFG2_FS_PHY_TYPE_NOT_SUPPORTED 0 | ||
282 | +#define GHWCFG2_FS_PHY_TYPE_DEDICATED 1 | ||
283 | +#define GHWCFG2_FS_PHY_TYPE_SHARED_UTMI 2 | ||
284 | +#define GHWCFG2_FS_PHY_TYPE_SHARED_ULPI 3 | ||
285 | +#define GHWCFG2_HS_PHY_TYPE_MASK (0x3 << 6) | ||
286 | +#define GHWCFG2_HS_PHY_TYPE_SHIFT 6 | ||
287 | +#define GHWCFG2_HS_PHY_TYPE_NOT_SUPPORTED 0 | ||
288 | +#define GHWCFG2_HS_PHY_TYPE_UTMI 1 | ||
289 | +#define GHWCFG2_HS_PHY_TYPE_ULPI 2 | ||
290 | +#define GHWCFG2_HS_PHY_TYPE_UTMI_ULPI 3 | ||
291 | +#define GHWCFG2_POINT2POINT BIT(5) | ||
292 | +#define GHWCFG2_ARCHITECTURE_MASK (0x3 << 3) | ||
293 | +#define GHWCFG2_ARCHITECTURE_SHIFT 3 | ||
294 | +#define GHWCFG2_SLAVE_ONLY_ARCH 0 | ||
295 | +#define GHWCFG2_EXT_DMA_ARCH 1 | ||
296 | +#define GHWCFG2_INT_DMA_ARCH 2 | ||
297 | +#define GHWCFG2_OP_MODE_MASK (0x7 << 0) | ||
298 | +#define GHWCFG2_OP_MODE_SHIFT 0 | ||
299 | +#define GHWCFG2_OP_MODE_HNP_SRP_CAPABLE 0 | ||
300 | +#define GHWCFG2_OP_MODE_SRP_ONLY_CAPABLE 1 | ||
301 | +#define GHWCFG2_OP_MODE_NO_HNP_SRP_CAPABLE 2 | ||
302 | +#define GHWCFG2_OP_MODE_SRP_CAPABLE_DEVICE 3 | ||
303 | +#define GHWCFG2_OP_MODE_NO_SRP_CAPABLE_DEVICE 4 | ||
304 | +#define GHWCFG2_OP_MODE_SRP_CAPABLE_HOST 5 | ||
305 | +#define GHWCFG2_OP_MODE_NO_SRP_CAPABLE_HOST 6 | ||
306 | +#define GHWCFG2_OP_MODE_UNDEFINED 7 | ||
307 | + | ||
308 | +#define GHWCFG3 HSOTG_REG(0x004c) | ||
309 | +#define GHWCFG3_DFIFO_DEPTH_MASK (0xffff << 16) | ||
310 | +#define GHWCFG3_DFIFO_DEPTH_SHIFT 16 | ||
311 | +#define GHWCFG3_OTG_LPM_EN BIT(15) | ||
312 | +#define GHWCFG3_BC_SUPPORT BIT(14) | ||
313 | +#define GHWCFG3_OTG_ENABLE_HSIC BIT(13) | ||
314 | +#define GHWCFG3_ADP_SUPP BIT(12) | ||
315 | +#define GHWCFG3_SYNCH_RESET_TYPE BIT(11) | ||
316 | +#define GHWCFG3_OPTIONAL_FEATURES BIT(10) | ||
317 | +#define GHWCFG3_VENDOR_CTRL_IF BIT(9) | ||
318 | +#define GHWCFG3_I2C BIT(8) | ||
319 | +#define GHWCFG3_OTG_FUNC BIT(7) | ||
320 | +#define GHWCFG3_PACKET_SIZE_CNTR_WIDTH_MASK (0x7 << 4) | ||
321 | +#define GHWCFG3_PACKET_SIZE_CNTR_WIDTH_SHIFT 4 | ||
322 | +#define GHWCFG3_XFER_SIZE_CNTR_WIDTH_MASK (0xf << 0) | ||
323 | +#define GHWCFG3_XFER_SIZE_CNTR_WIDTH_SHIFT 0 | ||
324 | + | ||
325 | +#define GHWCFG4 HSOTG_REG(0x0050) | ||
326 | +#define GHWCFG4_DESC_DMA_DYN BIT(31) | ||
327 | +#define GHWCFG4_DESC_DMA BIT(30) | ||
328 | +#define GHWCFG4_NUM_IN_EPS_MASK (0xf << 26) | ||
329 | +#define GHWCFG4_NUM_IN_EPS_SHIFT 26 | ||
330 | +#define GHWCFG4_DED_FIFO_EN BIT(25) | ||
331 | +#define GHWCFG4_DED_FIFO_SHIFT 25 | ||
332 | +#define GHWCFG4_SESSION_END_FILT_EN BIT(24) | ||
333 | +#define GHWCFG4_B_VALID_FILT_EN BIT(23) | ||
334 | +#define GHWCFG4_A_VALID_FILT_EN BIT(22) | ||
335 | +#define GHWCFG4_VBUS_VALID_FILT_EN BIT(21) | ||
336 | +#define GHWCFG4_IDDIG_FILT_EN BIT(20) | ||
337 | +#define GHWCFG4_NUM_DEV_MODE_CTRL_EP_MASK (0xf << 16) | ||
338 | +#define GHWCFG4_NUM_DEV_MODE_CTRL_EP_SHIFT 16 | ||
339 | +#define GHWCFG4_UTMI_PHY_DATA_WIDTH_MASK (0x3 << 14) | ||
340 | +#define GHWCFG4_UTMI_PHY_DATA_WIDTH_SHIFT 14 | ||
341 | +#define GHWCFG4_UTMI_PHY_DATA_WIDTH_8 0 | ||
342 | +#define GHWCFG4_UTMI_PHY_DATA_WIDTH_16 1 | ||
343 | +#define GHWCFG4_UTMI_PHY_DATA_WIDTH_8_OR_16 2 | ||
344 | +#define GHWCFG4_ACG_SUPPORTED BIT(12) | ||
345 | +#define GHWCFG4_IPG_ISOC_SUPPORTED BIT(11) | ||
346 | +#define GHWCFG4_SERVICE_INTERVAL_SUPPORTED BIT(10) | ||
347 | +#define GHWCFG4_XHIBER BIT(7) | ||
348 | +#define GHWCFG4_HIBER BIT(6) | ||
349 | +#define GHWCFG4_MIN_AHB_FREQ BIT(5) | ||
350 | +#define GHWCFG4_POWER_OPTIMIZ BIT(4) | ||
351 | +#define GHWCFG4_NUM_DEV_PERIO_IN_EP_MASK (0xf << 0) | ||
352 | +#define GHWCFG4_NUM_DEV_PERIO_IN_EP_SHIFT 0 | ||
353 | + | ||
354 | +#define GLPMCFG HSOTG_REG(0x0054) | ||
355 | +#define GLPMCFG_INVSELHSIC BIT(31) | ||
356 | +#define GLPMCFG_HSICCON BIT(30) | ||
357 | +#define GLPMCFG_RSTRSLPSTS BIT(29) | ||
358 | +#define GLPMCFG_ENBESL BIT(28) | ||
359 | +#define GLPMCFG_LPM_RETRYCNT_STS_MASK (0x7 << 25) | ||
360 | +#define GLPMCFG_LPM_RETRYCNT_STS_SHIFT 25 | ||
361 | +#define GLPMCFG_SNDLPM BIT(24) | ||
362 | +#define GLPMCFG_RETRY_CNT_MASK (0x7 << 21) | ||
363 | +#define GLPMCFG_RETRY_CNT_SHIFT 21 | ||
364 | +#define GLPMCFG_LPM_REJECT_CTRL_CONTROL BIT(21) | ||
365 | +#define GLPMCFG_LPM_ACCEPT_CTRL_ISOC BIT(22) | ||
366 | +#define GLPMCFG_LPM_CHNL_INDX_MASK (0xf << 17) | ||
367 | +#define GLPMCFG_LPM_CHNL_INDX_SHIFT 17 | ||
368 | +#define GLPMCFG_L1RESUMEOK BIT(16) | ||
369 | +#define GLPMCFG_SLPSTS BIT(15) | ||
370 | +#define GLPMCFG_COREL1RES_MASK (0x3 << 13) | ||
371 | +#define GLPMCFG_COREL1RES_SHIFT 13 | ||
372 | +#define GLPMCFG_HIRD_THRES_MASK (0x1f << 8) | ||
373 | +#define GLPMCFG_HIRD_THRES_SHIFT 8 | ||
374 | +#define GLPMCFG_HIRD_THRES_EN (0x10 << 8) | ||
375 | +#define GLPMCFG_ENBLSLPM BIT(7) | ||
376 | +#define GLPMCFG_BREMOTEWAKE BIT(6) | ||
377 | +#define GLPMCFG_HIRD_MASK (0xf << 2) | ||
378 | +#define GLPMCFG_HIRD_SHIFT 2 | ||
379 | +#define GLPMCFG_APPL1RES BIT(1) | ||
380 | +#define GLPMCFG_LPMCAP BIT(0) | ||
381 | + | ||
382 | +#define GPWRDN HSOTG_REG(0x0058) | ||
383 | +#define GPWRDN_MULT_VAL_ID_BC_MASK (0x1f << 24) | ||
384 | +#define GPWRDN_MULT_VAL_ID_BC_SHIFT 24 | ||
385 | +#define GPWRDN_ADP_INT BIT(23) | ||
386 | +#define GPWRDN_BSESSVLD BIT(22) | ||
387 | +#define GPWRDN_IDSTS BIT(21) | ||
388 | +#define GPWRDN_LINESTATE_MASK (0x3 << 19) | ||
389 | +#define GPWRDN_LINESTATE_SHIFT 19 | ||
390 | +#define GPWRDN_STS_CHGINT_MSK BIT(18) | ||
391 | +#define GPWRDN_STS_CHGINT BIT(17) | ||
392 | +#define GPWRDN_SRP_DET_MSK BIT(16) | ||
393 | +#define GPWRDN_SRP_DET BIT(15) | ||
394 | +#define GPWRDN_CONNECT_DET_MSK BIT(14) | ||
395 | +#define GPWRDN_CONNECT_DET BIT(13) | ||
396 | +#define GPWRDN_DISCONN_DET_MSK BIT(12) | ||
397 | +#define GPWRDN_DISCONN_DET BIT(11) | ||
398 | +#define GPWRDN_RST_DET_MSK BIT(10) | ||
399 | +#define GPWRDN_RST_DET BIT(9) | ||
400 | +#define GPWRDN_LNSTSCHG_MSK BIT(8) | ||
401 | +#define GPWRDN_LNSTSCHG BIT(7) | ||
402 | +#define GPWRDN_DIS_VBUS BIT(6) | ||
403 | +#define GPWRDN_PWRDNSWTCH BIT(5) | ||
404 | +#define GPWRDN_PWRDNRSTN BIT(4) | ||
405 | +#define GPWRDN_PWRDNCLMP BIT(3) | ||
406 | +#define GPWRDN_RESTORE BIT(2) | ||
407 | +#define GPWRDN_PMUACTV BIT(1) | ||
408 | +#define GPWRDN_PMUINTSEL BIT(0) | ||
409 | + | ||
410 | +#define GDFIFOCFG HSOTG_REG(0x005c) | ||
411 | +#define GDFIFOCFG_EPINFOBASE_MASK (0xffff << 16) | ||
412 | +#define GDFIFOCFG_EPINFOBASE_SHIFT 16 | ||
413 | +#define GDFIFOCFG_GDFIFOCFG_MASK (0xffff << 0) | ||
414 | +#define GDFIFOCFG_GDFIFOCFG_SHIFT 0 | ||
415 | + | ||
416 | +#define ADPCTL HSOTG_REG(0x0060) | ||
417 | +#define ADPCTL_AR_MASK (0x3 << 27) | ||
418 | +#define ADPCTL_AR_SHIFT 27 | ||
419 | +#define ADPCTL_ADP_TMOUT_INT_MSK BIT(26) | ||
420 | +#define ADPCTL_ADP_SNS_INT_MSK BIT(25) | ||
421 | +#define ADPCTL_ADP_PRB_INT_MSK BIT(24) | ||
422 | +#define ADPCTL_ADP_TMOUT_INT BIT(23) | ||
423 | +#define ADPCTL_ADP_SNS_INT BIT(22) | ||
424 | +#define ADPCTL_ADP_PRB_INT BIT(21) | ||
425 | +#define ADPCTL_ADPENA BIT(20) | ||
426 | +#define ADPCTL_ADPRES BIT(19) | ||
427 | +#define ADPCTL_ENASNS BIT(18) | ||
428 | +#define ADPCTL_ENAPRB BIT(17) | ||
429 | +#define ADPCTL_RTIM_MASK (0x7ff << 6) | ||
430 | +#define ADPCTL_RTIM_SHIFT 6 | ||
431 | +#define ADPCTL_PRB_PER_MASK (0x3 << 4) | ||
432 | +#define ADPCTL_PRB_PER_SHIFT 4 | ||
433 | +#define ADPCTL_PRB_DELTA_MASK (0x3 << 2) | ||
434 | +#define ADPCTL_PRB_DELTA_SHIFT 2 | ||
435 | +#define ADPCTL_PRB_DSCHRG_MASK (0x3 << 0) | ||
436 | +#define ADPCTL_PRB_DSCHRG_SHIFT 0 | ||
437 | + | ||
438 | +#define GREFCLK HSOTG_REG(0x0064) | ||
439 | +#define GREFCLK_REFCLKPER_MASK (0x1ffff << 15) | ||
440 | +#define GREFCLK_REFCLKPER_SHIFT 15 | ||
441 | +#define GREFCLK_REF_CLK_MODE BIT(14) | ||
442 | +#define GREFCLK_SOF_CNT_WKUP_ALERT_MASK (0x3ff) | ||
443 | +#define GREFCLK_SOF_CNT_WKUP_ALERT_SHIFT 0 | ||
444 | + | ||
445 | +#define GINTMSK2 HSOTG_REG(0x0068) | ||
446 | +#define GINTMSK2_WKUP_ALERT_INT_MSK BIT(0) | ||
447 | + | ||
448 | +#define GINTSTS2 HSOTG_REG(0x006c) | ||
449 | +#define GINTSTS2_WKUP_ALERT_INT BIT(0) | ||
450 | + | ||
451 | +#define HPTXFSIZ HSOTG_REG(0x100) | ||
452 | +/* Use FIFOSIZE_* constants to access this register */ | ||
453 | + | ||
454 | +#define DPTXFSIZN(_a) HSOTG_REG(0x104 + (((_a) - 1) * 4)) | ||
455 | +/* Use FIFOSIZE_* constants to access this register */ | ||
456 | + | ||
457 | +/* These apply to the GNPTXFSIZ, HPTXFSIZ and DPTXFSIZN registers */ | ||
458 | +#define FIFOSIZE_DEPTH_MASK (0xffff << 16) | ||
459 | +#define FIFOSIZE_DEPTH_SHIFT 16 | ||
460 | +#define FIFOSIZE_STARTADDR_MASK (0xffff << 0) | ||
461 | +#define FIFOSIZE_STARTADDR_SHIFT 0 | ||
462 | +#define FIFOSIZE_DEPTH_GET(_x) (((_x) >> 16) & 0xffff) | ||
463 | + | ||
464 | +/* Device mode registers */ | ||
465 | + | ||
466 | +#define DCFG HSOTG_REG(0x800) | ||
467 | +#define DCFG_DESCDMA_EN BIT(23) | ||
468 | +#define DCFG_EPMISCNT_MASK (0x1f << 18) | ||
469 | +#define DCFG_EPMISCNT_SHIFT 18 | ||
470 | +#define DCFG_EPMISCNT_LIMIT 0x1f | ||
471 | +#define DCFG_EPMISCNT(_x) ((_x) << 18) | ||
472 | +#define DCFG_IPG_ISOC_SUPPORDED BIT(17) | ||
473 | +#define DCFG_PERFRINT_MASK (0x3 << 11) | ||
474 | +#define DCFG_PERFRINT_SHIFT 11 | ||
475 | +#define DCFG_PERFRINT_LIMIT 0x3 | ||
476 | +#define DCFG_PERFRINT(_x) ((_x) << 11) | ||
477 | +#define DCFG_DEVADDR_MASK (0x7f << 4) | ||
478 | +#define DCFG_DEVADDR_SHIFT 4 | ||
479 | +#define DCFG_DEVADDR_LIMIT 0x7f | ||
480 | +#define DCFG_DEVADDR(_x) ((_x) << 4) | ||
481 | +#define DCFG_NZ_STS_OUT_HSHK BIT(2) | ||
482 | +#define DCFG_DEVSPD_MASK (0x3 << 0) | ||
483 | +#define DCFG_DEVSPD_SHIFT 0 | ||
484 | +#define DCFG_DEVSPD_HS 0 | ||
485 | +#define DCFG_DEVSPD_FS 1 | ||
486 | +#define DCFG_DEVSPD_LS 2 | ||
487 | +#define DCFG_DEVSPD_FS48 3 | ||
488 | + | ||
489 | +#define DCTL HSOTG_REG(0x804) | ||
490 | +#define DCTL_SERVICE_INTERVAL_SUPPORTED BIT(19) | ||
491 | +#define DCTL_PWRONPRGDONE BIT(11) | ||
492 | +#define DCTL_CGOUTNAK BIT(10) | ||
493 | +#define DCTL_SGOUTNAK BIT(9) | ||
494 | +#define DCTL_CGNPINNAK BIT(8) | ||
495 | +#define DCTL_SGNPINNAK BIT(7) | ||
496 | +#define DCTL_TSTCTL_MASK (0x7 << 4) | ||
497 | +#define DCTL_TSTCTL_SHIFT 4 | ||
498 | +#define DCTL_GOUTNAKSTS BIT(3) | ||
499 | +#define DCTL_GNPINNAKSTS BIT(2) | ||
500 | +#define DCTL_SFTDISCON BIT(1) | ||
501 | +#define DCTL_RMTWKUPSIG BIT(0) | ||
502 | + | ||
503 | +#define DSTS HSOTG_REG(0x808) | ||
504 | +#define DSTS_SOFFN_MASK (0x3fff << 8) | ||
505 | +#define DSTS_SOFFN_SHIFT 8 | ||
506 | +#define DSTS_SOFFN_LIMIT 0x3fff | ||
507 | +#define DSTS_SOFFN(_x) ((_x) << 8) | ||
508 | +#define DSTS_ERRATICERR BIT(3) | ||
509 | +#define DSTS_ENUMSPD_MASK (0x3 << 1) | ||
510 | +#define DSTS_ENUMSPD_SHIFT 1 | ||
511 | +#define DSTS_ENUMSPD_HS 0 | ||
512 | +#define DSTS_ENUMSPD_FS 1 | ||
513 | +#define DSTS_ENUMSPD_LS 2 | ||
514 | +#define DSTS_ENUMSPD_FS48 3 | ||
515 | +#define DSTS_SUSPSTS BIT(0) | ||
516 | + | ||
517 | +#define DIEPMSK HSOTG_REG(0x810) | ||
518 | +#define DIEPMSK_NAKMSK BIT(13) | ||
519 | +#define DIEPMSK_BNAININTRMSK BIT(9) | ||
520 | +#define DIEPMSK_TXFIFOUNDRNMSK BIT(8) | ||
521 | +#define DIEPMSK_TXFIFOEMPTY BIT(7) | ||
522 | +#define DIEPMSK_INEPNAKEFFMSK BIT(6) | ||
523 | +#define DIEPMSK_INTKNEPMISMSK BIT(5) | ||
524 | +#define DIEPMSK_INTKNTXFEMPMSK BIT(4) | ||
525 | +#define DIEPMSK_TIMEOUTMSK BIT(3) | ||
526 | +#define DIEPMSK_AHBERRMSK BIT(2) | ||
527 | +#define DIEPMSK_EPDISBLDMSK BIT(1) | ||
528 | +#define DIEPMSK_XFERCOMPLMSK BIT(0) | ||
529 | + | ||
530 | +#define DOEPMSK HSOTG_REG(0x814) | ||
531 | +#define DOEPMSK_BNAMSK BIT(9) | ||
532 | +#define DOEPMSK_BACK2BACKSETUP BIT(6) | ||
533 | +#define DOEPMSK_STSPHSERCVDMSK BIT(5) | ||
534 | +#define DOEPMSK_OUTTKNEPDISMSK BIT(4) | ||
535 | +#define DOEPMSK_SETUPMSK BIT(3) | ||
536 | +#define DOEPMSK_AHBERRMSK BIT(2) | ||
537 | +#define DOEPMSK_EPDISBLDMSK BIT(1) | ||
538 | +#define DOEPMSK_XFERCOMPLMSK BIT(0) | ||
539 | + | ||
540 | +#define DAINT HSOTG_REG(0x818) | ||
541 | +#define DAINTMSK HSOTG_REG(0x81C) | ||
542 | +#define DAINT_OUTEP_SHIFT 16 | ||
543 | +#define DAINT_OUTEP(_x) (1 << ((_x) + 16)) | ||
544 | +#define DAINT_INEP(_x) (1 << (_x)) | ||
545 | + | ||
546 | +#define DTKNQR1 HSOTG_REG(0x820) | ||
547 | +#define DTKNQR2 HSOTG_REG(0x824) | ||
548 | +#define DTKNQR3 HSOTG_REG(0x830) | ||
549 | +#define DTKNQR4 HSOTG_REG(0x834) | ||
550 | +#define DIEPEMPMSK HSOTG_REG(0x834) | ||
551 | + | ||
552 | +#define DVBUSDIS HSOTG_REG(0x828) | ||
553 | +#define DVBUSPULSE HSOTG_REG(0x82C) | ||
554 | + | ||
555 | +#define DIEPCTL0 HSOTG_REG(0x900) | ||
556 | +#define DIEPCTL(_a) HSOTG_REG(0x900 + ((_a) * 0x20)) | ||
557 | + | ||
558 | +#define DOEPCTL0 HSOTG_REG(0xB00) | ||
559 | +#define DOEPCTL(_a) HSOTG_REG(0xB00 + ((_a) * 0x20)) | ||
560 | + | ||
561 | +/* EP0 specialness: | ||
562 | + * bits[29..28] - reserved (no SetD0PID, SetD1PID) | ||
563 | + * bits[25..22] - should always be zero, this isn't a periodic endpoint | ||
564 | + * bits[10..0] - MPS setting different for EP0 | ||
565 | + */ | ||
566 | +#define D0EPCTL_MPS_MASK (0x3 << 0) | ||
567 | +#define D0EPCTL_MPS_SHIFT 0 | ||
568 | +#define D0EPCTL_MPS_64 0 | ||
569 | +#define D0EPCTL_MPS_32 1 | ||
570 | +#define D0EPCTL_MPS_16 2 | ||
571 | +#define D0EPCTL_MPS_8 3 | ||
572 | + | ||
573 | +#define DXEPCTL_EPENA BIT(31) | ||
574 | +#define DXEPCTL_EPDIS BIT(30) | ||
575 | +#define DXEPCTL_SETD1PID BIT(29) | ||
576 | +#define DXEPCTL_SETODDFR BIT(29) | ||
577 | +#define DXEPCTL_SETD0PID BIT(28) | ||
578 | +#define DXEPCTL_SETEVENFR BIT(28) | ||
579 | +#define DXEPCTL_SNAK BIT(27) | ||
580 | +#define DXEPCTL_CNAK BIT(26) | ||
581 | +#define DXEPCTL_TXFNUM_MASK (0xf << 22) | ||
582 | +#define DXEPCTL_TXFNUM_SHIFT 22 | ||
583 | +#define DXEPCTL_TXFNUM_LIMIT 0xf | ||
584 | +#define DXEPCTL_TXFNUM(_x) ((_x) << 22) | ||
585 | +#define DXEPCTL_STALL BIT(21) | ||
586 | +#define DXEPCTL_SNP BIT(20) | ||
587 | +#define DXEPCTL_EPTYPE_MASK (0x3 << 18) | ||
588 | +#define DXEPCTL_EPTYPE_CONTROL (0x0 << 18) | ||
589 | +#define DXEPCTL_EPTYPE_ISO (0x1 << 18) | ||
590 | +#define DXEPCTL_EPTYPE_BULK (0x2 << 18) | ||
591 | +#define DXEPCTL_EPTYPE_INTERRUPT (0x3 << 18) | ||
592 | + | ||
593 | +#define DXEPCTL_NAKSTS BIT(17) | ||
594 | +#define DXEPCTL_DPID BIT(16) | ||
595 | +#define DXEPCTL_EOFRNUM BIT(16) | ||
596 | +#define DXEPCTL_USBACTEP BIT(15) | ||
597 | +#define DXEPCTL_NEXTEP_MASK (0xf << 11) | ||
598 | +#define DXEPCTL_NEXTEP_SHIFT 11 | ||
599 | +#define DXEPCTL_NEXTEP_LIMIT 0xf | ||
600 | +#define DXEPCTL_NEXTEP(_x) ((_x) << 11) | ||
601 | +#define DXEPCTL_MPS_MASK (0x7ff << 0) | ||
602 | +#define DXEPCTL_MPS_SHIFT 0 | ||
603 | +#define DXEPCTL_MPS_LIMIT 0x7ff | ||
604 | +#define DXEPCTL_MPS(_x) ((_x) << 0) | ||
605 | + | ||
606 | +#define DIEPINT(_a) HSOTG_REG(0x908 + ((_a) * 0x20)) | ||
607 | +#define DOEPINT(_a) HSOTG_REG(0xB08 + ((_a) * 0x20)) | ||
608 | +#define DXEPINT_SETUP_RCVD BIT(15) | ||
609 | +#define DXEPINT_NYETINTRPT BIT(14) | ||
610 | +#define DXEPINT_NAKINTRPT BIT(13) | ||
611 | +#define DXEPINT_BBLEERRINTRPT BIT(12) | ||
612 | +#define DXEPINT_PKTDRPSTS BIT(11) | ||
613 | +#define DXEPINT_BNAINTR BIT(9) | ||
614 | +#define DXEPINT_TXFIFOUNDRN BIT(8) | ||
615 | +#define DXEPINT_OUTPKTERR BIT(8) | ||
616 | +#define DXEPINT_TXFEMP BIT(7) | ||
617 | +#define DXEPINT_INEPNAKEFF BIT(6) | ||
618 | +#define DXEPINT_BACK2BACKSETUP BIT(6) | ||
619 | +#define DXEPINT_INTKNEPMIS BIT(5) | ||
620 | +#define DXEPINT_STSPHSERCVD BIT(5) | ||
621 | +#define DXEPINT_INTKNTXFEMP BIT(4) | ||
622 | +#define DXEPINT_OUTTKNEPDIS BIT(4) | ||
623 | +#define DXEPINT_TIMEOUT BIT(3) | ||
624 | +#define DXEPINT_SETUP BIT(3) | ||
625 | +#define DXEPINT_AHBERR BIT(2) | ||
626 | +#define DXEPINT_EPDISBLD BIT(1) | ||
627 | +#define DXEPINT_XFERCOMPL BIT(0) | ||
628 | + | ||
629 | +#define DIEPTSIZ0 HSOTG_REG(0x910) | ||
630 | +#define DIEPTSIZ0_PKTCNT_MASK (0x3 << 19) | ||
631 | +#define DIEPTSIZ0_PKTCNT_SHIFT 19 | ||
632 | +#define DIEPTSIZ0_PKTCNT_LIMIT 0x3 | ||
633 | +#define DIEPTSIZ0_PKTCNT(_x) ((_x) << 19) | ||
634 | +#define DIEPTSIZ0_XFERSIZE_MASK (0x7f << 0) | ||
635 | +#define DIEPTSIZ0_XFERSIZE_SHIFT 0 | ||
636 | +#define DIEPTSIZ0_XFERSIZE_LIMIT 0x7f | ||
637 | +#define DIEPTSIZ0_XFERSIZE(_x) ((_x) << 0) | ||
638 | + | ||
639 | +#define DOEPTSIZ0 HSOTG_REG(0xB10) | ||
640 | +#define DOEPTSIZ0_SUPCNT_MASK (0x3 << 29) | ||
641 | +#define DOEPTSIZ0_SUPCNT_SHIFT 29 | ||
642 | +#define DOEPTSIZ0_SUPCNT_LIMIT 0x3 | ||
643 | +#define DOEPTSIZ0_SUPCNT(_x) ((_x) << 29) | ||
644 | +#define DOEPTSIZ0_PKTCNT BIT(19) | ||
645 | +#define DOEPTSIZ0_XFERSIZE_MASK (0x7f << 0) | ||
646 | +#define DOEPTSIZ0_XFERSIZE_SHIFT 0 | ||
647 | + | ||
648 | +#define DIEPTSIZ(_a) HSOTG_REG(0x910 + ((_a) * 0x20)) | ||
649 | +#define DOEPTSIZ(_a) HSOTG_REG(0xB10 + ((_a) * 0x20)) | ||
650 | +#define DXEPTSIZ_MC_MASK (0x3 << 29) | ||
651 | +#define DXEPTSIZ_MC_SHIFT 29 | ||
652 | +#define DXEPTSIZ_MC_LIMIT 0x3 | ||
653 | +#define DXEPTSIZ_MC(_x) ((_x) << 29) | ||
654 | +#define DXEPTSIZ_PKTCNT_MASK (0x3ff << 19) | ||
655 | +#define DXEPTSIZ_PKTCNT_SHIFT 19 | ||
656 | +#define DXEPTSIZ_PKTCNT_LIMIT 0x3ff | ||
657 | +#define DXEPTSIZ_PKTCNT_GET(_v) (((_v) >> 19) & 0x3ff) | ||
658 | +#define DXEPTSIZ_PKTCNT(_x) ((_x) << 19) | ||
659 | +#define DXEPTSIZ_XFERSIZE_MASK (0x7ffff << 0) | ||
660 | +#define DXEPTSIZ_XFERSIZE_SHIFT 0 | ||
661 | +#define DXEPTSIZ_XFERSIZE_LIMIT 0x7ffff | ||
662 | +#define DXEPTSIZ_XFERSIZE_GET(_v) (((_v) >> 0) & 0x7ffff) | ||
663 | +#define DXEPTSIZ_XFERSIZE(_x) ((_x) << 0) | ||
664 | + | ||
665 | +#define DIEPDMA(_a) HSOTG_REG(0x914 + ((_a) * 0x20)) | ||
666 | +#define DOEPDMA(_a) HSOTG_REG(0xB14 + ((_a) * 0x20)) | ||
667 | + | ||
668 | +#define DTXFSTS(_a) HSOTG_REG(0x918 + ((_a) * 0x20)) | ||
669 | + | ||
670 | +#define PCGCTL HSOTG_REG(0x0e00) | ||
671 | +#define PCGCTL_IF_DEV_MODE BIT(31) | ||
672 | +#define PCGCTL_P2HD_PRT_SPD_MASK (0x3 << 29) | ||
673 | +#define PCGCTL_P2HD_PRT_SPD_SHIFT 29 | ||
674 | +#define PCGCTL_P2HD_DEV_ENUM_SPD_MASK (0x3 << 27) | ||
675 | +#define PCGCTL_P2HD_DEV_ENUM_SPD_SHIFT 27 | ||
676 | +#define PCGCTL_MAC_DEV_ADDR_MASK (0x7f << 20) | ||
677 | +#define PCGCTL_MAC_DEV_ADDR_SHIFT 20 | ||
678 | +#define PCGCTL_MAX_TERMSEL BIT(19) | ||
679 | +#define PCGCTL_MAX_XCVRSELECT_MASK (0x3 << 17) | ||
680 | +#define PCGCTL_MAX_XCVRSELECT_SHIFT 17 | ||
681 | +#define PCGCTL_PORT_POWER BIT(16) | ||
682 | +#define PCGCTL_PRT_CLK_SEL_MASK (0x3 << 14) | ||
683 | +#define PCGCTL_PRT_CLK_SEL_SHIFT 14 | ||
684 | +#define PCGCTL_ESS_REG_RESTORED BIT(13) | ||
685 | +#define PCGCTL_EXTND_HIBER_SWITCH BIT(12) | ||
686 | +#define PCGCTL_EXTND_HIBER_PWRCLMP BIT(11) | ||
687 | +#define PCGCTL_ENBL_EXTND_HIBER BIT(10) | ||
688 | +#define PCGCTL_RESTOREMODE BIT(9) | ||
689 | +#define PCGCTL_RESETAFTSUSP BIT(8) | ||
690 | +#define PCGCTL_DEEP_SLEEP BIT(7) | ||
691 | +#define PCGCTL_PHY_IN_SLEEP BIT(6) | ||
692 | +#define PCGCTL_ENBL_SLEEP_GATING BIT(5) | ||
693 | +#define PCGCTL_RSTPDWNMODULE BIT(3) | ||
694 | +#define PCGCTL_PWRCLMP BIT(2) | ||
695 | +#define PCGCTL_GATEHCLK BIT(1) | ||
696 | +#define PCGCTL_STOPPCLK BIT(0) | ||
697 | + | ||
698 | +#define PCGCCTL1 HSOTG_REG(0xe04) | ||
699 | +#define PCGCCTL1_TIMER (0x3 << 1) | ||
700 | +#define PCGCCTL1_GATEEN BIT(0) | ||
701 | + | ||
702 | +#define EPFIFO(_a) HSOTG_REG(0x1000 + ((_a) * 0x1000)) | ||
703 | + | ||
704 | +/* Host Mode Registers */ | ||
705 | + | ||
706 | +#define HCFG HSOTG_REG(0x0400) | ||
707 | +#define HCFG_MODECHTIMEN BIT(31) | ||
708 | +#define HCFG_PERSCHEDENA BIT(26) | ||
709 | +#define HCFG_FRLISTEN_MASK (0x3 << 24) | ||
710 | +#define HCFG_FRLISTEN_SHIFT 24 | ||
711 | +#define HCFG_FRLISTEN_8 (0 << 24) | ||
712 | +#define FRLISTEN_8_SIZE 8 | ||
713 | +#define HCFG_FRLISTEN_16 BIT(24) | ||
714 | +#define FRLISTEN_16_SIZE 16 | ||
715 | +#define HCFG_FRLISTEN_32 (2 << 24) | ||
716 | +#define FRLISTEN_32_SIZE 32 | ||
717 | +#define HCFG_FRLISTEN_64 (3 << 24) | ||
718 | +#define FRLISTEN_64_SIZE 64 | ||
719 | +#define HCFG_DESCDMA BIT(23) | ||
720 | +#define HCFG_RESVALID_MASK (0xff << 8) | ||
721 | +#define HCFG_RESVALID_SHIFT 8 | ||
722 | +#define HCFG_ENA32KHZ BIT(7) | ||
723 | +#define HCFG_FSLSSUPP BIT(2) | ||
724 | +#define HCFG_FSLSPCLKSEL_MASK (0x3 << 0) | ||
725 | +#define HCFG_FSLSPCLKSEL_SHIFT 0 | ||
726 | +#define HCFG_FSLSPCLKSEL_30_60_MHZ 0 | ||
727 | +#define HCFG_FSLSPCLKSEL_48_MHZ 1 | ||
728 | +#define HCFG_FSLSPCLKSEL_6_MHZ 2 | ||
729 | + | ||
730 | +#define HFIR HSOTG_REG(0x0404) | ||
731 | +#define HFIR_FRINT_MASK (0xffff << 0) | ||
732 | +#define HFIR_FRINT_SHIFT 0 | ||
733 | +#define HFIR_RLDCTRL BIT(16) | ||
734 | + | ||
735 | +#define HFNUM HSOTG_REG(0x0408) | ||
736 | +#define HFNUM_FRREM_MASK (0xffff << 16) | ||
737 | +#define HFNUM_FRREM_SHIFT 16 | ||
738 | +#define HFNUM_FRNUM_MASK (0xffff << 0) | ||
739 | +#define HFNUM_FRNUM_SHIFT 0 | ||
740 | +#define HFNUM_MAX_FRNUM 0x3fff | ||
741 | + | ||
742 | +#define HPTXSTS HSOTG_REG(0x0410) | ||
743 | +#define TXSTS_QTOP_ODD BIT(31) | ||
744 | +#define TXSTS_QTOP_CHNEP_MASK (0xf << 27) | ||
745 | +#define TXSTS_QTOP_CHNEP_SHIFT 27 | ||
746 | +#define TXSTS_QTOP_TOKEN_MASK (0x3 << 25) | ||
747 | +#define TXSTS_QTOP_TOKEN_SHIFT 25 | ||
748 | +#define TXSTS_QTOP_TERMINATE BIT(24) | ||
749 | +#define TXSTS_QSPCAVAIL_MASK (0xff << 16) | ||
750 | +#define TXSTS_QSPCAVAIL_SHIFT 16 | ||
751 | +#define TXSTS_FSPCAVAIL_MASK (0xffff << 0) | ||
752 | +#define TXSTS_FSPCAVAIL_SHIFT 0 | ||
753 | + | ||
754 | +#define HAINT HSOTG_REG(0x0414) | ||
755 | +#define HAINTMSK HSOTG_REG(0x0418) | ||
756 | +#define HFLBADDR HSOTG_REG(0x041c) | ||
757 | + | ||
758 | +#define HPRT0 HSOTG_REG(0x0440) | ||
759 | +#define HPRT0_SPD_MASK (0x3 << 17) | ||
760 | +#define HPRT0_SPD_SHIFT 17 | ||
761 | +#define HPRT0_SPD_HIGH_SPEED 0 | ||
762 | +#define HPRT0_SPD_FULL_SPEED 1 | ||
763 | +#define HPRT0_SPD_LOW_SPEED 2 | ||
764 | +#define HPRT0_TSTCTL_MASK (0xf << 13) | ||
765 | +#define HPRT0_TSTCTL_SHIFT 13 | ||
766 | +#define HPRT0_PWR BIT(12) | ||
767 | +#define HPRT0_LNSTS_MASK (0x3 << 10) | ||
768 | +#define HPRT0_LNSTS_SHIFT 10 | ||
769 | +#define HPRT0_RST BIT(8) | ||
770 | +#define HPRT0_SUSP BIT(7) | ||
771 | +#define HPRT0_RES BIT(6) | ||
772 | +#define HPRT0_OVRCURRCHG BIT(5) | ||
773 | +#define HPRT0_OVRCURRACT BIT(4) | ||
774 | +#define HPRT0_ENACHG BIT(3) | ||
775 | +#define HPRT0_ENA BIT(2) | ||
776 | +#define HPRT0_CONNDET BIT(1) | ||
777 | +#define HPRT0_CONNSTS BIT(0) | ||
778 | + | ||
779 | +#define HCCHAR(_ch) HSOTG_REG(0x0500 + 0x20 * (_ch)) | ||
780 | +#define HCCHAR_CHENA BIT(31) | ||
781 | +#define HCCHAR_CHDIS BIT(30) | ||
782 | +#define HCCHAR_ODDFRM BIT(29) | ||
783 | +#define HCCHAR_DEVADDR_MASK (0x7f << 22) | ||
784 | +#define HCCHAR_DEVADDR_SHIFT 22 | ||
785 | +#define HCCHAR_MULTICNT_MASK (0x3 << 20) | ||
786 | +#define HCCHAR_MULTICNT_SHIFT 20 | ||
787 | +#define HCCHAR_EPTYPE_MASK (0x3 << 18) | ||
788 | +#define HCCHAR_EPTYPE_SHIFT 18 | ||
789 | +#define HCCHAR_LSPDDEV BIT(17) | ||
790 | +#define HCCHAR_EPDIR BIT(15) | ||
791 | +#define HCCHAR_EPNUM_MASK (0xf << 11) | ||
792 | +#define HCCHAR_EPNUM_SHIFT 11 | ||
793 | +#define HCCHAR_MPS_MASK (0x7ff << 0) | ||
794 | +#define HCCHAR_MPS_SHIFT 0 | ||
795 | + | ||
796 | +#define HCSPLT(_ch) HSOTG_REG(0x0504 + 0x20 * (_ch)) | ||
797 | +#define HCSPLT_SPLTENA BIT(31) | ||
798 | +#define HCSPLT_COMPSPLT BIT(16) | ||
799 | +#define HCSPLT_XACTPOS_MASK (0x3 << 14) | ||
800 | +#define HCSPLT_XACTPOS_SHIFT 14 | ||
801 | +#define HCSPLT_XACTPOS_MID 0 | ||
802 | +#define HCSPLT_XACTPOS_END 1 | ||
803 | +#define HCSPLT_XACTPOS_BEGIN 2 | ||
804 | +#define HCSPLT_XACTPOS_ALL 3 | ||
805 | +#define HCSPLT_HUBADDR_MASK (0x7f << 7) | ||
806 | +#define HCSPLT_HUBADDR_SHIFT 7 | ||
807 | +#define HCSPLT_PRTADDR_MASK (0x7f << 0) | ||
808 | +#define HCSPLT_PRTADDR_SHIFT 0 | ||
809 | + | ||
810 | +#define HCINT(_ch) HSOTG_REG(0x0508 + 0x20 * (_ch)) | ||
811 | +#define HCINTMSK(_ch) HSOTG_REG(0x050c + 0x20 * (_ch)) | ||
812 | +#define HCINTMSK_RESERVED14_31 (0x3ffff << 14) | ||
813 | +#define HCINTMSK_FRM_LIST_ROLL BIT(13) | ||
814 | +#define HCINTMSK_XCS_XACT BIT(12) | ||
815 | +#define HCINTMSK_BNA BIT(11) | ||
816 | +#define HCINTMSK_DATATGLERR BIT(10) | ||
817 | +#define HCINTMSK_FRMOVRUN BIT(9) | ||
818 | +#define HCINTMSK_BBLERR BIT(8) | ||
819 | +#define HCINTMSK_XACTERR BIT(7) | ||
820 | +#define HCINTMSK_NYET BIT(6) | ||
821 | +#define HCINTMSK_ACK BIT(5) | ||
822 | +#define HCINTMSK_NAK BIT(4) | ||
823 | +#define HCINTMSK_STALL BIT(3) | ||
824 | +#define HCINTMSK_AHBERR BIT(2) | ||
825 | +#define HCINTMSK_CHHLTD BIT(1) | ||
826 | +#define HCINTMSK_XFERCOMPL BIT(0) | ||
827 | + | ||
828 | +#define HCTSIZ(_ch) HSOTG_REG(0x0510 + 0x20 * (_ch)) | ||
829 | +#define TSIZ_DOPNG BIT(31) | ||
830 | +#define TSIZ_SC_MC_PID_MASK (0x3 << 29) | ||
831 | +#define TSIZ_SC_MC_PID_SHIFT 29 | ||
832 | +#define TSIZ_SC_MC_PID_DATA0 0 | ||
833 | +#define TSIZ_SC_MC_PID_DATA2 1 | ||
834 | +#define TSIZ_SC_MC_PID_DATA1 2 | ||
835 | +#define TSIZ_SC_MC_PID_MDATA 3 | ||
836 | +#define TSIZ_SC_MC_PID_SETUP 3 | ||
837 | +#define TSIZ_PKTCNT_MASK (0x3ff << 19) | ||
838 | +#define TSIZ_PKTCNT_SHIFT 19 | ||
839 | +#define TSIZ_NTD_MASK (0xff << 8) | ||
840 | +#define TSIZ_NTD_SHIFT 8 | ||
841 | +#define TSIZ_SCHINFO_MASK (0xff << 0) | ||
842 | +#define TSIZ_SCHINFO_SHIFT 0 | ||
843 | +#define TSIZ_XFERSIZE_MASK (0x7ffff << 0) | ||
844 | +#define TSIZ_XFERSIZE_SHIFT 0 | ||
845 | + | ||
846 | +#define HCDMA(_ch) HSOTG_REG(0x0514 + 0x20 * (_ch)) | ||
847 | + | ||
848 | +#define HCDMAB(_ch) HSOTG_REG(0x051c + 0x20 * (_ch)) | ||
849 | + | ||
850 | +#define HCFIFO(_ch) HSOTG_REG(0x1000 + 0x1000 * (_ch)) | ||
851 | + | ||
852 | +/** | ||
853 | + * struct dwc2_dma_desc - DMA descriptor structure, | ||
854 | + * used for both host and gadget modes | ||
855 | + * | ||
856 | + * @status: DMA descriptor status quadlet | ||
857 | + * @buf: DMA descriptor data buffer pointer | ||
858 | + * | ||
859 | + * DMA Descriptor structure contains two quadlets: | ||
860 | + * Status quadlet and Data buffer pointer. | ||
861 | + */ | ||
862 | +struct dwc2_dma_desc { | ||
863 | + uint32_t status; | ||
864 | + uint32_t buf; | ||
865 | +} __packed; | ||
866 | + | ||
867 | +/* Host Mode DMA descriptor status quadlet */ | ||
868 | + | ||
869 | +#define HOST_DMA_A BIT(31) | ||
870 | +#define HOST_DMA_STS_MASK (0x3 << 28) | ||
871 | +#define HOST_DMA_STS_SHIFT 28 | ||
872 | +#define HOST_DMA_STS_PKTERR BIT(28) | ||
873 | +#define HOST_DMA_EOL BIT(26) | ||
874 | +#define HOST_DMA_IOC BIT(25) | ||
875 | +#define HOST_DMA_SUP BIT(24) | ||
876 | +#define HOST_DMA_ALT_QTD BIT(23) | ||
877 | +#define HOST_DMA_QTD_OFFSET_MASK (0x3f << 17) | ||
878 | +#define HOST_DMA_QTD_OFFSET_SHIFT 17 | ||
879 | +#define HOST_DMA_ISOC_NBYTES_MASK (0xfff << 0) | ||
880 | +#define HOST_DMA_ISOC_NBYTES_SHIFT 0 | ||
881 | +#define HOST_DMA_NBYTES_MASK (0x1ffff << 0) | ||
882 | +#define HOST_DMA_NBYTES_SHIFT 0 | ||
883 | +#define HOST_DMA_NBYTES_LIMIT 131071 | ||
884 | + | ||
885 | +/* Device Mode DMA descriptor status quadlet */ | ||
886 | + | ||
887 | +#define DEV_DMA_BUFF_STS_MASK (0x3 << 30) | ||
888 | +#define DEV_DMA_BUFF_STS_SHIFT 30 | ||
889 | +#define DEV_DMA_BUFF_STS_HREADY 0 | ||
890 | +#define DEV_DMA_BUFF_STS_DMABUSY 1 | ||
891 | +#define DEV_DMA_BUFF_STS_DMADONE 2 | ||
892 | +#define DEV_DMA_BUFF_STS_HBUSY 3 | ||
893 | +#define DEV_DMA_STS_MASK (0x3 << 28) | ||
894 | +#define DEV_DMA_STS_SHIFT 28 | ||
895 | +#define DEV_DMA_STS_SUCC 0 | ||
896 | +#define DEV_DMA_STS_BUFF_FLUSH 1 | ||
897 | +#define DEV_DMA_STS_BUFF_ERR 3 | ||
898 | +#define DEV_DMA_L BIT(27) | ||
899 | +#define DEV_DMA_SHORT BIT(26) | ||
900 | +#define DEV_DMA_IOC BIT(25) | ||
901 | +#define DEV_DMA_SR BIT(24) | ||
902 | +#define DEV_DMA_MTRF BIT(23) | ||
903 | +#define DEV_DMA_ISOC_PID_MASK (0x3 << 23) | ||
904 | +#define DEV_DMA_ISOC_PID_SHIFT 23 | ||
905 | +#define DEV_DMA_ISOC_PID_DATA0 0 | ||
906 | +#define DEV_DMA_ISOC_PID_DATA2 1 | ||
907 | +#define DEV_DMA_ISOC_PID_DATA1 2 | ||
908 | +#define DEV_DMA_ISOC_PID_MDATA 3 | ||
909 | +#define DEV_DMA_ISOC_FRNUM_MASK (0x7ff << 12) | ||
910 | +#define DEV_DMA_ISOC_FRNUM_SHIFT 12 | ||
911 | +#define DEV_DMA_ISOC_TX_NBYTES_MASK (0xfff << 0) | ||
912 | +#define DEV_DMA_ISOC_TX_NBYTES_LIMIT 0xfff | ||
913 | +#define DEV_DMA_ISOC_RX_NBYTES_MASK (0x7ff << 0) | ||
914 | +#define DEV_DMA_ISOC_RX_NBYTES_LIMIT 0x7ff | ||
915 | +#define DEV_DMA_ISOC_NBYTES_SHIFT 0 | ||
916 | +#define DEV_DMA_NBYTES_MASK (0xffff << 0) | ||
917 | +#define DEV_DMA_NBYTES_SHIFT 0 | ||
918 | +#define DEV_DMA_NBYTES_LIMIT 0xffff | ||
919 | + | ||
920 | +#define MAX_DMA_DESC_NUM_GENERIC 64 | ||
921 | +#define MAX_DMA_DESC_NUM_HS_ISOC 256 | ||
922 | + | ||
923 | +#endif /* __DWC2_HW_H__ */ | ||
924 | -- | ||
925 | 2.20.1 | ||
926 | |||
927 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Paul Zimmerman <pauldzim@gmail.com> | ||
2 | 1 | ||
3 | Add the dwc-hsotg (dwc2) USB host controller state definitions. | ||
4 | Mostly based on hw/usb/hcd-ehci.h. | ||
5 | |||
6 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | ||
7 | Message-id: 20200520235349.21215-4-pauldzim@gmail.com | ||
8 | Reviewed-by: Peter Maydell <peter.maydell@linaro.org> | ||
9 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
10 | --- | ||
11 | hw/usb/hcd-dwc2.h | 190 ++++++++++++++++++++++++++++++++++++++++++++++ | ||
12 | 1 file changed, 190 insertions(+) | ||
13 | create mode 100644 hw/usb/hcd-dwc2.h | ||
14 | |||
15 | diff --git a/hw/usb/hcd-dwc2.h b/hw/usb/hcd-dwc2.h | ||
16 | new file mode 100644 | ||
17 | index XXXXXXX..XXXXXXX | ||
18 | --- /dev/null | ||
19 | +++ b/hw/usb/hcd-dwc2.h | ||
20 | @@ -XXX,XX +XXX,XX @@ | ||
21 | +/* | ||
22 | + * dwc-hsotg (dwc2) USB host controller state definitions | ||
23 | + * | ||
24 | + * Based on hw/usb/hcd-ehci.h | ||
25 | + * | ||
26 | + * Copyright (c) 2020 Paul Zimmerman <pauldzim@gmail.com> | ||
27 | + * | ||
28 | + * This program is free software; you can redistribute it and/or modify | ||
29 | + * it under the terms of the GNU General Public License as published by | ||
30 | + * the Free Software Foundation; either version 2 of the License, or | ||
31 | + * (at your option) any later version. | ||
32 | + * | ||
33 | + * This program is distributed in the hope that it will be useful, | ||
34 | + * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
35 | + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
36 | + * GNU General Public License for more details. | ||
37 | + */ | ||
38 | + | ||
39 | +#ifndef HW_USB_DWC2_H | ||
40 | +#define HW_USB_DWC2_H | ||
41 | + | ||
42 | +#include "qemu/timer.h" | ||
43 | +#include "hw/irq.h" | ||
44 | +#include "hw/sysbus.h" | ||
45 | +#include "hw/usb.h" | ||
46 | +#include "sysemu/dma.h" | ||
47 | + | ||
48 | +#define DWC2_MMIO_SIZE 0x11000 | ||
49 | + | ||
50 | +#define DWC2_NB_CHAN 8 /* Number of host channels */ | ||
51 | +#define DWC2_MAX_XFER_SIZE 65536 /* Max transfer size expected in HCTSIZ */ | ||
52 | + | ||
53 | +typedef struct DWC2Packet DWC2Packet; | ||
54 | +typedef struct DWC2State DWC2State; | ||
55 | +typedef struct DWC2Class DWC2Class; | ||
56 | + | ||
57 | +enum async_state { | ||
58 | + DWC2_ASYNC_NONE = 0, | ||
59 | + DWC2_ASYNC_INITIALIZED, | ||
60 | + DWC2_ASYNC_INFLIGHT, | ||
61 | + DWC2_ASYNC_FINISHED, | ||
62 | +}; | ||
63 | + | ||
64 | +struct DWC2Packet { | ||
65 | + USBPacket packet; | ||
66 | + uint32_t devadr; | ||
67 | + uint32_t epnum; | ||
68 | + uint32_t epdir; | ||
69 | + uint32_t mps; | ||
70 | + uint32_t pid; | ||
71 | + uint32_t index; | ||
72 | + uint32_t pcnt; | ||
73 | + uint32_t len; | ||
74 | + int32_t async; | ||
75 | + bool small; | ||
76 | + bool needs_service; | ||
77 | +}; | ||
78 | + | ||
79 | +struct DWC2State { | ||
80 | + /*< private >*/ | ||
81 | + SysBusDevice parent_obj; | ||
82 | + | ||
83 | + /*< public >*/ | ||
84 | + USBBus bus; | ||
85 | + qemu_irq irq; | ||
86 | + MemoryRegion *dma_mr; | ||
87 | + AddressSpace dma_as; | ||
88 | + MemoryRegion container; | ||
89 | + MemoryRegion hsotg; | ||
90 | + MemoryRegion fifos; | ||
91 | + | ||
92 | + union { | ||
93 | +#define DWC2_GLBREG_SIZE 0x70 | ||
94 | + uint32_t glbreg[DWC2_GLBREG_SIZE / sizeof(uint32_t)]; | ||
95 | + struct { | ||
96 | + uint32_t gotgctl; /* 00 */ | ||
97 | + uint32_t gotgint; /* 04 */ | ||
98 | + uint32_t gahbcfg; /* 08 */ | ||
99 | + uint32_t gusbcfg; /* 0c */ | ||
100 | + uint32_t grstctl; /* 10 */ | ||
101 | + uint32_t gintsts; /* 14 */ | ||
102 | + uint32_t gintmsk; /* 18 */ | ||
103 | + uint32_t grxstsr; /* 1c */ | ||
104 | + uint32_t grxstsp; /* 20 */ | ||
105 | + uint32_t grxfsiz; /* 24 */ | ||
106 | + uint32_t gnptxfsiz; /* 28 */ | ||
107 | + uint32_t gnptxsts; /* 2c */ | ||
108 | + uint32_t gi2cctl; /* 30 */ | ||
109 | + uint32_t gpvndctl; /* 34 */ | ||
110 | + uint32_t ggpio; /* 38 */ | ||
111 | + uint32_t guid; /* 3c */ | ||
112 | + uint32_t gsnpsid; /* 40 */ | ||
113 | + uint32_t ghwcfg1; /* 44 */ | ||
114 | + uint32_t ghwcfg2; /* 48 */ | ||
115 | + uint32_t ghwcfg3; /* 4c */ | ||
116 | + uint32_t ghwcfg4; /* 50 */ | ||
117 | + uint32_t glpmcfg; /* 54 */ | ||
118 | + uint32_t gpwrdn; /* 58 */ | ||
119 | + uint32_t gdfifocfg; /* 5c */ | ||
120 | + uint32_t gadpctl; /* 60 */ | ||
121 | + uint32_t grefclk; /* 64 */ | ||
122 | + uint32_t gintmsk2; /* 68 */ | ||
123 | + uint32_t gintsts2; /* 6c */ | ||
124 | + }; | ||
125 | + }; | ||
126 | + | ||
127 | + union { | ||
128 | +#define DWC2_FSZREG_SIZE 0x04 | ||
129 | + uint32_t fszreg[DWC2_FSZREG_SIZE / sizeof(uint32_t)]; | ||
130 | + struct { | ||
131 | + uint32_t hptxfsiz; /* 100 */ | ||
132 | + }; | ||
133 | + }; | ||
134 | + | ||
135 | + union { | ||
136 | +#define DWC2_HREG0_SIZE 0x44 | ||
137 | + uint32_t hreg0[DWC2_HREG0_SIZE / sizeof(uint32_t)]; | ||
138 | + struct { | ||
139 | + uint32_t hcfg; /* 400 */ | ||
140 | + uint32_t hfir; /* 404 */ | ||
141 | + uint32_t hfnum; /* 408 */ | ||
142 | + uint32_t rsvd0; /* 40c */ | ||
143 | + uint32_t hptxsts; /* 410 */ | ||
144 | + uint32_t haint; /* 414 */ | ||
145 | + uint32_t haintmsk; /* 418 */ | ||
146 | + uint32_t hflbaddr; /* 41c */ | ||
147 | + uint32_t rsvd1[8]; /* 420-43c */ | ||
148 | + uint32_t hprt0; /* 440 */ | ||
149 | + }; | ||
150 | + }; | ||
151 | + | ||
152 | +#define DWC2_HREG1_SIZE (0x20 * DWC2_NB_CHAN) | ||
153 | + uint32_t hreg1[DWC2_HREG1_SIZE / sizeof(uint32_t)]; | ||
154 | + | ||
155 | +#define hcchar(_ch) hreg1[((_ch) << 3) + 0] /* 500, 520, ... */ | ||
156 | +#define hcsplt(_ch) hreg1[((_ch) << 3) + 1] /* 504, 524, ... */ | ||
157 | +#define hcint(_ch) hreg1[((_ch) << 3) + 2] /* 508, 528, ... */ | ||
158 | +#define hcintmsk(_ch) hreg1[((_ch) << 3) + 3] /* 50c, 52c, ... */ | ||
159 | +#define hctsiz(_ch) hreg1[((_ch) << 3) + 4] /* 510, 530, ... */ | ||
160 | +#define hcdma(_ch) hreg1[((_ch) << 3) + 5] /* 514, 534, ... */ | ||
161 | +#define hcdmab(_ch) hreg1[((_ch) << 3) + 7] /* 51c, 53c, ... */ | ||
162 | + | ||
163 | + union { | ||
164 | +#define DWC2_PCGREG_SIZE 0x08 | ||
165 | + uint32_t pcgreg[DWC2_PCGREG_SIZE / sizeof(uint32_t)]; | ||
166 | + struct { | ||
167 | + uint32_t pcgctl; /* e00 */ | ||
168 | + uint32_t pcgcctl1; /* e04 */ | ||
169 | + }; | ||
170 | + }; | ||
171 | + | ||
172 | + /* TODO - implement FIFO registers for slave mode */ | ||
173 | +#define DWC2_HFIFO_SIZE (0x1000 * DWC2_NB_CHAN) | ||
174 | + | ||
175 | + /* | ||
176 | + * Internal state | ||
177 | + */ | ||
178 | + QEMUTimer *eof_timer; | ||
179 | + QEMUTimer *frame_timer; | ||
180 | + QEMUBH *async_bh; | ||
181 | + int64_t sof_time; | ||
182 | + int64_t usb_frame_time; | ||
183 | + int64_t usb_bit_time; | ||
184 | + uint32_t usb_version; | ||
185 | + uint16_t frame_number; | ||
186 | + uint16_t fi; | ||
187 | + uint16_t next_chan; | ||
188 | + bool working; | ||
189 | + USBPort uport; | ||
190 | + DWC2Packet packet[DWC2_NB_CHAN]; /* one packet per chan */ | ||
191 | + uint8_t usb_buf[DWC2_NB_CHAN][DWC2_MAX_XFER_SIZE]; /* one buffer per chan */ | ||
192 | +}; | ||
193 | + | ||
194 | +struct DWC2Class { | ||
195 | + /*< private >*/ | ||
196 | + SysBusDeviceClass parent_class; | ||
197 | + ResettablePhases parent_phases; | ||
198 | + | ||
199 | + /*< public >*/ | ||
200 | +}; | ||
201 | + | ||
202 | +#define TYPE_DWC2_USB "dwc2-usb" | ||
203 | +#define DWC2_USB(obj) \ | ||
204 | + OBJECT_CHECK(DWC2State, (obj), TYPE_DWC2_USB) | ||
205 | +#define DWC2_CLASS(klass) \ | ||
206 | + OBJECT_CLASS_CHECK(DWC2Class, (klass), TYPE_DWC2_USB) | ||
207 | +#define DWC2_GET_CLASS(obj) \ | ||
208 | + OBJECT_GET_CLASS(DWC2Class, (obj), TYPE_DWC2_USB) | ||
209 | + | ||
210 | +#endif | ||
211 | -- | ||
212 | 2.20.1 | ||
213 | |||
214 | diff view generated by jsdifflib |
Deleted patch | |||
---|---|---|---|
1 | From: Paul Zimmerman <pauldzim@gmail.com> | ||
2 | 1 | ||
3 | The dwc-hsotg (dwc2) USB host depends on a short packet to | ||
4 | indicate the end of an IN transfer. The usb-storage driver | ||
5 | currently doesn't provide this, so fix it. | ||
6 | |||
7 | I have tested this change rather extensively using a PC | ||
8 | emulation with xhci, ehci, and uhci controllers, and have | ||
9 | not observed any regressions. | ||
10 | |||
11 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | ||
12 | Message-id: 20200520235349.21215-6-pauldzim@gmail.com | ||
13 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | ||
14 | --- | ||
15 | hw/usb/dev-storage.c | 15 ++++++++++++++- | ||
16 | 1 file changed, 14 insertions(+), 1 deletion(-) | ||
17 | |||
18 | diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c | ||
19 | index XXXXXXX..XXXXXXX 100644 | ||
20 | --- a/hw/usb/dev-storage.c | ||
21 | +++ b/hw/usb/dev-storage.c | ||
22 | @@ -XXX,XX +XXX,XX @@ static void usb_msd_copy_data(MSDState *s, USBPacket *p) | ||
23 | usb_packet_copy(p, scsi_req_get_buf(s->req) + s->scsi_off, len); | ||
24 | s->scsi_len -= len; | ||
25 | s->scsi_off += len; | ||
26 | + if (len > s->data_len) { | ||
27 | + len = s->data_len; | ||
28 | + } | ||
29 | s->data_len -= len; | ||
30 | if (s->scsi_len == 0 || s->data_len == 0) { | ||
31 | scsi_req_continue(s->req); | ||
32 | @@ -XXX,XX +XXX,XX @@ static void usb_msd_command_complete(SCSIRequest *req, uint32_t status, size_t r | ||
33 | if (s->data_len) { | ||
34 | int len = (p->iov.size - p->actual_length); | ||
35 | usb_packet_skip(p, len); | ||
36 | + if (len > s->data_len) { | ||
37 | + len = s->data_len; | ||
38 | + } | ||
39 | s->data_len -= len; | ||
40 | } | ||
41 | if (s->data_len == 0) { | ||
42 | @@ -XXX,XX +XXX,XX @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p) | ||
43 | int len = p->iov.size - p->actual_length; | ||
44 | if (len) { | ||
45 | usb_packet_skip(p, len); | ||
46 | + if (len > s->data_len) { | ||
47 | + len = s->data_len; | ||
48 | + } | ||
49 | s->data_len -= len; | ||
50 | if (s->data_len == 0) { | ||
51 | s->mode = USB_MSDM_CSW; | ||
52 | @@ -XXX,XX +XXX,XX @@ static void usb_msd_handle_data(USBDevice *dev, USBPacket *p) | ||
53 | int len = p->iov.size - p->actual_length; | ||
54 | if (len) { | ||
55 | usb_packet_skip(p, len); | ||
56 | + if (len > s->data_len) { | ||
57 | + len = s->data_len; | ||
58 | + } | ||
59 | s->data_len -= len; | ||
60 | if (s->data_len == 0) { | ||
61 | s->mode = USB_MSDM_CSW; | ||
62 | } | ||
63 | } | ||
64 | } | ||
65 | - if (p->actual_length < p->iov.size) { | ||
66 | + if (p->actual_length < p->iov.size && (p->short_not_ok || | ||
67 | + s->scsi_len >= p->ep->max_packet_size)) { | ||
68 | DPRINTF("Deferring packet %p [wait data-in]\n", p); | ||
69 | s->packet = p; | ||
70 | p->status = USB_RET_ASYNC; | ||
71 | -- | ||
72 | 2.20.1 | ||
73 | |||
74 | diff view generated by jsdifflib |
1 | From: Paul Zimmerman <pauldzim@gmail.com> | 1 | From: Joe Komlodi <joe.komlodi@xilinx.com> |
---|---|---|---|
2 | 2 | ||
3 | Wire the dwc-hsotg (dwc2) emulation into Qemu | 3 | Numonyx chips determine the number of cycles to wait based on bits 7:4 |
4 | in the volatile configuration register. | ||
4 | 5 | ||
5 | Signed-off-by: Paul Zimmerman <pauldzim@gmail.com> | 6 | However, if these bits are 0x0 or 0xF, the number of dummy cycles to |
6 | Reviewed-by: Philippe Mathieu-Daude <f4bug@amsat.org> | 7 | wait is 10 for QIOR and QIOR4 commands or when in QIO mode, and otherwise 8 for |
7 | Message-id: 20200520235349.21215-7-pauldzim@gmail.com | 8 | the currently supported fast read commands. [1] |
9 | |||
10 | [1] | ||
11 | https://www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_02g_cbb_0.pdf?rev=9b167fbf2b3645efba6385949a72e453 | ||
12 | |||
13 | Signed-off-by: Joe Komlodi <komlodi@xilinx.com> | ||
14 | Reviewed-by: Francisco Iglesias <francisco.iglesias@xilinx.com> | ||
15 | Message-id: 1605568264-26376-5-git-send-email-komlodi@xilinx.com | ||
8 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> | 16 | Signed-off-by: Peter Maydell <peter.maydell@linaro.org> |
9 | --- | 17 | --- |
10 | include/hw/arm/bcm2835_peripherals.h | 3 ++- | 18 | hw/block/m25p80.c | 30 +++++++++++++++++++++++++++--- |
11 | hw/arm/bcm2835_peripherals.c | 21 ++++++++++++++++++++- | 19 | 1 file changed, 27 insertions(+), 3 deletions(-) |
12 | 2 files changed, 22 insertions(+), 2 deletions(-) | ||
13 | 20 | ||
14 | diff --git a/include/hw/arm/bcm2835_peripherals.h b/include/hw/arm/bcm2835_peripherals.h | 21 | diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c |
15 | index XXXXXXX..XXXXXXX 100644 | 22 | index XXXXXXX..XXXXXXX 100644 |
16 | --- a/include/hw/arm/bcm2835_peripherals.h | 23 | --- a/hw/block/m25p80.c |
17 | +++ b/include/hw/arm/bcm2835_peripherals.h | 24 | +++ b/hw/block/m25p80.c |
18 | @@ -XXX,XX +XXX,XX @@ | 25 | @@ -XXX,XX +XXX,XX @@ static uint8_t numonyx_mode(Flash *s) |
19 | #include "hw/sd/bcm2835_sdhost.h" | 26 | } |
20 | #include "hw/gpio/bcm2835_gpio.h" | 27 | } |
21 | #include "hw/timer/bcm2835_systmr.h" | 28 | |
22 | +#include "hw/usb/hcd-dwc2.h" | 29 | +static uint8_t numonyx_extract_cfg_num_dummies(Flash *s) |
23 | #include "hw/misc/unimp.h" | 30 | +{ |
24 | 31 | + uint8_t num_dummies; | |
25 | #define TYPE_BCM2835_PERIPHERALS "bcm2835-peripherals" | 32 | + uint8_t mode; |
26 | @@ -XXX,XX +XXX,XX @@ typedef struct BCM2835PeripheralState { | 33 | + assert(get_man(s) == MAN_NUMONYX); |
27 | UnimplementedDeviceState ave0; | ||
28 | UnimplementedDeviceState bscsl; | ||
29 | UnimplementedDeviceState smi; | ||
30 | - UnimplementedDeviceState dwc2; | ||
31 | + DWC2State dwc2; | ||
32 | UnimplementedDeviceState sdramc; | ||
33 | } BCM2835PeripheralState; | ||
34 | |||
35 | diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c | ||
36 | index XXXXXXX..XXXXXXX 100644 | ||
37 | --- a/hw/arm/bcm2835_peripherals.c | ||
38 | +++ b/hw/arm/bcm2835_peripherals.c | ||
39 | @@ -XXX,XX +XXX,XX @@ static void bcm2835_peripherals_init(Object *obj) | ||
40 | /* Mphi */ | ||
41 | sysbus_init_child_obj(obj, "mphi", &s->mphi, sizeof(s->mphi), | ||
42 | TYPE_BCM2835_MPHI); | ||
43 | + | 34 | + |
44 | + /* DWC2 */ | 35 | + mode = numonyx_mode(s); |
45 | + sysbus_init_child_obj(obj, "dwc2", &s->dwc2, sizeof(s->dwc2), | 36 | + num_dummies = extract32(s->volatile_cfg, 4, 4); |
46 | + TYPE_DWC2_USB); | ||
47 | + | 37 | + |
48 | + object_property_add_const_link(OBJECT(&s->dwc2), "dma-mr", | 38 | + if (num_dummies == 0x0 || num_dummies == 0xf) { |
49 | + OBJECT(&s->gpu_bus_mr)); | 39 | + switch (s->cmd_in_progress) { |
50 | } | 40 | + case QIOR: |
51 | 41 | + case QIOR4: | |
52 | static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) | 42 | + num_dummies = 10; |
53 | @@ -XXX,XX +XXX,XX @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) | 43 | + break; |
54 | qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, | 44 | + default: |
55 | INTERRUPT_HOSTPORT)); | 45 | + num_dummies = (mode == MODE_QIO) ? 10 : 8; |
56 | 46 | + break; | |
57 | + /* DWC2 */ | 47 | + } |
58 | + object_property_set_bool(OBJECT(&s->dwc2), true, "realized", &err); | ||
59 | + if (err) { | ||
60 | + error_propagate(errp, err); | ||
61 | + return; | ||
62 | + } | 48 | + } |
63 | + | 49 | + |
64 | + memory_region_add_subregion(&s->peri_mr, USB_OTG_OFFSET, | 50 | + return num_dummies; |
65 | + sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->dwc2), 0)); | 51 | +} |
66 | + sysbus_connect_irq(SYS_BUS_DEVICE(&s->dwc2), 0, | ||
67 | + qdev_get_gpio_in_named(DEVICE(&s->ic), BCM2835_IC_GPU_IRQ, | ||
68 | + INTERRUPT_USB)); | ||
69 | + | 52 | + |
70 | create_unimp(s, &s->armtmr, "bcm2835-sp804", ARMCTRL_TIMER0_1_OFFSET, 0x40); | 53 | static void decode_fast_read_cmd(Flash *s) |
71 | create_unimp(s, &s->cprman, "bcm2835-cprman", CPRMAN_OFFSET, 0x1000); | 54 | { |
72 | create_unimp(s, &s->a2w, "bcm2835-a2w", A2W_OFFSET, 0x1000); | 55 | s->needed_bytes = get_addr_length(s); |
73 | @@ -XXX,XX +XXX,XX @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) | 56 | @@ -XXX,XX +XXX,XX @@ static void decode_fast_read_cmd(Flash *s) |
74 | create_unimp(s, &s->otp, "bcm2835-otp", OTP_OFFSET, 0x80); | 57 | s->needed_bytes += 8; |
75 | create_unimp(s, &s->dbus, "bcm2835-dbus", DBUS_OFFSET, 0x8000); | 58 | break; |
76 | create_unimp(s, &s->ave0, "bcm2835-ave0", AVE0_OFFSET, 0x8000); | 59 | case MAN_NUMONYX: |
77 | - create_unimp(s, &s->dwc2, "dwc-usb2", USB_OTG_OFFSET, 0x1000); | 60 | - s->needed_bytes += extract32(s->volatile_cfg, 4, 4); |
78 | create_unimp(s, &s->sdramc, "bcm2835-sdramc", SDRAMC_OFFSET, 0x100); | 61 | + s->needed_bytes += numonyx_extract_cfg_num_dummies(s); |
79 | } | 62 | break; |
80 | 63 | case MAN_MACRONIX: | |
64 | if (extract32(s->volatile_cfg, 6, 2) == 1) { | ||
65 | @@ -XXX,XX +XXX,XX @@ static void decode_dio_read_cmd(Flash *s) | ||
66 | ); | ||
67 | break; | ||
68 | case MAN_NUMONYX: | ||
69 | - s->needed_bytes += extract32(s->volatile_cfg, 4, 4); | ||
70 | + s->needed_bytes += numonyx_extract_cfg_num_dummies(s); | ||
71 | break; | ||
72 | case MAN_MACRONIX: | ||
73 | switch (extract32(s->volatile_cfg, 6, 2)) { | ||
74 | @@ -XXX,XX +XXX,XX @@ static void decode_qio_read_cmd(Flash *s) | ||
75 | ); | ||
76 | break; | ||
77 | case MAN_NUMONYX: | ||
78 | - s->needed_bytes += extract32(s->volatile_cfg, 4, 4); | ||
79 | + s->needed_bytes += numonyx_extract_cfg_num_dummies(s); | ||
80 | break; | ||
81 | case MAN_MACRONIX: | ||
82 | switch (extract32(s->volatile_cfg, 6, 2)) { | ||
81 | -- | 83 | -- |
82 | 2.20.1 | 84 | 2.20.1 |
83 | 85 | ||
84 | 86 | diff view generated by jsdifflib |