[PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)

Alex Bennée posted 14 patches 3 years, 10 months ago
Test docker-mingw@fedora passed
Test checkpatch failed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200605154929.26910-1-alex.bennee@linaro.org
include/qemu/qemu-plugin.h             |  1 +
exec.c                                 |  8 ++-
hw/virtio/vhost.c                      | 57 +++++++++++++++------
linux-user/elfload.c                   | 71 ++++++++++++++++++++++----
linux-user/mmap.c                      |  2 +-
tests/plugin/mem.c                     |  2 +-
tests/tcg/arm/commpage.c               | 61 ++++++++++++++++++++++
.shippable.yml                         | 12 ++---
.travis.yml                            |  5 ++
hw/virtio/trace-events                 |  3 +-
scripts/clean-includes                 |  1 +
tests/docker/Makefile.include          |  2 +-
tests/docker/dockerfiles/ubuntu.docker |  2 +-
tests/qemu-iotests/194                 | 10 ++++
tests/qemu-iotests/194.out             |  5 ++
tests/tcg/arm/Makefile.target          |  2 +
16 files changed, 206 insertions(+), 38 deletions(-)
create mode 100644 tests/tcg/arm/commpage.c
[PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Posted by Alex Bennée 3 years, 10 months ago
Hi,

These are all the patches I've currently got which are ready for a
pull request next week. I've included some patches which are destined
to go in via other trees so I can keep the testing green on the CI.

In summary:

 Some simple plugin cleanups (the reset remain in plugins/next)
 Reliability fixes for travis/shippable
 iotest 194 fix (going in via block tree?)
 docker updates (ubuntu and tricore fix)
 vhost-user and TCG fix
 more linux-user guest_base fixes

I'll certainly include the testing stuff in my PR but if others are
happy for me to include bits touching their areas then shout and I'll
include them in the PR.

The following need review:

 - linux-user: detect overflow of MAP_FIXED mmap
 - linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
 - linux-user: provide fallback pgd_find_hole for bare chroots
 - tests/docker: fix pre-requisite for debian-tricore-cross
 - hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
 - .shippable: temporaily disable some cross builds
 - exec: flush the whole TLB if a watchpoint crosses a page boundary

Alex Bennée (10):
  tests/plugin: correctly honour io_count
  exec: flush the whole TLB if a watchpoint crosses a page boundary
  .travis.yml: allow failure for unreliable hosts
  .shippable: temporaily disable some cross builds
  tests/docker: fix pre-requisite for debian-tricore-cross
  hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
  linux-user: provide fallback pgd_find_hole for bare chroots
  linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
  tests/tcg: add simple commpage test case
  linux-user: detect overflow of MAP_FIXED mmap

Emilio G. Cota (1):
  qemu-plugin.h: add missing include <stddef.h> to define size_t

Paolo Bonzini (1):
  docker: update Ubuntu to 20.04

Philippe Mathieu-Daudé (1):
  scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

Vladimir Sementsov-Ogievskiy (1):
  iotests: 194: wait migration completion on target too

 include/qemu/qemu-plugin.h             |  1 +
 exec.c                                 |  8 ++-
 hw/virtio/vhost.c                      | 57 +++++++++++++++------
 linux-user/elfload.c                   | 71 ++++++++++++++++++++++----
 linux-user/mmap.c                      |  2 +-
 tests/plugin/mem.c                     |  2 +-
 tests/tcg/arm/commpage.c               | 61 ++++++++++++++++++++++
 .shippable.yml                         | 12 ++---
 .travis.yml                            |  5 ++
 hw/virtio/trace-events                 |  3 +-
 scripts/clean-includes                 |  1 +
 tests/docker/Makefile.include          |  2 +-
 tests/docker/dockerfiles/ubuntu.docker |  2 +-
 tests/qemu-iotests/194                 | 10 ++++
 tests/qemu-iotests/194.out             |  5 ++
 tests/tcg/arm/Makefile.target          |  2 +
 16 files changed, 206 insertions(+), 38 deletions(-)
 create mode 100644 tests/tcg/arm/commpage.c

-- 
2.20.1


Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Posted by Thomas Huth 3 years, 10 months ago
On 05/06/2020 17.49, Alex Bennée wrote:
> Hi,
> 
> These are all the patches I've currently got which are ready for a
> pull request next week. I've included some patches which are destined
> to go in via other trees so I can keep the testing green on the CI.
> 
> In summary:
> 
>  Some simple plugin cleanups (the reset remain in plugins/next)
>  Reliability fixes for travis/shippable
>  iotest 194 fix (going in via block tree?)
>  docker updates (ubuntu and tricore fix)
>  vhost-user and TCG fix
>  more linux-user guest_base fixes
> 
> I'll certainly include the testing stuff in my PR but if others are
> happy for me to include bits touching their areas then shout and I'll
> include them in the PR.
> 
> The following need review:
> 
>  - linux-user: detect overflow of MAP_FIXED mmap
>  - linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
>  - linux-user: provide fallback pgd_find_hole for bare chroots
>  - tests/docker: fix pre-requisite for debian-tricore-cross
>  - hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
>  - .shippable: temporaily disable some cross builds
>  - exec: flush the whole TLB if a watchpoint crosses a page boundary
> 
> Alex Bennée (10):
>   tests/plugin: correctly honour io_count
>   exec: flush the whole TLB if a watchpoint crosses a page boundary
>   .travis.yml: allow failure for unreliable hosts
>   .shippable: temporaily disable some cross builds
>   tests/docker: fix pre-requisite for debian-tricore-cross
>   hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
>   linux-user: provide fallback pgd_find_hole for bare chroots
>   linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
>   tests/tcg: add simple commpage test case
>   linux-user: detect overflow of MAP_FIXED mmap
> 
> Emilio G. Cota (1):
>   qemu-plugin.h: add missing include <stddef.h> to define size_t
> 
> Paolo Bonzini (1):
>   docker: update Ubuntu to 20.04
> 
> Philippe Mathieu-Daudé (1):
>   scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

What about Philippe's "tests: Remove unused bison/flex packages" v2
patch series from May 15th? I think you could include it here, too.

 Thomas


Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Posted by Alex Bennée 3 years, 10 months ago
Thomas Huth <thuth@redhat.com> writes:

> On 05/06/2020 17.49, Alex Bennée wrote:
>> Hi,
>> 
>> These are all the patches I've currently got which are ready for a
>> pull request next week. I've included some patches which are destined
>> to go in via other trees so I can keep the testing green on the CI.
>> 
>> In summary:
>> 
>>  Some simple plugin cleanups (the reset remain in plugins/next)
>>  Reliability fixes for travis/shippable
>>  iotest 194 fix (going in via block tree?)
>>  docker updates (ubuntu and tricore fix)
>>  vhost-user and TCG fix
>>  more linux-user guest_base fixes
>> 
>> I'll certainly include the testing stuff in my PR but if others are
>> happy for me to include bits touching their areas then shout and I'll
>> include them in the PR.
>> 
>> The following need review:
>> 
>>  - linux-user: detect overflow of MAP_FIXED mmap
>>  - linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
>>  - linux-user: provide fallback pgd_find_hole for bare chroots
>>  - tests/docker: fix pre-requisite for debian-tricore-cross
>>  - hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
>>  - .shippable: temporaily disable some cross builds
>>  - exec: flush the whole TLB if a watchpoint crosses a page boundary
>> 
>> Alex Bennée (10):
>>   tests/plugin: correctly honour io_count
>>   exec: flush the whole TLB if a watchpoint crosses a page boundary
>>   .travis.yml: allow failure for unreliable hosts
>>   .shippable: temporaily disable some cross builds
>>   tests/docker: fix pre-requisite for debian-tricore-cross
>>   hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
>>   linux-user: provide fallback pgd_find_hole for bare chroots
>>   linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
>>   tests/tcg: add simple commpage test case
>>   linux-user: detect overflow of MAP_FIXED mmap
>> 
>> Emilio G. Cota (1):
>>   qemu-plugin.h: add missing include <stddef.h> to define size_t
>> 
>> Paolo Bonzini (1):
>>   docker: update Ubuntu to 20.04
>> 
>> Philippe Mathieu-Daudé (1):
>>   scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header
>
> What about Philippe's "tests: Remove unused bison/flex packages" v2
> patch series from May 15th? I think you could include it here, too.

Sure - grabbed.

-- 
Alex Bennée

Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Posted by Eric Blake 3 years, 10 months ago
On 6/5/20 10:49 AM, Alex Bennée wrote:
> Hi,
> 
> These are all the patches I've currently got which are ready for a
> pull request next week. I've included some patches which are destined
> to go in via other trees so I can keep the testing green on the CI.
> 
> In summary:
> 
>   Some simple plugin cleanups (the reset remain in plugins/next)
>   Reliability fixes for travis/shippable
>   iotest 194 fix (going in via block tree?)

I've got that one queued for a PR Monday with some typo fixes included.

>   docker updates (ubuntu and tricore fix)
>   vhost-user and TCG fix
>   more linux-user guest_base fixes
> 
> I'll certainly include the testing stuff in my PR but if others are
> happy for me to include bits touching their areas then shout and I'll
> include them in the PR.
> 
> The following need review:
> 
>   - linux-user: detect overflow of MAP_FIXED mmap
>   - linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
>   - linux-user: provide fallback pgd_find_hole for bare chroots
>   - tests/docker: fix pre-requisite for debian-tricore-cross
>   - hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
>   - .shippable: temporaily disable some cross builds
>   - exec: flush the whole TLB if a watchpoint crosses a page boundary
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


Re: [PATCH v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Posted by no-reply@patchew.org 3 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20200605154929.26910-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200605154929.26910-1-alex.bennee@linaro.org
Subject: [PATCH  v1 00/14] various fixes for next PR (testing, vhost, guest_base fixes)
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200605165007.12095-1-peter.maydell@linaro.org -> patchew/20200605165007.12095-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200605165656.17578-1-philmd@redhat.com -> patchew/20200605165656.17578-1-philmd@redhat.com
Auto packing the repository for optimum performance. You may also
run "git gc" manually. See "git help gc" for more information.
Switched to a new branch 'test'
8c192c8 linux-user: detect overflow of MAP_FIXED mmap
343b114 tests/tcg: add simple commpage test case
3ea9b6b linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
bd10df6 linux-user: provide fallback pgd_find_hole for bare chroots
140a4b0 hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE
c3fdeb9 docker: update Ubuntu to 20.04
3827a17 tests/docker: fix pre-requisite for debian-tricore-cross
00ba0df iotests: 194: wait migration completion on target too
8252e14 .shippable: temporaily disable some cross builds
1027a95 .travis.yml: allow failure for unreliable hosts
d545513 exec: flush the whole TLB if a watchpoint crosses a page boundary
c286730 tests/plugin: correctly honour io_count
573745f scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header
592de76 qemu-plugin.h: add missing include <stddef.h> to define size_t

=== OUTPUT BEGIN ===
1/14 Checking commit 592de76606a7 (qemu-plugin.h: add missing include <stddef.h> to define size_t)
2/14 Checking commit 573745fa77cd (scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header)
3/14 Checking commit c286730e2e6a (tests/plugin: correctly honour io_count)
4/14 Checking commit d545513f07b5 (exec: flush the whole TLB if a watchpoint crosses a page boundary)
5/14 Checking commit 1027a95a2300 (.travis.yml: allow failure for unreliable hosts)
6/14 Checking commit 8252e1457d91 (.shippable: temporaily disable some cross builds)
7/14 Checking commit 00ba0dfa3911 (iotests: 194: wait migration completion on target too)
8/14 Checking commit 3827a17199bf (tests/docker: fix pre-requisite for debian-tricore-cross)
9/14 Checking commit c3fdeb9b0a44 (docker: update Ubuntu to 20.04)
10/14 Checking commit 140a4b0c679f (hw/virtio/vhost: re-factor vhost-section and allow DIRTY_MEMORY_CODE)
11/14 Checking commit bd10df6e7aff (linux-user: provide fallback pgd_find_hole for bare chroots)
WARNING: line over 80 characters
#46: FILE: linux-user/elfload.c:2116:
+static uintptr_t pgd_find_hole_fallback(uintptr_t guest_size, uintptr_t brk, long align)

total: 0 errors, 1 warnings, 60 lines checked

Patch 11/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/14 Checking commit 3ea9b6bac8e8 (linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit)
13/14 Checking commit 343b11418044 (tests/tcg: add simple commpage test case)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

ERROR: Use of volatile is usually wrong, please add a comment
#59: FILE: tests/tcg/arm/commpage.c:25:
+typedef int (cmpxchg_fn)(int oldval, int newval, volatile int *ptr);

ERROR: Use of volatile is usually wrong, please add a comment
#65: FILE: tests/tcg/arm/commpage.c:31:
+                           volatile int64_t *ptr);

total: 2 errors, 1 warnings, 69 lines checked

Patch 13/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/14 Checking commit 8c192c8751c3 (linux-user: detect overflow of MAP_FIXED mmap)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200605154929.26910-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com