Gerd Hoffmann (2):
  qdev: add support for device module loading
  vga: build qxl as module

 Makefile.objs            |  1 +
 Makefile.target          |  7 ++++++
 include/hw/qdev-core.h   |  3 +++
 include/qemu/module.h    |  1 +
 hw/core/qdev.c           | 49 ++++++++++++++++++++++++++++++++++++++++
 qdev-monitor.c           |  5 ++++
 hw/Makefile.objs         |  1 +
 hw/display/Makefile.objs |  4 +++-
 8 files changed, 70 insertions(+), 1 deletion(-)

-- 
2.18.4

Patchew URL: https://patchew.org/QEMU/20200604075943.7001-1-kraxel@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

Not run: 259
Failures: 127 267
Failed 2 of 119 iotests
make: *** [check-tests/check-block.sh] Error 1
Traceback (most recent call last):
  File "./tests/docker/docker.py", line 665, in <module>
    sys.exit(main())
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=91aa49358c8d4cdeb8843c69db56e178', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-pqbrir70/src/docker-src.2020-06-04-04.07.03.28898:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=91aa49358c8d4cdeb8843c69db56e178
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-pqbrir70/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    16m33.652s
user    0m9.001s


The full log is available at
http://patchew.org/logs/20200604075943.7001-1-kraxel@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200604075943.7001-1-kraxel@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===

  GEN     docs/interop/qemu-qmp-ref.7
In file included from /tmp/qemu-test/src/hw/display/qxl.h:10,
                 from /tmp/qemu-test/src/hw/display/qxl.c:37:
/tmp/qemu-test/src/include/ui/spice-display.h:21:10: fatal error: spice.h: No such file or directory
 #include <spice.h>
          ^~~~~~~~~
compilation terminated.
In file included from /tmp/qemu-test/src/hw/display/qxl.h:10,
                 from /tmp/qemu-test/src/hw/display/qxl-logger.c:24:
/tmp/qemu-test/src/include/ui/spice-display.h:21:10: fatal error: spice.h: No such file or directory
 #include <spice.h>
          ^~~~~~~~~
compilation terminated.
  AS      pc-bios/optionrom/multiboot.o
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/display/qxl.o] Error 1
make: *** Waiting for unfinished jobs....
  AS      pc-bios/optionrom/linuxboot.o
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/display/qxl-logger.o] Error 1
  CC      pc-bios/optionrom/linuxboot_dma.o
  AS      pc-bios/optionrom/kvmvapic.o
  AS      pc-bios/optionrom/pvh.o
---
  BUILD   pc-bios/optionrom/multiboot.img
In file included from /tmp/qemu-test/src/hw/display/qxl.h:10,
                 from /tmp/qemu-test/src/hw/display/qxl-render.c:23:
/tmp/qemu-test/src/include/ui/spice-display.h:21:10: fatal error: spice.h: No such file or directory
 #include <spice.h>
          ^~~~~~~~~
compilation terminated.
make: *** [/tmp/qemu-test/src/rules.mak:69: hw/display/qxl-render.o] Error 1
  BUILD   pc-bios/optionrom/linuxboot.img
  BUILD   pc-bios/optionrom/kvmvapic.img
  BUILD   pc-bios/optionrom/multiboot.raw
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=412fc17a4ab84b92b93a64f6f7c3365d', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-ef12sg7p/src/docker-src.2020-06-04-04.25.07.24568:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=412fc17a4ab84b92b93a64f6f7c3365d
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-ef12sg7p/src'
make: *** [docker-run-test-mingw@fedora] Error 2

real    4m56.687s
user    0m8.283s


The full log is available at
http://patchew.org/logs/20200604075943.7001-1-kraxel@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

On Thu, Jun 04, 2020 at 09:59:41AM +0200, Gerd Hoffmann wrote:
>

There's no info here, or in the commit message about the
intended goal of this modularization ? If we're modularizing
devices, why only qxl and not other devices too ?

> 
> Gerd Hoffmann (2):
>   qdev: add support for device module loading
>   vga: build qxl as module
> 
>  Makefile.objs            |  1 +
>  Makefile.target          |  7 ++++++
>  include/hw/qdev-core.h   |  3 +++
>  include/qemu/module.h    |  1 +
>  hw/core/qdev.c           | 49 ++++++++++++++++++++++++++++++++++++++++
>  qdev-monitor.c           |  5 ++++
>  hw/Makefile.objs         |  1 +
>  hw/display/Makefile.objs |  4 +++-
>  8 files changed, 70 insertions(+), 1 deletion(-)
> 
> -- 
> 2.18.4
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

On Thu, Jun 04, 2020 at 09:48:20AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 04, 2020 at 09:59:41AM +0200, Gerd Hoffmann wrote:
> >
> 
> There's no info here, or in the commit message about the
> intended goal of this modularization ? If we're modularizing
> devices, why only qxl and not other devices too ?

Same reason we created all the other modules:  Reduce shared library
dependencies of core qemu.  In this case: spice.  This mini-series
alone isn't enough for that, but it should make it easier to make qemu
spice support modular (Christophe looks into that).

Other candidates:
  * virtio-gpu (libvirglrenderer.so).
  * ccid-card-emulated (libcacard.so).

cheers,
  Gerd

> Other candidates:
>   * virtio-gpu (libvirglrenderer.so).
>   * ccid-card-emulated (libcacard.so).

 * usb-redir (libusbredir.so)
 * usb-host (libusb.so)

usb-host also has a monitor command ("info usbhost").  This uses libusb
too so leaving that in core qemu would be pointless.  So for that one
we'll also need some way for modules to dynamically register monitor
commands.

cheers,
  Gerd