Use QLNULL for null lockable

[PATCH 0/2] Use QLNULL for null lockable

Joe Slater posted 2 patches 3 years, 11 months ago

Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200603224903.26268-1-joe.slater@windriver.com

Maintainers: Max Reitz <mreitz@redhat.com>, John Snow <jsnow@redhat.com>, Greg Kurz <groug@kaod.org>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Kevin Wolf <kwolf@redhat.com>

block/block-backend.c          |  4 ++--
block/block-copy.c             |  2 +-
block/mirror.c                 |  5 +++--
fsdev/qemu-fsdev-throttle.c    |  6 +++---
hw/9pfs/9p.c                   |  2 +-
include/qemu/lockable.h        | 16 ++++++----------
util/qemu-co-shared-resource.c |  2 +-
7 files changed, 17 insertions(+), 20 deletions(-)

Expand all Fold all

[PATCH 0/2] Use QLNULL for null lockable

Posted by Joe Slater 3 years, 11 months ago

We currently will fail to build for optimizations like -Og because they do not
eliminate dead code.  We do not need such clean up if we use QLNULL.  There is no
need to produce a QemuLockable that will be thrown away.

Only testing:

$ ../configure
$ make -j16 CFLAGS="$CFLAGS"      # which I set to use -Og, then -O2

Joe Slater (2):
  lockable:  use QLNULL for a null lockable
  lockable: do not rely on optimization for null lockables

 block/block-backend.c          |  4 ++--
 block/block-copy.c             |  2 +-
 block/mirror.c                 |  5 +++--
 fsdev/qemu-fsdev-throttle.c    |  6 +++---
 hw/9pfs/9p.c                   |  2 +-
 include/qemu/lockable.h        | 16 ++++++----------
 util/qemu-co-shared-resource.c |  2 +-
 7 files changed, 17 insertions(+), 20 deletions(-)

-- 
2.7.4