[PATCH v2 02/20] iotests: 129 don't check backup "busy"

Vladimir Sementsov-Ogievskiy posted 20 patches 5 years, 8 months ago
There is a newer version of this series
[PATCH v2 02/20] iotests: 129 don't check backup "busy"
Posted by Vladimir Sementsov-Ogievskiy 5 years, 8 months ago
Busy is racy, job has it's "pause-points" when it's not busy. Drop this
check.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/129 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
index b0da4a5541..4db5eca441 100755
--- a/tests/qemu-iotests/129
+++ b/tests/qemu-iotests/129
@@ -66,7 +66,6 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
         result = self.vm.qmp("stop")
         self.assert_qmp(result, 'return', {})
         result = self.vm.qmp("query-block-jobs")
-        self.assert_qmp(result, 'return[0]/busy', True)
         self.assert_qmp(result, 'return[0]/ready', False)
 
     def test_drive_mirror(self):
-- 
2.21.0


Re: [PATCH v2 02/20] iotests: 129 don't check backup "busy"
Posted by Max Reitz 5 years, 6 months ago
On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote:
> Busy is racy, job has it's "pause-points" when it's not busy. Drop this
> check.

Possible, though I have to admit I don’t think I’ve ever seen 129 fail
because of that, but rather because of:

https://lists.nongnu.org/archive/html/qemu-block/2019-06/msg00499.html

I.e. the fact that BB throttling doesn’t do anything and the job is
basically just done before query-block-jobs.

But checking @busy is probably not the best thing to do, right.

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/129 | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>