[v2] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typedefs

[PATCH v2 0/3] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typedefs

Philippe Mathieu-Daudé posted 3 patches 3 years, 11 months ago

Diff against v1
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200601141536.15192-1-f4bug@amsat.org

include/exec/cpu-common.h |  3 ---
include/exec/memory.h     |  6 -----
include/hw/usb.h          | 30 -------------------------
include/hw/usb/hcd-musb.h | 47 +++++++++++++++++++++++++++++++++++++++
hw/usb/hcd-musb.c         |  5 +++--
hw/usb/tusb6010.c         |  1 +
6 files changed, 51 insertions(+), 41 deletions(-)
create mode 100644 include/hw/usb/hcd-musb.h

Expand all Fold all

[PATCH v2 0/3] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typedefs

Posted by Philippe Mathieu-Daudé 3 years, 11 months ago

Followed Peter's suggestions [1]:

 * delete the unused MmeoryRegionMmio
 * move these typedefs into include/hw/usb.h and rename them
   to MUSBReadFunc and MUSBWriteFunc, since that's all they're
   used for now

Since v1 [2], addressed Peter review:
- Renamed include/hw/usb/musb.h -> include/hw/usb/hcd-musb.h
- Added Peter's R-b tags

Series fully reviewed.

[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708165.html
[2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708194.html

Philippe Mathieu-Daudé (3):
  exec/memory: Remove unused MemoryRegionMmio type
  hw/usb: Move device-specific declarations to new 'hcd-musb.h' header
  exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h'

 include/exec/cpu-common.h |  3 ---
 include/exec/memory.h     |  6 -----
 include/hw/usb.h          | 30 -------------------------
 include/hw/usb/hcd-musb.h | 47 +++++++++++++++++++++++++++++++++++++++
 hw/usb/hcd-musb.c         |  5 +++--
 hw/usb/tusb6010.c         |  1 +
 6 files changed, 51 insertions(+), 41 deletions(-)
 create mode 100644 include/hw/usb/hcd-musb.h

-- 
2.21.3

Re: [PATCH v2 0/3] exec: Kill CPUReadMemoryFunc/CPUWriteMemoryFunc typedefs

Posted by Paolo Bonzini 3 years, 11 months ago

On 01/06/20 16:15, Philippe Mathieu-Daudé wrote:
> Followed Peter's suggestions [1]:
> 
>  * delete the unused MmeoryRegionMmio
>  * move these typedefs into include/hw/usb.h and rename them
>    to MUSBReadFunc and MUSBWriteFunc, since that's all they're
>    used for now
> 
> Since v1 [2], addressed Peter review:
> - Renamed include/hw/usb/musb.h -> include/hw/usb/hcd-musb.h
> - Added Peter's R-b tags
> 
> Series fully reviewed.
> 
> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708165.html
> [2] https://www.mail-archive.com/qemu-devel@nongnu.org/msg708194.html
> 
> Philippe Mathieu-Daudé (3):
>   exec/memory: Remove unused MemoryRegionMmio type
>   hw/usb: Move device-specific declarations to new 'hcd-musb.h' header
>   exec/cpu-common: Move MUSB specific typedefs to 'hw/usb/hcd-musb.h'
> 
>  include/exec/cpu-common.h |  3 ---
>  include/exec/memory.h     |  6 -----
>  include/hw/usb.h          | 30 -------------------------
>  include/hw/usb/hcd-musb.h | 47 +++++++++++++++++++++++++++++++++++++++
>  hw/usb/hcd-musb.c         |  5 +++--
>  hw/usb/tusb6010.c         |  1 +
>  6 files changed, 51 insertions(+), 41 deletions(-)
>  create mode 100644 include/hw/usb/hcd-musb.h
> 

Queued, thanks.

Paolo