[PATCH 03/13] i386: hvf: Clean stray includes in sysemu

Roman Bolshakov posted 13 patches 5 years, 8 months ago
Maintainers: Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Roman Bolshakov <r.bolshakov@yadro.com>
[PATCH 03/13] i386: hvf: Clean stray includes in sysemu
Posted by Roman Bolshakov 5 years, 8 months ago
They have no use.

Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 include/sysemu/hvf.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h
index 03f3cd7db3..cf579e1592 100644
--- a/include/sysemu/hvf.h
+++ b/include/sysemu/hvf.h
@@ -13,15 +13,8 @@
 #ifndef HVF_H
 #define HVF_H
 
-#include "cpu.h"
-#include "qemu/bitops.h"
-
 extern bool hvf_allowed;
 #ifdef CONFIG_HVF
-#include <Hypervisor/hv.h>
-#include <Hypervisor/hv_vmx.h>
-#include <Hypervisor/hv_error.h>
-#include "target/i386/cpu.h"
 uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx,
                                  int reg);
 #define hvf_enabled() (hvf_allowed)
-- 
2.26.1


Re: [PATCH 03/13] i386: hvf: Clean stray includes in sysemu
Posted by Claudio Fontana 5 years, 8 months ago
On 5/28/20 9:37 PM, Roman Bolshakov wrote:
> They have no use.
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
>  include/sysemu/hvf.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h
> index 03f3cd7db3..cf579e1592 100644
> --- a/include/sysemu/hvf.h
> +++ b/include/sysemu/hvf.h
> @@ -13,15 +13,8 @@
>  #ifndef HVF_H
>  #define HVF_H
>  
> -#include "cpu.h"
> -#include "qemu/bitops.h"
> -
>  extern bool hvf_allowed;
>  #ifdef CONFIG_HVF
> -#include <Hypervisor/hv.h>
> -#include <Hypervisor/hv_vmx.h>
> -#include <Hypervisor/hv_error.h>
> -#include "target/i386/cpu.h"
>  uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t idx,
>                                   int reg);
>  #define hvf_enabled() (hvf_allowed)
> 

[I will include then cpu.h from hvf-cpus.c in the cpus-refactoring series.]

Reviewed-by: Claudio Fontana <cfontana@suse.de>