[v3] bitmaps patches for 2020-05-26

[PULL v3 00/11] bitmaps patches for 2020-05-26

Posted by Eric Blake 3 years, 11 months ago

The following changes since commit a20ab81d22300cca80325c284f21eefee99aa740:

  Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-05-28' into staging (2020-05-28 16:18:06 +0100)

are available in the Git repository at:

  https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-2020-05-26-v3

for you to fetch changes up to cf2d1203dcfc2bf964453d83a2302231ce77f2dc:

  iotests: Add test 291 to for qemu-img bitmap coverage (2020-05-28 13:16:30 -0500)

v3: port sed expression to BSD sed
v2: fix iotest 190 to not be as sensitive to different sparseness of
qcow2 file on various filesystems, such as FreeBSD (sending only the
changed patch)

----------------------------------------------------------------
bitmaps patches for 2020-05-26

- fix non-blockdev migration of bitmaps when mirror job is in use
- add bitmap sizing to 'qemu-img measure'
- add 'qemu-img convert --bitmaps'

----------------------------------------------------------------
Eric Blake (5):
      iotests: Fix test 178
      qcow2: Expose bitmaps' size during measure
      qemu-img: Factor out code for merging bitmaps
      qemu-img: Add convert --bitmaps option
      iotests: Add test 291 to for qemu-img bitmap coverage

Vladimir Sementsov-Ogievskiy (6):
      migration: refactor init_dirty_bitmap_migration
      block/dirty-bitmap: add bdrv_has_named_bitmaps helper
      migration: fix bitmaps pre-blockdev migration with mirror job
      iotests: 194: test also migration of dirty bitmap
      migration: add_bitmaps_to_list: check disk name once
      migration: forbid bitmap migration by generated node-name

 docs/tools/qemu-img.rst          |  13 +++-
 qapi/block-core.json             |  16 +++--
 block/qcow2.h                    |   2 +
 include/block/dirty-bitmap.h     |   1 +
 block/crypto.c                   |   2 +-
 block/dirty-bitmap.c             |  13 ++++
 block/qcow2-bitmap.c             |  36 ++++++++++
 block/qcow2.c                    |  14 +++-
 block/raw-format.c               |   2 +-
 migration/block-dirty-bitmap.c   | 142 ++++++++++++++++++++++++++++-----------
 qemu-img.c                       | 107 ++++++++++++++++++++++++-----
 qemu-img-cmds.hx                 |   4 +-
 tests/qemu-iotests/178.out.qcow2 |  18 ++++-
 tests/qemu-iotests/178.out.raw   |   2 +-
 tests/qemu-iotests/190           |  47 ++++++++++++-
 tests/qemu-iotests/190.out       |  27 +++++++-
 tests/qemu-iotests/194           |  14 ++--
 tests/qemu-iotests/194.out       |   6 ++
 tests/qemu-iotests/291           | 112 ++++++++++++++++++++++++++++++
 tests/qemu-iotests/291.out       |  80 ++++++++++++++++++++++
 tests/qemu-iotests/group         |   1 +
 21 files changed, 582 insertions(+), 77 deletions(-)
 create mode 100755 tests/qemu-iotests/291
 create mode 100644 tests/qemu-iotests/291.out

-- 
2.26.2

Re: [PULL v3 00/11] bitmaps patches for 2020-05-26

Posted by Peter Maydell 3 years, 11 months ago

On Thu, 28 May 2020 at 19:19, Eric Blake <eblake@redhat.com> wrote:
>
> The following changes since commit a20ab81d22300cca80325c284f21eefee99aa740:
>
>   Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-05-28' into staging (2020-05-28 16:18:06 +0100)
>
> are available in the Git repository at:
>
>   https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-2020-05-26-v3
>
> for you to fetch changes up to cf2d1203dcfc2bf964453d83a2302231ce77f2dc:
>
>   iotests: Add test 291 to for qemu-img bitmap coverage (2020-05-28 13:16:30 -0500)
>
> v3: port sed expression to BSD sed
> v2: fix iotest 190 to not be as sensitive to different sparseness of
> qcow2 file on various filesystems, such as FreeBSD (sending only the
> changed patch)
>
> ----------------------------------------------------------------
> bitmaps patches for 2020-05-26
>
> - fix non-blockdev migration of bitmaps when mirror job is in use
> - add bitmap sizing to 'qemu-img measure'
> - add 'qemu-img convert --bitmaps'
>


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM

Re: [PULL v3 00/11] bitmaps patches for 2020-05-26

Posted by Vladimir Sementsov-Ogievskiy 3 years, 11 months ago

Hi!

Strange thing with your pull requests: I receive only small part of them.. I thought it's my problem of receiving part, but now I've checked that in mailing list archive there are same only two emails: 00/11 and 08/11 https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08061.html

28.05.2020 21:18, Eric Blake wrote:
> The following changes since commit a20ab81d22300cca80325c284f21eefee99aa740:
> 
>    Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-05-28' into staging (2020-05-28 16:18:06 +0100)
> 
> are available in the Git repository at:
> 
>    https://repo.or.cz/qemu/ericb.git tags/pull-bitmaps-2020-05-26-v3
> 
> for you to fetch changes up to cf2d1203dcfc2bf964453d83a2302231ce77f2dc:
> 
>    iotests: Add test 291 to for qemu-img bitmap coverage (2020-05-28 13:16:30 -0500)
> 
> v3: port sed expression to BSD sed
> v2: fix iotest 190 to not be as sensitive to different sparseness of
> qcow2 file on various filesystems, such as FreeBSD (sending only the
> changed patch)
> 
> ----------------------------------------------------------------
> bitmaps patches for 2020-05-26
> 
> - fix non-blockdev migration of bitmaps when mirror job is in use
> - add bitmap sizing to 'qemu-img measure'
> - add 'qemu-img convert --bitmaps'
> 
> ----------------------------------------------------------------
> Eric Blake (5):
>        iotests: Fix test 178
>        qcow2: Expose bitmaps' size during measure
>        qemu-img: Factor out code for merging bitmaps
>        qemu-img: Add convert --bitmaps option
>        iotests: Add test 291 to for qemu-img bitmap coverage
> 
> Vladimir Sementsov-Ogievskiy (6):
>        migration: refactor init_dirty_bitmap_migration
>        block/dirty-bitmap: add bdrv_has_named_bitmaps helper
>        migration: fix bitmaps pre-blockdev migration with mirror job
>        iotests: 194: test also migration of dirty bitmap
>        migration: add_bitmaps_to_list: check disk name once
>        migration: forbid bitmap migration by generated node-name
> 
>   docs/tools/qemu-img.rst          |  13 +++-
>   qapi/block-core.json             |  16 +++--
>   block/qcow2.h                    |   2 +
>   include/block/dirty-bitmap.h     |   1 +
>   block/crypto.c                   |   2 +-
>   block/dirty-bitmap.c             |  13 ++++
>   block/qcow2-bitmap.c             |  36 ++++++++++
>   block/qcow2.c                    |  14 +++-
>   block/raw-format.c               |   2 +-
>   migration/block-dirty-bitmap.c   | 142 ++++++++++++++++++++++++++++-----------
>   qemu-img.c                       | 107 ++++++++++++++++++++++++-----
>   qemu-img-cmds.hx                 |   4 +-
>   tests/qemu-iotests/178.out.qcow2 |  18 ++++-
>   tests/qemu-iotests/178.out.raw   |   2 +-
>   tests/qemu-iotests/190           |  47 ++++++++++++-
>   tests/qemu-iotests/190.out       |  27 +++++++-
>   tests/qemu-iotests/194           |  14 ++--
>   tests/qemu-iotests/194.out       |   6 ++
>   tests/qemu-iotests/291           | 112 ++++++++++++++++++++++++++++++
>   tests/qemu-iotests/291.out       |  80 ++++++++++++++++++++++
>   tests/qemu-iotests/group         |   1 +
>   21 files changed, 582 insertions(+), 77 deletions(-)
>   create mode 100755 tests/qemu-iotests/291
>   create mode 100644 tests/qemu-iotests/291.out
> 


-- 
Best regards,
Vladimir

Re: [PULL v3 00/11] bitmaps patches for 2020-05-26

Posted by Peter Maydell 3 years, 11 months ago

On Fri, 29 May 2020 at 06:53, Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
>
> Hi!
>
> Strange thing with your pull requests: I receive only small part of them.. I thought it's my problem of receiving part, but now I've checked that in mailing list archive there are same only two emails: 00/11 and 08/11 https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08061.html

The convention when resending a pullreq which has had to
be respun with a minor fixup is to send only the coverletter
and any significantly changed patches, on the basis that there's
no need to spam the list with the whole set of emails again.
You can see that for v1 the whole set was sent:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg07419.html

thanks
-- PMM

Re: [PULL v3 00/11] bitmaps patches for 2020-05-26

Posted by Eric Blake 3 years, 11 months ago

On 5/29/20 12:37 AM, Vladimir Sementsov-Ogievskiy wrote:
> Hi!
> 
> Strange thing with your pull requests: I receive only small part of 
> them.. I thought it's my problem of receiving part, but now I've checked 
> that in mailing list archive there are same only two emails: 00/11 and 
> 08/11 https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08061.html

It was intentional for both v2 and v3:

> 
> 28.05.2020 21:18, Eric Blake wrote:

>>
>> v3: port sed expression to BSD sed
>> v2: fix iotest 190 to not be as sensitive to different sparseness of
>> qcow2 file on various filesystems, such as FreeBSD (sending only the
>> changed patch)

and I even tried to mention what I was doing, although I also see how it 
could have been easy to miss that buried in the middle of the cover letter.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org