[PULL 0/8] Audio 20200526 patches

Gerd Hoffmann posted 8 patches 5 years, 5 months ago
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200526075639.27949-1-kraxel@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Eric Blake <eblake@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
configure               |  17 +
audio/audio.h           |   4 +-
audio/audio_template.h  |   2 +
audio/audio.c           |   5 +-
audio/jackaudio.c       | 667 ++++++++++++++++++++++++++++++++++++++++
audio/mixeng.c          |   9 +-
audio/wavcapture.c      |   2 +-
hw/audio/es1370.c       |   7 +-
hw/audio/gus.c          |   8 +-
hw/mips/mips_fulong2e.c |   1 -
ui/vnc.c                |   2 +-
audio/Makefile.objs     |   5 +
qapi/audio.json         |  56 +++-
13 files changed, 763 insertions(+), 22 deletions(-)
create mode 100644 audio/jackaudio.c
[PULL 0/8] Audio 20200526 patches
Posted by Gerd Hoffmann 5 years, 5 months ago
The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 18:54:47 +0100)

are available in the Git repository at:

  git://git.kraxel.org/qemu tags/audio-20200526-pull-request

for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02:

  hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include (2020-05-26 08:46:14 +0200)

----------------------------------------------------------------
audio: add JACK client audiodev.
audio: bugfixes and cleanups.

----------------------------------------------------------------

Bruce Rogers (1):
  audio: fix wavcapture segfault

Geoffrey McRae (1):
  audio/jack: add JACK client audiodev

Philippe Mathieu-Daudé (4):
  hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from
    'audio/audio.h'
  audio: Let audio_sample_to_uint64() use const samples argument
  audio: Let capture_callback handler use const buffer argument
  hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include

Prasad J Pandit (1):
  es1370: check total frame count against current frame

Volker Rümelin (1):
  audio/mixeng: fix clang 10+ warning

 configure               |  17 +
 audio/audio.h           |   4 +-
 audio/audio_template.h  |   2 +
 audio/audio.c           |   5 +-
 audio/jackaudio.c       | 667 ++++++++++++++++++++++++++++++++++++++++
 audio/mixeng.c          |   9 +-
 audio/wavcapture.c      |   2 +-
 hw/audio/es1370.c       |   7 +-
 hw/audio/gus.c          |   8 +-
 hw/mips/mips_fulong2e.c |   1 -
 ui/vnc.c                |   2 +-
 audio/Makefile.objs     |   5 +
 qapi/audio.json         |  56 +++-
 13 files changed, 763 insertions(+), 22 deletions(-)
 create mode 100644 audio/jackaudio.c

-- 
2.18.4


Re: [PULL 0/8] Audio 20200526 patches
Posted by Peter Maydell 5 years, 5 months ago
On Tue, 26 May 2020 at 08:59, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 18:54:47 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/audio-20200526-pull-request
>
> for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02:
>
>   hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include (2020-05-26 08:46:14 +0200)
>
> ----------------------------------------------------------------
> audio: add JACK client audiodev.
> audio: bugfixes and cleanups.
>
> ----------------------------------------------------------------

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM

Re: [PULL 0/8] Audio 20200526 patches
Posted by Markus Armbruster 5 years, 5 months ago
Gerd Hoffmann <kraxel@redhat.com> writes:

> The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 18:54:47 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/audio-20200526-pull-request
>
> for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02:
>
>   hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include (2020-05-26 08:46:14 +0200)
>
> ----------------------------------------------------------------
> audio: add JACK client audiodev.
> audio: bugfixes and cleanups.
>
> ----------------------------------------------------------------

$ qemu-system-aarch64 -S -accel qtest -display none -M akita -monitor stdio
(qemu) qemu-system-aarch64: /work/armbru/qemu/audio/paaudio.c:779: qpa_audio_init: Assertion `dev->driver == AUDIODEV_DRIVER_PA' failed.

Same for 40p, akita, borzoi, cheetah, integratorcp, milkymist, musicpal,
n800, n810, realview-eb, realview-eb-mpcore, realview-pb-a8,
realview-pbx-a9, spitz, terrier, versatileab, versatilepb, vexpress-a15,
vexpress-a9, xlnx-zcu102, z2.

git-bisect blames commit 2e44570321 "audio/jack: add JACK client
audiodev".


Re: [PULL 0/8] Audio 20200526 patches
Posted by Gerd Hoffmann 5 years, 5 months ago
On Wed, May 27, 2020 at 08:30:18AM +0200, Markus Armbruster wrote:
> Gerd Hoffmann <kraxel@redhat.com> writes:
> 
> > The following changes since commit fea8f3ed739536fca027cf56af7f5576f37ef9cd:
> >
> >   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/pflash-next-20200522' into staging (2020-05-22 18:54:47 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.kraxel.org/qemu tags/audio-20200526-pull-request
> >
> > for you to fetch changes up to b3b8a1fea6ed5004bbad2f70833caee70402bf02:
> >
> >   hw/mips/mips_fulong2e: Remove unused 'audio/audio.h' include (2020-05-26 08:46:14 +0200)
> >
> > ----------------------------------------------------------------
> > audio: add JACK client audiodev.
> > audio: bugfixes and cleanups.
> >
> > ----------------------------------------------------------------
> 
> $ qemu-system-aarch64 -S -accel qtest -display none -M akita -monitor stdio
> (qemu) qemu-system-aarch64: /work/armbru/qemu/audio/paaudio.c:779: qpa_audio_init: Assertion `dev->driver == AUDIODEV_DRIVER_PA' failed.

Hmm, seems to be a dependency issue in our build system.
rm -rf $builddir, rebuild, try again, assert gone.

take care,
  Gerd