scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

[PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

Philippe Mathieu-Daudé posted 1 patch 3 years, 11 months ago

Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200524215654.13256-1-f4bug@amsat.org

scripts/clean-includes | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

Posted by Philippe Mathieu-Daudé 3 years, 11 months ago

"qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
but by 3rd party plugins that QEMU can use. These plugins can be
built out of QEMU and don't include "qemu/osdep.h".
Mark "qemu/qemu-plugin.h" as a special header that doesn't need
to be cleaned for "qemu/osdep.h".

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 scripts/clean-includes | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/clean-includes b/scripts/clean-includes
index dd938daa3e..795b3bea31 100755
--- a/scripts/clean-includes
+++ b/scripts/clean-includes
@@ -123,6 +123,7 @@ for f in "$@"; do
       ;;
     *include/qemu/osdep.h | \
     *include/qemu/compiler.h | \
+    *include/qemu/qemu-plugin.h | \
     *include/glib-compat.h | \
     *include/sysemu/os-posix.h | \
     *include/sysemu/os-win32.h | \
-- 
2.21.3

Re: [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

Posted by Emilio G. Cota 3 years, 11 months ago

On Sun, May 24, 2020 at 23:56:54 +0200, Philippe Mathieu-Daudé wrote:
> "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
> but by 3rd party plugins that QEMU can use. These plugins can be
> built out of QEMU and don't include "qemu/osdep.h".
> Mark "qemu/qemu-plugin.h" as a special header that doesn't need
> to be cleaned for "qemu/osdep.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Emilio G. Cota <cota@braap.org>

Thanks,
		Emilio

Re: [PATCH] scripts/clean-includes: Mark 'qemu/qemu-plugin.h' as special header

Posted by Alex Bennée 3 years, 11 months ago

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> "qemu/qemu-plugin.h" isn't meant to be include by QEMU codebase,
> but by 3rd party plugins that QEMU can use. These plugins can be
> built out of QEMU and don't include "qemu/osdep.h".
> Mark "qemu/qemu-plugin.h" as a special header that doesn't need
> to be cleaned for "qemu/osdep.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  scripts/clean-includes | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/clean-includes b/scripts/clean-includes
> index dd938daa3e..795b3bea31 100755
> --- a/scripts/clean-includes
> +++ b/scripts/clean-includes
> @@ -123,6 +123,7 @@ for f in "$@"; do
>        ;;
>      *include/qemu/osdep.h | \
>      *include/qemu/compiler.h | \
> +    *include/qemu/qemu-plugin.h | \
>      *include/glib-compat.h | \
>      *include/sysemu/os-posix.h | \
>      *include/sysemu/os-win32.h | \


Queued to plugins/next, thanks.

-- 
Alex Bennée