[v4] fix migration with bitmaps and mirror

[PATCH v4 0/6] fix migration with bitmaps and mirror

Vladimir Sementsov-Ogievskiy posted 6 patches 3 years, 11 months ago

Diff against v1 v2 v3
Download series mbox

Test asan failed

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200521220648.3255-1-vsementsov@virtuozzo.com

Maintainers: Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Max Reitz <mreitz@redhat.com>, John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Juan Quintela <quintela@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Fam Zheng <fam@euphon.net>

include/block/dirty-bitmap.h   |   1 +
block/dirty-bitmap.c           |  13 ++++
migration/block-dirty-bitmap.c | 130 ++++++++++++++++++++++++---------
tests/qemu-iotests/194         |  14 +++-
tests/qemu-iotests/194.out     |   6 ++
5 files changed, 127 insertions(+), 37 deletions(-)

Expand all Fold all

[PATCH v4 0/6] fix migration with bitmaps and mirror

Posted by Vladimir Sementsov-Ogievskiy 3 years, 11 months ago

v4: (Max's patch marking filters as filters already in master)
03: careful select child of filter, avoid crash 
04: add Eric's r-b
05-06: tweak error message, keep Andrey's r-b, add Eric's r-b

Vladimir Sementsov-Ogievskiy (6):
  migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration
  block/dirty-bitmap: add bdrv_has_named_bitmaps helper
  migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration
    during mirror job
  iotests: 194: test also migration of dirty bitmap
  migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name
    once
  migration/block-dirty-bitmap: forbid migration by generated node-name

 include/block/dirty-bitmap.h   |   1 +
 block/dirty-bitmap.c           |  13 ++++
 migration/block-dirty-bitmap.c | 130 ++++++++++++++++++++++++---------
 tests/qemu-iotests/194         |  14 +++-
 tests/qemu-iotests/194.out     |   6 ++
 5 files changed, 127 insertions(+), 37 deletions(-)

-- 
2.21.0

Re: [PATCH v4 0/6] fix migration with bitmaps and mirror

Posted by Eric Blake 3 years, 11 months ago

On 5/21/20 5:06 PM, Vladimir Sementsov-Ogievskiy wrote:
> v4: (Max's patch marking filters as filters already in master)
> 03: careful select child of filter, avoid crash
> 04: add Eric's r-b
> 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b
> 
> Vladimir Sementsov-Ogievskiy (6):
>    migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration
>    block/dirty-bitmap: add bdrv_has_named_bitmaps helper
>    migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration
>      during mirror job
>    iotests: 194: test also migration of dirty bitmap
>    migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name
>      once
>    migration/block-dirty-bitmap: forbid migration by generated node-name

3 and 5 have rather long subject lines, as shown by the wrapping 
inserted by git (3 even exceeds 80 columns on its own, even before git 
adds prefixing).  Should I try to touch this up in my staging queue? 
For example:

migration: fix non-blockdev bitmap migration with mirror

doesn't lose too much information, but is definitely shorter for 3.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [PATCH v4 0/6] fix migration with bitmaps and mirror

Posted by Vladimir Sementsov-Ogievskiy 3 years, 11 months ago

22.05.2020 18:24, Eric Blake wrote:
> On 5/21/20 5:06 PM, Vladimir Sementsov-Ogievskiy wrote:
>> v4: (Max's patch marking filters as filters already in master)
>> 03: careful select child of filter, avoid crash
>> 04: add Eric's r-b
>> 05-06: tweak error message, keep Andrey's r-b, add Eric's r-b
>>
>> Vladimir Sementsov-Ogievskiy (6):
>>    migration/block-dirty-bitmap: refactor init_dirty_bitmap_migration
>>    block/dirty-bitmap: add bdrv_has_named_bitmaps helper
>>    migration/block-dirty-bitmap: fix bitmaps pre-blockdev migration
>>      during mirror job
>>    iotests: 194: test also migration of dirty bitmap
>>    migration/block-dirty-bitmap: add_bitmaps_to_list: check disk name
>>      once
>>    migration/block-dirty-bitmap: forbid migration by generated node-name
> 
> 3 and 5 have rather long subject lines, as shown by the wrapping inserted by git (3 even exceeds 80 columns on its own, even before git adds prefixing).  Should I try to touch this up in my staging queue? For example:
> 
> migration: fix non-blockdev bitmap migration with mirror
> 
> doesn't lose too much information, but is definitely shorter for 3.
> 

No objections, of course

-- 
Best regards,
Vladimir