[v3] fix & merge block_status_above and is_allocated_above

[PATCH v3 0/5] fix & merge block_status_above and is_allocated_above

Vladimir Sementsov-Ogievskiy posted 5 patches 5 years, 5 months ago

Diff against v1 v2 v4 v5 v6 v7
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200520083520.25793-1-vsementsov@virtuozzo.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>

There is a newer version of this series

block/io.c                 | 105 +++++++++++++++++++------------------
block/qcow2.c              |  16 +++++-
tests/qemu-iotests/274     |  20 +++++++
tests/qemu-iotests/274.out |  65 +++++++++++++++++++++++
4 files changed, 152 insertions(+), 54 deletions(-)

Expand all Fold all

[PATCH v3 0/5] fix & merge block_status_above and is_allocated_above

Posted by Vladimir Sementsov-Ogievskiy 5 years, 5 months ago

Hi all!

v3: fix regression in 01 [Eric]

These series are here to address the following problem:
block-status-above functions may consider space after EOF of
intermediate backing files as unallocated, which is wrong, as these
backing files are the reason of producing zeroes, we never go further by
backing chain after a short backing file. So, if such short-backing file
is _inside_ requested sub-chain of the backing chain, we should never
report space after its EOF as unallocated.

See patches 01,04,05 for details.

Note, that this series leaves for another day the general problem
around block-status: misuse of BDRV_BLOCK_ALLOCATED as is-fs-allocated
vs go-to-backing.
Audit for this problem is done here:
"backing chain & block status & filters"
https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html
And I'm going to prepare series to address this problem.

Also, get_block_status func have same disease, but remains unfixed here:
I want to make separate series for it, as it need some more refactoring,
which should be based on patch
"[PATCH v2] block: Factor out bdrv_run_co()"

Vladimir Sementsov-Ogievskiy (5):
  block/io: fix bdrv_co_block_status_above
  block/io: bdrv_common_block_status_above: support include_base
  block/io: bdrv_common_block_status_above: support bs == base
  block/io: fix bdrv_is_allocated_above
  iotests: add commit top->base cases to 274

 block/io.c                 | 105 +++++++++++++++++++------------------
 block/qcow2.c              |  16 +++++-
 tests/qemu-iotests/274     |  20 +++++++
 tests/qemu-iotests/274.out |  65 +++++++++++++++++++++++
 4 files changed, 152 insertions(+), 54 deletions(-)

-- 
2.21.0