[v6] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

[PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

Hi,

This series has two parts:

- First we add the ability to QOM objects to produce data
  consumable by the fw_cfg device,

- Then we add the tls-cipher-suites object, and let it
  implement the FW_CFG_DATA_GENERATOR interface.

This is required by EDK2 'HTTPS Boot' feature [*] to tell
the guest which TLS ciphers it can use.

[*]: https://github.com/tianocore/edk2/blob/master/OvmfPkg/README

Since v5:
- Complete rewrite after chatting with Daniel Berrangé
Since v4:
- Addressed Laszlo comments (see patch#1 description)
Since v3:
- Addressed Markus' comments (do not care about heap)
Since v2:
- Split of
Since v1:
- Addressed Michael and Laszlo comments.

Please review,

Phil.

v5: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04525.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04300.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02965.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
Supersedes: <20190620122132.10075-1-philmd@redhat.com>

Philippe Mathieu-Daudé (5):
  hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
  softmmu/vl: Let -fw_cfg option take a 'blob_id' argument
  softmmu/vl: Allow -fw_cfg 'blob_id' option to set any file pathname
  crypto: Add tls-cipher-suites object
  crypto/tls-cipher-suites: Product fw_cfg consumable blob

 include/crypto/tls-cipher-suites.h |  39 ++++++++
 include/hw/nvram/fw_cfg.h          |  49 ++++++++++
 crypto/tls-cipher-suites.c         | 152 +++++++++++++++++++++++++++++
 hw/nvram/fw_cfg.c                  |  30 ++++++
 softmmu/vl.c                       |  19 +++-
 crypto/Makefile.objs               |   1 +
 6 files changed, 285 insertions(+), 5 deletions(-)
 create mode 100644 include/crypto/tls-cipher-suites.h
 create mode 100644 crypto/tls-cipher-suites.c

-- 
2.21.3

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

Hi Daniel,

On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series has two parts:
> 
> - First we add the ability to QOM objects to produce data
>   consumable by the fw_cfg device,
> 
> - Then we add the tls-cipher-suites object, and let it
>   implement the FW_CFG_DATA_GENERATOR interface.

Can I have a quick feedback that you are not going to NAck this series
later before addressing all comments from Laszlo's reviews?

Thanks!

Phil.

> 
> This is required by EDK2 'HTTPS Boot' feature [*] to tell
> the guest which TLS ciphers it can use.
> 
> [*]: https://github.com/tianocore/edk2/blob/master/OvmfPkg/README
> 
> Since v5:
> - Complete rewrite after chatting with Daniel Berrangé
> Since v4:
> - Addressed Laszlo comments (see patch#1 description)
> Since v3:
> - Addressed Markus' comments (do not care about heap)
> Since v2:
> - Split of
> Since v1:
> - Addressed Michael and Laszlo comments.
> 
> Please review,
> 
> Phil.
> 
> v5: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg04525.html
> v4: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04300.html
> v3: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02965.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02522.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01598.html
> Supersedes: <20190620122132.10075-1-philmd@redhat.com>
> 
> Philippe Mathieu-Daudé (5):
>   hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
>   softmmu/vl: Let -fw_cfg option take a 'blob_id' argument
>   softmmu/vl: Allow -fw_cfg 'blob_id' option to set any file pathname
>   crypto: Add tls-cipher-suites object
>   crypto/tls-cipher-suites: Product fw_cfg consumable blob
> 
>  include/crypto/tls-cipher-suites.h |  39 ++++++++
>  include/hw/nvram/fw_cfg.h          |  49 ++++++++++
>  crypto/tls-cipher-suites.c         | 152 +++++++++++++++++++++++++++++
>  hw/nvram/fw_cfg.c                  |  30 ++++++
>  softmmu/vl.c                       |  19 +++-
>  crypto/Makefile.objs               |   1 +
>  6 files changed, 285 insertions(+), 5 deletions(-)
>  create mode 100644 include/crypto/tls-cipher-suites.h
>  create mode 100644 crypto/tls-cipher-suites.c
>

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Posted by Daniel P. Berrangé 5 years, 5 months ago

On Wed, May 27, 2020 at 01:29:20PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Daniel,
> 
> On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote:
> > Hi,
> > 
> > This series has two parts:
> > 
> > - First we add the ability to QOM objects to produce data
> >   consumable by the fw_cfg device,
> > 
> > - Then we add the tls-cipher-suites object, and let it
> >   implement the FW_CFG_DATA_GENERATOR interface.
> 
> Can I have a quick feedback that you are not going to NAck this series
> later before addressing all comments from Laszlo's reviews?

It looks reasonable.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH v6 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

On 5/27/20 1:33 PM, Daniel P. Berrangé wrote:
> On Wed, May 27, 2020 at 01:29:20PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi Daniel,
>>
>> On 5/19/20 8:20 PM, Philippe Mathieu-Daudé wrote:
>>> Hi,
>>>
>>> This series has two parts:
>>>
>>> - First we add the ability to QOM objects to produce data
>>>   consumable by the fw_cfg device,
>>>
>>> - Then we add the tls-cipher-suites object, and let it
>>>   implement the FW_CFG_DATA_GENERATOR interface.
>>
>> Can I have a quick feedback that you are not going to NAck this series
>> later before addressing all comments from Laszlo's reviews?
> 
> It looks reasonable.

Thanks for your quick answer!

Phil.