[v3] net: Drop legacy "name" from -net and remove NetLegacy

[PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

Thomas Huth posted 2 patches 3 years, 11 months ago

Diff against v1 v2
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200518180103.32484-1-thuth@redhat.com

Maintainers: Eric Blake <eblake@redhat.com>, Jason Wang <jasowang@redhat.com>, Markus Armbruster <armbru@redhat.com>

docs/system/deprecated.rst | 15 ++++---
net/net.c                  | 87 ++++++--------------------------------
qapi/net.json              | 49 ---------------------
3 files changed, 23 insertions(+), 128 deletions(-)

Expand all Fold all

[PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

Posted by Thomas Huth 3 years, 11 months ago

Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of
'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used
internally anymore. And it's been marked as deprecated since QEMU v3.1,
so it is time to remove the "name" parameter from -net now. Once this
has been done, we can also drop the obsolete NetLegacy structure since
there is no major difference between Netdev and NetLegacy anymore.

v3:
 - Do not make "id" in Netdev optional, but rather assign a temporary
   "id" for -net before we call the options visitor function.
 - Changed some "void *" to "Netdev *" now

v2:
 - Rebased to master (use the deprecated.rst instead of qemu-deprecated.texi)

Thomas Huth (2):
  net: Drop the legacy "name" parameter from the -net option
  net: Drop the NetLegacy structure, always use Netdev instead

 docs/system/deprecated.rst | 15 ++++---
 net/net.c                  | 87 ++++++--------------------------------
 qapi/net.json              | 49 ---------------------
 3 files changed, 23 insertions(+), 128 deletions(-)

-- 
2.18.1

Re: [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

Posted by Thomas Huth 3 years, 10 months ago

On 18/05/2020 20.01, Thomas Huth wrote:
> Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of
> 'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used
> internally anymore. And it's been marked as deprecated since QEMU v3.1,
> so it is time to remove the "name" parameter from -net now. Once this
> has been done, we can also drop the obsolete NetLegacy structure since
> there is no major difference between Netdev and NetLegacy anymore.
> 
> v3:
>  - Do not make "id" in Netdev optional, but rather assign a temporary
>    "id" for -net before we call the options visitor function.
>  - Changed some "void *" to "Netdev *" now
> 
> v2:
>  - Rebased to master (use the deprecated.rst instead of qemu-deprecated.texi)
> 
> Thomas Huth (2):
>   net: Drop the legacy "name" parameter from the -net option
>   net: Drop the NetLegacy structure, always use Netdev instead

Ping!

Jason, do you think these patches are OK now, and if so, could you
please queue them for your next net pull request?

 Thanks,
  Thomas

Re: [PATCH v3 0/2] net: Drop legacy "name" from -net and remove NetLegacy

Posted by Jason Wang 3 years, 10 months ago

On 2020/6/15 下午8:06, Thomas Huth wrote:
> On 18/05/2020 20.01, Thomas Huth wrote:
>> Since commit b4983c570c7a ("net: Remove deprecated [hub_id name] tuple of
>> 'hostfwd_add' / 'hostfwd_remove'"), the "name" parameter is not used
>> internally anymore. And it's been marked as deprecated since QEMU v3.1,
>> so it is time to remove the "name" parameter from -net now. Once this
>> has been done, we can also drop the obsolete NetLegacy structure since
>> there is no major difference between Netdev and NetLegacy anymore.
>>
>> v3:
>>   - Do not make "id" in Netdev optional, but rather assign a temporary
>>     "id" for -net before we call the options visitor function.
>>   - Changed some "void *" to "Netdev *" now
>>
>> v2:
>>   - Rebased to master (use the deprecated.rst instead of qemu-deprecated.texi)
>>
>> Thomas Huth (2):
>>    net: Drop the legacy "name" parameter from the -net option
>>    net: Drop the NetLegacy structure, always use Netdev instead
> Ping!
>
> Jason, do you think these patches are OK now, and if so, could you
> please queue them for your next net pull request?


Queued.

Sorry for the late.

Thanks


>
>   Thanks,
>    Thomas
>
>