[v2] tests/tcg: fix invocation of the memory record/replay tests

[PATCH v2] tests/tcg: fix invocation of the memory record/replay tests

Alex Bennée posted 1 patch 5 years, 6 months ago

Diff against v1
Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test FreeBSD passed

Test docker-quick@centos7 passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200518162903.883-1-alex.bennee@linaro.org

tests/tcg/aarch64/Makefile.softmmu-target | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] tests/tcg: fix invocation of the memory record/replay tests

Posted by Alex Bennée 5 years, 6 months ago

I'm not sure when this broke but we should use EXTRA_RUNS for
"virtual" tests which are not generated from the binary names.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - keep the PHONY's for the benefit of output
---
 tests/tcg/aarch64/Makefile.softmmu-target | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/Makefile.softmmu-target
index 71f72cfbe34..1057a8ac498 100644
--- a/tests/tcg/aarch64/Makefile.softmmu-target
+++ b/tests/tcg/aarch64/Makefile.softmmu-target
@@ -61,7 +61,7 @@ run-memory-replay: memory-replay run-memory-record
 	   	  $(QEMU_OPTS) memory, \
 	  "$< on $(TARGET_NAME)")
 
-EXTRA_TESTS+=memory-record memory-replay
+EXTRA_RUNS+=run-memory-replay
 
 ifneq ($(DOCKER_IMAGE)$(CROSS_CC_HAS_ARMV8_3),)
 pauth-3: CFLAGS += -march=armv8.3-a
-- 
2.20.1

Re: [PATCH v2] tests/tcg: fix invocation of the memory record/replay tests

Posted by Richard Henderson 5 years, 5 months ago

On 5/18/20 9:29 AM, Alex Bennée wrote:
> I'm not sure when this broke but we should use EXTRA_RUNS for
> "virtual" tests which are not generated from the binary names.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v2
>   - keep the PHONY's for the benefit of output
> ---
>  tests/tcg/aarch64/Makefile.softmmu-target | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~