[v1] virtio-balloon: free page hinting fixes

[PATCH v1 0/3] virtio-balloon: free page hinting fixes

David Hildenbrand posted 3 patches 5 years, 6 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200518083704.52646-1-david@redhat.com

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

There is a newer version of this series

hw/virtio/virtio-balloon.c | 38 ++++++++++++++++++++------------------
1 file changed, 20 insertions(+), 18 deletions(-)

Expand all Fold all

[PATCH v1 0/3] virtio-balloon: free page hinting fixes

Posted by David Hildenbrand 5 years, 6 months ago

Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
Alexander Bulekov [1], the other ones were discovered by me when digging
into the details.

[1] https://lkml.kernel.org/r/20200511044121.eihns2tdimdzgi4i@mozz.bu.edu

David Hildenbrand (3):
  virtio-balloon: fix free page hinting without an iothread
  virtio-balloon: fix free page hinting check on unrealize
  virtio-balloon: unref the iothread when unrealizing

 hw/virtio/virtio-balloon.c | 38 ++++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 18 deletions(-)

-- 
2.25.4

Re: [PATCH v1 0/3] virtio-balloon: free page hinting fixes

Posted by Philippe Mathieu-Daudé 5 years, 6 months ago

On 5/18/20 10:37 AM, David Hildenbrand wrote:
> Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
> Alexander Bulekov [1], the other ones were discovered by me when digging
> into the details.
> 
> [1] https://lkml.kernel.org/r/20200511044121.eihns2tdimdzgi4i@mozz.bu.edu
> 
> David Hildenbrand (3):
>    virtio-balloon: fix free page hinting without an iothread
>    virtio-balloon: fix free page hinting check on unrealize
>    virtio-balloon: unref the iothread when unrealizing
> 
>   hw/virtio/virtio-balloon.c | 38 ++++++++++++++++++++------------------
>   1 file changed, 20 insertions(+), 18 deletions(-)
> 

All this series deserves a 'Cc: qemu-stable@nongnu.org' tag, right?

Re: [PATCH v1 0/3] virtio-balloon: free page hinting fixes

Posted by David Hildenbrand 5 years, 6 months ago

On 18.05.20 11:20, Philippe Mathieu-Daudé wrote:
> On 5/18/20 10:37 AM, David Hildenbrand wrote:
>> Some fixes for VIRTIO_BALLOON_F_FREE_PAGE_HINT. First issue was reported by
>> Alexander Bulekov [1], the other ones were discovered by me when digging
>> into the details.
>>
>> [1] https://lkml.kernel.org/r/20200511044121.eihns2tdimdzgi4i@mozz.bu.edu
>>
>> David Hildenbrand (3):
>>    virtio-balloon: fix free page hinting without an iothread
>>    virtio-balloon: fix free page hinting check on unrealize
>>    virtio-balloon: unref the iothread when unrealizing
>>
>>   hw/virtio/virtio-balloon.c | 38 ++++++++++++++++++++------------------
>>   1 file changed, 20 insertions(+), 18 deletions(-)
>>
> 
> All this series deserves a 'Cc: qemu-stable@nongnu.org' tag, right?

I was asking myself the same question. People usually don't unplug the
balloon device, but yes, #2 and #3 can be triggered by the user. Most
probably yes, cc stable for all.

-- 
Thanks,

David / dhildenb