1. Patchew
  2. QEMU
  3. View series

[PATCH] travis.yml: Use clang++ in the Clang tests

Thomas Huth posted 1 patch 5 years, 6 months ago
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200518083316.25065-1-thuth@redhat.com
Maintainers: "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Fam Zheng <fam@euphon.net>
There is a newer version of this series
.travis.yml | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
[PATCH] travis.yml: Use clang++ in the Clang tests
Posted by Thomas Huth 5 years, 6 months ago 
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 1ec8a7b465..564be50a3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -205,14 +205,15 @@ jobs:
     # Test with Clang for compile portability (Travis uses clang-5.0)
     - name: "Clang (user)"
       env:
-        - CONFIG="--disable-system"
+        - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
       compiler: clang
 
 
     - name: "Clang (main-softmmu)"
       env:
-        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
+        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
+                  --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
       compiler: clang
       before_script:
@@ -222,7 +223,8 @@ jobs:
 
     - name: "Clang (other-softmmu)"
       env:
-        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
+        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
+                  --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
       compiler: clang
 
-- 
2.18.1
Re: [PATCH] travis.yml: Use clang++ in the Clang tests
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago 
On 5/18/20 10:33 AM, Thomas Huth wrote:
> Our configure script does not look for clang++ automatically, so we
> should use --cxx=clang++ to make sure that we test our C++ code with
> Clang, too. And while we're at it, also use --host-cc=clang here
> to avoid that we use the normal "cc" as host C compiler.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   .travis.yml | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 1ec8a7b465..564be50a3c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -205,14 +205,15 @@ jobs:
>       # Test with Clang for compile portability (Travis uses clang-5.0)
>       - name: "Clang (user)"
>         env:
> -        - CONFIG="--disable-system"
> +        - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
>         compiler: clang
>   
>   
>       - name: "Clang (main-softmmu)"
>         env:
> -        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
> +        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
> +                  --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
>         compiler: clang
>         before_script:
> @@ -222,7 +223,8 @@ jobs:
>   
>       - name: "Clang (other-softmmu)"
>         env:
> -        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
> +        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
> +                  --host-cc=clang --cxx=clang++"
>           - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
>         compiler: clang
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Re: [PATCH] travis.yml: Use clang++ in the Clang tests
Posted by Alex Bennée 5 years, 6 months ago 
Thomas Huth <thuth@redhat.com> writes:

> Our configure script does not look for clang++ automatically, so we
> should use --cxx=clang++ to make sure that we test our C++ code with
> Clang, too. And while we're at it, also use --host-cc=clang here
> to avoid that we use the normal "cc" as host C compiler.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée
[PATCH] travis.yml: Use clang++ in the Clang tests
Posted by Thomas Huth 5 years, 6 months ago 
Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 1ec8a7b465..564be50a3c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -205,14 +205,15 @@ jobs:
     # Test with Clang for compile portability (Travis uses clang-5.0)
     - name: "Clang (user)"
       env:
-        - CONFIG="--disable-system"
+        - CONFIG="--disable-system --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
       compiler: clang
 
 
     - name: "Clang (main-softmmu)"
       env:
-        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
+        - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS}
+                  --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
       compiler: clang
       before_script:
@@ -222,7 +223,8 @@ jobs:
 
     - name: "Clang (other-softmmu)"
       env:
-        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
+        - CONFIG="--disable-user --target-list-exclude=${MAIN_SOFTMMU_TARGETS}
+                  --host-cc=clang --cxx=clang++"
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
       compiler: clang
 
-- 
2.18.1

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.