[v1] Fixes around device realization

[PATCH 13/24] ppc4xx: Drop redundant device realization

Posted by Markus Armbruster 5 years, 6 months ago

object_property_set_bool(OBJECT(dev), true, "realized", ...) right
after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
already realizes.  Drop.

Cc: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/ppc/ppc440_uc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index b30e093cbb..dc318c7aa7 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
     dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
     qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
     qdev_init_nofail(dev);
-    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
     ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
 
     dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
     qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
     qdev_init_nofail(dev);
-    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
     ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
 }
-- 
2.21.1

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization

Posted by Philippe Mathieu-Daudé 5 years, 6 months ago

On 5/18/20 7:03 AM, Markus Armbruster wrote:
> object_property_set_bool(OBJECT(dev), true, "realized", ...) right
> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
> already realizes.  Drop.
> 
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   hw/ppc/ppc440_uc.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index b30e093cbb..dc318c7aa7 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
>       dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>       qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
>       qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>       ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>   
>       dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>       qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
>       qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>       ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>   }
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization

Posted by Thomas Huth 5 years, 6 months ago

On 18/05/2020 07.03, Markus Armbruster wrote:
> object_property_set_bool(OBJECT(dev), true, "realized", ...) right
> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
> already realizes.  Drop.
> 
> Cc: BALATON Zoltan <balaton@eik.bme.hu>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  hw/ppc/ppc440_uc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index b30e093cbb..dc318c7aa7 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
>      dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>      qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
>      qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>      ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>  
>      dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>      qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
>      qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>      ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>  }
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization

Posted by BALATON Zoltan 5 years, 6 months ago

On Mon, 18 May 2020, Markus Armbruster wrote:
> object_property_set_bool(OBJECT(dev), true, "realized", ...) right
> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
> already realizes.  Drop.
>
> Cc: BALATON Zoltan <balaton@eik.bme.hu>

Shouldn't this Cc line come after the --- so it's not included in the 
final commit? Thanks.

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/ppc/ppc440_uc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index b30e093cbb..dc318c7aa7 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -1370,12 +1370,10 @@ void ppc460ex_pcie_init(CPUPPCState *env)
>     dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>     qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE0_BASE);
>     qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>     ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
>
>     dev = qdev_create(NULL, TYPE_PPC460EX_PCIE_HOST);
>     qdev_prop_set_int32(dev, "dcrn-base", DCRN_PCIE1_BASE);
>     qdev_init_nofail(dev);
> -    object_property_set_bool(OBJECT(dev), true, "realized", NULL);
>     ppc460ex_pcie_register_dcrs(PPC460EX_PCIE_HOST(dev), env);
> }
>

Re: [PATCH 13/24] ppc4xx: Drop redundant device realization

Posted by Markus Armbruster 5 years, 5 months ago

BALATON Zoltan <balaton@eik.bme.hu> writes:

> On Mon, 18 May 2020, Markus Armbruster wrote:
>> object_property_set_bool(OBJECT(dev), true, "realized", ...) right
>> after qdev_init_nofail(dev) does nothing, because qdev_init_nofail()
>> already realizes.  Drop.
>>
>> Cc: BALATON Zoltan <balaton@eik.bme.hu>
>
> Shouldn't this Cc line come after the --- so it's not included in the
> final commit? Thanks.

We routinely include it in git history.

> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

Thanks!