Hi all!

These series has 3 goals:

 - get rid of group file
 - introduce human-readable names for tests
 - rewrite check into python

v4:
   - human readable tests in  ..qemu-iotests/tests subdirectory
   - add --start-from argument for findtests
   - add type hinting

Vladimir Sementsov-Ogievskiy (9):
  iotests/277: use dot slash for nbd-fault-injector.py running
  iotests: fix some whitespaces in test output files
  iotests/283: make executable
  iotests: define group in each iotest
  iotests: add findtests.py
  iotests: add testenv.py
  iotests: add testrunner.py
  iotests: rewrite check into python
  iotests: rename and move 169 and 199 tests

 docs/devel/testing.rst                        |  50 +-
 tests/qemu-iotests/001                        |   1 +
 tests/qemu-iotests/002                        |   1 +
 tests/qemu-iotests/003                        |   1 +
 tests/qemu-iotests/004                        |   1 +
 tests/qemu-iotests/005                        |   1 +
 tests/qemu-iotests/007                        |   1 +
 tests/qemu-iotests/008                        |   1 +
 tests/qemu-iotests/009                        |   1 +
 tests/qemu-iotests/010                        |   1 +
 tests/qemu-iotests/011                        |   1 +
 tests/qemu-iotests/012                        |   1 +
 tests/qemu-iotests/013                        |   1 +
 tests/qemu-iotests/014                        |   1 +
 tests/qemu-iotests/015                        |   1 +
 tests/qemu-iotests/017                        |   1 +
 tests/qemu-iotests/018                        |   1 +
 tests/qemu-iotests/019                        |   1 +
 tests/qemu-iotests/020                        |   1 +
 tests/qemu-iotests/021                        |   1 +
 tests/qemu-iotests/022                        |   1 +
 tests/qemu-iotests/023                        |   1 +
 tests/qemu-iotests/024                        |   1 +
 tests/qemu-iotests/025                        |   1 +
 tests/qemu-iotests/026                        |   1 +
 tests/qemu-iotests/027                        |   1 +
 tests/qemu-iotests/028                        |   1 +
 tests/qemu-iotests/029                        |   1 +
 tests/qemu-iotests/030                        |   1 +
 tests/qemu-iotests/031                        |   1 +
 tests/qemu-iotests/032                        |   1 +
 tests/qemu-iotests/033                        |   1 +
 tests/qemu-iotests/034                        |   1 +
 tests/qemu-iotests/035                        |   1 +
 tests/qemu-iotests/036                        |   1 +
 tests/qemu-iotests/037                        |   1 +
 tests/qemu-iotests/038                        |   1 +
 tests/qemu-iotests/039                        |   1 +
 tests/qemu-iotests/040                        |   1 +
 tests/qemu-iotests/041                        |   1 +
 tests/qemu-iotests/042                        |   1 +
 tests/qemu-iotests/043                        |   1 +
 tests/qemu-iotests/044                        |   1 +
 tests/qemu-iotests/045                        |   1 +
 tests/qemu-iotests/046                        |   1 +
 tests/qemu-iotests/047                        |   1 +
 tests/qemu-iotests/048                        |   1 +
 tests/qemu-iotests/049                        |   1 +
 tests/qemu-iotests/050                        |   1 +
 tests/qemu-iotests/051                        |   1 +
 tests/qemu-iotests/052                        |   1 +
 tests/qemu-iotests/053                        |   1 +
 tests/qemu-iotests/054                        |   1 +
 tests/qemu-iotests/055                        |   1 +
 tests/qemu-iotests/056                        |   1 +
 tests/qemu-iotests/057                        |   1 +
 tests/qemu-iotests/058                        |   1 +
 tests/qemu-iotests/059                        |   1 +
 tests/qemu-iotests/060                        |   1 +
 tests/qemu-iotests/061                        |   1 +
 tests/qemu-iotests/062                        |   1 +
 tests/qemu-iotests/063                        |   1 +
 tests/qemu-iotests/064                        |   1 +
 tests/qemu-iotests/065                        |   1 +
 tests/qemu-iotests/066                        |   1 +
 tests/qemu-iotests/067                        |   1 +
 tests/qemu-iotests/068                        |   1 +
 tests/qemu-iotests/069                        |   1 +
 tests/qemu-iotests/070                        |   1 +
 tests/qemu-iotests/071                        |   1 +
 tests/qemu-iotests/072                        |   1 +
 tests/qemu-iotests/073                        |   1 +
 tests/qemu-iotests/074                        |   1 +
 tests/qemu-iotests/075                        |   1 +
 tests/qemu-iotests/076                        |   1 +
 tests/qemu-iotests/077                        |   1 +
 tests/qemu-iotests/078                        |   1 +
 tests/qemu-iotests/079                        |   1 +
 tests/qemu-iotests/080                        |   1 +
 tests/qemu-iotests/081                        |   1 +
 tests/qemu-iotests/082                        |   1 +
 tests/qemu-iotests/083                        |   1 +
 tests/qemu-iotests/084                        |   1 +
 tests/qemu-iotests/085                        |   1 +
 tests/qemu-iotests/086                        |   1 +
 tests/qemu-iotests/087                        |   1 +
 tests/qemu-iotests/088                        |   1 +
 tests/qemu-iotests/089                        |   1 +
 tests/qemu-iotests/090                        |   1 +
 tests/qemu-iotests/091                        |   1 +
 tests/qemu-iotests/092                        |   1 +
 tests/qemu-iotests/093                        |   1 +
 tests/qemu-iotests/094                        |   1 +
 tests/qemu-iotests/095                        |   1 +
 tests/qemu-iotests/096                        |   1 +
 tests/qemu-iotests/097                        |   1 +
 tests/qemu-iotests/098                        |   1 +
 tests/qemu-iotests/099                        |   1 +
 tests/qemu-iotests/101                        |   1 +
 tests/qemu-iotests/102                        |   1 +
 tests/qemu-iotests/103                        |   1 +
 tests/qemu-iotests/104                        |   1 +
 tests/qemu-iotests/105                        |   1 +
 tests/qemu-iotests/106                        |   1 +
 tests/qemu-iotests/107                        |   1 +
 tests/qemu-iotests/108                        |   1 +
 tests/qemu-iotests/109                        |   1 +
 tests/qemu-iotests/110                        |   1 +
 tests/qemu-iotests/111                        |   1 +
 tests/qemu-iotests/112                        |   1 +
 tests/qemu-iotests/113                        |   1 +
 tests/qemu-iotests/114                        |   1 +
 tests/qemu-iotests/115                        |   1 +
 tests/qemu-iotests/116                        |   1 +
 tests/qemu-iotests/117                        |   1 +
 tests/qemu-iotests/118                        |   1 +
 tests/qemu-iotests/119                        |   1 +
 tests/qemu-iotests/120                        |   1 +
 tests/qemu-iotests/121                        |   1 +
 tests/qemu-iotests/122                        |   1 +
 tests/qemu-iotests/123                        |   1 +
 tests/qemu-iotests/124                        |   1 +
 tests/qemu-iotests/125                        |   1 +
 tests/qemu-iotests/126                        |   1 +
 tests/qemu-iotests/127                        |   1 +
 tests/qemu-iotests/128                        |   1 +
 tests/qemu-iotests/129                        |   1 +
 tests/qemu-iotests/130                        |   1 +
 tests/qemu-iotests/131                        |   1 +
 tests/qemu-iotests/132                        |   1 +
 tests/qemu-iotests/133                        |   1 +
 tests/qemu-iotests/134                        |   1 +
 tests/qemu-iotests/135                        |   1 +
 tests/qemu-iotests/136                        |   1 +
 tests/qemu-iotests/137                        |   1 +
 tests/qemu-iotests/138                        |   1 +
 tests/qemu-iotests/139                        |   1 +
 tests/qemu-iotests/140                        |   1 +
 tests/qemu-iotests/141                        |   1 +
 tests/qemu-iotests/143                        |   1 +
 tests/qemu-iotests/144                        |   1 +
 tests/qemu-iotests/145                        |   1 +
 tests/qemu-iotests/146                        |   1 +
 tests/qemu-iotests/147                        |   1 +
 tests/qemu-iotests/148                        |   1 +
 tests/qemu-iotests/149                        |   1 +
 tests/qemu-iotests/150                        |   1 +
 tests/qemu-iotests/151                        |   1 +
 tests/qemu-iotests/152                        |   1 +
 tests/qemu-iotests/153                        |   1 +
 tests/qemu-iotests/154                        |   1 +
 tests/qemu-iotests/155                        |   1 +
 tests/qemu-iotests/156                        |   1 +
 tests/qemu-iotests/157                        |   1 +
 tests/qemu-iotests/158                        |   1 +
 tests/qemu-iotests/159                        |   1 +
 tests/qemu-iotests/160                        |   1 +
 tests/qemu-iotests/161                        |   1 +
 tests/qemu-iotests/162                        |   1 +
 tests/qemu-iotests/163                        |   1 +
 tests/qemu-iotests/165                        |   1 +
 tests/qemu-iotests/170                        |   1 +
 tests/qemu-iotests/171                        |   1 +
 tests/qemu-iotests/172                        |   1 +
 tests/qemu-iotests/173                        |   1 +
 tests/qemu-iotests/174                        |   1 +
 tests/qemu-iotests/175                        |   1 +
 tests/qemu-iotests/175.out                    |   2 +-
 tests/qemu-iotests/176                        |   1 +
 tests/qemu-iotests/177                        |   1 +
 tests/qemu-iotests/178                        |   1 +
 tests/qemu-iotests/179                        |   1 +
 tests/qemu-iotests/181                        |   1 +
 tests/qemu-iotests/182                        |   1 +
 tests/qemu-iotests/183                        |   1 +
 tests/qemu-iotests/184                        |   1 +
 tests/qemu-iotests/185                        |   1 +
 tests/qemu-iotests/186                        |   1 +
 tests/qemu-iotests/187                        |   1 +
 tests/qemu-iotests/188                        |   1 +
 tests/qemu-iotests/189                        |   1 +
 tests/qemu-iotests/190                        |   1 +
 tests/qemu-iotests/191                        |   1 +
 tests/qemu-iotests/192                        |   1 +
 tests/qemu-iotests/194                        |   1 +
 tests/qemu-iotests/195                        |   1 +
 tests/qemu-iotests/196                        |   1 +
 tests/qemu-iotests/197                        |   1 +
 tests/qemu-iotests/198                        |   1 +
 tests/qemu-iotests/200                        |   1 +
 tests/qemu-iotests/201                        |   1 +
 tests/qemu-iotests/202                        |   1 +
 tests/qemu-iotests/203                        |   1 +
 tests/qemu-iotests/204                        |   1 +
 tests/qemu-iotests/205                        |   1 +
 tests/qemu-iotests/206                        |   1 +
 tests/qemu-iotests/207                        |   1 +
 tests/qemu-iotests/208                        |   1 +
 tests/qemu-iotests/209                        |   1 +
 tests/qemu-iotests/210                        |   1 +
 tests/qemu-iotests/211                        |   1 +
 tests/qemu-iotests/212                        |   1 +
 tests/qemu-iotests/213                        |   1 +
 tests/qemu-iotests/214                        |   1 +
 tests/qemu-iotests/215                        |   1 +
 tests/qemu-iotests/216                        |   1 +
 tests/qemu-iotests/217                        |   1 +
 tests/qemu-iotests/218                        |   1 +
 tests/qemu-iotests/219                        |   1 +
 tests/qemu-iotests/220                        |   1 +
 tests/qemu-iotests/221                        |   1 +
 tests/qemu-iotests/222                        |   1 +
 tests/qemu-iotests/223                        |   1 +
 tests/qemu-iotests/224                        |   1 +
 tests/qemu-iotests/225                        |   1 +
 tests/qemu-iotests/226                        |   1 +
 tests/qemu-iotests/227                        |   1 +
 tests/qemu-iotests/228                        |   1 +
 tests/qemu-iotests/229                        |   1 +
 tests/qemu-iotests/231                        |   1 +
 tests/qemu-iotests/232                        |   1 +
 tests/qemu-iotests/233                        |   1 +
 tests/qemu-iotests/234                        |   1 +
 tests/qemu-iotests/235                        |   1 +
 tests/qemu-iotests/236                        |   1 +
 tests/qemu-iotests/237                        |   1 +
 tests/qemu-iotests/238                        |   1 +
 tests/qemu-iotests/239                        |   1 +
 tests/qemu-iotests/240                        |   1 +
 tests/qemu-iotests/241                        |   1 +
 tests/qemu-iotests/242                        |   1 +
 tests/qemu-iotests/243                        |   1 +
 tests/qemu-iotests/244                        |   1 +
 tests/qemu-iotests/245                        |   1 +
 tests/qemu-iotests/246                        |   1 +
 tests/qemu-iotests/247                        |   1 +
 tests/qemu-iotests/248                        |   1 +
 tests/qemu-iotests/249                        |   1 +
 tests/qemu-iotests/250                        |   1 +
 tests/qemu-iotests/251                        |   1 +
 tests/qemu-iotests/252                        |   1 +
 tests/qemu-iotests/253                        |   1 +
 tests/qemu-iotests/254                        |   1 +
 tests/qemu-iotests/255                        |   1 +
 tests/qemu-iotests/256                        |   1 +
 tests/qemu-iotests/257                        |   1 +
 tests/qemu-iotests/258                        |   1 +
 tests/qemu-iotests/259                        |   1 +
 tests/qemu-iotests/260                        |   1 +
 tests/qemu-iotests/261                        |   1 +
 tests/qemu-iotests/262                        |   1 +
 tests/qemu-iotests/263                        |   1 +
 tests/qemu-iotests/264                        |   1 +
 tests/qemu-iotests/265                        |   1 +
 tests/qemu-iotests/266                        |   1 +
 tests/qemu-iotests/267                        |   1 +
 tests/qemu-iotests/267.out                    |  48 +-
 tests/qemu-iotests/268                        |   1 +
 tests/qemu-iotests/270                        |   1 +
 tests/qemu-iotests/272                        |   1 +
 tests/qemu-iotests/273                        |   1 +
 tests/qemu-iotests/274                        |   1 +
 tests/qemu-iotests/277                        |   3 +-
 tests/qemu-iotests/279                        |   1 +
 tests/qemu-iotests/280                        |   1 +
 tests/qemu-iotests/281                        |   1 +
 tests/qemu-iotests/282                        |   1 +
 tests/qemu-iotests/283                        |   1 +
 tests/qemu-iotests/284                        |   1 +
 tests/qemu-iotests/286                        |   1 +
 tests/qemu-iotests/287                        |   1 +
 tests/qemu-iotests/287.out                    |  10 +-
 tests/qemu-iotests/288                        |   1 +
 tests/qemu-iotests/289                        |   1 +
 tests/qemu-iotests/290                        |   1 +
 tests/qemu-iotests/292                        |   1 +
 tests/qemu-iotests/check                      | 983 +-----------------
 tests/qemu-iotests/findtests.py               | 229 ++++
 tests/qemu-iotests/group                      | 302 ------
 tests/qemu-iotests/testenv.py                 | 325 ++++++
 tests/qemu-iotests/testrunner.py              | 351 +++++++
 .../migrate-bitmaps-postcopy-test}            |   1 +
 .../migrate-bitmaps-postcopy-test.out}        |   0
 .../{169 => tests/migrate-bitmaps-test}       |   1 +
 .../migrate-bitmaps-test.out}                 |   0
 285 files changed, 1287 insertions(+), 1289 deletions(-)
 mode change 100644 => 100755 tests/qemu-iotests/283
 create mode 100755 tests/qemu-iotests/findtests.py
 delete mode 100644 tests/qemu-iotests/group
 create mode 100755 tests/qemu-iotests/testenv.py
 create mode 100644 tests/qemu-iotests/testrunner.py
 rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (99%)
 rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
 rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (99%)
 rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)

-- 
2.21.0

Ping :)

(of course, master is updated and 04 should cover more iotests now, but still,
  the core scripts of the series need some review)

16.05.2020 00:14, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> These series has 3 goals:
> 
>   - get rid of group file
>   - introduce human-readable names for tests
>   - rewrite check into python
> 
> v4:
>     - human readable tests in  ..qemu-iotests/tests subdirectory
>     - add --start-from argument for findtests
>     - add type hinting
> 
> Vladimir Sementsov-Ogievskiy (9):
>    iotests/277: use dot slash for nbd-fault-injector.py running
>    iotests: fix some whitespaces in test output files
>    iotests/283: make executable
>    iotests: define group in each iotest
>    iotests: add findtests.py
>    iotests: add testenv.py
>    iotests: add testrunner.py
>    iotests: rewrite check into python
>    iotests: rename and move 169 and 199 tests
> 
>   docs/devel/testing.rst                        |  50 +-
>   tests/qemu-iotests/001                        |   1 +
>   tests/qemu-iotests/002                        |   1 +
>   tests/qemu-iotests/003                        |   1 +
>   tests/qemu-iotests/004                        |   1 +
>   tests/qemu-iotests/005                        |   1 +
>   tests/qemu-iotests/007                        |   1 +
>   tests/qemu-iotests/008                        |   1 +
>   tests/qemu-iotests/009                        |   1 +
>   tests/qemu-iotests/010                        |   1 +
>   tests/qemu-iotests/011                        |   1 +
>   tests/qemu-iotests/012                        |   1 +
>   tests/qemu-iotests/013                        |   1 +
>   tests/qemu-iotests/014                        |   1 +
>   tests/qemu-iotests/015                        |   1 +
>   tests/qemu-iotests/017                        |   1 +
>   tests/qemu-iotests/018                        |   1 +
>   tests/qemu-iotests/019                        |   1 +
>   tests/qemu-iotests/020                        |   1 +
>   tests/qemu-iotests/021                        |   1 +
>   tests/qemu-iotests/022                        |   1 +
>   tests/qemu-iotests/023                        |   1 +
>   tests/qemu-iotests/024                        |   1 +
>   tests/qemu-iotests/025                        |   1 +
>   tests/qemu-iotests/026                        |   1 +
>   tests/qemu-iotests/027                        |   1 +
>   tests/qemu-iotests/028                        |   1 +
>   tests/qemu-iotests/029                        |   1 +
>   tests/qemu-iotests/030                        |   1 +
>   tests/qemu-iotests/031                        |   1 +
>   tests/qemu-iotests/032                        |   1 +
>   tests/qemu-iotests/033                        |   1 +
>   tests/qemu-iotests/034                        |   1 +
>   tests/qemu-iotests/035                        |   1 +
>   tests/qemu-iotests/036                        |   1 +
>   tests/qemu-iotests/037                        |   1 +
>   tests/qemu-iotests/038                        |   1 +
>   tests/qemu-iotests/039                        |   1 +
>   tests/qemu-iotests/040                        |   1 +
>   tests/qemu-iotests/041                        |   1 +
>   tests/qemu-iotests/042                        |   1 +
>   tests/qemu-iotests/043                        |   1 +
>   tests/qemu-iotests/044                        |   1 +
>   tests/qemu-iotests/045                        |   1 +
>   tests/qemu-iotests/046                        |   1 +
>   tests/qemu-iotests/047                        |   1 +
>   tests/qemu-iotests/048                        |   1 +
>   tests/qemu-iotests/049                        |   1 +
>   tests/qemu-iotests/050                        |   1 +
>   tests/qemu-iotests/051                        |   1 +
>   tests/qemu-iotests/052                        |   1 +
>   tests/qemu-iotests/053                        |   1 +
>   tests/qemu-iotests/054                        |   1 +
>   tests/qemu-iotests/055                        |   1 +
>   tests/qemu-iotests/056                        |   1 +
>   tests/qemu-iotests/057                        |   1 +
>   tests/qemu-iotests/058                        |   1 +
>   tests/qemu-iotests/059                        |   1 +
>   tests/qemu-iotests/060                        |   1 +
>   tests/qemu-iotests/061                        |   1 +
>   tests/qemu-iotests/062                        |   1 +
>   tests/qemu-iotests/063                        |   1 +
>   tests/qemu-iotests/064                        |   1 +
>   tests/qemu-iotests/065                        |   1 +
>   tests/qemu-iotests/066                        |   1 +
>   tests/qemu-iotests/067                        |   1 +
>   tests/qemu-iotests/068                        |   1 +
>   tests/qemu-iotests/069                        |   1 +
>   tests/qemu-iotests/070                        |   1 +
>   tests/qemu-iotests/071                        |   1 +
>   tests/qemu-iotests/072                        |   1 +
>   tests/qemu-iotests/073                        |   1 +
>   tests/qemu-iotests/074                        |   1 +
>   tests/qemu-iotests/075                        |   1 +
>   tests/qemu-iotests/076                        |   1 +
>   tests/qemu-iotests/077                        |   1 +
>   tests/qemu-iotests/078                        |   1 +
>   tests/qemu-iotests/079                        |   1 +
>   tests/qemu-iotests/080                        |   1 +
>   tests/qemu-iotests/081                        |   1 +
>   tests/qemu-iotests/082                        |   1 +
>   tests/qemu-iotests/083                        |   1 +
>   tests/qemu-iotests/084                        |   1 +
>   tests/qemu-iotests/085                        |   1 +
>   tests/qemu-iotests/086                        |   1 +
>   tests/qemu-iotests/087                        |   1 +
>   tests/qemu-iotests/088                        |   1 +
>   tests/qemu-iotests/089                        |   1 +
>   tests/qemu-iotests/090                        |   1 +
>   tests/qemu-iotests/091                        |   1 +
>   tests/qemu-iotests/092                        |   1 +
>   tests/qemu-iotests/093                        |   1 +
>   tests/qemu-iotests/094                        |   1 +
>   tests/qemu-iotests/095                        |   1 +
>   tests/qemu-iotests/096                        |   1 +
>   tests/qemu-iotests/097                        |   1 +
>   tests/qemu-iotests/098                        |   1 +
>   tests/qemu-iotests/099                        |   1 +
>   tests/qemu-iotests/101                        |   1 +
>   tests/qemu-iotests/102                        |   1 +
>   tests/qemu-iotests/103                        |   1 +
>   tests/qemu-iotests/104                        |   1 +
>   tests/qemu-iotests/105                        |   1 +
>   tests/qemu-iotests/106                        |   1 +
>   tests/qemu-iotests/107                        |   1 +
>   tests/qemu-iotests/108                        |   1 +
>   tests/qemu-iotests/109                        |   1 +
>   tests/qemu-iotests/110                        |   1 +
>   tests/qemu-iotests/111                        |   1 +
>   tests/qemu-iotests/112                        |   1 +
>   tests/qemu-iotests/113                        |   1 +
>   tests/qemu-iotests/114                        |   1 +
>   tests/qemu-iotests/115                        |   1 +
>   tests/qemu-iotests/116                        |   1 +
>   tests/qemu-iotests/117                        |   1 +
>   tests/qemu-iotests/118                        |   1 +
>   tests/qemu-iotests/119                        |   1 +
>   tests/qemu-iotests/120                        |   1 +
>   tests/qemu-iotests/121                        |   1 +
>   tests/qemu-iotests/122                        |   1 +
>   tests/qemu-iotests/123                        |   1 +
>   tests/qemu-iotests/124                        |   1 +
>   tests/qemu-iotests/125                        |   1 +
>   tests/qemu-iotests/126                        |   1 +
>   tests/qemu-iotests/127                        |   1 +
>   tests/qemu-iotests/128                        |   1 +
>   tests/qemu-iotests/129                        |   1 +
>   tests/qemu-iotests/130                        |   1 +
>   tests/qemu-iotests/131                        |   1 +
>   tests/qemu-iotests/132                        |   1 +
>   tests/qemu-iotests/133                        |   1 +
>   tests/qemu-iotests/134                        |   1 +
>   tests/qemu-iotests/135                        |   1 +
>   tests/qemu-iotests/136                        |   1 +
>   tests/qemu-iotests/137                        |   1 +
>   tests/qemu-iotests/138                        |   1 +
>   tests/qemu-iotests/139                        |   1 +
>   tests/qemu-iotests/140                        |   1 +
>   tests/qemu-iotests/141                        |   1 +
>   tests/qemu-iotests/143                        |   1 +
>   tests/qemu-iotests/144                        |   1 +
>   tests/qemu-iotests/145                        |   1 +
>   tests/qemu-iotests/146                        |   1 +
>   tests/qemu-iotests/147                        |   1 +
>   tests/qemu-iotests/148                        |   1 +
>   tests/qemu-iotests/149                        |   1 +
>   tests/qemu-iotests/150                        |   1 +
>   tests/qemu-iotests/151                        |   1 +
>   tests/qemu-iotests/152                        |   1 +
>   tests/qemu-iotests/153                        |   1 +
>   tests/qemu-iotests/154                        |   1 +
>   tests/qemu-iotests/155                        |   1 +
>   tests/qemu-iotests/156                        |   1 +
>   tests/qemu-iotests/157                        |   1 +
>   tests/qemu-iotests/158                        |   1 +
>   tests/qemu-iotests/159                        |   1 +
>   tests/qemu-iotests/160                        |   1 +
>   tests/qemu-iotests/161                        |   1 +
>   tests/qemu-iotests/162                        |   1 +
>   tests/qemu-iotests/163                        |   1 +
>   tests/qemu-iotests/165                        |   1 +
>   tests/qemu-iotests/170                        |   1 +
>   tests/qemu-iotests/171                        |   1 +
>   tests/qemu-iotests/172                        |   1 +
>   tests/qemu-iotests/173                        |   1 +
>   tests/qemu-iotests/174                        |   1 +
>   tests/qemu-iotests/175                        |   1 +
>   tests/qemu-iotests/175.out                    |   2 +-
>   tests/qemu-iotests/176                        |   1 +
>   tests/qemu-iotests/177                        |   1 +
>   tests/qemu-iotests/178                        |   1 +
>   tests/qemu-iotests/179                        |   1 +
>   tests/qemu-iotests/181                        |   1 +
>   tests/qemu-iotests/182                        |   1 +
>   tests/qemu-iotests/183                        |   1 +
>   tests/qemu-iotests/184                        |   1 +
>   tests/qemu-iotests/185                        |   1 +
>   tests/qemu-iotests/186                        |   1 +
>   tests/qemu-iotests/187                        |   1 +
>   tests/qemu-iotests/188                        |   1 +
>   tests/qemu-iotests/189                        |   1 +
>   tests/qemu-iotests/190                        |   1 +
>   tests/qemu-iotests/191                        |   1 +
>   tests/qemu-iotests/192                        |   1 +
>   tests/qemu-iotests/194                        |   1 +
>   tests/qemu-iotests/195                        |   1 +
>   tests/qemu-iotests/196                        |   1 +
>   tests/qemu-iotests/197                        |   1 +
>   tests/qemu-iotests/198                        |   1 +
>   tests/qemu-iotests/200                        |   1 +
>   tests/qemu-iotests/201                        |   1 +
>   tests/qemu-iotests/202                        |   1 +
>   tests/qemu-iotests/203                        |   1 +
>   tests/qemu-iotests/204                        |   1 +
>   tests/qemu-iotests/205                        |   1 +
>   tests/qemu-iotests/206                        |   1 +
>   tests/qemu-iotests/207                        |   1 +
>   tests/qemu-iotests/208                        |   1 +
>   tests/qemu-iotests/209                        |   1 +
>   tests/qemu-iotests/210                        |   1 +
>   tests/qemu-iotests/211                        |   1 +
>   tests/qemu-iotests/212                        |   1 +
>   tests/qemu-iotests/213                        |   1 +
>   tests/qemu-iotests/214                        |   1 +
>   tests/qemu-iotests/215                        |   1 +
>   tests/qemu-iotests/216                        |   1 +
>   tests/qemu-iotests/217                        |   1 +
>   tests/qemu-iotests/218                        |   1 +
>   tests/qemu-iotests/219                        |   1 +
>   tests/qemu-iotests/220                        |   1 +
>   tests/qemu-iotests/221                        |   1 +
>   tests/qemu-iotests/222                        |   1 +
>   tests/qemu-iotests/223                        |   1 +
>   tests/qemu-iotests/224                        |   1 +
>   tests/qemu-iotests/225                        |   1 +
>   tests/qemu-iotests/226                        |   1 +
>   tests/qemu-iotests/227                        |   1 +
>   tests/qemu-iotests/228                        |   1 +
>   tests/qemu-iotests/229                        |   1 +
>   tests/qemu-iotests/231                        |   1 +
>   tests/qemu-iotests/232                        |   1 +
>   tests/qemu-iotests/233                        |   1 +
>   tests/qemu-iotests/234                        |   1 +
>   tests/qemu-iotests/235                        |   1 +
>   tests/qemu-iotests/236                        |   1 +
>   tests/qemu-iotests/237                        |   1 +
>   tests/qemu-iotests/238                        |   1 +
>   tests/qemu-iotests/239                        |   1 +
>   tests/qemu-iotests/240                        |   1 +
>   tests/qemu-iotests/241                        |   1 +
>   tests/qemu-iotests/242                        |   1 +
>   tests/qemu-iotests/243                        |   1 +
>   tests/qemu-iotests/244                        |   1 +
>   tests/qemu-iotests/245                        |   1 +
>   tests/qemu-iotests/246                        |   1 +
>   tests/qemu-iotests/247                        |   1 +
>   tests/qemu-iotests/248                        |   1 +
>   tests/qemu-iotests/249                        |   1 +
>   tests/qemu-iotests/250                        |   1 +
>   tests/qemu-iotests/251                        |   1 +
>   tests/qemu-iotests/252                        |   1 +
>   tests/qemu-iotests/253                        |   1 +
>   tests/qemu-iotests/254                        |   1 +
>   tests/qemu-iotests/255                        |   1 +
>   tests/qemu-iotests/256                        |   1 +
>   tests/qemu-iotests/257                        |   1 +
>   tests/qemu-iotests/258                        |   1 +
>   tests/qemu-iotests/259                        |   1 +
>   tests/qemu-iotests/260                        |   1 +
>   tests/qemu-iotests/261                        |   1 +
>   tests/qemu-iotests/262                        |   1 +
>   tests/qemu-iotests/263                        |   1 +
>   tests/qemu-iotests/264                        |   1 +
>   tests/qemu-iotests/265                        |   1 +
>   tests/qemu-iotests/266                        |   1 +
>   tests/qemu-iotests/267                        |   1 +
>   tests/qemu-iotests/267.out                    |  48 +-
>   tests/qemu-iotests/268                        |   1 +
>   tests/qemu-iotests/270                        |   1 +
>   tests/qemu-iotests/272                        |   1 +
>   tests/qemu-iotests/273                        |   1 +
>   tests/qemu-iotests/274                        |   1 +
>   tests/qemu-iotests/277                        |   3 +-
>   tests/qemu-iotests/279                        |   1 +
>   tests/qemu-iotests/280                        |   1 +
>   tests/qemu-iotests/281                        |   1 +
>   tests/qemu-iotests/282                        |   1 +
>   tests/qemu-iotests/283                        |   1 +
>   tests/qemu-iotests/284                        |   1 +
>   tests/qemu-iotests/286                        |   1 +
>   tests/qemu-iotests/287                        |   1 +
>   tests/qemu-iotests/287.out                    |  10 +-
>   tests/qemu-iotests/288                        |   1 +
>   tests/qemu-iotests/289                        |   1 +
>   tests/qemu-iotests/290                        |   1 +
>   tests/qemu-iotests/292                        |   1 +
>   tests/qemu-iotests/check                      | 983 +-----------------
>   tests/qemu-iotests/findtests.py               | 229 ++++
>   tests/qemu-iotests/group                      | 302 ------
>   tests/qemu-iotests/testenv.py                 | 325 ++++++
>   tests/qemu-iotests/testrunner.py              | 351 +++++++
>   .../migrate-bitmaps-postcopy-test}            |   1 +
>   .../migrate-bitmaps-postcopy-test.out}        |   0
>   .../{169 => tests/migrate-bitmaps-test}       |   1 +
>   .../migrate-bitmaps-test.out}                 |   0
>   285 files changed, 1287 insertions(+), 1289 deletions(-)
>   mode change 100644 => 100755 tests/qemu-iotests/283
>   create mode 100755 tests/qemu-iotests/findtests.py
>   delete mode 100644 tests/qemu-iotests/group
>   create mode 100755 tests/qemu-iotests/testenv.py
>   create mode 100644 tests/qemu-iotests/testrunner.py
>   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (99%)
>   rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (99%)
>   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> 


-- 
Best regards,
Vladimir

Rename bitmaps migration tests and move them to tests subdirectory to
demonstrate new human-friendly test naming.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
 .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
 tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
 tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
 4 files changed, 0 insertions(+), 0 deletions(-)
 rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
 rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
 rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
 rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)

diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
similarity index 100%
rename from tests/qemu-iotests/199
rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
similarity index 100%
rename from tests/qemu-iotests/199.out
rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
similarity index 100%
rename from tests/qemu-iotests/169
rename to tests/qemu-iotests/tests/migrate-bitmaps-test
diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
similarity index 100%
rename from tests/qemu-iotests/169.out
rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
-- 
2.21.0

On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
> Rename bitmaps migration tests and move them to tests subdirectory to
> demonstrate new human-friendly test naming.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
>  .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
>  tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
>  tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
>  4 files changed, 0 insertions(+), 0 deletions(-)
>  rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
>  rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>  rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
>  rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> 
> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> similarity index 100%
> rename from tests/qemu-iotests/199
> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> similarity index 100%
> rename from tests/qemu-iotests/199.out
> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
> similarity index 100%
> rename from tests/qemu-iotests/169
> rename to tests/qemu-iotests/tests/migrate-bitmaps-test
> diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
> similarity index 100%
> rename from tests/qemu-iotests/169.out
> rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out

I like the idea ... but the path name + file names get now quite long.
While you're at it, what about renaming the "qemu-iotests" directory to
just "iotests" or even just "io" now?

 Thomas

18.05.2020 19:12, Thomas Huth wrote:
> On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
>> Rename bitmaps migration tests and move them to tests subdirectory to
>> demonstrate new human-friendly test naming.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
>>   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
>>   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
>>   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
>>   4 files changed, 0 insertions(+), 0 deletions(-)
>>   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
>>   rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>>   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
>>   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
>>
>> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>> similarity index 100%
>> rename from tests/qemu-iotests/199
>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>> diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>> similarity index 100%
>> rename from tests/qemu-iotests/199.out
>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>> diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
>> similarity index 100%
>> rename from tests/qemu-iotests/169
>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test
>> diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
>> similarity index 100%
>> rename from tests/qemu-iotests/169.out
>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
> 
> I like the idea ... but the path name + file names get now quite long.
> While you're at it, what about renaming the "qemu-iotests" directory to
> just "iotests" or even just "io" now?

I'm for, and I remember, someone else already said about it. OK, I'll add a patch if send a next version.


-- 
Best regards,
Vladimir

Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
> On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
> > Rename bitmaps migration tests and move them to tests subdirectory to
> > demonstrate new human-friendly test naming.
> > 
> > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > ---
> >  tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
> >  .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
> >  tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
> >  tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
> >  4 files changed, 0 insertions(+), 0 deletions(-)
> >  rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
> >  rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
> >  rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
> >  rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> > 
> > diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > similarity index 100%
> > rename from tests/qemu-iotests/199
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > similarity index 100%
> > rename from tests/qemu-iotests/199.out
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
> > similarity index 100%
> > rename from tests/qemu-iotests/169
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-test
> > diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
> > similarity index 100%
> > rename from tests/qemu-iotests/169.out
> > rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
> 
> I like the idea ... but the path name + file names get now quite long.
> While you're at it, what about renaming the "qemu-iotests" directory to
> just "iotests" or even just "io" now?

Renames are always kind of painful. Do we have a real reason for the
rename except that the paths feel a bit long subjectively?

Of course, if we're renaming all files anyway, changing the directory
name at the same time shouldn't give any additional pain, so it would be
completely reasonable then. We're not renaming the test harness files,
though, and even only two test cases in this patch.

Maybe this final patch should stay RFC until we have the infrastructure
in and then we can have a single series that moves all tests and also
renames the directory? Maybe a not strictly necessary rename of the
tooling would be bearable in the context of a mass rename of tests.

Kevin

19.05.2020 12:07, Kevin Wolf wrote:
> Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
>> On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
>>> Rename bitmaps migration tests and move them to tests subdirectory to
>>> demonstrate new human-friendly test naming.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> ---
>>>   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
>>>   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
>>>   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
>>>   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
>>>   4 files changed, 0 insertions(+), 0 deletions(-)
>>>   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
>>>   rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>>>   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
>>>   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
>>>
>>> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>> similarity index 100%
>>> rename from tests/qemu-iotests/199
>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>> diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>> similarity index 100%
>>> rename from tests/qemu-iotests/199.out
>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>> diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
>>> similarity index 100%
>>> rename from tests/qemu-iotests/169
>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test
>>> diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>> similarity index 100%
>>> rename from tests/qemu-iotests/169.out
>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>
>> I like the idea ... but the path name + file names get now quite long.
>> While you're at it, what about renaming the "qemu-iotests" directory to
>> just "iotests" or even just "io" now?
> 
> Renames are always kind of painful. Do we have a real reason for the
> rename except that the paths feel a bit long subjectively?
> 
> Of course, if we're renaming all files anyway, changing the directory
> name at the same time shouldn't give any additional pain, so it would be
> completely reasonable then. We're not renaming the test harness files,
> though, and even only two test cases in this patch.
> 
> Maybe this final patch should stay RFC until we have the infrastructure
> in and then we can have a single series that moves all tests and also
> renames the directory? Maybe a not strictly necessary rename of the
> tooling would be bearable in the context of a mass rename of tests.
> 

I'm absolutely not hurrying about this thing. And actual aim of the series is another. I even doubt that we will mass rename the tests: who knows what they all test?) I don't. Still we may rename some tests, and we'll create new named tests which is good enough.. OK, if I resend a new version, I'll add an RFC patch on renaming the directory, up to maintainers, take it now or not :)

-- 
Best regards,
Vladimir

Am 19.05.2020 um 13:32 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 19.05.2020 12:07, Kevin Wolf wrote:
> > Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
> > > On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
> > > > Rename bitmaps migration tests and move them to tests subdirectory to
> > > > demonstrate new human-friendly test naming.
> > > > 
> > > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > > ---
> > > >   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
> > > >   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
> > > >   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
> > > >   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
> > > >   4 files changed, 0 insertions(+), 0 deletions(-)
> > > >   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
> > > >   rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
> > > >   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
> > > >   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
> > > > 
> > > > diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > > > similarity index 100%
> > > > rename from tests/qemu-iotests/199
> > > > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
> > > > diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > > > similarity index 100%
> > > > rename from tests/qemu-iotests/199.out
> > > > rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
> > > > diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
> > > > similarity index 100%
> > > > rename from tests/qemu-iotests/169
> > > > rename to tests/qemu-iotests/tests/migrate-bitmaps-test
> > > > diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
> > > > similarity index 100%
> > > > rename from tests/qemu-iotests/169.out
> > > > rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
> > > 
> > > I like the idea ... but the path name + file names get now quite long.
> > > While you're at it, what about renaming the "qemu-iotests" directory to
> > > just "iotests" or even just "io" now?
> > 
> > Renames are always kind of painful. Do we have a real reason for the
> > rename except that the paths feel a bit long subjectively?
> > 
> > Of course, if we're renaming all files anyway, changing the directory
> > name at the same time shouldn't give any additional pain, so it would be
> > completely reasonable then. We're not renaming the test harness files,
> > though, and even only two test cases in this patch.
> > 
> > Maybe this final patch should stay RFC until we have the infrastructure
> > in and then we can have a single series that moves all tests and also
> > renames the directory? Maybe a not strictly necessary rename of the
> > tooling would be bearable in the context of a mass rename of tests.
> 
> I'm absolutely not hurrying about this thing. And actual aim of the
> series is another. I even doubt that we will mass rename the tests:
> who knows what they all test?) I don't.

Good point.

And conversely, there are a few test cases that I do know (like 026 030
040 041 055) and probably wouldn't recognise for a while after a rename.
:-)

> Still we may rename some tests, and we'll create new named tests which
> is good enough.. OK, if I resend a new version, I'll add an RFC patch
> on renaming the directory, up to maintainers, take it now or not :)

I guess a final patch to rename the directory as an RFC makes sense.
Then we can continue the discussion there and decide whether or not to
apply it without holding up the rest of the series.

I think I would be inclined to leave the name unchanged as long as we
don't have a real reason, but if people overwhelmingly think otherwise,
we can still rename.

Kevin

On 5/19/20 7:41 AM, Kevin Wolf wrote:
> Am 19.05.2020 um 13:32 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> 19.05.2020 12:07, Kevin Wolf wrote:
>>> Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
>>>> On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
>>>>> Rename bitmaps migration tests and move them to tests subdirectory to
>>>>> demonstrate new human-friendly test naming.
>>>>>
>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>> ---
>>>>>   tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
>>>>>   .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
>>>>>   tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
>>>>>   tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
>>>>>   4 files changed, 0 insertions(+), 0 deletions(-)
>>>>>   rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
>>>>>   rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>>>>>   rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
>>>>>   rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
>>>>>
>>>>> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>>>> similarity index 100%
>>>>> rename from tests/qemu-iotests/199
>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>>>> diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>>>> similarity index 100%
>>>>> rename from tests/qemu-iotests/199.out
>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>>>> diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
>>>>> similarity index 100%
>>>>> rename from tests/qemu-iotests/169
>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test
>>>>> diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>>>> similarity index 100%
>>>>> rename from tests/qemu-iotests/169.out
>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>>>
>>>> I like the idea ... but the path name + file names get now quite long.
>>>> While you're at it, what about renaming the "qemu-iotests" directory to
>>>> just "iotests" or even just "io" now?
>>>
>>> Renames are always kind of painful. Do we have a real reason for the
>>> rename except that the paths feel a bit long subjectively?
>>>
>>> Of course, if we're renaming all files anyway, changing the directory
>>> name at the same time shouldn't give any additional pain, so it would be
>>> completely reasonable then. We're not renaming the test harness files,
>>> though, and even only two test cases in this patch.
>>>
>>> Maybe this final patch should stay RFC until we have the infrastructure
>>> in and then we can have a single series that moves all tests and also
>>> renames the directory? Maybe a not strictly necessary rename of the
>>> tooling would be bearable in the context of a mass rename of tests.
>>
>> I'm absolutely not hurrying about this thing. And actual aim of the
>> series is another. I even doubt that we will mass rename the tests:
>> who knows what they all test?) I don't.
> 
> Good point.
> 
> And conversely, there are a few test cases that I do know (like 026 030
> 040 041 055) and probably wouldn't recognise for a while after a rename.
> :-)
> 
>> Still we may rename some tests, and we'll create new named tests which
>> is good enough.. OK, if I resend a new version, I'll add an RFC patch
>> on renaming the directory, up to maintainers, take it now or not :)
> 
> I guess a final patch to rename the directory as an RFC makes sense.
> Then we can continue the discussion there and decide whether or not to
> apply it without holding up the rest of the series.
> 
> I think I would be inclined to leave the name unchanged as long as we
> don't have a real reason, but if people overwhelmingly think otherwise,
> we can still rename.
> 

It's a pinch long, but it's not a big ordeal. I wouldn't object to
.tests/io as long as all of the renames happened all at once.

I'll admit to not having read the series, but I will miss the ability to
specify ranges of tests. I'm not sure how that happens under the new
proposal; but I think it's a strict improvement to give the tests human
readable names in the filesystem.

--js

21.05.2020 21:32, John Snow wrote:
> 
> 
> On 5/19/20 7:41 AM, Kevin Wolf wrote:
>> Am 19.05.2020 um 13:32 hat Vladimir Sementsov-Ogievskiy geschrieben:
>>> 19.05.2020 12:07, Kevin Wolf wrote:
>>>> Am 18.05.2020 um 18:12 hat Thomas Huth geschrieben:
>>>>> On 15/05/2020 23.15, Vladimir Sementsov-Ogievskiy wrote:
>>>>>> Rename bitmaps migration tests and move them to tests subdirectory to
>>>>>> demonstrate new human-friendly test naming.
>>>>>>
>>>>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>>>>> ---
>>>>>>    tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test}   | 0
>>>>>>    .../{199.out => tests/migrate-bitmaps-postcopy-test.out}          | 0
>>>>>>    tests/qemu-iotests/{169 => tests/migrate-bitmaps-test}            | 0
>>>>>>    tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out}    | 0
>>>>>>    4 files changed, 0 insertions(+), 0 deletions(-)
>>>>>>    rename tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} (100%)
>>>>>>    rename tests/qemu-iotests/{199.out => tests/migrate-bitmaps-postcopy-test.out} (100%)
>>>>>>    rename tests/qemu-iotests/{169 => tests/migrate-bitmaps-test} (100%)
>>>>>>    rename tests/qemu-iotests/{169.out => tests/migrate-bitmaps-test.out} (100%)
>>>>>>
>>>>>> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>>>>> similarity index 100%
>>>>>> rename from tests/qemu-iotests/199
>>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
>>>>>> diff --git a/tests/qemu-iotests/199.out b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>>>>> similarity index 100%
>>>>>> rename from tests/qemu-iotests/199.out
>>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test.out
>>>>>> diff --git a/tests/qemu-iotests/169 b/tests/qemu-iotests/tests/migrate-bitmaps-test
>>>>>> similarity index 100%
>>>>>> rename from tests/qemu-iotests/169
>>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test
>>>>>> diff --git a/tests/qemu-iotests/169.out b/tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>>>>> similarity index 100%
>>>>>> rename from tests/qemu-iotests/169.out
>>>>>> rename to tests/qemu-iotests/tests/migrate-bitmaps-test.out
>>>>>
>>>>> I like the idea ... but the path name + file names get now quite long.
>>>>> While you're at it, what about renaming the "qemu-iotests" directory to
>>>>> just "iotests" or even just "io" now?
>>>>
>>>> Renames are always kind of painful. Do we have a real reason for the
>>>> rename except that the paths feel a bit long subjectively?
>>>>
>>>> Of course, if we're renaming all files anyway, changing the directory
>>>> name at the same time shouldn't give any additional pain, so it would be
>>>> completely reasonable then. We're not renaming the test harness files,
>>>> though, and even only two test cases in this patch.
>>>>
>>>> Maybe this final patch should stay RFC until we have the infrastructure
>>>> in and then we can have a single series that moves all tests and also
>>>> renames the directory? Maybe a not strictly necessary rename of the
>>>> tooling would be bearable in the context of a mass rename of tests.
>>>
>>> I'm absolutely not hurrying about this thing. And actual aim of the
>>> series is another. I even doubt that we will mass rename the tests:
>>> who knows what they all test?) I don't.
>>
>> Good point.
>>
>> And conversely, there are a few test cases that I do know (like 026 030
>> 040 041 055) and probably wouldn't recognise for a while after a rename.
>> :-)
>>
>>> Still we may rename some tests, and we'll create new named tests which
>>> is good enough.. OK, if I resend a new version, I'll add an RFC patch
>>> on renaming the directory, up to maintainers, take it now or not :)
>>
>> I guess a final patch to rename the directory as an RFC makes sense.
>> Then we can continue the discussion there and decide whether or not to
>> apply it without holding up the rest of the series.
>>
>> I think I would be inclined to leave the name unchanged as long as we
>> don't have a real reason, but if people overwhelmingly think otherwise,
>> we can still rename.
>>
> 
> It's a pinch long, but it's not a big ordeal. I wouldn't object to
> .tests/io as long as all of the renames happened all at once.
> 
> I'll admit to not having read the series, but I will miss the ability to
> specify ranges of tests. I'm not sure how that happens under the new
> proposal; but I think it's a strict improvement to give the tests human
> readable names in the filesystem.
> 

Hmm. Actually, I think, it's not a problem to continue support ranges of tests for number test names, if you need it.

Note a new paramter --start-from, which is here to re-run failed  ./check run from the middle of the process, is it your use-case or not?


-- 
Best regards,
Vladimir

On 5/27/20 2:50 PM, Vladimir Sementsov-Ogievskiy wrote:
> 
> Hmm. Actually, I think, it's not a problem to continue support ranges of
> tests for number test names, if you need it.
> 
> Note a new paramter --start-from, which is here to re-run failed 
> ./check run from the middle of the process, is it your use-case or not?

Yeah, that'll solve that for me! I pretty much care only about excluding
tests sometimes, and running ranges was just a way to do that.