[PATCH v2 2/5] tests/vm: Remove flex/bison packages

Philippe Mathieu-Daudé posted 5 patches 5 years, 6 months ago
[PATCH v2 2/5] tests/vm: Remove flex/bison packages
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago
QEMU does not use flex/bison packages.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: use 'does not', removed bison in OpenBSD VM (Claudio)
---
 tests/vm/fedora      | 1 -
 tests/vm/freebsd     | 1 -
 tests/vm/netbsd      | 1 -
 tests/vm/openbsd     | 1 -
 tests/vm/ubuntu.i386 | 2 +-
 5 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/tests/vm/fedora b/tests/vm/fedora
index bd9c6cf295..a9195670f4 100755
--- a/tests/vm/fedora
+++ b/tests/vm/fedora
@@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM):
     pkgs = [
         # tools
         'git-core',
-        'flex', 'bison',
         'gcc', 'binutils', 'make',
 
         # perl
diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index 298967fe9c..f87db2b126 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM):
         "bash",
         "gmake",
         "gsed",
-        "flex", "bison",
 
         # libs: crypto
         "gnutls",
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index b10c9d429d..cdac502dad 100755
--- a/tests/vm/netbsd
+++ b/tests/vm/netbsd
@@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM):
         "bash",
         "gmake",
         "gsed",
-        "flex", "bison",
 
         # libs: crypto
         "gnutls",
diff --git a/tests/vm/openbsd b/tests/vm/openbsd
index 0b705f4945..13e7f9a6d5 100755
--- a/tests/vm/openbsd
+++ b/tests/vm/openbsd
@@ -35,7 +35,6 @@ class OpenBSDVM(basevm.BaseVM):
         "bash",
         "gmake",
         "gsed",
-        "bison",
 
         # libs: usb
         "libusb1",
diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
index 1570775335..24527cc78c 100755
--- a/tests/vm/ubuntu.i386
+++ b/tests/vm/ubuntu.i386
@@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM):
         self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list")
         self.ssh_root_check("apt-get update")
         self.ssh_root_check("apt-get build-dep -y qemu")
-        self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en")
+        self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en")
         self.ssh_root("poweroff")
         self.wait()
         os.rename(img_tmp, img)
-- 
2.21.3


Re: [PATCH v2 2/5] tests/vm: Remove flex/bison packages
Posted by Claudio Fontana 5 years, 6 months ago
On 5/15/20 6:30 PM, Philippe Mathieu-Daudé wrote:
> QEMU does not use flex/bison packages.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: use 'does not', removed bison in OpenBSD VM (Claudio)
> ---
>  tests/vm/fedora      | 1 -
>  tests/vm/freebsd     | 1 -
>  tests/vm/netbsd      | 1 -
>  tests/vm/openbsd     | 1 -
>  tests/vm/ubuntu.i386 | 2 +-
>  5 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/tests/vm/fedora b/tests/vm/fedora
> index bd9c6cf295..a9195670f4 100755
> --- a/tests/vm/fedora
> +++ b/tests/vm/fedora
> @@ -32,7 +32,6 @@ class FedoraVM(basevm.BaseVM):
>      pkgs = [
>          # tools
>          'git-core',
> -        'flex', 'bison',
>          'gcc', 'binutils', 'make',
>  
>          # perl
> diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index 298967fe9c..f87db2b126 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -38,7 +38,6 @@ class FreeBSDVM(basevm.BaseVM):
>          "bash",
>          "gmake",
>          "gsed",
> -        "flex", "bison",
>  
>          # libs: crypto
>          "gnutls",
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index b10c9d429d..cdac502dad 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -36,7 +36,6 @@ class NetBSDVM(basevm.BaseVM):
>          "bash",
>          "gmake",
>          "gsed",
> -        "flex", "bison",
>  
>          # libs: crypto
>          "gnutls",
> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> index 0b705f4945..13e7f9a6d5 100755
> --- a/tests/vm/openbsd
> +++ b/tests/vm/openbsd
> @@ -35,7 +35,6 @@ class OpenBSDVM(basevm.BaseVM):
>          "bash",
>          "gmake",
>          "gsed",
> -        "bison",
>  
>          # libs: usb
>          "libusb1",
> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
> index 1570775335..24527cc78c 100755
> --- a/tests/vm/ubuntu.i386
> +++ b/tests/vm/ubuntu.i386
> @@ -52,7 +52,7 @@ class UbuntuX86VM(basevm.BaseVM):
>          self.ssh_root_check("sed -ie s/^#\ deb-src/deb-src/g /etc/apt/sources.list")
>          self.ssh_root_check("apt-get update")
>          self.ssh_root_check("apt-get build-dep -y qemu")
> -        self.ssh_root_check("apt-get install -y libfdt-dev flex bison language-pack-en")
> +        self.ssh_root_check("apt-get install -y libfdt-dev language-pack-en")
>          self.ssh_root("poweroff")
>          self.wait()
>          os.rename(img_tmp, img)
> 
Reviewed-by: Claudio Fontana <cfontana@suse.de>