The documentation for the s390x system emulation target still has quite
a bit of room for improvement, so I started adding some device documentation.

v1->v2:
- css.rst: added example for cssid == 0 (Thomas)
- css.rst: mention what the properties look like (Thomas)
- css.rst: it's "channel subsystem image" (me)
- 3270.rst: make introduction less confusing (Thomas)
- 3270.rst: fix device name (Thomas)
- 3270.rst: use unprivileged port (Thomas)
- vfio-ccw.rst: add mdevctl example (Thomas)
- vfio-ccw.rst: formatting tweaks (Thomas)

Cornelia Huck (3):
  docs/s390x: document the virtual css
  docs/s390x: document 3270
  docs/s390x: document vfio-ccw

 docs/system/s390x/3270.rst     | 32 +++++++++++++
 docs/system/s390x/css.rst      | 86 ++++++++++++++++++++++++++++++++++
 docs/system/s390x/vfio-ccw.rst | 72 ++++++++++++++++++++++++++++
 docs/system/target-s390x.rst   |  3 ++
 4 files changed, 193 insertions(+)
 create mode 100644 docs/system/s390x/3270.rst
 create mode 100644 docs/system/s390x/css.rst
 create mode 100644 docs/system/s390x/vfio-ccw.rst

-- 
2.25.4

Patchew URL: https://patchew.org/QEMU/20200515151518.83950-1-cohuck@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200515151518.83950-1-cohuck@redhat.com
Subject: [PATCH v2 0/3] s390x: improve documentation
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
eeaa1c2 docs/s390x: document vfio-ccw
f2e7e9f docs/s390x: document 3270
d96751b docs/s390x: document the virtual css

=== OUTPUT BEGIN ===
1/3 Checking commit d96751bf382a (docs/s390x: document the virtual css)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 93 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit f2e7e9fed702 (docs/s390x: document 3270)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 39 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit eeaa1c2251e5 (docs/s390x: document vfio-ccw)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: trailing whitespace
#78: FILE: docs/system/s390x/vfio-ccw.rst:61:
+    Device   Subchan.  DevType CU Type Use  PIM PAM POM  CHPIDs           $

total: 1 errors, 1 warnings, 79 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200515151518.83950-1-cohuck@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

On Fri, 15 May 2020 17:15:15 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> The documentation for the s390x system emulation target still has quite
> a bit of room for improvement, so I started adding some device documentation.
> 
> v1->v2:
> - css.rst: added example for cssid == 0 (Thomas)
> - css.rst: mention what the properties look like (Thomas)
> - css.rst: it's "channel subsystem image" (me)
> - 3270.rst: make introduction less confusing (Thomas)
> - 3270.rst: fix device name (Thomas)
> - 3270.rst: use unprivileged port (Thomas)
> - vfio-ccw.rst: add mdevctl example (Thomas)
> - vfio-ccw.rst: formatting tweaks (Thomas)
> 
> Cornelia Huck (3):
>   docs/s390x: document the virtual css
>   docs/s390x: document 3270
>   docs/s390x: document vfio-ccw
> 
>  docs/system/s390x/3270.rst     | 32 +++++++++++++
>  docs/system/s390x/css.rst      | 86 ++++++++++++++++++++++++++++++++++
>  docs/system/s390x/vfio-ccw.rst | 72 ++++++++++++++++++++++++++++
>  docs/system/target-s390x.rst   |  3 ++
>  4 files changed, 193 insertions(+)
>  create mode 100644 docs/system/s390x/3270.rst
>  create mode 100644 docs/system/s390x/css.rst
>  create mode 100644 docs/system/s390x/vfio-ccw.rst
> 

Queued patches 1/2, will send an update to patch 3.