qom/object: simplify type_initialize_interface()

[PATCH] qom/object: simplify type_initialize_interface()

Masahiro Yamada posted 1 patch 4 years ago

Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200512182501.2300530-1-masahiroy@kernel.org

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>

qom/object.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] qom/object: simplify type_initialize_interface()

Posted by Masahiro Yamada 4 years ago

iface_impl->class is the same as new_iface. Make it more readable.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 qom/object.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/qom/object.c b/qom/object.c
index 9d1a918e42..75c628591d 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
     new_iface->concrete_class = ti->class;
     new_iface->interface_type = interface_type;
 
-    ti->class->interfaces = g_slist_append(ti->class->interfaces,
-                                           iface_impl->class);
+    ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
 }
 
 static void object_property_free(gpointer data)
-- 
2.25.1

Re: [PATCH] qom/object: simplify type_initialize_interface()

Posted by Paolo Bonzini 3 years, 12 months ago

On 12/05/20 20:25, Masahiro Yamada wrote:
> iface_impl->class is the same as new_iface. Make it more readable.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
>  qom/object.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qom/object.c b/qom/object.c
> index 9d1a918e42..75c628591d 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -262,8 +262,7 @@ static void type_initialize_interface(TypeImpl *ti, TypeImpl *interface_type,
>      new_iface->concrete_class = ti->class;
>      new_iface->interface_type = interface_type;
>  
> -    ti->class->interfaces = g_slist_append(ti->class->interfaces,
> -                                           iface_impl->class);
> +    ti->class->interfaces = g_slist_append(ti->class->interfaces, new_iface);
>  }
>  
>  static void object_property_free(gpointer data)
> 

Queued, thanks.

Paolo